Inspection of "news" - gggeek/phpxmlrpc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bb780a...ebcf65 )

by Gaetano

created 2023-01-23 12:43 UTC

Status

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -176,8 +176,7 @@
 block discarded – undo
                         } else {
                             $escapedData .= $ch;
                         }
-                    }
-                    else if ($ii < 128) {
+                    } else if ($ii < 128) {
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
                         switch ($ii) {

Please login to merge, or discard this patch.

demo/server/methodProviders/testsuite.php 1 patch

Braces +6 added lines, -5 removed lines patch added patch discarded remove patch

@@ -66,11 +66,12 @@
 block discarded – undo
     $a = $req->getParam(0);
     $b = $req->getParam(1);
 
-    if ($a->scalartyp() == Value::$xmlrpcNull)
-        return new Response(new Value(plain_findstate($b->scalarval())));
-    else
-        return new Response(new Value(plain_findstate($a->scalarval())));
-}
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
+            return new Response(new Value(plain_findstate($b->scalarval())));
+    } else {
+            return new Response(new Value(plain_findstate($a->scalarval())));
+    }
+    }
 
 return array(
     "tests.getallheaders" => array(

Please login to merge, or discard this patch.

debugger/action.php 1 patch

Braces +9 added lines, -2 removed lines patch added patch discarded remove patch

@@ -15,7 +15,12 @@  discard block
 block discarded – undo
 <html lang="en">
 <head>
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
+    echo 'JSON-RPC';
+} else {
+    echo 'XML-RPC';
+}
+?> Debugger</title>
     <meta name="robots" content="index,nofollow"/>
     <style type="text/css">
         <!--
@@ -367,7 +372,9 @@  discard block
 block discarded – undo
                                 echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
                                 if ($x->count() > 1) {
                                     foreach($x as $k => $y) {
-                                        if ($k == 0) continue;
+                                        if ($k == 0) {
+                                            continue;
+                                        }
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
                                         if ($wstype == 1) {
                                             switch($y->scalarval()) {

Please login to merge, or discard this patch.

debugger/index.php 1 patch

Braces +6 added lines, -1 removed lines patch added patch discarded remove patch

@@ -13,7 +13,12 @@
 block discarded – undo
 <html lang="en">
 <head>
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
+    echo 'JSON-RPC';
+} else {
+    echo 'XML-RPC';
+}
+?> Debugger</title>
 </head>
 <frameset rows="360,*">
     <frame name="frmcontroller" src="controller.php<?php echo htmlspecialchars($query); ?>" marginwidth="0"

Please login to merge, or discard this patch.

debugger/controller.php 1 patch

Braces +16 added lines, -4 removed lines patch added patch discarded remove patch

@@ -66,7 +66,12 @@  discard block
 block discarded – undo
 <html lang="en">
 <head>
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
+    echo 'JSON-RPC';
+} else {
+    echo 'XML-RPC';
+}
+?> Debugger</title>
     <meta name="robots" content="index,nofollow"/>
     <script type="text/javascript" language="Javascript">
         if (window.name != 'frmcontroller')
@@ -266,19 +271,26 @@  discard block
 block discarded – undo
     </script>
 </head>
 <body
-    onload="<?php if ($hasjsonrpcclient) echo "switchtransport($wstype); " ?>switchaction(); switchssl(); switchauth(); swicthcainfo();<?php if ($run) {
+    onload="<?php if ($hasjsonrpcclient) {
+    echo "switchtransport($wstype); " ?>switchaction(); switchssl(); switchauth(); swicthcainfo();<?php if ($run) {
         echo ' document.frmaction.submit();';
+}
     } ?>">
 <h1>XML-RPC
 <?php if ($hasjsonrpcclient) {
     echo '<form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);"';
     // q: does this if make sense at all?
-    if (!class_exists('\PhpXmlRpc\Client')) echo ' disabled="disabled"';
+    if (!class_exists('\PhpXmlRpc\Client')) {
+        echo ' disabled="disabled"';
+    }
     echo ' /></form> / <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);"/></form>
     JSON-RPC';
 } ?>
 Debugger</h1><h3>(based on <a href="https://gggeek.github.io/phpxmlrpc/">PHPXMLRPC</a>, ver. <?php echo htmlspecialchars(\PhpXmlRpc\PhpXmlRpc::$xmlrpcVersion)?>
-<?php if (class_exists('\PhpXmlRpc\JsonRpc\PhpJsonRpc')) echo ' and <a href="https://gggeek.github.io/phpxmlrpc-jsonrpc/">PHPJOSNRPC</a>, ver. ' . htmlspecialchars(\PhpXmlRpc\JsonRpc\PhpJsonRpc::$jsonrpcVersion); ?>)</h3>
+<?php if (class_exists('\PhpXmlRpc\JsonRpc\PhpJsonRpc')) {
+    echo ' and <a href="https://gggeek.github.io/phpxmlrpc-jsonrpc/">PHPJOSNRPC</a>, ver. ' . htmlspecialchars(\PhpXmlRpc\JsonRpc\PhpJsonRpc::$jsonrpcVersion);
+}
+?>)</h3>
 <form name="frmaction" method="get" action="action.php" target="frmaction" onSubmit="switchFormMethod();">
 
     <table id="serverblock">

Please login to merge, or discard this patch.

src/Wrapper.php 1 patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -605,8 +605,9 @@
 block discarded – undo
         }
         foreach ($parsVariations as $i => $pars) {
             $innerCode .= "  if (\$paramCount == " . count($pars) . ") \$retVal = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
-            if ($i < (count($parsVariations) - 1))
-                $innerCode .= "  else\n";
+            if ($i < (count($parsVariations) - 1)) {
+                            $innerCode .= "  else\n";
+            }
         }
         $innerCode .= "  if (is_a(\$retVal, '" . static::$namespace . "Response'))\n    return \$retVal;\n  else\n";
         /// q: why not do the same for int, float, bool, string?

Please login to merge, or discard this patch.

tests/06EncoderTest.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -21,14 +21,16 @@
 block discarded – undo
     protected function set_up()
     {
         $this->args = argParser::getArgs();
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tear_down()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == BaseTestRunner::STATUS_ERROR

Please login to merge, or discard this patch.

tests/07ClientTest.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -24,14 +24,16 @@
 block discarded – undo
         $this->client = new xmlrpc_client('/NOTEXIST.php', $this->args['HTTPSERVER'], 80);
         $this->client->setDebug($this->args['DEBUG']);
 
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tear_down()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == BaseTestRunner::STATUS_ERROR

Please login to merge, or discard this patch.

tests/08ServerTest.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -108,14 +108,16 @@
 block discarded – undo
 
         $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']);
 
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tear_down()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == BaseTestRunner::STATUS_ERROR

Please login to merge, or discard this patch.

		@@ -176,8 +176,7 @@
		block discarded – undo
176	176	} else {
177	177	$escapedData .= $ch;
178	178	}
179		- }
180		- else if ($ii < 128) {
	179	+ } else if ($ii < 128) {
181	180	/// @todo shall we replace this with a (supposedly) faster str_replace?
182	181	/// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
183	182	switch ($ii) {

		@@ -605,8 +605,9 @@
		block discarded – undo
605	605	}
606	606	foreach ($parsVariations as $i => $pars) {
607	607	$innerCode .= " if (\$paramCount == " . count($pars) . ") \$retVal = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
608		- if ($i < (count($parsVariations) - 1))
609		- $innerCode .= " else\n";
	608	+ if ($i < (count($parsVariations) - 1)) {
	609	+ $innerCode .= " else\n";
	610	+ }
610	611	}
611	612	$innerCode .= " if (is_a(\$retVal, '" . static::$namespace . "Response'))\n return \$retVal;\n else\n";
612	613	/// q: why not do the same for int, float, bool, string?

		@@ -108,14 +108,16 @@
		block discarded – undo
108	108
109	109	$this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('\|/tests/index\.php(\?.*)?\|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']);
110	110
111		- if ($this->args['DEBUG'] == 1)
112		- ob_start();
	111	+ if ($this->args['DEBUG'] == 1) {
	112	+ ob_start();
	113	+ }
113	114	}
114	115
115	116	protected function tear_down()
116	117	{
117		- if ($this->args['DEBUG'] != 1)
118		- return;
	118	+ if ($this->args['DEBUG'] != 1) {
	119	+ return;
	120	+ }
119	121	$out = ob_get_clean();
120	122	$status = $this->getStatus();
121	123	if ($status == BaseTestRunner::STATUS_ERROR

		@@ -66,11 +66,12 @@
		block discarded – undo
66	66	$a = $req->getParam(0);
67	67	$b = $req->getParam(1);
68	68
69		- if ($a->scalartyp() == Value::$xmlrpcNull)
70		- return new Response(new Value(plain_findstate($b->scalarval())));
71		- else
72		- return new Response(new Value(plain_findstate($a->scalarval())));
73		-}
	69	+ if ($a->scalartyp() == Value::$xmlrpcNull) {
	70	+ return new Response(new Value(plain_findstate($b->scalarval())));
	71	+ } else {
	72	+ return new Response(new Value(plain_findstate($a->scalarval())));
	73	+ }
	74	+ }
74	75
75	76	return array(
76	77	"tests.getallheaders" => array(

		@@ -15,7 +15,12 @@ discard block
		block discarded – undo
15	15	<html lang="en">
16	16	<head>
17	17	<link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
18		- <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
	18	+ <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
	19	+ echo 'JSON-RPC';
	20	+} else {
	21	+ echo 'XML-RPC';
	22	+}
	23	+?> Debugger</title>
19	24	<meta name="robots" content="index,nofollow"/>
20	25	<style type="text/css">
21	26	<!--
		@@ -367,7 +372,9 @@ discard block
		block discarded – undo
367	372	echo "<code>OUT: " . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
368	373	if ($x->count() > 1) {
369	374	foreach($x as $k => $y) {
370		- if ($k == 0) continue;
	375	+ if ($k == 0) {
	376	+ continue;
	377	+ }
371	378	echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
372	379	if ($wstype == 1) {
373	380	switch($y->scalarval()) {

		@@ -13,7 +13,12 @@
		block discarded – undo
13	13	<html lang="en">
14	14	<head>
15	15	<link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
16		- <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
	16	+ <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
	17	+ echo 'JSON-RPC';
	18	+} else {
	19	+ echo 'XML-RPC';
	20	+}
	21	+?> Debugger</title>
17	22	</head>
18	23	<frameset rows="360,*">
19	24	<frame name="frmcontroller" src="controller.php<?php echo htmlspecialchars($query); ?>" marginwidth="0"

		@@ -66,7 +66,12 @@ discard block
		block discarded – undo
66	66	<html lang="en">
67	67	<head>
68	68	<link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
69		- <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
	69	+ <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
	70	+ echo 'JSON-RPC';
	71	+} else {
	72	+ echo 'XML-RPC';
	73	+}
	74	+?> Debugger</title>
70	75	<meta name="robots" content="index,nofollow"/>
71	76	<script type="text/javascript" language="Javascript">
72	77	if (window.name != 'frmcontroller')
		@@ -266,19 +271,26 @@ discard block
		block discarded – undo
266	271	</script>
267	272	</head>
268	273	<body
269		- onload="<?php if ($hasjsonrpcclient) echo "switchtransport($wstype); " ?>switchaction(); switchssl(); switchauth(); swicthcainfo();<?php if ($run) {
	274	+ onload="<?php if ($hasjsonrpcclient) {
	275	+ echo "switchtransport($wstype); " ?>switchaction(); switchssl(); switchauth(); swicthcainfo();<?php if ($run) {
270	276	echo ' document.frmaction.submit();';
	277	+}
271	278	} ?>">
272	279	<h1>XML-RPC
273	280	<?php if ($hasjsonrpcclient) {
274	281	echo '<form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);"';
275	282	// q: does this if make sense at all?
276		- if (!class_exists('\PhpXmlRpc\Client')) echo ' disabled="disabled"';
	283	+ if (!class_exists('\PhpXmlRpc\Client')) {
	284	+ echo ' disabled="disabled"';
	285	+ }
277	286	echo ' /></form> / <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);"/></form>
278	287	JSON-RPC';
279	288	} ?>
280	289	Debugger</h1><h3>(based on <a href="https://gggeek.github.io/phpxmlrpc/">PHPXMLRPC</a>, ver. <?php echo htmlspecialchars(\PhpXmlRpc\PhpXmlRpc::$xmlrpcVersion)?>
281		-<?php if (class_exists('\PhpXmlRpc\JsonRpc\PhpJsonRpc')) echo ' and <a href="https://gggeek.github.io/phpxmlrpc-jsonrpc/">PHPJOSNRPC</a>, ver. ' . htmlspecialchars(\PhpXmlRpc\JsonRpc\PhpJsonRpc::$jsonrpcVersion); ?>)</h3>
	290	+<?php if (class_exists('\PhpXmlRpc\JsonRpc\PhpJsonRpc')) {
	291	+ echo ' and <a href="https://gggeek.github.io/phpxmlrpc-jsonrpc/">PHPJOSNRPC</a>, ver. ' . htmlspecialchars(\PhpXmlRpc\JsonRpc\PhpJsonRpc::$jsonrpcVersion);
	292	+}
	293	+?>)</h3>
282	294	<form name="frmaction" method="get" action="action.php" target="frmaction" onSubmit="switchFormMethod();">
283	295
284	296	<table id="serverblock">

		@@ -21,14 +21,16 @@
		block discarded – undo
21	21	protected function set_up()
22	22	{
23	23	$this->args = argParser::getArgs();
24		- if ($this->args['DEBUG'] == 1)
25		- ob_start();
	24	+ if ($this->args['DEBUG'] == 1) {
	25	+ ob_start();
	26	+ }
26	27	}
27	28
28	29	protected function tear_down()
29	30	{
30		- if ($this->args['DEBUG'] != 1)
31		- return;
	31	+ if ($this->args['DEBUG'] != 1) {
	32	+ return;
	33	+ }
32	34	$out = ob_get_clean();
33	35	$status = $this->getStatus();
34	36	if ($status == BaseTestRunner::STATUS_ERROR

		@@ -24,14 +24,16 @@
		block discarded – undo
24	24	$this->client = new xmlrpc_client('/NOTEXIST.php', $this->args['HTTPSERVER'], 80);
25	25	$this->client->setDebug($this->args['DEBUG']);
26	26
27		- if ($this->args['DEBUG'] == 1)
28		- ob_start();
	27	+ if ($this->args['DEBUG'] == 1) {
	28	+ ob_start();
	29	+ }
29	30	}
30	31
31	32	protected function tear_down()
32	33	{
33		- if ($this->args['DEBUG'] != 1)
34		- return;
	34	+ if ($this->args['DEBUG'] != 1) {
	35	+ return;
	36	+ }
35	37	$out = ob_get_clean();
36	38	$status = $this->getStatus();
37	39	if ($status == BaseTestRunner::STATUS_ERROR

gggeek / phpxmlrpc

Push — master ( bb780a...ebcf65 )

Status

Category

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -5 removed lines patch added patch discarded remove patch

Braces +9 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -1 removed lines patch added patch discarded remove patch

Braces +16 added lines, -4 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch