gggeek / phpxmlrpc

pakefile.php

Braces +7 added lines, -6 removed lines

@@ -27,8 +27,9 @@ 
 
     public static function libVersion()
     {
-        if (self::$libVersion == null)
-            throw new \Exception('Missing library version argument');
+        if (self::$libVersion == null) {
+                    throw new \Exception('Missing library version argument');
+        }
         return self::$libVersion;
     }
 
@@ -59,9 +60,10 @@ 
 
     public static function getOpts($args=array(), $cliOpts=array())
     {
-        if (count($args) > 0)
-        //    throw new \Exception('Missing library version argument');
+        if (count($args) > 0) {
+                //    throw new \Exception('Missing library version argument');
             self::$libVersion = $args[0];
+        }
 
         foreach (self::$tools as $name => $binary) {
             if (isset($cliOpts[$name])) {
@@ -338,8 +340,7 @@ 
             $cmd = Builder::tool('zip');
             $extra = '-9 -r';
             pake_sh("$cmd $distFile $extra ".basename(Builder::distDir()));
-        }
-        else {
+        } else {
             $finder = pakeFinder::type('any')->pattern(basename(Builder::distDir()).'/**');
             // see https://bugs.php.net/bug.php?id=58852
             $pharFile = str_replace(Builder::libVersion(), '_LIBVERSION_', $distFile);

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * Makefile for phpxmlrpc library.
- * To be used with the Pake tool: https://github.com/indeyets/pake/wiki
- *
- * @copyright (c) 2015 G. Giunta
- *
- * @todo !important allow user to specify location of docbook xslt instead of the one installed via composer
- */
+     * Makefile for phpxmlrpc library.
+     * To be used with the Pake tool: https://github.com/indeyets/pake/wiki
+     *
+     * @copyright (c) 2015 G. Giunta
+     *
+     * @todo !important allow user to specify location of docbook xslt instead of the one installed via composer
+     */
 
 namespace PhpXmlRpc {
 

debugger/action.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * @author Gaetano Giunta
- * @copyright (C) 2005-2015 G. Giunta
- * @license code licensed under the BSD License: see file license.txt
- *
- * @todo switch params for http compression from 0,1,2 to values to be used directly
- * @todo use ob_start to catch debug info and echo it AFTER method call results?
- * @todo be smarter in creating client stub for proxy/auth cases: only set appropriate property of client obj
- **/
+     * @author Gaetano Giunta
+     * @copyright (C) 2005-2015 G. Giunta
+     * @license code licensed under the BSD License: see file license.txt
+     *
+     * @todo switch params for http compression from 0,1,2 to values to be used directly
+     * @todo use ob_start to catch debug info and echo it AFTER method call results?
+     * @todo be smarter in creating client stub for proxy/auth cases: only set appropriate property of client obj
+     **/
 
 header('Content-Type: text/html; charset=utf-8');
 

Braces +3 added lines, -1 removed lines

@@ -367,7 +367,9 @@
                                 echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
                                 if ($x->count() > 1) {
                                     foreach($x as $k => $y) {
-                                        if ($k == 0) continue;
+                                        if ($k == 0) {
+                                            continue;
+                                        }
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
                                         if ($wstype != 1) {
                                             $type = $y->scalarval();

tests/4LocalhostMultiTest.php

Braces +7 added lines, -8 removed lines

@@ -24,8 +24,9 @@ 
         {
             if(strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
             {
-                if (!isset(self::$failed_tests[$method]))
-                    $this->$method();
+                if (!isset(self::$failed_tests[$method])) {
+                                    $this->$method();
+                }
             }
             /*if ($this->_failed)
             {
@@ -76,9 +77,9 @@ 
         {
             $this->client->setProxy($this->args['PROXYSERVER'], $this->args['PROXYPORT']);
             $this->_runtests();
+        } else {
+                    $this->markTestSkipped('PROXY definition missing: cannot test proxy');
         }
-        else
-            $this->markTestSkipped('PROXY definition missing: cannot test proxy');
     }
 
     function testHttp11()
@@ -132,8 +133,7 @@ 
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
             return;
-        }
-        else if ($this->args['PROXYSERVER'] == '')
+        } else if ($this->args['PROXYSERVER'] == '')
         {
             $this->markTestSkipped('PROXY definition missing: cannot test proxy w. http 1.1');
             return;
@@ -170,8 +170,7 @@ 
         {
             $this->markTestSkipped('CURL missing: cannot test https functionality');
             return;
-        }
-        else if ($this->args['PROXYSERVER'] == '')
+        } else if ($this->args['PROXYSERVER'] == '')
         {
             $this->markTestSkipped('PROXY definition missing: cannot test proxy w. http 1.1');
             return;

tests/benchmark.php

Indentation +9 added lines, -9 removed lines

@@ -1,14 +1,14 @@
 <?php
 /**
- * Benchmarking suite for the PHP-XMLRPC lib.
- *
- * @author Gaetano Giunta
- * @copyright (c) 2005-2015 G. Giunta
- * @license code licensed under the BSD License: see file license.txt
- *
- * @todo add a test for response ok in call testing
- * @todo add support for --help option to give users the list of supported parameters
- **/
+     * Benchmarking suite for the PHP-XMLRPC lib.
+     *
+     * @author Gaetano Giunta
+     * @copyright (c) 2005-2015 G. Giunta
+     * @license code licensed under the BSD License: see file license.txt
+     *
+     * @todo add a test for response ok in call testing
+     * @todo add support for --help option to give users the list of supported parameters
+     **/
 
 use PhpXmlRpc\PhpXmlRpc;
 use PhpXmlRpc\Value;

tests/phpunit_coverage.php

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * Used to serve back the server-side code coverage results to phpunit-selenium
- *
- * @copyright (C) 2007-2015 G. Giunta
- * @license code licensed under the BSD License: see file license.txt
- **/
+     * Used to serve back the server-side code coverage results to phpunit-selenium
+     *
+     * @copyright (C) 2007-2015 G. Giunta
+     * @license code licensed under the BSD License: see file license.txt
+     **/
 
 $coverageFile = realpath(__DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/phpunit_coverage.php");
 

tests/1ParsingBugsTest.php

Indentation +2 added lines, -2 removed lines

@@ -1,7 +1,7 @@
 <?php
 /**
- * NB: do not let your IDE fool you. The correct encoding for this file is NOT UTF8.
- */
+     * NB: do not let your IDE fool you. The correct encoding for this file is NOT UTF8.
+     */
 include_once __DIR__ . '/../lib/xmlrpc.inc';
 include_once __DIR__ . '/../lib/xmlrpcs.inc';
 

Braces +6 added lines, -4 removed lines

@@ -17,14 +17,16 @@
     protected function setUp()
     {
         $this->args = argParser::getArgs();
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tearDown()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == PHPUnit_Runner_BaseTestRunner::STATUS_ERROR

demo/server/server.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * Demo server for xmlrpc library.
- *
- * Implements a lot of webservices, including a suite of services used for
- * interoperability testing (validator1 methods), and some whose only purpose
- * is to be used for unit-testing the library.
- *
- * Please do not copy this file verbatim into your production server.
- **/
+     * Demo server for xmlrpc library.
+     *
+     * Implements a lot of webservices, including a suite of services used for
+     * interoperability testing (validator1 methods), and some whose only purpose
+     * is to be used for unit-testing the library.
+     *
+     * Please do not copy this file verbatim into your production server.
+     **/
 
 // give user a chance to see the source for this server instead of running the services
 if ($_SERVER['REQUEST_METHOD'] != 'POST' && isset($_GET['showSource'])) {

Braces +6 added lines, -5 removed lines

@@ -209,11 +209,12 @@
     $a = $req->getParam(0);
     $b = $req->getParam(1);
 
-    if ($a->scalartyp() == Value::$xmlrpcNull)
-        return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
-    else
-        return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
-}
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
+    } else {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
+    }
+    }
 
 $addtwo_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt, Value::$xmlrpcInt));
 $addtwo_doc = 'Add two integers together and return the result';

demo/server/proxy.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * XMLRPC server acting as proxy for requests to other servers
- * (useful e.g. for ajax-originated calls that can only connect back to
- * the originating server).
- *
- * @author Gaetano Giunta
- * @copyright (C) 2006-2015 G. Giunta
- * @license code licensed under the BSD License: see file license.txt
- */
+     * XMLRPC server acting as proxy for requests to other servers
+     * (useful e.g. for ajax-originated calls that can only connect back to
+     * the originating server).
+     *
+     * @author Gaetano Giunta
+     * @copyright (C) 2006-2015 G. Giunta
+     * @license code licensed under the BSD License: see file license.txt
+     */
 
 include_once __DIR__ . "/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();

src/Client.php

Indentation +9 added lines, -9 removed lines

@@ -457,9 +457,9 @@ 
      * @return Response
      */
     protected function sendPayloadHTTP10($req, $server, $port, $timeout = 0,
-                                       $username = '', $password = '', $authType = 1, $proxyHost = '',
-                                       $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
-                                       $method='http')
+                                        $username = '', $password = '', $authType = 1, $proxyHost = '',
+                                        $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
+                                        $method='http')
     {
         if ($port == 0) {
             $port = ( $method === "https" ) ? 443 : 80;
@@ -636,9 +636,9 @@ 
      * @return Response
      */
     protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '',
-                                      $password = '', $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '',
-                                      $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
-                                      $keepAlive = false, $key = '', $keyPass = '', $sslVersion = 0)
+                                        $password = '', $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '',
+                                        $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
+                                        $keepAlive = false, $key = '', $keyPass = '', $sslVersion = 0)
     {
         return $this->sendPayloadCURL($req, $server, $port, $timeout, $username,
             $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort,
@@ -674,9 +674,9 @@ 
      * @return Response
      */
     protected function sendPayloadCURL($req, $server, $port, $timeout = 0, $username = '',
-                                     $password = '', $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '',
-                                     $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https',
-                                     $keepAlive = false, $key = '', $keyPass = '', $sslVersion = 0)
+                                        $password = '', $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '',
+                                        $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https',
+                                        $keepAlive = false, $key = '', $keyPass = '', $sslVersion = 0)
     {
         if (!function_exists('curl_init')) {
             $this->errstr = 'CURL unavailable on this install';