Passed
Push — master ( 970c56...251b1a )
by Gaetano
09:46
created
src/Helper/XMLParser.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -154,10 +154,10 @@  discard block
 block discarded – undo
154 154
         $this->accept = $accept;
155 155
 
156 156
         // @see ticket #70 - we have to parse big xml docks in chunks to avoid errors
157
-        for ($offset = 0; $offset < $len; $offset += $this->maxChunkLength) {
157
+        for ($offset = 0; $offset<$len; $offset += $this->maxChunkLength) {
158 158
             $chunk = substr($data, $offset, $this->maxChunkLength);
159 159
             // error handling: xml not well formed
160
-            if (!xml_parse($parser, $chunk, $offset + $this->maxChunkLength >= $len)) {
160
+            if (!xml_parse($parser, $chunk, $offset+$this->maxChunkLength>=$len)) {
161 161
                 $errCode = xml_get_error_code($parser);
162 162
                 $errStr = sprintf('XML error %s: %s at line %d, column %d', $errCode, xml_error_string($errCode),
163 163
                     xml_get_current_line_number($parser), xml_get_current_column_number($parser));
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     public function xmlrpc_se($parser, $name, $attrs, $acceptSingleVals = false)
183 183
     {
184 184
         // if invalid xmlrpc already detected, skip all processing
185
-        if ($this->_xh['isf'] < 2) {
185
+        if ($this->_xh['isf']<2) {
186 186
 
187 187
             // check for correct element nesting
188 188
             if (count($this->_xh['stack']) == 0) {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
                     $this->_xh['rt'] = strtolower($name);
203 203
                 } else {
204 204
                     $this->_xh['isf'] = 2;
205
-                    $this->_xh['isf_reason'] = 'missing top level xmlrpc element. Found: ' . $name;
205
+                    $this->_xh['isf_reason'] = 'missing top level xmlrpc element. Found: '.$name;
206 206
 
207 207
                     return;
208 208
                 }
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
                     break;
297 297
                 case 'MEMBER':
298 298
                     // set member name to null, in case we do not find in the xml later on
299
-                    $this->_xh['valuestack'][count($this->_xh['valuestack']) - 1]['name'] = '';
299
+                    $this->_xh['valuestack'][count($this->_xh['valuestack'])-1]['name'] = '';
300 300
                     //$this->_xh['ac']='';
301 301
                 // Drop trough intentionally
302 302
                 case 'PARAM':
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
      */
358 358
     public function xmlrpc_ee($parser, $name, $rebuildXmlrpcvals = 1)
359 359
     {
360
-        if ($this->_xh['isf'] < 2) {
360
+        if ($this->_xh['isf']<2) {
361 361
             // push this element name from stack
362 362
             // NB: if XML validates, correct opening/closing is guaranteed and
363 363
             // we do not have to check for $name == $currElem.
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
                         $this->_xh['vt'] = Value::$xmlrpcString;
373 373
                     }
374 374
 
375
-                    if ($rebuildXmlrpcvals > 0) {
375
+                    if ($rebuildXmlrpcvals>0) {
376 376
                         // build the xmlrpc val out of the data received, and substitute it
377 377
                         $temp = new Value($this->_xh['value'], $this->_xh['vt']);
378 378
                         // in case we got info about underlying php class, save it
@@ -381,15 +381,15 @@  discard block
 block discarded – undo
381 381
                             $temp->_php_class = $this->_xh['php_class'];
382 382
                         }
383 383
                         $this->_xh['value'] = $temp;
384
-                    } elseif ($rebuildXmlrpcvals < 0) {
384
+                    } elseif ($rebuildXmlrpcvals<0) {
385 385
                         if ($this->_xh['vt'] == Value::$xmlrpcDateTime) {
386
-                            $this->_xh['value'] = (object)array(
386
+                            $this->_xh['value'] = (object) array(
387 387
                                 'xmlrpc_type' => 'datetime',
388 388
                                 'scalar' => $this->_xh['value'],
389 389
                                 'timestamp' => \PhpXmlRpc\Helper\Date::iso8601Decode($this->_xh['value'])
390 390
                             );
391 391
                         } elseif ($this->_xh['vt'] == Value::$xmlrpcBase64) {
392
-                            $this->_xh['value'] = (object)array(
392
+                            $this->_xh['value'] = (object) array(
393 393
                                 'xmlrpc_type' => 'base64',
394 394
                                 'scalar' => $this->_xh['value']
395 395
                             );
@@ -405,8 +405,8 @@  discard block
 block discarded – undo
405 405
                     // check if we are inside an array or struct:
406 406
                     // if value just built is inside an array, let's move it into array on the stack
407 407
                     $vscount = count($this->_xh['valuestack']);
408
-                    if ($vscount && $this->_xh['valuestack'][$vscount - 1]['type'] == 'ARRAY') {
409
-                        $this->_xh['valuestack'][$vscount - 1]['values'][] = $this->_xh['value'];
408
+                    if ($vscount && $this->_xh['valuestack'][$vscount-1]['type'] == 'ARRAY') {
409
+                        $this->_xh['valuestack'][$vscount-1]['values'][] = $this->_xh['value'];
410 410
                     }
411 411
                     break;
412 412
                 case 'BOOLEAN':
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
                         $this->_xh['value'] = $this->_xh['ac'];
426 426
                     } elseif ($name == 'DATETIME.ISO8601') {
427 427
                         if (!preg_match('/^[0-9]{8}T[0-9]{2}:[0-9]{2}:[0-9]{2}$/', $this->_xh['ac'])) {
428
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': invalid value received in DATETIME: ' . $this->_xh['ac']);
428
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': invalid value received in DATETIME: '.$this->_xh['ac']);
429 429
                         }
430 430
                         $this->_xh['vt'] = Value::$xmlrpcDateTime;
431 431
                         $this->_xh['value'] = $this->_xh['ac'];
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
                         } else {
445 445
                             // log if receiving something strange, even though we set the value to false anyway
446 446
                             if ($this->_xh['ac'] != '0' && strcasecmp($this->_xh['ac'], 'false') != 0) {
447
-                                Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': invalid value received in BOOLEAN: ' . $this->_xh['ac']);
447
+                                Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': invalid value received in BOOLEAN: '.$this->_xh['ac']);
448 448
                             }
449 449
                             $this->_xh['value'] = false;
450 450
                         }
@@ -454,37 +454,37 @@  discard block
 block discarded – undo
454 454
                         // NOTE: regexp could be much stricter than this...
455 455
                         if (!preg_match('/^[+-eE0123456789 \t.]+$/', $this->_xh['ac'])) {
456 456
                             /// @todo: find a better way of throwing an error than this!
457
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': non numeric value received in DOUBLE: ' . $this->_xh['ac']);
457
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': non numeric value received in DOUBLE: '.$this->_xh['ac']);
458 458
                             $this->_xh['value'] = 'ERROR_NON_NUMERIC_FOUND';
459 459
                         } else {
460 460
                             // it's ok, add it on
461
-                            $this->_xh['value'] = (double)$this->_xh['ac'];
461
+                            $this->_xh['value'] = (double) $this->_xh['ac'];
462 462
                         }
463 463
                     } else {
464 464
                         // we have an I4/I8/INT
465 465
                         // we must check that only 0123456789-<space> are characters here
466 466
                         if (!preg_match('/^[+-]?[0123456789 \t]+$/', $this->_xh['ac'])) {
467 467
                             /// @todo find a better way of throwing an error than this!
468
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': non numeric value received in INT: ' . $this->_xh['ac']);
468
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': non numeric value received in INT: '.$this->_xh['ac']);
469 469
                             $this->_xh['value'] = 'ERROR_NON_NUMERIC_FOUND';
470 470
                         } else {
471 471
                             // it's ok, add it on
472
-                            $this->_xh['value'] = (int)$this->_xh['ac'];
472
+                            $this->_xh['value'] = (int) $this->_xh['ac'];
473 473
                         }
474 474
                     }
475 475
                     $this->_xh['lv'] = 3; // indicate we've found a value
476 476
                     break;
477 477
                 case 'NAME':
478
-                    $this->_xh['valuestack'][count($this->_xh['valuestack']) - 1]['name'] = $this->_xh['ac'];
478
+                    $this->_xh['valuestack'][count($this->_xh['valuestack'])-1]['name'] = $this->_xh['ac'];
479 479
                     break;
480 480
                 case 'MEMBER':
481 481
                     // add to array in the stack the last element built,
482 482
                     // unless no VALUE was found
483 483
                     if ($this->_xh['vt']) {
484 484
                         $vscount = count($this->_xh['valuestack']);
485
-                        $this->_xh['valuestack'][$vscount - 1]['values'][$this->_xh['valuestack'][$vscount - 1]['name']] = $this->_xh['value'];
485
+                        $this->_xh['valuestack'][$vscount-1]['values'][$this->_xh['valuestack'][$vscount-1]['name']] = $this->_xh['value'];
486 486
                     } else {
487
-                        Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': missing VALUE inside STRUCT in received xml');
487
+                        Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': missing VALUE inside STRUCT in received xml');
488 488
                     }
489 489
                     break;
490 490
                 case 'DATA':
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
                         $this->_xh['params'][] = $this->_xh['value'];
508 508
                         $this->_xh['pt'][] = $this->_xh['vt'];
509 509
                     } else {
510
-                        Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': missing VALUE inside PARAM in received xml');
510
+                        Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': missing VALUE inside PARAM in received xml');
511 511
                     }
512 512
                     break;
513 513
                 case 'METHODNAME':
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
     public function xmlrpc_cd($parser, $data)
567 567
     {
568 568
         // skip processing if xml fault already detected
569
-        if ($this->_xh['isf'] < 2) {
569
+        if ($this->_xh['isf']<2) {
570 570
             // "lookforvalue==3" means that we've found an entire value
571 571
             // and should discard any further character data
572 572
             if ($this->_xh['lv'] != 3) {
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
     public function xmlrpc_dh($parser, $data)
586 586
     {
587 587
         // skip processing if xml fault already detected
588
-        if ($this->_xh['isf'] < 2) {
588
+        if ($this->_xh['isf']<2) {
589 589
             if (substr($data, 0, 1) == '&' && substr($data, -1, 1) == ';') {
590 590
                 $this->_xh['ac'] .= $data;
591 591
             }
@@ -659,8 +659,8 @@  discard block
 block discarded – undo
659 659
         // Details:
660 660
         // SPACE:         (#x20 | #x9 | #xD | #xA)+ === [ \x9\xD\xA]+
661 661
         // EQ:            SPACE?=SPACE? === [ \x9\xD\xA]*=[ \x9\xD\xA]*
662
-        if (preg_match('/^<\?xml\s+version\s*=\s*' . "((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))" .
663
-            '\s+encoding\s*=\s*' . "((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
662
+        if (preg_match('/^<\?xml\s+version\s*=\s*'."((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))".
663
+            '\s+encoding\s*=\s*'."((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
664 664
             $xmlChunk, $matches)) {
665 665
             return strtoupper(substr($matches[2], 1, -1));
666 666
         }
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
             // NB: mb_detect likes to call it ascii, xml parser likes to call it US_ASCII...
679 679
             // IANA also likes better US-ASCII, so go with it
680 680
             if ($enc == 'ASCII') {
681
-                $enc = 'US-' . $enc;
681
+                $enc = 'US-'.$enc;
682 682
             }
683 683
 
684 684
             return $enc;
@@ -713,8 +713,8 @@  discard block
 block discarded – undo
713 713
         // Details:
714 714
         // SPACE:         (#x20 | #x9 | #xD | #xA)+ === [ \x9\xD\xA]+
715 715
         // EQ:            SPACE?=SPACE? === [ \x9\xD\xA]*=[ \x9\xD\xA]*
716
-        if (preg_match('/^<\?xml\s+version\s*=\s*' . "((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))" .
717
-            '\s+encoding\s*=\s*' . "((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
716
+        if (preg_match('/^<\?xml\s+version\s*=\s*'."((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))".
717
+            '\s+encoding\s*=\s*'."((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
718 718
             $xmlChunk, $matches)) {
719 719
             return true;
720 720
         }
Please login to merge, or discard this patch.
src/Helper/Charset.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
68 68
                 if (count($this->xml_iso88591_Entities['in'])) {
69 69
                     return;
70 70
                 }
71
-                for ($i = 0; $i < 32; $i++) {
71
+                for ($i = 0; $i<32; $i++) {
72 72
                     $this->xml_iso88591_Entities["in"][] = chr($i);
73 73
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
74 74
                 }
75 75
 
76 76
                 /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
77 77
 
78
-                for ($i = 160; $i < 256; $i++) {
78
+                for ($i = 160; $i<256; $i++) {
79 79
                     $this->xml_iso88591_Entities["in"][] = chr($i);
80 80
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
81 81
                 }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 break;*/
104 104
 
105 105
             default:
106
-                throw new \Exception('Unsupported table: ' . $tableName);
106
+                throw new \Exception('Unsupported table: '.$tableName);
107 107
         }
108 108
     }
109 109
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
             $destEncoding = 'US-ASCII';
147 147
         }
148 148
 
149
-        $conversion = strtoupper($srcEncoding . '_' . $destEncoding);
149
+        $conversion = strtoupper($srcEncoding.'_'.$destEncoding);
150 150
 
151 151
         // list ordered with (expected) most common scenarios first
152 152
         switch ($conversion) {
@@ -164,20 +164,20 @@  discard block
 block discarded – undo
164 164
                 // NB: this will choke on invalid UTF-8, going most likely beyond EOF
165 165
                 $escapedData = '';
166 166
                 // be kind to users creating string xmlrpc values out of different php types
167
-                $data = (string)$data;
167
+                $data = (string) $data;
168 168
                 $ns = strlen($data);
169
-                for ($nn = 0; $nn < $ns; $nn++) {
169
+                for ($nn = 0; $nn<$ns; $nn++) {
170 170
                     $ch = $data[$nn];
171 171
                     $ii = ord($ch);
172 172
                     // 7 bits in 1 byte: 0bbbbbbb (127)
173
-                    if ($ii < 32) {
173
+                    if ($ii<32) {
174 174
                         if ($conversion == 'UTF-8_US-ASCII') {
175 175
                             $escapedData .= sprintf('&#%d;', $ii);
176 176
                         } else {
177 177
                             $escapedData .= $ch;
178 178
                         }
179 179
                     }
180
-                    else if ($ii < 128) {
180
+                    else if ($ii<128) {
181 181
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
182 182
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
183 183
                         switch ($ii) {
@@ -202,25 +202,25 @@  discard block
 block discarded – undo
202 202
                     } // 11 bits in 2 bytes: 110bbbbb 10bbbbbb (2047)
203 203
                     elseif ($ii >> 5 == 6) {
204 204
                         $b1 = ($ii & 31);
205
-                        $b2 = (ord($data[$nn + 1]) & 63);
206
-                        $ii = ($b1 * 64) + $b2;
205
+                        $b2 = (ord($data[$nn+1]) & 63);
206
+                        $ii = ($b1 * 64)+$b2;
207 207
                         $escapedData .= sprintf('&#%d;', $ii);
208 208
                         $nn += 1;
209 209
                     } // 16 bits in 3 bytes: 1110bbbb 10bbbbbb 10bbbbbb
210 210
                     elseif ($ii >> 4 == 14) {
211 211
                         $b1 = ($ii & 15);
212
-                        $b2 = (ord($data[$nn + 1]) & 63);
213
-                        $b3 = (ord($data[$nn + 2]) & 63);
214
-                        $ii = ((($b1 * 64) + $b2) * 64) + $b3;
212
+                        $b2 = (ord($data[$nn+1]) & 63);
213
+                        $b3 = (ord($data[$nn+2]) & 63);
214
+                        $ii = ((($b1 * 64)+$b2) * 64)+$b3;
215 215
                         $escapedData .= sprintf('&#%d;', $ii);
216 216
                         $nn += 2;
217 217
                     } // 21 bits in 4 bytes: 11110bbb 10bbbbbb 10bbbbbb 10bbbbbb
218 218
                     elseif ($ii >> 3 == 30) {
219 219
                         $b1 = ($ii & 7);
220
-                        $b2 = (ord($data[$nn + 1]) & 63);
221
-                        $b3 = (ord($data[$nn + 2]) & 63);
222
-                        $b4 = (ord($data[$nn + 3]) & 63);
223
-                        $ii = ((((($b1 * 64) + $b2) * 64) + $b3) * 64) + $b4;
220
+                        $b2 = (ord($data[$nn+1]) & 63);
221
+                        $b3 = (ord($data[$nn+2]) & 63);
222
+                        $b4 = (ord($data[$nn+3]) & 63);
223
+                        $ii = ((((($b1 * 64)+$b2) * 64)+$b3) * 64)+$b4;
224 224
                         $escapedData .= sprintf('&#%d;', $ii);
225 225
                         $nn += 3;
226 226
                     }
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 
269 269
             default:
270 270
                 $escapedData = '';
271
-                Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding: not supported...");
271
+                Logger::instance()->errorLog('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding: not supported...");
272 272
         }
273 273
 
274 274
         return $escapedData;
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
             case 'iso88591':
323 323
                 return $this->xml_iso88591_Entities;
324 324
             default:
325
-                throw new \Exception('Unsupported charset: ' . $charset);
325
+                throw new \Exception('Unsupported charset: '.$charset);
326 326
         }
327 327
     }
328 328
 }
Please login to merge, or discard this patch.
debugger/action.php 1 patch
Spacing   +113 added lines, -113 removed lines patch added patch discarded remove patch
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
 <body>
93 93
 <?php
94 94
 
95
-include __DIR__ . '/common.php';
95
+include __DIR__.'/common.php';
96 96
 
97 97
 if ($action) {
98 98
 
99 99
     // make sure the script waits long enough for the call to complete...
100 100
     if ($timeout) {
101
-        set_time_limit($timeout + 10);
101
+        set_time_limit($timeout+10);
102 102
     }
103 103
 
104 104
     if ($wstype == 1) {
@@ -123,13 +123,13 @@  discard block
 block discarded – undo
123 123
         $server = "$host$path";
124 124
     }
125 125
     if ($protocol == 2 || $protocol == 3) {
126
-        $server = 'https://' . $server;
126
+        $server = 'https://'.$server;
127 127
     } else {
128
-        $server = 'http://' . $server;
128
+        $server = 'http://'.$server;
129 129
     }
130 130
     if ($proxy != '') {
131 131
         $pproxy = explode(':', $proxy);
132
-        if (count($pproxy) > 1) {
132
+        if (count($pproxy)>1) {
133 133
             $pport = $pproxy[1];
134 134
         } else {
135 135
             $pport = 8080;
@@ -204,9 +204,9 @@  discard block
 block discarded – undo
204 204
         case 'wrap':
205 205
             $msg[0] = new $requestClass('system.methodHelp', array(), $id);
206 206
             $msg[0]->addparam(new PhpXmlRpc\Value($method));
207
-            $msg[1] = new $requestClass('system.methodSignature', array(), (int)$id + 1);
207
+            $msg[1] = new $requestClass('system.methodSignature', array(), (int) $id+1);
208 208
             $msg[1]->addparam(new PhpXmlRpc\Value($method));
209
-            $actionname = 'Description of method "' . $method . '"';
209
+            $actionname = 'Description of method "'.$method.'"';
210 210
             break;
211 211
         case 'list':
212 212
             $msg[0] = new $requestClass('system.listMethods', array(), $id);
@@ -219,9 +219,9 @@  discard block
 block discarded – undo
219 219
             $msg[0] = new $requestClass($method, array(), $id);
220 220
             // hack! build xml payload by hand
221 221
             if ($wstype == 1) {
222
-                $msg[0]->payload = "{\n" .
223
-                    '"method": "' . $method . "\",\n\"params\": [" .
224
-                    $payload .
222
+                $msg[0]->payload = "{\n".
223
+                    '"method": "'.$method."\",\n\"params\": [".
224
+                    $payload.
225 225
                     "\n],\n\"id\": ";
226 226
                 // fix: if user gave an empty string, use NULL, or we'll break json syntax
227 227
                 if ($id == "") {
@@ -234,20 +234,20 @@  discard block
 block discarded – undo
234 234
                     }
235 235
                 }
236 236
             } else {
237
-                $msg[0]->payload = $msg[0]->xml_header($inputcharset) .
238
-                    '<methodName>' . $method . "</methodName>\n<params>" .
239
-                    $payload .
240
-                    "</params>\n" . $msg[0]->xml_footer();
237
+                $msg[0]->payload = $msg[0]->xml_header($inputcharset).
238
+                    '<methodName>'.$method."</methodName>\n<params>".
239
+                    $payload.
240
+                    "</params>\n".$msg[0]->xml_footer();
241 241
             }
242
-            $actionname = 'Execution of method ' . $method;
242
+            $actionname = 'Execution of method '.$method;
243 243
             break;
244 244
         default: // give a warning
245
-            $actionname = '[ERROR: unknown action] "' . $action . '"';
245
+            $actionname = '[ERROR: unknown action] "'.$action.'"';
246 246
     }
247 247
 
248 248
     // Before calling execute, echo out brief description of action taken + date and time ???
249 249
     // this gives good user feedback for long-running methods...
250
-    echo '<h2>' . htmlspecialchars($actionname, ENT_COMPAT, $inputcharset) . ' on server ' . htmlspecialchars($server, ENT_COMPAT, $inputcharset) . " ...</h2>\n";
250
+    echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset)." ...</h2>\n";
251 251
     flush();
252 252
 
253 253
     $response = null;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
             break;
266 266
         }
267 267
     }
268
-    $time = microtime(true) - $time;
268
+    $time = microtime(true)-$time;
269 269
     if ($debug) {
270 270
         echo "</div>\n";
271 271
     }
@@ -275,8 +275,8 @@  discard block
 block discarded – undo
275 275
             // call failed! echo out error msg!
276 276
             //echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset).'</h2>';
277 277
             echo "<h3>$protoName call FAILED!</h3>\n";
278
-            echo "<p>Fault code: [" . htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
279
-                "] Reason: '" . htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "'</p>\n";
278
+            echo "<p>Fault code: [".htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
279
+                "] Reason: '".htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."'</p>\n";
280 280
             echo(date("d/M/Y:H:i:s\n"));
281 281
         } else {
282 282
             // call succeeded: parse results
@@ -292,36 +292,36 @@  discard block
 block discarded – undo
292 292
                         $max = $v->count();
293 293
                         echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
294 294
                         echo "<thead>\n<tr><th>Method ($max)</th><th>Description</th></tr>\n</thead>\n<tbody>\n";
295
-                        foreach($v as $i => $rec) {
295
+                        foreach ($v as $i => $rec) {
296 296
                             if ($i % 2) {
297 297
                                 $class = ' class="oddrow"';
298 298
                             } else {
299 299
                                 $class = ' class="evenrow"';
300 300
                             }
301
-                            echo("<tr><td$class>" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">" .
302
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
303
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
304
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
305
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
306
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
307
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
308
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
309
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
310
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
311
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
312
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
313
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
314
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
315
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
316
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
317
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
318
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
319
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
320
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
321
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "\" />" .
322
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
323
-                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />" .
324
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
301
+                            echo("<tr><td$class>".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">".
302
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
303
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
304
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
305
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
306
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
307
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
308
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
309
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
310
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
311
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
312
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
313
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
314
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
315
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
316
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
317
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
318
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
319
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
320
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
321
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."\" />".
322
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
323
+                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />".
324
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
325 325
                                 "<input type=\"submit\" value=\"Describe\" /></form></td>");
326 326
                             //echo("</tr>\n");
327 327
 
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
                     $r2 = $resp[1]->value();
349 349
 
350 350
                     echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
351
-                    echo "<thead>\n<tr><th>Method</th><th>" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
351
+                    echo "<thead>\n<tr><th>Method</th><th>".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
352 352
                     $desc = htmlspecialchars($r1->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
353 353
                     if ($desc == "") {
354 354
                         $desc = "-";
@@ -358,41 +358,41 @@  discard block
 block discarded – undo
358 358
                     if ($r2->kindOf() != "array") {
359 359
                         echo "<tr><td class=\"oddrow\">Signature</td><td class=\"oddrow\">Unknown</td><td class=\"oddrow\">&nbsp;</td></tr>\n";
360 360
                     } else {
361
-                        foreach($r2 as $i => $x) {
361
+                        foreach ($r2 as $i => $x) {
362 362
                             $payload = "";
363 363
                             $alt_payload = "";
364
-                            if ($i + 1 % 2) {
364
+                            if ($i+1 % 2) {
365 365
                                 $class = ' class="oddrow"';
366 366
                             } else {
367 367
                                 $class = ' class="evenrow"';
368 368
                             }
369
-                            echo "<tr><td$class>Signature&nbsp;" . ($i + 1) . "</td><td$class>";
369
+                            echo "<tr><td$class>Signature&nbsp;".($i+1)."</td><td$class>";
370 370
                             if ($x->kindOf() == "array") {
371 371
                                 $ret = $x[0];
372
-                                echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
373
-                                if ($x->count() > 1) {
374
-                                    foreach($x as $k => $y) {
372
+                                echo "<code>OUT:&nbsp;".htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."<br />IN: (";
373
+                                if ($x->count()>1) {
374
+                                    foreach ($x as $k => $y) {
375 375
                                         if ($k == 0) continue;
376 376
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
377 377
                                         if ($wstype != 1) {
378 378
                                             $type = $y->scalarval();
379 379
                                             $payload .= '<param><value>';
380
-                                            switch($type) {
380
+                                            switch ($type) {
381 381
                                                 case 'undefined':
382 382
                                                     break;
383 383
                                                 case 'null';
384 384
                                                     $type = 'nil';
385 385
                                                     // fall thru intentionally
386 386
                                                 default:
387
-                                                    $payload .= '<' .
388
-                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
389
-                                                        '></' . htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
387
+                                                    $payload .= '<'.
388
+                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
389
+                                                        '></'.htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
390 390
                                                         '>';
391 391
                                             }
392 392
                                             $payload .= "</value></param>\n";
393 393
                                         }
394 394
                                         $alt_payload .= $y->scalarval();
395
-                                        if ($k < $x->count() - 1) {
395
+                                        if ($k<$x->count()-1) {
396 396
                                             $alt_payload .= ';';
397 397
                                             echo ", ";
398 398
                                         }
@@ -405,63 +405,63 @@  discard block
 block discarded – undo
405 405
                             echo '</td>';
406 406
                             // button to test this method
407 407
                             //$payload="<methodCall>\n<methodName>$method</methodName>\n<params>\n$payload</params>\n</methodCall>";
408
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
409
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
410
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
411
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
412
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
413
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
414
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
415
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
416
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
417
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
418
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
419
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
420
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
421
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
422
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
423
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
424
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
425
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
426
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
427
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
428
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
429
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
430
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
431
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
408
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
409
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
410
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
411
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
412
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
413
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
414
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
415
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
416
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
417
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
418
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
419
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
420
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
421
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
422
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
423
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
424
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
425
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
426
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
427
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
428
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
429
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
430
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
431
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
432 432
                                 "<input type=\"hidden\" name=\"action\" value=\"execute\" />";
433 433
                             if ($wstype != 1) {
434 434
                                 echo "<input type=\"submit\" value=\"Load method synopsis\" />";
435 435
                             }
436 436
                             echo "</form></td>\n";
437 437
 
438
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
439
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
440
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
441
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
442
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
443
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
444
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
445
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
446
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
447
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
448
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
449
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
450
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
451
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
452
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
453
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
454
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
455
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
456
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
457
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
458
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
459
-                                "<input type=\"hidden\" name=\"methodsig\" value=\"" . $i . "\" />" .
460
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
461
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
462
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
463
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
464
-                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />" .
438
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
439
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
440
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
441
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
442
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
443
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
444
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
445
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
446
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
447
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
448
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
449
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
450
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
451
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
452
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
453
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
454
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
455
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
456
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
457
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
458
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
459
+                                "<input type=\"hidden\" name=\"methodsig\" value=\"".$i."\" />".
460
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
461
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
462
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
463
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
464
+                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />".
465 465
                                 "<input type=\"submit\" value=\"Generate method call stub code\" />";
466 466
                             echo "</form></td></tr>\n";
467 467
                         }
@@ -473,14 +473,14 @@  discard block
 block discarded – undo
473 473
                 case 'wrap':
474 474
                     $r1 = $resp[0]->value();
475 475
                     $r2 = $resp[1]->value();
476
-                    if ($r2->kindOf() != "array" || $r2->count() <= $methodsig) {
476
+                    if ($r2->kindOf() != "array" || $r2->count()<=$methodsig) {
477 477
                         echo "Error: signature unknown\n";
478 478
                     } else {
479 479
                         $mdesc = $r1->scalarval();
480 480
                         $encoder = new PhpXmlRpc\Encoder();
481 481
                         $msig = $encoder->decode($r2);
482 482
                         $msig = $msig[$methodsig];
483
-                        $proto = ($protocol == 1) ? 'http11' : ( $protocol == 2 ? 'https' : ( $protocol == 3 ? 'h2' : ( $protocol == 4 ? 'h2c' : '' ) ) );
483
+                        $proto = ($protocol == 1) ? 'http11' : ($protocol == 2 ? 'https' : ($protocol == 3 ? 'h2' : ($protocol == 4 ? 'h2c' : '')));
484 484
                         if ($proxy == '' && $username == '' && !$requestcompression && !$responsecompression &&
485 485
                             $clientcookies == ''
486 486
                         ) {
@@ -494,11 +494,11 @@  discard block
 block discarded – undo
494 494
                             $prefix = 'xmlrpc';
495 495
                         }
496 496
                         $wrapper = new PhpXmlRpc\Wrapper();
497
-                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix . '_' . $method), $msig, $mdesc);
497
+                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix.'_'.$method), $msig, $mdesc);
498 498
                         //if ($code)
499 499
                         //{
500 500
                         echo "<div id=\"phpcode\">\n";
501
-                        highlight_string("<?php\n" . $code['docstring'] . $code['source'] . '?>');
501
+                        highlight_string("<?php\n".$code['docstring'].$code['source'].'?>');
502 502
                         echo "\n</div>";
503 503
                         //}
504 504
                         //else
@@ -509,7 +509,7 @@  discard block
 block discarded – undo
509 509
                     break;
510 510
 
511 511
                 case 'execute':
512
-                    echo '<div id="response"><h2>Response:</h2>' . htmlspecialchars($response->serialize()) . '</div>';
512
+                    echo '<div id="response"><h2>Response:</h2>'.htmlspecialchars($response->serialize()).'</div>';
513 513
                     break;
514 514
 
515 515
                 default: // give a warning
Please login to merge, or discard this patch.
pakefile.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -63,9 +63,9 @@  discard block
 block discarded – undo
63 63
         );
64 64
     }
65 65
 
66
-    public static function getOpts($args=array(), $cliOpts=array())
66
+    public static function getOpts($args = array(), $cliOpts = array())
67 67
     {
68
-        if (count($args) > 0)
68
+        if (count($args)>0)
69 69
         //    throw new \Exception('Missing library version argument');
70 70
             self::$libVersion = $args[0];
71 71
 
@@ -168,17 +168,17 @@  discard block
 block discarded – undo
168 168
         $out = '';
169 169
         while (($start = strpos($content, $startTag, $last)) !== false) {
170 170
             $end = strpos($content, $endTag, $start);
171
-            $code = substr($content, $start + strlen($startTag), $end - $start - strlen($startTag));
172
-            if ($code[strlen($code) - 1] == "\n") {
171
+            $code = substr($content, $start+strlen($startTag), $end-$start-strlen($startTag));
172
+            if ($code[strlen($code)-1] == "\n") {
173 173
                 $code = substr($code, 0, -1);
174 174
             }
175 175
 
176 176
             $code = str_replace(array('&gt;', '&lt;'), array('>', '<'), $code);
177
-            $code = highlight_string('<?php ' . $code, true);
177
+            $code = highlight_string('<?php '.$code, true);
178 178
             $code = str_replace('<span style="color: #0000BB">&lt;?php&nbsp;<br />', '<span style="color: #0000BB">', $code);
179 179
 
180
-            $out = $out . substr($content, $last, $start + strlen($startTag) - $last) . $code . $endTag;
181
-            $last = $end + strlen($endTag);
180
+            $out = $out.substr($content, $last, $start+strlen($startTag)-$last).$code.$endTag;
181
+            $last = $end+strlen($endTag);
182 182
         }
183 183
         $out .= substr($content, $last, strlen($content));
184 184
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
 use PhpXmlRpc\Builder;
194 194
 
195
-function run_default($task=null, $args=array(), $cliOpts=array())
195
+function run_default($task = null, $args = array(), $cliOpts = array())
196 196
 {
197 197
     echo "Syntax: pake {\$pake-options} \$task \$lib-version [\$git-tag] {\$task-options}\n";
198 198
     echo "\n";
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
     echo "      --zip=ZIP        Location of the zip tool\n";
211 211
 }
212 212
 
213
-function run_getopts($task=null, $args=array(), $cliOpts=array())
213
+function run_getopts($task = null, $args = array(), $cliOpts = array())
214 214
 {
215 215
     Builder::getOpts($args, $cliOpts);
216 216
 }
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
  * Downloads source code in the build workspace directory, optionally checking out the given branch/tag
220 220
  * @todo allow using current installation / dir as source, bypassing git clone in workspace - at least for doc generation
221 221
  */
222
-function run_init($task=null, $args=array(), $cliOpts=array())
222
+function run_init($task = null, $args = array(), $cliOpts = array())
223 223
 {
224 224
     // download the current version into the workspace
225 225
     $targetDir = Builder::workspaceDir();
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
  *
248 248
  * (does nothing by itself, as all the steps are managed via task dependencies)
249 249
  */
250
-function run_build($task=null, $args=array(), $cliOpts=array())
250
+function run_build($task = null, $args = array(), $cliOpts = array())
251 251
 {
252 252
 }
253 253
 
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 /**
264 264
  * Generates documentation in all formats
265 265
  */
266
-function run_doc($task=null, $args=array(), $cliOpts=array())
266
+function run_doc($task = null, $args = array(), $cliOpts = array())
267 267
 {
268 268
     // in
269 269
     $srcDir = Builder::workspaceDir();
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 
275 275
     // from phpdoc comments using phpdocumentor
276 276
     $cmd = Builder::tool('php');
277
-    pake_sh("$cmd " . Builder::toolsDir(). "/vendor/bin/phpdoc run --cache-folder ".Builder::buildDir()."/.phpdoc -d ".$srcDir.'/src'." -t ".$docDir.'/api --title PHP-XMLRPC');
277
+    pake_sh("$cmd ".Builder::toolsDir()."/vendor/bin/phpdoc run --cache-folder ".Builder::buildDir()."/.phpdoc -d ".$srcDir.'/src'." -t ".$docDir.'/api --title PHP-XMLRPC');
278 278
 
279 279
     // from phpdoc comments using Sami
280 280
     // deprecated on 2021/12, as Sami is abandonware
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 /**
356 356
  * Creates the tarballs for a release
357 357
  */
358
-function run_dist($task=null, $args=array(), $cliOpts=array())
358
+function run_dist($task = null, $args = array(), $cliOpts = array())
359 359
 {
360 360
     // copy workspace dir into dist dir, without git
361 361
     pake_mkdirs(Builder::distDir());
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
     // create tarballs
371 371
     $cwd = getcwd();
372 372
     chdir(dirname(Builder::distDir()));
373
-    foreach(Builder::distFiles() as $distFile) {
373
+    foreach (Builder::distFiles() as $distFile) {
374 374
         // php can not really create good zip files via phar: they are not compressed!
375 375
         if (substr($distFile, -4) == '.zip') {
376 376
             $cmd = Builder::tool('zip');
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
     chdir($cwd);
389 389
 }
390 390
 
391
-function run_clean_workspace($task=null, $args=array(), $cliOpts=array())
391
+function run_clean_workspace($task = null, $args = array(), $cliOpts = array())
392 392
 {
393 393
     if (realpath(__DIR__) === realpath(Builder::workspaceDir())) {
394 394
         throw new \Exception("Can not remove workspace dir, as it is where pakefile is located!");
@@ -400,13 +400,13 @@  discard block
 block discarded – undo
400 400
  * Cleans up the whole build directory
401 401
  * @todo 'make clean' usually just removes the results of the build, distclean removes all but sources
402 402
  */
403
-function run_clean($task=null, $args=array(), $cliOpts=array())
403
+function run_clean($task = null, $args = array(), $cliOpts = array())
404 404
 {
405 405
     pake_remove_dir(Builder::buildDir());
406 406
 }
407 407
 
408 408
 // helper task: display help text
409
-pake_task( 'default' );
409
+pake_task('default');
410 410
 // internal task: parse cli options
411 411
 pake_task('getopts');
412 412
 pake_task('init', 'getopts');
Please login to merge, or discard this patch.