Passed
Push — master ( 970c56...251b1a )
by Gaetano
09:46
created
tests/2MessageTest.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpcs.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/PolyfillTestCase.php';
8
+include_once __DIR__.'/PolyfillTestCase.php';
9 9
 
10 10
 use PHPUnit\Runner\BaseTestRunner;
11 11
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 
104 104
     public function testI8()
105 105
     {
106
-        if (PHP_INT_SIZE == 4 ) {
106
+        if (PHP_INT_SIZE == 4) {
107 107
             $this->markTestSkipped('Can not test i8 as php is compiled in 32 bit mode');
108 108
             return;
109 109
         }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 
134 134
     public function testUnicodeInMemberName()
135 135
     {
136
-        $str = "G" . chr(252) . "nter, El" . chr(232) . "ne";
136
+        $str = "G".chr(252)."nter, El".chr(232)."ne";
137 137
         $v = array($str => new xmlrpcval(1));
138 138
         $r = new xmlrpcresp(new xmlrpcval($v, 'struct'));
139 139
         $r = $r->serialize();
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
             '<?xml version="1.0"?>
150 150
 <!-- $Id -->
151 151
 <!-- found by G. Giunta, covers what happens when lib receives UTF8 chars in response text and comments -->
152
-<!-- ' . chr(224) . chr(252) . chr(232) . '&#224;&#252;&#232; -->
152
+<!-- ' . chr(224).chr(252).chr(232).'&#224;&#252;&#232; -->
153 153
 <methodResponse>
154 154
 <fault>
155 155
 <value>
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 </member>
161 161
 <member>
162 162
 <name>faultString</name>
163
-<value><string>' . chr(224) . chr(252) . chr(232) . '&#224;&#252;&#232;</string></value>
163
+<value><string>' . chr(224).chr(252).chr(232).'&#224;&#252;&#232;</string></value>
164 164
 </member>
165 165
 </struct>
166 166
 </value>
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         $m = $this->newMsg('dummy');
170 170
         $r = $m->parseResponse($response);
171 171
         $v = $r->faultString();
172
-        $this->assertEquals(chr(224) . chr(252) . chr(232) . chr(224) . chr(252) . chr(232), $v);
172
+        $this->assertEquals(chr(224).chr(252).chr(232).chr(224).chr(252).chr(232), $v);
173 173
     }
174 174
 
175 175
     public function testBrokenRequests()
@@ -409,11 +409,11 @@  discard block
 block discarded – undo
409 409
 
410 410
     public function testUTF8Response()
411 411
     {
412
-        $string = chr(224) . chr(252) . chr(232);
412
+        $string = chr(224).chr(252).chr(232);
413 413
 
414 414
         $s = $this->newMsg('dummy');
415
-        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
416
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
415
+        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
416
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
417 417
 ';
418 418
         $r = $s->parseResponse($f, false, 'phpvals');
419 419
         $v = $r->value();
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
         $this->assertEquals($string, $v);
422 422
 
423 423
         $f = '<?xml version="1.0" encoding="UTF-8"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
424
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
424
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
425 425
 ';
426 426
         $r = $s->parseResponse($f, false, 'phpvals');
427 427
         $v = $r->value();
@@ -437,11 +437,11 @@  discard block
 block discarded – undo
437 437
 
438 438
     public function testLatin1Response()
439 439
     {
440
-        $string = chr(224) . chr(252) . chr(232);
440
+        $string = chr(224).chr(252).chr(232);
441 441
 
442 442
         $s = $this->newMsg('dummy');
443
-        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
444
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
443
+        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
444
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
445 445
 ';
446 446
         $r = $s->parseResponse($f, false, 'phpvals');
447 447
         $v = $r->value();
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
         $this->assertEquals($string, $v);
450 450
 
451 451
         $f = '<?xml version="1.0" encoding="ISO-8859-1"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
452
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
452
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
453 453
 ';
454 454
         $r = $s->parseResponse($f, false, 'phpvals');
455 455
         $v = $r->value();
Please login to merge, or discard this patch.
tests/1ValueTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpcs.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/PolyfillTestCase.php';
8
+include_once __DIR__.'/PolyfillTestCase.php';
9 9
 
10 10
 use PHPUnit\Runner\BaseTestRunner;
11 11
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
         $this->assertequals(1, count($v1));
129 129
         $out = array('me' => array(), 'mytype' => 2, '_php_class' => null);
130 130
 
131
-        foreach($v1 as $key => $val)
131
+        foreach ($v1 as $key => $val)
132 132
         {
133 133
             $this->assertArrayHasKey($key, $out);
134 134
             $expected = $out[$key];
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
         $this->assertequals(2, count($v2));
144 144
         $out = array(array('key' => 0, 'value'  => 'object'), array('key' => 1, 'value'  => 'object'));
145 145
         $i = 0;
146
-        foreach($v2 as $key => $val)
146
+        foreach ($v2 as $key => $val)
147 147
         {
148 148
             $expected = $out[$i];
149 149
             $this->assertequals($expected['key'], $key);
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     {
158 158
         // nb: make sure that  the serialized xml corresponding to this is > 10MB in size
159 159
         $data = array();
160
-        for ($i = 0; $i < 500000; $i++ ) {
160
+        for ($i = 0; $i<500000; $i++) {
161 161
             $data[] = 'hello world';
162 162
         }
163 163
 
Please login to merge, or discard this patch.
extras/verify_compat.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -17,8 +17,8 @@  discard block
 block discarded – undo
17 17
         // test for php version
18 18
         $ver = phpversion();
19 19
         $tests['php_version'] = array();
20
-        $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
21
-        if (version_compare($ver, '5.3.0') < 0) {
20
+        $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
21
+        if (version_compare($ver, '5.3.0')<0) {
22 22
             $tests['php_version']['status'] = 0;
23 23
             $tests['php_version']['description'] .= 'This version of PHP is not compatible with this release of the PHP XMLRPC library. Please upgrade to php 5.1.0 or later';
24 24
         } else {
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
         // test for php version
52 52
         $ver = phpversion();
53 53
         $tests['php_version'] = array();
54
-        $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
55
-        if (version_compare($ver, '5.3.0') < 0) {
54
+        $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
55
+        if (version_compare($ver, '5.3.0')<0) {
56 56
             $tests['php_version']['status'] = 0;
57 57
             $tests['php_version']['description'] .= 'This version of PHP is not compatible with the PHP XMLRPC library. Please upgrade to 5.1.0 or later';
58 58
         } else {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             $info = curl_version();
80 80
             $tests['curl']['status'] = 2;
81 81
             $tests['curl']['description'] = "The cURL extension is enabled.\n\nYou will be able to send and receive messages using 'HTTPS' and 'HTTP 1.1' protocols";
82
-            if (version_compare($ver, '4.3.8') < 0) {
82
+            if (version_compare($ver, '4.3.8')<0) {
83 83
                 $tests['curl']['status'] = 1;
84 84
                 $tests['curl']['description'] .= ".\nPlease note that the current cURL install does not support keep-alives";
85 85
             }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
     <?php
168 168
     $res = phpxmlrpc_verify_compat('server');
169 169
     foreach ($res as $test => $result) {
170
-        echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
170
+        echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
171 171
     }
172 172
     ?>
173 173
     </tbody>
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     <?php
185 185
     $res = phpxmlrpc_verify_compat('client');
186 186
     foreach ($res as $test => $result) {
187
-        echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
187
+        echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
188 188
     }
189 189
     ?>
190 190
     </tbody>
Please login to merge, or discard this patch.
tests/WebTestCase.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/parse_args.php';
3
+include_once __DIR__.'/parse_args.php';
4 4
 
5
-include_once __DIR__ . '/PolyfillTestCase.php';
5
+include_once __DIR__.'/PolyfillTestCase.php';
6 6
 
7 7
 use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage;
8 8
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function _run($result = NULL)
27 27
     {
28
-        $this->testId = get_class($this) . '__' . $this->getName();
28
+        $this->testId = get_class($this).'__'.$this->getName();
29 29
 
30 30
         if ($result === NULL) {
31 31
             $result = $this->createResult();
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     protected function request($path, $method = 'GET', $payload = '', $emptyPageOk = false)
62 62
     {
63
-        $url = $this->baseUrl . $path;
63
+        $url = $this->baseUrl.$path;
64 64
 
65 65
         $ch = curl_init($url);
66 66
         curl_setopt_array($ch, array(
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         {
79 79
             curl_setopt($ch, CURLOPT_COOKIE, 'PHPUNIT_SELENIUM_TEST_ID='.$this->testId);
80 80
         }
81
-        if ($this->args['DEBUG'] > 0) {
81
+        if ($this->args['DEBUG']>0) {
82 82
             curl_setopt($ch, CURLOPT_VERBOSE, 1);
83 83
         }
84 84
         $page = curl_exec($ch);
Please login to merge, or discard this patch.
demo/server/methodProviders/functions.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 );
30 30
 
31 31
 $findstate_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcInt));
32
-$findstate_doc = 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the ' .
32
+$findstate_doc = 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the '.
33 33
     'index of that state name in an alphabetic order.';
34 34
 function findState($req)
35 35
 {
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
     // extract the value of the state number
43 43
     $snv = $sno->scalarval();
44 44
     // look it up in our array (zero-based)
45
-    if (isset($GLOBALS['stateNames'][$snv - 1])) {
46
-        $stateName = $GLOBALS['stateNames'][$snv - 1];
45
+    if (isset($GLOBALS['stateNames'][$snv-1])) {
46
+        $stateName = $GLOBALS['stateNames'][$snv-1];
47 47
     } else {
48 48
         // not there, so complain
49
-        $err = "I don't have a state for the index '" . $snv . "'";
49
+        $err = "I don't have a state for the index '".$snv."'";
50 50
     }
51 51
 
52 52
     // if we generated an error, create an error return response
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         return 0;
83 83
     }
84 84
 
85
-    return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
85
+    return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
86 86
 }
87 87
 
88 88
 $agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     // hack, must make global as uksort() won't
129 129
     // allow us to pass any other auxiliary information
130 130
     uksort($agesorter_arr, 'agesorter_compare');
131
-    foreach($agesorter_arr as $key => $val) {
131
+    foreach ($agesorter_arr as $key => $val) {
132 132
         // recreate each struct element
133 133
         $v[] = new Value(
134 134
             array(
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     $s = $req->getParam(0);
154 154
     $t = $req->getParam(1);
155 155
 
156
-    return new Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
156
+    return new Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
157 157
 }
158 158
 
159 159
 $addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
     $s = $req->getParam(0);
164 164
     $t = $req->getParam(1);
165 165
 
166
-    return new Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
166
+    return new Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
167 167
 }
168 168
 
169 169
 $stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 function echoBack($req)
180 180
 {
181 181
     // just sends back a string with what i got sent to me, just escaped, that's all
182
-    $s = "I got the following message:\n" . $req->serialize();
182
+    $s = "I got the following message:\n".$req->serialize();
183 183
 
184 184
     return new Response(new Value($s));
185 185
 }
@@ -293,17 +293,17 @@  discard block
 block discarded – undo
293 293
         $err = "Error, no 'From' field specified";
294 294
     }
295 295
 
296
-    $msgHdr = "From: " . $mFrom->scalarval() . "\n";
297
-    $msgHdr .= "To: " . $mTo->scalarval() . "\n";
296
+    $msgHdr = "From: ".$mFrom->scalarval()."\n";
297
+    $msgHdr .= "To: ".$mTo->scalarval()."\n";
298 298
 
299 299
     if ($mCc->scalarval() != "") {
300
-        $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
300
+        $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
301 301
     }
302 302
     if ($mBcc->scalarval() != "") {
303
-        $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
303
+        $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
304 304
     }
305 305
     if ($mMime->scalarval() != "") {
306
-        $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
306
+        $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
307 307
     }
308 308
     $msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
309 309
 
Please login to merge, or discard this patch.
demo/server/methodProviders/validator1.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     $moe = $sno["moe"];
37 37
     $larry = $sno["larry"];
38 38
     $curly = $sno["curly"];
39
-    $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
39
+    $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
40 40
 
41 41
     return new Response(new Value($num, Value::$xmlrpcInt));
42 42
 }
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
     $ar = $req->getParam(0);
79 79
     $sz = $ar->count();
80 80
     $first = $ar[0];
81
-    $last = $ar[$sz - 1];
81
+    $last = $ar[$sz-1];
82 82
 
83
-    return new Response(new Value($first->scalarval() .
83
+    return new Response(new Value($first->scalarval().
84 84
         $last->scalarval(), Value::$xmlrpcString));
85 85
 }
86 86
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     $larry = $fools["larry"];
115 115
     $moe = $fools["moe"];
116 116
 
117
-    return new Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
117
+    return new Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
118 118
 }
119 119
 
120 120
 $v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     $ap = 0;
129 129
     $qu = 0;
130 130
     $amp = 0;
131
-    for ($i = 0; $i < strlen($str); $i++) {
131
+    for ($i = 0; $i<strlen($str); $i++) {
132 132
         $c = substr($str, $i, 1);
133 133
         switch ($c) {
134 134
             case ">":
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $val = reset($ar);
108 108
         $typ = key($ar);
109 109
 
110
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
110
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
111 111
         //}
112 112
     }
113 113
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         // preserve back compatibility
127 127
 
128 128
         if (is_array($b)) {
129
-            foreach($b as $id => $cont) {
129
+            foreach ($b as $id => $cont) {
130 130
                 $b[$id] = $cont->scalarval();
131 131
             }
132 132
         }
@@ -134,10 +134,10 @@  discard block
 block discarded – undo
134 134
         // add support for structures directly encoding php objects
135 135
         if (is_object($b)) {
136 136
             $t = get_object_vars($b);
137
-            foreach($t as $id => $cont) {
137
+            foreach ($t as $id => $cont) {
138 138
                 $t[$id] = $cont->scalarval();
139 139
             }
140
-            foreach($t as $id => $cont) {
140
+            foreach ($t as $id => $cont) {
141 141
                 @$b->$id = $cont;
142 142
             }
143 143
         }
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
 /* Expose as global functions the ones which are now class methods */
180 180
 
181 181
 /// Wrong speling, but we are adamant on backwards compatibility!
182
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
182
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
183 183
 {
184 184
     return Charset::instance()->encodeEntities($data, $srcEncoding, $destEncoding);
185 185
 }
186 186
 
187
-function iso8601_encode($timeT, $utc=0)
187
+function iso8601_encode($timeT, $utc = 0)
188 188
 {
189 189
     return Date::iso8601Encode($timeT, $utc);
190 190
 }
191 191
 
192
-function iso8601_decode($iDate, $utc=0)
192
+function iso8601_decode($iDate, $utc = 0)
193 193
 {
194 194
     return Date::iso8601Decode($iDate, $utc);
195 195
 }
@@ -199,25 +199,25 @@  discard block
 block discarded – undo
199 199
     return Http::decodeChunked($buffer);
200 200
 }
201 201
 
202
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
202
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
203 203
 {
204 204
     $encoder = new Encoder();
205 205
     return $encoder->decode($xmlrpcVal, $options);
206 206
 }
207 207
 
208
-function php_xmlrpc_encode($phpVal, $options=array())
208
+function php_xmlrpc_encode($phpVal, $options = array())
209 209
 {
210 210
     $encoder = new Encoder();
211 211
     return $encoder->encode($phpVal, $options);
212 212
 }
213 213
 
214
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
214
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
215 215
 {
216 216
     $encoder = new Encoder();
217 217
     return $encoder->decodeXml($xmlVal, $options);
218 218
 }
219 219
 
220
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
220
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
221 221
 {
222 222
     return XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
223 223
 }
Please login to merge, or discard this patch.
demo/server/methodProviders/wrapper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -27,11 +27,11 @@  discard block
 block discarded – undo
27 27
 {
28 28
     global $stateNames;
29 29
 
30
-    if (isset($stateNames[$stateNo - 1])) {
31
-        return $stateNames[$stateNo - 1];
30
+    if (isset($stateNames[$stateNo-1])) {
31
+        return $stateNames[$stateNo-1];
32 32
     } else {
33 33
         // not, there so complain
34
-        throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
34
+        throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
35 35
     }
36 36
 }
37 37
 
@@ -125,13 +125,13 @@  discard block
 block discarded – undo
125 125
 
126 126
 $findstate10_sig = array(
127 127
     /// @todo add a demo/test with a closure
128
-    "function" => function ($req) { return findState($req); },
128
+    "function" => function($req) { return findState($req); },
129 129
     "signature" => array(array(Value::$xmlrpcString, Value::$xmlrpcInt)),
130
-    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the ' .
130
+    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the '.
131 131
         'index of that state name in an alphabetic order.',
132 132
 );
133 133
 
134
-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return plain_findstate($stateNo); });
134
+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return plain_findstate($stateNo); });
135 135
 
136 136
 /// @todo do we really need a new instance ?
137 137
 $c = new xmlrpcServerMethodsContainer();
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
 $namespaceSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'namespacetest.', 'replace_class_name' => true, 'method_filter' => '/^findState$/', 'method_type' => 'static'));
142 142
 
143
-$returnObj_sig =  $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
143
+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
144 144
 
145 145
 return array_merge(
146 146
     array(
Please login to merge, or discard this patch.
src/Client.php 1 patch
Spacing   +64 added lines, -64 removed lines patch added patch discarded remove patch
@@ -157,10 +157,10 @@  discard block
 block discarded – undo
157 157
             $server = $parts['host'];
158 158
             $path = isset($parts['path']) ? $parts['path'] : '';
159 159
             if (isset($parts['query'])) {
160
-                $path .= '?' . $parts['query'];
160
+                $path .= '?'.$parts['query'];
161 161
             }
162 162
             if (isset($parts['fragment'])) {
163
-                $path .= '#' . $parts['fragment'];
163
+                $path .= '#'.$parts['fragment'];
164 164
             }
165 165
             if (isset($parts['port'])) {
166 166
                 $port = $parts['port'];
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
             }
177 177
         }
178 178
         if ($path == '' || $path[0] != '/') {
179
-            $this->path = '/' . $path;
179
+            $this->path = '/'.$path;
180 180
         } else {
181 181
             $this->path = $path;
182 182
         }
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
         }*/
215 215
 
216 216
         // initialize user_agent string
217
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
217
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
218 218
     }
219 219
 
220 220
     /**
@@ -592,7 +592,7 @@  discard block
 block discarded – undo
592 592
      */
593 593
     protected function sendPayloadHTTP10($req, $server, $port, $timeout = 0, $username = '', $password = '',
594 594
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
595
-        $method='http')
595
+        $method = 'http')
596 596
     {
597 597
         //trigger_error('Method ' . __METHOD__ . ' is deprecated', E_USER_DEPRECATED);
598 598
 
@@ -624,7 +624,7 @@  discard block
 block discarded – undo
624 624
      * @param int $sslVersion
625 625
      * @return Response
626 626
      */
627
-    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '',  $password = '',
627
+    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '', $password = '',
628 628
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
629 629
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
630 630
         $sslVersion = 0)
@@ -663,13 +663,13 @@  discard block
 block discarded – undo
663 663
      */
664 664
     protected function sendPayloadSocket($req, $server, $port, $timeout = 0, $username = '', $password = '',
665 665
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
666
-        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method='http', $key = '', $keyPass = '',
666
+        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'http', $key = '', $keyPass = '',
667 667
         $sslVersion = 0)
668 668
     {
669 669
         /// @todo log a warning if passed an unsupported method
670 670
 
671 671
         if ($port == 0) {
672
-            $port = ( $method === 'https' ) ? 443 : 80;
672
+            $port = ($method === 'https') ? 443 : 80;
673 673
         }
674 674
 
675 675
         // Only create the payload if it was not created previously
@@ -699,15 +699,15 @@  discard block
 block discarded – undo
699 699
         // thanks to Grant Rauscher <[email protected]> for this
700 700
         $credentials = '';
701 701
         if ($username != '') {
702
-            $credentials = 'Authorization: Basic ' . base64_encode($username . ':' . $password) . "\r\n";
702
+            $credentials = 'Authorization: Basic '.base64_encode($username.':'.$password)."\r\n";
703 703
             if ($authType != 1) {
704
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
704
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
705 705
             }
706 706
         }
707 707
 
708 708
         $acceptedEncoding = '';
709 709
         if (is_array($this->accepted_compression) && count($this->accepted_compression)) {
710
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $this->accepted_compression) . "\r\n";
710
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $this->accepted_compression)."\r\n";
711 711
         }
712 712
 
713 713
         $proxyCredentials = '';
@@ -718,17 +718,17 @@  discard block
 block discarded – undo
718 718
             $connectServer = $proxyHost;
719 719
             $connectPort = $proxyPort;
720 720
             $transport = 'tcp';
721
-            $uri = 'http://' . $server . ':' . $port . $this->path;
721
+            $uri = 'http://'.$server.':'.$port.$this->path;
722 722
             if ($proxyUsername != '') {
723 723
                 if ($proxyAuthType != 1) {
724
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
724
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
725 725
                 }
726
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($proxyUsername . ':' . $proxyPassword) . "\r\n";
726
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($proxyUsername.':'.$proxyPassword)."\r\n";
727 727
             }
728 728
         } else {
729 729
             $connectServer = $server;
730 730
             $connectPort = $port;
731
-            $transport = ( $method === 'https' ) ? 'tls' : 'tcp';
731
+            $transport = ($method === 'https') ? 'tls' : 'tcp';
732 732
             $uri = $this->path;
733 733
         }
734 734
 
@@ -738,45 +738,45 @@  discard block
 block discarded – undo
738 738
             $version = '';
739 739
             foreach ($this->cookies as $name => $cookie) {
740 740
                 if ($cookie['version']) {
741
-                    $version = ' $Version="' . $cookie['version'] . '";';
742
-                    $cookieHeader .= ' ' . $name . '="' . $cookie['value'] . '";';
741
+                    $version = ' $Version="'.$cookie['version'].'";';
742
+                    $cookieHeader .= ' '.$name.'="'.$cookie['value'].'";';
743 743
                     if ($cookie['path']) {
744
-                        $cookieHeader .= ' $Path="' . $cookie['path'] . '";';
744
+                        $cookieHeader .= ' $Path="'.$cookie['path'].'";';
745 745
                     }
746 746
                     if ($cookie['domain']) {
747
-                        $cookieHeader .= ' $Domain="' . $cookie['domain'] . '";';
747
+                        $cookieHeader .= ' $Domain="'.$cookie['domain'].'";';
748 748
                     }
749 749
                     if ($cookie['port']) {
750
-                        $cookieHeader .= ' $Port="' . $cookie['port'] . '";';
750
+                        $cookieHeader .= ' $Port="'.$cookie['port'].'";';
751 751
                     }
752 752
                 } else {
753
-                    $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
753
+                    $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
754 754
                 }
755 755
             }
756
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
756
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
757 757
         }
758 758
 
759 759
         // omit port if default
760 760
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
761
-            $port =  '';
761
+            $port = '';
762 762
         } else {
763
-            $port = ':' . $port;
763
+            $port = ':'.$port;
764 764
         }
765 765
 
766
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
767
-            'User-Agent: ' . $this->user_agent . "\r\n" .
768
-            'Host: ' . $server . $port . "\r\n" .
769
-            $credentials .
770
-            $proxyCredentials .
771
-            $acceptedEncoding .
772
-            $encodingHdr .
773
-            'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings) . "\r\n" .
774
-            $cookieHeader .
775
-            'Content-Type: ' . $req->content_type . "\r\nContent-Length: " .
776
-            strlen($payload) . "\r\n\r\n" .
766
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
767
+            'User-Agent: '.$this->user_agent."\r\n".
768
+            'Host: '.$server.$port."\r\n".
769
+            $credentials.
770
+            $proxyCredentials.
771
+            $acceptedEncoding.
772
+            $encodingHdr.
773
+            'Accept-Charset: '.implode(',', $this->accepted_charset_encodings)."\r\n".
774
+            $cookieHeader.
775
+            'Content-Type: '.$req->content_type."\r\nContent-Length: ".
776
+            strlen($payload)."\r\n\r\n".
777 777
             $payload;
778 778
 
779
-        if ($this->debug > 1) {
779
+        if ($this->debug>1) {
780 780
             $this->getLogger()->debugMessage("---SENDING---\n$op\n---END---");
781 781
         }
782 782
 
@@ -803,7 +803,7 @@  discard block
 block discarded – undo
803 803
 
804 804
         $context = stream_context_create($contextOptions);
805 805
 
806
-        if ($timeout <= 0) {
806
+        if ($timeout<=0) {
807 807
             $connectTimeout = ini_get('default_socket_timeout');
808 808
         } else {
809 809
             $connectTimeout = $timeout;
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
816 816
             STREAM_CLIENT_CONNECT, $context);
817 817
         if ($fp) {
818
-            if ($timeout > 0) {
818
+            if ($timeout>0) {
819 819
                 stream_set_timeout($fp, $timeout);
820 820
             }
821 821
         } else {
@@ -824,8 +824,8 @@  discard block
 block discarded – undo
824 824
                 $this->errstr = $err['message'];
825 825
             }
826 826
 
827
-            $this->errstr = 'Connect error: ' . $this->errstr;
828
-            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
827
+            $this->errstr = 'Connect error: '.$this->errstr;
828
+            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
829 829
 
830 830
             return $r;
831 831
         }
@@ -914,13 +914,13 @@  discard block
 block discarded – undo
914 914
 
915 915
         $result = curl_exec($curl);
916 916
 
917
-        if ($this->debug > 1) {
917
+        if ($this->debug>1) {
918 918
             $message = "---CURL INFO---\n";
919 919
             foreach (curl_getinfo($curl) as $name => $val) {
920 920
                 if (is_array($val)) {
921 921
                     $val = implode("\n", $val);
922 922
                 }
923
-                $message .= $name . ': ' . $val . "\n";
923
+                $message .= $name.': '.$val."\n";
924 924
             }
925 925
             $message .= '---END---';
926 926
             $this->getLogger()->debugMessage($message);
@@ -930,7 +930,7 @@  discard block
 block discarded – undo
930 930
             /// @todo we should use a better check here - what if we get back '' or '0'?
931 931
 
932 932
             $this->errstr = 'no response';
933
-            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . curl_error($curl));
933
+            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.curl_error($curl));
934 934
             curl_close($curl);
935 935
             if ($keepAlive) {
936 936
                 $this->xmlrpc_curl_handle = null;
@@ -999,7 +999,7 @@  discard block
 block discarded – undo
999 999
                     $protocol = $method;
1000 1000
                 }
1001 1001
             }
1002
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $this->path);
1002
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$this->path);
1003 1003
             if ($keepAlive) {
1004 1004
                 $this->xmlrpc_curl_handle = $curl;
1005 1005
             }
@@ -1010,7 +1010,7 @@  discard block
 block discarded – undo
1010 1010
         // results into variable
1011 1011
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1012 1012
 
1013
-        if ($this->debug > 1) {
1013
+        if ($this->debug>1) {
1014 1014
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1015 1015
             /// @todo allow callers to redirect curlopt_stderr to some stream which can be buffered
1016 1016
         }
@@ -1035,7 +1035,7 @@  discard block
 block discarded – undo
1035 1035
             }
1036 1036
         }
1037 1037
         // extra headers
1038
-        $headers = array('Content-Type: ' . $req->content_type, 'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings));
1038
+        $headers = array('Content-Type: '.$req->content_type, 'Accept-Charset: '.implode(',', $this->accepted_charset_encodings));
1039 1039
         // if no keepalive is wanted, let the server know it in advance
1040 1040
         if (!$keepAlive) {
1041 1041
             $headers[] = 'Connection: close';
@@ -1052,10 +1052,10 @@  discard block
 block discarded – undo
1052 1052
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
1053 1053
         // timeout is borked
1054 1054
         if ($timeout) {
1055
-            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout - 1);
1055
+            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout-1);
1056 1056
         }
1057 1057
 
1058
-        switch($method) {
1058
+        switch ($method) {
1059 1059
             case 'http10':
1060 1060
                 curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
1061 1061
                 break;
@@ -1071,11 +1071,11 @@  discard block
 block discarded – undo
1071 1071
         }
1072 1072
 
1073 1073
         if ($username && $password) {
1074
-            curl_setopt($curl, CURLOPT_USERPWD, $username . ':' . $password);
1074
+            curl_setopt($curl, CURLOPT_USERPWD, $username.':'.$password);
1075 1075
             if (defined('CURLOPT_HTTPAUTH')) {
1076 1076
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $authType);
1077 1077
             } elseif ($authType != 1) {
1078
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1078
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1079 1079
             }
1080 1080
         }
1081 1081
 
@@ -1117,13 +1117,13 @@  discard block
 block discarded – undo
1117 1117
             if ($proxyPort == 0) {
1118 1118
                 $proxyPort = 8080; // NB: even for HTTPS, local connection is on port 8080
1119 1119
             }
1120
-            curl_setopt($curl, CURLOPT_PROXY, $proxyHost . ':' . $proxyPort);
1120
+            curl_setopt($curl, CURLOPT_PROXY, $proxyHost.':'.$proxyPort);
1121 1121
             if ($proxyUsername) {
1122
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername . ':' . $proxyPassword);
1122
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername.':'.$proxyPassword);
1123 1123
                 if (defined('CURLOPT_PROXYAUTH')) {
1124 1124
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $proxyAuthType);
1125 1125
                 } elseif ($proxyAuthType != 1) {
1126
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1126
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1127 1127
                 }
1128 1128
             }
1129 1129
         }
@@ -1133,7 +1133,7 @@  discard block
 block discarded – undo
1133 1133
         if (count($this->cookies)) {
1134 1134
             $cookieHeader = '';
1135 1135
             foreach ($this->cookies as $name => $cookie) {
1136
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1136
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1137 1137
             }
1138 1138
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1139 1139
         }
@@ -1142,7 +1142,7 @@  discard block
 block discarded – undo
1142 1142
             curl_setopt($curl, $opt, $val);
1143 1143
         }
1144 1144
 
1145
-        if ($this->debug > 1) {
1145
+        if ($this->debug>1) {
1146 1146
             $this->getLogger()->debugMessage("---SENDING---\n$payload\n---END---");
1147 1147
         }
1148 1148
 
@@ -1240,7 +1240,7 @@  discard block
 block discarded – undo
1240 1240
             $call['methodName'] = new Value($req->method(), 'string');
1241 1241
             $numParams = $req->getNumParams();
1242 1242
             $params = array();
1243
-            for ($i = 0; $i < $numParams; $i++) {
1243
+            for ($i = 0; $i<$numParams; $i++) {
1244 1244
                 $params[$i] = $req->getParam($i);
1245 1245
             }
1246 1246
             $call['params'] = new Value($params, 'array');
@@ -1266,15 +1266,15 @@  discard block
 block discarded – undo
1266 1266
             /// @todo test this code branch...
1267 1267
             $rets = $result->value();
1268 1268
             if (!is_array($rets)) {
1269
-                return false;       // bad return type from system.multicall
1269
+                return false; // bad return type from system.multicall
1270 1270
             }
1271 1271
             $numRets = count($rets);
1272 1272
             if ($numRets != count($reqs)) {
1273
-                return false;       // wrong number of return values.
1273
+                return false; // wrong number of return values.
1274 1274
             }
1275 1275
 
1276 1276
             $response = array();
1277
-            for ($i = 0; $i < $numRets; $i++) {
1277
+            for ($i = 0; $i<$numRets; $i++) {
1278 1278
                 $val = $rets[$i];
1279 1279
                 if (!is_array($val)) {
1280 1280
                     return false;
@@ -1282,7 +1282,7 @@  discard block
 block discarded – undo
1282 1282
                 switch (count($val)) {
1283 1283
                     case 1:
1284 1284
                         if (!isset($val[0])) {
1285
-                            return false;       // Bad value
1285
+                            return false; // Bad value
1286 1286
                         }
1287 1287
                         // Normal return value
1288 1288
                         $response[$i] = new Response($val[0], 0, '', 'phpvals');
@@ -1310,19 +1310,19 @@  discard block
 block discarded – undo
1310 1310
 
1311 1311
             $rets = $result->value();
1312 1312
             if ($rets->kindOf() != 'array') {
1313
-                return false;       // bad return type from system.multicall
1313
+                return false; // bad return type from system.multicall
1314 1314
             }
1315 1315
             $numRets = $rets->count();
1316 1316
             if ($numRets != count($reqs)) {
1317
-                return false;       // wrong number of return values.
1317
+                return false; // wrong number of return values.
1318 1318
             }
1319 1319
 
1320 1320
             $response = array();
1321
-            foreach($rets as $val) {
1321
+            foreach ($rets as $val) {
1322 1322
                 switch ($val->kindOf()) {
1323 1323
                     case 'array':
1324 1324
                         if ($val->count() != 1) {
1325
-                            return false;       // Bad value
1325
+                            return false; // Bad value
1326 1326
                         }
1327 1327
                         // Normal return value
1328 1328
                         $response[] = new Response($val[0]);
Please login to merge, or discard this patch.