Passed
Push — master ( f91eab...402905 )
by Gaetano
06:20
created
debugger/action.php 2 patches
Braces   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,12 @@  discard block
 block discarded – undo
15 15
 <html lang="en">
16 16
 <head>
17 17
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
18
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSON-RPC'; else echo 'XML-RPC'; ?> Debugger</title>
18
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
19
+    echo 'JSON-RPC';
20
+} else {
21
+    echo 'XML-RPC';
22
+}
23
+?> Debugger</title>
19 24
     <meta name="robots" content="index,nofollow"/>
20 25
     <style type="text/css">
21 26
         <!--
@@ -367,7 +372,9 @@  discard block
 block discarded – undo
367 372
                                 echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
368 373
                                 if ($x->count() > 1) {
369 374
                                     foreach($x as $k => $y) {
370
-                                        if ($k == 0) continue;
375
+                                        if ($k == 0) {
376
+                                            continue;
377
+                                        }
371 378
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
372 379
                                         if ($wstype == 1) {
373 380
                                             switch($y->scalarval()) {
Please login to merge, or discard this patch.
Spacing   +115 added lines, -115 removed lines patch added patch discarded remove patch
@@ -78,13 +78,13 @@  discard block
 block discarded – undo
78 78
 <body>
79 79
 <?php
80 80
 
81
-include __DIR__ . '/common.php';
81
+include __DIR__.'/common.php';
82 82
 
83 83
 if ($action) {
84 84
 
85 85
     // avoid php hanging when using the builtin webserver and sending requests to itself
86 86
     $skip = false;
87
-    if (php_sapi_name() === 'cli-server' && ((int)getenv('PHP_CLI_SERVER_WORKERS') < 2)) {
87
+    if (php_sapi_name() === 'cli-server' && ((int) getenv('PHP_CLI_SERVER_WORKERS')<2)) {
88 88
         $localHost = explode(':', $_SERVER['HTTP_HOST']);
89 89
         /// @todo support also case where port is null (on either side), and when there is a Proxy in the parameters,
90 90
         ///       and that proxy is us
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     if (!$skip) {
98 98
         // make sure the script waits long enough for the call to complete...
99 99
         if ($timeout) {
100
-            set_time_limit($timeout + 10);
100
+            set_time_limit($timeout+10);
101 101
         }
102 102
 
103 103
         if ($wstype == 1) {
@@ -118,13 +118,13 @@  discard block
 block discarded – undo
118 118
             $server = "$host$path";
119 119
         }
120 120
         if ($protocol == 2 || $protocol == 3) {
121
-            $server = 'https://' . $server;
121
+            $server = 'https://'.$server;
122 122
         } else {
123
-            $server = 'http://' . $server;
123
+            $server = 'http://'.$server;
124 124
         }
125 125
         if ($proxy != '') {
126 126
             $pproxy = explode(':', $proxy);
127
-            if (count($pproxy) > 1) {
127
+            if (count($pproxy)>1) {
128 128
                 $pport = $pproxy[1];
129 129
             } else {
130 130
                 $pport = 8080;
@@ -199,9 +199,9 @@  discard block
 block discarded – undo
199 199
             case 'wrap':
200 200
                 $msg[0] = new $requestClass('system.methodHelp', array(), $id);
201 201
                 $msg[0]->addparam(new PhpXmlRpc\Value($method));
202
-                $msg[1] = new $requestClass('system.methodSignature', array(), (int)$id + 1);
202
+                $msg[1] = new $requestClass('system.methodSignature', array(), (int) $id+1);
203 203
                 $msg[1]->addparam(new PhpXmlRpc\Value($method));
204
-                $actionname = 'Description of method "' . $method . '"';
204
+                $actionname = 'Description of method "'.$method.'"';
205 205
                 break;
206 206
             case 'list':
207 207
                 $msg[0] = new $requestClass('system.listMethods', array(), $id);
@@ -214,9 +214,9 @@  discard block
 block discarded – undo
214 214
                 $msg[0] = new $requestClass($method, array(), $id);
215 215
                 // hack! build payload by hand
216 216
                 if ($wstype == 1) {
217
-                    $payload = "{\n" .
218
-                        '"method": "' . $method . "\",\n\"params\": [" .
219
-                        $payload .
217
+                    $payload = "{\n".
218
+                        '"method": "'.$method."\",\n\"params\": [".
219
+                        $payload.
220 220
                         "\n],\n\"id\": ";
221 221
                     // fix: if user gave an empty string, use NULL, or we'll break json syntax
222 222
                     if ($id == "") {
@@ -231,22 +231,22 @@  discard block
 block discarded – undo
231 231
                     $msg[0]->setPayload($payload);
232 232
                 } else {
233 233
                     $msg[0]->setPayload(
234
-                        $msg[0]->xml_header($inputcharset) .
235
-                        '<methodName>' . $method . "</methodName>\n<params>" .
236
-                        $payload .
237
-                        "</params>\n" . $msg[0]->xml_footer()
234
+                        $msg[0]->xml_header($inputcharset).
235
+                        '<methodName>'.$method."</methodName>\n<params>".
236
+                        $payload.
237
+                        "</params>\n".$msg[0]->xml_footer()
238 238
                     );
239 239
                 }
240
-                $actionname = 'Execution of method ' . $method;
240
+                $actionname = 'Execution of method '.$method;
241 241
                 break;
242 242
             default: // give a warning
243
-                $actionname = '[ERROR: unknown action] "' . $action . '"';
243
+                $actionname = '[ERROR: unknown action] "'.$action.'"';
244 244
         }
245 245
     }
246 246
 
247 247
     // Before calling execute, echo out brief description of action taken + date and time ???
248 248
     // this gives good user feedback for long-running methods...
249
-    echo '<h2>' . htmlspecialchars($actionname, ENT_COMPAT, $inputcharset) . ' on server ' . htmlspecialchars($server, ENT_COMPAT, $inputcharset) . " ...</h2>\n";
249
+    echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset)." ...</h2>\n";
250 250
     flush();
251 251
 
252 252
     $response = null;
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
             break;
264 264
         }
265 265
     }
266
-    $time = microtime(true) - $time;
266
+    $time = microtime(true)-$time;
267 267
     if ($debug) {
268 268
         echo "</div>\n";
269 269
     }
@@ -273,8 +273,8 @@  discard block
 block discarded – undo
273 273
             // call failed! echo out error msg!
274 274
             //echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset).'</h2>';
275 275
             echo "<h3>$protoName call FAILED!</h3>\n";
276
-            echo "<p>Fault code: [" . htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
277
-                "] Reason: '" . htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "'</p>\n";
276
+            echo "<p>Fault code: [".htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
277
+                "] Reason: '".htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."'</p>\n";
278 278
             echo(date("d/M/Y:H:i:s\n"));
279 279
         } else {
280 280
             // call succeeded: parse results
@@ -290,36 +290,36 @@  discard block
 block discarded – undo
290 290
                         $max = $v->count();
291 291
                         echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
292 292
                         echo "<thead>\n<tr><th>Method ($max)</th><th>Description</th></tr>\n</thead>\n<tbody>\n";
293
-                        foreach($v as $i => $rec) {
293
+                        foreach ($v as $i => $rec) {
294 294
                             if ($i % 2) {
295 295
                                 $class = ' class="oddrow"';
296 296
                             } else {
297 297
                                 $class = ' class="evenrow"';
298 298
                             }
299
-                            echo("<tr><td$class>" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">" .
300
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
301
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
302
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
303
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
304
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
305
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
306
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
307
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
308
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
309
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
310
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
311
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
312
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
313
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
314
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
315
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
316
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
317
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
318
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
319
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "\" />" .
320
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
321
-                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />" .
322
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
299
+                            echo("<tr><td$class>".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">".
300
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
301
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
302
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
303
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
304
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
305
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
306
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
307
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
308
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
309
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
310
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
311
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
312
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
313
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
314
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
315
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
316
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
317
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
318
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
319
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."\" />".
320
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
321
+                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />".
322
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
323 323
                                 "<input type=\"submit\" value=\"Describe\" /></form></td>");
324 324
                             //echo("</tr>\n");
325 325
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                     $r2 = $resp[1]->value();
347 347
 
348 348
                     echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
349
-                    echo "<thead>\n<tr><th>Method</th><th>" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
349
+                    echo "<thead>\n<tr><th>Method</th><th>".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
350 350
                     $desc = htmlspecialchars($r1->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
351 351
                     if ($desc == "") {
352 352
                         $desc = "-";
@@ -356,24 +356,24 @@  discard block
 block discarded – undo
356 356
                     if ($r2->kindOf() != "array") {
357 357
                         echo "<tr><td class=\"oddrow\">Signature</td><td class=\"oddrow\">Unknown</td><td class=\"oddrow\">&nbsp;</td></tr>\n";
358 358
                     } else {
359
-                        foreach($r2 as $i => $x) {
359
+                        foreach ($r2 as $i => $x) {
360 360
                             $payload = "";
361 361
                             $alt_payload = "";
362
-                            if ($i + 1 % 2) {
362
+                            if ($i+1 % 2) {
363 363
                                 $class = ' class="oddrow"';
364 364
                             } else {
365 365
                                 $class = ' class="evenrow"';
366 366
                             }
367
-                            echo "<tr><td$class>Signature&nbsp;" . ($i + 1) . "</td><td$class>";
367
+                            echo "<tr><td$class>Signature&nbsp;".($i+1)."</td><td$class>";
368 368
                             if ($x->kindOf() == "array") {
369 369
                                 $ret = $x[0];
370
-                                echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
371
-                                if ($x->count() > 1) {
372
-                                    foreach($x as $k => $y) {
370
+                                echo "<code>OUT:&nbsp;".htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."<br />IN: (";
371
+                                if ($x->count()>1) {
372
+                                    foreach ($x as $k => $y) {
373 373
                                         if ($k == 0) continue;
374 374
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
375 375
                                         if ($wstype == 1) {
376
-                                            switch($y->scalarval()) {
376
+                                            switch ($y->scalarval()) {
377 377
                                                 case 'string':
378 378
                                                 case 'dateTime.iso8601':
379 379
                                                 case 'base64':
@@ -406,22 +406,22 @@  discard block
 block discarded – undo
406 406
                                         } else {
407 407
                                             $type = $y->scalarval();
408 408
                                             $payload .= '<param><value>';
409
-                                            switch($type) {
409
+                                            switch ($type) {
410 410
                                                 case 'undefined':
411 411
                                                     break;
412 412
                                                 case 'null';
413 413
                                                     $type = 'nil';
414 414
                                                     // fall thru intentionally
415 415
                                                 default:
416
-                                                    $payload .= '<' .
417
-                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
418
-                                                        '></' . htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
416
+                                                    $payload .= '<'.
417
+                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
418
+                                                        '></'.htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
419 419
                                                         '>';
420 420
                                             }
421 421
                                             $payload .= "</value></param>\n";
422 422
                                         }
423 423
                                         $alt_payload .= $y->scalarval();
424
-                                        if ($k < $x->count() - 1) {
424
+                                        if ($k<$x->count()-1) {
425 425
                                             $alt_payload .= ';';
426 426
                                             if ($wstype == 1) {
427 427
                                                 $payload .= ', ';
@@ -437,63 +437,63 @@  discard block
 block discarded – undo
437 437
                             echo '</td>';
438 438
                             // button to test this method
439 439
                             //$payload="<methodCall>\n<methodName>$method</methodName>\n<params>\n$payload</params>\n</methodCall>";
440
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
441
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
442
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
443
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
444
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
445
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
446
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
447
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
448
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
449
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
450
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
451
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
452
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
453
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
454
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
455
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
456
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
457
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
458
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
459
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
460
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
461
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
462
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
463
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
440
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
441
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
442
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
443
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
444
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
445
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
446
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
447
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
448
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
449
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
450
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
451
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
452
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
453
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
454
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
455
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
456
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
457
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
458
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
459
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
460
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
461
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
462
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
463
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
464 464
                                 "<input type=\"hidden\" name=\"action\" value=\"execute\" />";
465 465
                             //if ($wstype != 1) {
466 466
                                 echo "<input type=\"submit\" value=\"Load method synopsis\" />";
467 467
                             //}
468 468
                             echo "</form></td>\n";
469 469
 
470
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
471
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
472
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
473
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
474
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
475
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
476
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
477
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
478
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
479
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
480
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
481
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
482
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
483
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
484
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
485
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
486
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
487
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
488
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
489
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
490
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
491
-                                "<input type=\"hidden\" name=\"methodsig\" value=\"" . $i . "\" />" .
492
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
493
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
494
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
495
-                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />" .
496
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
470
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
471
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
472
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
473
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
474
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
475
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
476
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
477
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
478
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
479
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
480
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
481
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
482
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
483
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
484
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
485
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
486
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
487
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
488
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
489
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
490
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
491
+                                "<input type=\"hidden\" name=\"methodsig\" value=\"".$i."\" />".
492
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
493
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
494
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
495
+                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />".
496
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
497 497
                                 "<input type=\"submit\" value=\"Generate method call stub code\" />";
498 498
                             echo "</form></td></tr>\n";
499 499
                         }
@@ -505,14 +505,14 @@  discard block
 block discarded – undo
505 505
                 case 'wrap':
506 506
                     $r1 = $resp[0]->value();
507 507
                     $r2 = $resp[1]->value();
508
-                    if ($r2->kindOf() != "array" || $r2->count() <= $methodsig) {
508
+                    if ($r2->kindOf() != "array" || $r2->count()<=$methodsig) {
509 509
                         echo "Error: signature unknown\n";
510 510
                     } else {
511 511
                         $mdesc = $r1->scalarval();
512 512
                         $encoder = new PhpXmlRpc\Encoder();
513 513
                         $msig = $encoder->decode($r2);
514 514
                         $msig = $msig[$methodsig];
515
-                        $proto = ($protocol == 1) ? 'http11' : ( $protocol == 2 ? 'https' : ( $protocol == 3 ? 'h2' : ( $protocol == 4 ? 'h2c' : '' ) ) );
515
+                        $proto = ($protocol == 1) ? 'http11' : ($protocol == 2 ? 'https' : ($protocol == 3 ? 'h2' : ($protocol == 4 ? 'h2c' : '')));
516 516
                         if ($proxy == '' && $username == '' && !$requestcompression && !$responsecompression &&
517 517
                             $clientcookies == '') {
518 518
                             $opts = 1; // simple client copy in stub code
@@ -533,12 +533,12 @@  discard block
 block discarded – undo
533 533
                             $client,
534 534
                             $method,
535 535
                             array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix, 'throw_on_fault' => true),
536
-                            str_replace('.', '_', $prefix . '_' . $method), $msig, $mdesc
536
+                            str_replace('.', '_', $prefix.'_'.$method), $msig, $mdesc
537 537
                         );
538 538
                         //if ($code)
539 539
                         //{
540 540
                         echo "<div id=\"phpcode\">\n";
541
-                        highlight_string("<?php\n" . $code['docstring'] . $code['source']);
541
+                        highlight_string("<?php\n".$code['docstring'].$code['source']);
542 542
                         echo "\n</div>";
543 543
                         //}
544 544
                         //else
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
                     break;
550 550
 
551 551
                 case 'execute':
552
-                    echo '<div id="response"><h2>Response:</h2>' . htmlspecialchars($response->serialize()) . '</div>';
552
+                    echo '<div id="response"><h2>Response:</h2>'.htmlspecialchars($response->serialize()).'</div>';
553 553
                     break;
554 554
 
555 555
                 default: // give a warning
Please login to merge, or discard this patch.
debugger/common.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     // assume this is either a standalone install, or installed as Composer dependency
21 21
     /// @todo if the latter is true, should we just not skip using the custom Autoloader, and let a top-level
22 22
     ///       debugger include this one, taking care of autoloading?
23
-    include_once __DIR__ . "/../src/Autoloader.php";
23
+    include_once __DIR__."/../src/Autoloader.php";
24 24
     PhpXmlRpc\Autoloader::register();
25 25
 }
26 26
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         }
35 35
 
36 36
         // Variables that shouldn't be unset
37
-        $noUnset = array('GLOBALS',  '_GET', '_POST', '_COOKIE', '_REQUEST', '_SERVER', '_ENV', '_FILES');
37
+        $noUnset = array('GLOBALS', '_GET', '_POST', '_COOKIE', '_REQUEST', '_SERVER', '_ENV', '_FILES');
38 38
 
39 39
         $input = array_merge($_GET, $_POST, $_COOKIE, $_SERVER, $_ENV, $_FILES,
40 40
             isset($_SESSION) && is_array($_SESSION) ? $_SESSION : array()
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 $id = '';
87 87
 if (isset($_GET['action'])) {
88 88
     if (isset($_GET['wstype']) && ($_GET['wstype'] == '1' || $_GET['wstype'] == '0')) {
89
-        $wstype = (int)$_GET['wstype'];
89
+        $wstype = (int) $_GET['wstype'];
90 90
         if ($wstype === 1 && !$hasjsonrpcclient) {
91 91
             $wstype = 0;
92 92
         }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     $host = isset($_GET['host']) ? $_GET['host'] : 'localhost'; // using '' will trigger an xml-rpc error...
98 98
     if (isset($_GET['protocol']) && ($_GET['protocol'] == '1' || $_GET['protocol'] == '2' || $_GET['protocol'] == '3'
99 99
         || $_GET['protocol'] == '4')) {
100
-        $protocol = (int)$_GET['protocol'];
100
+        $protocol = (int) $_GET['protocol'];
101 101
     }
102 102
     if (strpos($host, 'http://') === 0) {
103 103
         // NB: if protocol is https or h2, it will override http://
@@ -109,18 +109,18 @@  discard block
 block discarded – undo
109 109
             $protocol = 2;
110 110
         }
111 111
     }
112
-    $port = isset($_GET['port']) ? (int)$_GET['port'] : '';
112
+    $port = isset($_GET['port']) ? (int) $_GET['port'] : '';
113 113
     if ($port === 0) {
114 114
         $port = '';
115 115
     }
116 116
     $path = isset($_GET['path']) ? $_GET['path'] : '';
117 117
     // in case user forgot initial '/' in xml-rpc server path, add it back
118 118
     if ($path && ($path[0]) != '/') {
119
-        $path = '/' . $path;
119
+        $path = '/'.$path;
120 120
     }
121 121
 
122 122
     if (isset($_GET['debug']) && ($_GET['debug'] == '1' || $_GET['debug'] == '2')) {
123
-        $debug = (int)$_GET['debug'];
123
+        $debug = (int) $_GET['debug'];
124 124
     }
125 125
 
126 126
     $verifyhost = (isset($_GET['verifyhost']) && ($_GET['verifyhost'] == '1' || $_GET['verifyhost'] == '2')) ? $_GET['verifyhost'] : 0;
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     /// @todo what about an https proxy?
138 138
     $proxyuser = isset($_GET['proxyuser']) ? $_GET['proxyuser'] : '';
139 139
     $proxypwd = isset($_GET['proxypwd']) ? $_GET['proxypwd'] : '';
140
-    $timeout = isset($_GET['timeout']) ? (int)$_GET['timeout'] : 0;
140
+    $timeout = isset($_GET['timeout']) ? (int) $_GET['timeout'] : 0;
141 141
     $action = $_GET['action'];
142 142
 
143 143
     $method = isset($_GET['method']) ? $_GET['method'] : '';
@@ -152,15 +152,15 @@  discard block
 block discarded – undo
152 152
     $username = isset($_GET['username']) ? $_GET['username'] : '';
153 153
     $password = isset($_GET['password']) ? $_GET['password'] : '';
154 154
 
155
-    $authtype = (isset($_GET['authtype']) && ($_GET['authtype'] == '2' || $_GET['authtype'] == '8')) ? (int)$_GET['authtype'] : 1;
155
+    $authtype = (isset($_GET['authtype']) && ($_GET['authtype'] == '2' || $_GET['authtype'] == '8')) ? (int) $_GET['authtype'] : 1;
156 156
 
157 157
     if (isset($_GET['requestcompression']) && ($_GET['requestcompression'] == '1' || $_GET['requestcompression'] == '2')) {
158
-        (int)$requestcompression = $_GET['requestcompression'];
158
+        (int) $requestcompression = $_GET['requestcompression'];
159 159
     } else {
160 160
         $requestcompression = 0;
161 161
     }
162 162
     if (isset($_GET['responsecompression']) && ($_GET['responsecompression'] == '1' || $_GET['responsecompression'] == '2' || $_GET['responsecompression'] == '3')) {
163
-        $responsecompression = (int)$_GET['responsecompression'];
163
+        $responsecompression = (int) $_GET['responsecompression'];
164 164
     } else {
165 165
         $responsecompression = 0;
166 166
     }
Please login to merge, or discard this patch.
src/Wrapper.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -605,8 +605,9 @@
 block discarded – undo
605 605
         }
606 606
         foreach ($parsVariations as $i => $pars) {
607 607
             $innerCode .= "  if (\$paramCount == " . count($pars) . ") \$retVal = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
608
-            if ($i < (count($parsVariations) - 1))
609
-                $innerCode .= "  else\n";
608
+            if ($i < (count($parsVariations) - 1)) {
609
+                            $innerCode .= "  else\n";
610
+            }
610 611
         }
611 612
         $innerCode .= "  if (is_a(\$retVal, '" . static::$namespace . "Response'))\n    return \$retVal;\n  else\n";
612 613
         /// q: why not do the same for int, float, bool, string?
Please login to merge, or discard this patch.
Spacing   +96 added lines, -96 removed lines patch added patch discarded remove patch
@@ -173,20 +173,20 @@  discard block
 block discarded – undo
173 173
             $callable = explode('::', $callable);
174 174
         }
175 175
         if (is_array($callable)) {
176
-            if (count($callable) < 2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
177
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': syntax for function to be wrapped is wrong');
176
+            if (count($callable)<2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
177
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': syntax for function to be wrapped is wrong');
178 178
                 return false;
179 179
             }
180 180
             if (is_string($callable[0])) {
181 181
                 $plainFuncName = implode('::', $callable);
182 182
             } elseif (is_object($callable[0])) {
183
-                $plainFuncName = get_class($callable[0]) . '->' . $callable[1];
183
+                $plainFuncName = get_class($callable[0]).'->'.$callable[1];
184 184
             }
185 185
             $exists = method_exists($callable[0], $callable[1]);
186 186
         } else if ($callable instanceof \Closure) {
187 187
             // we do not support creating code which wraps closures, as php does not allow to serialize them
188 188
             if (!$buildIt) {
189
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': a closure can not be wrapped in generated source code');
189
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': a closure can not be wrapped in generated source code');
190 190
                 return false;
191 191
             }
192 192
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
         }
199 199
 
200 200
         if (!$exists) {
201
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': function to be wrapped is not defined: ' . $plainFuncName);
201
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': function to be wrapped is not defined: '.$plainFuncName);
202 202
             return false;
203 203
         }
204 204
 
@@ -242,23 +242,23 @@  discard block
 block discarded – undo
242 242
         if (is_array($callable)) {
243 243
             $func = new \ReflectionMethod($callable[0], $callable[1]);
244 244
             if ($func->isPrivate()) {
245
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': method to be wrapped is private: ' . $plainFuncName);
245
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': method to be wrapped is private: '.$plainFuncName);
246 246
                 return false;
247 247
             }
248 248
             if ($func->isProtected()) {
249
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': method to be wrapped is protected: ' . $plainFuncName);
249
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': method to be wrapped is protected: '.$plainFuncName);
250 250
                 return false;
251 251
             }
252 252
             if ($func->isConstructor()) {
253
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the constructor: ' . $plainFuncName);
253
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': method to be wrapped is the constructor: '.$plainFuncName);
254 254
                 return false;
255 255
             }
256 256
             if ($func->isDestructor()) {
257
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the destructor: ' . $plainFuncName);
257
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': method to be wrapped is the destructor: '.$plainFuncName);
258 258
                 return false;
259 259
             }
260 260
             if ($func->isAbstract()) {
261
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': method to be wrapped is abstract: ' . $plainFuncName);
261
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': method to be wrapped is abstract: '.$plainFuncName);
262 262
                 return false;
263 263
             }
264 264
             /// @todo add more checks for static vs. nonstatic?
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
         if ($func->isInternal()) {
269 269
             /// @todo from PHP 5.1.0 onward, we should be able to use invokeargs instead of getparameters to fully
270 270
             ///       reflect internal php functions
271
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': function to be wrapped is internal: ' . $plainFuncName);
271
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': function to be wrapped is internal: '.$plainFuncName);
272 272
             return false;
273 273
         }
274 274
 
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         $i = 0;
321 321
         foreach ($func->getParameters() as $paramObj) {
322 322
             $params[$i] = array();
323
-            $params[$i]['name'] = '$' . $paramObj->getName();
323
+            $params[$i]['name'] = '$'.$paramObj->getName();
324 324
             $params[$i]['isoptional'] = $paramObj->isOptional();
325 325
             $i++;
326 326
         }
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             // build a signature
385 385
             $sig = array($this->php2XmlrpcType($funcDesc['returns']));
386 386
             $pSig = array($funcDesc['returnsDocs']);
387
-            for ($i = 0; $i < count($pars); $i++) {
387
+            for ($i = 0; $i<count($pars); $i++) {
388 388
                 $name = strtolower($funcDesc['params'][$i]['name']);
389 389
                 if (isset($funcDesc['paramDocs'][$name]['type'])) {
390 390
                     $sig[] = $this->php2XmlrpcType($funcDesc['paramDocs'][$name]['type']);
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
                 }
441 441
             }
442 442
             $numPars = $req->getNumParams();
443
-            if ($numPars < $minPars || $numPars > $maxPars) {
443
+            if ($numPars<$minPars || $numPars>$maxPars) {
444 444
                 return new $responseClass(0, 3, 'Incorrect parameters passed to method');
445 445
             }
446 446
 
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
 
454 454
             $result = call_user_func_array($callable, $params);
455 455
 
456
-            if (! is_a($result, $responseClass)) {
456
+            if (!is_a($result, $responseClass)) {
457 457
                 // q: why not do the same for int, float, bool, string?
458 458
                 if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
459 459
                     $result = new $valueClass($result, $funcDesc['returns']);
@@ -492,9 +492,9 @@  discard block
 block discarded – undo
492 492
         if ($newFuncName == '') {
493 493
             if (is_array($callable)) {
494 494
                 if (is_string($callable[0])) {
495
-                    $xmlrpcFuncName = "{$prefix}_" . implode('_', $callable);
495
+                    $xmlrpcFuncName = "{$prefix}_".implode('_', $callable);
496 496
                 } else {
497
-                    $xmlrpcFuncName = "{$prefix}_" . get_class($callable[0]) . '_' . $callable[1];
497
+                    $xmlrpcFuncName = "{$prefix}_".get_class($callable[0]).'_'.$callable[1];
498 498
                 }
499 499
             } else {
500 500
                 if ($callable instanceof \Closure) {
@@ -526,9 +526,9 @@  discard block
 block discarded – undo
526 526
      */
527 527
     protected function buildWrapFunctionSource($callable, $newFuncName, $extraOptions, $plainFuncName, $funcDesc)
528 528
     {
529
-        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool)$extraOptions['encode_nulls'] : false;
530
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
531
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
529
+        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool) $extraOptions['encode_nulls'] : false;
530
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
531
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
532 532
         $catchWarnings = isset($extraOptions['suppress_warnings']) && $extraOptions['suppress_warnings'] ? '@' : '';
533 533
 
534 534
         $i = 0;
@@ -563,9 +563,9 @@  discard block
 block discarded – undo
563 563
         // build body of new function
564 564
 
565 565
         $innerCode = "  \$paramCount = \$req->getNumParams();\n";
566
-        $innerCode .= "  if (\$paramCount < $minPars || \$paramCount > $maxPars) return new " . static::$namespace . "Response(0, " . PhpXmlRpc::$xmlrpcerr['incorrect_params'] . ", '" . PhpXmlRpc::$xmlrpcstr['incorrect_params'] . "');\n";
566
+        $innerCode .= "  if (\$paramCount < $minPars || \$paramCount > $maxPars) return new ".static::$namespace."Response(0, ".PhpXmlRpc::$xmlrpcerr['incorrect_params'].", '".PhpXmlRpc::$xmlrpcstr['incorrect_params']."');\n";
567 567
 
568
-        $innerCode .= "  \$encoder = new " . static::$namespace . "Encoder();\n";
568
+        $innerCode .= "  \$encoder = new ".static::$namespace."Encoder();\n";
569 569
         if ($decodePhpObjects) {
570 570
             $innerCode .= "  \$params = \$encoder->decode(\$req, array('decode_php_objs'));\n";
571 571
         } else {
@@ -578,23 +578,23 @@  discard block
 block discarded – undo
578 578
             static::holdObject($newFuncName, $callable[0]);
579 579
             $class = get_class($callable[0]);
580 580
             if ($class[0] !== '\\') {
581
-                $class = '\\' . $class;
581
+                $class = '\\'.$class;
582 582
             }
583 583
             $innerCode .= "  /// @var $class \$obj\n";
584 584
             $innerCode .= "  \$obj = PhpXmlRpc\\Wrapper::getHeldObject('$newFuncName');\n";
585
-            $realFuncName = '$obj->' . $callable[1];
585
+            $realFuncName = '$obj->'.$callable[1];
586 586
         } else {
587 587
             $realFuncName = $plainFuncName;
588 588
         }
589 589
         foreach ($parsVariations as $i => $pars) {
590
-            $innerCode .= "  if (\$paramCount == " . count($pars) . ") \$retVal = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
591
-            if ($i < (count($parsVariations) - 1))
590
+            $innerCode .= "  if (\$paramCount == ".count($pars).") \$retVal = {$catchWarnings}$realFuncName(".implode(',', $pars).");\n";
591
+            if ($i<(count($parsVariations)-1))
592 592
                 $innerCode .= "  else\n";
593 593
         }
594
-        $innerCode .= "  if (is_a(\$retVal, '" . static::$namespace . "Response'))\n    return \$retVal;\n  else\n";
594
+        $innerCode .= "  if (is_a(\$retVal, '".static::$namespace."Response'))\n    return \$retVal;\n  else\n";
595 595
         /// q: why not do the same for int, float, bool, string?
596 596
         if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
597
-            $innerCode .= "    return new " . static::$namespace . "Response(new " . static::$namespace . "Value(\$retVal, '{$funcDesc['returns']}'));";
597
+            $innerCode .= "    return new ".static::$namespace."Response(new ".static::$namespace."Value(\$retVal, '{$funcDesc['returns']}'));";
598 598
         } else {
599 599
             $encodeOptions = array();
600 600
             if ($encodeNulls) {
@@ -605,18 +605,18 @@  discard block
 block discarded – undo
605 605
             }
606 606
 
607 607
             if ($encodeOptions) {
608
-                $innerCode .= "    return new " . static::$namespace . "Response(\$encoder->encode(\$retVal, array('" .
609
-                    implode("', '", $encodeOptions) . "')));";
608
+                $innerCode .= "    return new ".static::$namespace."Response(\$encoder->encode(\$retVal, array('".
609
+                    implode("', '", $encodeOptions)."')));";
610 610
             } else {
611
-                $innerCode .= "    return new " . static::$namespace . "Response(\$encoder->encode(\$retVal));";
611
+                $innerCode .= "    return new ".static::$namespace."Response(\$encoder->encode(\$retVal));";
612 612
             }
613 613
         }
614 614
         // shall we exclude functions returning by ref?
615 615
         // if ($func->returnsReference())
616 616
         //     return false;
617 617
 
618
-        $code = "/**\n * @param \PhpXmlRpc\Request \$req\n * @return \PhpXmlRpc\Response\n * @throws \\Exception\n */\n" .
619
-            "function $newFuncName(\$req)\n{\n" . $innerCode . "\n}";
618
+        $code = "/**\n * @param \PhpXmlRpc\Request \$req\n * @return \PhpXmlRpc\Response\n * @throws \\Exception\n */\n".
619
+            "function $newFuncName(\$req)\n{\n".$innerCode."\n}";
620 620
 
621 621
         return $code;
622 622
     }
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
     protected function generateMethodNameForClassMethod($className, $classMethod, $extraOptions = array())
677 677
     {
678 678
         if (isset($extraOptions['replace_class_name']) && $extraOptions['replace_class_name']) {
679
-            return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . $classMethod;
679
+            return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '').$classMethod;
680 680
         }
681 681
 
682 682
         if (is_object($className)) {
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
         } else {
685 685
             $realClassName = $className;
686 686
         }
687
-        return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . "$realClassName.$classMethod";
687
+        return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '')."$realClassName.$classMethod";
688 688
     }
689 689
 
690 690
     /**
@@ -780,14 +780,14 @@  discard block
 block discarded – undo
780 780
      */
781 781
     protected function retrieveMethodSignature($client, $methodName, array $extraOptions = array())
782 782
     {
783
-        $reqClass = static::$namespace . 'Request';
784
-        $valClass = static::$namespace . 'Value';
785
-        $decoderClass = static::$namespace . 'Encoder';
783
+        $reqClass = static::$namespace.'Request';
784
+        $valClass = static::$namespace.'Value';
785
+        $decoderClass = static::$namespace.'Encoder';
786 786
 
787 787
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
788
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
788
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
789 789
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
790
-        $sigNum = isset($extraOptions['signum']) ? (int)$extraOptions['signum'] : 0;
790
+        $sigNum = isset($extraOptions['signum']) ? (int) $extraOptions['signum'] : 0;
791 791
 
792 792
         $req = new $reqClass('system.methodSignature');
793 793
         $req->addParam(new $valClass($methodName));
@@ -797,7 +797,7 @@  discard block
 block discarded – undo
797 797
         $response = $client->send($req, $timeout, $protocol);
798 798
         $client->setDebug($origDebug);
799 799
         if ($response->faultCode()) {
800
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature from remote server for method ' . $methodName);
800
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': could not retrieve method signature from remote server for method '.$methodName);
801 801
             return false;
802 802
         }
803 803
 
@@ -808,8 +808,8 @@  discard block
 block discarded – undo
808 808
             $mSig = $decoder->decode($mSig);
809 809
         }
810 810
 
811
-        if (!is_array($mSig) || count($mSig) <= $sigNum) {
812
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature nr.' . $sigNum . ' from remote server for method ' . $methodName);
811
+        if (!is_array($mSig) || count($mSig)<=$sigNum) {
812
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': could not retrieve method signature nr.'.$sigNum.' from remote server for method '.$methodName);
813 813
             return false;
814 814
         }
815 815
 
@@ -824,11 +824,11 @@  discard block
 block discarded – undo
824 824
      */
825 825
     protected function retrieveMethodHelp($client, $methodName, array $extraOptions = array())
826 826
     {
827
-        $reqClass = static::$namespace . 'Request';
828
-        $valClass = static::$namespace . 'Value';
827
+        $reqClass = static::$namespace.'Request';
828
+        $valClass = static::$namespace.'Value';
829 829
 
830 830
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
831
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
831
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
832 832
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
833 833
 
834 834
         $mDesc = '';
@@ -865,11 +865,11 @@  discard block
 block discarded – undo
865 865
         $clientClone = clone $client;
866 866
         $function = function() use($clientClone, $methodName, $extraOptions, $mSig)
867 867
         {
868
-            $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
868
+            $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
869 869
             $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
870
-            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
871
-            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
872
-            $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool)$extraOptions['encode_nulls'] : false;
870
+            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
871
+            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
872
+            $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool) $extraOptions['encode_nulls'] : false;
873 873
             $throwFault = false;
874 874
             $decodeFault = false;
875 875
             $faultResponse = null;
@@ -880,9 +880,9 @@  discard block
 block discarded – undo
880 880
                 $faultResponse = $extraOptions['return_on_fault'];
881 881
             }
882 882
 
883
-            $reqClass = static::$namespace . 'Request';
884
-            $encoderClass = static::$namespace . 'Encoder';
885
-            $valueClass = static::$namespace . 'Value';
883
+            $reqClass = static::$namespace.'Request';
884
+            $encoderClass = static::$namespace.'Encoder';
885
+            $valueClass = static::$namespace.'Value';
886 886
 
887 887
             $encoder = new $encoderClass();
888 888
             $encodeOptions = array();
@@ -964,14 +964,14 @@  discard block
 block discarded – undo
964 964
      * @param string $mDesc
965 965
      * @return string[] keys: source, docstring
966 966
      */
967
-    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc='')
967
+    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc = '')
968 968
     {
969
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
969
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
970 970
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
971
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
972
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
973
-        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool)$extraOptions['encode_nulls'] : false;
974
-        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int)($extraOptions['simple_client_copy']) : 0;
971
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
972
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
973
+        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool) $extraOptions['encode_nulls'] : false;
974
+        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int) ($extraOptions['simple_client_copy']) : 0;
975 975
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
976 976
         $throwFault = false;
977 977
         $decodeFault = false;
@@ -984,10 +984,10 @@  discard block
 block discarded – undo
984 984
         }
985 985
 
986 986
         $code = "function $newFuncName(";
987
-        if ($clientCopyMode < 2) {
987
+        if ($clientCopyMode<2) {
988 988
             // client copy mode 0 or 1 == full / partial client copy in emitted code
989 989
             $verbatimClientCopy = !$clientCopyMode;
990
-            $innerCode = '  ' . str_replace("\n", "\n  ", $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, static::$namespace));
990
+            $innerCode = '  '.str_replace("\n", "\n  ", $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, static::$namespace));
991 991
             $innerCode .= "\$client->setDebug(\$debug);\n";
992 992
             $this_ = '';
993 993
         } else {
@@ -995,28 +995,28 @@  discard block
 block discarded – undo
995 995
             $innerCode = '';
996 996
             $this_ = 'this->';
997 997
         }
998
-        $innerCode .= "  \$req = new " . static::$namespace . "Request('$methodName');\n";
998
+        $innerCode .= "  \$req = new ".static::$namespace."Request('$methodName');\n";
999 999
 
1000 1000
         if ($mDesc != '') {
1001 1001
             // take care that PHP comment is not terminated unwillingly by method description
1002 1002
             /// @todo according to the spec, method desc can have html in it. We should run it through strip_tags...
1003
-            $mDesc = "/**\n * " . str_replace(array("\n", '*/'), array("\n * ", '* /'), $mDesc) . "\n";
1003
+            $mDesc = "/**\n * ".str_replace(array("\n", '*/'), array("\n * ", '* /'), $mDesc)."\n";
1004 1004
         } else {
1005 1005
             $mDesc = "/**\n * Function $newFuncName.\n";
1006 1006
         }
1007 1007
 
1008 1008
         // param parsing
1009
-        $innerCode .= "  \$encoder = new " . static::$namespace . "Encoder();\n";
1009
+        $innerCode .= "  \$encoder = new ".static::$namespace."Encoder();\n";
1010 1010
         $plist = array();
1011 1011
         $pCount = count($mSig);
1012
-        for ($i = 1; $i < $pCount; $i++) {
1012
+        for ($i = 1; $i<$pCount; $i++) {
1013 1013
             $plist[] = "\$p$i";
1014 1014
             $pType = $mSig[$i];
1015 1015
             if ($pType == 'i4' || $pType == 'i8' || $pType == 'int' || $pType == 'boolean' || $pType == 'double' ||
1016 1016
                 $pType == 'string' || $pType == 'dateTime.iso8601' || $pType == 'base64' || $pType == 'null'
1017 1017
             ) {
1018 1018
                 // only build directly xml-rpc values when type is known and scalar
1019
-                $innerCode .= "  \$p$i = new " . static::$namespace . "Value(\$p$i, '$pType');\n";
1019
+                $innerCode .= "  \$p$i = new ".static::$namespace."Value(\$p$i, '$pType');\n";
1020 1020
             } else {
1021 1021
                 if ($encodePhpObjects || $encodeNulls) {
1022 1022
                     $encOpts = array();
@@ -1027,26 +1027,26 @@  discard block
 block discarded – undo
1027 1027
                         $encOpts[] = 'null_extension';
1028 1028
                     }
1029 1029
 
1030
-                    $innerCode .= "  \$p$i = \$encoder->encode(\$p$i, array( '" . implode("', '", $encOpts) . "'));\n";
1030
+                    $innerCode .= "  \$p$i = \$encoder->encode(\$p$i, array( '".implode("', '", $encOpts)."'));\n";
1031 1031
                 } else {
1032 1032
                     $innerCode .= "  \$p$i = \$encoder->encode(\$p$i);\n";
1033 1033
                 }
1034 1034
             }
1035 1035
             $innerCode .= "  \$req->addParam(\$p$i);\n";
1036
-            $mDesc .= " * @param " . $this->xmlrpc2PhpType($pType) . " \$p$i\n";
1036
+            $mDesc .= " * @param ".$this->xmlrpc2PhpType($pType)." \$p$i\n";
1037 1037
         }
1038
-        if ($clientCopyMode < 2) {
1038
+        if ($clientCopyMode<2) {
1039 1039
             $plist[] = '$debug = 0';
1040 1040
             $mDesc .= " * @param int \$debug when 1 (or 2) will enable debugging of the underlying {$prefix} call (defaults to 0)\n";
1041 1041
         }
1042 1042
         $plist = implode(', ', $plist);
1043
-        $mDesc .= ' * @return ' . $this->xmlrpc2PhpType($mSig[0]);
1043
+        $mDesc .= ' * @return '.$this->xmlrpc2PhpType($mSig[0]);
1044 1044
         if ($throwFault) {
1045
-            $mDesc .= "\n * @throws " . (is_string($throwFault) ? $throwFault : '\\PhpXmlRpc\\Exception');
1045
+            $mDesc .= "\n * @throws ".(is_string($throwFault) ? $throwFault : '\\PhpXmlRpc\\Exception');
1046 1046
         } else if ($decodeFault) {
1047
-            $mDesc .= '|' . gettype($faultResponse) . " (a " . gettype($faultResponse) . " if call fails)";
1047
+            $mDesc .= '|'.gettype($faultResponse)." (a ".gettype($faultResponse)." if call fails)";
1048 1048
         } else {
1049
-            $mDesc .= '|' . static::$namespace . "Response (a " . static::$namespace . "Response obj instance if call fails)";
1049
+            $mDesc .= '|'.static::$namespace."Response (a ".static::$namespace."Response obj instance if call fails)";
1050 1050
         }
1051 1051
         $mDesc .= "\n */\n";
1052 1052
 
@@ -1059,9 +1059,9 @@  discard block
 block discarded – undo
1059 1059
             $respCode = "throw new $throwFault(\$res->faultString(), \$res->faultCode())";
1060 1060
         } else if ($decodeFault) {
1061 1061
             if (is_string($faultResponse) && ((strpos($faultResponse, '%faultCode%') !== false) || (strpos($faultResponse, '%faultString%') !== false))) {
1062
-                $respCode = "return str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '" . str_replace("'", "''", $faultResponse) . "')";
1062
+                $respCode = "return str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '".str_replace("'", "''", $faultResponse)."')";
1063 1063
             } else {
1064
-                $respCode = 'return ' . var_export($faultResponse, true);
1064
+                $respCode = 'return '.var_export($faultResponse, true);
1065 1065
             }
1066 1066
         } else {
1067 1067
             $respCode = 'return $res';
@@ -1072,7 +1072,7 @@  discard block
 block discarded – undo
1072 1072
             $innerCode .= "  if (\$res->faultCode()) $respCode; else return \$encoder->decode(\$res->value());";
1073 1073
         }
1074 1074
 
1075
-        $code = $code . $plist . ")\n{\n" . $innerCode . "\n}\n";
1075
+        $code = $code.$plist.")\n{\n".$innerCode."\n}\n";
1076 1076
 
1077 1077
         return array('source' => $code, 'docstring' => $mDesc);
1078 1078
     }
@@ -1102,26 +1102,26 @@  discard block
 block discarded – undo
1102 1102
     public function wrapXmlrpcServer($client, $extraOptions = array())
1103 1103
     {
1104 1104
         $methodFilter = isset($extraOptions['method_filter']) ? $extraOptions['method_filter'] : '';
1105
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
1105
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
1106 1106
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
1107 1107
         $newClassName = isset($extraOptions['new_class_name']) ? $extraOptions['new_class_name'] : '';
1108
-        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool)$extraOptions['encode_nulls'] : false;
1109
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
1110
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
1108
+        $encodeNulls = isset($extraOptions['encode_nulls']) ? (bool) $extraOptions['encode_nulls'] : false;
1109
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
1110
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
1111 1111
         $verbatimClientCopy = isset($extraOptions['simple_client_copy']) ? !($extraOptions['simple_client_copy']) : true;
1112
-        $throwOnFault = isset($extraOptions['throw_on_fault']) ? (bool)$extraOptions['throw_on_fault'] : false;
1112
+        $throwOnFault = isset($extraOptions['throw_on_fault']) ? (bool) $extraOptions['throw_on_fault'] : false;
1113 1113
         $buildIt = isset($extraOptions['return_source']) ? !($extraOptions['return_source']) : true;
1114 1114
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
1115 1115
 
1116
-        $reqClass = static::$namespace . 'Request';
1117
-        $decoderClass = static::$namespace . 'Encoder';
1116
+        $reqClass = static::$namespace.'Request';
1117
+        $decoderClass = static::$namespace.'Encoder';
1118 1118
 
1119 1119
         // retrieve the list of methods
1120 1120
         $req = new $reqClass('system.listMethods');
1121 1121
         /// @todo move setting of timeout, protocol to outside the send() call
1122 1122
         $response = $client->send($req, $timeout, $protocol);
1123 1123
         if ($response->faultCode()) {
1124
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': could not retrieve method list from remote server');
1124
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': could not retrieve method list from remote server');
1125 1125
 
1126 1126
             return false;
1127 1127
         }
@@ -1132,7 +1132,7 @@  discard block
 block discarded – undo
1132 1132
             $mList = $decoder->decode($mList);
1133 1133
         }
1134 1134
         if (!is_array($mList) || !count($mList)) {
1135
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': could not retrieve meaningful method list from remote server');
1135
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': could not retrieve meaningful method list from remote server');
1136 1136
 
1137 1137
             return false;
1138 1138
         }
@@ -1142,8 +1142,8 @@  discard block
 block discarded – undo
1142 1142
             $xmlrpcClassName = $newClassName;
1143 1143
         } else {
1144 1144
             /// @todo direct access to $client->server is now deprecated
1145
-            $xmlrpcClassName = $prefix . '_' . preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'), array('_', ''),
1146
-                $client->server) . '_client';
1145
+            $xmlrpcClassName = $prefix.'_'.preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'), array('_', ''),
1146
+                $client->server).'_client';
1147 1147
         }
1148 1148
         while ($buildIt && class_exists($xmlrpcClassName)) {
1149 1149
             $xmlrpcClassName .= 'x';
@@ -1151,7 +1151,7 @@  discard block
 block discarded – undo
1151 1151
 
1152 1152
         $source = "class $xmlrpcClassName\n{\n  public \$client;\n\n";
1153 1153
         $source .= "  function __construct()\n  {\n";
1154
-        $source .= '    ' . str_replace("\n", "\n    ", $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, static::$namespace));
1154
+        $source .= '    '.str_replace("\n", "\n    ", $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, static::$namespace));
1155 1155
         $source .= "\$this->client = \$client;\n  }\n\n";
1156 1156
         $opts = array(
1157 1157
             'return_source' => true,
@@ -1174,28 +1174,28 @@  discard block
 block discarded – undo
1174 1174
                 $methodWrap = $this->wrapXmlrpcMethod($client, $mName, $opts);
1175 1175
                 if ($methodWrap) {
1176 1176
                     if ($buildIt) {
1177
-                        $source .= $methodWrap['source'] . "\n";
1177
+                        $source .= $methodWrap['source']."\n";
1178 1178
 
1179 1179
                     } else {
1180
-                        $source .= '  ' . str_replace("\n", "\n  ", $methodWrap['docstring']);
1181
-                        $source .= str_replace("\n", "\n  ", $methodWrap['source']). "\n";
1180
+                        $source .= '  '.str_replace("\n", "\n  ", $methodWrap['docstring']);
1181
+                        $source .= str_replace("\n", "\n  ", $methodWrap['source'])."\n";
1182 1182
                     }
1183 1183
 
1184 1184
                 } else {
1185
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': will not create class method to wrap remote method ' . $mName);
1185
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': will not create class method to wrap remote method '.$mName);
1186 1186
                 }
1187 1187
             }
1188 1188
         }
1189 1189
         $source .= "}\n";
1190 1190
         if ($buildIt) {
1191 1191
             $allOK = 0;
1192
-            eval($source . '$allOK=1;');
1192
+            eval($source.'$allOK=1;');
1193 1193
             if ($allOK) {
1194 1194
                 return $xmlrpcClassName;
1195 1195
             } else {
1196 1196
                 /// @todo direct access to $client->server is now deprecated
1197
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': could not create class ' . $xmlrpcClassName .
1198
-                    ' to wrap remote server ' . $client->server);
1197
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': could not create class '.$xmlrpcClassName.
1198
+                    ' to wrap remote server '.$client->server);
1199 1199
                 return false;
1200 1200
             }
1201 1201
         } else {
@@ -1214,7 +1214,7 @@  discard block
 block discarded – undo
1214 1214
      */
1215 1215
     protected function buildClientWrapperCode($client, $verbatimClientCopy, $prefix = 'xmlrpc', $namespace = '\\PhpXmlRpc\\')
1216 1216
     {
1217
-        $code = "\$client = new {$namespace}Client('" . str_replace(array("\\", "'"), array("\\\\", "\'"), $client->getUrl()) .
1217
+        $code = "\$client = new {$namespace}Client('".str_replace(array("\\", "'"), array("\\\\", "\'"), $client->getUrl()).
1218 1218
             "');\n";
1219 1219
 
1220 1220
         // copy all client fields to the client that will be generated runtime
Please login to merge, or discard this patch.
tests/09HTTPTest.php 2 patches
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -201,8 +201,7 @@  discard block
 block discarded – undo
201 201
         {
202 202
             $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
203 203
             return;
204
-        }
205
-        else if ($this->args['PROXYSERVER'] == '')
204
+        } else if ($this->args['PROXYSERVER'] == '')
206 205
         {
207 206
             $this->markTestSkipped('PROXYSERVER definition missing: cannot test proxy w. http 1.1');
208 207
             return;
@@ -226,8 +225,7 @@  discard block
 block discarded – undo
226 225
         {
227 226
             $this->markTestSkipped('CURL missing: cannot test https functionality');
228 227
             return;
229
-        }
230
-        else if ($this->args['HTTPSSERVER'] == '')
228
+        } else if ($this->args['HTTPSSERVER'] == '')
231 229
         {
232 230
             $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https');
233 231
             return;
@@ -278,13 +276,11 @@  discard block
 block discarded – undo
278 276
         {
279 277
             $this->markTestSkipped('CURL missing: cannot test https w. proxy');
280 278
             return;
281
-        }
282
-        else if ($this->args['PROXYSERVER'] == '')
279
+        } else if ($this->args['PROXYSERVER'] == '')
283 280
         {
284 281
             $this->markTestSkipped('PROXYSERVER definition missing: cannot test proxy w. https');
285 282
             return;
286
-        }
287
-        else if ($this->args['HTTPSSERVER'] == '')
283
+        } else if ($this->args['HTTPSSERVER'] == '')
288 284
         {
289 285
             $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https w. proxy');
290 286
             return;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/08ServerTest.php';
3
+include_once __DIR__.'/08ServerTest.php';
4 4
 
5 5
 /**
6 6
  * Tests which stress http features of the library.
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         );
26 26
 
27 27
         $methods = array();
28
-        foreach(get_class_methods('ServerTest') as $method)
28
+        foreach (get_class_methods('ServerTest') as $method)
29 29
         {
30 30
             if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
31 31
             {
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
                 preg_match('/ubunutu([0-9]+)/', $output[0], $matches);
318 318
                 $ubuntuVersion = @$matches[1];
319 319
             }
320
-            if ($ubuntuVersion >= 20) {
320
+            if ($ubuntuVersion>=20) {
321 321
                 $this->markTestSkipped('HTTPS via Socket known to fail on php less than 7.2 on Ubuntu 20 and higher');
322 322
                 return;
323 323
             }
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
         {
337 337
             $version = explode('.', PHP_VERSION);
338 338
             $this->client->setOption(\PhpXmlRpc\Client::OPT_EXTRA_SOCKET_OPTS,
339
-                array('ssl' => array('security_level' => 2 + $version[1])));
339
+                array('ssl' => array('security_level' => 2+$version[1])));
340 340
         }
341 341
 
342 342
         $this->$method();
Please login to merge, or discard this patch.
demo/server/server.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     }
25 25
 }
26 26
 
27
-require_once __DIR__ . "/_prepend.php";
27
+require_once __DIR__."/_prepend.php";
28 28
 
29 29
 use PhpXmlRpc\PhpXmlRpc;
30 30
 use PhpXmlRpc\Server;
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         } elseif ($_GET['FORCE_AUTH'] == 'Digest') {
84 84
             if (empty($_SERVER['PHP_AUTH_DIGEST'])) {
85 85
                 header('HTTP/1.1 401 Unauthorized');
86
-                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="' . uniqid() . '",opaque="' . md5('Phpxmlrpc Digest Realm') . '"');
86
+                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="'.uniqid().'",opaque="'.md5('Phpxmlrpc Digest Realm').'"');
87 87
                 die('Text visible if user hits Cancel button');
88 88
             }
89 89
         }
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     if (isset($_GET['FORCE_REDIRECT'])) {
92 92
         header('HTTP/1.0 302 Found');
93 93
         unset($_GET['FORCE_REDIRECT']);
94
-        header('Location: ' . $_SERVER['REQUEST_URI'] . (count($_GET) ? '?' . http_build_query($_GET) : ''));
94
+        header('Location: '.$_SERVER['REQUEST_URI'].(count($_GET) ? '?'.http_build_query($_GET) : ''));
95 95
         die();
96 96
     }
97 97
 }
Please login to merge, or discard this patch.
demo/client/_prepend.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
 }
9 9
 
10 10
 // Use the custom class autoloader. These two lines are not needed when the phpxmlrpc library is installed using Composer
11
-include_once __DIR__ . '/../../src/Autoloader.php';
11
+include_once __DIR__.'/../../src/Autoloader.php';
12 12
 PhpXmlRpc\Autoloader::register();
13 13
 
14 14
 // Let unit tests run against localhost, 'plain' demos against a known public server
@@ -22,5 +22,5 @@  discard block
 block discarded – undo
22 22
 function output($text)
23 23
 {
24 24
     /// @todo we should only strip html tags, and let through all xml tags
25
-    echo PHP_SAPI == 'cli' ? strip_tags(str_replace(array('<br/>','<br>'), "\n", $text)) : $text;
25
+    echo PHP_SAPI == 'cli' ? strip_tags(str_replace(array('<br/>', '<br>'), "\n", $text)) : $text;
26 26
 }
Please login to merge, or discard this patch.
tests/05LoggerTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/PolyfillTestCase.php';
3
+include_once __DIR__.'/PolyfillTestCase.php';
4 4
 
5 5
 use PhpXmlRpc\Helper\Charset;
6 6
 use PhpXmlRpc\Helper\Http;
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
         $l = $h->getLogger();
39 39
         Http::setLogger($this);
40 40
 
41
-        $s = "HTTP/1.0 200 OK\r\n" .
42
-            "Content-Type: unknown\r\n" .
43
-            "\r\n" .
41
+        $s = "HTTP/1.0 200 OK\r\n".
42
+            "Content-Type: unknown\r\n".
43
+            "\r\n".
44 44
             "body";
45 45
         ob_start();
46 46
         $h->parseResponseHeaders($s, false, 1);
Please login to merge, or discard this patch.
tests/12ExtraFilesTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests for php files in the 'extras' directory.
Please login to merge, or discard this patch.
tests/10DemofilesTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests for php files in the 'demo' directory.
Please login to merge, or discard this patch.