Passed
Push — master ( bd7691...51530c )
by Gaetano
08:10
created
demo/client/introspect.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Introspect demo</title></head>
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 function display_error($r)
18 18
 {
19 19
     output("An error occurred: ");
20
-    output("Code: " . $r->faultCode() . " Reason: '" . $r->faultString() . "'<br/>");
20
+    output("Code: ".$r->faultCode()." Reason: '".$r->faultString()."'<br/>");
21 21
 }
22 22
 
23 23
 $client = new Client(XMLRPCSERVER);
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 $client->setOption(Client::OPT_RETURN_TYPE, XMLRPCParser::RETURN_PHP);
26 26
 
27 27
 // First off, let's retrieve the list of methods available on the remote server
28
-output("<h3>methods available at http://" . $client->server . $client->path . "</h3>\n");
28
+output("<h3>methods available at http://".$client->server.$client->path."</h3>\n");
29 29
 $req = new Request('system.listMethods');
30 30
 $resp = $client->send($req);
31 31
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     // Then, retrieve the signature and help text of each available method
49 49
     foreach ($v as $methodName) {
50
-        output("<h4>" . htmlspecialchars($methodName) . "</h4>\n");
50
+        output("<h4>".htmlspecialchars($methodName)."</h4>\n");
51 51
         // build requests first, add params later
52 52
         $r1 = new PhpXmlRpc\Request('system.methodHelp');
53 53
         $r2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
                         continue;
84 84
                     }
85 85
                     $ret = $sig[0];
86
-                    output("<code>" . htmlspecialchars($ret) . " "
87
-                        . htmlspecialchars($methodName) . "(");
88
-                    if (count($sig) > 1) {
89
-                        for ($k = 1; $k < count($sig); $k++) {
86
+                    output("<code>".htmlspecialchars($ret)." "
87
+                        . htmlspecialchars($methodName)."(");
88
+                    if (count($sig)>1) {
89
+                        for ($k = 1; $k<count($sig); $k++) {
90 90
                             output(htmlspecialchars($sig[$k]));
91
-                            if ($k < count($sig) - 1) {
91
+                            if ($k<count($sig)-1) {
92 92
                                 output(", ");
93 93
                             }
94 94
                         }
Please login to merge, or discard this patch.
demo/client/getstatename.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Getstatename demo</title></head>
@@ -17,13 +17,13 @@  discard block
 block discarded – undo
17 17
 $stateNo = "";
18 18
 
19 19
 if (isset($_POST['stateno']) && $_POST['stateno'] != "") {
20
-    $stateNo = (integer)$_POST['stateno'];
20
+    $stateNo = (integer) $_POST['stateno'];
21 21
     $method = 'examples.getStateName';
22 22
     $arguments = array(
23 23
         new Value($stateNo, Value::$xmlrpcInt),
24 24
     );
25 25
     $req = new Request($method, $arguments);
26
-    output("Sending the following request:<pre>\n\n" . htmlentities($req->serialize()) .
26
+    output("Sending the following request:<pre>\n\n".htmlentities($req->serialize()).
27 27
         "\n\n</pre>Debug info of server data follows...\n\n");
28 28
     $client = new Client(XMLRPCSERVER);
29 29
     $client->setOption(Client::OPT_DEBUG, 1);
@@ -32,12 +32,12 @@  discard block
 block discarded – undo
32 32
         $val = $resp->value();
33 33
         // NB: we are _assuming_ that the server did return a scalar xml-rpc value here.
34 34
         // If the server is not trusted, we might check that via `$val->kindOf() == 'scalar'`
35
-        output('<br/>State number <b>' . $stateNo . '</b> is <b>'
36
-            . htmlspecialchars($val->scalarval()) . '</b><br/><br/>');
35
+        output('<br/>State number <b>'.$stateNo.'</b> is <b>'
36
+            . htmlspecialchars($val->scalarval()).'</b><br/><br/>');
37 37
     } else {
38 38
         output('An error occurred: ');
39
-        output('<pre>Code: ' . htmlspecialchars($resp->faultCode())
40
-            . " Reason: '" . htmlspecialchars($resp->faultString()) . "'</pre>");
39
+        output('<pre>Code: '.htmlspecialchars($resp->faultCode())
40
+            . " Reason: '".htmlspecialchars($resp->faultString())."'</pre>");
41 41
     }
42 42
 }
43 43
 
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Webservice wrapper demo</title></head>
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 $client->setOption(\PhpXmlRpc\Client::OPT_RETURN_TYPE, 'phpvals'); // let client give us back php values instead of xmlrpcvals
21 21
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
22 22
 if ($resp->faultCode()) {
23
-    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n");
23
+    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n");
24 24
 } else {
25 25
     output("<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n");
26 26
     flush();
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
         if ($methodName == 'examples.getStateName') {
33 33
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
34 34
             if ($callable) {
35
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n");
35
+                output("<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n");
36 36
             } else {
37
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n");
37
+                output("<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n");
38 38
             }
39 39
             break;
40 40
         }
Please login to merge, or discard this patch.
demo/server/codegen.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 require_once __DIR__.'/methodProviders/CommentManager.php';
5 5
 
@@ -25,33 +25,33 @@  discard block
 block discarded – undo
25 25
 // generate a file with a class definition
26 26
 
27 27
 // the generated code does not have an autoloader included - we need to add in one
28
-$autoloader = __DIR__ . "/_prepend.php";
28
+$autoloader = __DIR__."/_prepend.php";
29 29
 
30 30
 file_put_contents($targetClassFile,
31
-    "<?php\n\n" .
32
-    "require_once '$autoloader';\n\n" .
31
+    "<?php\n\n".
32
+    "require_once '$autoloader';\n\n".
33 33
     "class MyServerClass\n{\n\n"
34 34
 ) || die('uh oh');
35 35
 
36 36
 // we mangle a bit the code we get from wrapPhpClass to generate a php class instead of a bunch of functions
37 37
 
38
-foreach($code as $methodName => $methodDef) {
39
-    file_put_contents($targetClassFile, '  ' . str_replace(array('function ', "\n"), array('public static function ', "\n  "), $methodDef['source']) . "\n\n", FILE_APPEND) || die('uh oh');
40
-    $code[$methodName]['function'] = 'MyServerClass::' . $methodDef['function'];
38
+foreach ($code as $methodName => $methodDef) {
39
+    file_put_contents($targetClassFile, '  '.str_replace(array('function ', "\n"), array('public static function ', "\n  "), $methodDef['source'])."\n\n", FILE_APPEND) || die('uh oh');
40
+    $code[$methodName]['function'] = 'MyServerClass::'.$methodDef['function'];
41 41
     unset($code[$methodName]['source']);
42 42
 }
43 43
 file_put_contents($targetClassFile, "}\n", FILE_APPEND) || die('uh oh');
44 44
 
45 45
 // generate separate files with the xml-rpc server instantiation and its dispatch map
46 46
 
47
-file_put_contents($targetDispatchMapFile, "<?php\n\nreturn " . var_export($code, true) . ";\n");
47
+file_put_contents($targetDispatchMapFile, "<?php\n\nreturn ".var_export($code, true).";\n");
48 48
 
49 49
 file_put_contents($targetControllerFile,
50
-    "<?php\n\n" .
50
+    "<?php\n\n".
51 51
 
52
-    "require_once '$autoloader';\n\n" .
52
+    "require_once '$autoloader';\n\n".
53 53
 
54
-    "require_once '$targetClassFile';\n\n" .
54
+    "require_once '$targetClassFile';\n\n".
55 55
 
56 56
     // NB: since we are running the generated code within the same script, the existing CommentManager instance will be
57 57
     // available for usage by the methods of MyServerClass, as we keep a reference to them within the variable Wrapper::$objHolder
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
     //     Wrapper::holdObject('xmlrpc_CommentManager_addComment', $cm);
62 62
     //     Wrapper::holdObject('xmlrpc_CommentManager_getComments', $cm);
63 63
 
64
-    "\$dm = require_once '$targetDispatchMapFile';\n" .
65
-    '$s = new \PhpXmlRpc\Server($dm, false);' . "\n" .
66
-    '// NB: do not leave these 2 debug lines enabled on publicly accessible servers!' . "\n" .
67
-    '$s->setOption(\PhpXmlRpc\Server::OPT_DEBUG, 2);' . "\n" .
68
-    '$s->setOption(\PhpXmlRpc\Server::OPT_EXCEPTION_HANDLING, 1);' . "\n" .
69
-    '$s->service();' . "\n"
64
+    "\$dm = require_once '$targetDispatchMapFile';\n".
65
+    '$s = new \PhpXmlRpc\Server($dm, false);'."\n".
66
+    '// NB: do not leave these 2 debug lines enabled on publicly accessible servers!'."\n".
67
+    '$s->setOption(\PhpXmlRpc\Server::OPT_DEBUG, 2);'."\n".
68
+    '$s->setOption(\PhpXmlRpc\Server::OPT_EXCEPTION_HANDLING, 1);'."\n".
69
+    '$s->service();'."\n"
70 70
 ) || die('uh oh');
71 71
 
72 72
 // test that everything worked by running it in realtime (note that this will return an xml-rpc error message if run
Please login to merge, or discard this patch.
src/Encoder.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -57,13 +57,13 @@  discard block
 block discarded – undo
57 57
                                 'scalar' => $val,
58 58
                                 'timestamp' => \PhpXmlRpc\Helper\Date::iso8601Decode($val)
59 59
                             );
60
-                            return (object)$xmlrpcVal;
60
+                            return (object) $xmlrpcVal;
61 61
                         case 'base64':
62 62
                             $xmlrpcVal = array(
63 63
                                 'xmlrpc_type' => 'base64',
64 64
                                 'scalar' => $val
65 65
                             );
66
-                            return (object)$xmlrpcVal;
66
+                            return (object) $xmlrpcVal;
67 67
                         case 'string':
68 68
                             if (isset($options['extension_api_encoding'])) {
69 69
                                 // if iconv is not available, we use mb_convert_encoding
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
             case 'msg':
137 137
                 $paramCount = $xmlrpcVal->getNumParams();
138 138
                 $arr = array();
139
-                for ($i = 0; $i < $paramCount; $i++) {
139
+                for ($i = 0; $i<$paramCount; $i++) {
140 140
                     $arr[] = $this->decode($xmlrpcVal->getParam($i), $options);
141 141
                 }
142 142
                 return $arr;
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
                 break;
262 262
             case 'resource':
263 263
                 if (in_array('extension_api', $options)) {
264
-                    $xmlrpcVal = new Value((int)$phpVal, Value::$xmlrpcInt);
264
+                    $xmlrpcVal = new Value((int) $phpVal, Value::$xmlrpcInt);
265 265
                 } else {
266 266
                     $xmlrpcVal = new Value();
267 267
                 }
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
                     if ($valEncoding == 'ISO-8859-1') {
311 311
                         $xmlVal = utf8_encode($xmlVal);
312 312
                     } else {
313
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': invalid charset encoding of xml text: ' . $valEncoding);
313
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.': invalid charset encoding of xml text: '.$valEncoding);
314 314
                     }
315 315
                 }
316 316
             }
@@ -332,10 +332,10 @@  discard block
 block discarded – undo
332 332
             $parserOptions
333 333
         );
334 334
 
335
-        if ($xmlRpcParser->_xh['isf'] > 1) {
335
+        if ($xmlRpcParser->_xh['isf']>1) {
336 336
             // test that $xmlrpc->_xh['value'] is an obj, too???
337 337
 
338
-            $this->getLogger()->error('XML-RPC: ' . $xmlRpcParser->_xh['isf_reason']);
338
+            $this->getLogger()->error('XML-RPC: '.$xmlRpcParser->_xh['isf_reason']);
339 339
 
340 340
             return false;
341 341
         }
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
 
357 357
             case 'methodcall':
358 358
                 $req = new Request($xmlRpcParser->_xh['method']);
359
-                for ($i = 0; $i < count($xmlRpcParser->_xh['params']); $i++) {
359
+                for ($i = 0; $i<count($xmlRpcParser->_xh['params']); $i++) {
360 360
                     $req->addParam($xmlRpcParser->_xh['params'][$i]);
361 361
                 }
362 362
                 return $req;
Please login to merge, or discard this patch.
src/Response.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
                 // user declares the type of resp value: we "almost" trust it... but log errors just in case
74 74
                 if (($this->valtyp == 'xmlrpcvals' && (!is_a($this->val, 'PhpXmlRpc\Value'))) ||
75 75
                     ($this->valtyp == 'xml' && (!is_string($this->val)))) {
76
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': value passed in does not match type ' . $valType);
76
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': value passed in does not match type '.$valType);
77 77
                 }
78 78
             }
79 79
         }
@@ -152,33 +152,33 @@  discard block
 block discarded – undo
152 152
     public function serialize($charsetEncoding = '')
153 153
     {
154 154
         if ($charsetEncoding != '') {
155
-            $this->content_type = 'text/xml; charset=' . $charsetEncoding;
155
+            $this->content_type = 'text/xml; charset='.$charsetEncoding;
156 156
         } else {
157 157
             $this->content_type = 'text/xml';
158 158
         }
159 159
         if (PhpXmlRpc::$xmlrpc_null_apache_encoding) {
160
-            $result = "<methodResponse xmlns:ex=\"" . PhpXmlRpc::$xmlrpc_null_apache_encoding_ns . "\">\n";
160
+            $result = "<methodResponse xmlns:ex=\"".PhpXmlRpc::$xmlrpc_null_apache_encoding_ns."\">\n";
161 161
         } else {
162 162
             $result = "<methodResponse>\n";
163 163
         }
164 164
         if ($this->errno) {
165 165
             // Let non-ASCII response messages be tolerated by clients by xml-encoding non ascii chars
166
-            $result .= "<fault>\n" .
167
-                "<value>\n<struct><member><name>faultCode</name>\n<value><int>" . $this->errno .
168
-                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>" .
169
-                $this->getCharsetEncoder()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) .
166
+            $result .= "<fault>\n".
167
+                "<value>\n<struct><member><name>faultCode</name>\n<value><int>".$this->errno.
168
+                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>".
169
+                $this->getCharsetEncoder()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding).
170 170
                 "</string></value>\n</member>\n</struct>\n</value>\n</fault>";
171 171
         } else {
172 172
             if (is_object($this->val) && is_a($this->val, 'PhpXmlRpc\Value')) {
173
-                $result .= "<params>\n<param>\n" . $this->val->serialize($charsetEncoding) . "</param>\n</params>";
173
+                $result .= "<params>\n<param>\n".$this->val->serialize($charsetEncoding)."</param>\n</params>";
174 174
             } else if (is_string($this->val) && $this->valtyp == 'xml') {
175
-                $result .= "<params>\n<param>\n" .
176
-                    $this->val .
175
+                $result .= "<params>\n<param>\n".
176
+                    $this->val.
177 177
                     "</param>\n</params>";
178 178
             } else if ($this->valtyp == 'phpvals') {
179 179
                     $encoder = new Encoder();
180 180
                     $val = $encoder->encode($this->val);
181
-                    $result .= "<params>\n<param>\n" . $val->serialize($charsetEncoding) . "</param>\n</params>";
181
+                    $result .= "<params>\n<param>\n".$val->serialize($charsetEncoding)."</param>\n</params>";
182 182
             } else {
183 183
                 throw new StateErrorException('cannot serialize xmlrpc response objects whose content is native php values');
184 184
             }
@@ -196,18 +196,18 @@  discard block
 block discarded – undo
196 196
     {
197 197
         switch ($name) {
198 198
             case 'hdrs':
199
-                $this->logDeprecation('Getting property Response::' . $name . ' is deprecated');
199
+                $this->logDeprecation('Getting property Response::'.$name.' is deprecated');
200 200
                 return $this->httpResponse['headers'];
201 201
             case '_cookies':
202
-                $this->logDeprecation('Getting property Response::' . $name . ' is deprecated');
202
+                $this->logDeprecation('Getting property Response::'.$name.' is deprecated');
203 203
                 return $this->httpResponse['cookies'];
204 204
             case 'raw_data':
205
-                $this->logDeprecation('Getting property Response::' . $name . ' is deprecated');
205
+                $this->logDeprecation('Getting property Response::'.$name.' is deprecated');
206 206
                 return $this->httpResponse['raw_data'];
207 207
             default:
208 208
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
209 209
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
210
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
210
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
211 211
                 return null;
212 212
         }
213 213
     }
@@ -216,21 +216,21 @@  discard block
 block discarded – undo
216 216
     {
217 217
         switch ($name) {
218 218
             case 'hdrs':
219
-                $this->logDeprecation('Setting property Response::' . $name . ' is deprecated');
219
+                $this->logDeprecation('Setting property Response::'.$name.' is deprecated');
220 220
                 $this->httpResponse['headers'] = $value;
221 221
                 break;
222 222
             case '_cookies':
223
-                $this->logDeprecation('Setting property Response::' . $name . ' is deprecated');
223
+                $this->logDeprecation('Setting property Response::'.$name.' is deprecated');
224 224
                 $this->httpResponse['cookies'] = $value;
225 225
                 break;
226 226
             case 'raw_data':
227
-                $this->logDeprecation('Setting property Response::' . $name . ' is deprecated');
227
+                $this->logDeprecation('Setting property Response::'.$name.' is deprecated');
228 228
                 $this->httpResponse['raw_data'] = $value;
229 229
                 break;
230 230
             default:
231 231
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
232 232
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
233
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
233
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
234 234
         }
235 235
     }
236 236
 
@@ -238,13 +238,13 @@  discard block
 block discarded – undo
238 238
     {
239 239
         switch ($name) {
240 240
             case 'hdrs':
241
-                $this->logDeprecation('Checking property Response::' . $name . ' is deprecated');
241
+                $this->logDeprecation('Checking property Response::'.$name.' is deprecated');
242 242
                 return isset($this->httpResponse['headers']);
243 243
             case '_cookies':
244
-                $this->logDeprecation('Checking property Response::' . $name . ' is deprecated');
244
+                $this->logDeprecation('Checking property Response::'.$name.' is deprecated');
245 245
                 return isset($this->httpResponse['cookies']);
246 246
             case 'raw_data':
247
-                $this->logDeprecation('Checking property Response::' . $name . ' is deprecated');
247
+                $this->logDeprecation('Checking property Response::'.$name.' is deprecated');
248 248
                 return isset($this->httpResponse['raw_data']);
249 249
             default:
250 250
                 return false;
@@ -255,21 +255,21 @@  discard block
 block discarded – undo
255 255
     {
256 256
         switch ($name) {
257 257
             case 'hdrs':
258
-                $this->logDeprecation('Unsetting property Response::' . $name . ' is deprecated');
258
+                $this->logDeprecation('Unsetting property Response::'.$name.' is deprecated');
259 259
                 unset($this->httpResponse['headers']);
260 260
                 break;
261 261
             case '_cookies':
262
-                $this->logDeprecation('Unsetting property Response::' . $name . ' is deprecated');
262
+                $this->logDeprecation('Unsetting property Response::'.$name.' is deprecated');
263 263
                 unset($this->httpResponse['cookies']);
264 264
                 break;
265 265
             case 'raw_data':
266
-                $this->logDeprecation('Unsetting property Response::' . $name . ' is deprecated');
266
+                $this->logDeprecation('Unsetting property Response::'.$name.' is deprecated');
267 267
                 unset($this->httpResponse['raw_data']);
268 268
                 break;
269 269
             default:
270 270
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
271 271
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
272
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
272
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
273 273
         }
274 274
     }
275 275
 }
Please login to merge, or discard this patch.
src/Helper/Charset.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -76,14 +76,14 @@  discard block
 block discarded – undo
76 76
                 if (count($this->xml_iso88591_Entities['in'])) {
77 77
                     return;
78 78
                 }
79
-                for ($i = 0; $i < 32; $i++) {
79
+                for ($i = 0; $i<32; $i++) {
80 80
                     $this->xml_iso88591_Entities["in"][] = chr($i);
81 81
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
82 82
                 }
83 83
 
84 84
                 /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
85 85
 
86
-                for ($i = 160; $i < 256; $i++) {
86
+                for ($i = 160; $i<256; $i++) {
87 87
                     $this->xml_iso88591_Entities["in"][] = chr($i);
88 88
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
89 89
                 }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                 break;*/
112 112
 
113 113
             default:
114
-                throw new ValueErrorException('Unsupported table: ' . $tableName);
114
+                throw new ValueErrorException('Unsupported table: '.$tableName);
115 115
         }
116 116
     }
117 117
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
             $srcEncoding = 'UTF-8';
164 164
         }
165 165
 
166
-        $conversion = strtoupper($srcEncoding . '_' . $destEncoding);
166
+        $conversion = strtoupper($srcEncoding.'_'.$destEncoding);
167 167
 
168 168
         // list ordered with (expected) most common scenarios first
169 169
         switch ($conversion) {
@@ -181,20 +181,20 @@  discard block
 block discarded – undo
181 181
                 // NB: this will choke on invalid UTF-8, going most likely beyond EOF
182 182
                 $escapedData = '';
183 183
                 // be kind to users creating string xml-rpc values out of different php types
184
-                $data = (string)$data;
184
+                $data = (string) $data;
185 185
                 $ns = strlen($data);
186
-                for ($nn = 0; $nn < $ns; $nn++) {
186
+                for ($nn = 0; $nn<$ns; $nn++) {
187 187
                     $ch = $data[$nn];
188 188
                     $ii = ord($ch);
189 189
                     // 7 bits in 1 byte: 0bbbbbbb (127)
190
-                    if ($ii < 32) {
190
+                    if ($ii<32) {
191 191
                         if ($conversion == 'UTF-8_US-ASCII') {
192 192
                             $escapedData .= sprintf('&#%d;', $ii);
193 193
                         } else {
194 194
                             $escapedData .= $ch;
195 195
                         }
196 196
                     }
197
-                    else if ($ii < 128) {
197
+                    else if ($ii<128) {
198 198
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
199 199
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
200 200
                         switch ($ii) {
@@ -219,25 +219,25 @@  discard block
 block discarded – undo
219 219
                     } // 11 bits in 2 bytes: 110bbbbb 10bbbbbb (2047)
220 220
                     elseif ($ii >> 5 == 6) {
221 221
                         $b1 = ($ii & 31);
222
-                        $b2 = (ord($data[$nn + 1]) & 63);
223
-                        $ii = ($b1 * 64) + $b2;
222
+                        $b2 = (ord($data[$nn+1]) & 63);
223
+                        $ii = ($b1 * 64)+$b2;
224 224
                         $escapedData .= sprintf('&#%d;', $ii);
225 225
                         $nn += 1;
226 226
                     } // 16 bits in 3 bytes: 1110bbbb 10bbbbbb 10bbbbbb
227 227
                     elseif ($ii >> 4 == 14) {
228 228
                         $b1 = ($ii & 15);
229
-                        $b2 = (ord($data[$nn + 1]) & 63);
230
-                        $b3 = (ord($data[$nn + 2]) & 63);
231
-                        $ii = ((($b1 * 64) + $b2) * 64) + $b3;
229
+                        $b2 = (ord($data[$nn+1]) & 63);
230
+                        $b3 = (ord($data[$nn+2]) & 63);
231
+                        $ii = ((($b1 * 64)+$b2) * 64)+$b3;
232 232
                         $escapedData .= sprintf('&#%d;', $ii);
233 233
                         $nn += 2;
234 234
                     } // 21 bits in 4 bytes: 11110bbb 10bbbbbb 10bbbbbb 10bbbbbb
235 235
                     elseif ($ii >> 3 == 30) {
236 236
                         $b1 = ($ii & 7);
237
-                        $b2 = (ord($data[$nn + 1]) & 63);
238
-                        $b3 = (ord($data[$nn + 2]) & 63);
239
-                        $b4 = (ord($data[$nn + 3]) & 63);
240
-                        $ii = ((((($b1 * 64) + $b2) * 64) + $b3) * 64) + $b4;
237
+                        $b2 = (ord($data[$nn+1]) & 63);
238
+                        $b3 = (ord($data[$nn+2]) & 63);
239
+                        $b4 = (ord($data[$nn+3]) & 63);
240
+                        $ii = ((((($b1 * 64)+$b2) * 64)+$b3) * 64)+$b4;
241 241
                         $escapedData .= sprintf('&#%d;', $ii);
242 242
                         $nn += 3;
243 243
                     }
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
                     // If src is UTF8, we run htmlspecialchars before converting to the target charset, as
291 291
                     // htmlspecialchars has limited charset support, but it groks utf8
292 292
                     if ($srcEncoding === 'UTF-8') {
293
-                        $data = htmlspecialchars($data,  defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
293
+                        $data = htmlspecialchars($data, defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
294 294
                     }
295 295
                     if ($srcEncoding !== $destEncoding) {
296 296
                         try {
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
                     }
303 303
                     if ($data === false) {
304 304
                         $escapedData = '';
305
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
305
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
306 306
                     } else {
307 307
                         if ($srcEncoding === 'UTF-8') {
308 308
                             $escapedData = $data;
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
                     }
313 313
                 } else {
314 314
                     $escapedData = '';
315
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding: not supported...");
315
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding: not supported...");
316 316
                 }
317 317
         }
318 318
 
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
         if (function_exists('mb_list_encodings')) {
331 331
             $knownCharsets = array_unique(array_merge($knownCharsets, array_diff(mb_list_encodings(), array(
332 332
                 'pass', 'auto', 'wchar', 'BASE64', 'UUENCODE', 'ASCII', 'HTML-ENTITIES', 'Quoted-Printable',
333
-                '7bit','8bit', 'byte2be', 'byte2le', 'byte4be', 'byte4le'
333
+                '7bit', '8bit', 'byte2be', 'byte2le', 'byte4be', 'byte4le'
334 334
             ))));
335 335
         }
336 336
         return $knownCharsets;
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
      */
348 348
     public function isValidCharset($encoding, $validList)
349 349
     {
350
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
350
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
351 351
 
352 352
         if (is_string($validList)) {
353 353
             $validList = explode(',', $validList);
@@ -377,14 +377,14 @@  discard block
 block discarded – undo
377 377
      */
378 378
     public function getEntities($charset)
379 379
     {
380
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
380
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
381 381
 
382 382
         switch ($charset)
383 383
         {
384 384
             case 'iso88591':
385 385
                 return $this->xml_iso88591_Entities;
386 386
             default:
387
-                throw new ValueErrorException('Unsupported charset: ' . $charset);
387
+                throw new ValueErrorException('Unsupported charset: '.$charset);
388 388
         }
389 389
     }
390 390
 }
Please login to merge, or discard this patch.
src/Value.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
                     $this->me['struct'] = $val;
97 97
                     break;
98 98
                 default:
99
-                    $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": not a known type ($type)");
99
+                    $this->getLogger()->error("XML-RPC: ".__METHOD__.": not a known type ($type)");
100 100
             }
101 101
         }
102 102
     }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         }
127 127
 
128 128
         if ($typeOf !== 1) {
129
-            $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": not a scalar type ($type)");
129
+            $this->getLogger()->error("XML-RPC: ".__METHOD__.": not a scalar type ($type)");
130 130
             return 0;
131 131
         }
132 132
 
@@ -143,10 +143,10 @@  discard block
 block discarded – undo
143 143
 
144 144
         switch ($this->mytype) {
145 145
             case 1:
146
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': scalar xmlrpc value can have only one value');
146
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': scalar xmlrpc value can have only one value');
147 147
                 return 0;
148 148
             case 3:
149
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': cannot add anonymous scalar to struct xmlrpc value');
149
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': cannot add anonymous scalar to struct xmlrpc value');
150 150
                 return 0;
151 151
             case 2:
152 152
                 // we're adding a scalar value to an array here
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
             return 1;
192 192
         } else {
193
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']');
193
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']');
194 194
             return 0;
195 195
         }
196 196
     }
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 
222 222
             return 1;
223 223
         } else {
224
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']');
224
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']');
225 225
             return 0;
226 226
         }
227 227
     }
@@ -265,19 +265,19 @@  discard block
 block discarded – undo
265 265
             case 1:
266 266
                 switch ($typ) {
267 267
                     case static::$xmlrpcBase64:
268
-                        $rs .= "<{$typ}>" . base64_encode($val) . "</{$typ}>";
268
+                        $rs .= "<{$typ}>".base64_encode($val)."</{$typ}>";
269 269
                         break;
270 270
                     case static::$xmlrpcBoolean:
271
-                        $rs .= "<{$typ}>" . ($val ? '1' : '0') . "</{$typ}>";
271
+                        $rs .= "<{$typ}>".($val ? '1' : '0')."</{$typ}>";
272 272
                         break;
273 273
                     case static::$xmlrpcString:
274 274
                         // Do NOT use htmlentities, since it will produce named html entities, which are invalid xml
275
-                        $rs .= "<{$typ}>" . $this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</{$typ}>";
275
+                        $rs .= "<{$typ}>".$this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</{$typ}>";
276 276
                         break;
277 277
                     case static::$xmlrpcInt:
278 278
                     case static::$xmlrpcI4:
279 279
                     case static::$xmlrpcI8:
280
-                        $rs .= "<{$typ}>" . (int)$val . "</{$typ}>";
280
+                        $rs .= "<{$typ}>".(int) $val."</{$typ}>";
281 281
                         break;
282 282
                     case static::$xmlrpcDouble:
283 283
                         // avoid using standard conversion of float to string because it is locale-dependent,
@@ -285,16 +285,16 @@  discard block
 block discarded – undo
285 285
                         // sprintf('%F') could be most likely ok, but it fails e.g. on 2e-14.
286 286
                         // The code below tries its best at keeping max precision while avoiding exp notation,
287 287
                         // but there is of course no limit in the number of decimal places to be used...
288
-                        $rs .= "<{$typ}>" . preg_replace('/\\.?0+$/', '', number_format((double)$val, PhpXmlRpc::$xmlpc_double_precision, '.', '')) . "</{$typ}>";
288
+                        $rs .= "<{$typ}>".preg_replace('/\\.?0+$/', '', number_format((double) $val, PhpXmlRpc::$xmlpc_double_precision, '.', ''))."</{$typ}>";
289 289
                         break;
290 290
                     case static::$xmlrpcDateTime:
291 291
                         if (is_string($val)) {
292 292
                             $rs .= "<{$typ}>{$val}</{$typ}>";
293 293
                         // DateTimeInterface is not present in php 5.4...
294 294
                         } elseif (is_a($val, 'DateTimeInterface') || is_a($val, 'DateTime')) {
295
-                            $rs .= "<{$typ}>" . $val->format('Ymd\TH:i:s') . "</{$typ}>";
295
+                            $rs .= "<{$typ}>".$val->format('Ymd\TH:i:s')."</{$typ}>";
296 296
                         } elseif (is_int($val)) {
297
-                            $rs .= "<{$typ}>" . date('Ymd\TH:i:s', $val) . "</{$typ}>";
297
+                            $rs .= "<{$typ}>".date('Ymd\TH:i:s', $val)."</{$typ}>";
298 298
                         } else {
299 299
                             // not really a good idea here: but what should we output anyway? left for backward compat...
300 300
                             $rs .= "<{$typ}>{$val}</{$typ}>";
@@ -316,14 +316,14 @@  discard block
 block discarded – undo
316 316
             case 3:
317 317
                 // struct
318 318
                 if ($this->_php_class) {
319
-                    $rs .= '<struct php_class="' . $this->_php_class . "\">\n";
319
+                    $rs .= '<struct php_class="'.$this->_php_class."\">\n";
320 320
                 } else {
321 321
                     $rs .= "<struct>\n";
322 322
                 }
323 323
                 $charsetEncoder = $this->getCharsetEncoder();
324 324
                 /** @var Value $val2 */
325 325
                 foreach ($val as $key2 => $val2) {
326
-                    $rs .= '<member><name>' . $charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</name>\n";
326
+                    $rs .= '<member><name>'.$charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</name>\n";
327 327
                     //$rs.=$this->serializeval($val2);
328 328
                     $rs .= $val2->serialize($charsetEncoding);
329 329
                     $rs .= "</member>\n";
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
         $val = reset($this->me);
359 359
         $typ = key($this->me);
360 360
 
361
-        return '<value>' . $this->serializeData($typ, $val, $charsetEncoding) . "</value>\n";
361
+        return '<value>'.$this->serializeData($typ, $val, $charsetEncoding)."</value>\n";
362 362
     }
363 363
 
364 364
     /**
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
      */
374 374
     public function structMemExists($key)
375 375
     {
376
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
376
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
377 377
 
378 378
         return array_key_exists($key, $this->me['struct']);
379 379
     }
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
      */
390 390
     public function structMem($key)
391 391
     {
392
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
392
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
393 393
 
394 394
         return $this->me['struct'][$key];
395 395
     }
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
      */
403 403
     public function structReset()
404 404
     {
405
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
405
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
406 406
 
407 407
         reset($this->me['struct']);
408 408
     }
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
      */
418 418
     public function structEach()
419 419
     {
420
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
420
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
421 421
 
422 422
         return @each($this->me['struct']);
423 423
     }
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
      */
463 463
     public function arrayMem($key)
464 464
     {
465
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
465
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
466 466
 
467 467
         return $this->me['array'][$key];
468 468
     }
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
      */
477 477
     public function arraySize()
478 478
     {
479
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
479
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
480 480
 
481 481
         return count($this->me['array']);
482 482
     }
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
      */
491 491
     public function structSize()
492 492
     {
493
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
493
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
494 494
 
495 495
         return count($this->me['struct']);
496 496
     }
Please login to merge, or discard this patch.
src/Traits/DeprecationLogger.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,6 +14,6 @@
 block discarded – undo
14 14
             return;
15 15
         }
16 16
 
17
-        $this->getLogger()->warning('XML-RPC Deprecated: ' . $message);
17
+        $this->getLogger()->warning('XML-RPC Deprecated: '.$message);
18 18
     }
19 19
 }
Please login to merge, or discard this patch.