LocalhostTest

Complexity

Total Complexity

113

Size/Duplication

Total Lines	944
Duplicated Lines	14.41 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

43 Methods

Rating	Name	Duplication	Size	Complexity
B	fail()	0	16	5
B	run()	27	27	3
A	setUp()	0	20	3
A	tearDown()	11	11	4
B	send()	0	26	6
B	testString()	5	27	3
A	testLatin1String()	0	12	2
B	testExoticCharsetsRequests()	0	27	2
B	testExoticCharsetsRequests2()	0	26	2
B	testExoticCharsetsRequests3()	0	24	2
A	testUtf8Method()	0	12	2
A	testAddingDoubles()	0	15	2
A	testAdding()	11	11	2
A	testInvalidNumber()	13	13	2
B	testBoolean()	0	27	4
A	testBase64()	5	23	3
A	testDateTime()	0	15	3
A	testCountEntities()	0	18	3
A	_multicall_msg()	0	7	1
A	testServerMulticall()	0	56	4
B	testClientMulticall1()	11	42	5
B	testClientMulticall2()	10	36	5
B	testClientMulticall3()	9	36	4
A	testCatchWarnings()	10	10	2
A	testCatchExceptions()	0	13	1
A	testZeroParams()	0	5	1
A	testNullParams()	0	23	3
A	testCodeInjectionServerSide()	0	9	2
A	testServerWrappedFunction()	0	22	1
A	testServerWrappedFunctionAsSource()	0	14	1
B	testServerWrappedObjectMethods()	0	38	1
A	testServerWrappedObjectMethodsAsSource()	0	20	1
A	testServerClosure()	8	8	1
A	testServerWrappedClosure()	8	8	1
A	testServerWrappedClass()	8	8	1
A	testWrappedMethod()	0	15	2
A	testWrappedMethodAsSource()	0	17	2
A	testWrappedClass()	0	17	2
A	testTransferOfObjectViaWrapping()	0	14	2
D	testGetCookies()	0	43	9
B	testSetCookies()	0	29	4
A	testServerComments()	0	8	1
A	testSendTwiceSameMsg()	0	11	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 12 and the first side effect is on line 3.

include_once __DIR__ . '/../lib/xmlrpc.inc';
include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';

include_once __DIR__ . '/parse_args.php';

/**
 * Tests which involve interaction between the client and the server.
 * They are run against the server found in demo/server.php
 */
class LocalhostTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /** @var xmlrpc_client $client */
    protected $client = null;
    protected $method = 'http';
    protected $timeout = 10;
    protected $request_compression = null;
    protected $accepted_compression = '';
    protected $args = array();

    protected static $failed_tests = array();

    protected $testId;
    /** @var boolean $collectCodeCoverageInformation */
    protected $collectCodeCoverageInformation;
    protected $coverageScriptUrl;

    public static function fail($message = '')
    {
        // save in a static var that this particular test has failed
        // (but only if not called from subclass objects / multitests)
        if (function_exists('debug_backtrace') && strtolower(get_called_class()) == 'localhosttests') {
            $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
            for ($i = 0; $i < count($trace); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                if (strpos($trace[$i]['function'], 'test') === 0) {
                    self::$failed_tests[$trace[$i]['function']] = true;
                    break;
                }
            }
        }

        parent::fail($message);
    }

    /**
     * Reimplemented to allow us to collect code coverage info from the target server.
     * Code taken from PHPUnit_Extensions_Selenium2TestCase
     *
     * @param PHPUnit_Framework_TestResult $result
     * @return PHPUnit_Framework_TestResult
     * @throws Exception
     */
    public function run(PHPUnit_Framework_TestResult $result = NULL)

This method seems to be duplicated in your project.

    {
        $this->testId = get_class($this) . '__' . $this->getName();

        if ($result === NULL) {
            $result = $this->createResult();
        }

        $this->collectCodeCoverageInformation = $result->getCollectCodeCoverageInformation();

        parent::run($result);

        if ($this->collectCodeCoverageInformation) {
            $coverage = new PHPUnit_Extensions_SeleniumCommon_RemoteCoverage(
                $this->coverageScriptUrl,
                $this->testId
            );
            $result->getCodeCoverage()->append(
                $coverage->get(), $this
            );
        }

        // do not call this before to give the time to the Listeners to run
        //$this->getStrategy()->endOfTest($this->session);

77% of this comment could be valid code. Did you maybe forget this after debugging?

        return $result;
    }

    public function setUp()
    {
        $this->args = argParser::getArgs();

        $server = explode(':', $this->args['LOCALSERVER']);
        if (count($server) > 1) {
            $this->client = new xmlrpc_client($this->args['URI'], $server[0], $server[1]);
        } else {
            $this->client = new xmlrpc_client($this->args['URI'], $this->args['LOCALSERVER']);
        }

        $this->client->setDebug($this->args['DEBUG']);
        $this->client->request_compression = $this->request_compression;
        $this->client->accepted_compression = $this->accepted_compression;

It seems like $this->accepted_compression of type string is incompatible with the declared type array of property $accepted_compression.

        $this->coverageScriptUrl = 'http://' . $this->args['LOCALSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI'] );

        if ($this->args['DEBUG'] == 1)
            ob_start();
    }

    protected function tearDown()

This method seems to be duplicated in your project.

    {
        if ($this->args['DEBUG'] != 1)
            return;
        $out = ob_get_clean();
        $status = $this->getStatus();
        if ($status == PHPUnit_Runner_BaseTestRunner::STATUS_ERROR
            || $status == PHPUnit_Runner_BaseTestRunner::STATUS_FAILURE) {
            echo $out;
        }
    }

    /**
     * @param PhpXmlRpc\Request|array $msg
     * @param int|array $errorCode
     * @param bool $returnResponse
     * @return mixed|\PhpXmlRpc\Response|\PhpXmlRpc\Response[]|\PhpXmlRpc\Value|string|void
     */
    protected function send($msg, $errorCode = 0, $returnResponse = false)
    {
        if ($this->collectCodeCoverageInformation) {
            $this->client->setCookie('PHPUNIT_SELENIUM_TEST_ID', $this->testId);
        }

        $r = $this->client->send($msg, $this->timeout, $this->method);

It seems like $msg defined by parameter $msg on line 121 can also be of type array; however, PhpXmlRpc\Client::send() does only seem to accept object<PhpXmlRpc\Request>|array<integer,object<PhpXmlRpc\Request>>|string, maybe add an additional type check?

        // for multicall, return directly array of responses
        if (is_array($r)) {
            return $r;
        }
        if (is_array($errorCode)) {
            $this->assertContains($r->faultCode(), $errorCode, 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
        } else {
            $this->assertEquals($errorCode, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
        }
        if (!$r->faultCode()) {
            if ($returnResponse) {
                return $r;
            } else {
                return $r->value();
            }
        } else {
            return;
        }
    }

    public function testString()
    {
        $sendString = "here are 3 \"entities\": < > & " .
            "and here's a dollar sign: \$pretendvarname and a backslash too: " . chr(92) .
            " - isn't that great? \\\"hackery\\\" at it's best " .
            " also don't want to miss out on \$item[0]. " .
            "The real weird stuff follows: CRLF here" . chr(13) . chr(10) .
            "a simple CR here" . chr(13) .
            "a simple LF here" . chr(10) .
            "and then LFCR" . chr(10) . chr(13) .
            "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne, and an xml comment closing tag: -->";
        $m = new xmlrpcmsg('examples.stringecho', array(
            new xmlrpcval($sendString, 'string'),
        ));
        $v = $this->send($m);
        if ($v) {
            // when sending/receiving non-US-ASCII encoded strings, XML says cr-lf can be normalized.
            // so we relax our tests...
            $l1 = strlen($sendString);
            $l2 = strlen($v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

            if ($l1 == $l2) {

This code seems to be duplicated across your project.

                $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

            } else {
                $this->assertEquals(str_replace(array("\r\n", "\r"), array("\n", "\n"), $sendString), $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

            }
        }
    }

    public function testLatin1String()
    {
        $sendString =
            "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne";
        $x = '<?xml version="1.0" encoding="ISO-8859-1"?><methodCall><methodName>examples.stringecho</methodName><params><param><value>'.
            $sendString.
            '</value></param></params></methodCall>';
        $v = $this->send($x);

$x is of type string, but the function expects a object<PhpXmlRpc\Request>|array.

        if ($v) {
            $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testExoticCharsetsRequests()
    {
        // note that we should disable this call also when mbstring is missing server-side
        if (!function_exists('mb_convert_encoding')) {
            $this->markTestSkipped('Miss mbstring extension to test exotic charsets');
            return;
        }
        $sendString = 'κόσμε'; // Greek word 'kosme'. NB: NOT a valid ISO8859 string!
        $str = '<?xml version="1.0" encoding="_ENC_"?>
<methodCall>
    <methodName>examples.stringecho</methodName>
    <params>
        <param>
        <value><string>'.$sendString.'</string></value>
        </param>
    </params>
</methodCall>';

        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'UTF-8';
        // we have to set the encoding declaration either in the http header or xml prolog, as mb_detect_encoding
        // (used on the server side) will fail recognizing these 2 charsets
        $v = $this->send(mb_convert_encoding(str_replace('_ENC_', 'UCS-4', $str), 'UCS-4', 'UTF-8'));

mb_convert_encoding(str_replace('_ENC_', 'UCS-4', $str), 'UCS-4', 'UTF-8') is of type string, but the function expects a object<PhpXmlRpc\Request>|array.

        $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $v = $this->send(mb_convert_encoding(str_replace('_ENC_', 'UTF-16', $str), 'UTF-16', 'UTF-8'));

mb_convert_encoding(str_replace('_ENC_', 'UTF-16', $str), 'UTF-16', 'UTF-8') is of type string, but the function expects a object<PhpXmlRpc\Request>|array.

        $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'ISO-8859-1';
    }

    public function testExoticCharsetsRequests2()
    {
        // note that we should disable this call also when mbstring is missing server-side
        if (!function_exists('mb_convert_encoding')) {
            $this->markTestSkipped('Miss mbstring extension to test exotic charsets');
            return;
        }
        $sendString = '安室奈美恵'; // No idea what this means :-) NB: NOT a valid ISO8859 string!
        $str = '<?xml version="1.0"?>
<methodCall>
    <methodName>examples.stringecho</methodName>
    <params>
        <param>
        <value><string>'.$sendString.'</string></value>
        </param>
    </params>
</methodCall>';

        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'UTF-8';
        // no encoding declaration either in the http header or xml prolog, let mb_detect_encoding
        // (used on the server side) sort it out
        $this->client->path = $this->args['URI'].'?DETECT_ENCODINGS[]=EUC-JP&DETECT_ENCODINGS[]=UTF-8';
        $v = $this->send(mb_convert_encoding($str, 'EUC-JP', 'UTF-8'));

mb_convert_encoding($str, 'EUC-JP', 'UTF-8') is of type string, but the function expects a object<PhpXmlRpc\Request>|array.

        $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'ISO-8859-1';
    }

    public function testExoticCharsetsRequests3()
    {
        // note that we should disable this call also when mbstring is missing server-side
        if (!function_exists('mb_convert_encoding')) {
            $this->markTestSkipped('Miss mbstring extension to test exotic charsets');
            return;
        }
        $sendString = utf8_decode('élève');
        $str = '<?xml version="1.0"?>
<methodCall>
    <methodName>examples.stringecho</methodName>
    <params>
        <param>
        <value><string>'.$sendString.'</string></value>
        </param>
    </params>
</methodCall>';

        // no encoding declaration either in the http header or xml prolog, let mb_detect_encoding
        // (used on the server side) sort it out
        $this->client->path = $this->args['URI'].'?DETECT_ENCODINGS[]=ISO-8859-1&DETECT_ENCODINGS[]=UTF-8';
        $v = $this->send($str);

$str is of type string, but the function expects a object<PhpXmlRpc\Request>|array.

        $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    /*public function testLatin1Method()

57% of this comment could be valid code. Did you maybe forget this after debugging?

    {
        $f = new xmlrpcmsg("tests.iso88591methodname." . chr(224) . chr(252) . chr(232), array(
            new xmlrpcval('hello')
        ));
        $v = $this->send($f);
        if ($v) {
            $this->assertEquals('hello', $v->scalarval());
        }
    }*/

    public function testUtf8Method()
    {
        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'UTF-8';
        $m = new xmlrpcmsg("tests.utf8methodname." . 'κόσμε', array(
            new xmlrpcval('hello')
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals('hello', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
        PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'ISO-8859-1';
    }

    public function testAddingDoubles()
    {
        // note that rounding errors mean we
        // keep precision to sensible levels here ;-)
        $a = 12.13;
        $b = -23.98;
        $m = new xmlrpcmsg('examples.addtwodouble', array(
            new xmlrpcval($a, 'double'),
            new xmlrpcval($b, 'double'),
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals($a + $b, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testAdding()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('examples.addtwo', array(
            new xmlrpcval(12, 'int'),
            new xmlrpcval(-23, 'int'),
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals(12 - 23, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testInvalidNumber()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('examples.addtwo', array(
            new xmlrpcval('fred', 'int'),
            new xmlrpcval("\"; exec('ls')", 'int'),
        ));
        $v = $this->send($m);
        /// @todo a fault condition should be generated here
        /// by the server, which we pick up on
        if ($v) {
            $this->assertEquals(0, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testBoolean()
    {
        $m = new xmlrpcmsg('examples.invertBooleans', array(
            new xmlrpcval(array(

array(new \xmlrpcval(true, 'boolean'), new \xmlrpcval(false, 'boolean'), new \xmlrpcval(1, 'boolean'), new \xmlrpcval(0, 'boolean')) is of type array<integer,object<xmlrpcval>,{"0":"object<xmlrpcval>","1":"object<xmlrpcval>","2":"object<xmlrpcval>","3":"object<xmlrpcval>"}>, but the function expects a integer.

                new xmlrpcval(true, 'boolean'),

true is of type boolean, but the function expects a integer.

                new xmlrpcval(false, 'boolean'),

false is of type boolean, but the function expects a integer.

                new xmlrpcval(1, 'boolean'),
                new xmlrpcval(0, 'boolean')
            ),
                'array'
            ),));
        $answer = '0101';
        $v = $this->send($m);
        if ($v) {
            $sz = $v->arraysize();

The method arraysize() does not seem to exist on object<PhpXmlRpc\Response>.

            $got = '';
            for ($i = 0; $i < $sz; $i++) {
                $b = $v->arraymem($i);

The method arraymem() does not seem to exist on object<PhpXmlRpc\Response>.

                if ($b->scalarval()) {
                    $got .= '1';
                } else {
                    $got .= '0';
                }
            }
            $this->assertEquals($answer, $got);
        }
    }

    public function testBase64()
    {
        $sendString = 'Mary had a little lamb,
Whose fleece was white as snow,
And everywhere that Mary went
the lamb was sure to go.

Mary had a little lamb
She tied it to a pylon
Ten thousand volts went down its back
And turned it into nylon';
        $m = new xmlrpcmsg('examples.decode64', array(
            new xmlrpcval($sendString, 'base64'),
        ));
        $v = $this->send($m);
        if ($v) {
            if (strlen($sendString) == strlen($v->scalarval())) {

This code seems to be duplicated across your project.

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

                $this->assertEquals($sendString, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

            } else {
                $this->assertEquals(str_replace(array("\r\n", "\r"), array("\n", "\n"), $sendString), $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

            }
        }
    }

    public function testDateTime()
    {
        $time = time();
        $t1 = new xmlrpcval($time, 'dateTime.iso8601');
        $t2 = new xmlrpcval(iso8601_encode($time), 'dateTime.iso8601');
        $this->assertEquals($t1->serialize(), $t2->serialize());
        if (class_exists('DateTime')) {
            $datetime = new DateTime();
            // skip this test for php 5.2. It is a bit harder there to build a DateTime from unix timestamp with proper TZ info
            if (is_callable(array($datetime, 'setTimestamp'))) {
                $t3 = new xmlrpcval($datetime->setTimestamp($time), 'dateTime.iso8601');

$datetime->setTimestamp($time) is of type object<DateTime>, but the function expects a integer.

                $this->assertEquals($t1->serialize(), $t3->serialize());
            }
        }
    }

    public function testCountEntities()
    {
        $sendString = "h'fd>onc>>l>>rw&bpu>q>e<v&gxs<ytjzkami<";
        $m = new xmlrpcmsg('validator1.countTheEntities', array(
            new xmlrpcval($sendString, 'string'),
        ));
        $v = $this->send($m);
        if ($v) {
            $got = '';
            $expected = '37210';
            $expect_array = array('ctLeftAngleBrackets', 'ctRightAngleBrackets', 'ctAmpersands', 'ctApostrophes', 'ctQuotes');
            while (list(, $val) = each($expect_array)) {
                $b = $v->structmem($val);

The method structmem() does not seem to exist on object<PhpXmlRpc\Response>.

                $got .= $b->me['int'];
            }
            $this->assertEquals($expected, $got);
        }
    }

    public function _multicall_msg($method, $params)
    {
        $struct['methodName'] = new xmlrpcval($method, 'string');

$struct was never initialized. Although not strictly required by PHP, it is generally a good practice to add $struct = array(); before regardless.

        $struct['params'] = new xmlrpcval($params, 'array');

        return new xmlrpcval($struct, 'struct');

$struct is of type array<string,object<xmlrpcval>,{"params":"object<xmlrpcval>"}>, but the function expects a integer.

    }

    public function testServerMulticall()
    {
        // We manually construct a system.multicall() call to ensure
        // that the server supports it.

        // NB: This test will NOT pass if server does not support system.multicall.

        // Based on http://xmlrpc-c.sourceforge.net/hacks/test_multicall.py
        $good1 = $this->_multicall_msg(
            'system.methodHelp',
            array(php_xmlrpc_encode('system.listMethods')));
        $bad = $this->_multicall_msg(
            'test.nosuch',
            array(php_xmlrpc_encode(1), php_xmlrpc_encode(2)));
        $recursive = $this->_multicall_msg(
            'system.multicall',
            array(new xmlrpcval(array(), 'array')));

array() is of type array, but the function expects a integer.

        $good2 = $this->_multicall_msg(
            'system.methodSignature',
            array(php_xmlrpc_encode('system.listMethods')));
        $arg = new xmlrpcval(
            array($good1, $bad, $recursive, $good2),

array($good1, $bad, $recursive, $good2) is of type array<integer,object<xmlrpcval>,{"0":"object<xmlrpcval>","1":"object<xmlrpcval>","2":"object<xmlrpcval>","3":"object<xmlrpcval>"}>, but the function expects a integer.

            'array'
        );

        $m = new xmlrpcmsg('system.multicall', array($arg));
        $v = $this->send($m);
        if ($v) {
            //$this->assertTrue($r->faultCode() == 0, "fault from system.multicall");

67% of this comment could be valid code. Did you maybe forget this after debugging?

            $this->assertTrue($v->arraysize() == 4, "bad number of return values");

The method arraysize() does not seem to exist on object<PhpXmlRpc\Response>.

            $r1 = $v->arraymem(0);

The method arraymem() does not seem to exist on object<PhpXmlRpc\Response>.

            $this->assertTrue(
                $r1->kindOf() == 'array' && $r1->arraysize() == 1,
                "did not get array of size 1 from good1"
            );

            $r2 = $v->arraymem(1);

The method arraymem() does not seem to exist on object<PhpXmlRpc\Response>.

            $this->assertTrue(
                $r2->kindOf() == 'struct',
                "no fault from bad"
            );

            $r3 = $v->arraymem(2);

The method arraymem() does not seem to exist on object<PhpXmlRpc\Response>.

            $this->assertTrue(
                $r3->kindOf() == 'struct',
                "recursive system.multicall did not fail"
            );

            $r4 = $v->arraymem(3);

The method arraymem() does not seem to exist on object<PhpXmlRpc\Response>.

            $this->assertTrue(
                $r4->kindOf() == 'array' && $r4->arraysize() == 1,
                "did not get array of size 1 from good2"
            );
        }
    }

    public function testClientMulticall1()
    {
        // NB: This test will NOT pass if server does not support system.multicall.

        $this->client->no_multicall = false;

        $good1 = new xmlrpcmsg('system.methodHelp',
            array(php_xmlrpc_encode('system.listMethods')));
        $bad = new xmlrpcmsg('test.nosuch',
            array(php_xmlrpc_encode(1), php_xmlrpc_encode(2)));
        $recursive = new xmlrpcmsg('system.multicall',
            array(new xmlrpcval(array(), 'array')));

array() is of type array, but the function expects a integer.

        $good2 = new xmlrpcmsg('system.methodSignature',
            array(php_xmlrpc_encode('system.listMethods'))
        );

        $r = $this->send(array($good1, $bad, $recursive, $good2));
        if ($r) {
            $this->assertTrue(count($r) == 4, "wrong number of return values");
        }

        $this->assertTrue($r[0]->faultCode() == 0, "fault from good1");
        if (!$r[0]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[0]->value();
            $this->assertTrue(
                $val->kindOf() == 'scalar' && $val->scalartyp() == 'string',
                "good1 did not return string"
            );
        }
        $this->assertTrue($r[1]->faultCode() != 0, "no fault from bad");
        $this->assertTrue($r[2]->faultCode() != 0, "no fault from recursive system.multicall");
        $this->assertTrue($r[3]->faultCode() == 0, "fault from good2");
        if (!$r[3]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[3]->value();
            $this->assertTrue($val->kindOf() == 'array', "good2 did not return array");
        }
        // This is the only assert in this test which should fail
        // if the test server does not support system.multicall.
        $this->assertTrue($this->client->no_multicall == false,

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            "server does not support system.multicall"
        );
    }

    public function testClientMulticall2()
    {
        // NB: This test will NOT pass if server does not support system.multicall.

        $this->client->no_multicall = true;

        $good1 = new xmlrpcmsg('system.methodHelp',
            array(php_xmlrpc_encode('system.listMethods')));
        $bad = new xmlrpcmsg('test.nosuch',
            array(php_xmlrpc_encode(1), php_xmlrpc_encode(2)));
        $recursive = new xmlrpcmsg('system.multicall',
            array(new xmlrpcval(array(), 'array')));

array() is of type array, but the function expects a integer.

        $good2 = new xmlrpcmsg('system.methodSignature',
            array(php_xmlrpc_encode('system.listMethods'))
        );

        $r = $this->send(array($good1, $bad, $recursive, $good2));
        if ($r) {
            $this->assertTrue(count($r) == 4, "wrong number of return values");
        }

        $this->assertTrue($r[0]->faultCode() == 0, "fault from good1");
        if (!$r[0]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[0]->value();
            $this->assertTrue(
                $val->kindOf() == 'scalar' && $val->scalartyp() == 'string',
                "good1 did not return string");
        }
        $this->assertTrue($r[1]->faultCode() != 0, "no fault from bad");
        $this->assertTrue($r[2]->faultCode() == 0, "fault from (non recursive) system.multicall");
        $this->assertTrue($r[3]->faultCode() == 0, "fault from good2");
        if (!$r[3]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[3]->value();
            $this->assertTrue($val->kindOf() == 'array', "good2 did not return array");
        }
    }

    public function testClientMulticall3()
    {
        // NB: This test will NOT pass if server does not support system.multicall.

        $this->client->return_type = 'phpvals';
        $this->client->no_multicall = false;

        $good1 = new xmlrpcmsg('system.methodHelp',
            array(php_xmlrpc_encode('system.listMethods')));
        $bad = new xmlrpcmsg('test.nosuch',
            array(php_xmlrpc_encode(1), php_xmlrpc_encode(2)));
        $recursive = new xmlrpcmsg('system.multicall',
            array(new xmlrpcval(array(), 'array')));

array() is of type array, but the function expects a integer.

        $good2 = new xmlrpcmsg('system.methodSignature',
            array(php_xmlrpc_encode('system.listMethods'))
        );

        $r = $this->send(array($good1, $bad, $recursive, $good2));
        if ($r) {
            $this->assertTrue(count($r) == 4, "wrong number of return values");
        }
        $this->assertTrue($r[0]->faultCode() == 0, "fault from good1");
        if (!$r[0]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[0]->value();
            $this->assertTrue(
                is_string($val), "good1 did not return string");
        }
        $this->assertTrue($r[1]->faultCode() != 0, "no fault from bad");
        $this->assertTrue($r[2]->faultCode() != 0, "no fault from recursive system.multicall");
        $this->assertTrue($r[3]->faultCode() == 0, "fault from good2");
        if (!$r[3]->faultCode()) {

This code seems to be duplicated across your project.

            $val = $r[3]->value();
            $this->assertTrue(is_array($val), "good2 did not return array");
        }
        $this->client->return_type = 'xmlrpcvals';
    }

    public function testCatchWarnings()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('tests.generatePHPWarning', array(
            new xmlrpcval('whatever', 'string'),
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals(true, $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testCatchExceptions()

testCatchExceptions uses the super-global variable $GLOBALS which is generally not recommended.

    {
        $m = new xmlrpcmsg('tests.raiseException', array(
            new xmlrpcval('whatever', 'string'),
        ));
        $v = $this->send($m, $GLOBALS['xmlrpcerr']['server_error']);

$v is not used, you could remove the assignment.

        $this->client->path = $this->args['URI'] . '?EXCEPTION_HANDLING=1';
        $v = $this->send($m, 1); // the error code of the expected exception

$v is not used, you could remove the assignment.

        $this->client->path = $this->args['URI'] . '?EXCEPTION_HANDLING=2';
        // depending on whether display_errors is ON or OFF on the server, we will get back a different error here,
        // as php will generate an http status code of either 200 or 500...
        $v = $this->send($m, array($GLOBALS['xmlrpcerr']['invalid_return'], $GLOBALS['xmlrpcerr']['http_error']));

array($GLOBALS['xmlrpcerr']['invalid_return'], $GLOBALS['xmlrpcerr']['http_error']) is of type array<integer,?,{"0":"?","1":"?"}>, but the function expects a integer.

$v is not used, you could remove the assignment.

    }

    public function testZeroParams()
    {
        $m = new xmlrpcmsg('system.listMethods');
        $v = $this->send($m);

$v is not used, you could remove the assignment.

    }

    public function testNullParams()

testNullParams uses the super-global variable $GLOBALS which is generally not recommended.

    {
        $m = new xmlrpcmsg('tests.getStateName.12', array(
            new xmlrpcval('whatever', 'null'),
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
        $m = new xmlrpcmsg('tests.getStateName.12', array(
            new xmlrpcval(23, 'int'),
            new xmlrpcval('whatever', 'null'),
        ));
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        }
        $m = new xmlrpcmsg('tests.getStateName.12', array(
            new xmlrpcval(23, 'int')
        ));
        $v = $this->send($m, array($GLOBALS['xmlrpcerr']['incorrect_params']));

array($GLOBALS['xmlrpcerr']['incorrect_params']) is of type array<integer,?,{"0":"?"}>, but the function expects a integer.

$v is not used, you could remove the assignment.

    }

    public function testCodeInjectionServerSide()
    {
        $m = new xmlrpcmsg('system.MethodHelp');
        $m->payload = "<?xml version=\"1.0\"?><methodCall><methodName>validator1.echoStructTest</methodName><params><param><value><struct><member><name>','')); echo('gotcha!'); die(); //</name></member></struct></value></param></params></methodCall>";
        $v = $this->send($m);
        if ($v) {
            $this->assertEquals(0, $v->structsize());

The method structsize() does not seem to exist on object<PhpXmlRpc\Response>.

        }
    }

    public function testServerWrappedFunction()

testServerWrappedFunction uses the super-global variable $GLOBALS which is generally not recommended.

    {
        $m = new xmlrpcmsg('tests.getStateName.2', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        // this generates an exception in the function which was wrapped, which is by default wrapped in a known error response
        $m = new xmlrpcmsg('tests.getStateName.2', array(
            new xmlrpcval(0, 'int'),
        ));
        $v = $this->send($m, $GLOBALS['xmlrpcerr']['server_error']);

$v is not used, you could remove the assignment.

        // check if the generated function dispatch map is fine, by checking if the server registered it
        $m = new xmlrpcmsg('system.methodSignature', array(
            new xmlrpcval('tests.getStateName.2'),
        ));
        $v = $this->send($m);
        $encoder = new \PhpXmlRpc\Encoder();
        $this->assertEquals(array(array('string', 'int')), $encoder->decode($v));
    }

    public function testServerWrappedFunctionAsSource()

testServerWrappedFunctionAsSource uses the super-global variable $GLOBALS which is generally not recommended.

    {
        $m = new xmlrpcmsg('tests.getStateName.6', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        // this generates an exception in the function which was wrapped, which is by default wrapped in a known error response
        $m = new xmlrpcmsg('tests.getStateName.6', array(
            new xmlrpcval(0, 'int'),
        ));
        $v = $this->send($m, $GLOBALS['xmlrpcerr']['server_error']);

$v is not used, you could remove the assignment.

    }

    public function testServerWrappedObjectMethods()
    {
        $m = new xmlrpcmsg('tests.getStateName.3', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.4', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.5', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.7', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.8', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.9', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    public function testServerWrappedObjectMethodsAsSource()
    {
        $m = new xmlrpcmsg('tests.getStateName.7', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.8', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

        $m = new xmlrpcmsg('tests.getStateName.9', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    public function testServerClosure()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('tests.getStateName.10', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    public function testServerWrappedClosure()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('tests.getStateName.11', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    public function testServerWrappedClass()

This method seems to be duplicated in your project.

    {
        $m = new xmlrpcmsg('tests.xmlrpcServerMethodsContainer.findState', array(
            new xmlrpcval(23, 'int'),
        ));
        $v = $this->send($m);
        $this->assertEquals('Michigan', $v->scalarval());

The method scalarval() does not seem to exist on object<PhpXmlRpc\Response>.

    }

    public function testWrappedMethod()
    {
        // make a 'deep client copy' as the original one might have many properties set
        $func = wrap_xmlrpc_method($this->client, 'examples.getStateName', array('simple_client_copy' => 0));

array('simple_client_copy' => 0) is of type array<string,integer,{"simple_client_copy":"integer"}>, but the function expects a integer.

        if ($func == false) {
            $this->fail('Registration of examples.getStateName failed');
        } else {
            $v = $func(23);
            // work around bug in current (or old?) version of phpunit when reporting the error
            /*if (is_object($v)) {

60% of this comment could be valid code. Did you maybe forget this after debugging?

                $v = var_export($v, true);
            }*/
            $this->assertEquals('Michigan', $v);
        }
    }

    public function testWrappedMethodAsSource()
    {
        // make a 'deep client copy' as the original one might have many properties set
        $func = wrap_xmlrpc_method($this->client, 'examples.getStateName', array('simple_client_copy' => 0, 'return_source' => true));

array('simple_client_copy' => 0, 'return_source' => true) is of type array<string,integer|boolean,{"simple_client_copy":"integer","return_source":"boolean"}>, but the function expects a integer.

        if ($func == false) {
            $this->fail('Registration of examples.getStateName failed');
        } else {
            eval($func['source']);

It is generally not recommended to use eval unless absolutely required.

            $func = $func['function'];
            $v = $func(23);
            // work around bug in current (or old?) version of phpunit when reporting the error
            /*if (is_object($v)) {

60% of this comment could be valid code. Did you maybe forget this after debugging?

                $v = var_export($v, true);
            }*/
            $this->assertEquals('Michigan', $v);
        }
    }

    public function testWrappedClass()
    {
        // make a 'deep client copy' as the original one might have many properties set
        // also for speed only wrap one method of the whole server
        $class = wrap_xmlrpc_server($this->client, array('simple_client_copy' => 0, 'method_filter' => '/examples\.getStateName/' ));
        if ($class == '') {
            $this->fail('Registration of remote server failed');
        } else {
            $obj = new $class();
            $v = $obj->examples_getStateName(23);
            // work around bug in current (or old?) version of phpunit when reporting the error
            /*if (is_object($v)) {

60% of this comment could be valid code. Did you maybe forget this after debugging?

                $v = var_export($v, true);
            }*/
            $this->assertEquals('Michigan', $v);
        }
    }

    public function testTransferOfObjectViaWrapping()
    {
        // make a 'deep client copy' as the original one might have many properties set
        $func = wrap_xmlrpc_method($this->client, 'tests.returnPhpObject', array('simple_client_copy' => true,

array('simple_client_copy' => true, 'decode_php_objs' => true) is of type array<string,boolean,{"simple_client_copy":"boolean","decode_php_objs":"boolean"}>, but the function expects a integer.

            'decode_php_objs' => true));
        if ($func == false) {
            $this->fail('Registration of tests.returnPhpObject failed');
        } else {
            $v = $func();
            $obj = new stdClass();
            $obj->hello = 'world';
            $this->assertEquals($obj, $v);
        }
    }

    public function testGetCookies()
    {
        // let server set to us some cookies we tell it
        $cookies = array(
            //'c1' => array(),

63% of this comment could be valid code. Did you maybe forget this after debugging?

            'c2' => array('value' => 'c2'),
            'c3' => array('value' => 'c3', 'expires' => time() + 60 * 60 * 24 * 30),
            'c4' => array('value' => 'c4', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/'),
            'c5' => array('value' => 'c5', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/', 'domain' => 'localhost'),
        );
        $cookiesval = php_xmlrpc_encode($cookies);
        $m = new xmlrpcmsg('examples.setcookies', array($cookiesval));
        $r = $this->send($m, 0, true);
        if ($r) {
            $v = $r->value();
            $this->assertEquals(1, $v->scalarval());
            // now check if we decoded the cookies as we had set them
            $rcookies = $r->cookies();
            // remove extra cookies which might have been set by proxies
            foreach ($rcookies as $c => $v) {
                if (!in_array($c, array('c2', 'c3', 'c4', 'c5'))) {
                    unset($rcookies[$c]);
                }
                // Seems like we get this when using php-fpm and php 5.5+ ...
                if (isset($rcookies[$c]['Max-Age'])) {
                    unset($rcookies[$c]['Max-Age']);
                }
            }
            foreach ($cookies as $c => $v) {
                // format for date string in cookies: 'Mon, 31 Oct 2005 13:50:56 GMT'
                // but PHP versions differ on that, some use 'Mon, 31-Oct-2005 13:50:56 GMT'...
                if (isset($v['expires'])) {
                    if (isset($rcookies[$c]['expires']) && strpos($rcookies[$c]['expires'], '-')) {
                        $cookies[$c]['expires'] = gmdate('D, d\-M\-Y H:i:s \G\M\T', $cookies[$c]['expires']);
                    } else {
                        $cookies[$c]['expires'] = gmdate('D, d M Y H:i:s \G\M\T', $cookies[$c]['expires']);
                    }
                }
            }

            $this->assertEquals($cookies, $rcookies);
        }
    }

    public function testSetCookies()
    {
        // let server set to us some cookies we tell it
        $cookies = array(
            'c0' => null,
            'c1' => 1,
            'c2' => '2 3',
            'c3' => '!@#$%^&*()_+|}{":?><,./\';[]\\=-',
        );
        $m = new xmlrpcmsg('examples.getcookies', array());
        foreach ($cookies as $cookie => $val) {
            $this->client->setCookie($cookie, $val);
            $cookies[$cookie] = (string)$cookies[$cookie];
        }
        $r = $this->client->send($m, $this->timeout, $this->method);
        $this->assertEquals(0, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
        if (!$r->faultCode()) {
            $v = $r->value();
            $v = php_xmlrpc_decode($v);

            // take care for the extra cookie used for coverage collection
            if (isset($v['PHPUNIT_SELENIUM_TEST_ID'])) {
                unset($v['PHPUNIT_SELENIUM_TEST_ID']);
            }

            // on IIS and Apache getallheaders returns something slightly different...
            $this->assertEquals($cookies, $v);
        }
    }

    public function testServerComments()
    {
        $m = new xmlrpcmsg('tests.xmlrpcServerMethodsContainer.debugMessageGenerator', array(
            new xmlrpcval('hello world', 'string'),
        ));
        $r = $this->send($m, 0, true);
        $this->assertContains('hello world', $r->raw_data);
    }

    public function testSendTwiceSameMsg()
    {
        $m = new xmlrpcmsg('examples.stringecho', array(
            new xmlrpcval('hello world', 'string'),
        ));
        $v1 = $this->send($m);
        $v2 = $this->send($m);
        if ($v1 && $v2) {
            $this->assertEquals($v1, $v2);
        }
    }
}