Completed
Push — master ( 640b8c...d8e180 )
by Gaetano
07:50
created
src/Server.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -348,7 +348,8 @@
 block discarded – undo
348 348
     /**
349 349
      * Parse http headers received along with xmlrpc request. If needed, inflate request.
350 350
      *
351
-     * @return mixed Response|null on success or an error Response
351
+     * @param string $data
352
+     * @return Response|null Response|null on success or an error Response
352 353
      */
353 354
     protected function parseRequestHeaders(&$data, &$reqEncoding, &$respEncoding, &$respCompression)
354 355
     {
Please login to merge, or discard this patch.
src/Wrapper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
      * @todo validate params? In theory all validation is left to the dispatch map...
393 393
      * @todo add support for $catchWarnings
394 394
      *
395
-     * @param $callable
395
+     * @param callable $callable
396 396
      * @param array $extraOptions
397 397
      * @param string $plainFuncName
398 398
      * @param string $funcDesc
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 
455 455
     /**
456 456
      * Return a name for a new function, based on $callable, insuring its uniqueness
457
-     * @param mixed $callable a php callable, or the name of an xmlrpc method
457
+     * @param callable $callable a php callable, or the name of an xmlrpc method
458 458
      * @param string $newFuncName when not empty, it is used instead of the calculated version
459 459
      * @return string
460 460
      */
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
     }
493 493
 
494 494
     /**
495
-     * @param $callable
495
+     * @param callable $callable
496 496
      * @param string $newFuncName
497 497
      * @param array $extraOptions
498 498
      * @param string $plainFuncName
Please login to merge, or discard this patch.
tests/1ParsingBugsTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -33,6 +33,9 @@
 block discarded – undo
33 33
         }
34 34
     }
35 35
 
36
+    /**
37
+     * @param string $methodName
38
+     */
36 39
     protected function newMsg($methodName, $params = array())
37 40
     {
38 41
         $msg = new xmlrpcmsg($methodName, $params);
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * NB: do not let your IDE fool you. The correct encoding for this file is NOT UTF8.
4
- */
3
+     * NB: do not let your IDE fool you. The correct encoding for this file is NOT UTF8.
4
+     */
5 5
 include_once __DIR__ . '/../lib/xmlrpc.inc';
6 6
 include_once __DIR__ . '/../lib/xmlrpcs.inc';
7 7
 
Please login to merge, or discard this patch.
tests/3LocalhostTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
     /**
116 116
      * @param PhpXmlRpc\Request|array $msg
117
-     * @param int|array $errorCode
117
+     * @param integer $errorCode
118 118
      * @param bool $returnResponse
119 119
      * @return mixed|\PhpXmlRpc\Response|\PhpXmlRpc\Response[]|\PhpXmlRpc\Value|string|void
120 120
      */
@@ -419,6 +419,9 @@  discard block
 block discarded – undo
419 419
         }
420 420
     }
421 421
 
422
+    /**
423
+     * @param string $method
424
+     */
422 425
     public function _multicall_msg($method, $params)
423 426
     {
424 427
         $struct['methodName'] = new xmlrpcval($method, 'string');
Please login to merge, or discard this patch.
debugger/action.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,13 +1,13 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Gaetano Giunta
4
- * @copyright (C) 2005-2015 G. Giunta
5
- * @license code licensed under the BSD License: see file license.txt
6
- *
7
- * @todo switch params for http compression from 0,1,2 to values to be used directly
8
- * @todo use ob_start to catch debug info and echo it AFTER method call results?
9
- * @todo be smarter in creating client stub for proxy/auth cases: only set appropriate property of client obj
10
- **/
3
+     * @author Gaetano Giunta
4
+     * @copyright (C) 2005-2015 G. Giunta
5
+     * @license code licensed under the BSD License: see file license.txt
6
+     *
7
+     * @todo switch params for http compression from 0,1,2 to values to be used directly
8
+     * @todo use ob_start to catch debug info and echo it AFTER method call results?
9
+     * @todo be smarter in creating client stub for proxy/auth cases: only set appropriate property of client obj
10
+     **/
11 11
 
12 12
 header('Content-Type: text/html; charset=utf-8');
13 13
 
Please login to merge, or discard this patch.
tests/phpunit_coverage.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Used to serve back the server-side code coverage results to phpunit-selenium
4
- *
5
- * @copyright (C) 2007-2015 G. Giunta
6
- * @license code licensed under the BSD License: see file license.txt
7
- **/
3
+     * Used to serve back the server-side code coverage results to phpunit-selenium
4
+     *
5
+     * @copyright (C) 2007-2015 G. Giunta
6
+     * @license code licensed under the BSD License: see file license.txt
7
+     **/
8 8
 
9 9
 $coverageFile = realpath(__DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/phpunit_coverage.php");
10 10
 
Please login to merge, or discard this patch.
demo/server/server.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,13 +1,13 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Demo server for xmlrpc library.
4
- *
5
- * Implements a lot of webservices, including a suite of services used for
6
- * interoperability testing (validator1 methods), and some whose only purpose
7
- * is to be used for unit-testing the library.
8
- *
9
- * Please do not copy this file verbatim into your production server.
10
- **/
3
+     * Demo server for xmlrpc library.
4
+     *
5
+     * Implements a lot of webservices, including a suite of services used for
6
+     * interoperability testing (validator1 methods), and some whose only purpose
7
+     * is to be used for unit-testing the library.
8
+     *
9
+     * Please do not copy this file verbatim into your production server.
10
+     **/
11 11
 
12 12
 // give user a chance to see the source for this server instead of running the services
13 13
 if ($_SERVER['REQUEST_METHOD'] != 'POST' && isset($_GET['showSource'])) {
Please login to merge, or discard this patch.
demo/server/proxy.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,13 +1,13 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * XMLRPC server acting as proxy for requests to other servers
4
- * (useful e.g. for ajax-originated calls that can only connect back to
5
- * the originating server).
6
- *
7
- * @author Gaetano Giunta
8
- * @copyright (C) 2006-2015 G. Giunta
9
- * @license code licensed under the BSD License: see file license.txt
10
- */
3
+     * XMLRPC server acting as proxy for requests to other servers
4
+     * (useful e.g. for ajax-originated calls that can only connect back to
5
+     * the originating server).
6
+     *
7
+     * @author Gaetano Giunta
8
+     * @copyright (C) 2006-2015 G. Giunta
9
+     * @license code licensed under the BSD License: see file license.txt
10
+     */
11 11
 
12 12
 include_once __DIR__ . "/../../src/Autoloader.php";
13 13
 PhpXmlRpc\Autoloader::register();
Please login to merge, or discard this patch.
debugger/controller.php 1 patch
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,16 +1,16 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @author Gaetano Giunta
4
- * @copyright (C) 2005-2015 G. Giunta
5
- * @license code licensed under the BSD License: see file license.txt
6
- *
7
- * @todo add links to documentation from every option caption
8
- * @todo switch params for http compression from 0,1,2 to values to be used directly
9
- * @todo add a little bit more CSS formatting: we broke IE box model getting a width > 100%...
10
- * @todo add support for more options, such as ntlm auth to proxy, or request charset encoding
11
- * @todo parse content of payload textarea to be fed to visual editor
12
- * @todo add http no-cache headers
13
- **/
3
+     * @author Gaetano Giunta
4
+     * @copyright (C) 2005-2015 G. Giunta
5
+     * @license code licensed under the BSD License: see file license.txt
6
+     *
7
+     * @todo add links to documentation from every option caption
8
+     * @todo switch params for http compression from 0,1,2 to values to be used directly
9
+     * @todo add a little bit more CSS formatting: we broke IE box model getting a width > 100%...
10
+     * @todo add support for more options, such as ntlm auth to proxy, or request charset encoding
11
+     * @todo parse content of payload textarea to be fed to visual editor
12
+     * @todo add http no-cache headers
13
+     **/
14 14
 
15 15
 // make sure we set the correct charset type for output, so that we can display all characters
16 16
 header('Content-Type: text/html; charset=utf-8');
Please login to merge, or discard this patch.