Passed
Push — master ( c22564...0c11b8 )
by Gaetano
08:03 queued 25s
created
tests/7DemofilesTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests for php files in the 'demo' directory
@@ -11,9 +11,9 @@  discard block
 block discarded – undo
11 11
     {
12 12
         $this->args = argParser::getArgs();
13 13
 
14
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/demo/', $this->args['HTTPURI'] );
14
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/demo/', $this->args['HTTPURI']);
15 15
 
16
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI'] );
16
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
17 17
     }
18 18
 
19 19
     public function testAgeSort()
Please login to merge, or discard this patch.
tests/8DebuggerTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 class DebuggerTest extends PhpXmlRpc_WebTestCase
6 6
 {
@@ -8,9 +8,9 @@  discard block
 block discarded – undo
8 8
     {
9 9
         $this->args = argParser::getArgs();
10 10
 
11
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/debugger/', $this->args['HTTPURI'] );
11
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/debugger/', $this->args['HTTPURI']);
12 12
 
13
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI'] );
13
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
14 14
     }
15 15
 
16 16
     public function testIndex()
Please login to merge, or discard this patch.
tests/9ExtraFilesTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests for php files in the 'extras' directory
@@ -12,9 +12,9 @@  discard block
 block discarded – undo
12 12
     {
13 13
         $this->args = argParser::getArgs();
14 14
 
15
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/extras/', $this->args['HTTPURI'] );
15
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/extras/', $this->args['HTTPURI']);
16 16
 
17
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI'] );
17
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
18 18
     }
19 19
 
20 20
     /**
Please login to merge, or discard this patch.
tests/WebTestCase.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/parse_args.php';
3
+include_once __DIR__.'/parse_args.php';
4 4
 
5
-include_once __DIR__ . '/PolyfillTestCase.php';
5
+include_once __DIR__.'/PolyfillTestCase.php';
6 6
 
7 7
 use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage;
8 8
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function _run($result = NULL)
27 27
     {
28
-        $this->testId = get_class($this) . '__' . $this->getName();
28
+        $this->testId = get_class($this).'__'.$this->getName();
29 29
 
30 30
         if ($result === NULL) {
31 31
             $result = $this->createResult();
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     protected function request($path, $method = 'GET', $payload = '', $emptyPageOk = false)
62 62
     {
63
-        $url = $this->baseUrl . $path;
63
+        $url = $this->baseUrl.$path;
64 64
 
65 65
         $ch = curl_init($url);
66 66
         curl_setopt_array($ch, array(
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         {
79 79
             curl_setopt($ch, CURLOPT_COOKIE, 'PHPUNIT_SELENIUM_TEST_ID='.$this->testId);
80 80
         }
81
-        if ($this->args['DEBUG'] > 0) {
81
+        if ($this->args['DEBUG']>0) {
82 82
             curl_setopt($ch, CURLOPT_VERBOSE, 1);
83 83
         }
84 84
         $page = curl_exec($ch);
Please login to merge, or discard this patch.
demo/server/server.php 2 patches
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -40,11 +40,12 @@
 block discarded – undo
40 40
     $a = $req->getParam(0);
41 41
     $b = $req->getParam(1);
42 42
 
43
-    if ($a->scalartyp() == Value::$xmlrpcNull)
44
-        return new Response(new Value(plain_findstate($b->scalarval())));
45
-    else
46
-        return new Response(new Value(plain_findstate($a->scalarval())));
47
-}
43
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
44
+            return new Response(new Value(plain_findstate($b->scalarval())));
45
+    } else {
46
+            return new Response(new Value(plain_findstate($a->scalarval())));
47
+    }
48
+    }
48 49
 
49 50
 $object = new xmlrpcServerMethodsContainer();
50 51
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * Please _do not_ copy this file verbatim into your production server.
10 10
  */
11 11
 
12
-require_once __DIR__ . "/_prepend.php";
12
+require_once __DIR__."/_prepend.php";
13 13
 
14 14
 use PhpXmlRpc\PhpXmlRpc;
15 15
 use PhpXmlRpc\Response;
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     ),
62 62
     // Greek word 'kosme'. NB: NOT a valid ISO8859 string!
63 63
     // NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
64
-    "tests.utf8methodname." . 'κόσμε' => array(
64
+    "tests.utf8methodname.".'κόσμε' => array(
65 65
         "function" => "stringEcho",
66 66
         "signature" => $stringecho_sig,
67 67
         "docstring" => $stringecho_doc,
@@ -121,4 +121,4 @@  discard block
 block discarded – undo
121 121
 $s->service();
122 122
 // That should do all we need!
123 123
 
124
-require_once __DIR__ . "/_append.php";
124
+require_once __DIR__."/_append.php";
Please login to merge, or discard this patch.
demo/server/methodProviders/functions.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 );
30 30
 
31 31
 $findstate_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcInt));
32
-$findstate_doc = 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the ' .
32
+$findstate_doc = 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the '.
33 33
     'index of that state name in an alphabetic order.';
34 34
 function findState($req)
35 35
 {
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
     // extract the value of the state number
43 43
     $snv = $sno->scalarval();
44 44
     // look it up in our array (zero-based)
45
-    if (isset($GLOBALS['stateNames'][$snv - 1])) {
46
-        $stateName = $GLOBALS['stateNames'][$snv - 1];
45
+    if (isset($GLOBALS['stateNames'][$snv-1])) {
46
+        $stateName = $GLOBALS['stateNames'][$snv-1];
47 47
     } else {
48 48
         // not there, so complain
49
-        $err = "I don't have a state for the index '" . $snv . "'";
49
+        $err = "I don't have a state for the index '".$snv."'";
50 50
     }
51 51
 
52 52
     // if we generated an error, create an error return response
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         return 0;
83 83
     }
84 84
 
85
-    return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
85
+    return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
86 86
 }
87 87
 
88 88
 $agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     // hack, must make global as uksort() won't
129 129
     // allow us to pass any other auxiliary information
130 130
     uksort($agesorter_arr, 'agesorter_compare');
131
-    foreach($agesorter_arr as $key => $val) {
131
+    foreach ($agesorter_arr as $key => $val) {
132 132
         // recreate each struct element
133 133
         $v[] = new Value(
134 134
             array(
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
     $s = $req->getParam(0);
154 154
     $t = $req->getParam(1);
155 155
 
156
-    return new Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
156
+    return new Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
157 157
 }
158 158
 
159 159
 $addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
     $s = $req->getParam(0);
164 164
     $t = $req->getParam(1);
165 165
 
166
-    return new Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
166
+    return new Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
167 167
 }
168 168
 
169 169
 $stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 function echoBack($req)
180 180
 {
181 181
     // just sends back a string with what i got sent to me, just escaped, that's all
182
-    $s = "I got the following message:\n" . $req->serialize();
182
+    $s = "I got the following message:\n".$req->serialize();
183 183
 
184 184
     return new Response(new Value($s));
185 185
 }
@@ -293,17 +293,17 @@  discard block
 block discarded – undo
293 293
         $err = "Error, no 'From' field specified";
294 294
     }
295 295
 
296
-    $msgHdr = "From: " . $mFrom->scalarval() . "\n";
297
-    $msgHdr .= "To: " . $mTo->scalarval() . "\n";
296
+    $msgHdr = "From: ".$mFrom->scalarval()."\n";
297
+    $msgHdr .= "To: ".$mTo->scalarval()."\n";
298 298
 
299 299
     if ($mCc->scalarval() != "") {
300
-        $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
300
+        $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
301 301
     }
302 302
     if ($mBcc->scalarval() != "") {
303
-        $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
303
+        $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
304 304
     }
305 305
     if ($mMime->scalarval() != "") {
306
-        $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
306
+        $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
307 307
     }
308 308
     $msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
309 309
 
Please login to merge, or discard this patch.
demo/server/methodProviders/validator1.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     $moe = $sno["moe"];
37 37
     $larry = $sno["larry"];
38 38
     $curly = $sno["curly"];
39
-    $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
39
+    $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
40 40
 
41 41
     return new Response(new Value($num, Value::$xmlrpcInt));
42 42
 }
@@ -78,9 +78,9 @@  discard block
 block discarded – undo
78 78
     $ar = $req->getParam(0);
79 79
     $sz = $ar->count();
80 80
     $first = $ar[0];
81
-    $last = $ar[$sz - 1];
81
+    $last = $ar[$sz-1];
82 82
 
83
-    return new Response(new Value($first->scalarval() .
83
+    return new Response(new Value($first->scalarval().
84 84
         $last->scalarval(), Value::$xmlrpcString));
85 85
 }
86 86
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     $larry = $fools["larry"];
115 115
     $moe = $fools["moe"];
116 116
 
117
-    return new Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
117
+    return new Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
118 118
 }
119 119
 
120 120
 $v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     $ap = 0;
129 129
     $qu = 0;
130 130
     $amp = 0;
131
-    for ($i = 0; $i < strlen($str); $i++) {
131
+    for ($i = 0; $i<strlen($str); $i++) {
132 132
         $c = substr($str, $i, 1);
133 133
         switch ($c) {
134 134
             case ">":
Please login to merge, or discard this patch.
lib/xmlrpcs.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function echoInput()
56 56
     {
57
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
57
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
58 58
         print $r->serialize();
59 59
     }
60 60
 
@@ -65,11 +65,11 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function __get($name)
67 67
     {
68
-        switch($name) {
68
+        switch ($name) {
69 69
             case 'dmap':
70 70
                 return $this->dmap;
71 71
             default:
72
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' .
72
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.
73 73
                     $trace[0]['line'], E_USER_NOTICE);
74 74
                 return null;
75 75
         }
@@ -96,30 +96,30 @@  discard block
 block discarded – undo
96 96
     Server::xmlrpc_debugmsg($m);
97 97
 }
98 98
 
99
-function _xmlrpcs_getCapabilities($server, $m=null)
99
+function _xmlrpcs_getCapabilities($server, $m = null)
100 100
 {
101 101
     return Server::_xmlrpcs_getCapabilities($server, $m);
102 102
 }
103 103
 
104
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
105
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
106
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
107
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
104
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
105
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
106
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
107
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
108 108
 {
109 109
     return Server::_xmlrpcs_listMethods($server, $m);
110 110
 }
111 111
 
112
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
113
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
114
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
112
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
113
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
114
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
115 115
 function _xmlrpcs_methodSignature($server, $m)
116 116
 {
117 117
     return Server::_xmlrpcs_methodSignature($server, $m);
118 118
 }
119 119
 
120
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
121
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
122
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
120
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
121
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
122
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
123 123
 function _xmlrpcs_methodHelp($server, $m)
124 124
 {
125 125
     return Server::_xmlrpcs_methodHelp($server, $m);
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $val = reset($ar);
108 108
         $typ = key($ar);
109 109
 
110
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
110
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
111 111
         //}
112 112
     }
113 113
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         // preserve back compatibility
127 127
 
128 128
         if (is_array($b)) {
129
-            foreach($b as $id => $cont) {
129
+            foreach ($b as $id => $cont) {
130 130
                 $b[$id] = $cont->scalarval();
131 131
             }
132 132
         }
@@ -134,10 +134,10 @@  discard block
 block discarded – undo
134 134
         // add support for structures directly encoding php objects
135 135
         if (is_object($b)) {
136 136
             $t = get_object_vars($b);
137
-            foreach($t as $id => $cont) {
137
+            foreach ($t as $id => $cont) {
138 138
                 $t[$id] = $cont->scalarval();
139 139
             }
140
-            foreach($t as $id => $cont) {
140
+            foreach ($t as $id => $cont) {
141 141
                 @$b->$id = $cont;
142 142
             }
143 143
         }
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
 /* Expose as global functions the ones which are now class methods */
180 180
 
181 181
 /// Wrong speling, but we are adamant on backwards compatibility!
182
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
182
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
183 183
 {
184 184
     return Charset::instance()->encodeEntities($data, $srcEncoding, $destEncoding);
185 185
 }
186 186
 
187
-function iso8601_encode($timeT, $utc=0)
187
+function iso8601_encode($timeT, $utc = 0)
188 188
 {
189 189
     return Date::iso8601Encode($timeT, $utc);
190 190
 }
191 191
 
192
-function iso8601_decode($iDate, $utc=0)
192
+function iso8601_decode($iDate, $utc = 0)
193 193
 {
194 194
     return Date::iso8601Decode($iDate, $utc);
195 195
 }
@@ -199,25 +199,25 @@  discard block
 block discarded – undo
199 199
     return Http::decodeChunked($buffer);
200 200
 }
201 201
 
202
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
202
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
203 203
 {
204 204
     $encoder = new Encoder();
205 205
     return $encoder->decode($xmlrpcVal, $options);
206 206
 }
207 207
 
208
-function php_xmlrpc_encode($phpVal, $options=array())
208
+function php_xmlrpc_encode($phpVal, $options = array())
209 209
 {
210 210
     $encoder = new Encoder();
211 211
     return $encoder->encode($phpVal, $options);
212 212
 }
213 213
 
214
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
214
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
215 215
 {
216 216
     $encoder = new Encoder();
217 217
     return $encoder->decodeXml($xmlVal, $options);
218 218
 }
219 219
 
220
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
220
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
221 221
 {
222 222
     return XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
223 223
 }
Please login to merge, or discard this patch.