ParallelClient::sendParallel()

Complexity

Conditions	19
Paths	1004

Size

Total Lines	85
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	47
CRAP Score	20.1119

Importance

Changes	3
Bugs	2	Features	1

<?php
    public function sendParallel($requests, $timeout = 0, $method = '')
    {
        if ($method == '') {
            $method = $this->method;
        }

        if ($timeout == 0) {
            $timeout = $this->timeout;
        }

        $opts = $this->getOptions();
        $opts['timeout'] = $timeout;
        // this is required to avoid $this->createCurlHandle reusing the same handle
        $opts['keepalive'] = false;

        /// @todo validate that $method can be handled by the current curl install

        $handles = array();
        $curl = curl_multi_init();

        foreach($requests as $k => $req) {
            $req->setDebug($this->debug);
            $handle = $this->createCurlHandle($req, $method, $this->server, $this->port, $this->path, $opts);
            if (($error = curl_multi_add_handle($curl, $handle)) !== 0) {

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_add_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

It seems like $handle can also be of type false; however, parameter $handle of curl_multi_add_handle() does only seem to accept CurlHandle|resource, maybe add an additional type check?

                throw new \Exception("Curl multi error: $error");
            }
            $handles[$k] = $handle;
        }

        // loop code taken from php manual
        $running = 0;
        do {
            $status = curl_multi_exec($curl, $running);

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_exec() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

            if ($status !== CURLM_OK) {
                throw new \Exception("Curl multi error");
            }
            while (($info = curl_multi_info_read($curl)) !== false) {

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_info_read() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

                if ($info['msg'] === CURLMSG_DONE) {
                    $handle = $info['handle'];
                    curl_multi_remove_handle($curl, $handle);

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_remove_handle() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

                    if ($info['result'] !== CURLE_OK) {
                        /// @todo should we handle this, or is it enough to call curl_error in the loop below?
                    }
                }
            }
            if ($running > 0) {
                if (curl_multi_select($curl) === -1) {

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_select() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

                    throw new \Exception("Curl multi error");
                }
            }
        } while ($running > 0);

        curl_multi_close($curl);

It seems like $curl can also be of type true; however, parameter $multi_handle of curl_multi_close() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check?

        $responses = array();
        $errors = array();
        foreach($handles as $k => $h) {
            $responses[$k] = curl_multi_getcontent($h);

            if ($this->debug > 1) {
                $message = "---CURL INFO---\n";
                foreach (curl_getinfo($h) as $name => $val) {
                    if (is_array($val)) {
                        $val = implode("\n", $val);
                    }
                    $message .= $name . ': ' . $val . "\n";
                }
                $message .= '---END---';
                $this->getLogger()->debugMessage($message);
            }

            if (!$responses[$k]) {
                $errors[$k] = curl_error($h);
            }
        }

        foreach($responses as $k => $resp) {
            if (!$resp) {
                $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . $errors[$k]);
            } else {
                $responses[$k] = $requests[$k]->parseResponse($resp, true, $this->return_type);
            }
        }

        return $responses;
    }