gggeek / phpxmlrpc

src/Server.php

Doc Comments +2 added lines, -1 removed lines

@@ -348,7 +348,8 @@
     /**
      * Parse http headers received along with xmlrpc request. If needed, inflate request.
      *
-     * @return mixed Response|null on success or an error Response
+     * @param string $data
+     * @return Response|null Response|null on success or an error Response
      */
     protected function parseRequestHeaders(&$data, &$reqEncoding, &$respEncoding, &$respCompression)
     {

tests/1ParsingBugsTest.php

Doc Comments +3 added lines

@@ -33,6 +33,9 @@
         }
     }
 
+    /**
+     * @param string $methodName
+     */
     protected function newMsg($methodName, $params = array())
     {
         $msg = new xmlrpcmsg($methodName, $params);

Braces +6 added lines, -4 removed lines

@@ -17,14 +17,16 @@
     protected function setUp()
     {
         $this->args = argParser::getArgs();
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tearDown()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == PHPUnit_Runner_BaseTestRunner::STATUS_ERROR

pakefile.php

Braces +7 added lines, -6 removed lines

@@ -27,8 +27,9 @@ 
 
     public static function libVersion()
     {
-        if (self::$libVersion == null)
-            throw new \Exception('Missing library version argument');
+        if (self::$libVersion == null) {
+                    throw new \Exception('Missing library version argument');
+        }
         return self::$libVersion;
     }
 
@@ -59,9 +60,10 @@ 
 
     public static function getOpts($args=array(), $cliOpts=array())
     {
-        if (count($args) > 0)
-        //    throw new \Exception('Missing library version argument');
+        if (count($args) > 0) {
+                //    throw new \Exception('Missing library version argument');
             self::$libVersion = $args[0];
+        }
 
         foreach (self::$tools as $name => $binary) {
             if (isset($cliOpts[$name])) {
@@ -338,8 +340,7 @@ 
             $cmd = Builder::tool('zip');
             $extra = '-9 -r';
             pake_sh("$cmd $distFile $extra ".basename(Builder::distDir()));
-        }
-        else {
+        } else {
             $finder = pakeFinder::type('any')->pattern(basename(Builder::distDir()).'/**');
             // see https://bugs.php.net/bug.php?id=58852
             $pharFile = str_replace(Builder::libVersion(), '_LIBVERSION_', $distFile);

debugger/action.php

Braces +3 added lines, -1 removed lines

@@ -367,7 +367,9 @@
                                 echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
                                 if ($x->count() > 1) {
                                     foreach($x as $k => $y) {
-                                        if ($k == 0) continue;
+                                        if ($k == 0) {
+                                            continue;
+                                        }
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
                                         if ($wstype != 1) {
                                             $type = $y->scalarval();

tests/3LocalhostTest.php

Braces +6 added lines, -4 removed lines

@@ -96,14 +96,16 @@
 
         $this->coverageScriptUrl = 'http://' . $this->args['LOCALSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI'] );
 
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tearDown()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == PHPUnit_Runner_BaseTestRunner::STATUS_ERROR

Doc Comments +5 added lines, -1 removed lines

@@ -114,7 +114,7 @@ 
 
     /**
      * @param PhpXmlRpc\Request|array $msg
-     * @param int|array $errorCode
+     * @param integer $errorCode
      * @param bool $returnResponse
      * @return mixed|\PhpXmlRpc\Response|\PhpXmlRpc\Response[]|\PhpXmlRpc\Value|string|null
      */
@@ -431,6 +431,10 @@ 
         }
     }
 
+    /**
+     * @param string $method
+     * @param PhpXmlRpc\Value[] $params
+     */
     public function _multicall_msg($method, $params)
     {
         $struct['methodName'] = new xmlrpcval($method, 'string');

tests/2InvalidHostTest.php

Braces +6 added lines, -4 removed lines

@@ -20,14 +20,16 @@
         $this->client = new xmlrpc_client('/NOTEXIST.php', $this->args['LOCALSERVER'], 80);
         $this->client->setDebug($this->args['DEBUG']);
 
-        if ($this->args['DEBUG'] == 1)
-            ob_start();
+        if ($this->args['DEBUG'] == 1) {
+                    ob_start();
+        }
     }
 
     protected function tearDown()
     {
-        if ($this->args['DEBUG'] != 1)
-            return;
+        if ($this->args['DEBUG'] != 1) {
+                    return;
+        }
         $out = ob_get_clean();
         $status = $this->getStatus();
         if ($status == PHPUnit_Runner_BaseTestRunner::STATUS_ERROR

demo/server/server.php

Braces +6 added lines, -5 removed lines

@@ -209,11 +209,12 @@
     $a = $req->getParam(0);
     $b = $req->getParam(1);
 
-    if ($a->scalartyp() == Value::$xmlrpcNull)
-        return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
-    else
-        return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
-}
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
+    } else {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
+    }
+    }
 
 $addtwo_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt, Value::$xmlrpcInt));
 $addtwo_doc = 'Add two integers together and return the result';

src/Wrapper.php

Braces +4 added lines, -3 removed lines

@@ -561,8 +561,9 @@ 
         }
         foreach ($parsVariations as $i => $pars) {
             $innerCode .= "if (\$paramCount == " . count($pars) . ") \$retval = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
-            if ($i < (count($parsVariations) - 1))
-                $innerCode .= "else\n";
+            if ($i < (count($parsVariations) - 1)) {
+                            $innerCode .= "else\n";
+            }
         }
         $innerCode .= "if (is_a(\$retval, '{$namespace}Response')) return \$retval; else\n";
         if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
@@ -615,7 +616,7 @@ 
                         if ($methodWrap) {
                             if (is_object($className)) {
                                 $realClassName = get_class($className);
-                            }else {
+                            } else {
                                 $realClassName = $className;
                             }
                             $results[$prefix."$realClassName.$mName"] = $methodWrap;

Doc Comments +3 added lines, -3 removed lines

@@ -393,7 +393,7 @@ 
      * @todo validate params? In theory all validation is left to the dispatch map...
      * @todo add support for $catchWarnings
      *
-     * @param $callable
+     * @param callable $callable
      * @param array $extraOptions
      * @param string $plainFuncName
      * @param array $funcDesc
@@ -459,7 +459,7 @@ 
 
     /**
      * Return a name for a new function, based on $callable, insuring its uniqueness
-     * @param mixed $callable a php callable, or the name of an xmlrpc method
+     * @param callable $callable a php callable, or the name of an xmlrpc method
      * @param string $newFuncName when not empty, it is used instead of the calculated version
      * @return string
      */
@@ -497,7 +497,7 @@ 
     }
 
     /**
-     * @param $callable
+     * @param callable $callable
      * @param string $newFuncName
      * @param array $extraOptions
      * @param string $plainFuncName

lib/xmlrpc.inc

Doc Comments +6 added lines

@@ -168,6 +168,9 @@ 
     return PhpXmlRpc\Helper\Charset::instance()->encodeEntitites($data, $srcEncoding, $destEncoding);
 }
 
+/**
+ * @param integer $timeT
+ */
 function iso8601_encode($timeT, $utc=0)
 {
     return PhpXmlRpc\Helper\Date::iso8601Encode($timeT, $utc);
@@ -195,6 +198,9 @@ 
     return $encoder->encode($phpVal, $options);
 }
 
+/**
+ * @param string $xmlVal
+ */
 function php_xmlrpc_decode_xml($xmlVal, $options=array())
 {
     $encoder = new PhpXmlRpc\Encoder();