Inspection of "more fixes to the manual" - gggeek/phpxmlrpc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9ff63...64b192 )

by Gaetano

created 2016-01-23 00:22 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/LocalFileTestCase.php';
+include_once __DIR__.'/LocalFileTestCase.php';
 
 /**
  * Tests for php files in the 'demo' directory
@@ -11,9 +11,9 @@  discard block
 block discarded – undo
     {
         $this->args = argParser::getArgs();
 
-        $this->baseUrl = $this->args['LOCALSERVER'] . str_replace( '/demo/server/server.php', '/demo/', $this->args['URI'] );
+        $this->baseUrl = $this->args['LOCALSERVER'].str_replace('/demo/server/server.php', '/demo/', $this->args['URI']);
 
-        $this->coverageScriptUrl = 'http://' . $this->args['LOCALSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI'] );
+        $this->coverageScriptUrl = 'http://'.$this->args['LOCALSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI']);
     }
 
     public function testAgeSort()

Please login to merge, or discard this patch.

demo/vardemo.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -3,16 +3,16 @@  discard block
 block discarded – undo
 <body>
 <?php
 
-include_once __DIR__ . "/../vendor/autoload.php";
+include_once __DIR__."/../vendor/autoload.php";
 
 $req = new PhpXmlRpc\Request('examples.getStateName');
 
 print "<h3>Testing value serialization</h3>\n";
 
 $v = new PhpXmlRpc\Value(23, "int");
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 $v = new PhpXmlRpc\Value("What are you saying? >> << &&");
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $v = new PhpXmlRpc\Value(array(
     new PhpXmlRpc\Value("ABCDEFHIJ"),
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
     "array"
 );
 
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $v = new PhpXmlRpc\Value(
     array(
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
     "struct"
 );
 
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $w = new PhpXmlRpc\Value(array($v, new PhpXmlRpc\Value("That was the struct!")), "array");
 
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
 
 $w = new PhpXmlRpc\Value("Mary had a little lamb,
 Whose fleece was white as snow,
@@ -65,26 +65,26 @@  discard block
 block discarded – undo
 Ten thousand volts went down its back
 And turned it into nylon", "base64"
 );
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
-print "<PRE>Value of base64 string is: '" . $w->scalarval() . "'</PRE>";
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
+print "<PRE>Value of base64 string is: '".$w->scalarval()."'</PRE>";
 
 $req->method('');
 $req->addParam(new PhpXmlRpc\Value("41", "int"));
 
 print "<h3>Testing request serialization</h3>\n";
 $op = $req->serialize();
-print "<PRE>" . htmlentities($op) . "</PRE>";
+print "<PRE>".htmlentities($op)."</PRE>";
 
 print "<h3>Testing ISO date format</h3><pre>\n";
 
 $t = time();
 $date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
 print "Now is $t --> $date\n";
-print "Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n";
+print "Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n";
 $tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
 print "That is to say $date --> $tb\n";
-print "Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n";
-print "Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($date, 1) . "\n";
+print "Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n";
+print "Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($date, 1)."\n";
 
 print "</pre>\n";
 

Please login to merge, or discard this patch.

demo/server/discuss.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . "/../../vendor/autoload.php";
+include_once __DIR__."/../../vendor/autoload.php";
 
 use PhpXmlRpc\Value;
 
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
             $count = 0;
         }
         // add the new comment in
-        dba_insert($msgID . "_comment_${count}", $comment, $dbh);
-        dba_insert($msgID . "_name_${count}", $name, $dbh);
+        dba_insert($msgID."_comment_${count}", $comment, $dbh);
+        dba_insert($msgID."_name_${count}", $name, $dbh);
         $count++;
         dba_replace($countID, $count, $dbh);
         dba_close($dbh);
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
         $countID = "${msgID}_count";
         if (dba_exists($countID, $dbh)) {
             $count = dba_fetch($countID, $dbh);
-            for ($i = 0; $i < $count; $i++) {
+            for ($i = 0; $i<$count; $i++) {
                 $name = dba_fetch("${msgID}_name_${i}", $dbh);
                 $comment = dba_fetch("${msgID}_comment_${i}", $dbh);
                 // push a new struct onto the return array

Please login to merge, or discard this patch.

demo/server/server.php 3 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Demo server for xmlrpc library.
- *
- * Implements a lot of webservices, including a suite of services used for
- * interoperability testing (validator1 methods), and some whose only purpose
- * is to be used for unit-testing the library.
- *
- * Please do not copy this file verbatim into your production server.
- **/
+     * Demo server for xmlrpc library.
+     *
+     * Implements a lot of webservices, including a suite of services used for
+     * interoperability testing (validator1 methods), and some whose only purpose
+     * is to be used for unit-testing the library.
+     *
+     * Please do not copy this file verbatim into your production server.
+     **/
 
 // give user a chance to see the source for this server instead of running the services
 if ($_SERVER['REQUEST_METHOD'] != 'POST' && isset($_GET['showSource'])) {

Please login to merge, or discard this patch.

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@  discard block
 block discarded – undo
     die();
 }
 
-include_once __DIR__ . "/../../vendor/autoload.php";
+include_once __DIR__."/../../vendor/autoload.php";
 
 // out-of-band information: let the client manipulate the server operations.
 // we do this to help the testsuite script: do not reproduce in production!
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
         mkdir($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY']);
     }
 
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
 }
 
 use PhpXmlRpc\Value;
@@ -122,11 +122,11 @@  discard block
 block discarded – undo
     // extract the value of the state number
     $snv = $sno->scalarval();
     // look it up in our array (zero-based)
-    if (isset($stateNames[$snv - 1])) {
-        $stateName = $stateNames[$snv - 1];
+    if (isset($stateNames[$snv-1])) {
+        $stateName = $stateNames[$snv-1];
     } else {
         // not there, so complain
-        $err = "I don't have a state for the index '" . $snv . "'";
+        $err = "I don't have a state for the index '".$snv."'";
     }
 
     // if we generated an error, create an error return response
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
 {
     global $stateNames;
 
-    if (isset($stateNames[$stateNo - 1])) {
-        return $stateNames[$stateNo - 1];
+    if (isset($stateNames[$stateNo-1])) {
+        return $stateNames[$stateNo-1];
     } else {
         // not, there so complain
-        throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
+        throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
     }
 }
 
@@ -186,17 +186,17 @@  discard block
 block discarded – undo
 eval($findstate9_sig['source']);
 
 $findstate10_sig = array(
-    "function" => function ($req) { return findState($req); },
+    "function" => function($req) { return findState($req); },
     "signature" => $findstate_sig,
     "docstring" => $findstate_doc,
 );
 
-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return inner_findstate($stateNo); });
+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return inner_findstate($stateNo); });
 
 $c = new xmlrpcServerMethodsContainer;
 $moreSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'tests.', 'method_type' => 'all'));
 
-$returnObj_sig =  $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
 
 // used to test signatures with NULL params
 $findstate12_sig = array(
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
     $s = $req->getParam(0);
     $t = $req->getParam(1);
 
-    return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
+    return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
 }
 
 $addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
     $s = $req->getParam(0);
     $t = $req->getParam(1);
 
-    return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
+    return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
 }
 
 $stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
 function echoBack($req)
 {
     // just sends back a string with what i got sent to me, just escaped, that's all
-    $s = "I got the following message:\n" . $req->serialize();
+    $s = "I got the following message:\n".$req->serialize();
 
     return new PhpXmlRpc\Response(new Value($s));
 }
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
         return 0;
     }
 
-    return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
+    return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
 }
 
 $agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
@@ -406,17 +406,17 @@  discard block
 block discarded – undo
         $err = "Error, no 'From' field specified";
     }
 
-    $msgHdr = "From: " . $mFrom->scalarval() . "\n";
-    $msgHdr .= "To: " . $mTo->scalarval() . "\n";
+    $msgHdr = "From: ".$mFrom->scalarval()."\n";
+    $msgHdr .= "To: ".$mTo->scalarval()."\n";
 
     if ($mCc->scalarval() != "") {
-        $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
+        $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
     }
     if ($mBcc->scalarval() != "") {
-        $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
+        $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
     }
     if ($mMime->scalarval() != "") {
-        $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
+        $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
     }
     $msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
     $moe = $sno["moe"];
     $larry = $sno["larry"];
     $curly = $sno["curly"];
-    $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
+    $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
 
     return new PhpXmlRpc\Response(new Value($num, Value::$xmlrpcInt));
 }
@@ -548,9 +548,9 @@  discard block
 block discarded – undo
     $ar = $req->getParam(0);
     $sz = $ar->count();
     $first = $ar[0];
-    $last = $ar[$sz - 1];
+    $last = $ar[$sz-1];
 
-    return new PhpXmlRpc\Response(new Value($first->scalarval() .
+    return new PhpXmlRpc\Response(new Value($first->scalarval().
         $last->scalarval(), Value::$xmlrpcString));
 }
 
@@ -584,7 +584,7 @@  discard block
 block discarded – undo
     $larry = $fools["larry"];
     $moe = $fools["moe"];
 
-    return new PhpXmlRpc\Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
+    return new PhpXmlRpc\Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
 }
 
 $v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
     $ap = 0;
     $qu = 0;
     $amp = 0;
-    for ($i = 0; $i < strlen($str); $i++) {
+    for ($i = 0; $i<strlen($str); $i++) {
         $c = substr($str, $i, 1);
         switch ($c) {
             case ">":
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
     ),
     // Greek word 'kosme'. NB: NOT a valid ISO8859 string!
     // NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
-    "tests.utf8methodname." . 'κόσμε' => array(
+    "tests.utf8methodname.".'κόσμε' => array(
         "function" => "stringEcho",
         "signature" => $stringecho_sig,
         "docstring" => $stringecho_doc,
@@ -977,5 +977,5 @@  discard block
 block discarded – undo
 // out-of-band information: let the client manipulate the server operations.
 // we do this to help the testsuite script: do not reproduce in production!
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
 }

Please login to merge, or discard this patch.

Braces +6 added lines, -5 removed lines patch added patch discarded remove patch

@@ -209,11 +209,12 @@
 block discarded – undo
     $a = $req->getParam(0);
     $b = $req->getParam(1);
 
-    if ($a->scalartyp() == Value::$xmlrpcNull)
-        return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
-    else
-        return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
-}
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
+    } else {
+            return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
+    }
+    }
 
 $addtwo_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt, Value::$xmlrpcInt));
 $addtwo_doc = 'Add two integers together and return the result';

Please login to merge, or discard this patch.

demo/server/proxy.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * XMLRPC server acting as proxy for requests to other servers
- * (useful e.g. for ajax-originated calls that can only connect back to
- * the originating server).
- *
- * @author Gaetano Giunta
- * @copyright (C) 2006-2015 G. Giunta
- * @license code licensed under the BSD License: see file license.txt
- */
+     * XMLRPC server acting as proxy for requests to other servers
+     * (useful e.g. for ajax-originated calls that can only connect back to
+     * the originating server).
+     *
+     * @author Gaetano Giunta
+     * @copyright (C) 2006-2015 G. Giunta
+     * @license code licensed under the BSD License: see file license.txt
+     */
 
 include_once __DIR__ . "/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@  discard block
 block discarded – undo
  * @license code licensed under the BSD License: see file license.txt
  */
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 /**
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
     $url = $encoder->decode($req->getParam(0));
     $client = new PhpXmlRpc\Client($url);
 
-    if ($req->getNumParams() > 3) {
+    if ($req->getNumParams()>3) {
         // we have to set some options onto the client.
         // Note that if we do not untaint the received values, warnings might be generated...
         $options = $encoder->decode($req->getParam(3));
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
                     $client->setSSLVerifyPeer($val);
                     break;
                 case 'Timeout':
-                    $timeout = (integer)$val;
+                    $timeout = (integer) $val;
                     break;
             } // switch
         }
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
     }
 
     // add debug info into response we give back to caller
-    PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: " . $req->serialize());
+    PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: ".$req->serialize());
 
     return $client->send($req, $timeout);
 }

Please login to merge, or discard this patch.

demo/client/introspect.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -6,20 +6,20 @@  discard block
 block discarded – undo
 <h3>The code demonstrates usage of multicall and introspection methods</h3>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 function display_error($r)
 {
     print "An error occurred: ";
-    print "Code: " . $r->faultCode()
-        . " Reason: '" . $r->faultString() . "'<br/>";
+    print "Code: ".$r->faultCode()
+        . " Reason: '".$r->faultString()."'<br/>";
 }
 
 $client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
 
 // First off, let's retrieve the list of methods available on the remote server
-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
 $req = new PhpXmlRpc\Request('system.listMethods');
 $resp = $client->send($req);
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 
     // Then, retrieve the signature and help text of each available method
     foreach ($v as $methodName) {
-        print "<h4>" . $methodName->scalarval() . "</h4>\n";
+        print "<h4>".$methodName->scalarval()."</h4>\n";
         // build messages first, add params later
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
             if ($val->kindOf() == "array") {
                 foreach ($val as $x) {
                     $ret = $x[0];
-                    print "<code>" . $ret->scalarval() . " "
-                        . $methodName->scalarval() . "(";
-                    if ($x->count() > 1) {
-                        for ($k = 1; $k < $x->count(); $k++) {
+                    print "<code>".$ret->scalarval()." "
+                        . $methodName->scalarval()."(";
+                    if ($x->count()>1) {
+                        for ($k = 1; $k<$x->count(); $k++) {
                             $y = $x[$k];
                             print $y->scalarval();
-                            if ($k < $x->count() - 1) {
+                            if ($k<$x->count()-1) {
                                 print ", ";
                             }
                         }

Please login to merge, or discard this patch.

demo/client/wrap.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -12,14 +12,14 @@  discard block
 block discarded – undo
 </h3>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 $client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
 $client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
 if ($resp->faultCode()) {
-    echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n";
+    echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n";
 } else {
     echo "<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n";
     flush();
@@ -31,9 +31,9 @@  discard block
 block discarded – undo
         if ($methodName == 'examples.getStateName') {
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
             if ($callable) {
-                echo "<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n";
+                echo "<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n";
             } else {
-                echo "<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n";
+                echo "<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n";
             }
             break;
         }

Please login to merge, or discard this patch.

demo/client/agesort.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -10,13 +10,13 @@  discard block
 block discarded – undo
 <p></p>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 $inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
 print "This is the input data:<br/><pre>";
-foreach($inAr as $key => $val) {
-    print $key . ", " . $val . "\n";
+foreach ($inAr as $key => $val) {
+    print $key.", ".$val."\n";
 }
 print "</pre>";
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
     );
 }
 $v = new PhpXmlRpc\Value($p, "array");
-print "Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n";
+print "Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n";
 
 // create client and message objects
 $req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
@@ -52,15 +52,15 @@  discard block
 block discarded – undo
     foreach ($value as $struct) {
         $name = $struct["name"];
         $age = $struct["age"];
-        print htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n";
+        print htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n";
     }
 
-    print "<hr/>For nerds: I got this value back<br/><pre>" .
-        htmlentities($resp->serialize()) . "</pre><hr/>\n";
+    print "<hr/>For nerds: I got this value back<br/><pre>".
+        htmlentities($resp->serialize())."</pre><hr/>\n";
 } else {
     print "An error occurred:<pre>";
-    print "Code: " . htmlspecialchars($resp->faultCode()) .
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>';
+    print "Code: ".htmlspecialchars($resp->faultCode()).
+        "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>';
 }
 
 ?>

Please login to merge, or discard this patch.

demo/client/proxy.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@
 block discarded – undo
 <h3>The code demonstrates usage for the terminally lazy. For a more complete proxy, look at at the Wrapper class</h3>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 class PhpXmlRpcProxy

Please login to merge, or discard this patch.

		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	die();
16	16	}
17	17
18		-include_once __DIR__ . "/../../vendor/autoload.php";
	18	+include_once __DIR__."/../../vendor/autoload.php";
19	19
20	20	// out-of-band information: let the client manipulate the server operations.
21	21	// we do this to help the testsuite script: do not reproduce in production!
		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	mkdir($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY']);
26	26	}
27	27
28		- include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
	28	+ include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
29	29	}
30	30
31	31	use PhpXmlRpc\Value;
		@@ -122,11 +122,11 @@ discard block
		block discarded – undo
122	122	// extract the value of the state number
123	123	$snv = $sno->scalarval();
124	124	// look it up in our array (zero-based)
125		- if (isset($stateNames[$snv - 1])) {
126		- $stateName = $stateNames[$snv - 1];
	125	+ if (isset($stateNames[$snv-1])) {
	126	+ $stateName = $stateNames[$snv-1];
127	127	} else {
128	128	// not there, so complain
129		- $err = "I don't have a state for the index '" . $snv . "'";
	129	+ $err = "I don't have a state for the index '".$snv."'";
130	130	}
131	131
132	132	// if we generated an error, create an error return response
		@@ -152,11 +152,11 @@ discard block
		block discarded – undo
152	152	{
153	153	global $stateNames;
154	154
155		- if (isset($stateNames[$stateNo - 1])) {
156		- return $stateNames[$stateNo - 1];
	155	+ if (isset($stateNames[$stateNo-1])) {
	156	+ return $stateNames[$stateNo-1];
157	157	} else {
158	158	// not, there so complain
159		- throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
	159	+ throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
160	160	}
161	161	}
162	162
		@@ -186,17 +186,17 @@ discard block
		block discarded – undo
186	186	eval($findstate9_sig['source']);
187	187
188	188	$findstate10_sig = array(
189		- "function" => function ($req) { return findState($req); },
	189	+ "function" => function($req) { return findState($req); },
190	190	"signature" => $findstate_sig,
191	191	"docstring" => $findstate_doc,
192	192	);
193	193
194		-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return inner_findstate($stateNo); });
	194	+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return inner_findstate($stateNo); });
195	195
196	196	$c = new xmlrpcServerMethodsContainer;
197	197	$moreSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'tests.', 'method_type' => 'all'));
198	198
199		-$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
	199	+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
200	200
201	201	// used to test signatures with NULL params
202	202	$findstate12_sig = array(
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	$s = $req->getParam(0);
223	223	$t = $req->getParam(1);
224	224
225		- return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
	225	+ return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
226	226	}
227	227
228	228	$addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
		@@ -232,7 +232,7 @@ discard block
		block discarded – undo
232	232	$s = $req->getParam(0);
233	233	$t = $req->getParam(1);
234	234
235		- return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
	235	+ return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
236	236	}
237	237
238	238	$stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	function echoBack($req)
249	249	{
250	250	// just sends back a string with what i got sent to me, just escaped, that's all
251		- $s = "I got the following message:\n" . $req->serialize();
	251	+ $s = "I got the following message:\n".$req->serialize();
252	252
253	253	return new PhpXmlRpc\Response(new Value($s));
254	254	}
		@@ -305,7 +305,7 @@ discard block
		block discarded – undo
305	305	return 0;
306	306	}
307	307
308		- return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
	308	+ return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
309	309	}
310	310
311	311	$agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
		@@ -406,17 +406,17 @@ discard block
		block discarded – undo
406	406	$err = "Error, no 'From' field specified";
407	407	}
408	408
409		- $msgHdr = "From: " . $mFrom->scalarval() . "\n";
410		- $msgHdr .= "To: " . $mTo->scalarval() . "\n";
	409	+ $msgHdr = "From: ".$mFrom->scalarval()."\n";
	410	+ $msgHdr .= "To: ".$mTo->scalarval()."\n";
411	411
412	412	if ($mCc->scalarval() != "") {
413		- $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
	413	+ $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
414	414	}
415	415	if ($mBcc->scalarval() != "") {
416		- $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
	416	+ $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
417	417	}
418	418	if ($mMime->scalarval() != "") {
419		- $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
	419	+ $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
420	420	}
421	421	$msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
422	422
		@@ -506,7 +506,7 @@ discard block
		block discarded – undo
506	506	$moe = $sno["moe"];
507	507	$larry = $sno["larry"];
508	508	$curly = $sno["curly"];
509		- $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
	509	+ $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
510	510
511	511	return new PhpXmlRpc\Response(new Value($num, Value::$xmlrpcInt));
512	512	}
		@@ -548,9 +548,9 @@ discard block
		block discarded – undo
548	548	$ar = $req->getParam(0);
549	549	$sz = $ar->count();
550	550	$first = $ar[0];
551		- $last = $ar[$sz - 1];
	551	+ $last = $ar[$sz-1];
552	552
553		- return new PhpXmlRpc\Response(new Value($first->scalarval() .
	553	+ return new PhpXmlRpc\Response(new Value($first->scalarval().
554	554	$last->scalarval(), Value::$xmlrpcString));
555	555	}
556	556
		@@ -584,7 +584,7 @@ discard block
		block discarded – undo
584	584	$larry = $fools["larry"];
585	585	$moe = $fools["moe"];
586	586
587		- return new PhpXmlRpc\Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
	587	+ return new PhpXmlRpc\Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
588	588	}
589	589
590	590	$v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
		@@ -598,7 +598,7 @@ discard block
		block discarded – undo
598	598	$ap = 0;
599	599	$qu = 0;
600	600	$amp = 0;
601		- for ($i = 0; $i < strlen($str); $i++) {
	601	+ for ($i = 0; $i<strlen($str); $i++) {
602	602	$c = substr($str, $i, 1);
603	603	switch ($c) {
604	604	case ">":
		@@ -800,7 +800,7 @@ discard block
		block discarded – undo
800	800	),
801	801	// Greek word 'kosme'. NB: NOT a valid ISO8859 string!
802	802	// NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
803		- "tests.utf8methodname." . 'κόσμε' => array(
	803	+ "tests.utf8methodname.".'κόσμε' => array(
804	804	"function" => "stringEcho",
805	805	"signature" => $stringecho_sig,
806	806	"docstring" => $stringecho_doc,
		@@ -977,5 +977,5 @@ discard block
		block discarded – undo
977	977	// out-of-band information: let the client manipulate the server operations.
978	978	// we do this to help the testsuite script: do not reproduce in production!
979	979	if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
980		- include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
	980	+ include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
981	981	}

		@@ -209,11 +209,12 @@
		block discarded – undo
209	209	$a = $req->getParam(0);
210	210	$b = $req->getParam(1);
211	211
212		- if ($a->scalartyp() == Value::$xmlrpcNull)
213		- return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
214		- else
215		- return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
216		-}
	212	+ if ($a->scalartyp() == Value::$xmlrpcNull) {
	213	+ return new PhpXmlRpc\Response(new Value(inner_findstate($b->scalarval())));
	214	+ } else {
	215	+ return new PhpXmlRpc\Response(new Value(inner_findstate($a->scalarval())));
	216	+ }
	217	+ }
217	218
218	219	$addtwo_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt, Value::$xmlrpcInt));
219	220	$addtwo_doc = 'Add two integers together and return the result';

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/LocalFileTestCase.php';
	3	+include_once __DIR__.'/LocalFileTestCase.php';
4	4
5	5	/**
6	6	* Tests for php files in the 'demo' directory
		@@ -11,9 +11,9 @@ discard block
		block discarded – undo
11	11	{
12	12	$this->args = argParser::getArgs();
13	13
14		- $this->baseUrl = $this->args['LOCALSERVER'] . str_replace( '/demo/server/server.php', '/demo/', $this->args['URI'] );
	14	+ $this->baseUrl = $this->args['LOCALSERVER'].str_replace('/demo/server/server.php', '/demo/', $this->args['URI']);
15	15
16		- $this->coverageScriptUrl = 'http://' . $this->args['LOCALSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI'] );
	16	+ $this->coverageScriptUrl = 'http://'.$this->args['LOCALSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['URI']);
17	17	}
18	18
19	19	public function testAgeSort()

		@@ -3,16 +3,16 @@ discard block
		block discarded – undo
3	3	<body>
4	4	<?php
5	5
6		-include_once __DIR__ . "/../vendor/autoload.php";
	6	+include_once __DIR__."/../vendor/autoload.php";
7	7
8	8	$req = new PhpXmlRpc\Request('examples.getStateName');
9	9
10	10	print "<h3>Testing value serialization</h3>\n";
11	11
12	12	$v = new PhpXmlRpc\Value(23, "int");
13		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	13	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
14	14	$v = new PhpXmlRpc\Value("What are you saying? >> << &&");
15		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	15	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
16	16
17	17	$v = new PhpXmlRpc\Value(array(
18	18	new PhpXmlRpc\Value("ABCDEFHIJ"),
		@@ -21,7 +21,7 @@ discard block
		block discarded – undo
21	21	"array"
22	22	);
23	23
24		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	24	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
25	25
26	26	$v = new PhpXmlRpc\Value(
27	27	array(
		@@ -49,11 +49,11 @@ discard block
		block discarded – undo
49	49	"struct"
50	50	);
51	51
52		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	52	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
53	53
54	54	$w = new PhpXmlRpc\Value(array($v, new PhpXmlRpc\Value("That was the struct!")), "array");
55	55
56		-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
	56	+print "<PRE>".htmlentities($w->serialize())."</PRE>";
57	57
58	58	$w = new PhpXmlRpc\Value("Mary had a little lamb,
59	59	Whose fleece was white as snow,
		@@ -65,26 +65,26 @@ discard block
		block discarded – undo
65	65	Ten thousand volts went down its back
66	66	And turned it into nylon", "base64"
67	67	);
68		-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
69		-print "<PRE>Value of base64 string is: '" . $w->scalarval() . "'</PRE>";
	68	+print "<PRE>".htmlentities($w->serialize())."</PRE>";
	69	+print "<PRE>Value of base64 string is: '".$w->scalarval()."'</PRE>";
70	70
71	71	$req->method('');
72	72	$req->addParam(new PhpXmlRpc\Value("41", "int"));
73	73
74	74	print "<h3>Testing request serialization</h3>\n";
75	75	$op = $req->serialize();
76		-print "<PRE>" . htmlentities($op) . "</PRE>";
	76	+print "<PRE>".htmlentities($op)."</PRE>";
77	77
78	78	print "<h3>Testing ISO date format</h3><pre>\n";
79	79
80	80	$t = time();
81	81	$date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
82	82	print "Now is $t --> $date\n";
83		-print "Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n";
	83	+print "Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n";
84	84	$tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
85	85	print "That is to say $date --> $tb\n";
86		-print "Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n";
87		-print "Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($date, 1) . "\n";
	86	+print "Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n";
	87	+print "Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($date, 1)."\n";
88	88
89	89	print "</pre>\n";
90	90

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Demo server for xmlrpc library.
4		- *
5		- * Implements a lot of webservices, including a suite of services used for
6		- * interoperability testing (validator1 methods), and some whose only purpose
7		- * is to be used for unit-testing the library.
8		- *
9		- * Please do not copy this file verbatim into your production server.
10		- **/
	3	+ * Demo server for xmlrpc library.
	4	+ *
	5	+ * Implements a lot of webservices, including a suite of services used for
	6	+ * interoperability testing (validator1 methods), and some whose only purpose
	7	+ * is to be used for unit-testing the library.
	8	+ *
	9	+ * Please do not copy this file verbatim into your production server.
	10	+ **/
11	11
12	12	// give user a chance to see the source for this server instead of running the services
13	13	if ($_SERVER['REQUEST_METHOD'] != 'POST' && isset($_GET['showSource'])) {

		@@ -9,7 +9,7 @@ discard block
		block discarded – undo
9	9	* @license code licensed under the BSD License: see file license.txt
10	10	*/
11	11
12		-include_once __DIR__ . "/../../src/Autoloader.php";
	12	+include_once __DIR__."/../../src/Autoloader.php";
13	13	PhpXmlRpc\Autoloader::register();
14	14
15	15	/**
		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	$url = $encoder->decode($req->getParam(0));
31	31	$client = new PhpXmlRpc\Client($url);
32	32
33		- if ($req->getNumParams() > 3) {
	33	+ if ($req->getNumParams()>3) {
34	34	// we have to set some options onto the client.
35	35	// Note that if we do not untaint the received values, warnings might be generated...
36	36	$options = $encoder->decode($req->getParam(3));
		@@ -50,7 +50,7 @@ discard block
		block discarded – undo
50	50	$client->setSSLVerifyPeer($val);
51	51	break;
52	52	case 'Timeout':
53		- $timeout = (integer)$val;
	53	+ $timeout = (integer) $val;
54	54	break;
55	55	} // switch
56	56	}
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	}
69	69
70	70	// add debug info into response we give back to caller
71		- PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: " . $req->serialize());
	71	+ PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: ".$req->serialize());
72	72
73	73	return $client->send($req, $timeout);
74	74	}

		@@ -6,20 +6,20 @@ discard block
		block discarded – undo
6	6	<h3>The code demonstrates usage of multicall and introspection methods</h3>
7	7	<?php
8	8
9		-include_once __DIR__ . "/../../src/Autoloader.php";
	9	+include_once __DIR__."/../../src/Autoloader.php";
10	10	PhpXmlRpc\Autoloader::register();
11	11
12	12	function display_error($r)
13	13	{
14	14	print "An error occurred: ";
15		- print "Code: " . $r->faultCode()
16		- . " Reason: '" . $r->faultString() . "'<br/>";
	15	+ print "Code: ".$r->faultCode()
	16	+ . " Reason: '".$r->faultString()."'<br/>";
17	17	}
18	18
19	19	$client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
20	20
21	21	// First off, let's retrieve the list of methods available on the remote server
22		-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
	22	+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
23	23	$req = new PhpXmlRpc\Request('system.listMethods');
24	24	$resp = $client->send($req);
25	25
		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30
31	31	// Then, retrieve the signature and help text of each available method
32	32	foreach ($v as $methodName) {
33		- print "<h4>" . $methodName->scalarval() . "</h4>\n";
	33	+ print "<h4>".$methodName->scalarval()."</h4>\n";
34	34	// build messages first, add params later
35	35	$m1 = new PhpXmlRpc\Request('system.methodHelp');
36	36	$m2 = new PhpXmlRpc\Request('system.methodSignature');
		@@ -61,13 +61,13 @@ discard block
		block discarded – undo
61	61	if ($val->kindOf() == "array") {
62	62	foreach ($val as $x) {
63	63	$ret = $x[0];
64		- print "<code>" . $ret->scalarval() . " "
65		- . $methodName->scalarval() . "(";
66		- if ($x->count() > 1) {
67		- for ($k = 1; $k < $x->count(); $k++) {
	64	+ print "<code>".$ret->scalarval()." "
	65	+ . $methodName->scalarval()."(";
	66	+ if ($x->count()>1) {
	67	+ for ($k = 1; $k<$x->count(); $k++) {
68	68	$y = $x[$k];
69	69	print $y->scalarval();
70		- if ($k < $x->count() - 1) {
	70	+ if ($k<$x->count()-1) {
71	71	print ", ";
72	72	}
73	73	}

		@@ -12,14 +12,14 @@ discard block
		block discarded – undo
12	12	</h3>
13	13	<?php
14	14
15		-include_once __DIR__ . "/../../src/Autoloader.php";
	15	+include_once __DIR__."/../../src/Autoloader.php";
16	16	PhpXmlRpc\Autoloader::register();
17	17
18	18	$client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
19	19	$client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
20	20	$resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
21	21	if ($resp->faultCode()) {
22		- echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n";
	22	+ echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n";
23	23	} else {
24	24	echo "<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n";
25	25	flush();
		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31	if ($methodName == 'examples.getStateName') {
32	32	$callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
33	33	if ($callable) {
34		- echo "<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n";
	34	+ echo "<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n";
35	35	} else {
36		- echo "<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n";
	36	+ echo "<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n";
37	37	}
38	38	break;
39	39	}

		@@ -10,13 +10,13 @@ discard block
		block discarded – undo
10	10	<p></p>
11	11	<?php
12	12
13		-include_once __DIR__ . "/../../src/Autoloader.php";
	13	+include_once __DIR__."/../../src/Autoloader.php";
14	14	PhpXmlRpc\Autoloader::register();
15	15
16	16	$inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
17	17	print "This is the input data:<br/><pre>";
18		-foreach($inAr as $key => $val) {
19		- print $key . ", " . $val . "\n";
	18	+foreach ($inAr as $key => $val) {
	19	+ print $key.", ".$val."\n";
20	20	}
21	21	print "</pre>";
22	22
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	);
33	33	}
34	34	$v = new PhpXmlRpc\Value($p, "array");
35		-print "Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n";
	35	+print "Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n";
36	36
37	37	// create client and message objects
38	38	$req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
		@@ -52,15 +52,15 @@ discard block
		block discarded – undo
52	52	foreach ($value as $struct) {
53	53	$name = $struct["name"];
54	54	$age = $struct["age"];
55		- print htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n";
	55	+ print htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n";
56	56	}
57	57
58		- print "<hr/>For nerds: I got this value back<br/><pre>" .
59		- htmlentities($resp->serialize()) . "</pre><hr/>\n";
	58	+ print "<hr/>For nerds: I got this value back<br/><pre>".
	59	+ htmlentities($resp->serialize())."</pre><hr/>\n";
60	60	} else {
61	61	print "An error occurred:<pre>";
62		- print "Code: " . htmlspecialchars($resp->faultCode()) .
63		- "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>';
	62	+ print "Code: ".htmlspecialchars($resp->faultCode()).
	63	+ "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>';
64	64	}
65	65
66	66	?>

		@@ -6,7 +6,7 @@
		block discarded – undo
6	6	<h3>The code demonstrates usage for the terminally lazy. For a more complete proxy, look at at the Wrapper class</h3>
7	7	<?php
8	8
9		-include_once __DIR__ . "/../../src/Autoloader.php";
	9	+include_once __DIR__."/../../src/Autoloader.php";
10	10	PhpXmlRpc\Autoloader::register();
11	11
12	12	class PhpXmlRpcProxy

gggeek / phpxmlrpc

Push — master ( a9ff63...64b192 )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +27 added lines, -27 removed lines patch added patch discarded remove patch

Braces +6 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch