Inspection of "more gha ci fixes" - gggeek/phpxmlrpc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0c11b8...7877a8 )

by Gaetano

created 2022-11-23 18:29 UTC

Status

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -17,15 +17,15 @@  discard block
 block discarded – undo
 // Make sure we set the correct charset type for output, so that we can display all characters
 header('Content-Type: text/html; charset=utf-8');
 
-include __DIR__ . '/common.php';
+include __DIR__.'/common.php';
 if ($action == '') {
     $action = 'list';
 }
 
 // Relative path to the visual xmlrpc editing dialog
 // We allow to easily configure this path via defines
-$editorpath = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..') . '/jsxmlrpc/debugger/';
-$editorlibs = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..') . '/jsxmlrpc/lib/';
+$editorpath = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..').'/jsxmlrpc/debugger/';
+$editorlibs = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..').'/jsxmlrpc/lib/';
 ?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
     "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
@@ -230,9 +230,9 @@  discard block
 block discarded – undo
         echo ' document.forms[2].submit();';
     } ?>">
 <h1>XMLRPC
-    <form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);" <?php if (!class_exists('\PhpXmlRpc\Client')) { echo 'disabled="disabled"';} ?>/></form>
+    <form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);" <?php if (!class_exists('\PhpXmlRpc\Client')) { echo 'disabled="disabled"'; } ?>/></form>
     /
-    <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);" <?php if (!class_exists('\PhpXmlRpc\JsonRpc\Client')) { echo 'disabled="disabled"';} ?>/></form>
+    <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);" <?php if (!class_exists('\PhpXmlRpc\JsonRpc\Client')) { echo 'disabled="disabled"'; } ?>/></form>
     JSONRPC Debugger (based on the <a href="http://gggeek.github.io/phpxmlrpc/">PHP-XMLRPC</a> library)
 </h1>
 <form name="frmaction" method="get" action="action.php" target="frmaction" onSubmit="switchFormMethod();">
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
                 </select>
             </td>
             <td class="labelcell">Timeout:</td>
-            <td><input type="text" name="timeout" size="3" value="<?php if ($timeout > 0) { echo $timeout; } ?>"/></td>
+            <td><input type="text" name="timeout" size="3" value="<?php if ($timeout>0) { echo $timeout; } ?>"/></td>
             <td class="labelcell">Protocol:</td>
             <td><select name="protocol" onchange="switchssl(); switchauth(); swicthcainfo();">
                     <option value="0"<?php if ($protocol == 0) { echo ' selected="selected"'; } ?>>HTTP 1.0</option>

Please login to merge, or discard this patch.

tests/4ClientTest.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,10 +1,10 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/PolyfillTestCase.php';
+include_once __DIR__.'/PolyfillTestCase.php';
 
 use PHPUnit\Runner\BaseTestRunner;
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
         $this->client->server .= 'XXX';
         $dnsinfo = @dns_get_record($this->client->server);
         if ($dnsinfo) {
-            $this->markTestSkipped('Seems like there is a catchall DNS in effect: host ' . $this->client->server . ' found');
+            $this->markTestSkipped('Seems like there is a catchall DNS in effect: host '.$this->client->server.' found');
         } else {
             $r = $this->client->send($m, 5);
             // make sure there's no freaking catchall DNS in effect
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
 
         // now test a successful connection
         $server = explode(':', $this->args['HTTPSERVER']);
-        if (count($server) > 1) {
+        if (count($server)>1) {
             $this->client->port = $server[1];
         }
         $this->client->server = $server[0];

Please login to merge, or discard this patch.

tests/0CharsetTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
  * @author JoakimLofgren
  */
 
-include_once __DIR__ . '/PolyfillTestCase.php';
+include_once __DIR__.'/PolyfillTestCase.php';
 
 use PhpXmlRpc\Helper\Charset;
 
@@ -32,10 +32,10 @@  discard block
 block discarded – undo
     {
         // construct a latin string with all chars (except control ones)
         $this->latinString = "\n\r\t";
-        for($i = 32; $i < 127; $i++) {
+        for ($i = 32; $i<127; $i++) {
             $this->latinString .= chr($i);
         }
-        for($i = 160; $i < 256; $i++) {
+        for ($i = 160; $i<256; $i++) {
             $this->latinString .= chr($i);
         }
     }

Please login to merge, or discard this patch.

tests/3EncoderTest.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpcs.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/PolyfillTestCase.php';
+include_once __DIR__.'/PolyfillTestCase.php';
 
 use PHPUnit\Runner\BaseTestRunner;
 

Please login to merge, or discard this patch.

tests/2MessageTest.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpcs.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/PolyfillTestCase.php';
+include_once __DIR__.'/PolyfillTestCase.php';
 
 use PHPUnit\Runner\BaseTestRunner;
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
 
     public function testI8()
     {
-        if (PHP_INT_SIZE == 4 ) {
+        if (PHP_INT_SIZE == 4) {
             $this->markTestSkipped('Can not test i8 as php is compiled in 32 bit mode');
             return;
         }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
 
     public function testUnicodeInMemberName()
     {
-        $str = "G" . chr(252) . "nter, El" . chr(232) . "ne";
+        $str = "G".chr(252)."nter, El".chr(232)."ne";
         $v = array($str => new xmlrpcval(1));
         $r = new xmlrpcresp(new xmlrpcval($v, 'struct'));
         $r = $r->serialize();
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
             '<?xml version="1.0"?>
 <!-- $Id -->
 <!-- found by G. Giunta, covers what happens when lib receives UTF8 chars in response text and comments -->
-<!-- ' . chr(224) . chr(252) . chr(232) . '&#224;&#252;&#232; -->
+<!-- ' . chr(224).chr(252).chr(232).'&#224;&#252;&#232; -->
 <methodResponse>
 <fault>
 <value>
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
 </member>
 <member>
 <name>faultString</name>
-<value><string>' . chr(224) . chr(252) . chr(232) . '&#224;&#252;&#232;</string></value>
+<value><string>' . chr(224).chr(252).chr(232).'&#224;&#252;&#232;</string></value>
 </member>
 </struct>
 </value>
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
         $m = $this->newMsg('dummy');
         $r = $m->parseResponse($response);
         $v = $r->faultString();
-        $this->assertEquals(chr(224) . chr(252) . chr(232) . chr(224) . chr(252) . chr(232), $v);
+        $this->assertEquals(chr(224).chr(252).chr(232).chr(224).chr(252).chr(232), $v);
     }
 
     public function testBrokenRequests()
@@ -409,11 +409,11 @@  discard block
 block discarded – undo
 
     public function testUTF8Response()
     {
-        $string = chr(224) . chr(252) . chr(232);
+        $string = chr(224).chr(252).chr(232);
 
         $s = $this->newMsg('dummy');
-        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
+        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
 ';
         $r = $s->parseResponse($f, false, 'phpvals');
         $v = $r->value();
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
         $this->assertEquals($string, $v);
 
         $f = '<?xml version="1.0" encoding="UTF-8"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
 ';
         $r = $s->parseResponse($f, false, 'phpvals');
         $v = $r->value();
@@ -437,11 +437,11 @@  discard block
 block discarded – undo
 
     public function testLatin1Response()
     {
-        $string = chr(224) . chr(252) . chr(232);
+        $string = chr(224).chr(252).chr(232);
 
         $s = $this->newMsg('dummy');
-        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
+        $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
 ';
         $r = $s->parseResponse($f, false, 'phpvals');
         $v = $r->value();
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
         $this->assertEquals($string, $v);
 
         $f = '<?xml version="1.0" encoding="ISO-8859-1"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
 ';
         $r = $s->parseResponse($f, false, 'phpvals');
         $v = $r->value();

Please login to merge, or discard this patch.

tests/6HTTPTest.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/5ServerTest.php';
+include_once __DIR__.'/5ServerTest.php';
 
 /**
  * Tests which stress http features of the library.
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
         );
 
         $methods = array();
-        foreach(get_class_methods('ServerTest') as $method)
+        foreach (get_class_methods('ServerTest') as $method)
         {
             if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
             {

Please login to merge, or discard this patch.

tests/1ValueTest.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpcs.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/PolyfillTestCase.php';
+include_once __DIR__.'/PolyfillTestCase.php';
 
 use PHPUnit\Runner\BaseTestRunner;
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
         $this->assertequals(1, count($v1));
         $out = array('me' => array(), 'mytype' => 2, '_php_class' => null);
 
-        foreach($v1 as $key => $val)
+        foreach ($v1 as $key => $val)
         {
             $this->assertArrayHasKey($key, $out);
             $expected = $out[$key];
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
         $this->assertequals(2, count($v2));
         $out = array(array('key' => 0, 'value'  => 'object'), array('key' => 1, 'value'  => 'object'));
         $i = 0;
-        foreach($v2 as $key => $val)
+        foreach ($v2 as $key => $val)
         {
             $expected = $out[$i];
             $this->assertequals($expected['key'], $key);
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
     {
         // nb: make sure that  the serialized xml corresponding to this is > 10MB in size
         $data = array();
-        for ($i = 0; $i < 500000; $i++ ) {
+        for ($i = 0; $i<500000; $i++) {
             $data[] = 'hello world';
         }
 

Please login to merge, or discard this patch.

extras/verify_compat.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -17,8 +17,8 @@  discard block
 block discarded – undo
         // test for php version
         $ver = phpversion();
         $tests['php_version'] = array();
-        $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
-        if (version_compare($ver, '5.3.0') < 0) {
+        $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
+        if (version_compare($ver, '5.3.0')<0) {
             $tests['php_version']['status'] = 0;
             $tests['php_version']['description'] .= 'This version of PHP is not compatible with this release of the PHP XMLRPC library. Please upgrade to php 5.1.0 or later';
         } else {
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
         // test for php version
         $ver = phpversion();
         $tests['php_version'] = array();
-        $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
-        if (version_compare($ver, '5.3.0') < 0) {
+        $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
+        if (version_compare($ver, '5.3.0')<0) {
             $tests['php_version']['status'] = 0;
             $tests['php_version']['description'] .= 'This version of PHP is not compatible with the PHP XMLRPC library. Please upgrade to 5.1.0 or later';
         } else {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
             $info = curl_version();
             $tests['curl']['status'] = 2;
             $tests['curl']['description'] = "The cURL extension is enabled.\n\nYou will be able to send and receive messages using 'HTTPS' and 'HTTP 1.1' protocols";
-            if (version_compare($ver, '4.3.8') < 0) {
+            if (version_compare($ver, '4.3.8')<0) {
                 $tests['curl']['status'] = 1;
                 $tests['curl']['description'] .= ".\nPlease note that the current cURL install does not support keep-alives";
             }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
     <?php
     $res = phpxmlrpc_verify_compat('server');
     foreach ($res as $test => $result) {
-        echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
+        echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
     }
     ?>
     </tbody>
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
     <?php
     $res = phpxmlrpc_verify_compat('client');
     foreach ($res as $test => $result) {
-        echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
+        echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
     }
     ?>
     </tbody>

Please login to merge, or discard this patch.

tests/7DemofilesTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/WebTestCase.php';
+include_once __DIR__.'/WebTestCase.php';
 
 /**
  * Tests for php files in the 'demo' directory
@@ -11,9 +11,9 @@  discard block
 block discarded – undo
     {
         $this->args = argParser::getArgs();
 
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/demo/', $this->args['HTTPURI'] );
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/demo/', $this->args['HTTPURI']);
 
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI'] );
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
     }
 
     public function testAgeSort()

Please login to merge, or discard this patch.

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/../lib/xmlrpc.inc';
4		-include_once __DIR__ . '/../lib/xmlrpcs.inc';
	3	+include_once __DIR__.'/../lib/xmlrpc.inc';
	4	+include_once __DIR__.'/../lib/xmlrpcs.inc';
5	5
6		-include_once __DIR__ . '/parse_args.php';
	6	+include_once __DIR__.'/parse_args.php';
7	7
8		-include_once __DIR__ . '/PolyfillTestCase.php';
	8	+include_once __DIR__.'/PolyfillTestCase.php';
9	9
10	10	use PHPUnit\Runner\BaseTestRunner;
11	11
		@@ -103,7 +103,7 @@ discard block
		block discarded – undo
103	103
104	104	public function testI8()
105	105	{
106		- if (PHP_INT_SIZE == 4 ) {
	106	+ if (PHP_INT_SIZE == 4) {
107	107	$this->markTestSkipped('Can not test i8 as php is compiled in 32 bit mode');
108	108	return;
109	109	}
		@@ -133,7 +133,7 @@ discard block
		block discarded – undo
133	133
134	134	public function testUnicodeInMemberName()
135	135	{
136		- $str = "G" . chr(252) . "nter, El" . chr(232) . "ne";
	136	+ $str = "G".chr(252)."nter, El".chr(232)."ne";
137	137	$v = array($str => new xmlrpcval(1));
138	138	$r = new xmlrpcresp(new xmlrpcval($v, 'struct'));
139	139	$r = $r->serialize();
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	'<?xml version="1.0"?>
150	150	<!-- $Id -->
151	151	<!-- found by G. Giunta, covers what happens when lib receives UTF8 chars in response text and comments -->
152		-<!-- ' . chr(224) . chr(252) . chr(232) . 'àüè -->
	152	+<!-- ' . chr(224).chr(252).chr(232).'àüè -->
153	153	<methodResponse>
154	154	<fault>
155	155	<value>
		@@ -160,7 +160,7 @@ discard block
		block discarded – undo
160	160	</member>
161	161	<member>
162	162	<name>faultString</name>
163		-<value><string>' . chr(224) . chr(252) . chr(232) . 'àüè</string></value>
	163	+<value><string>' . chr(224).chr(252).chr(232).'àüè</string></value>
164	164	</member>
165	165	</struct>
166	166	</value>
		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169	$m = $this->newMsg('dummy');
170	170	$r = $m->parseResponse($response);
171	171	$v = $r->faultString();
172		- $this->assertEquals(chr(224) . chr(252) . chr(232) . chr(224) . chr(252) . chr(232), $v);
	172	+ $this->assertEquals(chr(224).chr(252).chr(232).chr(224).chr(252).chr(232), $v);
173	173	}
174	174
175	175	public function testBrokenRequests()
		@@ -409,11 +409,11 @@ discard block
		block discarded – undo
409	409
410	410	public function testUTF8Response()
411	411	{
412		- $string = chr(224) . chr(252) . chr(232);
	412	+ $string = chr(224).chr(252).chr(232);
413	413
414	414	$s = $this->newMsg('dummy');
415		- $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
416		-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
	415	+ $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
	416	+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
417	417	';
418	418	$r = $s->parseResponse($f, false, 'phpvals');
419	419	$v = $r->value();
		@@ -421,7 +421,7 @@ discard block
		block discarded – undo
421	421	$this->assertEquals($string, $v);
422	422
423	423	$f = '<?xml version="1.0" encoding="UTF-8"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
424		-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
	424	+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
425	425	';
426	426	$r = $s->parseResponse($f, false, 'phpvals');
427	427	$v = $r->value();
		@@ -437,11 +437,11 @@ discard block
		block discarded – undo
437	437
438	438	public function testLatin1Response()
439	439	{
440		- $string = chr(224) . chr(252) . chr(232);
	440	+ $string = chr(224).chr(252).chr(232);
441	441
442	442	$s = $this->newMsg('dummy');
443		- $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
444		-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
	443	+ $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
	444	+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
445	445	';
446	446	$r = $s->parseResponse($f, false, 'phpvals');
447	447	$v = $r->value();
		@@ -449,7 +449,7 @@ discard block
		block discarded – undo
449	449	$this->assertEquals($string, $v);
450	450
451	451	$f = '<?xml version="1.0" encoding="ISO-8859-1"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member>
452		-<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
	452	+<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse>
453	453	';
454	454	$r = $s->parseResponse($f, false, 'phpvals');
455	455	$v = $r->value();

		@@ -17,15 +17,15 @@ discard block
		block discarded – undo
17	17	// Make sure we set the correct charset type for output, so that we can display all characters
18	18	header('Content-Type: text/html; charset=utf-8');
19	19
20		-include __DIR__ . '/common.php';
	20	+include __DIR__.'/common.php';
21	21	if ($action == '') {
22	22	$action = 'list';
23	23	}
24	24
25	25	// Relative path to the visual xmlrpc editing dialog
26	26	// We allow to easily configure this path via defines
27		-$editorpath = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..') . '/jsxmlrpc/debugger/';
28		-$editorlibs = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..') . '/jsxmlrpc/lib/';
	27	+$editorpath = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..').'/jsxmlrpc/debugger/';
	28	+$editorlibs = (defined('JSXMLRPC_PATH') ? JSXMLRPC_PATH : '../..').'/jsxmlrpc/lib/';
29	29	?>
30	30	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
31	31	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
		@@ -230,9 +230,9 @@ discard block
		block discarded – undo
230	230	echo ' document.forms[2].submit();';
231	231	} ?>">
232	232	<h1>XMLRPC
233		- <form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);" <?php if (!class_exists('\PhpXmlRpc\Client')) { echo 'disabled="disabled"';} ?>/></form>
	233	+ <form name="frmxmlrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(0);" <?php if (!class_exists('\PhpXmlRpc\Client')) { echo 'disabled="disabled"'; } ?>/></form>
234	234	/
235		- <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);" <?php if (!class_exists('\PhpXmlRpc\JsonRpc\Client')) { echo 'disabled="disabled"';} ?>/></form>
	235	+ <form name="frmjsonrpc" style="display: inline;" action="."><input name="yes" type="radio" onclick="switchtransport(1);" <?php if (!class_exists('\PhpXmlRpc\JsonRpc\Client')) { echo 'disabled="disabled"'; } ?>/></form>
236	236	JSONRPC Debugger (based on the <a href="http://gggeek.github.io/phpxmlrpc/">PHP-XMLRPC</a> library)
237	237	</h1>
238	238	<form name="frmaction" method="get" action="action.php" target="frmaction" onSubmit="switchFormMethod();">
		@@ -287,7 +287,7 @@ discard block
		block discarded – undo
287	287	</select>
288	288	</td>
289	289	<td class="labelcell">Timeout:</td>
290		- <td><input type="text" name="timeout" size="3" value="<?php if ($timeout > 0) { echo $timeout; } ?>"/></td>
	290	+ <td><input type="text" name="timeout" size="3" value="<?php if ($timeout>0) { echo $timeout; } ?>"/></td>
291	291	<td class="labelcell">Protocol:</td>
292	292	<td><select name="protocol" onchange="switchssl(); switchauth(); swicthcainfo();">
293	293	<option value="0"<?php if ($protocol == 0) { echo ' selected="selected"'; } ?>>HTTP 1.0</option>

		@@ -1,10 +1,10 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/../lib/xmlrpc.inc';
	3	+include_once __DIR__.'/../lib/xmlrpc.inc';
4	4
5		-include_once __DIR__ . '/parse_args.php';
	5	+include_once __DIR__.'/parse_args.php';
6	6
7		-include_once __DIR__ . '/PolyfillTestCase.php';
	7	+include_once __DIR__.'/PolyfillTestCase.php';
8	8
9	9	use PHPUnit\Runner\BaseTestRunner;
10	10
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	$this->client->server .= 'XXX';
59	59	$dnsinfo = @dns_get_record($this->client->server);
60	60	if ($dnsinfo) {
61		- $this->markTestSkipped('Seems like there is a catchall DNS in effect: host ' . $this->client->server . ' found');
	61	+ $this->markTestSkipped('Seems like there is a catchall DNS in effect: host '.$this->client->server.' found');
62	62	} else {
63	63	$r = $this->client->send($m, 5);
64	64	// make sure there's no freaking catchall DNS in effect
		@@ -85,7 +85,7 @@ discard block
		block discarded – undo
85	85
86	86	// now test a successful connection
87	87	$server = explode(':', $this->args['HTTPSERVER']);
88		- if (count($server) > 1) {
	88	+ if (count($server)>1) {
89	89	$this->client->port = $server[1];
90	90	}
91	91	$this->client->server = $server[0];

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	* @author JoakimLofgren
4	4	*/
5	5
6		-include_once __DIR__ . '/PolyfillTestCase.php';
	6	+include_once __DIR__.'/PolyfillTestCase.php';
7	7
8	8	use PhpXmlRpc\Helper\Charset;
9	9
		@@ -32,10 +32,10 @@ discard block
		block discarded – undo
32	32	{
33	33	// construct a latin string with all chars (except control ones)
34	34	$this->latinString = "\n\r\t";
35		- for($i = 32; $i < 127; $i++) {
	35	+ for ($i = 32; $i<127; $i++) {
36	36	$this->latinString .= chr($i);
37	37	}
38		- for($i = 160; $i < 256; $i++) {
	38	+ for ($i = 160; $i<256; $i++) {
39	39	$this->latinString .= chr($i);
40	40	}
41	41	}

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/../lib/xmlrpc.inc';
4		-include_once __DIR__ . '/../lib/xmlrpcs.inc';
	3	+include_once __DIR__.'/../lib/xmlrpc.inc';
	4	+include_once __DIR__.'/../lib/xmlrpcs.inc';
5	5
6		-include_once __DIR__ . '/parse_args.php';
	6	+include_once __DIR__.'/parse_args.php';
7	7
8		-include_once __DIR__ . '/PolyfillTestCase.php';
	8	+include_once __DIR__.'/PolyfillTestCase.php';
9	9
10	10	use PHPUnit\Runner\BaseTestRunner;
11	11

		@@ -17,8 +17,8 @@ discard block
		block discarded – undo
17	17	// test for php version
18	18	$ver = phpversion();
19	19	$tests['php_version'] = array();
20		- $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
21		- if (version_compare($ver, '5.3.0') < 0) {
	20	+ $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
	21	+ if (version_compare($ver, '5.3.0')<0) {
22	22	$tests['php_version']['status'] = 0;
23	23	$tests['php_version']['description'] .= 'This version of PHP is not compatible with this release of the PHP XMLRPC library. Please upgrade to php 5.1.0 or later';
24	24	} else {
		@@ -51,8 +51,8 @@ discard block
		block discarded – undo
51	51	// test for php version
52	52	$ver = phpversion();
53	53	$tests['php_version'] = array();
54		- $tests['php_version']['description'] = 'PHP version found: ' . $ver . ".\n\n";
55		- if (version_compare($ver, '5.3.0') < 0) {
	54	+ $tests['php_version']['description'] = 'PHP version found: '.$ver.".\n\n";
	55	+ if (version_compare($ver, '5.3.0')<0) {
56	56	$tests['php_version']['status'] = 0;
57	57	$tests['php_version']['description'] .= 'This version of PHP is not compatible with the PHP XMLRPC library. Please upgrade to 5.1.0 or later';
58	58	} else {
		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	$info = curl_version();
80	80	$tests['curl']['status'] = 2;
81	81	$tests['curl']['description'] = "The cURL extension is enabled.\n\nYou will be able to send and receive messages using 'HTTPS' and 'HTTP 1.1' protocols";
82		- if (version_compare($ver, '4.3.8') < 0) {
	82	+ if (version_compare($ver, '4.3.8')<0) {
83	83	$tests['curl']['status'] = 1;
84	84	$tests['curl']['description'] .= ".\nPlease note that the current cURL install does not support keep-alives";
85	85	}
		@@ -167,7 +167,7 @@ discard block
		block discarded – undo
167	167	<?php
168	168	$res = phpxmlrpc_verify_compat('server');
169	169	foreach ($res as $test => $result) {
170		- echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
	170	+ echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
171	171	}
172	172	?>
173	173	</tbody>
		@@ -184,7 +184,7 @@ discard block
		block discarded – undo
184	184	<?php
185	185	$res = phpxmlrpc_verify_compat('client');
186	186	foreach ($res as $test => $result) {
187		- echo '<tr><td class="res' . $result['status'] . '">' . htmlspecialchars($test) . '</td><td class="result">' . htmlspecialchars($result['description']) . "</td></tr>\n";
	187	+ echo '<tr><td class="res'.$result['status'].'">'.htmlspecialchars($test).'</td><td class="result">'.htmlspecialchars($result['description'])."</td></tr>\n";
188	188	}
189	189	?>
190	190	</tbody>

		@@ -1,6 +1,6 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/WebTestCase.php';
	3	+include_once __DIR__.'/WebTestCase.php';
4	4
5	5	/**
6	6	* Tests for php files in the 'demo' directory
		@@ -11,9 +11,9 @@ discard block
		block discarded – undo
11	11	{
12	12	$this->args = argParser::getArgs();
13	13
14		- $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/demo/', $this->args['HTTPURI'] );
	14	+ $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/demo/', $this->args['HTTPURI']);
15	15
16		- $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace( '/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI'] );
	16	+ $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
17	17	}
18	18
19	19	public function testAgeSort()

gggeek / phpxmlrpc

Push — master ( 0c11b8...7877a8 )

Status

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch