Passed
Push — master ( 43c003...f5456e )
by Gaetano
07:42
created
src/Helper/Date.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
                 // of PHP
33 33
                 $t = gmstrftime("%Y%m%dT%H:%M:%S", $timet);
34 34
             } else {
35
-                $t = strftime("%Y%m%dT%H:%M:%S", $timet - date('Z'));
35
+                $t = strftime("%Y%m%dT%H:%M:%S", $timet-date('Z'));
36 36
             }
37 37
         }
38 38
 
Please login to merge, or discard this patch.
lib/xmlrpc_wrappers.inc 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -141,9 +141,9 @@
 block discarded – undo
141 141
  * @deprecated
142 142
  */
143 143
 function build_remote_method_wrapper_code($client, $methodName, $xmlrpcFuncName,
144
-     $mSig, $mDesc = '', $timeout = 0, $protocol = '', $clientCopyMode = 0, $prefix = 'xmlrpc',
145
-     $decodePhpObjects = false, $encodePhpObjects = false, $decodeFault = false,
146
-     $faultResponse = '', $namespace = '\\PhpXmlRpc\\')
144
+        $mSig, $mDesc = '', $timeout = 0, $protocol = '', $clientCopyMode = 0, $prefix = 'xmlrpc',
145
+        $decodePhpObjects = false, $encodePhpObjects = false, $decodeFault = false,
146
+        $faultResponse = '', $namespace = '\\PhpXmlRpc\\')
147 147
 {
148 148
     $code = "function $xmlrpcFuncName (";
149 149
     if ($clientCopyMode < 2) {
Please login to merge, or discard this patch.
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
  * @param array $extraOptions
42 42
  * @return array|false
43 43
  */
44
-function wrap_php_function($funcName, $newFuncName='', $extraOptions=array())
44
+function wrap_php_function($funcName, $newFuncName = '', $extraOptions = array())
45 45
 {
46 46
     $wrapper = new PhpXmlRpc\Wrapper();
47
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
47
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
48 48
         // backwards compat: return string instead of callable
49 49
         $extraOptions['return_source'] = true;
50 50
         $wrapped = $wrapper->wrapPhpFunction($funcName, $newFuncName, $extraOptions);
@@ -64,17 +64,17 @@  discard block
 block discarded – undo
64 64
  * @param array $extraOptions
65 65
  * @return array|false
66 66
  */
67
-function wrap_php_class($className, $extraOptions=array())
67
+function wrap_php_class($className, $extraOptions = array())
68 68
 {
69 69
     $wrapper = new PhpXmlRpc\Wrapper();
70 70
     $fix = false;
71
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
71
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
72 72
         // backwards compat: return string instead of callable
73 73
         $extraOptions['return_source'] = true;
74 74
         $fix = true;
75 75
     }
76 76
     $wrapped = $wrapper->wrapPhpClass($className, $extraOptions);
77
-    foreach($wrapped as $name => $value) {
77
+    foreach ($wrapped as $name => $value) {
78 78
         if ($fix) {
79 79
             eval($value['source']);
80 80
         }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
  * @param string $newFuncName     deprecated, use an option in $extraOptions
94 94
  * @return array|callable|false
95 95
  */
96
-function wrap_xmlrpc_method($client, $methodName, $extraOptions=0, $timeout=0, $protocol='', $newFuncName='')
96
+function wrap_xmlrpc_method($client, $methodName, $extraOptions = 0, $timeout = 0, $protocol = '', $newFuncName = '')
97 97
 {
98 98
     if (!is_array($extraOptions))
99 99
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 
109 109
     $wrapper = new PhpXmlRpc\Wrapper();
110 110
 
111
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
111
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
112 112
         // backwards compat: return string instead of callable
113 113
         $extraOptions['return_source'] = true;
114 114
         $wrapped = $wrapper->wrapXmlrpcMethod($client, $methodName, $extraOptions);
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
  * @param array $extraOptions
127 127
  * @return mixed
128 128
  */
129
-function wrap_xmlrpc_server($client, $extraOptions=array())
129
+function wrap_xmlrpc_server($client, $extraOptions = array())
130 130
 {
131 131
     $wrapper = new PhpXmlRpc\Wrapper();
132 132
     return $wrapper->wrapXmlrpcServer($client, $extraOptions);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      $faultResponse = '', $namespace = '\\PhpXmlRpc\\')
147 147
 {
148 148
     $code = "function $xmlrpcFuncName (";
149
-    if ($clientCopyMode < 2) {
149
+    if ($clientCopyMode<2) {
150 150
         // client copy mode 0 or 1 == partial / full client copy in emitted code
151 151
         $innerCode = build_client_wrapper_code($client, $clientCopyMode, $prefix, $namespace);
152 152
         $innerCode .= "\$client->setDebug(\$debug);\n";
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 
161 161
     if ($mDesc != '') {
162 162
         // take care that PHP comment is not terminated unwillingly by method description
163
-        $mDesc = "/**\n* " . str_replace('*/', '* /', $mDesc) . "\n";
163
+        $mDesc = "/**\n* ".str_replace('*/', '* /', $mDesc)."\n";
164 164
     } else {
165 165
         $mDesc = "/**\nFunction $xmlrpcFuncName\n";
166 166
     }
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
170 170
     $plist = array();
171 171
     $pCount = count($mSig);
172
-    for ($i = 1; $i < $pCount; $i++) {
172
+    for ($i = 1; $i<$pCount; $i++) {
173 173
         $plist[] = "\$p$i";
174 174
         $pType = $mSig[$i];
175 175
         if ($pType == 'i4' || $pType == 'i8' || $pType == 'int' || $pType == 'boolean' || $pType == 'double' ||
@@ -185,19 +185,19 @@  discard block
 block discarded – undo
185 185
             }
186 186
         }
187 187
         $innerCode .= "\$req->addparam(\$p$i);\n";
188
-        $mDesc .= '* @param ' . xmlrpc_2_php_type($pType) . " \$p$i\n";
188
+        $mDesc .= '* @param '.xmlrpc_2_php_type($pType)." \$p$i\n";
189 189
     }
190
-    if ($clientCopyMode < 2) {
190
+    if ($clientCopyMode<2) {
191 191
         $plist[] = '$debug=0';
192 192
         $mDesc .= "* @param int \$debug when 1 (or 2) will enable debugging of the underlying {$prefix} call (defaults to 0)\n";
193 193
     }
194 194
     $plist = implode(', ', $plist);
195
-    $mDesc .= '* @return ' . xmlrpc_2_php_type($mSig[0]) . " (or an {$namespace}Response obj instance if call fails)\n*/\n";
195
+    $mDesc .= '* @return '.xmlrpc_2_php_type($mSig[0])." (or an {$namespace}Response obj instance if call fails)\n*/\n";
196 196
 
197 197
     $innerCode .= "\$res = \${$this_}client->send(\$req, $timeout, '$protocol');\n";
198 198
     if ($decodeFault) {
199 199
         if (is_string($faultResponse) && ((strpos($faultResponse, '%faultCode%') !== false) || (strpos($faultResponse, '%faultString%') !== false))) {
200
-            $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '" . str_replace("'", "''", $faultResponse) . "')";
200
+            $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '".str_replace("'", "''", $faultResponse)."')";
201 201
         } else {
202 202
             $respCode = var_export($faultResponse, true);
203 203
         }
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         $innerCode .= "if (\$res->faultcode()) return $respCode; else return \$encoder->decode(\$res->value());";
211 211
     }
212 212
 
213
-    $code = $code . $plist . ") {\n" . $innerCode . "\n}\n";
213
+    $code = $code.$plist.") {\n".$innerCode."\n}\n";
214 214
 
215 215
     return array('source' => $code, 'docstring' => $mDesc);
216 216
 }
@@ -218,18 +218,18 @@  discard block
 block discarded – undo
218 218
 /**
219 219
  * @deprecated
220 220
  */
221
-function build_client_wrapper_code($client, $verbatim_client_copy, $prefix='xmlrpc')
221
+function build_client_wrapper_code($client, $verbatim_client_copy, $prefix = 'xmlrpc')
222 222
 {
223 223
     $code = "\$client = new {$prefix}_client('".str_replace("'", "\'", $client->path).
224
-        "', '" . str_replace("'", "\'", $client->server) . "', $client->port);\n";
224
+        "', '".str_replace("'", "\'", $client->server)."', $client->port);\n";
225 225
 
226 226
     // copy all client fields to the client that will be generated runtime
227 227
     // (this provides for future expansion or subclassing of client obj)
228 228
     if ($verbatim_client_copy)
229 229
     {
230
-        foreach($client as $fld => $val)
230
+        foreach ($client as $fld => $val)
231 231
         {
232
-            if($fld != 'debug' && $fld != 'return_type')
232
+            if ($fld != 'debug' && $fld != 'return_type')
233 233
             {
234 234
                 $val = var_export($val, true);
235 235
                 $code .= "\$client->$fld = $val;\n";
Please login to merge, or discard this patch.
demo/vardemo.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -3,16 +3,16 @@  discard block
 block discarded – undo
3 3
 <body>
4 4
 <?php
5 5
 
6
-include_once __DIR__ . "/../vendor/autoload.php";
6
+include_once __DIR__."/../vendor/autoload.php";
7 7
 
8 8
 $req = new PhpXmlRpc\Request('examples.getStateName');
9 9
 
10 10
 print "<h3>Testing value serialization</h3>\n";
11 11
 
12 12
 $v = new PhpXmlRpc\Value(23, "int");
13
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
13
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
14 14
 $v = new PhpXmlRpc\Value("What are you saying? >> << &&");
15
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
15
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
16 16
 
17 17
 $v = new PhpXmlRpc\Value(
18 18
     array(
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
     "array"
24 24
 );
25 25
 
26
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
26
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
27 27
 
28 28
 $v = new PhpXmlRpc\Value(
29 29
     array(
@@ -51,11 +51,11 @@  discard block
 block discarded – undo
51 51
     "struct"
52 52
 );
53 53
 
54
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
54
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
55 55
 
56 56
 $w = new PhpXmlRpc\Value(array($v, new PhpXmlRpc\Value("That was the struct!")), "array");
57 57
 
58
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
58
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
59 59
 
60 60
 $w = new PhpXmlRpc\Value("Mary had a little lamb,
61 61
 Whose fleece was white as snow,
@@ -67,26 +67,26 @@  discard block
 block discarded – undo
67 67
 Ten thousand volts went down its back
68 68
 And turned it into nylon", "base64"
69 69
 );
70
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
71
-print "<PRE>Value of base64 string is: '" . $w->scalarval() . "'</PRE>";
70
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
71
+print "<PRE>Value of base64 string is: '".$w->scalarval()."'</PRE>";
72 72
 
73 73
 $req->method('');
74 74
 $req->addParam(new PhpXmlRpc\Value("41", "int"));
75 75
 
76 76
 print "<h3>Testing request serialization</h3>\n";
77 77
 $op = $req->serialize();
78
-print "<PRE>" . htmlentities($op) . "</PRE>";
78
+print "<PRE>".htmlentities($op)."</PRE>";
79 79
 
80 80
 print "<h3>Testing ISO date format</h3><pre>\n";
81 81
 
82 82
 $t = time();
83 83
 $date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
84 84
 print "Now is $t --> $date\n";
85
-print "Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n";
85
+print "Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n";
86 86
 $tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
87 87
 print "That is to say $date --> $tb\n";
88
-print "Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n";
89
-print "Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($date, 1) . "\n";
88
+print "Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n";
89
+print "Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($date, 1)."\n";
90 90
 
91 91
 print "</pre>\n";
92 92
 
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         $val = reset($ar);
96 96
         $typ = key($ar);
97 97
 
98
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
98
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
99 99
         //}
100 100
     }
101 101
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
         // preserve back compatibility
115 115
 
116 116
         if (is_array($b)) {
117
-            foreach($b as $id => $cont) {
117
+            foreach ($b as $id => $cont) {
118 118
                 $b[$id] = $cont->scalarval();
119 119
             }
120 120
         }
@@ -122,10 +122,10 @@  discard block
 block discarded – undo
122 122
         // add support for structures directly encoding php objects
123 123
         if (is_object($b)) {
124 124
             $t = get_object_vars($b);
125
-            foreach($t as $id => $cont) {
125
+            foreach ($t as $id => $cont) {
126 126
                 $t[$id] = $cont->scalarval();
127 127
             }
128
-            foreach($t as $id => $cont) {
128
+            foreach ($t as $id => $cont) {
129 129
                 @$b->$id = $cont;
130 130
             }
131 131
         }
@@ -160,17 +160,17 @@  discard block
 block discarded – undo
160 160
 /* Expose as global functions the ones which are now class methods */
161 161
 
162 162
 /// Wrong speling, but we are adamant on backwards compatibility!
163
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
163
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
164 164
 {
165 165
     return PhpXmlRpc\Helper\Charset::instance()->encodeEntitites($data, $srcEncoding, $destEncoding);
166 166
 }
167 167
 
168
-function iso8601_encode($timeT, $utc=0)
168
+function iso8601_encode($timeT, $utc = 0)
169 169
 {
170 170
     return PhpXmlRpc\Helper\Date::iso8601Encode($timeT, $utc);
171 171
 }
172 172
 
173
-function iso8601_decode($iDate, $utc=0)
173
+function iso8601_decode($iDate, $utc = 0)
174 174
 {
175 175
     return PhpXmlRpc\Helper\Date::iso8601Decode($iDate, $utc);
176 176
 }
@@ -180,25 +180,25 @@  discard block
 block discarded – undo
180 180
     return PhpXmlRpc\Helper\Http::decodeChunked($buffer);
181 181
 }
182 182
 
183
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
183
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
184 184
 {
185 185
     $encoder = new PhpXmlRpc\Encoder();
186 186
     return $encoder->decode($xmlrpcVal, $options);
187 187
 }
188 188
 
189
-function php_xmlrpc_encode($phpVal, $options=array())
189
+function php_xmlrpc_encode($phpVal, $options = array())
190 190
 {
191 191
     $encoder = new PhpXmlRpc\Encoder();
192 192
     return $encoder->encode($phpVal, $options);
193 193
 }
194 194
 
195
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
195
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
196 196
 {
197 197
     $encoder = new PhpXmlRpc\Encoder();
198 198
     return $encoder->decodeXml($xmlVal, $options);
199 199
 }
200 200
 
201
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
201
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
202 202
 {
203 203
     return PhpXmlRpc\Helper\XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
204 204
 }
Please login to merge, or discard this patch.
tests/4LocalhostMultiTest.php 2 patches
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -182,8 +182,7 @@  discard block
 block discarded – undo
182 182
         {
183 183
             $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
184 184
             return;
185
-        }
186
-        else if ($this->args['PROXYSERVER'] == '')
185
+        } else if ($this->args['PROXYSERVER'] == '')
187 186
         {
188 187
             $this->markTestSkipped('PROXY definition missing: cannot test proxy w. http 1.1');
189 188
             return;
@@ -207,8 +206,7 @@  discard block
 block discarded – undo
207 206
         {
208 207
             $this->markTestSkipped('CURL missing: cannot test https functionality');
209 208
             return;
210
-        }
211
-        else if ($this->args['HTTPSSERVER'] == '')
209
+        } else if ($this->args['HTTPSSERVER'] == '')
212 210
         {
213 211
             $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https');
214 212
             return;
@@ -235,13 +233,11 @@  discard block
 block discarded – undo
235 233
         {
236 234
             $this->markTestSkipped('CURL missing: cannot test https w. proxy');
237 235
             return;
238
-        }
239
-        else if ($this->args['PROXYSERVER'] == '')
236
+        } else if ($this->args['PROXYSERVER'] == '')
240 237
         {
241 238
             $this->markTestSkipped('PROXY definition missing: cannot test proxy w. https');
242 239
             return;
243
-        }
244
-        else if ($this->args['HTTPSSERVER'] == '')
240
+        } else if ($this->args['HTTPSSERVER'] == '')
245 241
         {
246 242
             $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https w. proxy');
247 243
             return;
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/3LocalhostTest.php';
8
+include_once __DIR__.'/3LocalhostTest.php';
9 9
 
10 10
 /**
11 11
  * Tests which stress http features of the library.
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
27 27
         );
28 28
 
29 29
         $methods = array();
30
-        foreach(get_class_methods('LocalhostTest') as $method)
30
+        foreach (get_class_methods('LocalhostTest') as $method)
31 31
         {
32
-            if(strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
32
+            if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
33 33
             {
34 34
                 if (!isset(self::$failed_tests[$method])) {
35 35
                     $methods[$method] = array($method);
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public function testDeflate($method)
48 48
     {
49
-        if(!function_exists('gzdeflate'))
49
+        if (!function_exists('gzdeflate'))
50 50
         {
51 51
             $this->markTestSkipped('Zlib missing: cannot test deflate functionality');
52 52
             return;
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      */
65 65
     public function testGzip($method)
66 66
     {
67
-        if(!function_exists('gzdeflate'))
67
+        if (!function_exists('gzdeflate'))
68 68
         {
69 69
             $this->markTestSkipped('Zlib missing: cannot test gzip functionality');
70 70
             return;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
     public function testKeepAlives()
80 80
     {
81
-        if(!function_exists('curl_init'))
81
+        if (!function_exists('curl_init'))
82 82
         {
83 83
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
84 84
             return;
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     public function testHttp11($method)
120 120
     {
121
-        if(!function_exists('curl_init'))
121
+        if (!function_exists('curl_init'))
122 122
         {
123 123
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
124 124
             return;
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     public function testHttp10Curl($method)
139 139
     {
140
-        if(!function_exists('curl_init'))
140
+        if (!function_exists('curl_init'))
141 141
         {
142 142
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
143 143
             return;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     public function testHttp11Gzip($method)
159 159
     {
160
-        if(!function_exists('curl_init'))
160
+        if (!function_exists('curl_init'))
161 161
         {
162 162
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
163 163
             return;
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      */
178 178
     public function testHttp11Deflate($method)
179 179
     {
180
-        if(!function_exists('curl_init'))
180
+        if (!function_exists('curl_init'))
181 181
         {
182 182
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
183 183
             return;
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      */
198 198
     public function testHttp11Proxy($method)
199 199
     {
200
-        if(!function_exists('curl_init'))
200
+        if (!function_exists('curl_init'))
201 201
         {
202 202
             $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
203 203
             return;
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
      */
223 223
     public function testHttps($method)
224 224
     {
225
-        if(!function_exists('curl_init'))
225
+        if (!function_exists('curl_init'))
226 226
         {
227 227
             $this->markTestSkipped('CURL missing: cannot test https functionality');
228 228
             return;
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
      */
275 275
     public function testHttpsProxy($method)
276 276
     {
277
-        if(!function_exists('curl_init'))
277
+        if (!function_exists('curl_init'))
278 278
         {
279 279
             $this->markTestSkipped('CURL missing: cannot test https w. proxy');
280 280
             return;
Please login to merge, or discard this patch.
lib/xmlrpcs.inc 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
      */
53 53
     public function echoInput()
54 54
     {
55
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
55
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
56 56
         print $r->serialize();
57 57
     }
58 58
 }
@@ -68,30 +68,30 @@  discard block
 block discarded – undo
68 68
     PhpXmlRpc\Server::xmlrpc_debugmsg($m);
69 69
 }
70 70
 
71
-function _xmlrpcs_getCapabilities($server, $m=null)
71
+function _xmlrpcs_getCapabilities($server, $m = null)
72 72
 {
73 73
     return PhpXmlRpc\Server::_xmlrpcs_getCapabilities($server, $m);
74 74
 }
75 75
 
76
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
77
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
78
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
79
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
76
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
77
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
78
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
79
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
80 80
 {
81 81
     return PhpXmlRpc\Server::_xmlrpcs_listMethods($server, $m);
82 82
 }
83 83
 
84
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
85
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
86
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
84
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
85
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
86
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
87 87
 function _xmlrpcs_methodSignature($server, $m)
88 88
 {
89 89
     return PhpXmlRpc\Server::_xmlrpcs_methodSignature($server, $m);
90 90
 }
91 91
 
92
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
93
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
94
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
92
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
93
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
94
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
95 95
 function _xmlrpcs_methodHelp($server, $m)
96 96
 {
97 97
     return PhpXmlRpc\Server::_xmlrpcs_methodHelp($server, $m);
Please login to merge, or discard this patch.
demo/client/mail.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     method)</p>
21 21
 <?php
22 22
 
23
-include_once __DIR__ . "/../../src/Autoloader.php";
23
+include_once __DIR__."/../../src/Autoloader.php";
24 24
 PhpXmlRpc\Autoloader::register();
25 25
 
26 26
 if (isset($_POST["mailto"]) && $_POST["mailto"]) {
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
         print "<font color=\"red\">";
45 45
         print "Mail send failed<br/>\n";
46 46
         print "Fault: ";
47
-        print "Code: " . htmlspecialchars($resp->faultCode()) .
48
-            " Reason: '" . htmlspecialchars($resp->faultString()) . "'<br/>";
47
+        print "Code: ".htmlspecialchars($resp->faultCode()).
48
+            " Reason: '".htmlspecialchars($resp->faultString())."'<br/>";
49 49
         print "</font><br/>";
50 50
     }
51 51
 }
Please login to merge, or discard this patch.
demo/client/introspect.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -6,20 +6,20 @@  discard block
 block discarded – undo
6 6
 <h3>The code demonstrates usage of multicall and introspection methods</h3>
7 7
 <?php
8 8
 
9
-include_once __DIR__ . "/../../src/Autoloader.php";
9
+include_once __DIR__."/../../src/Autoloader.php";
10 10
 PhpXmlRpc\Autoloader::register();
11 11
 
12 12
 function display_error($r)
13 13
 {
14 14
     print "An error occurred: ";
15
-    print "Code: " . $r->faultCode()
16
-        . " Reason: '" . $r->faultString() . "'<br/>";
15
+    print "Code: ".$r->faultCode()
16
+        . " Reason: '".$r->faultString()."'<br/>";
17 17
 }
18 18
 
19 19
 $client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
20 20
 
21 21
 // First off, let's retrieve the list of methods available on the remote server
22
-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
22
+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
23 23
 $req = new PhpXmlRpc\Request('system.listMethods');
24 24
 $resp = $client->send($req);
25 25
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
     // Then, retrieve the signature and help text of each available method
32 32
     foreach ($v as $methodName) {
33
-        print "<h4>" . $methodName->scalarval() . "</h4>\n";
33
+        print "<h4>".$methodName->scalarval()."</h4>\n";
34 34
         // build messages first, add params later
35 35
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
36 36
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
             if ($val->kindOf() == "array") {
62 62
                 foreach ($val as $x) {
63 63
                     $ret = $x[0];
64
-                    print "<code>" . htmlspecialchars($ret->scalarval()) . " "
65
-                        . htmlspecialchars($methodName->scalarval()) . "(";
66
-                    if ($x->count() > 1) {
67
-                        for ($k = 1; $k < $x->count(); $k++) {
64
+                    print "<code>".htmlspecialchars($ret->scalarval())." "
65
+                        . htmlspecialchars($methodName->scalarval())."(";
66
+                    if ($x->count()>1) {
67
+                        for ($k = 1; $k<$x->count(); $k++) {
68 68
                             $y = $x[$k];
69 69
                             print htmlspecialchars($y->scalarval());
70
-                            if ($k < $x->count() - 1) {
70
+                            if ($k<$x->count()-1) {
71 71
                                 print ", ";
72 72
                             }
73 73
                         }
Please login to merge, or discard this patch.
tests/benchmark.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -17,9 +17,9 @@  discard block
 block discarded – undo
17 17
 use PhpXmlRpc\Response;
18 18
 use PhpXmlRpc\Encoder;
19 19
 
20
-include_once __DIR__ . '/../vendor/autoload.php';
20
+include_once __DIR__.'/../vendor/autoload.php';
21 21
 
22
-include __DIR__ . '/parse_args.php';
22
+include __DIR__.'/parse_args.php';
23 23
 $args = argParser::getArgs();
24 24
 
25 25
 function begin_test($test_name, $test_case)
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     if (!isset($test_results[$test_name][$test_case])) {
40 40
         trigger_error('ending test that was not started');
41 41
     }
42
-    $test_results[$test_name][$test_case]['time'] = $end - $test_results[$test_name][$test_case]['time'];
42
+    $test_results[$test_name][$test_case]['time'] = $end-$test_results[$test_name][$test_case]['time'];
43 43
     $test_results[$test_name][$test_case]['result'] = $test_result;
44 44
     echo '.';
45 45
     flush();
@@ -73,24 +73,24 @@  discard block
 block discarded – undo
73 73
 }
74 74
 
75 75
 if ($is_web) {
76
-    echo "<h3>Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "</h3>\n";
76
+    echo "<h3>Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."</h3>\n";
77 77
     if ($xd) {
78
-        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: " . htmlspecialchars(xdebug_get_profiler_filename()) . "</h4>\n";
78
+        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: ".htmlspecialchars(xdebug_get_profiler_filename())."</h4>\n";
79 79
     }
80 80
     flush();
81 81
     ob_flush();
82 82
 } else {
83
-    echo "Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "\n";
83
+    echo "Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."\n";
84 84
     if ($xd) {
85
-        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: " . xdebug_get_profiler_filename() . "\n";
85
+        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: ".xdebug_get_profiler_filename()."\n";
86 86
     }
87 87
 }
88 88
 
89 89
 // test 'manual style' data encoding vs. 'automatic style' encoding
90 90
 begin_test('Data encoding (large array)', 'manual encoding');
91
-for ($i = 0; $i < $num_tests; $i++) {
91
+for ($i = 0; $i<$num_tests; $i++) {
92 92
     $vals = array();
93
-    for ($j = 0; $j < 10; $j++) {
93
+    for ($j = 0; $j<10; $j++) {
94 94
         $valarray = array();
95 95
         foreach ($data[$j] as $key => $val) {
96 96
             $values = array();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
 begin_test('Data encoding (large array)', 'automatic encoding');
117 117
 $encoder = new Encoder();
118
-for ($i = 0; $i < $num_tests; $i++) {
118
+for ($i = 0; $i<$num_tests; $i++) {
119 119
     $value = $encoder->encode($data, array('auto_dates'));
120 120
     $out = $value->serialize();
121 121
 }
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
123 123
 
124 124
 if (function_exists('xmlrpc_set_type')) {
125 125
     begin_test('Data encoding (large array)', 'xmlrpc-epi encoding');
126
-    for ($i = 0; $i < $num_tests; $i++) {
127
-        for ($j = 0; $j < 10; $j++) {
126
+    for ($i = 0; $i<$num_tests; $i++) {
127
+        for ($j = 0; $j<10; $j++) {
128 128
             foreach ($keys as $k) {
129 129
                 xmlrpc_set_type($data[$j][$k][4], 'datetime');
130 130
                 xmlrpc_set_type($data[$j][$k][8], 'datetime');
@@ -138,18 +138,18 @@  discard block
 block discarded – undo
138 138
 // test 'old style' data decoding vs. 'automatic style' decoding
139 139
 $dummy = new Request('');
140 140
 $out = new Response($value);
141
-$in = '<?xml version="1.0" ?>' . "\n" . $out->serialize();
141
+$in = '<?xml version="1.0" ?>'."\n".$out->serialize();
142 142
 
143 143
 begin_test('Data decoding (large array)', 'manual decoding');
144
-for ($i = 0; $i < $num_tests; $i++) {
144
+for ($i = 0; $i<$num_tests; $i++) {
145 145
     $response = $dummy->ParseResponse($in, true);
146 146
     $value = $response->value();
147 147
     $result = array();
148
-    foreach($value as $val1) {
148
+    foreach ($value as $val1) {
149 149
         $out = array();
150
-        foreach($val1 as $name => $val) {
150
+        foreach ($val1 as $name => $val) {
151 151
             $out[$name] = array();
152
-            foreach($val as $data) {
152
+            foreach ($val as $data) {
153 153
                 $out[$name][] = $data->scalarval();
154 154
             }
155 155
         }
@@ -159,18 +159,18 @@  discard block
 block discarded – undo
159 159
 end_test('Data decoding (large array)', 'manual decoding', $result);
160 160
 
161 161
 begin_test('Data decoding (large array)', 'manual decoding deprecated');
162
-for ($i = 0; $i < $num_tests; $i++) {
162
+for ($i = 0; $i<$num_tests; $i++) {
163 163
     $response = $dummy->ParseResponse($in, true);
164 164
     $value = $response->value();
165 165
     $result = array();
166 166
     $l = $value->arraysize();
167
-    for ($k = 0; $k < $l; $k++) {
167
+    for ($k = 0; $k<$l; $k++) {
168 168
         $val1 = $value->arraymem($k);
169 169
         $out = array();
170
-        foreach($val1 as $name => $val) {
170
+        foreach ($val1 as $name => $val) {
171 171
             $out[$name] = array();
172 172
             $m = $val->arraysize();
173
-            for ($j = 0; $j < $m; $j++) {
173
+            for ($j = 0; $j<$m; $j++) {
174 174
                 $data = $val->arraymem($j);
175 175
                 $out[$name][] = $data->scalarval();
176 176
             }
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 end_test('Data decoding (large array)', 'manual decoding deprecated', $result);
182 182
 
183 183
 begin_test('Data decoding (large array)', 'automatic decoding');
184
-for ($i = 0; $i < $num_tests; $i++) {
184
+for ($i = 0; $i<$num_tests; $i++) {
185 185
     $response = $dummy->ParseResponse($in, true, 'phpvals');
186 186
     $value = $response->value();
187 187
 }
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 
190 190
 if (function_exists('xmlrpc_decode')) {
191 191
     begin_test('Data decoding (large array)', 'xmlrpc-epi decoding');
192
-    for ($i = 0; $i < $num_tests; $i++) {
192
+    for ($i = 0; $i<$num_tests; $i++) {
193 193
         $response = $dummy->ParseResponse($in, true, 'xml');
194 194
         $value = xmlrpc_decode($response->value());
195 195
     }
@@ -203,15 +203,15 @@  discard block
 block discarded – undo
203 203
     $value = $encoder->encode($data1, array('auto_dates'));
204 204
     $req = new Request('interopEchoTests.echoValue', array($value));
205 205
     $reqs = array();
206
-    for ($i = 0; $i < 25; $i++) {
206
+    for ($i = 0; $i<25; $i++) {
207 207
         $reqs[] = $req;
208 208
     }
209 209
     $server = explode(':', $args['LOCALSERVER']);
210
-    if (count($server) > 1) {
211
-        $srv = $server[1] . '://' . $server[0] . $args['URI'];
210
+    if (count($server)>1) {
211
+        $srv = $server[1].'://'.$server[0].$args['URI'];
212 212
         $c = new Client($args['URI'], $server[0], $server[1]);
213 213
     } else {
214
-        $srv = $args['LOCALSERVER'] . $args['URI'];
214
+        $srv = $args['LOCALSERVER'].$args['URI'];
215 215
         $c = new Client($args['URI'], $args['LOCALSERVER']);
216 216
     }
217 217
     // do not interfere with http compression
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
     }
226 226
     begin_test($testName, 'http 10');
227 227
     $response = array();
228
-    for ($i = 0; $i < 25; $i++) {
228
+    for ($i = 0; $i<25; $i++) {
229 229
         $resp = $c->send($req);
230 230
         $response[] = $resp->value();
231 231
     }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
     if (function_exists('curl_init')) {
235 235
         begin_test($testName, 'http 11 w. keep-alive');
236 236
         $response = array();
237
-        for ($i = 0; $i < 25; $i++) {
237
+        for ($i = 0; $i<25; $i++) {
238 238
             $resp = $c->send($req, 10, 'http11');
239 239
             $response[] = $resp->value();
240 240
         }
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
         $c->keepalive = false;
244 244
         begin_test($testName, 'http 11');
245 245
         $response = array();
246
-        for ($i = 0; $i < 25; $i++) {
246
+        for ($i = 0; $i<25; $i++) {
247 247
             $resp = $c->send($req, 10, 'http11');
248 248
             $response[] = $resp->value();
249 249
         }
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 
264 264
         begin_test($testName, 'http 10 w. compression');
265 265
         $response = array();
266
-        for ($i = 0; $i < 25; $i++) {
266
+        for ($i = 0; $i<25; $i++) {
267 267
             $resp = $c->send($req);
268 268
             $response[] = $resp->value();
269 269
         }
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         if (function_exists('curl_init')) {
273 273
             begin_test($testName, 'http 11 w. keep-alive and compression');
274 274
             $response = array();
275
-            for ($i = 0; $i < 25; $i++) {
275
+            for ($i = 0; $i<25; $i++) {
276 276
                 $resp = $c->send($req, 10, 'http11');
277 277
                 $response[] = $resp->value();
278 278
             }
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
             $c->keepalive = false;
282 282
             begin_test($testName, 'http 11 w. compression');
283 283
             $response = array();
284
-            for ($i = 0; $i < 25; $i++) {
284
+            for ($i = 0; $i<25; $i++) {
285 285
                 $resp = $c->send($req, 10, 'http11');
286 286
                 $response[] = $resp->value();
287 287
             }
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 foreach ($test_results as $test => $results) {
303 303
     echo "\nTEST: $test\n";
304 304
     foreach ($results as $case => $data) {
305
-        echo "  $case: {$data['time']} secs - Output data CRC: " . crc32(serialize($data['result'])) . "\n";
305
+        echo "  $case: {$data['time']} secs - Output data CRC: ".crc32(serialize($data['result']))."\n";
306 306
     }
307 307
 }
308 308
 
Please login to merge, or discard this patch.