Inspection of "tests on php8" - gggeek/phpxmlrpc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 43c003...f5456e )

by Gaetano

created 2020-12-06 14:56 UTC

Status

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -3,16 +3,16 @@  discard block
 block discarded – undo
 <body>
 <?php
 
-include_once __DIR__ . "/../vendor/autoload.php";
+include_once __DIR__."/../vendor/autoload.php";
 
 $req = new PhpXmlRpc\Request('examples.getStateName');
 
 print "<h3>Testing value serialization</h3>\n";
 
 $v = new PhpXmlRpc\Value(23, "int");
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 $v = new PhpXmlRpc\Value("What are you saying? >> << &&");
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $v = new PhpXmlRpc\Value(
     array(
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
     "array"
 );
 
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $v = new PhpXmlRpc\Value(
     array(
@@ -51,11 +51,11 @@  discard block
 block discarded – undo
     "struct"
 );
 
-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($v->serialize())."</PRE>";
 
 $w = new PhpXmlRpc\Value(array($v, new PhpXmlRpc\Value("That was the struct!")), "array");
 
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
 
 $w = new PhpXmlRpc\Value("Mary had a little lamb,
 Whose fleece was white as snow,
@@ -67,26 +67,26 @@  discard block
 block discarded – undo
 Ten thousand volts went down its back
 And turned it into nylon", "base64"
 );
-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
-print "<PRE>Value of base64 string is: '" . $w->scalarval() . "'</PRE>";
+print "<PRE>".htmlentities($w->serialize())."</PRE>";
+print "<PRE>Value of base64 string is: '".$w->scalarval()."'</PRE>";
 
 $req->method('');
 $req->addParam(new PhpXmlRpc\Value("41", "int"));
 
 print "<h3>Testing request serialization</h3>\n";
 $op = $req->serialize();
-print "<PRE>" . htmlentities($op) . "</PRE>";
+print "<PRE>".htmlentities($op)."</PRE>";
 
 print "<h3>Testing ISO date format</h3><pre>\n";
 
 $t = time();
 $date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
 print "Now is $t --> $date\n";
-print "Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n";
+print "Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n";
 $tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
 print "That is to say $date --> $tb\n";
-print "Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n";
-print "Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($date, 1) . "\n";
+print "Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n";
+print "Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($date, 1)."\n";
 
 print "</pre>\n";
 

Please login to merge, or discard this patch.

lib/xmlrpc.inc 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -95,7 +95,7 @@  discard block
 block discarded – undo
         $val = reset($ar);
         $typ = key($ar);
 
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
         //}
     }
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
         // preserve back compatibility
 
         if (is_array($b)) {
-            foreach($b as $id => $cont) {
+            foreach ($b as $id => $cont) {
                 $b[$id] = $cont->scalarval();
             }
         }
@@ -122,10 +122,10 @@  discard block
 block discarded – undo
         // add support for structures directly encoding php objects
         if (is_object($b)) {
             $t = get_object_vars($b);
-            foreach($t as $id => $cont) {
+            foreach ($t as $id => $cont) {
                 $t[$id] = $cont->scalarval();
             }
-            foreach($t as $id => $cont) {
+            foreach ($t as $id => $cont) {
                 @$b->$id = $cont;
             }
         }
@@ -160,17 +160,17 @@  discard block
 block discarded – undo
 /* Expose as global functions the ones which are now class methods */
 
 /// Wrong speling, but we are adamant on backwards compatibility!
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
 {
     return PhpXmlRpc\Helper\Charset::instance()->encodeEntitites($data, $srcEncoding, $destEncoding);
 }
 
-function iso8601_encode($timeT, $utc=0)
+function iso8601_encode($timeT, $utc = 0)
 {
     return PhpXmlRpc\Helper\Date::iso8601Encode($timeT, $utc);
 }
 
-function iso8601_decode($iDate, $utc=0)
+function iso8601_decode($iDate, $utc = 0)
 {
     return PhpXmlRpc\Helper\Date::iso8601Decode($iDate, $utc);
 }
@@ -180,25 +180,25 @@  discard block
 block discarded – undo
     return PhpXmlRpc\Helper\Http::decodeChunked($buffer);
 }
 
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
 {
     $encoder = new PhpXmlRpc\Encoder();
     return $encoder->decode($xmlrpcVal, $options);
 }
 
-function php_xmlrpc_encode($phpVal, $options=array())
+function php_xmlrpc_encode($phpVal, $options = array())
 {
     $encoder = new PhpXmlRpc\Encoder();
     return $encoder->encode($phpVal, $options);
 }
 
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
 {
     $encoder = new PhpXmlRpc\Encoder();
     return $encoder->decodeXml($xmlVal, $options);
 }
 
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
 {
     return PhpXmlRpc\Helper\XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
 }

Please login to merge, or discard this patch.

demo/server/server.php 1 patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@  discard block
 block discarded – undo
     die();
 }
 
-include_once __DIR__ . "/../../vendor/autoload.php";
+include_once __DIR__."/../../vendor/autoload.php";
 
 // out-of-band information: let the client manipulate the server operations.
 // we do this to help the testsuite script: do not reproduce in production!
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
         mkdir($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY']);
     }
 
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
 }
 
 use PhpXmlRpc\Value;
@@ -122,11 +122,11 @@  discard block
 block discarded – undo
     // extract the value of the state number
     $snv = $sno->scalarval();
     // look it up in our array (zero-based)
-    if (isset($stateNames[$snv - 1])) {
-        $stateName = $stateNames[$snv - 1];
+    if (isset($stateNames[$snv-1])) {
+        $stateName = $stateNames[$snv-1];
     } else {
         // not there, so complain
-        $err = "I don't have a state for the index '" . $snv . "'";
+        $err = "I don't have a state for the index '".$snv."'";
     }
 
     // if we generated an error, create an error return response
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
 {
     global $stateNames;
 
-    if (isset($stateNames[$stateNo - 1])) {
-        return $stateNames[$stateNo - 1];
+    if (isset($stateNames[$stateNo-1])) {
+        return $stateNames[$stateNo-1];
     } else {
         // not, there so complain
-        throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
+        throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
     }
 }
 
@@ -186,17 +186,17 @@  discard block
 block discarded – undo
 eval($findstate9_sig['source']);
 
 $findstate10_sig = array(
-    "function" => function ($req) { return findState($req); },
+    "function" => function($req) { return findState($req); },
     "signature" => $findstate_sig,
     "docstring" => $findstate_doc,
 );
 
-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return inner_findstate($stateNo); });
+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return inner_findstate($stateNo); });
 
 $c = new xmlrpcServerMethodsContainer;
 $moreSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'tests.', 'method_type' => 'all'));
 
-$returnObj_sig =  $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
 
 // used to test signatures with NULL params
 $findstate12_sig = array(
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
     $s = $req->getParam(0);
     $t = $req->getParam(1);
 
-    return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
+    return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
 }
 
 $addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
     $s = $req->getParam(0);
     $t = $req->getParam(1);
 
-    return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
+    return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
 }
 
 $stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
 function echoBack($req)
 {
     // just sends back a string with what i got sent to me, just escaped, that's all
-    $s = "I got the following message:\n" . $req->serialize();
+    $s = "I got the following message:\n".$req->serialize();
 
     return new PhpXmlRpc\Response(new Value($s));
 }
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
         return 0;
     }
 
-    return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
+    return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
 }
 
 $agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
     // hack, must make global as uksort() won't
     // allow us to pass any other auxiliary information
     uksort($agesorter_arr, 'agesorter_compare');
-    foreach($agesorter_arr as $key => $val) {
+    foreach ($agesorter_arr as $key => $val) {
         // recreate each struct element
         $v[] = new Value(
             array(
@@ -406,17 +406,17 @@  discard block
 block discarded – undo
         $err = "Error, no 'From' field specified";
     }
 
-    $msgHdr = "From: " . $mFrom->scalarval() . "\n";
-    $msgHdr .= "To: " . $mTo->scalarval() . "\n";
+    $msgHdr = "From: ".$mFrom->scalarval()."\n";
+    $msgHdr .= "To: ".$mTo->scalarval()."\n";
 
     if ($mCc->scalarval() != "") {
-        $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
+        $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
     }
     if ($mBcc->scalarval() != "") {
-        $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
+        $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
     }
     if ($mMime->scalarval() != "") {
-        $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
+        $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
     }
     $msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
     $moe = $sno["moe"];
     $larry = $sno["larry"];
     $curly = $sno["curly"];
-    $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
+    $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
 
     return new PhpXmlRpc\Response(new Value($num, Value::$xmlrpcInt));
 }
@@ -548,9 +548,9 @@  discard block
 block discarded – undo
     $ar = $req->getParam(0);
     $sz = $ar->count();
     $first = $ar[0];
-    $last = $ar[$sz - 1];
+    $last = $ar[$sz-1];
 
-    return new PhpXmlRpc\Response(new Value($first->scalarval() .
+    return new PhpXmlRpc\Response(new Value($first->scalarval().
         $last->scalarval(), Value::$xmlrpcString));
 }
 
@@ -584,7 +584,7 @@  discard block
 block discarded – undo
     $larry = $fools["larry"];
     $moe = $fools["moe"];
 
-    return new PhpXmlRpc\Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
+    return new PhpXmlRpc\Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
 }
 
 $v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
     $ap = 0;
     $qu = 0;
     $amp = 0;
-    for ($i = 0; $i < strlen($str); $i++) {
+    for ($i = 0; $i<strlen($str); $i++) {
         $c = substr($str, $i, 1);
         switch ($c) {
             case ">":
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
     ),
     // Greek word 'kosme'. NB: NOT a valid ISO8859 string!
     // NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
-    "tests.utf8methodname." . 'κόσμε' => array(
+    "tests.utf8methodname.".'κόσμε' => array(
         "function" => "stringEcho",
         "signature" => $stringecho_sig,
         "docstring" => $stringecho_doc,
@@ -996,5 +996,5 @@  discard block
 block discarded – undo
 // Out-of-band information: let the client manipulate the server operations.
 // We do this to help the testsuite script: do not reproduce in production!
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
 }

Please login to merge, or discard this patch.

tests/4LocalhostMultiTest.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 
-include_once __DIR__ . '/../lib/xmlrpc.inc';
-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
+include_once __DIR__.'/../lib/xmlrpc.inc';
+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
 
-include_once __DIR__ . '/parse_args.php';
+include_once __DIR__.'/parse_args.php';
 
-include_once __DIR__ . '/3LocalhostTest.php';
+include_once __DIR__.'/3LocalhostTest.php';
 
 /**
  * Tests which stress http features of the library.
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
         );
 
         $methods = array();
-        foreach(get_class_methods('LocalhostTest') as $method)
+        foreach (get_class_methods('LocalhostTest') as $method)
         {
-            if(strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
+            if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
             {
                 if (!isset(self::$failed_tests[$method])) {
                     $methods[$method] = array($method);
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
      */
     public function testDeflate($method)
     {
-        if(!function_exists('gzdeflate'))
+        if (!function_exists('gzdeflate'))
         {
             $this->markTestSkipped('Zlib missing: cannot test deflate functionality');
             return;
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
      */
     public function testGzip($method)
     {
-        if(!function_exists('gzdeflate'))
+        if (!function_exists('gzdeflate'))
         {
             $this->markTestSkipped('Zlib missing: cannot test gzip functionality');
             return;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 
     public function testKeepAlives()
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
             return;
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
      */
     public function testHttp11($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
             return;
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
      */
     public function testHttp10Curl($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
             return;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
      */
     public function testHttp11Gzip($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
             return;
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
      */
     public function testHttp11Deflate($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1');
             return;
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
      */
     public function testHttp11Proxy($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
             return;
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
      */
     public function testHttps($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test https functionality');
             return;
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
      */
     public function testHttpsProxy($method)
     {
-        if(!function_exists('curl_init'))
+        if (!function_exists('curl_init'))
         {
             $this->markTestSkipped('CURL missing: cannot test https w. proxy');
             return;

Please login to merge, or discard this patch.

lib/xmlrpcs.inc 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -52,7 +52,7 @@  discard block
 block discarded – undo
      */
     public function echoInput()
     {
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
         print $r->serialize();
     }
 }
@@ -68,30 +68,30 @@  discard block
 block discarded – undo
     PhpXmlRpc\Server::xmlrpc_debugmsg($m);
 }
 
-function _xmlrpcs_getCapabilities($server, $m=null)
+function _xmlrpcs_getCapabilities($server, $m = null)
 {
     return PhpXmlRpc\Server::_xmlrpcs_getCapabilities($server, $m);
 }
 
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
 {
     return PhpXmlRpc\Server::_xmlrpcs_listMethods($server, $m);
 }
 
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
 function _xmlrpcs_methodSignature($server, $m)
 {
     return PhpXmlRpc\Server::_xmlrpcs_methodSignature($server, $m);
 }
 
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
 function _xmlrpcs_methodHelp($server, $m)
 {
     return PhpXmlRpc\Server::_xmlrpcs_methodHelp($server, $m);

Please login to merge, or discard this patch.

demo/client/mail.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
     method)</p>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 if (isset($_POST["mailto"]) && $_POST["mailto"]) {
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
         print "<font color=\"red\">";
         print "Mail send failed<br/>\n";
         print "Fault: ";
-        print "Code: " . htmlspecialchars($resp->faultCode()) .
-            " Reason: '" . htmlspecialchars($resp->faultString()) . "'<br/>";
+        print "Code: ".htmlspecialchars($resp->faultCode()).
+            " Reason: '".htmlspecialchars($resp->faultString())."'<br/>";
         print "</font><br/>";
     }
 }

Please login to merge, or discard this patch.

demo/client/introspect.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -6,20 +6,20 @@  discard block
 block discarded – undo
 <h3>The code demonstrates usage of multicall and introspection methods</h3>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 function display_error($r)
 {
     print "An error occurred: ";
-    print "Code: " . $r->faultCode()
-        . " Reason: '" . $r->faultString() . "'<br/>";
+    print "Code: ".$r->faultCode()
+        . " Reason: '".$r->faultString()."'<br/>";
 }
 
 $client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
 
 // First off, let's retrieve the list of methods available on the remote server
-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
 $req = new PhpXmlRpc\Request('system.listMethods');
 $resp = $client->send($req);
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 
     // Then, retrieve the signature and help text of each available method
     foreach ($v as $methodName) {
-        print "<h4>" . $methodName->scalarval() . "</h4>\n";
+        print "<h4>".$methodName->scalarval()."</h4>\n";
         // build messages first, add params later
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
             if ($val->kindOf() == "array") {
                 foreach ($val as $x) {
                     $ret = $x[0];
-                    print "<code>" . htmlspecialchars($ret->scalarval()) . " "
-                        . htmlspecialchars($methodName->scalarval()) . "(";
-                    if ($x->count() > 1) {
-                        for ($k = 1; $k < $x->count(); $k++) {
+                    print "<code>".htmlspecialchars($ret->scalarval())." "
+                        . htmlspecialchars($methodName->scalarval())."(";
+                    if ($x->count()>1) {
+                        for ($k = 1; $k<$x->count(); $k++) {
                             $y = $x[$k];
                             print htmlspecialchars($y->scalarval());
-                            if ($k < $x->count() - 1) {
+                            if ($k<$x->count()-1) {
                                 print ", ";
                             }
                         }

Please login to merge, or discard this patch.

tests/benchmark.php 1 patch

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -17,9 +17,9 @@  discard block
 block discarded – undo
 use PhpXmlRpc\Response;
 use PhpXmlRpc\Encoder;
 
-include_once __DIR__ . '/../vendor/autoload.php';
+include_once __DIR__.'/../vendor/autoload.php';
 
-include __DIR__ . '/parse_args.php';
+include __DIR__.'/parse_args.php';
 $args = argParser::getArgs();
 
 function begin_test($test_name, $test_case)
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
     if (!isset($test_results[$test_name][$test_case])) {
         trigger_error('ending test that was not started');
     }
-    $test_results[$test_name][$test_case]['time'] = $end - $test_results[$test_name][$test_case]['time'];
+    $test_results[$test_name][$test_case]['time'] = $end-$test_results[$test_name][$test_case]['time'];
     $test_results[$test_name][$test_case]['result'] = $test_result;
     echo '.';
     flush();
@@ -73,24 +73,24 @@  discard block
 block discarded – undo
 }
 
 if ($is_web) {
-    echo "<h3>Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "</h3>\n";
+    echo "<h3>Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."</h3>\n";
     if ($xd) {
-        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: " . htmlspecialchars(xdebug_get_profiler_filename()) . "</h4>\n";
+        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: ".htmlspecialchars(xdebug_get_profiler_filename())."</h4>\n";
     }
     flush();
     ob_flush();
 } else {
-    echo "Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "\n";
+    echo "Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."\n";
     if ($xd) {
-        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: " . xdebug_get_profiler_filename() . "\n";
+        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: ".xdebug_get_profiler_filename()."\n";
     }
 }
 
 // test 'manual style' data encoding vs. 'automatic style' encoding
 begin_test('Data encoding (large array)', 'manual encoding');
-for ($i = 0; $i < $num_tests; $i++) {
+for ($i = 0; $i<$num_tests; $i++) {
     $vals = array();
-    for ($j = 0; $j < 10; $j++) {
+    for ($j = 0; $j<10; $j++) {
         $valarray = array();
         foreach ($data[$j] as $key => $val) {
             $values = array();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
 
 begin_test('Data encoding (large array)', 'automatic encoding');
 $encoder = new Encoder();
-for ($i = 0; $i < $num_tests; $i++) {
+for ($i = 0; $i<$num_tests; $i++) {
     $value = $encoder->encode($data, array('auto_dates'));
     $out = $value->serialize();
 }
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
 
 if (function_exists('xmlrpc_set_type')) {
     begin_test('Data encoding (large array)', 'xmlrpc-epi encoding');
-    for ($i = 0; $i < $num_tests; $i++) {
-        for ($j = 0; $j < 10; $j++) {
+    for ($i = 0; $i<$num_tests; $i++) {
+        for ($j = 0; $j<10; $j++) {
             foreach ($keys as $k) {
                 xmlrpc_set_type($data[$j][$k][4], 'datetime');
                 xmlrpc_set_type($data[$j][$k][8], 'datetime');
@@ -138,18 +138,18 @@  discard block
 block discarded – undo
 // test 'old style' data decoding vs. 'automatic style' decoding
 $dummy = new Request('');
 $out = new Response($value);
-$in = '<?xml version="1.0" ?>' . "\n" . $out->serialize();
+$in = '<?xml version="1.0" ?>'."\n".$out->serialize();
 
 begin_test('Data decoding (large array)', 'manual decoding');
-for ($i = 0; $i < $num_tests; $i++) {
+for ($i = 0; $i<$num_tests; $i++) {
     $response = $dummy->ParseResponse($in, true);
     $value = $response->value();
     $result = array();
-    foreach($value as $val1) {
+    foreach ($value as $val1) {
         $out = array();
-        foreach($val1 as $name => $val) {
+        foreach ($val1 as $name => $val) {
             $out[$name] = array();
-            foreach($val as $data) {
+            foreach ($val as $data) {
                 $out[$name][] = $data->scalarval();
             }
         }
@@ -159,18 +159,18 @@  discard block
 block discarded – undo
 end_test('Data decoding (large array)', 'manual decoding', $result);
 
 begin_test('Data decoding (large array)', 'manual decoding deprecated');
-for ($i = 0; $i < $num_tests; $i++) {
+for ($i = 0; $i<$num_tests; $i++) {
     $response = $dummy->ParseResponse($in, true);
     $value = $response->value();
     $result = array();
     $l = $value->arraysize();
-    for ($k = 0; $k < $l; $k++) {
+    for ($k = 0; $k<$l; $k++) {
         $val1 = $value->arraymem($k);
         $out = array();
-        foreach($val1 as $name => $val) {
+        foreach ($val1 as $name => $val) {
             $out[$name] = array();
             $m = $val->arraysize();
-            for ($j = 0; $j < $m; $j++) {
+            for ($j = 0; $j<$m; $j++) {
                 $data = $val->arraymem($j);
                 $out[$name][] = $data->scalarval();
             }
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
 end_test('Data decoding (large array)', 'manual decoding deprecated', $result);
 
 begin_test('Data decoding (large array)', 'automatic decoding');
-for ($i = 0; $i < $num_tests; $i++) {
+for ($i = 0; $i<$num_tests; $i++) {
     $response = $dummy->ParseResponse($in, true, 'phpvals');
     $value = $response->value();
 }
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
 
 if (function_exists('xmlrpc_decode')) {
     begin_test('Data decoding (large array)', 'xmlrpc-epi decoding');
-    for ($i = 0; $i < $num_tests; $i++) {
+    for ($i = 0; $i<$num_tests; $i++) {
         $response = $dummy->ParseResponse($in, true, 'xml');
         $value = xmlrpc_decode($response->value());
     }
@@ -203,15 +203,15 @@  discard block
 block discarded – undo
     $value = $encoder->encode($data1, array('auto_dates'));
     $req = new Request('interopEchoTests.echoValue', array($value));
     $reqs = array();
-    for ($i = 0; $i < 25; $i++) {
+    for ($i = 0; $i<25; $i++) {
         $reqs[] = $req;
     }
     $server = explode(':', $args['LOCALSERVER']);
-    if (count($server) > 1) {
-        $srv = $server[1] . '://' . $server[0] . $args['URI'];
+    if (count($server)>1) {
+        $srv = $server[1].'://'.$server[0].$args['URI'];
         $c = new Client($args['URI'], $server[0], $server[1]);
     } else {
-        $srv = $args['LOCALSERVER'] . $args['URI'];
+        $srv = $args['LOCALSERVER'].$args['URI'];
         $c = new Client($args['URI'], $args['LOCALSERVER']);
     }
     // do not interfere with http compression
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
     }
     begin_test($testName, 'http 10');
     $response = array();
-    for ($i = 0; $i < 25; $i++) {
+    for ($i = 0; $i<25; $i++) {
         $resp = $c->send($req);
         $response[] = $resp->value();
     }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
     if (function_exists('curl_init')) {
         begin_test($testName, 'http 11 w. keep-alive');
         $response = array();
-        for ($i = 0; $i < 25; $i++) {
+        for ($i = 0; $i<25; $i++) {
             $resp = $c->send($req, 10, 'http11');
             $response[] = $resp->value();
         }
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
         $c->keepalive = false;
         begin_test($testName, 'http 11');
         $response = array();
-        for ($i = 0; $i < 25; $i++) {
+        for ($i = 0; $i<25; $i++) {
             $resp = $c->send($req, 10, 'http11');
             $response[] = $resp->value();
         }
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
 
         begin_test($testName, 'http 10 w. compression');
         $response = array();
-        for ($i = 0; $i < 25; $i++) {
+        for ($i = 0; $i<25; $i++) {
             $resp = $c->send($req);
             $response[] = $resp->value();
         }
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
         if (function_exists('curl_init')) {
             begin_test($testName, 'http 11 w. keep-alive and compression');
             $response = array();
-            for ($i = 0; $i < 25; $i++) {
+            for ($i = 0; $i<25; $i++) {
                 $resp = $c->send($req, 10, 'http11');
                 $response[] = $resp->value();
             }
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
             $c->keepalive = false;
             begin_test($testName, 'http 11 w. compression');
             $response = array();
-            for ($i = 0; $i < 25; $i++) {
+            for ($i = 0; $i<25; $i++) {
                 $resp = $c->send($req, 10, 'http11');
                 $response[] = $resp->value();
             }
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
 foreach ($test_results as $test => $results) {
     echo "\nTEST: $test\n";
     foreach ($results as $case => $data) {
-        echo "  $case: {$data['time']} secs - Output data CRC: " . crc32(serialize($data['result'])) . "\n";
+        echo "  $case: {$data['time']} secs - Output data CRC: ".crc32(serialize($data['result']))."\n";
     }
 }
 

Please login to merge, or discard this patch.

demo/client/agesort.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -10,13 +10,13 @@  discard block
 block discarded – undo
 <p></p>
 <?php
 
-include_once __DIR__ . "/../../src/Autoloader.php";
+include_once __DIR__."/../../src/Autoloader.php";
 PhpXmlRpc\Autoloader::register();
 
 $inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
 print "This is the input data:<br/><pre>";
 foreach ($inAr as $key => $val) {
-    print $key . ", " . $val . "\n";
+    print $key.", ".$val."\n";
 }
 print "</pre>";
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
     );
 }
 $v = new PhpXmlRpc\Value($p, "array");
-print "Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n";
+print "Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n";
 
 // create client and message objects
 $req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
@@ -52,15 +52,15 @@  discard block
 block discarded – undo
     foreach ($value as $struct) {
         $name = $struct["name"];
         $age = $struct["age"];
-        print htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n";
+        print htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n";
     }
 
-    print "<hr/>For nerds: I got this value back<br/><pre>" .
-        htmlentities($resp->serialize()) . "</pre><hr/>\n";
+    print "<hr/>For nerds: I got this value back<br/><pre>".
+        htmlentities($resp->serialize())."</pre><hr/>\n";
 } else {
     print "An error occurred:<pre>";
-    print "Code: " . htmlspecialchars($resp->faultCode()) .
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>';
+    print "Code: ".htmlspecialchars($resp->faultCode()).
+        "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>';
 }
 
 ?>

Please login to merge, or discard this patch.

		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	$val = reset($ar);
96	96	$typ = key($ar);
97	97
98		- return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
	98	+ return '<value>'.$this->serializedata($typ, $val)."</value>\n";
99	99	//}
100	100	}
101	101
		@@ -114,7 +114,7 @@ discard block
		block discarded – undo
114	114	// preserve back compatibility
115	115
116	116	if (is_array($b)) {
117		- foreach($b as $id => $cont) {
	117	+ foreach ($b as $id => $cont) {
118	118	$b[$id] = $cont->scalarval();
119	119	}
120	120	}
		@@ -122,10 +122,10 @@ discard block
		block discarded – undo
122	122	// add support for structures directly encoding php objects
123	123	if (is_object($b)) {
124	124	$t = get_object_vars($b);
125		- foreach($t as $id => $cont) {
	125	+ foreach ($t as $id => $cont) {
126	126	$t[$id] = $cont->scalarval();
127	127	}
128		- foreach($t as $id => $cont) {
	128	+ foreach ($t as $id => $cont) {
129	129	@$b->$id = $cont;
130	130	}
131	131	}
		@@ -160,17 +160,17 @@ discard block
		block discarded – undo
160	160	/* Expose as global functions the ones which are now class methods */
161	161
162	162	/// Wrong speling, but we are adamant on backwards compatibility!
163		-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
	163	+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
164	164	{
165	165	return PhpXmlRpc\Helper\Charset::instance()->encodeEntitites($data, $srcEncoding, $destEncoding);
166	166	}
167	167
168		-function iso8601_encode($timeT, $utc=0)
	168	+function iso8601_encode($timeT, $utc = 0)
169	169	{
170	170	return PhpXmlRpc\Helper\Date::iso8601Encode($timeT, $utc);
171	171	}
172	172
173		-function iso8601_decode($iDate, $utc=0)
	173	+function iso8601_decode($iDate, $utc = 0)
174	174	{
175	175	return PhpXmlRpc\Helper\Date::iso8601Decode($iDate, $utc);
176	176	}
		@@ -180,25 +180,25 @@ discard block
		block discarded – undo
180	180	return PhpXmlRpc\Helper\Http::decodeChunked($buffer);
181	181	}
182	182
183		-function php_xmlrpc_decode($xmlrpcVal, $options=array())
	183	+function php_xmlrpc_decode($xmlrpcVal, $options = array())
184	184	{
185	185	$encoder = new PhpXmlRpc\Encoder();
186	186	return $encoder->decode($xmlrpcVal, $options);
187	187	}
188	188
189		-function php_xmlrpc_encode($phpVal, $options=array())
	189	+function php_xmlrpc_encode($phpVal, $options = array())
190	190	{
191	191	$encoder = new PhpXmlRpc\Encoder();
192	192	return $encoder->encode($phpVal, $options);
193	193	}
194	194
195		-function php_xmlrpc_decode_xml($xmlVal, $options=array())
	195	+function php_xmlrpc_decode_xml($xmlVal, $options = array())
196	196	{
197	197	$encoder = new PhpXmlRpc\Encoder();
198	198	return $encoder->decodeXml($xmlVal, $options);
199	199	}
200	200
201		-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
	201	+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
202	202	{
203	203	return PhpXmlRpc\Helper\XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
204	204	}

		@@ -3,16 +3,16 @@ discard block
		block discarded – undo
3	3	<body>
4	4	<?php
5	5
6		-include_once __DIR__ . "/../vendor/autoload.php";
	6	+include_once __DIR__."/../vendor/autoload.php";
7	7
8	8	$req = new PhpXmlRpc\Request('examples.getStateName');
9	9
10	10	print "<h3>Testing value serialization</h3>\n";
11	11
12	12	$v = new PhpXmlRpc\Value(23, "int");
13		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	13	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
14	14	$v = new PhpXmlRpc\Value("What are you saying? >> << &&");
15		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	15	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
16	16
17	17	$v = new PhpXmlRpc\Value(
18	18	array(
		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	"array"
24	24	);
25	25
26		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	26	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
27	27
28	28	$v = new PhpXmlRpc\Value(
29	29	array(
		@@ -51,11 +51,11 @@ discard block
		block discarded – undo
51	51	"struct"
52	52	);
53	53
54		-print "<PRE>" . htmlentities($v->serialize()) . "</PRE>";
	54	+print "<PRE>".htmlentities($v->serialize())."</PRE>";
55	55
56	56	$w = new PhpXmlRpc\Value(array($v, new PhpXmlRpc\Value("That was the struct!")), "array");
57	57
58		-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
	58	+print "<PRE>".htmlentities($w->serialize())."</PRE>";
59	59
60	60	$w = new PhpXmlRpc\Value("Mary had a little lamb,
61	61	Whose fleece was white as snow,
		@@ -67,26 +67,26 @@ discard block
		block discarded – undo
67	67	Ten thousand volts went down its back
68	68	And turned it into nylon", "base64"
69	69	);
70		-print "<PRE>" . htmlentities($w->serialize()) . "</PRE>";
71		-print "<PRE>Value of base64 string is: '" . $w->scalarval() . "'</PRE>";
	70	+print "<PRE>".htmlentities($w->serialize())."</PRE>";
	71	+print "<PRE>Value of base64 string is: '".$w->scalarval()."'</PRE>";
72	72
73	73	$req->method('');
74	74	$req->addParam(new PhpXmlRpc\Value("41", "int"));
75	75
76	76	print "<h3>Testing request serialization</h3>\n";
77	77	$op = $req->serialize();
78		-print "<PRE>" . htmlentities($op) . "</PRE>";
	78	+print "<PRE>".htmlentities($op)."</PRE>";
79	79
80	80	print "<h3>Testing ISO date format</h3><pre>\n";
81	81
82	82	$t = time();
83	83	$date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
84	84	print "Now is $t --> $date\n";
85		-print "Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n";
	85	+print "Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n";
86	86	$tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
87	87	print "That is to say $date --> $tb\n";
88		-print "Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n";
89		-print "Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($date, 1) . "\n";
	88	+print "Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n";
	89	+print "Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($date, 1)."\n";
90	90
91	91	print "</pre>\n";
92	92

		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	die();
16	16	}
17	17
18		-include_once __DIR__ . "/../../vendor/autoload.php";
	18	+include_once __DIR__."/../../vendor/autoload.php";
19	19
20	20	// out-of-band information: let the client manipulate the server operations.
21	21	// we do this to help the testsuite script: do not reproduce in production!
		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	mkdir($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY']);
26	26	}
27	27
28		- include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
	28	+ include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
29	29	}
30	30
31	31	use PhpXmlRpc\Value;
		@@ -122,11 +122,11 @@ discard block
		block discarded – undo
122	122	// extract the value of the state number
123	123	$snv = $sno->scalarval();
124	124	// look it up in our array (zero-based)
125		- if (isset($stateNames[$snv - 1])) {
126		- $stateName = $stateNames[$snv - 1];
	125	+ if (isset($stateNames[$snv-1])) {
	126	+ $stateName = $stateNames[$snv-1];
127	127	} else {
128	128	// not there, so complain
129		- $err = "I don't have a state for the index '" . $snv . "'";
	129	+ $err = "I don't have a state for the index '".$snv."'";
130	130	}
131	131
132	132	// if we generated an error, create an error return response
		@@ -152,11 +152,11 @@ discard block
		block discarded – undo
152	152	{
153	153	global $stateNames;
154	154
155		- if (isset($stateNames[$stateNo - 1])) {
156		- return $stateNames[$stateNo - 1];
	155	+ if (isset($stateNames[$stateNo-1])) {
	156	+ return $stateNames[$stateNo-1];
157	157	} else {
158	158	// not, there so complain
159		- throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
	159	+ throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
160	160	}
161	161	}
162	162
		@@ -186,17 +186,17 @@ discard block
		block discarded – undo
186	186	eval($findstate9_sig['source']);
187	187
188	188	$findstate10_sig = array(
189		- "function" => function ($req) { return findState($req); },
	189	+ "function" => function($req) { return findState($req); },
190	190	"signature" => $findstate_sig,
191	191	"docstring" => $findstate_doc,
192	192	);
193	193
194		-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return inner_findstate($stateNo); });
	194	+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return inner_findstate($stateNo); });
195	195
196	196	$c = new xmlrpcServerMethodsContainer;
197	197	$moreSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'tests.', 'method_type' => 'all'));
198	198
199		-$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
	199	+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
200	200
201	201	// used to test signatures with NULL params
202	202	$findstate12_sig = array(
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	$s = $req->getParam(0);
223	223	$t = $req->getParam(1);
224	224
225		- return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcInt));
	225	+ return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcInt));
226	226	}
227	227
228	228	$addtwodouble_sig = array(array(Value::$xmlrpcDouble, Value::$xmlrpcDouble, Value::$xmlrpcDouble));
		@@ -232,7 +232,7 @@ discard block
		block discarded – undo
232	232	$s = $req->getParam(0);
233	233	$t = $req->getParam(1);
234	234
235		- return new PhpXmlRpc\Response(new Value($s->scalarval() + $t->scalarval(), Value::$xmlrpcDouble));
	235	+ return new PhpXmlRpc\Response(new Value($s->scalarval()+$t->scalarval(), Value::$xmlrpcDouble));
236	236	}
237	237
238	238	$stringecho_sig = array(array(Value::$xmlrpcString, Value::$xmlrpcString));
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	function echoBack($req)
249	249	{
250	250	// just sends back a string with what i got sent to me, just escaped, that's all
251		- $s = "I got the following message:\n" . $req->serialize();
	251	+ $s = "I got the following message:\n".$req->serialize();
252	252
253	253	return new PhpXmlRpc\Response(new Value($s));
254	254	}
		@@ -305,7 +305,7 @@ discard block
		block discarded – undo
305	305	return 0;
306	306	}
307	307
308		- return ($agesorter_arr[$a] > $agesorter_arr[$b]) ? -1 : 1;
	308	+ return ($agesorter_arr[$a]>$agesorter_arr[$b]) ? -1 : 1;
309	309	}
310	310
311	311	$agesorter_sig = array(array(Value::$xmlrpcArray, Value::$xmlrpcArray));
		@@ -351,7 +351,7 @@ discard block
		block discarded – undo
351	351	// hack, must make global as uksort() won't
352	352	// allow us to pass any other auxiliary information
353	353	uksort($agesorter_arr, 'agesorter_compare');
354		- foreach($agesorter_arr as $key => $val) {
	354	+ foreach ($agesorter_arr as $key => $val) {
355	355	// recreate each struct element
356	356	$v[] = new Value(
357	357	array(
		@@ -406,17 +406,17 @@ discard block
		block discarded – undo
406	406	$err = "Error, no 'From' field specified";
407	407	}
408	408
409		- $msgHdr = "From: " . $mFrom->scalarval() . "\n";
410		- $msgHdr .= "To: " . $mTo->scalarval() . "\n";
	409	+ $msgHdr = "From: ".$mFrom->scalarval()."\n";
	410	+ $msgHdr .= "To: ".$mTo->scalarval()."\n";
411	411
412	412	if ($mCc->scalarval() != "") {
413		- $msgHdr .= "Cc: " . $mCc->scalarval() . "\n";
	413	+ $msgHdr .= "Cc: ".$mCc->scalarval()."\n";
414	414	}
415	415	if ($mBcc->scalarval() != "") {
416		- $msgHdr .= "Bcc: " . $mBcc->scalarval() . "\n";
	416	+ $msgHdr .= "Bcc: ".$mBcc->scalarval()."\n";
417	417	}
418	418	if ($mMime->scalarval() != "") {
419		- $msgHdr .= "Content-type: " . $mMime->scalarval() . "\n";
	419	+ $msgHdr .= "Content-type: ".$mMime->scalarval()."\n";
420	420	}
421	421	$msgHdr .= "X-Mailer: XML-RPC for PHP mailer 1.0";
422	422
		@@ -506,7 +506,7 @@ discard block
		block discarded – undo
506	506	$moe = $sno["moe"];
507	507	$larry = $sno["larry"];
508	508	$curly = $sno["curly"];
509		- $num = $moe->scalarval() + $larry->scalarval() + $curly->scalarval();
	509	+ $num = $moe->scalarval()+$larry->scalarval()+$curly->scalarval();
510	510
511	511	return new PhpXmlRpc\Response(new Value($num, Value::$xmlrpcInt));
512	512	}
		@@ -548,9 +548,9 @@ discard block
		block discarded – undo
548	548	$ar = $req->getParam(0);
549	549	$sz = $ar->count();
550	550	$first = $ar[0];
551		- $last = $ar[$sz - 1];
	551	+ $last = $ar[$sz-1];
552	552
553		- return new PhpXmlRpc\Response(new Value($first->scalarval() .
	553	+ return new PhpXmlRpc\Response(new Value($first->scalarval().
554	554	$last->scalarval(), Value::$xmlrpcString));
555	555	}
556	556
		@@ -584,7 +584,7 @@ discard block
		block discarded – undo
584	584	$larry = $fools["larry"];
585	585	$moe = $fools["moe"];
586	586
587		- return new PhpXmlRpc\Response(new Value($curly->scalarval() + $larry->scalarval() + $moe->scalarval(), Value::$xmlrpcInt));
	587	+ return new PhpXmlRpc\Response(new Value($curly->scalarval()+$larry->scalarval()+$moe->scalarval(), Value::$xmlrpcInt));
588	588	}
589	589
590	590	$v1_countTheEntities_sig = array(array(Value::$xmlrpcStruct, Value::$xmlrpcString));
		@@ -598,7 +598,7 @@ discard block
		block discarded – undo
598	598	$ap = 0;
599	599	$qu = 0;
600	600	$amp = 0;
601		- for ($i = 0; $i < strlen($str); $i++) {
	601	+ for ($i = 0; $i<strlen($str); $i++) {
602	602	$c = substr($str, $i, 1);
603	603	switch ($c) {
604	604	case ">":
		@@ -800,7 +800,7 @@ discard block
		block discarded – undo
800	800	),
801	801	// Greek word 'kosme'. NB: NOT a valid ISO8859 string!
802	802	// NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
803		- "tests.utf8methodname." . 'κόσμε' => array(
	803	+ "tests.utf8methodname.".'κόσμε' => array(
804	804	"function" => "stringEcho",
805	805	"signature" => $stringecho_sig,
806	806	"docstring" => $stringecho_doc,
		@@ -996,5 +996,5 @@ discard block
		block discarded – undo
996	996	// Out-of-band information: let the client manipulate the server operations.
997	997	// We do this to help the testsuite script: do not reproduce in production!
998	998	if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
999		- include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
	999	+ include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
1000	1000	}

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-include_once __DIR__ . '/../lib/xmlrpc.inc';
4		-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
	3	+include_once __DIR__.'/../lib/xmlrpc.inc';
	4	+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
5	5
6		-include_once __DIR__ . '/parse_args.php';
	6	+include_once __DIR__.'/parse_args.php';
7	7
8		-include_once __DIR__ . '/3LocalhostTest.php';
	8	+include_once __DIR__.'/3LocalhostTest.php';
9	9
10	10	/**
11	11	* Tests which stress http features of the library.
		@@ -27,9 +27,9 @@ discard block
		block discarded – undo
27	27	);
28	28
29	29	$methods = array();
30		- foreach(get_class_methods('LocalhostTest') as $method)
	30	+ foreach (get_class_methods('LocalhostTest') as $method)
31	31	{
32		- if(strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
	32	+ if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
33	33	{
34	34	if (!isset(self::$failed_tests[$method])) {
35	35	$methods[$method] = array($method);
		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	*/
47	47	public function testDeflate($method)
48	48	{
49		- if(!function_exists('gzdeflate'))
	49	+ if (!function_exists('gzdeflate'))
50	50	{
51	51	$this->markTestSkipped('Zlib missing: cannot test deflate functionality');
52	52	return;
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	*/
65	65	public function testGzip($method)
66	66	{
67		- if(!function_exists('gzdeflate'))
	67	+ if (!function_exists('gzdeflate'))
68	68	{
69	69	$this->markTestSkipped('Zlib missing: cannot test gzip functionality');
70	70	return;
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78
79	79	public function testKeepAlives()
80	80	{
81		- if(!function_exists('curl_init'))
	81	+ if (!function_exists('curl_init'))
82	82	{
83	83	$this->markTestSkipped('CURL missing: cannot test http 1.1');
84	84	return;
		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	*/
119	119	public function testHttp11($method)
120	120	{
121		- if(!function_exists('curl_init'))
	121	+ if (!function_exists('curl_init'))
122	122	{
123	123	$this->markTestSkipped('CURL missing: cannot test http 1.1');
124	124	return;
		@@ -137,7 +137,7 @@ discard block
		block discarded – undo
137	137	*/
138	138	public function testHttp10Curl($method)
139	139	{
140		- if(!function_exists('curl_init'))
	140	+ if (!function_exists('curl_init'))
141	141	{
142	142	$this->markTestSkipped('CURL missing: cannot test http 1.1');
143	143	return;
		@@ -157,7 +157,7 @@ discard block
		block discarded – undo
157	157	*/
158	158	public function testHttp11Gzip($method)
159	159	{
160		- if(!function_exists('curl_init'))
	160	+ if (!function_exists('curl_init'))
161	161	{
162	162	$this->markTestSkipped('CURL missing: cannot test http 1.1');
163	163	return;
		@@ -177,7 +177,7 @@ discard block
		block discarded – undo
177	177	*/
178	178	public function testHttp11Deflate($method)
179	179	{
180		- if(!function_exists('curl_init'))
	180	+ if (!function_exists('curl_init'))
181	181	{
182	182	$this->markTestSkipped('CURL missing: cannot test http 1.1');
183	183	return;
		@@ -197,7 +197,7 @@ discard block
		block discarded – undo
197	197	*/
198	198	public function testHttp11Proxy($method)
199	199	{
200		- if(!function_exists('curl_init'))
	200	+ if (!function_exists('curl_init'))
201	201	{
202	202	$this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy');
203	203	return;
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	*/
223	223	public function testHttps($method)
224	224	{
225		- if(!function_exists('curl_init'))
	225	+ if (!function_exists('curl_init'))
226	226	{
227	227	$this->markTestSkipped('CURL missing: cannot test https functionality');
228	228	return;
		@@ -274,7 +274,7 @@ discard block
		block discarded – undo
274	274	*/
275	275	public function testHttpsProxy($method)
276	276	{
277		- if(!function_exists('curl_init'))
	277	+ if (!function_exists('curl_init'))
278	278	{
279	279	$this->markTestSkipped('CURL missing: cannot test https w. proxy');
280	280	return;

		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	*/
53	53	public function echoInput()
54	54	{
55		- $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
	55	+ $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
56	56	print $r->serialize();
57	57	}
58	58	}
		@@ -68,30 +68,30 @@ discard block
		block discarded – undo
68	68	PhpXmlRpc\Server::xmlrpc_debugmsg($m);
69	69	}
70	70
71		-function _xmlrpcs_getCapabilities($server, $m=null)
	71	+function _xmlrpcs_getCapabilities($server, $m = null)
72	72	{
73	73	return PhpXmlRpc\Server::_xmlrpcs_getCapabilities($server, $m);
74	74	}
75	75
76		-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
77		-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
78		-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
79		-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
	76	+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
	77	+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
	78	+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
	79	+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
80	80	{
81	81	return PhpXmlRpc\Server::_xmlrpcs_listMethods($server, $m);
82	82	}
83	83
84		-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
85		-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
86		-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
	84	+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
	85	+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
	86	+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
87	87	function _xmlrpcs_methodSignature($server, $m)
88	88	{
89	89	return PhpXmlRpc\Server::_xmlrpcs_methodSignature($server, $m);
90	90	}
91	91
92		-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
93		-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
94		-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
	92	+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
	93	+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
	94	+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
95	95	function _xmlrpcs_methodHelp($server, $m)
96	96	{
97	97	return PhpXmlRpc\Server::_xmlrpcs_methodHelp($server, $m);

		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	method)</p>
21	21	<?php
22	22
23		-include_once __DIR__ . "/../../src/Autoloader.php";
	23	+include_once __DIR__."/../../src/Autoloader.php";
24	24	PhpXmlRpc\Autoloader::register();
25	25
26	26	if (isset($_POST["mailto"]) && $_POST["mailto"]) {
		@@ -44,8 +44,8 @@ discard block
		block discarded – undo
44	44	print "<font color=\"red\">";
45	45	print "Mail send failed<br/>\n";
46	46	print "Fault: ";
47		- print "Code: " . htmlspecialchars($resp->faultCode()) .
48		- " Reason: '" . htmlspecialchars($resp->faultString()) . "'<br/>";
	47	+ print "Code: ".htmlspecialchars($resp->faultCode()).
	48	+ " Reason: '".htmlspecialchars($resp->faultString())."'<br/>";
49	49	print "</font><br/>";
50	50	}
51	51	}

		@@ -6,20 +6,20 @@ discard block
		block discarded – undo
6	6	<h3>The code demonstrates usage of multicall and introspection methods</h3>
7	7	<?php
8	8
9		-include_once __DIR__ . "/../../src/Autoloader.php";
	9	+include_once __DIR__."/../../src/Autoloader.php";
10	10	PhpXmlRpc\Autoloader::register();
11	11
12	12	function display_error($r)
13	13	{
14	14	print "An error occurred: ";
15		- print "Code: " . $r->faultCode()
16		- . " Reason: '" . $r->faultString() . "'<br/>";
	15	+ print "Code: ".$r->faultCode()
	16	+ . " Reason: '".$r->faultString()."'<br/>";
17	17	}
18	18
19	19	$client = new PhpXmlRpc\Client("http://phpxmlrpc.sourceforge.net/server.php");
20	20
21	21	// First off, let's retrieve the list of methods available on the remote server
22		-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
	22	+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
23	23	$req = new PhpXmlRpc\Request('system.listMethods');
24	24	$resp = $client->send($req);
25	25
		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30
31	31	// Then, retrieve the signature and help text of each available method
32	32	foreach ($v as $methodName) {
33		- print "<h4>" . $methodName->scalarval() . "</h4>\n";
	33	+ print "<h4>".$methodName->scalarval()."</h4>\n";
34	34	// build messages first, add params later
35	35	$m1 = new PhpXmlRpc\Request('system.methodHelp');
36	36	$m2 = new PhpXmlRpc\Request('system.methodSignature');
		@@ -61,13 +61,13 @@ discard block
		block discarded – undo
61	61	if ($val->kindOf() == "array") {
62	62	foreach ($val as $x) {
63	63	$ret = $x[0];
64		- print "<code>" . htmlspecialchars($ret->scalarval()) . " "
65		- . htmlspecialchars($methodName->scalarval()) . "(";
66		- if ($x->count() > 1) {
67		- for ($k = 1; $k < $x->count(); $k++) {
	64	+ print "<code>".htmlspecialchars($ret->scalarval())." "
	65	+ . htmlspecialchars($methodName->scalarval())."(";
	66	+ if ($x->count()>1) {
	67	+ for ($k = 1; $k<$x->count(); $k++) {
68	68	$y = $x[$k];
69	69	print htmlspecialchars($y->scalarval());
70		- if ($k < $x->count() - 1) {
	70	+ if ($k<$x->count()-1) {
71	71	print ", ";
72	72	}
73	73	}

		@@ -17,9 +17,9 @@ discard block
		block discarded – undo
17	17	use PhpXmlRpc\Response;
18	18	use PhpXmlRpc\Encoder;
19	19
20		-include_once __DIR__ . '/../vendor/autoload.php';
	20	+include_once __DIR__.'/../vendor/autoload.php';
21	21
22		-include __DIR__ . '/parse_args.php';
	22	+include __DIR__.'/parse_args.php';
23	23	$args = argParser::getArgs();
24	24
25	25	function begin_test($test_name, $test_case)
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	if (!isset($test_results[$test_name][$test_case])) {
40	40	trigger_error('ending test that was not started');
41	41	}
42		- $test_results[$test_name][$test_case]['time'] = $end - $test_results[$test_name][$test_case]['time'];
	42	+ $test_results[$test_name][$test_case]['time'] = $end-$test_results[$test_name][$test_case]['time'];
43	43	$test_results[$test_name][$test_case]['result'] = $test_result;
44	44	echo '.';
45	45	flush();
		@@ -73,24 +73,24 @@ discard block
		block discarded – undo
73	73	}
74	74
75	75	if ($is_web) {
76		- echo "<h3>Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "</h3>\n";
	76	+ echo "<h3>Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."</h3>\n";
77	77	if ($xd) {
78		- echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: " . htmlspecialchars(xdebug_get_profiler_filename()) . "</h4>\n";
	78	+ echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: ".htmlspecialchars(xdebug_get_profiler_filename())."</h4>\n";
79	79	}
80	80	flush();
81	81	ob_flush();
82	82	} else {
83		- echo "Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "\n";
	83	+ echo "Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."\n";
84	84	if ($xd) {
85		- echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: " . xdebug_get_profiler_filename() . "\n";
	85	+ echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: ".xdebug_get_profiler_filename()."\n";
86	86	}
87	87	}
88	88
89	89	// test 'manual style' data encoding vs. 'automatic style' encoding
90	90	begin_test('Data encoding (large array)', 'manual encoding');
91		-for ($i = 0; $i < $num_tests; $i++) {
	91	+for ($i = 0; $i<$num_tests; $i++) {
92	92	$vals = array();
93		- for ($j = 0; $j < 10; $j++) {
	93	+ for ($j = 0; $j<10; $j++) {
94	94	$valarray = array();
95	95	foreach ($data[$j] as $key => $val) {
96	96	$values = array();
		@@ -115,7 +115,7 @@ discard block
		block discarded – undo
115	115
116	116	begin_test('Data encoding (large array)', 'automatic encoding');
117	117	$encoder = new Encoder();
118		-for ($i = 0; $i < $num_tests; $i++) {
	118	+for ($i = 0; $i<$num_tests; $i++) {
119	119	$value = $encoder->encode($data, array('auto_dates'));
120	120	$out = $value->serialize();
121	121	}
		@@ -123,8 +123,8 @@ discard block
		block discarded – undo
123	123
124	124	if (function_exists('xmlrpc_set_type')) {
125	125	begin_test('Data encoding (large array)', 'xmlrpc-epi encoding');
126		- for ($i = 0; $i < $num_tests; $i++) {
127		- for ($j = 0; $j < 10; $j++) {
	126	+ for ($i = 0; $i<$num_tests; $i++) {
	127	+ for ($j = 0; $j<10; $j++) {
128	128	foreach ($keys as $k) {
129	129	xmlrpc_set_type($data[$j][$k][4], 'datetime');
130	130	xmlrpc_set_type($data[$j][$k][8], 'datetime');
		@@ -138,18 +138,18 @@ discard block
		block discarded – undo
138	138	// test 'old style' data decoding vs. 'automatic style' decoding
139	139	$dummy = new Request('');
140	140	$out = new Response($value);
141		-$in = '<?xml version="1.0" ?>' . "\n" . $out->serialize();
	141	+$in = '<?xml version="1.0" ?>'."\n".$out->serialize();
142	142
143	143	begin_test('Data decoding (large array)', 'manual decoding');
144		-for ($i = 0; $i < $num_tests; $i++) {
	144	+for ($i = 0; $i<$num_tests; $i++) {
145	145	$response = $dummy->ParseResponse($in, true);
146	146	$value = $response->value();
147	147	$result = array();
148		- foreach($value as $val1) {
	148	+ foreach ($value as $val1) {
149	149	$out = array();
150		- foreach($val1 as $name => $val) {
	150	+ foreach ($val1 as $name => $val) {
151	151	$out[$name] = array();
152		- foreach($val as $data) {
	152	+ foreach ($val as $data) {
153	153	$out[$name][] = $data->scalarval();
154	154	}
155	155	}
		@@ -159,18 +159,18 @@ discard block
		block discarded – undo
159	159	end_test('Data decoding (large array)', 'manual decoding', $result);
160	160
161	161	begin_test('Data decoding (large array)', 'manual decoding deprecated');
162		-for ($i = 0; $i < $num_tests; $i++) {
	162	+for ($i = 0; $i<$num_tests; $i++) {
163	163	$response = $dummy->ParseResponse($in, true);
164	164	$value = $response->value();
165	165	$result = array();
166	166	$l = $value->arraysize();
167		- for ($k = 0; $k < $l; $k++) {
	167	+ for ($k = 0; $k<$l; $k++) {
168	168	$val1 = $value->arraymem($k);
169	169	$out = array();
170		- foreach($val1 as $name => $val) {
	170	+ foreach ($val1 as $name => $val) {
171	171	$out[$name] = array();
172	172	$m = $val->arraysize();
173		- for ($j = 0; $j < $m; $j++) {
	173	+ for ($j = 0; $j<$m; $j++) {
174	174	$data = $val->arraymem($j);
175	175	$out[$name][] = $data->scalarval();
176	176	}
		@@ -181,7 +181,7 @@ discard block
		block discarded – undo
181	181	end_test('Data decoding (large array)', 'manual decoding deprecated', $result);
182	182
183	183	begin_test('Data decoding (large array)', 'automatic decoding');
184		-for ($i = 0; $i < $num_tests; $i++) {
	184	+for ($i = 0; $i<$num_tests; $i++) {
185	185	$response = $dummy->ParseResponse($in, true, 'phpvals');
186	186	$value = $response->value();
187	187	}
		@@ -189,7 +189,7 @@ discard block
		block discarded – undo
189	189
190	190	if (function_exists('xmlrpc_decode')) {
191	191	begin_test('Data decoding (large array)', 'xmlrpc-epi decoding');
192		- for ($i = 0; $i < $num_tests; $i++) {
	192	+ for ($i = 0; $i<$num_tests; $i++) {
193	193	$response = $dummy->ParseResponse($in, true, 'xml');
194	194	$value = xmlrpc_decode($response->value());
195	195	}
		@@ -203,15 +203,15 @@ discard block
		block discarded – undo
203	203	$value = $encoder->encode($data1, array('auto_dates'));
204	204	$req = new Request('interopEchoTests.echoValue', array($value));
205	205	$reqs = array();
206		- for ($i = 0; $i < 25; $i++) {
	206	+ for ($i = 0; $i<25; $i++) {
207	207	$reqs[] = $req;
208	208	}
209	209	$server = explode(':', $args['LOCALSERVER']);
210		- if (count($server) > 1) {
211		- $srv = $server[1] . '://' . $server[0] . $args['URI'];
	210	+ if (count($server)>1) {
	211	+ $srv = $server[1].'://'.$server[0].$args['URI'];
212	212	$c = new Client($args['URI'], $server[0], $server[1]);
213	213	} else {
214		- $srv = $args['LOCALSERVER'] . $args['URI'];
	214	+ $srv = $args['LOCALSERVER'].$args['URI'];
215	215	$c = new Client($args['URI'], $args['LOCALSERVER']);
216	216	}
217	217	// do not interfere with http compression
		@@ -225,7 +225,7 @@ discard block
		block discarded – undo
225	225	}
226	226	begin_test($testName, 'http 10');
227	227	$response = array();
228		- for ($i = 0; $i < 25; $i++) {
	228	+ for ($i = 0; $i<25; $i++) {
229	229	$resp = $c->send($req);
230	230	$response[] = $resp->value();
231	231	}
		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	if (function_exists('curl_init')) {
235	235	begin_test($testName, 'http 11 w. keep-alive');
236	236	$response = array();
237		- for ($i = 0; $i < 25; $i++) {
	237	+ for ($i = 0; $i<25; $i++) {
238	238	$resp = $c->send($req, 10, 'http11');
239	239	$response[] = $resp->value();
240	240	}
		@@ -243,7 +243,7 @@ discard block
		block discarded – undo
243	243	$c->keepalive = false;
244	244	begin_test($testName, 'http 11');
245	245	$response = array();
246		- for ($i = 0; $i < 25; $i++) {
	246	+ for ($i = 0; $i<25; $i++) {
247	247	$resp = $c->send($req, 10, 'http11');
248	248	$response[] = $resp->value();
249	249	}
		@@ -263,7 +263,7 @@ discard block
		block discarded – undo
263	263
264	264	begin_test($testName, 'http 10 w. compression');
265	265	$response = array();
266		- for ($i = 0; $i < 25; $i++) {
	266	+ for ($i = 0; $i<25; $i++) {
267	267	$resp = $c->send($req);
268	268	$response[] = $resp->value();
269	269	}
		@@ -272,7 +272,7 @@ discard block
		block discarded – undo
272	272	if (function_exists('curl_init')) {
273	273	begin_test($testName, 'http 11 w. keep-alive and compression');
274	274	$response = array();
275		- for ($i = 0; $i < 25; $i++) {
	275	+ for ($i = 0; $i<25; $i++) {
276	276	$resp = $c->send($req, 10, 'http11');
277	277	$response[] = $resp->value();
278	278	}
		@@ -281,7 +281,7 @@ discard block
		block discarded – undo
281	281	$c->keepalive = false;
282	282	begin_test($testName, 'http 11 w. compression');
283	283	$response = array();
284		- for ($i = 0; $i < 25; $i++) {
	284	+ for ($i = 0; $i<25; $i++) {
285	285	$resp = $c->send($req, 10, 'http11');
286	286	$response[] = $resp->value();
287	287	}
		@@ -302,7 +302,7 @@ discard block
		block discarded – undo
302	302	foreach ($test_results as $test => $results) {
303	303	echo "\nTEST: $test\n";
304	304	foreach ($results as $case => $data) {
305		- echo " $case: {$data['time']} secs - Output data CRC: " . crc32(serialize($data['result'])) . "\n";
	305	+ echo " $case: {$data['time']} secs - Output data CRC: ".crc32(serialize($data['result']))."\n";
306	306	}
307	307	}
308	308

		@@ -10,13 +10,13 @@ discard block
		block discarded – undo
10	10	<p></p>
11	11	<?php
12	12
13		-include_once __DIR__ . "/../../src/Autoloader.php";
	13	+include_once __DIR__."/../../src/Autoloader.php";
14	14	PhpXmlRpc\Autoloader::register();
15	15
16	16	$inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
17	17	print "This is the input data:<br/><pre>";
18	18	foreach ($inAr as $key => $val) {
19		- print $key . ", " . $val . "\n";
	19	+ print $key.", ".$val."\n";
20	20	}
21	21	print "</pre>";
22	22
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	);
33	33	}
34	34	$v = new PhpXmlRpc\Value($p, "array");
35		-print "Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n";
	35	+print "Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n";
36	36
37	37	// create client and message objects
38	38	$req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
		@@ -52,15 +52,15 @@ discard block
		block discarded – undo
52	52	foreach ($value as $struct) {
53	53	$name = $struct["name"];
54	54	$age = $struct["age"];
55		- print htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n";
	55	+ print htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n";
56	56	}
57	57
58		- print "<hr/>For nerds: I got this value back<br/><pre>" .
59		- htmlentities($resp->serialize()) . "</pre><hr/>\n";
	58	+ print "<hr/>For nerds: I got this value back<br/><pre>".
	59	+ htmlentities($resp->serialize())."</pre><hr/>\n";
60	60	} else {
61	61	print "An error occurred:<pre>";
62		- print "Code: " . htmlspecialchars($resp->faultCode()) .
63		- "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>';
	62	+ print "Code: ".htmlspecialchars($resp->faultCode()).
	63	+ "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>';
64	64	}
65	65
66	66	?>

gggeek / phpxmlrpc

Push — master ( 43c003...f5456e )

Status

Category

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch