View GitHub Repository phpxmlrpc

Schedule Inspection
Subscribe
Passed
Push — master ( 404971...7162b6 )
by Gaetano
08:59
created
Status
Category
Toggle Patches
demo/client/getstatename.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>phpxmlrpc - Getstatename demo</title></head>
 
@@ -17,13 +17,13 @@  discard block
 
 block discarded – undo
17 17 
 $stateNo = "";
18 18
19 19 
 if (isset($_POST['stateno']) && $_POST['stateno'] != "") {
20 
-    $stateNo = (integer)$_POST['stateno'];
20 
+    $stateNo = (integer) $_POST['stateno'];
21 21 
     $method = 'examples.getStateName';
22 22 
     $arguments = array(
23 23 
         new Value($stateNo, Value::$xmlrpcInt),
24 24 
     );
25 25 
     $req = new Request($method, $arguments);
26 
-    output("Sending the following request:<pre>\n\n" . htmlentities($req->serialize()) .
26 
+    output("Sending the following request:<pre>\n\n".htmlentities($req->serialize()).
27 27 
         "\n\n</pre>Debug info of server data follows...\n\n");
28 28 
     $client = new Client(XMLRPCSERVER);
29 29 
     $client->setDebug(1);
 
@@ -32,12 +32,12 @@  discard block
 
 block discarded – undo
32 32 
         $val = $resp->value();
33 33 
         // NB: we are _assuming_ that the server did return a scalar xml-rpc value here.
34 34 
         // If the server is not trusted, we might check that via `$val->kindOf() == 'scalar'`
35 
-        output('<br/>State number <b>' . $stateNo . '</b> is <b>'
36 
-            . htmlspecialchars($val->scalarval()) . '</b><br/><br/>');
35 
+        output('<br/>State number <b>'.$stateNo.'</b> is <b>'
36 
+            . htmlspecialchars($val->scalarval()).'</b><br/><br/>');
37 37 
     } else {
38 38 
         output('An error occurred: ');
39 
-        output('<pre>Code: ' . htmlspecialchars($resp->faultCode())
40 
-            . " Reason: '" . htmlspecialchars($resp->faultString()) . "'</pre>");
39 
+        output('<pre>Code: '.htmlspecialchars($resp->faultCode())
40 
+            . " Reason: '".htmlspecialchars($resp->faultString())."'</pre>");
41 41 
     }
42 42 
 }
43 43
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>phpxmlrpc - Proxy demo</title></head>
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>phpxmlrpc - Webservice wrapper demo</title></head>
 
@@ -20,7 +20,7 @@  discard block
 
 block discarded – undo
20 20 
 $client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
21 21 
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
22 22 
 if ($resp->faultCode()) {
23 
-    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n");
23 
+    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n");
24 24 
 } else {
25 25 
     output("<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n");
26 26 
     flush();
 
@@ -32,9 +32,9 @@  discard block
 
 block discarded – undo
32 32 
         if ($methodName == 'examples.getStateName') {
33 33 
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
34 34 
             if ($callable) {
35 
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n");
35 
+                output("<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n");
36 36 
             } else {
37 
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n");
37 
+                output("<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n");
38 38 
             }
39 39 
             break;
40 40 
         }
Please login to merge, or discard this patch.
demo/client/agesort.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>phpxmlrpc - Agesort demo</title></head>
 
@@ -17,21 +17,21 @@  discard block
 
 block discarded – undo
17 17
18 18 
 $inAr = array(
19 19 
     array('name' => 'Dave', 'age' => 24),
20 
-    array('name' => 'Edd',  'age' => 45),
21 
-    array('name' => 'Joe',  'age' => 37),
20 
+    array('name' => 'Edd', 'age' => 45),
21 
+    array('name' => 'Joe', 'age' => 37),
22 22 
     array('name' => 'Fred', 'age' => 27),
23 23 
 );
24 24
25 25 
 output('This is the input data:<br/><pre>');
26 26 
 foreach ($inAr as $val) {
27 
-    output($val['name'] . ", " . $val['age'] . "\n");
27 
+    output($val['name'].", ".$val['age']."\n");
28 28 
 }
29 29 
 output('</pre>');
30 30
31 31 
 // Create xml-rpc parameters from the input array: an array of structs
32 32 
 $encoder = new Encoder();
33 33 
 $v = $encoder->encode($inAr);
34 
-output("Encoded into xml-rpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n");
34 
+output("Encoded into xml-rpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n");
35 35
36 36 
 // create client and request objects
37 37 
 $req = new Request('examples.sortByAge', array($v));
 
@@ -51,15 +51,15 @@  discard block
 
 block discarded – undo
51 51 
     $value = $resp->value();
52 52 
     foreach ($encoder->decode($value) as $struct) {
53 53 
         // note: here we are trusting the server's response to have the expected format
54 
-        output(htmlspecialchars($struct['name']) . ", " . htmlspecialchars($struct['age']) . "\n");
54 
+        output(htmlspecialchars($struct['name']).", ".htmlspecialchars($struct['age'])."\n");
55 55 
     }
56 56
57 
-    output('</pre><hr/>For nerds: I got this value back<br/><pre>' .
58 
-        htmlentities($resp->serialize()) . "</pre><hr/>\n");
57 
+    output('</pre><hr/>For nerds: I got this value back<br/><pre>'.
58 
+        htmlentities($resp->serialize())."</pre><hr/>\n");
59 59 
 } else {
60 60 
     output('An error occurred:<pre>');
61 
-    output('Code: ' . htmlspecialchars($resp->faultCode()) .
62 
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . "'</pre><hr/>");
61 
+    output('Code: '.htmlspecialchars($resp->faultCode()).
62 
+        "\nReason: '".htmlspecialchars($resp->faultString())."'</pre><hr/>");
63 63 
 }
64 64
65 65 
 output("</body></html>\n");
Please login to merge, or discard this patch.
demo/client/introspect.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>phpxmlrpc - Introspect demo</title></head>
 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
 function display_error($r)
18 18 
 {
19 19 
     output("An error occurred: ");
20 
-    output("Code: " . $r->faultCode() . " Reason: '" . $r->faultString() . "'<br/>");
20 
+    output("Code: ".$r->faultCode()." Reason: '".$r->faultString()."'<br/>");
21 21 
 }
22 22
23 23 
 $client = new Client(XMLRPCSERVER);
 
@@ -25,7 +25,7 @@  discard block
 
 block discarded – undo
25 25 
 $client->return_type = XMLRPCParser::RETURN_PHP;
26 26
27 27 
 // First off, let's retrieve the list of methods available on the remote server
28 
-output("<h3>methods available at http://" . $client->server . $client->path . "</h3>\n");
28 
+output("<h3>methods available at http://".$client->server.$client->path."</h3>\n");
29 29 
 $req = new Request('system.listMethods');
30 30 
 $resp = $client->send($req);
31 31 
 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47
48 48 
     // Then, retrieve the signature and help text of each available method
49 49 
     foreach ($v as $methodName) {
50 
-        output("<h4>" . htmlspecialchars($methodName) . "</h4>\n");
50 
+        output("<h4>".htmlspecialchars($methodName)."</h4>\n");
51 51 
         // build requests first, add params later
52 52 
         $r1 = new PhpXmlRpc\Request('system.methodHelp');
53 53 
         $r2 = new PhpXmlRpc\Request('system.methodSignature');
 
@@ -83,12 +83,12 @@  discard block
 
 block discarded – undo
83 83 
                         continue;
84 84 
                     }
85 85 
                     $ret = $sig[0];
86 
-                    output("<code>" . htmlspecialchars($ret) . " "
87 
-                        . htmlspecialchars($methodName) . "(");
88 
-                    if (count($sig) > 1) {
89 
-                        for ($k = 1; $k < count($sig); $k++) {
86 
+                    output("<code>".htmlspecialchars($ret)." "
87 
+                        . htmlspecialchars($methodName)."(");
88 
+                    if (count($sig)>1) {
89 
+                        for ($k = 1; $k<count($sig); $k++) {
90 90 
                             output(htmlspecialchars($sig[$k]));
91 
-                            if ($k < count($sig) - 1) {
91 
+                            if ($k<count($sig)-1) {
92 92 
                                 output(", ");
93 93 
                             }
94 94 
                         }
Please login to merge, or discard this patch.
demo/server/methodProviders/wrapper.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -26,7 +26,7 @@
 
 block discarded – undo
26 26 
  */
27 27 
 function plain_findstate($stateNo)
28 28 
 {
29 
-     if (isset(exampleMethods::$stateNames[$stateNo - 1])) {
29 
+        if (isset(exampleMethods::$stateNames[$stateNo - 1])) {
30 30 
         return exampleMethods::$stateNames[$stateNo - 1];
31 31 
     } else {
32 32 
         // not, there so complain
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -26,11 +26,11 @@  discard block
 
 block discarded – undo
26 26 
  */
27 27 
 function plain_findstate($stateNo)
28 28 
 {
29 
-     if (isset(exampleMethods::$stateNames[$stateNo - 1])) {
30 
-        return exampleMethods::$stateNames[$stateNo - 1];
29 
+     if (isset(exampleMethods::$stateNames[$stateNo-1])) {
30 
+        return exampleMethods::$stateNames[$stateNo-1];
31 31 
     } else {
32 32 
         // not, there so complain
33 
-        throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
33 
+        throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
34 34 
     }
35 35 
 }
36 36 
 
@@ -124,13 +124,13 @@  discard block
 
 block discarded – undo
124 124
125 125 
 $findstate10_sig = array(
126 126 
     /// @todo add a demo and test with closure usage
127 
-    "function" => function ($req) { return exampleMethods::findState($req); },
127 
+    "function" => function($req) { return exampleMethods::findState($req); },
128 128 
     "signature" => array(array(Value::$xmlrpcString, Value::$xmlrpcInt)),
129 
-    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the ' .
129 
+    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the '.
130 130 
         'index of that state name in an alphabetic order.',
131 131 
 );
132 132
133 
-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return plain_findstate($stateNo); });
133 
+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return plain_findstate($stateNo); });
134 134
135 135 
 /// @todo do we really need a new instance ?
136 136 
 $c = new handlersContainer();
 
@@ -139,7 +139,7 @@  discard block
 
 block discarded – undo
139 139
140 140 
 $namespaceSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'namespacetest.', 'replace_class_name' => true, 'method_filter' => '/^findState$/', 'method_type' => 'static'));
141 141
142 
-$returnObj_sig =  $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
142 
+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
143 143
144 144 
 return array_merge(
145 145 
     array(
Please login to merge, or discard this patch.
demo/client/codegen.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 /**
5 5 
  * Demoing the code-generation capabilities of the library: create a client class which exposes a bunch of methods
 
@@ -21,12 +21,12 @@  discard block
 
 block discarded – undo
21 21 
 );
22 22
23 23 
 // the generated code does not have an autoloader included - we need to add in one
24 
-$autoloader = __DIR__ . "/_prepend.php";
24 
+$autoloader = __DIR__."/_prepend.php";
25 25
26 26 
 $targetFile = '/tmp/MyClient.php';
27 27 
 $generated = file_put_contents($targetFile,
28 
-    "<?php\n\n" .
29 
-    "require_once '$autoloader';\n\n" .
28 
+    "<?php\n\n".
29 
+    "require_once '$autoloader';\n\n".
30 30 
     $code['code']
31 31 
 );
32 32 
 
@@ -46,8 +46,8 @@  discard block
 
 block discarded – undo
46 46 
 $client = new MyClient();
47 47 
 $sorted = $client->examples_sortByAge(array(
48 48 
     array('name' => 'Dave', 'age' => 24),
49 
-    array('name' => 'Edd',  'age' => 45),
50 
-    array('name' => 'Joe',  'age' => 37),
49 
+    array('name' => 'Edd', 'age' => 45),
50 
+    array('name' => 'Joe', 'age' => 37),
51 51 
     array('name' => 'Fred', 'age' => 27),
52 52 
 ));
53 53
Please login to merge, or discard this patch.
demo/server/codegen.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 require_once __DIR__.'/methodProviders/CommentManager.php';
5 5 
 
@@ -22,19 +22,19 @@  discard block
 
 block discarded – undo
22 22 
 // generate a file with a class definition
23 23
24 24 
 // the generated code does not have an autoloader included - we need to add in one
25 
-$autoloader = __DIR__ . "/_prepend.php";
25 
+$autoloader = __DIR__."/_prepend.php";
26 26
27 27 
 file_put_contents($targetClassFile,
28 
-    "<?php\n\n" .
29 
-    "require_once '$autoloader';\n\n" .
28 
+    "<?php\n\n".
29 
+    "require_once '$autoloader';\n\n".
30 30 
     "class MyServerClass {\n\n"
31 31 
 ) || die('uh oh');
32 32
33 33 
 // we mangle a bit the code we get from wrapPhpClass to generate a php class instead of a bunch of functions
34 34
35 
-foreach($code as $methodName => $methodDef) {
36 
-    file_put_contents($targetClassFile, 'public static ' . $methodDef['source'] . "\n\n", FILE_APPEND) || die('uh oh');
37 
-    $code[$methodName]['function'] = 'MyServerClass::' . $methodDef['function'];
35 
+foreach ($code as $methodName => $methodDef) {
36 
+    file_put_contents($targetClassFile, 'public static '.$methodDef['source']."\n\n", FILE_APPEND) || die('uh oh');
37 
+    $code[$methodName]['function'] = 'MyServerClass::'.$methodDef['function'];
38 38 
     unset($code[$methodName]['source']);
39 39 
 }
40 40 
 file_put_contents($targetClassFile, "}\n", FILE_APPEND) || die('uh oh');
 
@@ -42,11 +42,11 @@  discard block
 
 block discarded – undo
42 42 
 // generate the separate file with the xml-rpc server and dispatch map
43 43
44 44 
 file_put_contents($targetServerFile,
45 
-    "<?php\n\n" .
45 
+    "<?php\n\n".
46 46
47 
-    "require_once '$autoloader';\n\n" .
47 
+    "require_once '$autoloader';\n\n".
48 48
49 
-    "require_once '$targetClassFile';\n\n" .
49 
+    "require_once '$targetClassFile';\n\n".
50 50
51 51 
     // NB: since we are running the generated code within the same script, the existing CommentManager instance will be
52 52 
     // available for usage by the methods of MyServerClass, as we keep a reference to them within the variable Wrapper::$objHolder
 
@@ -56,11 +56,11 @@  discard block
 
 block discarded – undo
56 56 
     //     Wrapper::$objHolder['xmlrpc_CommentManager_addComment'] = $cm;
57 57 
     //     Wrapper::$objHolder['xmlrpc_CommentManager_getComments'] = $cm;
58 58
59 
-    '$dm = ' . var_export($code, true) . ";\n" .
60 
-    '$s = new \PhpXmlRpc\Server($dm, false);' . "\n" .
61 
-    '$s->setDebug(2);' . "\n" .
62 
-    '$s->exception_handling = 1;' . "\n" .
63 
-    '$s->service();' . "\n"
59 
+    '$dm = '.var_export($code, true).";\n".
60 
+    '$s = new \PhpXmlRpc\Server($dm, false);'."\n".
61 
+    '$s->setDebug(2);'."\n".
62 
+    '$s->exception_handling = 1;'."\n".
63 
+    '$s->service();'."\n"
64 64 
 ) || die('uh oh');
65 65
66 66 
 // test that everything worked by running it in realtime
Please login to merge, or discard this patch.
demo/server/server.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
     die();
22 22 
 }
23 23
24 
-require_once __DIR__ . "/_prepend.php";
24 
+require_once __DIR__."/_prepend.php";
25 25
26 26 
 use PhpXmlRpc\PhpXmlRpc;
27 27 
 use PhpXmlRpc\Server;
 
@@ -80,7 +80,7 @@  discard block
 
 block discarded – undo
80 80 
         } elseif ($_GET['FORCE_AUTH'] == 'Digest') {
81 81 
             if (empty($_SERVER['PHP_AUTH_DIGEST'])) {
82 82 
                 header('HTTP/1.1 401 Unauthorized');
83 
-                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="' . uniqid() . '",opaque="' . md5('Phpxmlrpc Digest Realm') . '"');
83 
+                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="'.uniqid().'",opaque="'.md5('Phpxmlrpc Digest Realm').'"');
84 84 
                 die('Text visible if user hits Cancel button');
85 85 
             }
86 86 
         }
Please login to merge, or discard this patch.