@@ -24,12 +24,12 @@ discard block |
||
| 24 | 24 | |
| 25 | 25 | // read chunk-size, chunk-extension (if any) and crlf |
| 26 | 26 | // get the position of the linebreak |
| 27 | - $chunkEnd = strpos($buffer, "\r\n") + 2; |
|
| 27 | + $chunkEnd = strpos($buffer, "\r\n")+2; |
|
| 28 | 28 | $temp = substr($buffer, 0, $chunkEnd); |
| 29 | 29 | $chunkSize = hexdec(trim($temp)); |
| 30 | 30 | $chunkStart = $chunkEnd; |
| 31 | - while ($chunkSize > 0) { |
|
| 32 | - $chunkEnd = strpos($buffer, "\r\n", $chunkStart + $chunkSize); |
|
| 31 | + while ($chunkSize>0) { |
|
| 32 | + $chunkEnd = strpos($buffer, "\r\n", $chunkStart+$chunkSize); |
|
| 33 | 33 | |
| 34 | 34 | // just in case we got a broken connection |
| 35 | 35 | if ($chunkEnd == false) { |
@@ -41,19 +41,19 @@ discard block |
||
| 41 | 41 | } |
| 42 | 42 | |
| 43 | 43 | // read chunk-data and crlf |
| 44 | - $chunk = substr($buffer, $chunkStart, $chunkEnd - $chunkStart); |
|
| 44 | + $chunk = substr($buffer, $chunkStart, $chunkEnd-$chunkStart); |
|
| 45 | 45 | // append chunk-data to entity-body |
| 46 | 46 | $new .= $chunk; |
| 47 | 47 | // length := length + chunk-size |
| 48 | 48 | $length += strlen($chunk); |
| 49 | 49 | // read chunk-size and crlf |
| 50 | - $chunkStart = $chunkEnd + 2; |
|
| 50 | + $chunkStart = $chunkEnd+2; |
|
| 51 | 51 | |
| 52 | - $chunkEnd = strpos($buffer, "\r\n", $chunkStart) + 2; |
|
| 52 | + $chunkEnd = strpos($buffer, "\r\n", $chunkStart)+2; |
|
| 53 | 53 | if ($chunkEnd == false) { |
| 54 | 54 | break; // just in case we got a broken connection |
| 55 | 55 | } |
| 56 | - $temp = substr($buffer, $chunkStart, $chunkEnd - $chunkStart); |
|
| 56 | + $temp = substr($buffer, $chunkStart, $chunkEnd-$chunkStart); |
|
| 57 | 57 | $chunkSize = hexdec(trim($temp)); |
| 58 | 58 | $chunkStart = $chunkEnd; |
| 59 | 59 | } |
@@ -83,11 +83,11 @@ discard block |
||
| 83 | 83 | // Look for CR/LF or simple LF as line separator (even though it is not valid http) |
| 84 | 84 | $pos = strpos($data, "\r\n\r\n"); |
| 85 | 85 | if ($pos || is_int($pos)) { |
| 86 | - $bd = $pos + 4; |
|
| 86 | + $bd = $pos+4; |
|
| 87 | 87 | } else { |
| 88 | 88 | $pos = strpos($data, "\n\n"); |
| 89 | 89 | if ($pos || is_int($pos)) { |
| 90 | - $bd = $pos + 2; |
|
| 90 | + $bd = $pos+2; |
|
| 91 | 91 | } else { |
| 92 | 92 | // No separation between response headers and body: fault? |
| 93 | 93 | $bd = 0; |
@@ -97,8 +97,8 @@ discard block |
||
| 97 | 97 | // this filters out all http headers from proxy. maybe we could take them into account, too? |
| 98 | 98 | $data = substr($data, $bd); |
| 99 | 99 | } else { |
| 100 | - Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': HTTPS via proxy error, tunnel connection possibly failed'); |
|
| 101 | - throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'] . ' (HTTPS via proxy error, tunnel connection possibly failed)', PhpXmlRpc::$xmlrpcerr['http_error']); |
|
| 100 | + Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': HTTPS via proxy error, tunnel connection possibly failed'); |
|
| 101 | + throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'].' (HTTPS via proxy error, tunnel connection possibly failed)', PhpXmlRpc::$xmlrpcerr['http_error']); |
|
| 102 | 102 | } |
| 103 | 103 | } |
| 104 | 104 | |
@@ -131,19 +131,19 @@ discard block |
||
| 131 | 131 | } |
| 132 | 132 | |
| 133 | 133 | if ($httpResponse['status_code'] !== '200') { |
| 134 | - $errstr = substr($data, 0, strpos($data, "\n") - 1); |
|
| 135 | - Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': HTTP error, got response: ' . $errstr); |
|
| 136 | - throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'] . ' (' . $errstr . ')', PhpXmlRpc::$xmlrpcerr['http_error'], null, $httpResponse['status_code']); |
|
| 134 | + $errstr = substr($data, 0, strpos($data, "\n")-1); |
|
| 135 | + Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': HTTP error, got response: '.$errstr); |
|
| 136 | + throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'].' ('.$errstr.')', PhpXmlRpc::$xmlrpcerr['http_error'], null, $httpResponse['status_code']); |
|
| 137 | 137 | } |
| 138 | 138 | |
| 139 | 139 | // be tolerant to usage of \n instead of \r\n to separate headers and data (even though it is not valid http) |
| 140 | 140 | $pos = strpos($data, "\r\n\r\n"); |
| 141 | 141 | if ($pos || is_int($pos)) { |
| 142 | - $bd = $pos + 4; |
|
| 142 | + $bd = $pos+4; |
|
| 143 | 143 | } else { |
| 144 | 144 | $pos = strpos($data, "\n\n"); |
| 145 | 145 | if ($pos || is_int($pos)) { |
| 146 | - $bd = $pos + 2; |
|
| 146 | + $bd = $pos+2; |
|
| 147 | 147 | } else { |
| 148 | 148 | // No separation between response headers and body: fault? |
| 149 | 149 | // we could take some action here instead of going on... |
@@ -157,7 +157,7 @@ discard block |
||
| 157 | 157 | foreach ($ar as $line) { |
| 158 | 158 | // take care of multi-line headers and cookies |
| 159 | 159 | $arr = explode(':', $line, 2); |
| 160 | - if (count($arr) > 1) { |
|
| 160 | + if (count($arr)>1) { |
|
| 161 | 161 | $headerName = strtolower(trim($arr[0])); |
| 162 | 162 | /// @todo some other headers (the ones that allow a CSV list of values) do allow many values to be |
| 163 | 163 | /// passed using multiple header lines. |
@@ -174,7 +174,7 @@ discard block |
||
| 174 | 174 | foreach ($cookies as $cookie) { |
| 175 | 175 | // glue together all received cookies, using a comma to separate them (same as php does with getallheaders()) |
| 176 | 176 | if (isset($httpResponse['headers'][$headerName])) { |
| 177 | - $httpResponse['headers'][$headerName] .= ', ' . trim($cookie); |
|
| 177 | + $httpResponse['headers'][$headerName] .= ', '.trim($cookie); |
|
| 178 | 178 | } else { |
| 179 | 179 | $httpResponse['headers'][$headerName] = trim($cookie); |
| 180 | 180 | } |
@@ -203,7 +203,7 @@ discard block |
||
| 203 | 203 | } |
| 204 | 204 | } elseif (isset($headerName)) { |
| 205 | 205 | /// @todo version1 cookies might span multiple lines, thus breaking the parsing above |
| 206 | - $httpResponse['headers'][$headerName] .= ' ' . trim($line); |
|
| 206 | + $httpResponse['headers'][$headerName] .= ' '.trim($line); |
|
| 207 | 207 | } |
| 208 | 208 | } |
| 209 | 209 | |
@@ -226,7 +226,7 @@ discard block |
||
| 226 | 226 | // Decode chunked encoding sent by http 1.1 servers |
| 227 | 227 | if (isset($httpResponse['headers']['transfer-encoding']) && $httpResponse['headers']['transfer-encoding'] == 'chunked') { |
| 228 | 228 | if (!$data = static::decodeChunked($data)) { |
| 229 | - Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': errors occurred when trying to rebuild the chunked data received from server'); |
|
| 229 | + Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': errors occurred when trying to rebuild the chunked data received from server'); |
|
| 230 | 230 | throw new HttpException(PhpXmlRpc::$xmlrpcstr['dechunk_fail'], PhpXmlRpc::$xmlrpcerr['dechunk_fail'], null, $httpResponse['status_code']); |
| 231 | 231 | } |
| 232 | 232 | } |
@@ -241,19 +241,19 @@ discard block |
||
| 241 | 241 | if ($httpResponse['headers']['content-encoding'] == 'deflate' && $degzdata = @gzuncompress($data)) { |
| 242 | 242 | $data = $degzdata; |
| 243 | 243 | if ($debug) { |
| 244 | - Logger::instance()->debugMessage("---INFLATED RESPONSE---[" . strlen($data) . " chars]---\n$data\n---END---"); |
|
| 244 | + Logger::instance()->debugMessage("---INFLATED RESPONSE---[".strlen($data)." chars]---\n$data\n---END---"); |
|
| 245 | 245 | } |
| 246 | 246 | } elseif ($httpResponse['headers']['content-encoding'] == 'gzip' && $degzdata = @gzinflate(substr($data, 10))) { |
| 247 | 247 | $data = $degzdata; |
| 248 | 248 | if ($debug) { |
| 249 | - Logger::instance()->debugMessage("---INFLATED RESPONSE---[" . strlen($data) . " chars]---\n$data\n---END---"); |
|
| 249 | + Logger::instance()->debugMessage("---INFLATED RESPONSE---[".strlen($data)." chars]---\n$data\n---END---"); |
|
| 250 | 250 | } |
| 251 | 251 | } else { |
| 252 | - Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': errors occurred when trying to decode the deflated data received from server'); |
|
| 252 | + Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': errors occurred when trying to decode the deflated data received from server'); |
|
| 253 | 253 | throw new HttpException(PhpXmlRpc::$xmlrpcstr['decompress_fail'], PhpXmlRpc::$xmlrpcerr['decompress_fail'], null, $httpResponse['status_code']); |
| 254 | 254 | } |
| 255 | 255 | } else { |
| 256 | - Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': the server sent deflated data. Your php install must have the Zlib extension compiled in to support this.'); |
|
| 256 | + Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': the server sent deflated data. Your php install must have the Zlib extension compiled in to support this.'); |
|
| 257 | 257 | throw new HttpException(PhpXmlRpc::$xmlrpcstr['cannot_decompress'], PhpXmlRpc::$xmlrpcerr['cannot_decompress'], null, $httpResponse['status_code']); |
| 258 | 258 | } |
| 259 | 259 | } |
@@ -92,9 +92,9 @@ discard block |
||
| 92 | 92 | public function xml_header($charsetEncoding = '') |
| 93 | 93 | { |
| 94 | 94 | if ($charsetEncoding != '') { |
| 95 | - return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\" ?" . ">\n<methodCall>\n"; |
|
| 95 | + return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\" ?".">\n<methodCall>\n"; |
|
| 96 | 96 | } else { |
| 97 | - return "<?xml version=\"1.0\"?" . ">\n<methodCall>\n"; |
|
| 97 | + return "<?xml version=\"1.0\"?".">\n<methodCall>\n"; |
|
| 98 | 98 | } |
| 99 | 99 | } |
| 100 | 100 | |
@@ -116,16 +116,16 @@ discard block |
||
| 116 | 116 | public function createPayload($charsetEncoding = '') |
| 117 | 117 | { |
| 118 | 118 | if ($charsetEncoding != '') { |
| 119 | - $this->content_type = 'text/xml; charset=' . $charsetEncoding; |
|
| 119 | + $this->content_type = 'text/xml; charset='.$charsetEncoding; |
|
| 120 | 120 | } else { |
| 121 | 121 | $this->content_type = 'text/xml'; |
| 122 | 122 | } |
| 123 | 123 | $this->payload = $this->xml_header($charsetEncoding); |
| 124 | - $this->payload .= '<methodName>' . $this->getCharsetEncoder()->encodeEntities( |
|
| 125 | - $this->methodname, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</methodName>\n"; |
|
| 124 | + $this->payload .= '<methodName>'.$this->getCharsetEncoder()->encodeEntities( |
|
| 125 | + $this->methodname, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</methodName>\n"; |
|
| 126 | 126 | $this->payload .= "<params>\n"; |
| 127 | 127 | foreach ($this->params as $p) { |
| 128 | - $this->payload .= "<param>\n" . $p->serialize($charsetEncoding) . |
|
| 128 | + $this->payload .= "<param>\n".$p->serialize($charsetEncoding). |
|
| 129 | 129 | "</param>\n"; |
| 130 | 130 | } |
| 131 | 131 | $this->payload .= "</params>\n"; |
@@ -253,7 +253,7 @@ discard block |
||
| 253 | 253 | $this->httpResponse = array('raw_data' => $data, 'headers' => array(), 'cookies' => array()); |
| 254 | 254 | |
| 255 | 255 | if ($data == '') { |
| 256 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': no response received from server.'); |
|
| 256 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': no response received from server.'); |
|
| 257 | 257 | return new Response(0, PhpXmlRpc::$xmlrpcerr['no_data'], PhpXmlRpc::$xmlrpcstr['no_data']); |
| 258 | 258 | } |
| 259 | 259 | |
@@ -266,7 +266,7 @@ discard block |
||
| 266 | 266 | // failed processing of HTTP response headers |
| 267 | 267 | // save into response obj the full payload received, for debugging |
| 268 | 268 | return new Response(0, $e->getCode(), $e->getMessage(), '', array('raw_data' => $data, 'status_code', $e->statusCode())); |
| 269 | - } catch(\Exception $e) { |
|
| 269 | + } catch (\Exception $e) { |
|
| 270 | 270 | return new Response(0, $e->getCode(), $e->getMessage(), '', array('raw_data' => $data)); |
| 271 | 271 | } |
| 272 | 272 | } |
@@ -280,7 +280,7 @@ discard block |
||
| 280 | 280 | // idea from Luca Mariano <[email protected]> originally in PEARified version of the lib |
| 281 | 281 | $pos = strrpos($data, '</methodResponse>'); |
| 282 | 282 | if ($pos !== false) { |
| 283 | - $data = substr($data, 0, $pos + 17); |
|
| 283 | + $data = substr($data, 0, $pos+17); |
|
| 284 | 284 | } |
| 285 | 285 | |
| 286 | 286 | // try to 'guestimate' the character encoding of the received response |
@@ -294,9 +294,9 @@ discard block |
||
| 294 | 294 | if ($start) { |
| 295 | 295 | $start += strlen('<!-- SERVER DEBUG INFO (BASE64 ENCODED):'); |
| 296 | 296 | $end = strpos($data, '-->', $start); |
| 297 | - $comments = substr($data, $start, $end - $start); |
|
| 298 | - $this->getLogger()->debugMessage("---SERVER DEBUG INFO (DECODED) ---\n\t" . |
|
| 299 | - str_replace("\n", "\n\t", base64_decode($comments)) . "\n---END---", $respEncoding); |
|
| 297 | + $comments = substr($data, $start, $end-$start); |
|
| 298 | + $this->getLogger()->debugMessage("---SERVER DEBUG INFO (DECODED) ---\n\t". |
|
| 299 | + str_replace("\n", "\n\t", base64_decode($comments))."\n---END---", $respEncoding); |
|
| 300 | 300 | } |
| 301 | 301 | } |
| 302 | 302 | |
@@ -318,7 +318,7 @@ discard block |
||
| 318 | 318 | if ($respEncoding == 'ISO-8859-1') { |
| 319 | 319 | $data = utf8_encode($data); |
| 320 | 320 | } else { |
| 321 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': invalid charset encoding of received response: ' . $respEncoding); |
|
| 321 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': invalid charset encoding of received response: '.$respEncoding); |
|
| 322 | 322 | } |
| 323 | 323 | } |
| 324 | 324 | } |
@@ -339,12 +339,12 @@ discard block |
||
| 339 | 339 | $xmlRpcParser->parse($data, $returnType, XMLParser::ACCEPT_RESPONSE, $options); |
| 340 | 340 | |
| 341 | 341 | // first error check: xml not well-formed |
| 342 | - if ($xmlRpcParser->_xh['isf'] > 2) { |
|
| 342 | + if ($xmlRpcParser->_xh['isf']>2) { |
|
| 343 | 343 | |
| 344 | 344 | // BC break: in the past for some cases we used the error message: 'XML error at line 1, check URL' |
| 345 | 345 | |
| 346 | 346 | $r = new Response(0, PhpXmlRpc::$xmlrpcerr['invalid_xml'], |
| 347 | - PhpXmlRpc::$xmlrpcstr['invalid_xml'] . ' ' . $xmlRpcParser->_xh['isf_reason'], '', |
|
| 347 | + PhpXmlRpc::$xmlrpcstr['invalid_xml'].' '.$xmlRpcParser->_xh['isf_reason'], '', |
|
| 348 | 348 | $this->httpResponse |
| 349 | 349 | ); |
| 350 | 350 | |
@@ -355,7 +355,7 @@ discard block |
||
| 355 | 355 | // second error check: xml well-formed but not xml-rpc compliant |
| 356 | 356 | elseif ($xmlRpcParser->_xh['isf'] == 2) { |
| 357 | 357 | $r = new Response(0, PhpXmlRpc::$xmlrpcerr['xml_not_compliant'], |
| 358 | - PhpXmlRpc::$xmlrpcstr['xml_not_compliant'] . ' ' . $xmlRpcParser->_xh['isf_reason'], '', |
|
| 358 | + PhpXmlRpc::$xmlrpcstr['xml_not_compliant'].' '.$xmlRpcParser->_xh['isf_reason'], '', |
|
| 359 | 359 | $this->httpResponse |
| 360 | 360 | ); |
| 361 | 361 | |
@@ -371,7 +371,7 @@ discard block |
||
| 371 | 371 | '', $this->httpResponse |
| 372 | 372 | ); |
| 373 | 373 | } else { |
| 374 | - if ($this->debug > 1) { |
|
| 374 | + if ($this->debug>1) { |
|
| 375 | 375 | $this->getLogger()->debugMessage( |
| 376 | 376 | "---PARSED---\n".var_export($xmlRpcParser->_xh['value'], true)."\n---END---" |
| 377 | 377 | ); |
@@ -119,7 +119,7 @@ discard block |
||
| 119 | 119 | $this->me['struct'] = $val; |
| 120 | 120 | break; |
| 121 | 121 | default: |
| 122 | - $this->getLogger()->errorLog("XML-RPC: " . __METHOD__ . ": not a known type ($type)"); |
|
| 122 | + $this->getLogger()->errorLog("XML-RPC: ".__METHOD__.": not a known type ($type)"); |
|
| 123 | 123 | } |
| 124 | 124 | } |
| 125 | 125 | } |
@@ -144,7 +144,7 @@ discard block |
||
| 144 | 144 | } |
| 145 | 145 | |
| 146 | 146 | if ($typeOf !== 1) { |
| 147 | - $this->getLogger()->errorLog("XML-RPC: " . __METHOD__ . ": not a scalar type ($type)"); |
|
| 147 | + $this->getLogger()->errorLog("XML-RPC: ".__METHOD__.": not a scalar type ($type)"); |
|
| 148 | 148 | return 0; |
| 149 | 149 | } |
| 150 | 150 | |
@@ -161,10 +161,10 @@ discard block |
||
| 161 | 161 | |
| 162 | 162 | switch ($this->mytype) { |
| 163 | 163 | case 1: |
| 164 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': scalar xmlrpc value can have only one value'); |
|
| 164 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': scalar xmlrpc value can have only one value'); |
|
| 165 | 165 | return 0; |
| 166 | 166 | case 3: |
| 167 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': cannot add anonymous scalar to struct xmlrpc value'); |
|
| 167 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': cannot add anonymous scalar to struct xmlrpc value'); |
|
| 168 | 168 | return 0; |
| 169 | 169 | case 2: |
| 170 | 170 | // we're adding a scalar value to an array here |
@@ -206,7 +206,7 @@ discard block |
||
| 206 | 206 | |
| 207 | 207 | return 1; |
| 208 | 208 | } else { |
| 209 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']'); |
|
| 209 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']'); |
|
| 210 | 210 | return 0; |
| 211 | 211 | } |
| 212 | 212 | } |
@@ -237,7 +237,7 @@ discard block |
||
| 237 | 237 | |
| 238 | 238 | return 1; |
| 239 | 239 | } else { |
| 240 | - $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']'); |
|
| 240 | + $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']'); |
|
| 241 | 241 | return 0; |
| 242 | 242 | } |
| 243 | 243 | } |
@@ -280,19 +280,19 @@ discard block |
||
| 280 | 280 | case 1: |
| 281 | 281 | switch ($typ) { |
| 282 | 282 | case static::$xmlrpcBase64: |
| 283 | - $rs .= "<{$typ}>" . base64_encode($val) . "</{$typ}>"; |
|
| 283 | + $rs .= "<{$typ}>".base64_encode($val)."</{$typ}>"; |
|
| 284 | 284 | break; |
| 285 | 285 | case static::$xmlrpcBoolean: |
| 286 | - $rs .= "<{$typ}>" . ($val ? '1' : '0') . "</{$typ}>"; |
|
| 286 | + $rs .= "<{$typ}>".($val ? '1' : '0')."</{$typ}>"; |
|
| 287 | 287 | break; |
| 288 | 288 | case static::$xmlrpcString: |
| 289 | 289 | // Do NOT use htmlentities, since it will produce named html entities, which are invalid xml |
| 290 | - $rs .= "<{$typ}>" . $this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</{$typ}>"; |
|
| 290 | + $rs .= "<{$typ}>".$this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</{$typ}>"; |
|
| 291 | 291 | break; |
| 292 | 292 | case static::$xmlrpcInt: |
| 293 | 293 | case static::$xmlrpcI4: |
| 294 | 294 | case static::$xmlrpcI8: |
| 295 | - $rs .= "<{$typ}>" . (int)$val . "</{$typ}>"; |
|
| 295 | + $rs .= "<{$typ}>".(int) $val."</{$typ}>"; |
|
| 296 | 296 | break; |
| 297 | 297 | case static::$xmlrpcDouble: |
| 298 | 298 | // avoid using standard conversion of float to string because it is locale-dependent, |
@@ -300,16 +300,16 @@ discard block |
||
| 300 | 300 | // sprintf('%F') could be most likely ok, but it fails eg. on 2e-14. |
| 301 | 301 | // The code below tries its best at keeping max precision while avoiding exp notation, |
| 302 | 302 | // but there is of course no limit in the number of decimal places to be used... |
| 303 | - $rs .= "<{$typ}>" . preg_replace('/\\.?0+$/', '', number_format((double)$val, PhpXmlRpc::$xmlpc_double_precision, '.', '')) . "</{$typ}>"; |
|
| 303 | + $rs .= "<{$typ}>".preg_replace('/\\.?0+$/', '', number_format((double) $val, PhpXmlRpc::$xmlpc_double_precision, '.', ''))."</{$typ}>"; |
|
| 304 | 304 | break; |
| 305 | 305 | case static::$xmlrpcDateTime: |
| 306 | 306 | if (is_string($val)) { |
| 307 | 307 | $rs .= "<{$typ}>{$val}</{$typ}>"; |
| 308 | 308 | // DateTimeInterface is not present in php 5.4... |
| 309 | 309 | } elseif (is_a($val, 'DateTimeInterface') || is_a($val, 'DateTime')) { |
| 310 | - $rs .= "<{$typ}>" . $val->format('Ymd\TH:i:s') . "</{$typ}>"; |
|
| 310 | + $rs .= "<{$typ}>".$val->format('Ymd\TH:i:s')."</{$typ}>"; |
|
| 311 | 311 | } elseif (is_int($val)) { |
| 312 | - $rs .= "<{$typ}>" . date('Ymd\TH:i:s', $val) . "</{$typ}>"; |
|
| 312 | + $rs .= "<{$typ}>".date('Ymd\TH:i:s', $val)."</{$typ}>"; |
|
| 313 | 313 | } else { |
| 314 | 314 | // not really a good idea here: but what should we output anyway? left for backward compat... |
| 315 | 315 | $rs .= "<{$typ}>{$val}</{$typ}>"; |
@@ -331,14 +331,14 @@ discard block |
||
| 331 | 331 | case 3: |
| 332 | 332 | // struct |
| 333 | 333 | if ($this->_php_class) { |
| 334 | - $rs .= '<struct php_class="' . $this->_php_class . "\">\n"; |
|
| 334 | + $rs .= '<struct php_class="'.$this->_php_class."\">\n"; |
|
| 335 | 335 | } else { |
| 336 | 336 | $rs .= "<struct>\n"; |
| 337 | 337 | } |
| 338 | 338 | $charsetEncoder = $this->getCharsetEncoder(); |
| 339 | 339 | /** @var Value $val2 */ |
| 340 | 340 | foreach ($val as $key2 => $val2) { |
| 341 | - $rs .= '<member><name>' . $charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</name>\n"; |
|
| 341 | + $rs .= '<member><name>'.$charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</name>\n"; |
|
| 342 | 342 | //$rs.=$this->serializeval($val2); |
| 343 | 343 | $rs .= $val2->serialize($charsetEncoding); |
| 344 | 344 | $rs .= "</member>\n"; |
@@ -374,7 +374,7 @@ discard block |
||
| 374 | 374 | $val = reset($this->me); |
| 375 | 375 | $typ = key($this->me); |
| 376 | 376 | |
| 377 | - return '<value>' . $this->serializedata($typ, $val, $charsetEncoding) . "</value>\n"; |
|
| 377 | + return '<value>'.$this->serializedata($typ, $val, $charsetEncoding)."</value>\n"; |
|
| 378 | 378 | } |
| 379 | 379 | |
| 380 | 380 | /** |
@@ -1,5 +1,5 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | -require_once __DIR__ . "/_prepend.php"; |
|
| 2 | +require_once __DIR__."/_prepend.php"; |
|
| 3 | 3 | |
| 4 | 4 | use PhpXmlRpc\Encoder; |
| 5 | 5 | use PhpXmlRpc\Client; |
@@ -24,7 +24,7 @@ discard block |
||
| 24 | 24 | $handles = array(); |
| 25 | 25 | $curl = curl_multi_init(); |
| 26 | 26 | |
| 27 | - foreach($requests as $k => $req) { |
|
| 27 | + foreach ($requests as $k => $req) { |
|
| 28 | 28 | $req->setDebug($this->debug); |
| 29 | 29 | |
| 30 | 30 | $handle = $this->prepareCurlHandle( |
@@ -57,19 +57,19 @@ discard block |
||
| 57 | 57 | $running = 0; |
| 58 | 58 | do { |
| 59 | 59 | curl_multi_exec($curl, $running); |
| 60 | - } while($running > 0); |
|
| 60 | + } while ($running>0); |
|
| 61 | 61 | |
| 62 | 62 | $responses = array(); |
| 63 | - foreach($handles as $k => $h) { |
|
| 63 | + foreach ($handles as $k => $h) { |
|
| 64 | 64 | $responses[$k] = curl_multi_getcontent($handles[$k]); |
| 65 | 65 | |
| 66 | - if ($this->debug > 1) { |
|
| 66 | + if ($this->debug>1) { |
|
| 67 | 67 | $message = "---CURL INFO---\n"; |
| 68 | 68 | foreach (curl_getinfo($h) as $name => $val) { |
| 69 | 69 | if (is_array($val)) { |
| 70 | 70 | $val = implode("\n", $val); |
| 71 | 71 | } |
| 72 | - $message .= $name . ': ' . $val . "\n"; |
|
| 72 | + $message .= $name.': '.$val."\n"; |
|
| 73 | 73 | } |
| 74 | 74 | $message .= '---END---'; |
| 75 | 75 | $this->getLogger()->debugMessage($message); |
@@ -80,9 +80,9 @@ discard block |
||
| 80 | 80 | } |
| 81 | 81 | curl_multi_close($curl); |
| 82 | 82 | |
| 83 | - foreach($responses as $k => $resp) { |
|
| 83 | + foreach ($responses as $k => $resp) { |
|
| 84 | 84 | if (!$resp) { |
| 85 | - $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . curl_error($curl)); |
|
| 85 | + $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.curl_error($curl)); |
|
| 86 | 86 | } else { |
| 87 | 87 | $responses[$k] = $requests[$k]->parseResponse($resp, true, $this->return_type); |
| 88 | 88 | } |
@@ -99,7 +99,7 @@ discard block |
||
| 99 | 99 | $value = $encoder->encode($data, array('auto_dates')); |
| 100 | 100 | $req = new Request('interopEchoTests.echoValue', array($value)); |
| 101 | 101 | $reqs = array(); |
| 102 | -for ($i = 0; $i < $num_tests; $i++) { |
|
| 102 | +for ($i = 0; $i<$num_tests; $i++) { |
|
| 103 | 103 | $reqs[] = $req; |
| 104 | 104 | } |
| 105 | 105 | |
@@ -114,18 +114,18 @@ discard block |
||
| 114 | 114 | |
| 115 | 115 | $t = microtime(true); |
| 116 | 116 | $resp = $client->send($reqs); |
| 117 | -$t = microtime(true) - $t; |
|
| 118 | -echo "Sequential send: " . sprintf('%.3f', $t) . " secs.\n"; |
|
| 117 | +$t = microtime(true)-$t; |
|
| 118 | +echo "Sequential send: ".sprintf('%.3f', $t)." secs.\n"; |
|
| 119 | 119 | flush(); |
| 120 | 120 | |
| 121 | 121 | $t = microtime(true); |
| 122 | 122 | $resp = $client->sendParallel($reqs); |
| 123 | -$t = microtime(true) - $t; |
|
| 124 | -echo "Parallel send: " . sprintf('%.3f', $t) . " secs.\n"; |
|
| 123 | +$t = microtime(true)-$t; |
|
| 124 | +echo "Parallel send: ".sprintf('%.3f', $t)." secs.\n"; |
|
| 125 | 125 | flush(); |
| 126 | 126 | |
| 127 | 127 | $client->no_multicall = false; |
| 128 | 128 | $t = microtime(true); |
| 129 | 129 | $resp = $client->send($reqs); |
| 130 | -$t = microtime(true) - $t; |
|
| 131 | -echo "Multicall send: " . sprintf('%.3f', $t) . " secs.\n"; |
|
| 130 | +$t = microtime(true)-$t; |
|
| 131 | +echo "Multicall send: ".sprintf('%.3f', $t)." secs.\n"; |
|
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -include_once __DIR__ . '/WebTestCase.php'; |
|
| 3 | +include_once __DIR__.'/WebTestCase.php'; |
|
| 4 | 4 | |
| 5 | 5 | /** |
| 6 | 6 | * Tests for php files in the 'extras' directory |
@@ -13,8 +13,8 @@ discard block |
||
| 13 | 13 | $this->args = argParser::getArgs(); |
| 14 | 14 | |
| 15 | 15 | // assumes HTTPURI to be in the form /tests/index.php?etc... |
| 16 | - $this->baseUrl = $this->args['HTTPSERVER'] . preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 17 | - $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 16 | + $this->baseUrl = $this->args['HTTPSERVER'].preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 17 | + $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 18 | 18 | } |
| 19 | 19 | |
| 20 | 20 | public function testBenchmark() |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -include_once __DIR__ . '/WebTestCase.php'; |
|
| 3 | +include_once __DIR__.'/WebTestCase.php'; |
|
| 4 | 4 | |
| 5 | 5 | /** |
| 6 | 6 | * Tests for php files in the 'demo' directory |
@@ -12,8 +12,8 @@ discard block |
||
| 12 | 12 | $this->args = argParser::getArgs(); |
| 13 | 13 | |
| 14 | 14 | // assumes HTTPURI to be in the form /tests/index.php?etc... |
| 15 | - $this->baseUrl = $this->args['HTTPSERVER'] . preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 16 | - $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 15 | + $this->baseUrl = $this->args['HTTPSERVER'].preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 16 | + $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 17 | 17 | } |
| 18 | 18 | |
| 19 | 19 | public function testAgeSort() |
@@ -6,7 +6,7 @@ |
||
| 6 | 6 | * @license code licensed under the BSD License: see file license.txt |
| 7 | 7 | **/ |
| 8 | 8 | |
| 9 | -$coverageFile = realpath(__DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/phpunit_coverage.php"); |
|
| 9 | +$coverageFile = realpath(__DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/phpunit_coverage.php"); |
|
| 10 | 10 | |
| 11 | 11 | // has to be the same value as used in index.php |
| 12 | 12 | $GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'] = '/tmp/phpxmlrpc_coverage'; |
@@ -1,6 +1,6 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | |
| 3 | -include_once __DIR__ . '/WebTestCase.php'; |
|
| 3 | +include_once __DIR__.'/WebTestCase.php'; |
|
| 4 | 4 | |
| 5 | 5 | class DebuggerTest extends PhpXmlRpc_WebTestCase |
| 6 | 6 | { |
@@ -9,8 +9,8 @@ discard block |
||
| 9 | 9 | $this->args = argParser::getArgs(); |
| 10 | 10 | |
| 11 | 11 | // assumes HTTPURI to be in the form /tests/index.php?etc... |
| 12 | - $this->baseUrl = $this->args['HTTPSERVER'] . preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 13 | - $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 12 | + $this->baseUrl = $this->args['HTTPSERVER'].preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
| 13 | + $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
| 14 | 14 | } |
| 15 | 15 | |
| 16 | 16 | public function testIndex() |
@@ -46,7 +46,7 @@ discard block |
||
| 46 | 46 | // check for command line params (passed as env vars) vs. web page input params (passed as GET/POST) |
| 47 | 47 | // Note that the only usecase for web-page mode is when this is used by benchmark.php |
| 48 | 48 | if (!isset($_SERVER['REQUEST_METHOD'])) { |
| 49 | - foreach($_SERVER as $key => $val) { |
|
| 49 | + foreach ($_SERVER as $key => $val) { |
|
| 50 | 50 | if (array_key_exists($key, $args)) { |
| 51 | 51 | $$key = $val; |
| 52 | 52 | } |
@@ -91,7 +91,7 @@ discard block |
||
| 91 | 91 | //} |
| 92 | 92 | } |
| 93 | 93 | if ($HTTPURI[0] != '/') { |
| 94 | - $HTTPURI = '/' . $HTTPURI; |
|
| 94 | + $HTTPURI = '/'.$HTTPURI; |
|
| 95 | 95 | } |
| 96 | 96 | $args['HTTPURI'] = $HTTPURI; |
| 97 | 97 | |
@@ -105,21 +105,21 @@ discard block |
||
| 105 | 105 | } |
| 106 | 106 | |
| 107 | 107 | if (isset($HTTPSIGNOREPEER)) { |
| 108 | - $args['HTTPSIGNOREPEER'] = (bool)$HTTPSIGNOREPEER; |
|
| 108 | + $args['HTTPSIGNOREPEER'] = (bool) $HTTPSIGNOREPEER; |
|
| 109 | 109 | } |
| 110 | 110 | |
| 111 | 111 | if (isset($HTTPSVERIFYHOST)) { |
| 112 | - $args['HTTPSVERIFYHOST'] = (int)$HTTPSVERIFYHOST; |
|
| 112 | + $args['HTTPSVERIFYHOST'] = (int) $HTTPSVERIFYHOST; |
|
| 113 | 113 | } |
| 114 | 114 | |
| 115 | 115 | if (isset($SSLVERSION)) { |
| 116 | - $args['SSLVERSION'] = (int)$SSLVERSION; |
|
| 116 | + $args['SSLVERSION'] = (int) $SSLVERSION; |
|
| 117 | 117 | } |
| 118 | 118 | |
| 119 | 119 | if (isset($PROXYSERVER)) { |
| 120 | 120 | $arr = explode(':', $PROXYSERVER); |
| 121 | 121 | $args['PROXYSERVER'] = $arr[0]; |
| 122 | - if (count($arr) > 1) { |
|
| 122 | + if (count($arr)>1) { |
|
| 123 | 123 | $args['PROXYPORT'] = $arr[1]; |
| 124 | 124 | } else { |
| 125 | 125 | $args['PROXYPORT'] = 8080; |