Passed
Push — master ( 577871...2d5b6d )
by Gaetano
07:53
created
demo/server/server.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * Please _do not_ copy this file verbatim into your production server.
10 10
  */
11 11
 
12
-require_once __DIR__ . "/_prepend.php";
12
+require_once __DIR__."/_prepend.php";
13 13
 
14 14
 use PhpXmlRpc\PhpXmlRpc;
15 15
 use PhpXmlRpc\Response;
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         } elseif ($_GET['FORCE_AUTH'] == 'Digest') {
72 72
             if (empty($_SERVER['PHP_AUTH_DIGEST'])) {
73 73
                 header('HTTP/1.1 401 Unauthorized');
74
-                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="' . uniqid() . '",opaque="' . md5('Phpxmlrpc Digest Realm') . '"');
74
+                header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="'.uniqid().'",opaque="'.md5('Phpxmlrpc Digest Realm').'"');
75 75
                 die('Text visible if user hits Cancel button');
76 76
             }
77 77
         }
Please login to merge, or discard this patch.
demo/server/methodProviders/wrapper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
 {
29 29
     global $stateNames;
30 30
 
31
-    if (isset($stateNames[$stateNo - 1])) {
32
-        return $stateNames[$stateNo - 1];
31
+    if (isset($stateNames[$stateNo-1])) {
32
+        return $stateNames[$stateNo-1];
33 33
     } else {
34 34
         // not, there so complain
35
-        throw new Exception("I don't have a state for the index '" . $stateNo . "'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
35
+        throw new Exception("I don't have a state for the index '".$stateNo."'", PhpXmlRpc\PhpXmlRpc::$xmlrpcerruser);
36 36
     }
37 37
 }
38 38
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
126 126
 
127 127
 $findstate10_sig = array(
128 128
     /// @todo add a demo and test with closure usage
129
-    "function" => function ($req) { return findState($req); },
129
+    "function" => function($req) { return findState($req); },
130 130
     "signature" => array(array(Value::$xmlrpcString, Value::$xmlrpcInt)),
131
-    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the ' .
131
+    "docstring" => 'When passed an integer between 1 and 51 returns the name of a US state, where the integer is the '.
132 132
         'index of that state name in an alphabetic order.',
133 133
 );
134 134
 
135
-$findstate11_sig = $wrapper->wrapPhpFunction(function ($stateNo) { return plain_findstate($stateNo); });
135
+$findstate11_sig = $wrapper->wrapPhpFunction(function($stateNo) { return plain_findstate($stateNo); });
136 136
 
137 137
 /// @todo do we really need a new instance ?
138 138
 $c = new xmlrpcServerMethodsContainer();
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 
142 142
 $namespaceSignatures = $wrapper->wrapPhpClass($c, array('prefix' => 'namespacetest.', 'replace_class_name' => true, 'method_filter' => '/^findState$/', 'method_type' => 'static'));
143 143
 
144
-$returnObj_sig =  $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
144
+$returnObj_sig = $wrapper->wrapPhpFunction(array($c, 'returnObject'), '', array('encode_php_objs' => true));
145 145
 
146 146
 return array_merge(
147 147
     array(
Please login to merge, or discard this patch.
demo/server/methodProviders/testsuite.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
 
92 92
     // Greek word 'kosme'. NB: NOT a valid ISO8859 string!
93 93
     // NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods
94
-    "tests.utf8methodname." . 'κόσμε' => array(
94
+    "tests.utf8methodname.".'κόσμε' => array(
95 95
         "function" => "stringEcho",
96 96
         "signature" => $stringecho_sig,
97 97
         //"docstring" => $stringecho_doc,
Please login to merge, or discard this patch.
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -66,11 +66,12 @@
 block discarded – undo
66 66
     $a = $req->getParam(0);
67 67
     $b = $req->getParam(1);
68 68
 
69
-    if ($a->scalartyp() == Value::$xmlrpcNull)
70
-        return new Response(new Value(plain_findstate($b->scalarval())));
71
-    else
72
-        return new Response(new Value(plain_findstate($a->scalarval())));
73
-}
69
+    if ($a->scalartyp() == Value::$xmlrpcNull) {
70
+            return new Response(new Value(plain_findstate($b->scalarval())));
71
+    } else {
72
+            return new Response(new Value(plain_findstate($a->scalarval())));
73
+    }
74
+    }
74 75
 
75 76
 return array(
76 77
     "tests.getallheaders" => array(
Please login to merge, or discard this patch.
demo/vardemo.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/client/_prepend.php";
2
+require_once __DIR__."/client/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc</title></head>
@@ -10,23 +10,23 @@  discard block
 block discarded – undo
10 10
 output("<p>Please note that in most cases you are better off using `new PhpXmlRpc\Encoder()->encode()` to create nested Value objects</p>\n");
11 11
 
12 12
 $v = new PhpXmlRpc\Value(1234, 'int');
13
-output("Int: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
13
+output("Int: <PRE>".htmlentities($v->serialize())."</PRE>");
14 14
 
15 15
 $v = new PhpXmlRpc\Value('Are the following characters escaped? < & >');
16
-output("String <PRE>" . htmlentities($v->serialize()) . "</PRE>");
16
+output("String <PRE>".htmlentities($v->serialize())."</PRE>");
17 17
 
18 18
 $v = new PhpXmlRpc\Value(true, 'boolean');
19
-output("Boolean: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
19
+output("Boolean: <PRE>".htmlentities($v->serialize())."</PRE>");
20 20
 
21 21
 $v = new PhpXmlRpc\Value(1234.5678, 'double');
22
-output("Double: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
22
+output("Double: <PRE>".htmlentities($v->serialize())."</PRE>");
23 23
 
24 24
 $v = new PhpXmlRpc\Value(time(), 'dateTime.iso8601');
25
-output("Datetime: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
25
+output("Datetime: <PRE>".htmlentities($v->serialize())."</PRE>");
26 26
 
27 27
 $v = new PhpXmlRpc\Value('hello world', 'base64');
28
-output("Base64: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
29
-output("(value of base64 string is: '" . $v->scalarval() . "')<BR><BR>");
28
+output("Base64: <PRE>".htmlentities($v->serialize())."</PRE>");
29
+output("(value of base64 string is: '".$v->scalarval()."')<BR><BR>");
30 30
 
31 31
 $v = new PhpXmlRpc\Value(
32 32
     array(
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     ),
40 40
     "array"
41 41
 );
42
-output("Array: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
42
+output("Array: <PRE>".htmlentities($v->serialize())."</PRE>");
43 43
 
44 44
 $v = new PhpXmlRpc\Value(
45 45
     array(
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
     ),
60 60
     "struct"
61 61
 );
62
-output("Struct: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
62
+output("Struct: <PRE>".htmlentities($v->serialize())."</PRE>");
63 63
 
64 64
 $w = new PhpXmlRpc\Value(array($v), 'array');
65
-output("Array containing a struct: <PRE>" . htmlentities($w->serialize()) . "</PRE>");
65
+output("Array containing a struct: <PRE>".htmlentities($w->serialize())."</PRE>");
66 66
 
67 67
 class MyClass
68 68
 {
@@ -74,46 +74,46 @@  discard block
 block discarded – undo
74 74
 // the public property is the only one which will be serialized. As such, it has to be of type Value
75 75
 $myObject->public = new \PhpXmlRpc\Value('a public property, wrapped');
76 76
 $w = new PhpXmlRpc\Value($myObject, 'struct');
77
-output("Struct encoding a php object: <PRE>" . htmlentities($w->serialize()) . "</PRE>");
77
+output("Struct encoding a php object: <PRE>".htmlentities($w->serialize())."</PRE>");
78 78
 
79 79
 output("<h3>Testing value serialization - xml-rpc extensions</h3>\n");
80 80
 $v = new PhpXmlRpc\Value(1234, 'i8');
81
-output("I8: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
81
+output("I8: <PRE>".htmlentities($v->serialize())."</PRE>");
82 82
 $v = new PhpXmlRpc\Value(null, 'null');
83
-output("Null: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
83
+output("Null: <PRE>".htmlentities($v->serialize())."</PRE>");
84 84
 \PhpXmlRpc\PhpXmlRpc::$xmlrpc_null_apache_encoding = true;
85
-output("Null, alternative: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
85
+output("Null, alternative: <PRE>".htmlentities($v->serialize())."</PRE>");
86 86
 
87 87
 output("<h3>Testing value serialization - character encoding</h3>\n");
88 88
 // The greek word 'kosme'
89 89
 $v = new PhpXmlRpc\Value('κόσμε');
90
-output("Greek (default encoding): <PRE>" . htmlentities($v->serialize()) . "</PRE>");
91
-output("Greek (utf8 encoding): <PRE>" . htmlentities($v->serialize('UTF-8')) . "</PRE>");
90
+output("Greek (default encoding): <PRE>".htmlentities($v->serialize())."</PRE>");
91
+output("Greek (utf8 encoding): <PRE>".htmlentities($v->serialize('UTF-8'))."</PRE>");
92 92
 
93 93
 output("<h3>Testing request serialization</h3>\n");
94 94
 $req = new PhpXmlRpc\Request('examples.getStateName');
95 95
 $req->method('examples.getStateName');
96 96
 $req->addParam(new PhpXmlRpc\Value(42, 'int'));
97
-output("<PRE>" . htmlentities($req->serialize()) . "</PRE>");
97
+output("<PRE>".htmlentities($req->serialize())."</PRE>");
98 98
 
99 99
 output("<h3>Testing response serialization</h3>\n");
100 100
 $resp = new PhpXmlRpc\Response(new PhpXmlRpc\Value('The meaning of life'));
101
-output("<PRE>" . htmlentities($resp->serialize()) . "</PRE>");
101
+output("<PRE>".htmlentities($resp->serialize())."</PRE>");
102 102
 
103 103
 output("<h3>Testing ISO date formatting</h3><pre>\n");
104 104
 $t = time();
105 105
 $date = PhpXmlRpc\Helper\Date::iso8601Encode($t);
106 106
 output("Now is $t --> $date\n");
107
-output("Or in UTC, that is " . PhpXmlRpc\Helper\Date::iso8601Encode($t, 1) . "\n");
107
+output("Or in UTC, that is ".PhpXmlRpc\Helper\Date::iso8601Encode($t, 1)."\n");
108 108
 $tb = PhpXmlRpc\Helper\Date::iso8601Decode($date);
109 109
 output("That is to say $date --> $tb\n");
110
-output("Which comes out at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb) . "\n");
111
-output("Which was the time in UTC at " . PhpXmlRpc\Helper\Date::iso8601Encode($tb, 1) . "\n");
110
+output("Which comes out at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb)."\n");
111
+output("Which was the time in UTC at ".PhpXmlRpc\Helper\Date::iso8601Encode($tb, 1)."\n");
112 112
 output("</pre>\n");
113 113
 
114 114
 output("<h3>Testing reduced-precision formatting for doubles</h3><pre>\n");
115 115
 $v = new PhpXmlRpc\Value(1234.56789, 'double');
116 116
 \PhpXmlRpc\PhpXmlRpc::$xmlpc_double_precision = 2;
117
-output("Double, limited precision: <PRE>" . htmlentities($v->serialize()) . "</PRE>");
117
+output("Double, limited precision: <PRE>".htmlentities($v->serialize())."</PRE>");
118 118
 
119 119
 output('</body></html>');
Please login to merge, or discard this patch.
demo/client/which.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Which toolkit demo</title></head>
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     <methodName>interopEchoTests.whichToolkit</methodName>
20 20
     <params/>
21 21
 </methodCall>';
22
-output("XML custom request:<br/><pre>" . htmlspecialchars($payload) . "</pre>\n");
22
+output("XML custom request:<br/><pre>".htmlspecialchars($payload)."</pre>\n");
23 23
 
24 24
 $client = new Client(XMLRPCSERVER);
25 25
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 if (!$resp->faultCode()) {
41 41
 
42 42
     $xml = $resp->value();
43
-    output("XML response:<br/><pre>" . htmlspecialchars($xml) . "</pre>\n");
43
+    output("XML response:<br/><pre>".htmlspecialchars($xml)."</pre>\n");
44 44
 
45 45
     $encoder = new Encoder();
46 46
     // from xml to xml-rpc Response
@@ -52,14 +52,14 @@  discard block
 block discarded – undo
52 52
 
53 53
     output("Toolkit info:<br/>\n");
54 54
     output("<pre>");
55
-    output("name: " . htmlspecialchars($value["toolkitName"]) . "\n");
56
-    output("version: " . htmlspecialchars($value["toolkitVersion"]) . "\n");
57
-    output("docs: " . htmlspecialchars($value["toolkitDocsUrl"]) . "\n");
58
-    output("os: " . htmlspecialchars($value["toolkitOperatingSystem"]) . "\n");
55
+    output("name: ".htmlspecialchars($value["toolkitName"])."\n");
56
+    output("version: ".htmlspecialchars($value["toolkitVersion"])."\n");
57
+    output("docs: ".htmlspecialchars($value["toolkitDocsUrl"])."\n");
58
+    output("os: ".htmlspecialchars($value["toolkitOperatingSystem"])."\n");
59 59
     output("</pre>");
60 60
 } else {
61 61
     output("An error occurred: ");
62
-    output("Code: " . htmlspecialchars($resp->faultCode()) . " Reason: '" . htmlspecialchars($resp->faultString()) . "'\n");
62
+    output("Code: ".htmlspecialchars($resp->faultCode())." Reason: '".htmlspecialchars($resp->faultString())."'\n");
63 63
 }
64 64
 
65 65
 output("</body></html>\n");
Please login to merge, or discard this patch.
demo/client/getstatename.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Getstatename demo</title></head>
@@ -17,13 +17,13 @@  discard block
 block discarded – undo
17 17
 $stateNo = "";
18 18
 
19 19
 if (isset($_POST['stateno']) && $_POST['stateno'] != "") {
20
-    $stateNo = (integer)$_POST['stateno'];
20
+    $stateNo = (integer) $_POST['stateno'];
21 21
     $method = 'examples.getStateName';
22 22
     $arguments = array(
23 23
         new Value($stateNo, Value::$xmlrpcInt),
24 24
     );
25 25
     $req = new Request($method, $arguments);
26
-    output("Sending the following request:<pre>\n\n" . htmlentities($req->serialize()) .
26
+    output("Sending the following request:<pre>\n\n".htmlentities($req->serialize()).
27 27
         "\n\n</pre>Debug info of server data follows...\n\n");
28 28
     $client = new Client(XMLRPCSERVER);
29 29
     $client->setDebug(1);
@@ -32,12 +32,12 @@  discard block
 block discarded – undo
32 32
         $val = $resp->value();
33 33
         // NB: we are _assuming_ that the server did return a scalar xml-rpc value here.
34 34
         // If the server is not trusted, we might check that via `$val->kindOf() == 'scalar'`
35
-        output('<br/>State number <b>' . $stateNo . '</b> is <b>'
36
-            . htmlspecialchars($val->scalarval()) . '</b><br/><br/>');
35
+        output('<br/>State number <b>'.$stateNo.'</b> is <b>'
36
+            . htmlspecialchars($val->scalarval()).'</b><br/><br/>');
37 37
     } else {
38 38
         output('An error occurred: ');
39
-        output('<pre>Code: ' . htmlspecialchars($resp->faultCode())
40
-            . " Reason: '" . htmlspecialchars($resp->faultString()) . "'</pre>");
39
+        output('<pre>Code: '.htmlspecialchars($resp->faultCode())
40
+            . " Reason: '".htmlspecialchars($resp->faultString())."'</pre>");
41 41
     }
42 42
 }
43 43
 
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Proxy demo</title></head>
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Webservice wrapper demo</title></head>
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 $client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
21 21
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
22 22
 if ($resp->faultCode()) {
23
-    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n");
23
+    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n");
24 24
 } else {
25 25
     output("<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n");
26 26
     flush();
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
         if ($methodName == 'examples.getStateName') {
33 33
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
34 34
             if ($callable) {
35
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n");
35
+                output("<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n");
36 36
             } else {
37
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n");
37
+                output("<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n");
38 38
             }
39 39
             break;
40 40
         }
Please login to merge, or discard this patch.
demo/client/agesort.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Agesort demo</title></head>
@@ -17,21 +17,21 @@  discard block
 block discarded – undo
17 17
 
18 18
 $inAr = array(
19 19
     array('name' => 'Dave', 'age' => 24),
20
-    array('name' => 'Edd',  'age' => 45),
21
-    array('name' => 'Joe',  'age' => 37),
20
+    array('name' => 'Edd', 'age' => 45),
21
+    array('name' => 'Joe', 'age' => 37),
22 22
     array('name' => 'Fred', 'age' => 27),
23 23
 );
24 24
 
25 25
 output('This is the input data:<br/><pre>');
26 26
 foreach ($inAr as $val) {
27
-    output($val['name'] . ", " . $val['age'] . "\n");
27
+    output($val['name'].", ".$val['age']."\n");
28 28
 }
29 29
 output('</pre>');
30 30
 
31 31
 // Create xml-rpc parameters from the input array: an array of structs
32 32
 $encoder = new Encoder();
33 33
 $v = $encoder->encode($inAr);
34
-output("Encoded into xml-rpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n");
34
+output("Encoded into xml-rpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n");
35 35
 
36 36
 // create client and request objects
37 37
 $req = new Request('examples.sortByAge', array($v));
@@ -51,15 +51,15 @@  discard block
 block discarded – undo
51 51
     $value = $resp->value();
52 52
     foreach ($encoder->decode($value) as $struct) {
53 53
         // note: here we are trusting the server's response to have the expected format
54
-        output(htmlspecialchars($struct['name']) . ", " . htmlspecialchars($struct['age']) . "\n");
54
+        output(htmlspecialchars($struct['name']).", ".htmlspecialchars($struct['age'])."\n");
55 55
     }
56 56
 
57
-    output('</pre><hr/>For nerds: I got this value back<br/><pre>' .
58
-        htmlentities($resp->serialize()) . "</pre><hr/>\n");
57
+    output('</pre><hr/>For nerds: I got this value back<br/><pre>'.
58
+        htmlentities($resp->serialize())."</pre><hr/>\n");
59 59
 } else {
60 60
     output('An error occurred:<pre>');
61
-    output('Code: ' . htmlspecialchars($resp->faultCode()) .
62
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . "'</pre><hr/>");
61
+    output('Code: '.htmlspecialchars($resp->faultCode()).
62
+        "\nReason: '".htmlspecialchars($resp->faultString())."'</pre><hr/>");
63 63
 }
64 64
 
65 65
 output("</body></html>\n");
Please login to merge, or discard this patch.