Passed
Push — master ( 76b05c...805d72 )
by Gaetano
09:31
created
demo/client/introspect.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Introspect demo</title></head>
@@ -13,13 +13,13 @@  discard block
 block discarded – undo
13 13
 function display_error($r)
14 14
 {
15 15
     output("An error occurred: ");
16
-    output("Code: " . $r->faultCode() . " Reason: '" . $r->faultString() . "'<br/>");
16
+    output("Code: ".$r->faultCode()." Reason: '".$r->faultString()."'<br/>");
17 17
 }
18 18
 
19 19
 $client = new PhpXmlRpc\Client(XMLRPCSERVER);
20 20
 
21 21
 // First off, let's retrieve the list of methods available on the remote server
22
-output("<h3>methods available at http://" . $client->server . $client->path . "</h3>\n");
22
+output("<h3>methods available at http://".$client->server.$client->path."</h3>\n");
23 23
 $req = new PhpXmlRpc\Request('system.listMethods');
24 24
 $resp = $client->send($req);
25 25
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
     // Then, retrieve the signature and help text of each available method
32 32
     foreach ($v as $methodName) {
33
-        output("<h4>" . htmlspecialchars($methodName->scalarval()) . "</h4>\n");
33
+        output("<h4>".htmlspecialchars($methodName->scalarval())."</h4>\n");
34 34
         // build messages first, add params later
35 35
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
36 36
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
             if ($val->kindOf() == "array") {
62 62
                 foreach ($val as $x) {
63 63
                     $ret = $x[0];
64
-                    output("<code>" . htmlspecialchars($ret->scalarval()) . " "
65
-                        . htmlspecialchars($methodName->scalarval()) . "(");
66
-                    if ($x->count() > 1) {
67
-                        for ($k = 1; $k < $x->count(); $k++) {
64
+                    output("<code>".htmlspecialchars($ret->scalarval())." "
65
+                        . htmlspecialchars($methodName->scalarval())."(");
66
+                    if ($x->count()>1) {
67
+                        for ($k = 1; $k<$x->count(); $k++) {
68 68
                             $y = $x[$k];
69 69
                             output(htmlspecialchars($y->scalarval()));
70
-                            if ($k < $x->count() - 1) {
70
+                            if ($k<$x->count()-1) {
71 71
                                 output(", ");
72 72
                             }
73 73
                         }
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Proxy demo</title></head>
Please login to merge, or discard this patch.
demo/client/mail.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Mail demo</title></head>
@@ -35,8 +35,8 @@  discard block
 block discarded – undo
35 35
         output("<font color=\"red\">");
36 36
         output("Mail send failed<br/>\n");
37 37
         output("Fault: ");
38
-        output("Code: " . htmlspecialchars($resp->faultCode()) .
39
-            " Reason: '" . htmlspecialchars($resp->faultString()) . "'<br/>");
38
+        output("Code: ".htmlspecialchars($resp->faultCode()).
39
+            " Reason: '".htmlspecialchars($resp->faultString())."'<br/>");
40 40
         output("</font><br/>");
41 41
     }
42 42
 }
Please login to merge, or discard this patch.
tests/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777);
16 16
     }
17 17
 
18
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
18
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
19 19
 }
20 20
 
21 21
 $targetFile = null;
@@ -38,5 +38,5 @@  discard block
 block discarded – undo
38 38
 }
39 39
 
40 40
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
41
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
41
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
42 42
 }
Please login to merge, or discard this patch.
src/Response.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -151,35 +151,35 @@  discard block
 block discarded – undo
151 151
     public function serialize($charsetEncoding = '')
152 152
     {
153 153
         if ($charsetEncoding != '') {
154
-            $this->content_type = 'text/xml; charset=' . $charsetEncoding;
154
+            $this->content_type = 'text/xml; charset='.$charsetEncoding;
155 155
         } else {
156 156
             $this->content_type = 'text/xml';
157 157
         }
158 158
         if (PhpXmlRpc::$xmlrpc_null_apache_encoding) {
159
-            $result = "<methodResponse xmlns:ex=\"" . PhpXmlRpc::$xmlrpc_null_apache_encoding_ns . "\">\n";
159
+            $result = "<methodResponse xmlns:ex=\"".PhpXmlRpc::$xmlrpc_null_apache_encoding_ns."\">\n";
160 160
         } else {
161 161
             $result = "<methodResponse>\n";
162 162
         }
163 163
         if ($this->errno) {
164 164
             // Let non-ASCII response messages be tolerated by clients by xml-encoding non ascii chars
165
-            $result .= "<fault>\n" .
166
-                "<value>\n<struct><member><name>faultCode</name>\n<value><int>" . $this->errno .
167
-                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>" .
168
-                Charset::instance()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</string></value>\n</member>\n" .
165
+            $result .= "<fault>\n".
166
+                "<value>\n<struct><member><name>faultCode</name>\n<value><int>".$this->errno.
167
+                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>".
168
+                Charset::instance()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</string></value>\n</member>\n".
169 169
                 "</struct>\n</value>\n</fault>";
170 170
         } else {
171 171
             if (!is_object($this->val) || !is_a($this->val, 'PhpXmlRpc\Value')) {
172 172
                 if (is_string($this->val) && $this->valtyp == 'xml') {
173
-                    $result .= "<params>\n<param>\n" .
174
-                        $this->val .
173
+                    $result .= "<params>\n<param>\n".
174
+                        $this->val.
175 175
                         "</param>\n</params>";
176 176
                 } else {
177 177
                     /// @todo try to build something serializable using the Encoder...
178 178
                     throw new \Exception('cannot serialize xmlrpc response objects whose content is native php values');
179 179
                 }
180 180
             } else {
181
-                $result .= "<params>\n<param>\n" .
182
-                    $this->val->serialize($charsetEncoding) .
181
+                $result .= "<params>\n<param>\n".
182
+                    $this->val->serialize($charsetEncoding).
183 183
                     "</param>\n</params>";
184 184
             }
185 185
         }
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
                 return $this->httpResponse['raw_data'];
205 205
             default:
206 206
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
207
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
207
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
208 208
                 return null;
209 209
         }
210 210
     }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
                 break;
226 226
             default:
227 227
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
228
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
228
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
229 229
         }
230 230
     }
231 231
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
                 break;
258 258
             default:
259 259
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
260
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
260
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
261 261
         }
262 262
     }
263 263
 }
Please login to merge, or discard this patch.
src/Helper/Http.php 1 patch
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -24,12 +24,12 @@  discard block
 block discarded – undo
24 24
 
25 25
         // read chunk-size, chunk-extension (if any) and crlf
26 26
         // get the position of the linebreak
27
-        $chunkEnd = strpos($buffer, "\r\n") + 2;
27
+        $chunkEnd = strpos($buffer, "\r\n")+2;
28 28
         $temp = substr($buffer, 0, $chunkEnd);
29 29
         $chunkSize = hexdec(trim($temp));
30 30
         $chunkStart = $chunkEnd;
31
-        while ($chunkSize > 0) {
32
-            $chunkEnd = strpos($buffer, "\r\n", $chunkStart + $chunkSize);
31
+        while ($chunkSize>0) {
32
+            $chunkEnd = strpos($buffer, "\r\n", $chunkStart+$chunkSize);
33 33
 
34 34
             // just in case we got a broken connection
35 35
             if ($chunkEnd == false) {
@@ -41,19 +41,19 @@  discard block
 block discarded – undo
41 41
             }
42 42
 
43 43
             // read chunk-data and crlf
44
-            $chunk = substr($buffer, $chunkStart, $chunkEnd - $chunkStart);
44
+            $chunk = substr($buffer, $chunkStart, $chunkEnd-$chunkStart);
45 45
             // append chunk-data to entity-body
46 46
             $new .= $chunk;
47 47
             // length := length + chunk-size
48 48
             $length += strlen($chunk);
49 49
             // read chunk-size and crlf
50
-            $chunkStart = $chunkEnd + 2;
50
+            $chunkStart = $chunkEnd+2;
51 51
 
52
-            $chunkEnd = strpos($buffer, "\r\n", $chunkStart) + 2;
52
+            $chunkEnd = strpos($buffer, "\r\n", $chunkStart)+2;
53 53
             if ($chunkEnd == false) {
54 54
                 break; //just in case we got a broken connection
55 55
             }
56
-            $temp = substr($buffer, $chunkStart, $chunkEnd - $chunkStart);
56
+            $temp = substr($buffer, $chunkStart, $chunkEnd-$chunkStart);
57 57
             $chunkSize = hexdec(trim($temp));
58 58
             $chunkStart = $chunkEnd;
59 59
         }
@@ -84,11 +84,11 @@  discard block
 block discarded – undo
84 84
             // (even though it is not valid http)
85 85
             $pos = strpos($data, "\r\n\r\n");
86 86
             if ($pos || is_int($pos)) {
87
-                $bd = $pos + 4;
87
+                $bd = $pos+4;
88 88
             } else {
89 89
                 $pos = strpos($data, "\n\n");
90 90
                 if ($pos || is_int($pos)) {
91
-                    $bd = $pos + 2;
91
+                    $bd = $pos+2;
92 92
                 } else {
93 93
                     // No separation between response headers and body: fault?
94 94
                     $bd = 0;
@@ -99,8 +99,8 @@  discard block
 block discarded – undo
99 99
                 // maybe we could take them into account, too?
100 100
                 $data = substr($data, $bd);
101 101
             } else {
102
-                Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': HTTPS via proxy error, tunnel connection possibly failed');
103
-                throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'] . ' (HTTPS via proxy error, tunnel connection possibly failed)', PhpXmlRpc::$xmlrpcerr['http_error']);
102
+                Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': HTTPS via proxy error, tunnel connection possibly failed');
103
+                throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'].' (HTTPS via proxy error, tunnel connection possibly failed)', PhpXmlRpc::$xmlrpcerr['http_error']);
104 104
             }
105 105
         }
106 106
 
@@ -131,20 +131,20 @@  discard block
 block discarded – undo
131 131
         }
132 132
 
133 133
         if ($httpResponse['status_code'] !== '200') {
134
-            $errstr = substr($data, 0, strpos($data, "\n") - 1);
135
-            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': HTTP error, got response: ' . $errstr);
136
-            throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'] . ' (' . $errstr . ')', PhpXmlRpc::$xmlrpcerr['http_error'], null, $httpResponse['status_code']);
134
+            $errstr = substr($data, 0, strpos($data, "\n")-1);
135
+            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': HTTP error, got response: '.$errstr);
136
+            throw new HttpException(PhpXmlRpc::$xmlrpcstr['http_error'].' ('.$errstr.')', PhpXmlRpc::$xmlrpcerr['http_error'], null, $httpResponse['status_code']);
137 137
         }
138 138
 
139 139
         // be tolerant to usage of \n instead of \r\n to separate headers and data
140 140
         // (even though it is not valid http)
141 141
         $pos = strpos($data, "\r\n\r\n");
142 142
         if ($pos || is_int($pos)) {
143
-            $bd = $pos + 4;
143
+            $bd = $pos+4;
144 144
         } else {
145 145
             $pos = strpos($data, "\n\n");
146 146
             if ($pos || is_int($pos)) {
147
-                $bd = $pos + 2;
147
+                $bd = $pos+2;
148 148
             } else {
149 149
                 // No separation between response headers and body: fault?
150 150
                 // we could take some action here instead of going on...
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         foreach ($ar as $line) {
159 159
             // take care of multi-line headers and cookies
160 160
             $arr = explode(':', $line, 2);
161
-            if (count($arr) > 1) {
161
+            if (count($arr)>1) {
162 162
                 $headerName = strtolower(trim($arr[0]));
163 163
                 /// @todo some other headers (the ones that allow a CSV list of values)
164 164
                 ///       do allow many values to be passed using multiple header lines.
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                         // glue together all received cookies, using a comma to separate them
178 178
                         // (same as php does with getallheaders())
179 179
                         if (isset($httpResponse['headers'][$headerName])) {
180
-                            $httpResponse['headers'][$headerName] .= ', ' . trim($cookie);
180
+                            $httpResponse['headers'][$headerName] .= ', '.trim($cookie);
181 181
                         } else {
182 182
                             $httpResponse['headers'][$headerName] = trim($cookie);
183 183
                         }
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
                 }
207 207
             } elseif (isset($headerName)) {
208 208
                 /// @todo version1 cookies might span multiple lines, thus breaking the parsing above
209
-                $httpResponse['headers'][$headerName] .= ' ' . trim($line);
209
+                $httpResponse['headers'][$headerName] .= ' '.trim($line);
210 210
             }
211 211
         }
212 212
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
             // Decode chunked encoding sent by http 1.1 servers
231 231
             if (isset($httpResponse['headers']['transfer-encoding']) && $httpResponse['headers']['transfer-encoding'] == 'chunked') {
232 232
                 if (!$data = static::decodeChunked($data)) {
233
-                    Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': errors occurred when trying to rebuild the chunked data received from server');
233
+                    Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': errors occurred when trying to rebuild the chunked data received from server');
234 234
                     throw new HttpException(PhpXmlRpc::$xmlrpcstr['dechunk_fail'], PhpXmlRpc::$xmlrpcerr['dechunk_fail'], null, $httpResponse['status_code']);
235 235
                 }
236 236
             }
@@ -245,19 +245,19 @@  discard block
 block discarded – undo
245 245
                         if ($httpResponse['headers']['content-encoding'] == 'deflate' && $degzdata = @gzuncompress($data)) {
246 246
                             $data = $degzdata;
247 247
                             if ($debug) {
248
-                                Logger::instance()->debugMessage("---INFLATED RESPONSE---[" . strlen($data) . " chars]---\n$data\n---END---");
248
+                                Logger::instance()->debugMessage("---INFLATED RESPONSE---[".strlen($data)." chars]---\n$data\n---END---");
249 249
                             }
250 250
                         } elseif ($httpResponse['headers']['content-encoding'] == 'gzip' && $degzdata = @gzinflate(substr($data, 10))) {
251 251
                             $data = $degzdata;
252 252
                             if ($debug) {
253
-                                Logger::instance()->debugMessage("---INFLATED RESPONSE---[" . strlen($data) . " chars]---\n$data\n---END---");
253
+                                Logger::instance()->debugMessage("---INFLATED RESPONSE---[".strlen($data)." chars]---\n$data\n---END---");
254 254
                             }
255 255
                         } else {
256
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': errors occurred when trying to decode the deflated data received from server');
256
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': errors occurred when trying to decode the deflated data received from server');
257 257
                             throw new HttpException(PhpXmlRpc::$xmlrpcstr['decompress_fail'], PhpXmlRpc::$xmlrpcerr['decompress_fail'], null, $httpResponse['status_code']);
258 258
                         }
259 259
                     } else {
260
-                        Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': the server sent deflated data. Your php install must have the Zlib extension compiled in to support this.');
260
+                        Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': the server sent deflated data. Your php install must have the Zlib extension compiled in to support this.');
261 261
                         throw new HttpException(PhpXmlRpc::$xmlrpcstr['cannot_decompress'], PhpXmlRpc::$xmlrpcerr['cannot_decompress'], null, $httpResponse['status_code']);
262 262
                     }
263 263
                 }
Please login to merge, or discard this patch.
src/Helper/XMLParser.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -154,10 +154,10 @@  discard block
 block discarded – undo
154 154
         $this->accept = $accept;
155 155
 
156 156
         // @see ticket #70 - we have to parse big xml docks in chunks to avoid errors
157
-        for ($offset = 0; $offset < $len; $offset += $this->maxChunkLength) {
157
+        for ($offset = 0; $offset<$len; $offset += $this->maxChunkLength) {
158 158
             $chunk = substr($data, $offset, $this->maxChunkLength);
159 159
             // error handling: xml not well formed
160
-            if (!xml_parse($parser, $chunk, $offset + $this->maxChunkLength >= $len)) {
160
+            if (!xml_parse($parser, $chunk, $offset+$this->maxChunkLength>=$len)) {
161 161
                 $errCode = xml_get_error_code($parser);
162 162
                 $errStr = sprintf('XML error %s: %s at line %d, column %d', $errCode, xml_error_string($errCode),
163 163
                     xml_get_current_line_number($parser), xml_get_current_column_number($parser));
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     public function xmlrpc_se($parser, $name, $attrs, $acceptSingleVals = false)
183 183
     {
184 184
         // if invalid xmlrpc already detected, skip all processing
185
-        if ($this->_xh['isf'] < 2) {
185
+        if ($this->_xh['isf']<2) {
186 186
 
187 187
             // check for correct element nesting
188 188
             if (count($this->_xh['stack']) == 0) {
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
                     $this->_xh['rt'] = strtolower($name);
203 203
                 } else {
204 204
                     $this->_xh['isf'] = 2;
205
-                    $this->_xh['isf_reason'] = 'missing top level xmlrpc element. Found: ' . $name;
205
+                    $this->_xh['isf_reason'] = 'missing top level xmlrpc element. Found: '.$name;
206 206
 
207 207
                     return;
208 208
                 }
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
                     break;
297 297
                 case 'MEMBER':
298 298
                     // set member name to null, in case we do not find in the xml later on
299
-                    $this->_xh['valuestack'][count($this->_xh['valuestack']) - 1]['name'] = '';
299
+                    $this->_xh['valuestack'][count($this->_xh['valuestack'])-1]['name'] = '';
300 300
                     //$this->_xh['ac']='';
301 301
                 // Drop trough intentionally
302 302
                 case 'PARAM':
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
      */
358 358
     public function xmlrpc_ee($parser, $name, $rebuildXmlrpcvals = 1)
359 359
     {
360
-        if ($this->_xh['isf'] < 2) {
360
+        if ($this->_xh['isf']<2) {
361 361
             // push this element name from stack
362 362
             // NB: if XML validates, correct opening/closing is guaranteed and
363 363
             // we do not have to check for $name == $currElem.
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
                         $this->_xh['vt'] = Value::$xmlrpcString;
373 373
                     }
374 374
 
375
-                    if ($rebuildXmlrpcvals > 0) {
375
+                    if ($rebuildXmlrpcvals>0) {
376 376
                         // build the xmlrpc val out of the data received, and substitute it
377 377
                         $temp = new Value($this->_xh['value'], $this->_xh['vt']);
378 378
                         // in case we got info about underlying php class, save it
@@ -381,15 +381,15 @@  discard block
 block discarded – undo
381 381
                             $temp->_php_class = $this->_xh['php_class'];
382 382
                         }
383 383
                         $this->_xh['value'] = $temp;
384
-                    } elseif ($rebuildXmlrpcvals < 0) {
384
+                    } elseif ($rebuildXmlrpcvals<0) {
385 385
                         if ($this->_xh['vt'] == Value::$xmlrpcDateTime) {
386
-                            $this->_xh['value'] = (object)array(
386
+                            $this->_xh['value'] = (object) array(
387 387
                                 'xmlrpc_type' => 'datetime',
388 388
                                 'scalar' => $this->_xh['value'],
389 389
                                 'timestamp' => \PhpXmlRpc\Helper\Date::iso8601Decode($this->_xh['value'])
390 390
                             );
391 391
                         } elseif ($this->_xh['vt'] == Value::$xmlrpcBase64) {
392
-                            $this->_xh['value'] = (object)array(
392
+                            $this->_xh['value'] = (object) array(
393 393
                                 'xmlrpc_type' => 'base64',
394 394
                                 'scalar' => $this->_xh['value']
395 395
                             );
@@ -405,8 +405,8 @@  discard block
 block discarded – undo
405 405
                     // check if we are inside an array or struct:
406 406
                     // if value just built is inside an array, let's move it into array on the stack
407 407
                     $vscount = count($this->_xh['valuestack']);
408
-                    if ($vscount && $this->_xh['valuestack'][$vscount - 1]['type'] == 'ARRAY') {
409
-                        $this->_xh['valuestack'][$vscount - 1]['values'][] = $this->_xh['value'];
408
+                    if ($vscount && $this->_xh['valuestack'][$vscount-1]['type'] == 'ARRAY') {
409
+                        $this->_xh['valuestack'][$vscount-1]['values'][] = $this->_xh['value'];
410 410
                     }
411 411
                     break;
412 412
                 case 'BOOLEAN':
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
                         $this->_xh['value'] = $this->_xh['ac'];
426 426
                     } elseif ($name == 'DATETIME.ISO8601') {
427 427
                         if (!preg_match('/^[0-9]{8}T[0-9]{2}:[0-9]{2}:[0-9]{2}$/', $this->_xh['ac'])) {
428
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': invalid value received in DATETIME: ' . $this->_xh['ac']);
428
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': invalid value received in DATETIME: '.$this->_xh['ac']);
429 429
                         }
430 430
                         $this->_xh['vt'] = Value::$xmlrpcDateTime;
431 431
                         $this->_xh['value'] = $this->_xh['ac'];
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
                         } else {
445 445
                             // log if receiving something strange, even though we set the value to false anyway
446 446
                             if ($this->_xh['ac'] != '0' && strcasecmp($this->_xh['ac'], 'false') != 0) {
447
-                                Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': invalid value received in BOOLEAN: ' . $this->_xh['ac']);
447
+                                Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': invalid value received in BOOLEAN: '.$this->_xh['ac']);
448 448
                             }
449 449
                             $this->_xh['value'] = false;
450 450
                         }
@@ -454,37 +454,37 @@  discard block
 block discarded – undo
454 454
                         // NOTE: regexp could be much stricter than this...
455 455
                         if (!preg_match('/^[+-eE0123456789 \t.]+$/', $this->_xh['ac'])) {
456 456
                             /// @todo: find a better way of throwing an error than this!
457
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': non numeric value received in DOUBLE: ' . $this->_xh['ac']);
457
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': non numeric value received in DOUBLE: '.$this->_xh['ac']);
458 458
                             $this->_xh['value'] = 'ERROR_NON_NUMERIC_FOUND';
459 459
                         } else {
460 460
                             // it's ok, add it on
461
-                            $this->_xh['value'] = (double)$this->_xh['ac'];
461
+                            $this->_xh['value'] = (double) $this->_xh['ac'];
462 462
                         }
463 463
                     } else {
464 464
                         // we have an I4/I8/INT
465 465
                         // we must check that only 0123456789-<space> are characters here
466 466
                         if (!preg_match('/^[+-]?[0123456789 \t]+$/', $this->_xh['ac'])) {
467 467
                             /// @todo find a better way of throwing an error than this!
468
-                            Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': non numeric value received in INT: ' . $this->_xh['ac']);
468
+                            Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': non numeric value received in INT: '.$this->_xh['ac']);
469 469
                             $this->_xh['value'] = 'ERROR_NON_NUMERIC_FOUND';
470 470
                         } else {
471 471
                             // it's ok, add it on
472
-                            $this->_xh['value'] = (int)$this->_xh['ac'];
472
+                            $this->_xh['value'] = (int) $this->_xh['ac'];
473 473
                         }
474 474
                     }
475 475
                     $this->_xh['lv'] = 3; // indicate we've found a value
476 476
                     break;
477 477
                 case 'NAME':
478
-                    $this->_xh['valuestack'][count($this->_xh['valuestack']) - 1]['name'] = $this->_xh['ac'];
478
+                    $this->_xh['valuestack'][count($this->_xh['valuestack'])-1]['name'] = $this->_xh['ac'];
479 479
                     break;
480 480
                 case 'MEMBER':
481 481
                     // add to array in the stack the last element built,
482 482
                     // unless no VALUE was found
483 483
                     if ($this->_xh['vt']) {
484 484
                         $vscount = count($this->_xh['valuestack']);
485
-                        $this->_xh['valuestack'][$vscount - 1]['values'][$this->_xh['valuestack'][$vscount - 1]['name']] = $this->_xh['value'];
485
+                        $this->_xh['valuestack'][$vscount-1]['values'][$this->_xh['valuestack'][$vscount-1]['name']] = $this->_xh['value'];
486 486
                     } else {
487
-                        Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': missing VALUE inside STRUCT in received xml');
487
+                        Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': missing VALUE inside STRUCT in received xml');
488 488
                     }
489 489
                     break;
490 490
                 case 'DATA':
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
                         $this->_xh['params'][] = $this->_xh['value'];
508 508
                         $this->_xh['pt'][] = $this->_xh['vt'];
509 509
                     } else {
510
-                        Logger::instance()->errorLog('XML-RPC: ' . __METHOD__ . ': missing VALUE inside PARAM in received xml');
510
+                        Logger::instance()->errorLog('XML-RPC: '.__METHOD__.': missing VALUE inside PARAM in received xml');
511 511
                     }
512 512
                     break;
513 513
                 case 'METHODNAME':
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
     public function xmlrpc_cd($parser, $data)
567 567
     {
568 568
         // skip processing if xml fault already detected
569
-        if ($this->_xh['isf'] < 2) {
569
+        if ($this->_xh['isf']<2) {
570 570
             // "lookforvalue==3" means that we've found an entire value
571 571
             // and should discard any further character data
572 572
             if ($this->_xh['lv'] != 3) {
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
     public function xmlrpc_dh($parser, $data)
586 586
     {
587 587
         // skip processing if xml fault already detected
588
-        if ($this->_xh['isf'] < 2) {
588
+        if ($this->_xh['isf']<2) {
589 589
             if (substr($data, 0, 1) == '&' && substr($data, -1, 1) == ';') {
590 590
                 $this->_xh['ac'] .= $data;
591 591
             }
@@ -659,8 +659,8 @@  discard block
 block discarded – undo
659 659
         // Details:
660 660
         // SPACE:         (#x20 | #x9 | #xD | #xA)+ === [ \x9\xD\xA]+
661 661
         // EQ:            SPACE?=SPACE? === [ \x9\xD\xA]*=[ \x9\xD\xA]*
662
-        if (preg_match('/^<\?xml\s+version\s*=\s*' . "((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))" .
663
-            '\s+encoding\s*=\s*' . "((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
662
+        if (preg_match('/^<\?xml\s+version\s*=\s*'."((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))".
663
+            '\s+encoding\s*=\s*'."((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
664 664
             $xmlChunk, $matches)) {
665 665
             return strtoupper(substr($matches[2], 1, -1));
666 666
         }
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
             // NB: mb_detect likes to call it ascii, xml parser likes to call it US_ASCII...
679 679
             // IANA also likes better US-ASCII, so go with it
680 680
             if ($enc == 'ASCII') {
681
-                $enc = 'US-' . $enc;
681
+                $enc = 'US-'.$enc;
682 682
             }
683 683
 
684 684
             return $enc;
@@ -713,8 +713,8 @@  discard block
 block discarded – undo
713 713
         // Details:
714 714
         // SPACE:         (#x20 | #x9 | #xD | #xA)+ === [ \x9\xD\xA]+
715 715
         // EQ:            SPACE?=SPACE? === [ \x9\xD\xA]*=[ \x9\xD\xA]*
716
-        if (preg_match('/^<\?xml\s+version\s*=\s*' . "((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))" .
717
-            '\s+encoding\s*=\s*' . "((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
716
+        if (preg_match('/^<\?xml\s+version\s*=\s*'."((?:\"[a-zA-Z0-9_.:-]+\")|(?:'[a-zA-Z0-9_.:-]+'))".
717
+            '\s+encoding\s*=\s*'."((?:\"[A-Za-z][A-Za-z0-9._-]*\")|(?:'[A-Za-z][A-Za-z0-9._-]*'))/",
718 718
             $xmlChunk, $matches)) {
719 719
             return true;
720 720
         }
Please login to merge, or discard this patch.
debugger/action.php 2 patches
Spacing   +113 added lines, -113 removed lines patch added patch discarded remove patch
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
 <body>
93 93
 <?php
94 94
 
95
-include __DIR__ . '/common.php';
95
+include __DIR__.'/common.php';
96 96
 
97 97
 if ($action) {
98 98
 
99 99
     // make sure the script waits long enough for the call to complete...
100 100
     if ($timeout) {
101
-        set_time_limit($timeout + 10);
101
+        set_time_limit($timeout+10);
102 102
     }
103 103
 
104 104
     if ($wstype == 1) {
@@ -123,13 +123,13 @@  discard block
 block discarded – undo
123 123
         $server = "$host$path";
124 124
     }
125 125
     if ($protocol == 2 || $protocol == 3) {
126
-        $server = 'https://' . $server;
126
+        $server = 'https://'.$server;
127 127
     } else {
128
-        $server = 'http://' . $server;
128
+        $server = 'http://'.$server;
129 129
     }
130 130
     if ($proxy != '') {
131 131
         $pproxy = explode(':', $proxy);
132
-        if (count($pproxy) > 1) {
132
+        if (count($pproxy)>1) {
133 133
             $pport = $pproxy[1];
134 134
         } else {
135 135
             $pport = 8080;
@@ -204,9 +204,9 @@  discard block
 block discarded – undo
204 204
         case 'wrap':
205 205
             $msg[0] = new $requestClass('system.methodHelp', array(), $id);
206 206
             $msg[0]->addparam(new PhpXmlRpc\Value($method));
207
-            $msg[1] = new $requestClass('system.methodSignature', array(), (int)$id + 1);
207
+            $msg[1] = new $requestClass('system.methodSignature', array(), (int) $id+1);
208 208
             $msg[1]->addparam(new PhpXmlRpc\Value($method));
209
-            $actionname = 'Description of method "' . $method . '"';
209
+            $actionname = 'Description of method "'.$method.'"';
210 210
             break;
211 211
         case 'list':
212 212
             $msg[0] = new $requestClass('system.listMethods', array(), $id);
@@ -219,9 +219,9 @@  discard block
 block discarded – undo
219 219
             $msg[0] = new $requestClass($method, array(), $id);
220 220
             // hack! build xml payload by hand
221 221
             if ($wstype == 1) {
222
-                $msg[0]->payload = "{\n" .
223
-                    '"method": "' . $method . "\",\n\"params\": [" .
224
-                    $payload .
222
+                $msg[0]->payload = "{\n".
223
+                    '"method": "'.$method."\",\n\"params\": [".
224
+                    $payload.
225 225
                     "\n],\n\"id\": ";
226 226
                 // fix: if user gave an empty string, use NULL, or we'll break json syntax
227 227
                 if ($id == "") {
@@ -234,20 +234,20 @@  discard block
 block discarded – undo
234 234
                     }
235 235
                 }
236 236
             } else {
237
-                $msg[0]->payload = $msg[0]->xml_header($inputcharset) .
238
-                    '<methodName>' . $method . "</methodName>\n<params>" .
239
-                    $payload .
240
-                    "</params>\n" . $msg[0]->xml_footer();
237
+                $msg[0]->payload = $msg[0]->xml_header($inputcharset).
238
+                    '<methodName>'.$method."</methodName>\n<params>".
239
+                    $payload.
240
+                    "</params>\n".$msg[0]->xml_footer();
241 241
             }
242
-            $actionname = 'Execution of method ' . $method;
242
+            $actionname = 'Execution of method '.$method;
243 243
             break;
244 244
         default: // give a warning
245
-            $actionname = '[ERROR: unknown action] "' . $action . '"';
245
+            $actionname = '[ERROR: unknown action] "'.$action.'"';
246 246
     }
247 247
 
248 248
     // Before calling execute, echo out brief description of action taken + date and time ???
249 249
     // this gives good user feedback for long-running methods...
250
-    echo '<h2>' . htmlspecialchars($actionname, ENT_COMPAT, $inputcharset) . ' on server ' . htmlspecialchars($server, ENT_COMPAT, $inputcharset) . " ...</h2>\n";
250
+    echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset)." ...</h2>\n";
251 251
     flush();
252 252
 
253 253
     $response = null;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
             break;
266 266
         }
267 267
     }
268
-    $time = microtime(true) - $time;
268
+    $time = microtime(true)-$time;
269 269
     if ($debug) {
270 270
         echo "</div>\n";
271 271
     }
@@ -275,8 +275,8 @@  discard block
 block discarded – undo
275 275
             // call failed! echo out error msg!
276 276
             //echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset).'</h2>';
277 277
             echo "<h3>$protoName call FAILED!</h3>\n";
278
-            echo "<p>Fault code: [" . htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
279
-                "] Reason: '" . htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "'</p>\n";
278
+            echo "<p>Fault code: [".htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
279
+                "] Reason: '".htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."'</p>\n";
280 280
             echo(date("d/M/Y:H:i:s\n"));
281 281
         } else {
282 282
             // call succeeded: parse results
@@ -292,36 +292,36 @@  discard block
 block discarded – undo
292 292
                         $max = $v->count();
293 293
                         echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
294 294
                         echo "<thead>\n<tr><th>Method ($max)</th><th>Description</th></tr>\n</thead>\n<tbody>\n";
295
-                        foreach($v as $i => $rec) {
295
+                        foreach ($v as $i => $rec) {
296 296
                             if ($i % 2) {
297 297
                                 $class = ' class="oddrow"';
298 298
                             } else {
299 299
                                 $class = ' class="evenrow"';
300 300
                             }
301
-                            echo("<tr><td$class>" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">" .
302
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
303
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
304
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
305
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
306
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
307
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
308
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
309
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
310
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
311
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
312
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
313
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
314
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
315
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
316
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
317
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
318
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
319
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
320
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
321
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "\" />" .
322
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
323
-                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />" .
324
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
301
+                            echo("<tr><td$class>".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">".
302
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
303
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
304
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
305
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
306
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
307
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
308
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
309
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
310
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
311
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
312
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
313
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
314
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
315
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
316
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
317
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
318
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
319
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
320
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
321
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."\" />".
322
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
323
+                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />".
324
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
325 325
                                 "<input type=\"submit\" value=\"Describe\" /></form></td>");
326 326
                             //echo("</tr>\n");
327 327
 
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
                     $r2 = $resp[1]->value();
349 349
 
350 350
                     echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
351
-                    echo "<thead>\n<tr><th>Method</th><th>" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
351
+                    echo "<thead>\n<tr><th>Method</th><th>".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
352 352
                     $desc = htmlspecialchars($r1->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
353 353
                     if ($desc == "") {
354 354
                         $desc = "-";
@@ -358,41 +358,41 @@  discard block
 block discarded – undo
358 358
                     if ($r2->kindOf() != "array") {
359 359
                         echo "<tr><td class=\"oddrow\">Signature</td><td class=\"oddrow\">Unknown</td><td class=\"oddrow\">&nbsp;</td></tr>\n";
360 360
                     } else {
361
-                        foreach($r2 as $i => $x) {
361
+                        foreach ($r2 as $i => $x) {
362 362
                             $payload = "";
363 363
                             $alt_payload = "";
364
-                            if ($i + 1 % 2) {
364
+                            if ($i+1 % 2) {
365 365
                                 $class = ' class="oddrow"';
366 366
                             } else {
367 367
                                 $class = ' class="evenrow"';
368 368
                             }
369
-                            echo "<tr><td$class>Signature&nbsp;" . ($i + 1) . "</td><td$class>";
369
+                            echo "<tr><td$class>Signature&nbsp;".($i+1)."</td><td$class>";
370 370
                             if ($x->kindOf() == "array") {
371 371
                                 $ret = $x[0];
372
-                                echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
373
-                                if ($x->count() > 1) {
374
-                                    foreach($x as $k => $y) {
372
+                                echo "<code>OUT:&nbsp;".htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."<br />IN: (";
373
+                                if ($x->count()>1) {
374
+                                    foreach ($x as $k => $y) {
375 375
                                         if ($k == 0) continue;
376 376
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
377 377
                                         if ($wstype != 1) {
378 378
                                             $type = $y->scalarval();
379 379
                                             $payload .= '<param><value>';
380
-                                            switch($type) {
380
+                                            switch ($type) {
381 381
                                                 case 'undefined':
382 382
                                                     break;
383 383
                                                 case 'null';
384 384
                                                     $type = 'nil';
385 385
                                                     // fall thru intentionally
386 386
                                                 default:
387
-                                                    $payload .= '<' .
388
-                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
389
-                                                        '></' . htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
387
+                                                    $payload .= '<'.
388
+                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
389
+                                                        '></'.htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
390 390
                                                         '>';
391 391
                                             }
392 392
                                             $payload .= "</value></param>\n";
393 393
                                         }
394 394
                                         $alt_payload .= $y->scalarval();
395
-                                        if ($k < $x->count() - 1) {
395
+                                        if ($k<$x->count()-1) {
396 396
                                             $alt_payload .= ';';
397 397
                                             echo ", ";
398 398
                                         }
@@ -405,63 +405,63 @@  discard block
 block discarded – undo
405 405
                             echo '</td>';
406 406
                             // button to test this method
407 407
                             //$payload="<methodCall>\n<methodName>$method</methodName>\n<params>\n$payload</params>\n</methodCall>";
408
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
409
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
410
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
411
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
412
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
413
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
414
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
415
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
416
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
417
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
418
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
419
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
420
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
421
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
422
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
423
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
424
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
425
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
426
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
427
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
428
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
429
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
430
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
431
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
408
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
409
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
410
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
411
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
412
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
413
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
414
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
415
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
416
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
417
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
418
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
419
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
420
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
421
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
422
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
423
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
424
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
425
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
426
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
427
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
428
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
429
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
430
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
431
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
432 432
                                 "<input type=\"hidden\" name=\"action\" value=\"execute\" />";
433 433
                             if ($wstype != 1) {
434 434
                                 echo "<input type=\"submit\" value=\"Load method synopsis\" />";
435 435
                             }
436 436
                             echo "</form></td>\n";
437 437
 
438
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
439
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
440
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
441
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
442
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
443
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
444
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
445
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
446
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
447
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
448
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
449
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
450
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
451
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
452
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
453
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
454
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
455
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
456
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
457
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
458
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
459
-                                "<input type=\"hidden\" name=\"methodsig\" value=\"" . $i . "\" />" .
460
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
461
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
462
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
463
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
464
-                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />" .
438
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
439
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
440
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
441
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
442
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
443
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
444
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
445
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
446
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
447
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
448
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
449
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
450
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
451
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
452
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
453
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
454
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
455
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
456
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
457
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
458
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
459
+                                "<input type=\"hidden\" name=\"methodsig\" value=\"".$i."\" />".
460
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
461
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
462
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
463
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
464
+                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />".
465 465
                                 "<input type=\"submit\" value=\"Generate method call stub code\" />";
466 466
                             echo "</form></td></tr>\n";
467 467
                         }
@@ -473,14 +473,14 @@  discard block
 block discarded – undo
473 473
                 case 'wrap':
474 474
                     $r1 = $resp[0]->value();
475 475
                     $r2 = $resp[1]->value();
476
-                    if ($r2->kindOf() != "array" || $r2->count() <= $methodsig) {
476
+                    if ($r2->kindOf() != "array" || $r2->count()<=$methodsig) {
477 477
                         echo "Error: signature unknown\n";
478 478
                     } else {
479 479
                         $mdesc = $r1->scalarval();
480 480
                         $encoder = new PhpXmlRpc\Encoder();
481 481
                         $msig = $encoder->decode($r2);
482 482
                         $msig = $msig[$methodsig];
483
-                        $proto = ($protocol == 1) ? 'http11' : ( $protocol == 2 ? 'https' : ( $protocol == 3 ? 'h2' : ( $protocol == 4 ? 'h2c' : '' ) ) );
483
+                        $proto = ($protocol == 1) ? 'http11' : ($protocol == 2 ? 'https' : ($protocol == 3 ? 'h2' : ($protocol == 4 ? 'h2c' : '')));
484 484
                         if ($proxy == '' && $username == '' && !$requestcompression && !$responsecompression &&
485 485
                             $clientcookies == ''
486 486
                         ) {
@@ -494,11 +494,11 @@  discard block
 block discarded – undo
494 494
                             $prefix = 'xmlrpc';
495 495
                         }
496 496
                         $wrapper = new PhpXmlRpc\Wrapper();
497
-                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix . '_' . $method), $msig, $mdesc);
497
+                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix.'_'.$method), $msig, $mdesc);
498 498
                         //if ($code)
499 499
                         //{
500 500
                         echo "<div id=\"phpcode\">\n";
501
-                        highlight_string("<?php\n" . $code['docstring'] . $code['source'] . '?>');
501
+                        highlight_string("<?php\n".$code['docstring'].$code['source'].'?>');
502 502
                         echo "\n</div>";
503 503
                         //}
504 504
                         //else
@@ -509,7 +509,7 @@  discard block
 block discarded – undo
509 509
                     break;
510 510
 
511 511
                 case 'execute':
512
-                    echo '<div id="response"><h2>Response:</h2>' . htmlspecialchars($response->serialize()) . '</div>';
512
+                    echo '<div id="response"><h2>Response:</h2>'.htmlspecialchars($response->serialize()).'</div>';
513 513
                     break;
514 514
 
515 515
                 default: // give a warning
Please login to merge, or discard this patch.
Braces   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,12 @@  discard block
 block discarded – undo
15 15
 <html lang="en">
16 16
 <head>
17 17
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
18
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSONRPC'; else echo 'XMLRPC'; ?> Debugger</title>
18
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
19
+    echo 'JSONRPC';
20
+} else {
21
+    echo 'XMLRPC';
22
+}
23
+?> Debugger</title>
19 24
     <meta name="robots" content="index,nofollow"/>
20 25
     <style type="text/css">
21 26
         <!--
@@ -370,7 +375,9 @@  discard block
 block discarded – undo
370 375
                                 echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
371 376
                                 if ($x->count() > 1) {
372 377
                                     foreach($x as $k => $y) {
373
-                                        if ($k == 0) continue;
378
+                                        if ($k == 0) {
379
+                                            continue;
380
+                                        }
374 381
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
375 382
                                         if ($wstype != 1) {
376 383
                                             $type = $y->scalarval();
Please login to merge, or discard this patch.
src/Value.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
                     $this->me['struct'] = $val;
120 120
                     break;
121 121
                 default:
122
-                    $this->getLogger()->errorLog("XML-RPC: " . __METHOD__ . ": not a known type ($type)");
122
+                    $this->getLogger()->errorLog("XML-RPC: ".__METHOD__.": not a known type ($type)");
123 123
             }
124 124
         }
125 125
     }
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         }
145 145
 
146 146
         if ($typeOf !== 1) {
147
-            $this->getLogger()->errorLog("XML-RPC: " . __METHOD__ . ": not a scalar type ($type)");
147
+            $this->getLogger()->errorLog("XML-RPC: ".__METHOD__.": not a scalar type ($type)");
148 148
             return 0;
149 149
         }
150 150
 
@@ -161,10 +161,10 @@  discard block
 block discarded – undo
161 161
 
162 162
         switch ($this->mytype) {
163 163
             case 1:
164
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': scalar xmlrpc value can have only one value');
164
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': scalar xmlrpc value can have only one value');
165 165
                 return 0;
166 166
             case 3:
167
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': cannot add anonymous scalar to struct xmlrpc value');
167
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': cannot add anonymous scalar to struct xmlrpc value');
168 168
                 return 0;
169 169
             case 2:
170 170
                 // we're adding a scalar value to an array here
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
             return 1;
208 208
         } else {
209
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']');
209
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']');
210 210
             return 0;
211 211
         }
212 212
     }
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 
238 238
             return 1;
239 239
         } else {
240
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': already initialized as a [' . $this->kindOf() . ']');
240
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': already initialized as a ['.$this->kindOf().']');
241 241
             return 0;
242 242
         }
243 243
     }
@@ -279,19 +279,19 @@  discard block
 block discarded – undo
279 279
             case 1:
280 280
                 switch ($typ) {
281 281
                     case static::$xmlrpcBase64:
282
-                        $rs .= "<{$typ}>" . base64_encode($val) . "</{$typ}>";
282
+                        $rs .= "<{$typ}>".base64_encode($val)."</{$typ}>";
283 283
                         break;
284 284
                     case static::$xmlrpcBoolean:
285
-                        $rs .= "<{$typ}>" . ($val ? '1' : '0') . "</{$typ}>";
285
+                        $rs .= "<{$typ}>".($val ? '1' : '0')."</{$typ}>";
286 286
                         break;
287 287
                     case static::$xmlrpcString:
288 288
                         // Do NOT use htmlentities, since it will produce named html entities, which are invalid xml
289
-                        $rs .= "<{$typ}>" . $this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</{$typ}>";
289
+                        $rs .= "<{$typ}>".$this->getCharsetEncoder()->encodeEntities($val, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</{$typ}>";
290 290
                         break;
291 291
                     case static::$xmlrpcInt:
292 292
                     case static::$xmlrpcI4:
293 293
                     case static::$xmlrpcI8:
294
-                        $rs .= "<{$typ}>" . (int)$val . "</{$typ}>";
294
+                        $rs .= "<{$typ}>".(int) $val."</{$typ}>";
295 295
                         break;
296 296
                     case static::$xmlrpcDouble:
297 297
                         // avoid using standard conversion of float to string because it is locale-dependent,
@@ -299,16 +299,16 @@  discard block
 block discarded – undo
299 299
                         // sprintf('%F') could be most likely ok but it fails eg. on 2e-14.
300 300
                         // The code below tries its best at keeping max precision while avoiding exp notation,
301 301
                         // but there is of course no limit in the number of decimal places to be used...
302
-                        $rs .= "<{$typ}>" . preg_replace('/\\.?0+$/', '', number_format((double)$val, PhpXmlRpc::$xmlpc_double_precision, '.', '')) . "</{$typ}>";
302
+                        $rs .= "<{$typ}>".preg_replace('/\\.?0+$/', '', number_format((double) $val, PhpXmlRpc::$xmlpc_double_precision, '.', ''))."</{$typ}>";
303 303
                         break;
304 304
                     case static::$xmlrpcDateTime:
305 305
                         if (is_string($val)) {
306 306
                             $rs .= "<{$typ}>{$val}</{$typ}>";
307 307
                         // DateTimeInterface is not present in php 5.4...
308 308
                         } elseif (is_a($val, 'DateTimeInterface') || is_a($val, 'DateTime')) {
309
-                            $rs .= "<{$typ}>" . $val->format('Ymd\TH:i:s') . "</{$typ}>";
309
+                            $rs .= "<{$typ}>".$val->format('Ymd\TH:i:s')."</{$typ}>";
310 310
                         } elseif (is_int($val)) {
311
-                            $rs .= "<{$typ}>" . date('Ymd\TH:i:s', $val) . "</{$typ}>";
311
+                            $rs .= "<{$typ}>".date('Ymd\TH:i:s', $val)."</{$typ}>";
312 312
                         } else {
313 313
                             // not really a good idea here: but what should we output anyway? left for backward compat...
314 314
                             $rs .= "<{$typ}>{$val}</{$typ}>";
@@ -330,14 +330,14 @@  discard block
 block discarded – undo
330 330
             case 3:
331 331
                 // struct
332 332
                 if ($this->_php_class) {
333
-                    $rs .= '<struct php_class="' . $this->_php_class . "\">\n";
333
+                    $rs .= '<struct php_class="'.$this->_php_class."\">\n";
334 334
                 } else {
335 335
                     $rs .= "<struct>\n";
336 336
                 }
337 337
                 $charsetEncoder = $this->getCharsetEncoder();
338 338
                 /** @var Value $val2 */
339 339
                 foreach ($val as $key2 => $val2) {
340
-                    $rs .= '<member><name>' . $charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</name>\n";
340
+                    $rs .= '<member><name>'.$charsetEncoder->encodeEntities($key2, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</name>\n";
341 341
                     //$rs.=$this->serializeval($val2);
342 342
                     $rs .= $val2->serialize($charsetEncoding);
343 343
                     $rs .= "</member>\n";
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
         $val = reset($this->me);
374 374
         $typ = key($this->me);
375 375
 
376
-        return '<value>' . $this->serializedata($typ, $val, $charsetEncoding) . "</value>\n";
376
+        return '<value>'.$this->serializedata($typ, $val, $charsetEncoding)."</value>\n";
377 377
     }
378 378
 
379 379
     /**
Please login to merge, or discard this patch.