Passed
Push — master ( 5987e0...fe1d88 )
by Gaetano
09:19
created
tests/6HTTPTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/5ServerTest.php';
8
+include_once __DIR__.'/5ServerTest.php';
9 9
 
10 10
 /**
11 11
  * Tests which stress http features of the library.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         );
31 31
 
32 32
         $methods = array();
33
-        foreach(get_class_methods('ServerTest') as $method)
33
+        foreach (get_class_methods('ServerTest') as $method)
34 34
         {
35 35
             if (strpos($method, 'test') === 0 && !in_array($method, $unsafeMethods))
36 36
             {
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
                 preg_match('/ubunutu([0-9]+)/', $output[0], $matches);
272 272
                 $ubuntuVersion = @$matches[1];
273 273
             }
274
-            if ($ubuntuVersion >= 20) {
274
+            if ($ubuntuVersion>=20) {
275 275
                 $this->markTestSkipped('HTTPS via Socket known to fail on php less than 7.2 on Ubuntu 20 and higher');
276 276
                 return;
277 277
             }
Please login to merge, or discard this patch.
lib/xmlrpcs.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function echoInput()
56 56
     {
57
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
57
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
58 58
         print $r->serialize();
59 59
     }
60 60
 
@@ -65,12 +65,12 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function __get($name)
67 67
     {
68
-        switch($name) {
68
+        switch ($name) {
69 69
             case 'dmap':
70 70
                 return $this->dmap;
71 71
             default:
72 72
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
73
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' .
73
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.
74 74
                     $trace[0]['line'], E_USER_NOTICE);
75 75
                 return null;
76 76
         }
@@ -97,30 +97,30 @@  discard block
 block discarded – undo
97 97
     Server::xmlrpc_debugmsg($m);
98 98
 }
99 99
 
100
-function _xmlrpcs_getCapabilities($server, $m=null)
100
+function _xmlrpcs_getCapabilities($server, $m = null)
101 101
 {
102 102
     return Server::_xmlrpcs_getCapabilities($server, $m);
103 103
 }
104 104
 
105
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
107
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
108
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
105
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
107
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
108
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
109 109
 {
110 110
     return Server::_xmlrpcs_listMethods($server, $m);
111 111
 }
112 112
 
113
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
113
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
116 116
 function _xmlrpcs_methodSignature($server, $m)
117 117
 {
118 118
     return Server::_xmlrpcs_methodSignature($server, $m);
119 119
 }
120 120
 
121
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
123
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
121
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
123
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
124 124
 function _xmlrpcs_methodHelp($server, $m)
125 125
 {
126 126
     return Server::_xmlrpcs_methodHelp($server, $m);
Please login to merge, or discard this patch.
lib/xmlrpc_wrappers.inc 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
  * @param array $extraOptions
42 42
  * @return array|false
43 43
  */
44
-function wrap_php_function($funcName, $newFuncName='', $extraOptions=array())
44
+function wrap_php_function($funcName, $newFuncName = '', $extraOptions = array())
45 45
 {
46 46
     $wrapper = new PhpXmlRpc\Wrapper();
47
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
47
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
48 48
         // backwards compat: return string instead of callable
49 49
         $extraOptions['return_source'] = true;
50 50
         $wrapped = $wrapper->wrapPhpFunction($funcName, $newFuncName, $extraOptions);
@@ -64,17 +64,17 @@  discard block
 block discarded – undo
64 64
  * @param array $extraOptions
65 65
  * @return array|false
66 66
  */
67
-function wrap_php_class($className, $extraOptions=array())
67
+function wrap_php_class($className, $extraOptions = array())
68 68
 {
69 69
     $wrapper = new PhpXmlRpc\Wrapper();
70 70
     $fix = false;
71
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
71
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
72 72
         // backwards compat: return string instead of callable
73 73
         $extraOptions['return_source'] = true;
74 74
         $fix = true;
75 75
     }
76 76
     $wrapped = $wrapper->wrapPhpClass($className, $extraOptions);
77
-    foreach($wrapped as $name => $value) {
77
+    foreach ($wrapped as $name => $value) {
78 78
         if ($fix) {
79 79
             eval($value['source']);
80 80
         }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
  * @param string $newFuncName     deprecated, use an option in $extraOptions
94 94
  * @return array|callable|false
95 95
  */
96
-function wrap_xmlrpc_method($client, $methodName, $extraOptions=0, $timeout=0, $protocol='', $newFuncName='')
96
+function wrap_xmlrpc_method($client, $methodName, $extraOptions = 0, $timeout = 0, $protocol = '', $newFuncName = '')
97 97
 {
98 98
     if (!is_array($extraOptions))
99 99
     {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 
109 109
     $wrapper = new PhpXmlRpc\Wrapper();
110 110
 
111
-    if (!isset($extraOptions['return_source'])  || $extraOptions['return_source'] == false) {
111
+    if (!isset($extraOptions['return_source']) || $extraOptions['return_source'] == false) {
112 112
         // backwards compat: return string instead of callable
113 113
         $extraOptions['return_source'] = true;
114 114
         $wrapped = $wrapper->wrapXmlrpcMethod($client, $methodName, $extraOptions);
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
  * @param array $extraOptions
129 129
  * @return mixed
130 130
  */
131
-function wrap_xmlrpc_server($client, $extraOptions=array())
131
+function wrap_xmlrpc_server($client, $extraOptions = array())
132 132
 {
133 133
     $wrapper = new PhpXmlRpc\Wrapper();
134 134
     return $wrapper->wrapXmlrpcServer($client, $extraOptions);
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      $faultResponse = '', $namespace = '\\PhpXmlRpc\\')
149 149
 {
150 150
     $code = "function $xmlrpcFuncName (";
151
-    if ($clientCopyMode < 2) {
151
+    if ($clientCopyMode<2) {
152 152
         // client copy mode 0 or 1 == partial / full client copy in emitted code
153 153
         $innerCode = build_client_wrapper_code($client, $clientCopyMode, $prefix);
154 154
         $innerCode .= "\$client->setDebug(\$debug);\n";
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 
163 163
     if ($mDesc != '') {
164 164
         // take care that PHP comment is not terminated unwillingly by method description
165
-        $mDesc = "/**\n* " . str_replace('*/', '* /', $mDesc) . "\n";
165
+        $mDesc = "/**\n* ".str_replace('*/', '* /', $mDesc)."\n";
166 166
     } else {
167 167
         $mDesc = "/**\nFunction $xmlrpcFuncName\n";
168 168
     }
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
     $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
172 172
     $plist = array();
173 173
     $pCount = count($mSig);
174
-    for ($i = 1; $i < $pCount; $i++) {
174
+    for ($i = 1; $i<$pCount; $i++) {
175 175
         $plist[] = "\$p$i";
176 176
         $pType = $mSig[$i];
177 177
         if ($pType == 'i4' || $pType == 'i8' || $pType == 'int' || $pType == 'boolean' || $pType == 'double' ||
@@ -187,19 +187,19 @@  discard block
 block discarded – undo
187 187
             }
188 188
         }
189 189
         $innerCode .= "\$req->addparam(\$p$i);\n";
190
-        $mDesc .= '* @param ' . xmlrpc_2_php_type($pType) . " \$p$i\n";
190
+        $mDesc .= '* @param '.xmlrpc_2_php_type($pType)." \$p$i\n";
191 191
     }
192
-    if ($clientCopyMode < 2) {
192
+    if ($clientCopyMode<2) {
193 193
         $plist[] = '$debug=0';
194 194
         $mDesc .= "* @param int \$debug when 1 (or 2) will enable debugging of the underlying {$prefix} call (defaults to 0)\n";
195 195
     }
196 196
     $plist = implode(', ', $plist);
197
-    $mDesc .= '* @return ' . xmlrpc_2_php_type($mSig[0]) . " (or an {$namespace}Response obj instance if call fails)\n*/\n";
197
+    $mDesc .= '* @return '.xmlrpc_2_php_type($mSig[0])." (or an {$namespace}Response obj instance if call fails)\n*/\n";
198 198
 
199 199
     $innerCode .= "\$res = \${$this_}client->send(\$req, $timeout, '$protocol');\n";
200 200
     if ($decodeFault) {
201 201
         if (is_string($faultResponse) && ((strpos($faultResponse, '%faultCode%') !== false) || (strpos($faultResponse, '%faultString%') !== false))) {
202
-            $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '" . str_replace("'", "''", $faultResponse) . "')";
202
+            $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '".str_replace("'", "''", $faultResponse)."')";
203 203
         } else {
204 204
             $respCode = var_export($faultResponse, true);
205 205
         }
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         $innerCode .= "if (\$res->faultcode()) return $respCode; else return \$encoder->decode(\$res->value());";
213 213
     }
214 214
 
215
-    $code = $code . $plist . ") {\n" . $innerCode . "\n}\n";
215
+    $code = $code.$plist.") {\n".$innerCode."\n}\n";
216 216
 
217 217
     return array('source' => $code, 'docstring' => $mDesc);
218 218
 }
@@ -220,10 +220,10 @@  discard block
 block discarded – undo
220 220
 /**
221 221
  * @deprecated
222 222
  */
223
-function build_client_wrapper_code($client, $verbatim_client_copy, $prefix='xmlrpc')
223
+function build_client_wrapper_code($client, $verbatim_client_copy, $prefix = 'xmlrpc')
224 224
 {
225 225
     $code = "\$client = new {$prefix}_client('".str_replace("'", "\'", $client->path).
226
-        "', '" . str_replace("'", "\'", $client->server) . "', $client->port);\n";
226
+        "', '".str_replace("'", "\'", $client->server)."', $client->port);\n";
227 227
 
228 228
     // copy all client fields to the client that will be generated runtime
229 229
     // (this provides for future expansion or subclassing of client obj)
Please login to merge, or discard this patch.
tests/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777);
16 16
     }
17 17
 
18
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
18
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
19 19
 }
20 20
 
21 21
 $targetFile = null;
@@ -38,5 +38,5 @@  discard block
 block discarded – undo
38 38
 }
39 39
 
40 40
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
41
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
41
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
42 42
 }
Please login to merge, or discard this patch.
src/Response.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -151,35 +151,35 @@  discard block
 block discarded – undo
151 151
     public function serialize($charsetEncoding = '')
152 152
     {
153 153
         if ($charsetEncoding != '') {
154
-            $this->content_type = 'text/xml; charset=' . $charsetEncoding;
154
+            $this->content_type = 'text/xml; charset='.$charsetEncoding;
155 155
         } else {
156 156
             $this->content_type = 'text/xml';
157 157
         }
158 158
         if (PhpXmlRpc::$xmlrpc_null_apache_encoding) {
159
-            $result = "<methodResponse xmlns:ex=\"" . PhpXmlRpc::$xmlrpc_null_apache_encoding_ns . "\">\n";
159
+            $result = "<methodResponse xmlns:ex=\"".PhpXmlRpc::$xmlrpc_null_apache_encoding_ns."\">\n";
160 160
         } else {
161 161
             $result = "<methodResponse>\n";
162 162
         }
163 163
         if ($this->errno) {
164 164
             // Let non-ASCII response messages be tolerated by clients by xml-encoding non ascii chars
165
-            $result .= "<fault>\n" .
166
-                "<value>\n<struct><member><name>faultCode</name>\n<value><int>" . $this->errno .
167
-                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>" .
168
-                Charset::instance()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "</string></value>\n</member>\n" .
165
+            $result .= "<fault>\n".
166
+                "<value>\n<struct><member><name>faultCode</name>\n<value><int>".$this->errno.
167
+                "</int></value>\n</member>\n<member>\n<name>faultString</name>\n<value><string>".
168
+                Charset::instance()->encodeEntities($this->errstr, PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."</string></value>\n</member>\n".
169 169
                 "</struct>\n</value>\n</fault>";
170 170
         } else {
171 171
             if (!is_object($this->val) || !is_a($this->val, 'PhpXmlRpc\Value')) {
172 172
                 if (is_string($this->val) && $this->valtyp == 'xml') {
173
-                    $result .= "<params>\n<param>\n" .
174
-                        $this->val .
173
+                    $result .= "<params>\n<param>\n".
174
+                        $this->val.
175 175
                         "</param>\n</params>";
176 176
                 } else {
177 177
                     /// @todo try to build something serializable using the Encoder...
178 178
                     throw new \Exception('cannot serialize xmlrpc response objects whose content is native php values');
179 179
                 }
180 180
             } else {
181
-                $result .= "<params>\n<param>\n" .
182
-                    $this->val->serialize($charsetEncoding) .
181
+                $result .= "<params>\n<param>\n".
182
+                    $this->val->serialize($charsetEncoding).
183 183
                     "</param>\n</params>";
184 184
             }
185 185
         }
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
                 return $this->httpResponse['raw_data'];
205 205
             default:
206 206
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
207
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
207
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
208 208
                 return null;
209 209
         }
210 210
     }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
                 break;
226 226
             default:
227 227
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
228
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
228
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
229 229
         }
230 230
     }
231 231
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
                 break;
258 258
             default:
259 259
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
260
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
260
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
261 261
         }
262 262
     }
263 263
 }
Please login to merge, or discard this patch.
debugger/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 if (isset($_GET['run'])) {
5 5
     $path = parse_url($_GET['run']);
6 6
     if (isset($path['query'])) {
7
-        $query = '?' . $path['query'];
7
+        $query = '?'.$path['query'];
8 8
     }
9 9
 }
10 10
 
Please login to merge, or discard this patch.
debugger/action.php 1 patch
Spacing   +114 added lines, -114 removed lines patch added patch discarded remove patch
@@ -90,13 +90,13 @@  discard block
 block discarded – undo
90 90
 <body>
91 91
 <?php
92 92
 
93
-include __DIR__ . '/common.php';
93
+include __DIR__.'/common.php';
94 94
 
95 95
 if ($action) {
96 96
 
97 97
     // avoid php hanging when using the builtin webserver and sending requests to itself
98 98
     $skip = false;
99
-    if (php_sapi_name() === 'cli-server' && ((int)getenv('PHP_CLI_SERVER_WORKERS') < 2)) {
99
+    if (php_sapi_name() === 'cli-server' && ((int) getenv('PHP_CLI_SERVER_WORKERS')<2)) {
100 100
         $localHost = explode(':', $_SERVER['HTTP_HOST']);
101 101
         /// @todo support also case where port is null (on either side), and when there is a Proxy in the parameters,
102 102
         ///       and that proxy is us
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
     if (!$skip) {
110 110
         // make sure the script waits long enough for the call to complete...
111 111
         if ($timeout) {
112
-            set_time_limit($timeout + 10);
112
+            set_time_limit($timeout+10);
113 113
         }
114 114
 
115 115
         if ($wstype == 1) {
@@ -133,13 +133,13 @@  discard block
 block discarded – undo
133 133
             $server = "$host$path";
134 134
         }
135 135
         if ($protocol == 2 || $protocol == 3) {
136
-            $server = 'https://' . $server;
136
+            $server = 'https://'.$server;
137 137
         } else {
138
-            $server = 'http://' . $server;
138
+            $server = 'http://'.$server;
139 139
         }
140 140
         if ($proxy != '') {
141 141
             $pproxy = explode(':', $proxy);
142
-            if (count($pproxy) > 1) {
142
+            if (count($pproxy)>1) {
143 143
                 $pport = $pproxy[1];
144 144
             } else {
145 145
                 $pport = 8080;
@@ -214,9 +214,9 @@  discard block
 block discarded – undo
214 214
             case 'wrap':
215 215
                 $msg[0] = new $requestClass('system.methodHelp', array(), $id);
216 216
                 $msg[0]->addparam(new PhpXmlRpc\Value($method));
217
-                $msg[1] = new $requestClass('system.methodSignature', array(), (int)$id + 1);
217
+                $msg[1] = new $requestClass('system.methodSignature', array(), (int) $id+1);
218 218
                 $msg[1]->addparam(new PhpXmlRpc\Value($method));
219
-                $actionname = 'Description of method "' . $method . '"';
219
+                $actionname = 'Description of method "'.$method.'"';
220 220
                 break;
221 221
             case 'list':
222 222
                 $msg[0] = new $requestClass('system.listMethods', array(), $id);
@@ -229,9 +229,9 @@  discard block
 block discarded – undo
229 229
                 $msg[0] = new $requestClass($method, array(), $id);
230 230
                 // hack! build xml payload by hand
231 231
                 if ($wstype == 1) {
232
-                    $msg[0]->payload = "{\n" .
233
-                        '"method": "' . $method . "\",\n\"params\": [" .
234
-                        $payload .
232
+                    $msg[0]->payload = "{\n".
233
+                        '"method": "'.$method."\",\n\"params\": [".
234
+                        $payload.
235 235
                         "\n],\n\"id\": ";
236 236
                     // fix: if user gave an empty string, use NULL, or we'll break json syntax
237 237
                     if ($id == "") {
@@ -244,21 +244,21 @@  discard block
 block discarded – undo
244 244
                         }
245 245
                     }
246 246
                 } else {
247
-                    $msg[0]->payload = $msg[0]->xml_header($inputcharset) .
248
-                        '<methodName>' . $method . "</methodName>\n<params>" .
249
-                        $payload .
250
-                        "</params>\n" . $msg[0]->xml_footer();
247
+                    $msg[0]->payload = $msg[0]->xml_header($inputcharset).
248
+                        '<methodName>'.$method."</methodName>\n<params>".
249
+                        $payload.
250
+                        "</params>\n".$msg[0]->xml_footer();
251 251
                 }
252
-                $actionname = 'Execution of method ' . $method;
252
+                $actionname = 'Execution of method '.$method;
253 253
                 break;
254 254
             default: // give a warning
255
-                $actionname = '[ERROR: unknown action] "' . $action . '"';
255
+                $actionname = '[ERROR: unknown action] "'.$action.'"';
256 256
         }
257 257
     }
258 258
 
259 259
     // Before calling execute, echo out brief description of action taken + date and time ???
260 260
     // this gives good user feedback for long-running methods...
261
-    echo '<h2>' . htmlspecialchars($actionname, ENT_COMPAT, $inputcharset) . ' on server ' . htmlspecialchars($server, ENT_COMPAT, $inputcharset) . " ...</h2>\n";
261
+    echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset)." ...</h2>\n";
262 262
     flush();
263 263
 
264 264
     $response = null;
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
             break;
276 276
         }
277 277
     }
278
-    $time = microtime(true) - $time;
278
+    $time = microtime(true)-$time;
279 279
     if ($debug) {
280 280
         echo "</div>\n";
281 281
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
             // call failed! echo out error msg!
286 286
             //echo '<h2>'.htmlspecialchars($actionname, ENT_COMPAT, $inputcharset).' on server '.htmlspecialchars($server, ENT_COMPAT, $inputcharset).'</h2>';
287 287
             echo "<h3>$protoName call FAILED!</h3>\n";
288
-            echo "<p>Fault code: [" . htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
289
-                "] Reason: '" . htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "'</p>\n";
288
+            echo "<p>Fault code: [".htmlspecialchars($response->faultCode(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
289
+                "] Reason: '".htmlspecialchars($response->faultString(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."'</p>\n";
290 290
             echo(date("d/M/Y:H:i:s\n"));
291 291
         } else {
292 292
             // call succeeded: parse results
@@ -302,36 +302,36 @@  discard block
 block discarded – undo
302 302
                         $max = $v->count();
303 303
                         echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
304 304
                         echo "<thead>\n<tr><th>Method ($max)</th><th>Description</th></tr>\n</thead>\n<tbody>\n";
305
-                        foreach($v as $i => $rec) {
305
+                        foreach ($v as $i => $rec) {
306 306
                             if ($i % 2) {
307 307
                                 $class = ' class="oddrow"';
308 308
                             } else {
309 309
                                 $class = ' class="evenrow"';
310 310
                             }
311
-                            echo("<tr><td$class>" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">" .
312
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
313
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
314
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
315
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
316
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
317
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
318
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
319
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
320
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
321
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
322
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
323
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
324
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
325
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
326
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
327
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
328
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
329
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
330
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
331
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "\" />" .
332
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
333
-                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />" .
334
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
311
+                            echo("<tr><td$class>".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."</td><td$class><form action=\"controller.php\" method=\"get\" target=\"frmcontroller\">".
312
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
313
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
314
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
315
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
316
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
317
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
318
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
319
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
320
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
321
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
322
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
323
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
324
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
325
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
326
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
327
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
328
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
329
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
330
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
331
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($rec->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."\" />".
332
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
333
+                                "<input type=\"hidden\" name=\"action\" value=\"describe\" />".
334
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
335 335
                                 "<input type=\"submit\" value=\"Describe\" /></form></td>");
336 336
                             //echo("</tr>\n");
337 337
 
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
                     $r2 = $resp[1]->value();
359 359
 
360 360
                     echo "<table border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
361
-                    echo "<thead>\n<tr><th>Method</th><th>" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
361
+                    echo "<thead>\n<tr><th>Method</th><th>".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."</th><th>&nbsp;</th><th>&nbsp;</th></tr>\n</thead>\n<tbody>\n";
362 362
                     $desc = htmlspecialchars($r1->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
363 363
                     if ($desc == "") {
364 364
                         $desc = "-";
@@ -368,41 +368,41 @@  discard block
 block discarded – undo
368 368
                     if ($r2->kindOf() != "array") {
369 369
                         echo "<tr><td class=\"oddrow\">Signature</td><td class=\"oddrow\">Unknown</td><td class=\"oddrow\">&nbsp;</td></tr>\n";
370 370
                     } else {
371
-                        foreach($r2 as $i => $x) {
371
+                        foreach ($r2 as $i => $x) {
372 372
                             $payload = "";
373 373
                             $alt_payload = "";
374
-                            if ($i + 1 % 2) {
374
+                            if ($i+1 % 2) {
375 375
                                 $class = ' class="oddrow"';
376 376
                             } else {
377 377
                                 $class = ' class="evenrow"';
378 378
                             }
379
-                            echo "<tr><td$class>Signature&nbsp;" . ($i + 1) . "</td><td$class>";
379
+                            echo "<tr><td$class>Signature&nbsp;".($i+1)."</td><td$class>";
380 380
                             if ($x->kindOf() == "array") {
381 381
                                 $ret = $x[0];
382
-                                echo "<code>OUT:&nbsp;" . htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) . "<br />IN: (";
383
-                                if ($x->count() > 1) {
384
-                                    foreach($x as $k => $y) {
382
+                                echo "<code>OUT:&nbsp;".htmlspecialchars($ret->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding)."<br />IN: (";
383
+                                if ($x->count()>1) {
384
+                                    foreach ($x as $k => $y) {
385 385
                                         if ($k == 0) continue;
386 386
                                         echo htmlspecialchars($y->scalarval(), ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding);
387 387
                                         if ($wstype != 1) {
388 388
                                             $type = $y->scalarval();
389 389
                                             $payload .= '<param><value>';
390
-                                            switch($type) {
390
+                                            switch ($type) {
391 391
                                                 case 'undefined':
392 392
                                                     break;
393 393
                                                 case 'null';
394 394
                                                     $type = 'nil';
395 395
                                                     // fall thru intentionally
396 396
                                                 default:
397
-                                                    $payload .= '<' .
398
-                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
399
-                                                        '></' . htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding) .
397
+                                                    $payload .= '<'.
398
+                                                        htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
399
+                                                        '></'.htmlspecialchars($type, ENT_COMPAT, \PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding).
400 400
                                                         '>';
401 401
                                             }
402 402
                                             $payload .= "</value></param>\n";
403 403
                                         }
404 404
                                         $alt_payload .= $y->scalarval();
405
-                                        if ($k < $x->count() - 1) {
405
+                                        if ($k<$x->count()-1) {
406 406
                                             $alt_payload .= ';';
407 407
                                             echo ", ";
408 408
                                         }
@@ -415,63 +415,63 @@  discard block
 block discarded – undo
415 415
                             echo '</td>';
416 416
                             // button to test this method
417 417
                             //$payload="<methodCall>\n<methodName>$method</methodName>\n<params>\n$payload</params>\n</methodCall>";
418
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
419
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
420
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
421
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
422
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
423
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
424
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
425
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
426
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
427
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
428
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
429
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
430
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
431
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
432
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
433
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
434
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
435
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
436
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
437
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
438
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
439
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
440
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
441
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
418
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
419
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
420
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
421
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
422
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
423
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
424
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
425
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
426
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
427
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
428
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
429
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
430
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
431
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
432
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
433
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
434
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
435
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
436
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
437
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
438
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
439
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
440
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
441
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
442 442
                                 "<input type=\"hidden\" name=\"action\" value=\"execute\" />";
443 443
                             if ($wstype != 1) {
444 444
                                 echo "<input type=\"submit\" value=\"Load method synopsis\" />";
445 445
                             }
446 446
                             echo "</form></td>\n";
447 447
 
448
-                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">" .
449
-                                "<input type=\"hidden\" name=\"host\" value=\"" . htmlspecialchars($host, ENT_COMPAT, $inputcharset) . "\" />" .
450
-                                "<input type=\"hidden\" name=\"port\" value=\"" . htmlspecialchars($port, ENT_COMPAT, $inputcharset) . "\" />" .
451
-                                "<input type=\"hidden\" name=\"path\" value=\"" . htmlspecialchars($path, ENT_COMPAT, $inputcharset) . "\" />" .
452
-                                "<input type=\"hidden\" name=\"id\" value=\"" . htmlspecialchars($id, ENT_COMPAT, $inputcharset) . "\" />" .
453
-                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />" .
454
-                                "<input type=\"hidden\" name=\"username\" value=\"" . htmlspecialchars($username, ENT_COMPAT, $inputcharset) . "\" />" .
455
-                                "<input type=\"hidden\" name=\"password\" value=\"" . htmlspecialchars($password, ENT_COMPAT, $inputcharset) . "\" />" .
456
-                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />" .
457
-                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />" .
458
-                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />" .
459
-                                "<input type=\"hidden\" name=\"cainfo\" value=\"" . htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset) . "\" />" .
460
-                                "<input type=\"hidden\" name=\"proxy\" value=\"" . htmlspecialchars($proxy, ENT_COMPAT, $inputcharset) . "\" />" .
461
-                                "<input type=\"hidden\" name=\"proxyuser\" value=\"" . htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset) . "\" />" .
462
-                                "<input type=\"hidden\" name=\"proxypwd\" value=\"" . htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset) . "\" />" .
463
-                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />" .
464
-                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />" .
465
-                                "<input type=\"hidden\" name=\"clientcookies\" value=\"" . htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset) . "\" />" .
466
-                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />" .
467
-                                "<input type=\"hidden\" name=\"timeout\" value=\"" . htmlspecialchars($timeout, ENT_COMPAT, $inputcharset) . "\" />" .
468
-                                "<input type=\"hidden\" name=\"method\" value=\"" . htmlspecialchars($method, ENT_COMPAT, $inputcharset) . "\" />" .
469
-                                "<input type=\"hidden\" name=\"methodsig\" value=\"" . $i . "\" />" .
470
-                                "<input type=\"hidden\" name=\"methodpayload\" value=\"" . htmlspecialchars($payload, ENT_COMPAT, $inputcharset) . "\" />" .
471
-                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"" . htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset) . "\" />" .
472
-                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />" .
473
-                                "<input type=\"hidden\" name=\"run\" value=\"now\" />" .
474
-                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />" .
448
+                            echo "<td$class><form action=\"controller.php\" target=\"frmcontroller\" method=\"get\">".
449
+                                "<input type=\"hidden\" name=\"host\" value=\"".htmlspecialchars($host, ENT_COMPAT, $inputcharset)."\" />".
450
+                                "<input type=\"hidden\" name=\"port\" value=\"".htmlspecialchars($port, ENT_COMPAT, $inputcharset)."\" />".
451
+                                "<input type=\"hidden\" name=\"path\" value=\"".htmlspecialchars($path, ENT_COMPAT, $inputcharset)."\" />".
452
+                                "<input type=\"hidden\" name=\"id\" value=\"".htmlspecialchars($id, ENT_COMPAT, $inputcharset)."\" />".
453
+                                "<input type=\"hidden\" name=\"debug\" value=\"$debug\" />".
454
+                                "<input type=\"hidden\" name=\"username\" value=\"".htmlspecialchars($username, ENT_COMPAT, $inputcharset)."\" />".
455
+                                "<input type=\"hidden\" name=\"password\" value=\"".htmlspecialchars($password, ENT_COMPAT, $inputcharset)."\" />".
456
+                                "<input type=\"hidden\" name=\"authtype\" value=\"$authtype\" />".
457
+                                "<input type=\"hidden\" name=\"verifyhost\" value=\"$verifyhost\" />".
458
+                                "<input type=\"hidden\" name=\"verifypeer\" value=\"$verifypeer\" />".
459
+                                "<input type=\"hidden\" name=\"cainfo\" value=\"".htmlspecialchars($cainfo, ENT_COMPAT, $inputcharset)."\" />".
460
+                                "<input type=\"hidden\" name=\"proxy\" value=\"".htmlspecialchars($proxy, ENT_COMPAT, $inputcharset)."\" />".
461
+                                "<input type=\"hidden\" name=\"proxyuser\" value=\"".htmlspecialchars($proxyuser, ENT_COMPAT, $inputcharset)."\" />".
462
+                                "<input type=\"hidden\" name=\"proxypwd\" value=\"".htmlspecialchars($proxypwd, ENT_COMPAT, $inputcharset)."\" />".
463
+                                "<input type=\"hidden\" name=\"responsecompression\" value=\"$responsecompression\" />".
464
+                                "<input type=\"hidden\" name=\"requestcompression\" value=\"$requestcompression\" />".
465
+                                "<input type=\"hidden\" name=\"clientcookies\" value=\"".htmlspecialchars($clientcookies, ENT_COMPAT, $inputcharset)."\" />".
466
+                                "<input type=\"hidden\" name=\"protocol\" value=\"$protocol\" />".
467
+                                "<input type=\"hidden\" name=\"timeout\" value=\"".htmlspecialchars($timeout, ENT_COMPAT, $inputcharset)."\" />".
468
+                                "<input type=\"hidden\" name=\"method\" value=\"".htmlspecialchars($method, ENT_COMPAT, $inputcharset)."\" />".
469
+                                "<input type=\"hidden\" name=\"methodsig\" value=\"".$i."\" />".
470
+                                "<input type=\"hidden\" name=\"methodpayload\" value=\"".htmlspecialchars($payload, ENT_COMPAT, $inputcharset)."\" />".
471
+                                "<input type=\"hidden\" name=\"altmethodpayload\" value=\"".htmlspecialchars($alt_payload, ENT_COMPAT, $inputcharset)."\" />".
472
+                                "<input type=\"hidden\" name=\"wstype\" value=\"$wstype\" />".
473
+                                "<input type=\"hidden\" name=\"run\" value=\"now\" />".
474
+                                "<input type=\"hidden\" name=\"action\" value=\"wrap\" />".
475 475
                                 "<input type=\"submit\" value=\"Generate method call stub code\" />";
476 476
                             echo "</form></td></tr>\n";
477 477
                         }
@@ -483,14 +483,14 @@  discard block
 block discarded – undo
483 483
                 case 'wrap':
484 484
                     $r1 = $resp[0]->value();
485 485
                     $r2 = $resp[1]->value();
486
-                    if ($r2->kindOf() != "array" || $r2->count() <= $methodsig) {
486
+                    if ($r2->kindOf() != "array" || $r2->count()<=$methodsig) {
487 487
                         echo "Error: signature unknown\n";
488 488
                     } else {
489 489
                         $mdesc = $r1->scalarval();
490 490
                         $encoder = new PhpXmlRpc\Encoder();
491 491
                         $msig = $encoder->decode($r2);
492 492
                         $msig = $msig[$methodsig];
493
-                        $proto = ($protocol == 1) ? 'http11' : ( $protocol == 2 ? 'https' : ( $protocol == 3 ? 'h2' : ( $protocol == 4 ? 'h2c' : '' ) ) );
493
+                        $proto = ($protocol == 1) ? 'http11' : ($protocol == 2 ? 'https' : ($protocol == 3 ? 'h2' : ($protocol == 4 ? 'h2c' : '')));
494 494
                         if ($proxy == '' && $username == '' && !$requestcompression && !$responsecompression &&
495 495
                             $clientcookies == ''
496 496
                         ) {
@@ -504,11 +504,11 @@  discard block
 block discarded – undo
504 504
                             $prefix = 'xmlrpc';
505 505
                         }
506 506
                         $wrapper = new PhpXmlRpc\Wrapper();
507
-                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix . '_' . $method), $msig, $mdesc);
507
+                        $code = $wrapper->buildWrapMethodSource($client, $method, array('timeout' => $timeout, 'protocol' => $proto, 'simple_client_copy' => $opts, 'prefix' => $prefix), str_replace('.', '_', $prefix.'_'.$method), $msig, $mdesc);
508 508
                         //if ($code)
509 509
                         //{
510 510
                         echo "<div id=\"phpcode\">\n";
511
-                        highlight_string("<?php\n" . $code['docstring'] . $code['source'] . '?>');
511
+                        highlight_string("<?php\n".$code['docstring'].$code['source'].'?>');
512 512
                         echo "\n</div>";
513 513
                         //}
514 514
                         //else
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
                     break;
520 520
 
521 521
                 case 'execute':
522
-                    echo '<div id="response"><h2>Response:</h2>' . htmlspecialchars($response->serialize()) . '</div>';
522
+                    echo '<div id="response"><h2>Response:</h2>'.htmlspecialchars($response->serialize()).'</div>';
523 523
                     break;
524 524
 
525 525
                 default: // give a warning
Please login to merge, or discard this patch.
debugger/common.php 1 patch
Spacing   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     // assume this is either a standalone install, or installed as Composer dependency
21 21
     /// @todo if the latter is true, should we just not skip using the custom Autoloader, and let a top-level
22 22
     ///       debugger include this one, taking care of autoloading?
23
-    include_once __DIR__ . "/../src/Autoloader.php";
23
+    include_once __DIR__."/../src/Autoloader.php";
24 24
     PhpXmlRpc\Autoloader::register();
25 25
 }
26 26
 
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         }
35 35
 
36 36
         // Variables that shouldn't be unset
37
-        $noUnset = array('GLOBALS',  '_GET', '_POST', '_COOKIE', '_REQUEST', '_SERVER', '_ENV', '_FILES');
37
+        $noUnset = array('GLOBALS', '_GET', '_POST', '_COOKIE', '_REQUEST', '_SERVER', '_ENV', '_FILES');
38 38
 
39 39
         $input = array_merge($_GET, $_POST, $_COOKIE, $_SERVER, $_ENV, $_FILES,
40 40
             isset($_SESSION) && is_array($_SESSION) ? $_SESSION : array()
@@ -54,8 +54,7 @@  discard block
 block discarded – undo
54 54
     function stripslashes_deep($value)
55 55
     {
56 56
         $value = is_array($value) ?
57
-            array_map('stripslashes_deep', $value) :
58
-            stripslashes($value);
57
+            array_map('stripslashes_deep', $value) : stripslashes($value);
59 58
 
60 59
         return $value;
61 60
     }
@@ -105,7 +104,7 @@  discard block
 block discarded – undo
105 104
     $path = isset($_GET['path']) ? $_GET['path'] : '';
106 105
     // in case user forgot initial '/' in xmlrpc server path, add it back
107 106
     if ($path && ($path[0]) != '/') {
108
-        $path = '/' . $path;
107
+        $path = '/'.$path;
109 108
     }
110 109
 
111 110
     if (isset($_GET['debug']) && ($_GET['debug'] == '1' || $_GET['debug'] == '2')) {
Please login to merge, or discard this patch.
src/Wrapper.php 1 patch
Spacing   +71 added lines, -71 removed lines patch added patch discarded remove patch
@@ -182,20 +182,20 @@  discard block
 block discarded – undo
182 182
             $callable = explode('::', $callable);
183 183
         }
184 184
         if (is_array($callable)) {
185
-            if (count($callable) < 2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
186
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': syntax for function to be wrapped is wrong');
185
+            if (count($callable)<2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
186
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': syntax for function to be wrapped is wrong');
187 187
                 return false;
188 188
             }
189 189
             if (is_string($callable[0])) {
190 190
                 $plainFuncName = implode('::', $callable);
191 191
             } elseif (is_object($callable[0])) {
192
-                $plainFuncName = get_class($callable[0]) . '->' . $callable[1];
192
+                $plainFuncName = get_class($callable[0]).'->'.$callable[1];
193 193
             }
194 194
             $exists = method_exists($callable[0], $callable[1]);
195 195
         } else if ($callable instanceof \Closure) {
196 196
             // we do not support creating code which wraps closures, as php does not allow to serialize them
197 197
             if (!$buildIt) {
198
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': a closure can not be wrapped in generated source code');
198
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': a closure can not be wrapped in generated source code');
199 199
                 return false;
200 200
             }
201 201
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         }
208 208
 
209 209
         if (!$exists) {
210
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': function to be wrapped is not defined: ' . $plainFuncName);
210
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': function to be wrapped is not defined: '.$plainFuncName);
211 211
             return false;
212 212
         }
213 213
 
@@ -251,23 +251,23 @@  discard block
 block discarded – undo
251 251
         if (is_array($callable)) {
252 252
             $func = new \ReflectionMethod($callable[0], $callable[1]);
253 253
             if ($func->isPrivate()) {
254
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is private: ' . $plainFuncName);
254
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is private: '.$plainFuncName);
255 255
                 return false;
256 256
             }
257 257
             if ($func->isProtected()) {
258
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is protected: ' . $plainFuncName);
258
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is protected: '.$plainFuncName);
259 259
                 return false;
260 260
             }
261 261
             if ($func->isConstructor()) {
262
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the constructor: ' . $plainFuncName);
262
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is the constructor: '.$plainFuncName);
263 263
                 return false;
264 264
             }
265 265
             if ($func->isDestructor()) {
266
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the destructor: ' . $plainFuncName);
266
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is the destructor: '.$plainFuncName);
267 267
                 return false;
268 268
             }
269 269
             if ($func->isAbstract()) {
270
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is abstract: ' . $plainFuncName);
270
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is abstract: '.$plainFuncName);
271 271
                 return false;
272 272
             }
273 273
             /// @todo add more checks for static vs. nonstatic?
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
         if ($func->isInternal()) {
278 278
             /// @todo from PHP 5.1.0 onward, we should be able to use invokeargs instead of getparameters to fully
279 279
             ///       reflect internal php functions
280
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': function to be wrapped is internal: ' . $plainFuncName);
280
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': function to be wrapped is internal: '.$plainFuncName);
281 281
             return false;
282 282
         }
283 283
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
         $i = 0;
330 330
         foreach ($func->getParameters() as $paramObj) {
331 331
             $params[$i] = array();
332
-            $params[$i]['name'] = '$' . $paramObj->getName();
332
+            $params[$i]['name'] = '$'.$paramObj->getName();
333 333
             $params[$i]['isoptional'] = $paramObj->isOptional();
334 334
             $i++;
335 335
         }
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             // build a signature
394 394
             $sig = array($this->php2XmlrpcType($funcDesc['returns']));
395 395
             $pSig = array($funcDesc['returnsDocs']);
396
-            for ($i = 0; $i < count($pars); $i++) {
396
+            for ($i = 0; $i<count($pars); $i++) {
397 397
                 $name = strtolower($funcDesc['params'][$i]['name']);
398 398
                 if (isset($funcDesc['paramDocs'][$name]['type'])) {
399 399
                     $sig[] = $this->php2XmlrpcType($funcDesc['paramDocs'][$name]['type']);
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
                 }
451 451
             }
452 452
             $numPars = $req->getNumParams();
453
-            if ($numPars < $minPars || $numPars > $maxPars) {
453
+            if ($numPars<$minPars || $numPars>$maxPars) {
454 454
                 return new $responseClass(0, 3, 'Incorrect parameters passed to method');
455 455
             }
456 456
 
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 
464 464
             $result = call_user_func_array($callable, $params);
465 465
 
466
-            if (! is_a($result, $responseClass)) {
466
+            if (!is_a($result, $responseClass)) {
467 467
                 if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
468 468
                     $result = new $valueClass($result, $funcDesc['returns']);
469 469
                 } else {
@@ -498,9 +498,9 @@  discard block
 block discarded – undo
498 498
         if ($newFuncName == '') {
499 499
             if (is_array($callable)) {
500 500
                 if (is_string($callable[0])) {
501
-                    $xmlrpcFuncName = "{$prefix}_" . implode('_', $callable);
501
+                    $xmlrpcFuncName = "{$prefix}_".implode('_', $callable);
502 502
                 } else {
503
-                    $xmlrpcFuncName = "{$prefix}_" . get_class($callable[0]) . '_' . $callable[1];
503
+                    $xmlrpcFuncName = "{$prefix}_".get_class($callable[0]).'_'.$callable[1];
504 504
                 }
505 505
             } else {
506 506
                 if ($callable instanceof \Closure) {
@@ -536,8 +536,8 @@  discard block
 block discarded – undo
536 536
     {
537 537
         $namespace = '\\PhpXmlRpc\\';
538 538
 
539
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
540
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
539
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
540
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
541 541
         $catchWarnings = isset($extraOptions['suppress_warnings']) && $extraOptions['suppress_warnings'] ? '@' : '';
542 542
 
543 543
         $i = 0;
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
         // build body of new function
573 573
 
574 574
         $innerCode = "\$paramCount = \$req->getNumParams();\n";
575
-        $innerCode .= "if (\$paramCount < $minPars || \$paramCount > $maxPars) return new {$namespace}Response(0, " . PhpXmlRpc::$xmlrpcerr['incorrect_params'] . ", '" . PhpXmlRpc::$xmlrpcstr['incorrect_params'] . "');\n";
575
+        $innerCode .= "if (\$paramCount < $minPars || \$paramCount > $maxPars) return new {$namespace}Response(0, ".PhpXmlRpc::$xmlrpcerr['incorrect_params'].", '".PhpXmlRpc::$xmlrpcstr['incorrect_params']."');\n";
576 576
 
577 577
         $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
578 578
         if ($decodePhpObjects) {
@@ -586,13 +586,13 @@  discard block
 block discarded – undo
586 586
         if (is_array($callable) && is_object($callable[0])) {
587 587
             self::$objHolder[$newFuncName] = $callable[0];
588 588
             $innerCode .= "\$obj = PhpXmlRpc\\Wrapper::\$objHolder['$newFuncName'];\n";
589
-            $realFuncName = '$obj->' . $callable[1];
589
+            $realFuncName = '$obj->'.$callable[1];
590 590
         } else {
591 591
             $realFuncName = $plainFuncName;
592 592
         }
593 593
         foreach ($parsVariations as $i => $pars) {
594
-            $innerCode .= "if (\$paramCount == " . count($pars) . ") \$retval = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
595
-            if ($i < (count($parsVariations) - 1))
594
+            $innerCode .= "if (\$paramCount == ".count($pars).") \$retval = {$catchWarnings}$realFuncName(".implode(',', $pars).");\n";
595
+            if ($i<(count($parsVariations)-1))
596 596
                 $innerCode .= "else\n";
597 597
         }
598 598
         $innerCode .= "if (is_a(\$retval, '{$namespace}Response')) return \$retval; else\n";
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
         // if ($func->returnsReference())
610 610
         //     return false;
611 611
 
612
-        $code = "function $newFuncName(\$req) {\n" . $innerCode . "\n}";
612
+        $code = "function $newFuncName(\$req) {\n".$innerCode."\n}";
613 613
 
614 614
         return $code;
615 615
     }
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
     protected function generateMethodNameForClassMethod($className, $classMethod, $extraOptions = array())
664 664
     {
665 665
         if (isset($extraOptions['replace_class_name']) && $extraOptions['replace_class_name']) {
666
-            return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . $classMethod;
666
+            return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '').$classMethod;
667 667
         }
668 668
 
669 669
         if (is_object($className)) {
@@ -671,7 +671,7 @@  discard block
 block discarded – undo
671 671
         } else {
672 672
             $realClassName = $className;
673 673
         }
674
-        return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . "$realClassName.$classMethod";
674
+        return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '')."$realClassName.$classMethod";
675 675
     }
676 676
 
677 677
     /**
@@ -752,21 +752,21 @@  discard block
 block discarded – undo
752 752
     protected function retrieveMethodSignature($client, $methodName, array $extraOptions = array())
753 753
     {
754 754
         $namespace = '\\PhpXmlRpc\\';
755
-        $reqClass = $namespace . 'Request';
756
-        $valClass = $namespace . 'Value';
757
-        $decoderClass = $namespace . 'Encoder';
755
+        $reqClass = $namespace.'Request';
756
+        $valClass = $namespace.'Value';
757
+        $decoderClass = $namespace.'Encoder';
758 758
 
759 759
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
760
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
760
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
761 761
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
762
-        $sigNum = isset($extraOptions['signum']) ? (int)$extraOptions['signum'] : 0;
762
+        $sigNum = isset($extraOptions['signum']) ? (int) $extraOptions['signum'] : 0;
763 763
 
764 764
         $req = new $reqClass('system.methodSignature');
765 765
         $req->addparam(new $valClass($methodName));
766 766
         $client->setDebug($debug);
767 767
         $response = $client->send($req, $timeout, $protocol);
768 768
         if ($response->faultCode()) {
769
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature from remote server for method ' . $methodName);
769
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method signature from remote server for method '.$methodName);
770 770
             return false;
771 771
         }
772 772
 
@@ -777,8 +777,8 @@  discard block
 block discarded – undo
777 777
             $mSig = $decoder->decode($mSig);
778 778
         }
779 779
 
780
-        if (!is_array($mSig) || count($mSig) <= $sigNum) {
781
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature nr.' . $sigNum . ' from remote server for method ' . $methodName);
780
+        if (!is_array($mSig) || count($mSig)<=$sigNum) {
781
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method signature nr.'.$sigNum.' from remote server for method '.$methodName);
782 782
             return false;
783 783
         }
784 784
 
@@ -794,11 +794,11 @@  discard block
 block discarded – undo
794 794
     protected function retrieveMethodHelp($client, $methodName, array $extraOptions = array())
795 795
     {
796 796
         $namespace = '\\PhpXmlRpc\\';
797
-        $reqClass = $namespace . 'Request';
798
-        $valClass = $namespace . 'Value';
797
+        $reqClass = $namespace.'Request';
798
+        $valClass = $namespace.'Value';
799 799
 
800 800
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
801
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
801
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
802 802
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
803 803
 
804 804
         $mDesc = '';
@@ -832,10 +832,10 @@  discard block
 block discarded – undo
832 832
         $clientClone = clone $client;
833 833
         $function = function() use($clientClone, $methodName, $extraOptions, $mSig)
834 834
         {
835
-            $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
835
+            $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
836 836
             $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
837
-            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
838
-            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
837
+            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
838
+            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
839 839
             if (isset($extraOptions['return_on_fault'])) {
840 840
                 $decodeFault = true;
841 841
                 $faultResponse = $extraOptions['return_on_fault'];
@@ -844,9 +844,9 @@  discard block
 block discarded – undo
844 844
             }
845 845
 
846 846
             $namespace = '\\PhpXmlRpc\\';
847
-            $reqClass = $namespace . 'Request';
848
-            $encoderClass = $namespace . 'Encoder';
849
-            $valueClass = $namespace . 'Value';
847
+            $reqClass = $namespace.'Request';
848
+            $encoderClass = $namespace.'Encoder';
849
+            $valueClass = $namespace.'Value';
850 850
 
851 851
             $encoder = new $encoderClass();
852 852
             $encodeOptions = array();
@@ -919,13 +919,13 @@  discard block
 block discarded – undo
919 919
      * @param string $mDesc
920 920
      * @return string[] keys: source, docstring
921 921
      */
922
-    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc='')
922
+    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc = '')
923 923
     {
924
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
924
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
925 925
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
926
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
927
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
928
-        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int)($extraOptions['simple_client_copy']) : 0;
926
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
927
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
928
+        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int) ($extraOptions['simple_client_copy']) : 0;
929 929
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
930 930
         if (isset($extraOptions['return_on_fault'])) {
931 931
             $decodeFault = true;
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
         $namespace = '\\PhpXmlRpc\\';
939 939
 
940 940
         $code = "function $newFuncName (";
941
-        if ($clientCopyMode < 2) {
941
+        if ($clientCopyMode<2) {
942 942
             // client copy mode 0 or 1 == full / partial client copy in emitted code
943 943
             $verbatimClientCopy = !$clientCopyMode;
944 944
             $innerCode = $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, $namespace);
@@ -953,7 +953,7 @@  discard block
 block discarded – undo
953 953
 
954 954
         if ($mDesc != '') {
955 955
             // take care that PHP comment is not terminated unwillingly by method description
956
-            $mDesc = "/**\n* " . str_replace('*/', '* /', $mDesc) . "\n";
956
+            $mDesc = "/**\n* ".str_replace('*/', '* /', $mDesc)."\n";
957 957
         } else {
958 958
             $mDesc = "/**\nFunction $newFuncName\n";
959 959
         }
@@ -962,7 +962,7 @@  discard block
 block discarded – undo
962 962
         $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
963 963
         $plist = array();
964 964
         $pCount = count($mSig);
965
-        for ($i = 1; $i < $pCount; $i++) {
965
+        for ($i = 1; $i<$pCount; $i++) {
966 966
             $plist[] = "\$p$i";
967 967
             $pType = $mSig[$i];
968 968
             if ($pType == 'i4' || $pType == 'i8' || $pType == 'int' || $pType == 'boolean' || $pType == 'double' ||
@@ -978,19 +978,19 @@  discard block
 block discarded – undo
978 978
                 }
979 979
             }
980 980
             $innerCode .= "\$req->addparam(\$p$i);\n";
981
-            $mDesc .= '* @param ' . $this->xmlrpc2PhpType($pType) . " \$p$i\n";
981
+            $mDesc .= '* @param '.$this->xmlrpc2PhpType($pType)." \$p$i\n";
982 982
         }
983
-        if ($clientCopyMode < 2) {
983
+        if ($clientCopyMode<2) {
984 984
             $plist[] = '$debug=0';
985 985
             $mDesc .= "* @param int \$debug when 1 (or 2) will enable debugging of the underlying {$prefix} call (defaults to 0)\n";
986 986
         }
987 987
         $plist = implode(', ', $plist);
988
-        $mDesc .= "* @return {$namespace}Response|" . $this->xmlrpc2PhpType($mSig[0]) . " (an {$namespace}Response obj instance if call fails)\n*/\n";
988
+        $mDesc .= "* @return {$namespace}Response|".$this->xmlrpc2PhpType($mSig[0])." (an {$namespace}Response obj instance if call fails)\n*/\n";
989 989
 
990 990
         $innerCode .= "\$res = \${$this_}client->send(\$req, $timeout, '$protocol');\n";
991 991
         if ($decodeFault) {
992 992
             if (is_string($faultResponse) && ((strpos($faultResponse, '%faultCode%') !== false) || (strpos($faultResponse, '%faultString%') !== false))) {
993
-                $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '" . str_replace("'", "''", $faultResponse) . "')";
993
+                $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '".str_replace("'", "''", $faultResponse)."')";
994 994
             } else {
995 995
                 $respCode = var_export($faultResponse, true);
996 996
             }
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
             $innerCode .= "if (\$res->faultcode()) return $respCode; else return \$encoder->decode(\$res->value());";
1004 1004
         }
1005 1005
 
1006
-        $code = $code . $plist . ") {\n" . $innerCode . "\n}\n";
1006
+        $code = $code.$plist.") {\n".$innerCode."\n}\n";
1007 1007
 
1008 1008
         return array('source' => $code, 'docstring' => $mDesc);
1009 1009
     }
@@ -1030,24 +1030,24 @@  discard block
 block discarded – undo
1030 1030
     public function wrapXmlrpcServer($client, $extraOptions = array())
1031 1031
     {
1032 1032
         $methodFilter = isset($extraOptions['method_filter']) ? $extraOptions['method_filter'] : '';
1033
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
1033
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
1034 1034
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
1035 1035
         $newClassName = isset($extraOptions['new_class_name']) ? $extraOptions['new_class_name'] : '';
1036
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
1037
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
1036
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
1037
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
1038 1038
         $verbatimClientCopy = isset($extraOptions['simple_client_copy']) ? !($extraOptions['simple_client_copy']) : true;
1039 1039
         $buildIt = isset($extraOptions['return_source']) ? !($extraOptions['return_source']) : true;
1040 1040
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
1041 1041
         $namespace = '\\PhpXmlRpc\\';
1042 1042
 
1043
-        $reqClass = $namespace . 'Request';
1044
-        $decoderClass = $namespace . 'Encoder';
1043
+        $reqClass = $namespace.'Request';
1044
+        $decoderClass = $namespace.'Encoder';
1045 1045
 
1046 1046
         // retrieve the list of methods
1047 1047
         $req = new $reqClass('system.listMethods');
1048 1048
         $response = $client->send($req, $timeout, $protocol);
1049 1049
         if ($response->faultCode()) {
1050
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method list from remote server');
1050
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method list from remote server');
1051 1051
 
1052 1052
             return false;
1053 1053
         }
@@ -1058,7 +1058,7 @@  discard block
 block discarded – undo
1058 1058
             $mList = $decoder->decode($mList);
1059 1059
         }
1060 1060
         if (!is_array($mList) || !count($mList)) {
1061
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve meaningful method list from remote server');
1061
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve meaningful method list from remote server');
1062 1062
 
1063 1063
             return false;
1064 1064
         }
@@ -1067,8 +1067,8 @@  discard block
 block discarded – undo
1067 1067
         if ($newClassName != '') {
1068 1068
             $xmlrpcClassName = $newClassName;
1069 1069
         } else {
1070
-            $xmlrpcClassName = $prefix . '_' . preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'),
1071
-                    array('_', ''), $client->server) . '_client';
1070
+            $xmlrpcClassName = $prefix.'_'.preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'),
1071
+                    array('_', ''), $client->server).'_client';
1072 1072
         }
1073 1073
         while ($buildIt && class_exists($xmlrpcClassName)) {
1074 1074
             $xmlrpcClassName .= 'x';
@@ -1099,20 +1099,20 @@  discard block
 block discarded – undo
1099 1099
                     if (!$buildIt) {
1100 1100
                         $source .= $methodWrap['docstring'];
1101 1101
                     }
1102
-                    $source .= $methodWrap['source'] . "\n";
1102
+                    $source .= $methodWrap['source']."\n";
1103 1103
                 } else {
1104
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': will not create class method to wrap remote method ' . $mName);
1104
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': will not create class method to wrap remote method '.$mName);
1105 1105
                 }
1106 1106
             }
1107 1107
         }
1108 1108
         $source .= "}\n";
1109 1109
         if ($buildIt) {
1110 1110
             $allOK = 0;
1111
-            eval($source . '$allOK=1;');
1111
+            eval($source.'$allOK=1;');
1112 1112
             if ($allOK) {
1113 1113
                 return $xmlrpcClassName;
1114 1114
             } else {
1115
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not create class ' . $xmlrpcClassName . ' to wrap remote server ' . $client->server);
1115
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not create class '.$xmlrpcClassName.' to wrap remote server '.$client->server);
1116 1116
                 return false;
1117 1117
             }
1118 1118
         } else {
@@ -1131,8 +1131,8 @@  discard block
 block discarded – undo
1131 1131
      */
1132 1132
     protected function buildClientWrapperCode($client, $verbatimClientCopy, $prefix = 'xmlrpc', $namespace = '\\PhpXmlRpc\\')
1133 1133
     {
1134
-        $code = "\$client = new {$namespace}Client('" . str_replace(array("\\", "'"), array("\\\\", "\'"), $client->path) .
1135
-            "', '" . str_replace(array("\\", "'"), array("\\\\", "\'"), $client->server) . "', $client->port);\n";
1134
+        $code = "\$client = new {$namespace}Client('".str_replace(array("\\", "'"), array("\\\\", "\'"), $client->path).
1135
+            "', '".str_replace(array("\\", "'"), array("\\\\", "\'"), $client->server)."', $client->port);\n";
1136 1136
 
1137 1137
         // copy all client fields to the client that will be generated runtime
1138 1138
         // (this provides for future expansion or subclassing of client obj)
Please login to merge, or discard this patch.