Passed
Push — master ( e2ee8e...6a6cc8 )
by Gaetano
06:36
created
tests/WebTestCase.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/parse_args.php';
3
+include_once __DIR__.'/parse_args.php';
4 4
 
5
-include_once __DIR__ . '/PolyfillTestCase.php';
5
+include_once __DIR__.'/PolyfillTestCase.php';
6 6
 
7 7
 use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage;
8 8
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function _run($result = NULL)
27 27
     {
28
-        $this->testId = get_class($this) . '__' . $this->getName();
28
+        $this->testId = get_class($this).'__'.$this->getName();
29 29
 
30 30
         if ($result === NULL) {
31 31
             $result = $this->createResult();
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     protected function request($path, $method = 'GET', $payload = '', $emptyPageOk = false)
62 62
     {
63
-        $url = $this->baseUrl . $path;
63
+        $url = $this->baseUrl.$path;
64 64
 
65 65
         $ch = curl_init($url);
66 66
         curl_setopt_array($ch, array(
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         {
79 79
             curl_setopt($ch, CURLOPT_COOKIE, 'PHPUNIT_SELENIUM_TEST_ID='.$this->testId);
80 80
         }
81
-        if ($this->args['DEBUG'] > 0) {
81
+        if ($this->args['DEBUG']>0) {
82 82
             curl_setopt($ch, CURLOPT_VERBOSE, 1);
83 83
         }
84 84
         $page = curl_exec($ch);
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $val = reset($ar);
108 108
         $typ = key($ar);
109 109
 
110
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
110
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
111 111
         //}
112 112
     }
113 113
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         // preserve back compatibility
127 127
 
128 128
         if (is_array($b)) {
129
-            foreach($b as $id => $cont) {
129
+            foreach ($b as $id => $cont) {
130 130
                 $b[$id] = $cont->scalarval();
131 131
             }
132 132
         }
@@ -134,10 +134,10 @@  discard block
 block discarded – undo
134 134
         // add support for structures directly encoding php objects
135 135
         if (is_object($b)) {
136 136
             $t = get_object_vars($b);
137
-            foreach($t as $id => $cont) {
137
+            foreach ($t as $id => $cont) {
138 138
                 $t[$id] = $cont->scalarval();
139 139
             }
140
-            foreach($t as $id => $cont) {
140
+            foreach ($t as $id => $cont) {
141 141
                 @$b->$id = $cont;
142 142
             }
143 143
         }
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
 /* Expose as global functions the ones which are now class methods */
180 180
 
181 181
 /// Wrong speling, but we are adamant on backwards compatibility!
182
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
182
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
183 183
 {
184 184
     return Charset::instance()->encodeEntities($data, $srcEncoding, $destEncoding);
185 185
 }
186 186
 
187
-function iso8601_encode($timeT, $utc=0)
187
+function iso8601_encode($timeT, $utc = 0)
188 188
 {
189 189
     return Date::iso8601Encode($timeT, $utc);
190 190
 }
191 191
 
192
-function iso8601_decode($iDate, $utc=0)
192
+function iso8601_decode($iDate, $utc = 0)
193 193
 {
194 194
     return Date::iso8601Decode($iDate, $utc);
195 195
 }
@@ -199,25 +199,25 @@  discard block
 block discarded – undo
199 199
     return Http::decodeChunked($buffer);
200 200
 }
201 201
 
202
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
202
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
203 203
 {
204 204
     $encoder = new Encoder();
205 205
     return $encoder->decode($xmlrpcVal, $options);
206 206
 }
207 207
 
208
-function php_xmlrpc_encode($phpVal, $options=array())
208
+function php_xmlrpc_encode($phpVal, $options = array())
209 209
 {
210 210
     $encoder = new Encoder();
211 211
     return $encoder->encode($phpVal, $options);
212 212
 }
213 213
 
214
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
214
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
215 215
 {
216 216
     $encoder = new Encoder();
217 217
     return $encoder->decodeXml($xmlVal, $options);
218 218
 }
219 219
 
220
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
220
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
221 221
 {
222 222
     return XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
223 223
 }
Please login to merge, or discard this patch.
debugger/index.php 2 patches
Braces   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,12 @@
 block discarded – undo
12 12
 <html lang="en">
13 13
 <head>
14 14
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
15
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSONRPC'; else echo 'XMLRPC'; ?> Debugger</title>
15
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
16
+    echo 'JSONRPC';
17
+} else {
18
+    echo 'XMLRPC';
19
+}
20
+?> Debugger</title>
16 21
 </head>
17 22
 <frameset rows="360,*">
18 23
     <frame name="frmcontroller" src="controller.php<?php echo htmlspecialchars($query); ?>" marginwidth="0"
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 if (isset($_GET['run'])) {
5 5
     $path = parse_url($_GET['run']);
6 6
     if (isset($path['query'])) {
7
-        $query = '?' . $path['query'];
7
+        $query = '?'.$path['query'];
8 8
     }
9 9
 }
10 10
 
Please login to merge, or discard this patch.
src/Helper/Charset.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -176,8 +176,7 @@
 block discarded – undo
176 176
                         } else {
177 177
                             $escapedData .= $ch;
178 178
                         }
179
-                    }
180
-                    else if ($ii < 128) {
179
+                    } else if ($ii < 128) {
181 180
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
182 181
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
183 182
                         switch ($ii) {
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -91,14 +91,14 @@  discard block
 block discarded – undo
91 91
                 if (count($this->xml_iso88591_Entities['in'])) {
92 92
                     return;
93 93
                 }
94
-                for ($i = 0; $i < 32; $i++) {
94
+                for ($i = 0; $i<32; $i++) {
95 95
                     $this->xml_iso88591_Entities["in"][] = chr($i);
96 96
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
97 97
                 }
98 98
 
99 99
                 /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
100 100
 
101
-                for ($i = 160; $i < 256; $i++) {
101
+                for ($i = 160; $i<256; $i++) {
102 102
                     $this->xml_iso88591_Entities["in"][] = chr($i);
103 103
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
104 104
                 }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
                 break;*/
127 127
 
128 128
             default:
129
-                throw new \Exception('Unsupported table: ' . $tableName);
129
+                throw new \Exception('Unsupported table: '.$tableName);
130 130
         }
131 131
     }
132 132
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
             $srcEncoding = 'UTF-8';
179 179
         }
180 180
 
181
-        $conversion = strtoupper($srcEncoding . '_' . $destEncoding);
181
+        $conversion = strtoupper($srcEncoding.'_'.$destEncoding);
182 182
 
183 183
         // list ordered with (expected) most common scenarios first
184 184
         switch ($conversion) {
@@ -196,20 +196,20 @@  discard block
 block discarded – undo
196 196
                 // NB: this will choke on invalid UTF-8, going most likely beyond EOF
197 197
                 $escapedData = '';
198 198
                 // be kind to users creating string xmlrpc values out of different php types
199
-                $data = (string)$data;
199
+                $data = (string) $data;
200 200
                 $ns = strlen($data);
201
-                for ($nn = 0; $nn < $ns; $nn++) {
201
+                for ($nn = 0; $nn<$ns; $nn++) {
202 202
                     $ch = $data[$nn];
203 203
                     $ii = ord($ch);
204 204
                     // 7 bits in 1 byte: 0bbbbbbb (127)
205
-                    if ($ii < 32) {
205
+                    if ($ii<32) {
206 206
                         if ($conversion == 'UTF-8_US-ASCII') {
207 207
                             $escapedData .= sprintf('&#%d;', $ii);
208 208
                         } else {
209 209
                             $escapedData .= $ch;
210 210
                         }
211 211
                     }
212
-                    else if ($ii < 128) {
212
+                    else if ($ii<128) {
213 213
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
214 214
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
215 215
                         switch ($ii) {
@@ -234,25 +234,25 @@  discard block
 block discarded – undo
234 234
                     } // 11 bits in 2 bytes: 110bbbbb 10bbbbbb (2047)
235 235
                     elseif ($ii >> 5 == 6) {
236 236
                         $b1 = ($ii & 31);
237
-                        $b2 = (ord($data[$nn + 1]) & 63);
238
-                        $ii = ($b1 * 64) + $b2;
237
+                        $b2 = (ord($data[$nn+1]) & 63);
238
+                        $ii = ($b1 * 64)+$b2;
239 239
                         $escapedData .= sprintf('&#%d;', $ii);
240 240
                         $nn += 1;
241 241
                     } // 16 bits in 3 bytes: 1110bbbb 10bbbbbb 10bbbbbb
242 242
                     elseif ($ii >> 4 == 14) {
243 243
                         $b1 = ($ii & 15);
244
-                        $b2 = (ord($data[$nn + 1]) & 63);
245
-                        $b3 = (ord($data[$nn + 2]) & 63);
246
-                        $ii = ((($b1 * 64) + $b2) * 64) + $b3;
244
+                        $b2 = (ord($data[$nn+1]) & 63);
245
+                        $b3 = (ord($data[$nn+2]) & 63);
246
+                        $ii = ((($b1 * 64)+$b2) * 64)+$b3;
247 247
                         $escapedData .= sprintf('&#%d;', $ii);
248 248
                         $nn += 2;
249 249
                     } // 21 bits in 4 bytes: 11110bbb 10bbbbbb 10bbbbbb 10bbbbbb
250 250
                     elseif ($ii >> 3 == 30) {
251 251
                         $b1 = ($ii & 7);
252
-                        $b2 = (ord($data[$nn + 1]) & 63);
253
-                        $b3 = (ord($data[$nn + 2]) & 63);
254
-                        $b4 = (ord($data[$nn + 3]) & 63);
255
-                        $ii = ((((($b1 * 64) + $b2) * 64) + $b3) * 64) + $b4;
252
+                        $b2 = (ord($data[$nn+1]) & 63);
253
+                        $b3 = (ord($data[$nn+2]) & 63);
254
+                        $b4 = (ord($data[$nn+3]) & 63);
255
+                        $ii = ((((($b1 * 64)+$b2) * 64)+$b3) * 64)+$b4;
256 256
                         $escapedData .= sprintf('&#%d;', $ii);
257 257
                         $nn += 3;
258 258
                     }
@@ -305,14 +305,14 @@  discard block
 block discarded – undo
305 305
                     // If src is UTF8, we run htmlspecialchars before converting to the target charset, as
306 306
                     // htmlspecialchars has limited charset support, but it groks utf8
307 307
                     if ($srcEncoding === 'UTF-8') {
308
-                        $data = htmlspecialchars($data,  defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
308
+                        $data = htmlspecialchars($data, defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
309 309
                     }
310 310
                     if ($srcEncoding !== $destEncoding) {
311 311
                         $data = mb_convert_encoding($data, str_replace('US-ASCII', 'ASCII', $destEncoding), str_replace('US-ASCII', 'ASCII', $srcEncoding));
312 312
                     }
313 313
                     if ($data === false) {
314 314
                         $escapedData = '';
315
-                        $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
315
+                        $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
316 316
                     } else {
317 317
                         if ($srcEncoding === 'UTF-8') {
318 318
                             $escapedData = $data;
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
                     }
323 323
                 } else {
324 324
                     $escapedData = '';
325
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding: not supported...");
325
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding: not supported...");
326 326
                 }
327 327
         }
328 328
 
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
             case 'iso88591':
378 378
                 return $this->xml_iso88591_Entities;
379 379
             default:
380
-                throw new \Exception('Unsupported charset: ' . $charset);
380
+                throw new \Exception('Unsupported charset: '.$charset);
381 381
         }
382 382
     }
383 383
 }
Please login to merge, or discard this patch.
src/Wrapper.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -591,8 +591,9 @@
 block discarded – undo
591 591
         }
592 592
         foreach ($parsVariations as $i => $pars) {
593 593
             $innerCode .= "if (\$paramCount == " . count($pars) . ") \$retval = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
594
-            if ($i < (count($parsVariations) - 1))
595
-                $innerCode .= "else\n";
594
+            if ($i < (count($parsVariations) - 1)) {
595
+                            $innerCode .= "else\n";
596
+            }
596 597
         }
597 598
         $innerCode .= "if (is_a(\$retval, '{$namespace}Response')) return \$retval; else\n";
598 599
         if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
Please login to merge, or discard this patch.
Spacing   +71 added lines, -71 removed lines patch added patch discarded remove patch
@@ -182,20 +182,20 @@  discard block
 block discarded – undo
182 182
             $callable = explode('::', $callable);
183 183
         }
184 184
         if (is_array($callable)) {
185
-            if (count($callable) < 2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
186
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': syntax for function to be wrapped is wrong');
185
+            if (count($callable)<2 || (!is_string($callable[0]) && !is_object($callable[0]))) {
186
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': syntax for function to be wrapped is wrong');
187 187
                 return false;
188 188
             }
189 189
             if (is_string($callable[0])) {
190 190
                 $plainFuncName = implode('::', $callable);
191 191
             } elseif (is_object($callable[0])) {
192
-                $plainFuncName = get_class($callable[0]) . '->' . $callable[1];
192
+                $plainFuncName = get_class($callable[0]).'->'.$callable[1];
193 193
             }
194 194
             $exists = method_exists($callable[0], $callable[1]);
195 195
         } else if ($callable instanceof \Closure) {
196 196
             // we do not support creating code which wraps closures, as php does not allow to serialize them
197 197
             if (!$buildIt) {
198
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': a closure can not be wrapped in generated source code');
198
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': a closure can not be wrapped in generated source code');
199 199
                 return false;
200 200
             }
201 201
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         }
208 208
 
209 209
         if (!$exists) {
210
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': function to be wrapped is not defined: ' . $plainFuncName);
210
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': function to be wrapped is not defined: '.$plainFuncName);
211 211
             return false;
212 212
         }
213 213
 
@@ -251,23 +251,23 @@  discard block
 block discarded – undo
251 251
         if (is_array($callable)) {
252 252
             $func = new \ReflectionMethod($callable[0], $callable[1]);
253 253
             if ($func->isPrivate()) {
254
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is private: ' . $plainFuncName);
254
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is private: '.$plainFuncName);
255 255
                 return false;
256 256
             }
257 257
             if ($func->isProtected()) {
258
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is protected: ' . $plainFuncName);
258
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is protected: '.$plainFuncName);
259 259
                 return false;
260 260
             }
261 261
             if ($func->isConstructor()) {
262
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the constructor: ' . $plainFuncName);
262
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is the constructor: '.$plainFuncName);
263 263
                 return false;
264 264
             }
265 265
             if ($func->isDestructor()) {
266
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is the destructor: ' . $plainFuncName);
266
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is the destructor: '.$plainFuncName);
267 267
                 return false;
268 268
             }
269 269
             if ($func->isAbstract()) {
270
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': method to be wrapped is abstract: ' . $plainFuncName);
270
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': method to be wrapped is abstract: '.$plainFuncName);
271 271
                 return false;
272 272
             }
273 273
             /// @todo add more checks for static vs. nonstatic?
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
         if ($func->isInternal()) {
278 278
             /// @todo from PHP 5.1.0 onward, we should be able to use invokeargs instead of getparameters to fully
279 279
             ///       reflect internal php functions
280
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': function to be wrapped is internal: ' . $plainFuncName);
280
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': function to be wrapped is internal: '.$plainFuncName);
281 281
             return false;
282 282
         }
283 283
 
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
         $i = 0;
330 330
         foreach ($func->getParameters() as $paramObj) {
331 331
             $params[$i] = array();
332
-            $params[$i]['name'] = '$' . $paramObj->getName();
332
+            $params[$i]['name'] = '$'.$paramObj->getName();
333 333
             $params[$i]['isoptional'] = $paramObj->isOptional();
334 334
             $i++;
335 335
         }
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             // build a signature
394 394
             $sig = array($this->php2XmlrpcType($funcDesc['returns']));
395 395
             $pSig = array($funcDesc['returnsDocs']);
396
-            for ($i = 0; $i < count($pars); $i++) {
396
+            for ($i = 0; $i<count($pars); $i++) {
397 397
                 $name = strtolower($funcDesc['params'][$i]['name']);
398 398
                 if (isset($funcDesc['paramDocs'][$name]['type'])) {
399 399
                     $sig[] = $this->php2XmlrpcType($funcDesc['paramDocs'][$name]['type']);
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
                 }
451 451
             }
452 452
             $numPars = $req->getNumParams();
453
-            if ($numPars < $minPars || $numPars > $maxPars) {
453
+            if ($numPars<$minPars || $numPars>$maxPars) {
454 454
                 return new $responseClass(0, 3, 'Incorrect parameters passed to method');
455 455
             }
456 456
 
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
 
464 464
             $result = call_user_func_array($callable, $params);
465 465
 
466
-            if (! is_a($result, $responseClass)) {
466
+            if (!is_a($result, $responseClass)) {
467 467
                 if ($funcDesc['returns'] == Value::$xmlrpcDateTime || $funcDesc['returns'] == Value::$xmlrpcBase64) {
468 468
                     $result = new $valueClass($result, $funcDesc['returns']);
469 469
                 } else {
@@ -498,9 +498,9 @@  discard block
 block discarded – undo
498 498
         if ($newFuncName == '') {
499 499
             if (is_array($callable)) {
500 500
                 if (is_string($callable[0])) {
501
-                    $xmlrpcFuncName = "{$prefix}_" . implode('_', $callable);
501
+                    $xmlrpcFuncName = "{$prefix}_".implode('_', $callable);
502 502
                 } else {
503
-                    $xmlrpcFuncName = "{$prefix}_" . get_class($callable[0]) . '_' . $callable[1];
503
+                    $xmlrpcFuncName = "{$prefix}_".get_class($callable[0]).'_'.$callable[1];
504 504
                 }
505 505
             } else {
506 506
                 if ($callable instanceof \Closure) {
@@ -536,8 +536,8 @@  discard block
 block discarded – undo
536 536
     {
537 537
         $namespace = '\\PhpXmlRpc\\';
538 538
 
539
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
540
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
539
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
540
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
541 541
         $catchWarnings = isset($extraOptions['suppress_warnings']) && $extraOptions['suppress_warnings'] ? '@' : '';
542 542
 
543 543
         $i = 0;
@@ -572,7 +572,7 @@  discard block
 block discarded – undo
572 572
         // build body of new function
573 573
 
574 574
         $innerCode = "\$paramCount = \$req->getNumParams();\n";
575
-        $innerCode .= "if (\$paramCount < $minPars || \$paramCount > $maxPars) return new {$namespace}Response(0, " . PhpXmlRpc::$xmlrpcerr['incorrect_params'] . ", '" . PhpXmlRpc::$xmlrpcstr['incorrect_params'] . "');\n";
575
+        $innerCode .= "if (\$paramCount < $minPars || \$paramCount > $maxPars) return new {$namespace}Response(0, ".PhpXmlRpc::$xmlrpcerr['incorrect_params'].", '".PhpXmlRpc::$xmlrpcstr['incorrect_params']."');\n";
576 576
 
577 577
         $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
578 578
         if ($decodePhpObjects) {
@@ -586,13 +586,13 @@  discard block
 block discarded – undo
586 586
         if (is_array($callable) && is_object($callable[0])) {
587 587
             self::$objHolder[$newFuncName] = $callable[0];
588 588
             $innerCode .= "\$obj = PhpXmlRpc\\Wrapper::\$objHolder['$newFuncName'];\n";
589
-            $realFuncName = '$obj->' . $callable[1];
589
+            $realFuncName = '$obj->'.$callable[1];
590 590
         } else {
591 591
             $realFuncName = $plainFuncName;
592 592
         }
593 593
         foreach ($parsVariations as $i => $pars) {
594
-            $innerCode .= "if (\$paramCount == " . count($pars) . ") \$retval = {$catchWarnings}$realFuncName(" . implode(',', $pars) . ");\n";
595
-            if ($i < (count($parsVariations) - 1))
594
+            $innerCode .= "if (\$paramCount == ".count($pars).") \$retval = {$catchWarnings}$realFuncName(".implode(',', $pars).");\n";
595
+            if ($i<(count($parsVariations)-1))
596 596
                 $innerCode .= "else\n";
597 597
         }
598 598
         $innerCode .= "if (is_a(\$retval, '{$namespace}Response')) return \$retval; else\n";
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
         // if ($func->returnsReference())
610 610
         //     return false;
611 611
 
612
-        $code = "function $newFuncName(\$req) {\n" . $innerCode . "\n}";
612
+        $code = "function $newFuncName(\$req) {\n".$innerCode."\n}";
613 613
 
614 614
         return $code;
615 615
     }
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
     protected function generateMethodNameForClassMethod($className, $classMethod, $extraOptions = array())
664 664
     {
665 665
         if (isset($extraOptions['replace_class_name']) && $extraOptions['replace_class_name']) {
666
-            return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . $classMethod;
666
+            return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '').$classMethod;
667 667
         }
668 668
 
669 669
         if (is_object($className)) {
@@ -671,7 +671,7 @@  discard block
 block discarded – undo
671 671
         } else {
672 672
             $realClassName = $className;
673 673
         }
674
-        return (isset($extraOptions['prefix']) ?  $extraOptions['prefix'] : '') . "$realClassName.$classMethod";
674
+        return (isset($extraOptions['prefix']) ? $extraOptions['prefix'] : '')."$realClassName.$classMethod";
675 675
     }
676 676
 
677 677
     /**
@@ -752,21 +752,21 @@  discard block
 block discarded – undo
752 752
     protected function retrieveMethodSignature($client, $methodName, array $extraOptions = array())
753 753
     {
754 754
         $namespace = '\\PhpXmlRpc\\';
755
-        $reqClass = $namespace . 'Request';
756
-        $valClass = $namespace . 'Value';
757
-        $decoderClass = $namespace . 'Encoder';
755
+        $reqClass = $namespace.'Request';
756
+        $valClass = $namespace.'Value';
757
+        $decoderClass = $namespace.'Encoder';
758 758
 
759 759
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
760
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
760
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
761 761
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
762
-        $sigNum = isset($extraOptions['signum']) ? (int)$extraOptions['signum'] : 0;
762
+        $sigNum = isset($extraOptions['signum']) ? (int) $extraOptions['signum'] : 0;
763 763
 
764 764
         $req = new $reqClass('system.methodSignature');
765 765
         $req->addparam(new $valClass($methodName));
766 766
         $client->setDebug($debug);
767 767
         $response = $client->send($req, $timeout, $protocol);
768 768
         if ($response->faultCode()) {
769
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature from remote server for method ' . $methodName);
769
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method signature from remote server for method '.$methodName);
770 770
             return false;
771 771
         }
772 772
 
@@ -777,8 +777,8 @@  discard block
 block discarded – undo
777 777
             $mSig = $decoder->decode($mSig);
778 778
         }
779 779
 
780
-        if (!is_array($mSig) || count($mSig) <= $sigNum) {
781
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method signature nr.' . $sigNum . ' from remote server for method ' . $methodName);
780
+        if (!is_array($mSig) || count($mSig)<=$sigNum) {
781
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method signature nr.'.$sigNum.' from remote server for method '.$methodName);
782 782
             return false;
783 783
         }
784 784
 
@@ -794,11 +794,11 @@  discard block
 block discarded – undo
794 794
     protected function retrieveMethodHelp($client, $methodName, array $extraOptions = array())
795 795
     {
796 796
         $namespace = '\\PhpXmlRpc\\';
797
-        $reqClass = $namespace . 'Request';
798
-        $valClass = $namespace . 'Value';
797
+        $reqClass = $namespace.'Request';
798
+        $valClass = $namespace.'Value';
799 799
 
800 800
         $debug = isset($extraOptions['debug']) ? ($extraOptions['debug']) : 0;
801
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
801
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
802 802
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
803 803
 
804 804
         $mDesc = '';
@@ -832,10 +832,10 @@  discard block
 block discarded – undo
832 832
         $clientClone = clone $client;
833 833
         $function = function() use($clientClone, $methodName, $extraOptions, $mSig)
834 834
         {
835
-            $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
835
+            $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
836 836
             $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
837
-            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
838
-            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
837
+            $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
838
+            $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
839 839
             if (isset($extraOptions['return_on_fault'])) {
840 840
                 $decodeFault = true;
841 841
                 $faultResponse = $extraOptions['return_on_fault'];
@@ -844,9 +844,9 @@  discard block
 block discarded – undo
844 844
             }
845 845
 
846 846
             $namespace = '\\PhpXmlRpc\\';
847
-            $reqClass = $namespace . 'Request';
848
-            $encoderClass = $namespace . 'Encoder';
849
-            $valueClass = $namespace . 'Value';
847
+            $reqClass = $namespace.'Request';
848
+            $encoderClass = $namespace.'Encoder';
849
+            $valueClass = $namespace.'Value';
850 850
 
851 851
             $encoder = new $encoderClass();
852 852
             $encodeOptions = array();
@@ -919,13 +919,13 @@  discard block
 block discarded – undo
919 919
      * @param string $mDesc
920 920
      * @return string[] keys: source, docstring
921 921
      */
922
-    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc='')
922
+    public function buildWrapMethodSource($client, $methodName, array $extraOptions, $newFuncName, $mSig, $mDesc = '')
923 923
     {
924
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
924
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
925 925
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
926
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
927
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
928
-        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int)($extraOptions['simple_client_copy']) : 0;
926
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
927
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
928
+        $clientCopyMode = isset($extraOptions['simple_client_copy']) ? (int) ($extraOptions['simple_client_copy']) : 0;
929 929
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
930 930
         if (isset($extraOptions['return_on_fault'])) {
931 931
             $decodeFault = true;
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
         $namespace = '\\PhpXmlRpc\\';
939 939
 
940 940
         $code = "function $newFuncName (";
941
-        if ($clientCopyMode < 2) {
941
+        if ($clientCopyMode<2) {
942 942
             // client copy mode 0 or 1 == full / partial client copy in emitted code
943 943
             $verbatimClientCopy = !$clientCopyMode;
944 944
             $innerCode = $this->buildClientWrapperCode($client, $verbatimClientCopy, $prefix, $namespace);
@@ -953,7 +953,7 @@  discard block
 block discarded – undo
953 953
 
954 954
         if ($mDesc != '') {
955 955
             // take care that PHP comment is not terminated unwillingly by method description
956
-            $mDesc = "/**\n* " . str_replace('*/', '* /', $mDesc) . "\n";
956
+            $mDesc = "/**\n* ".str_replace('*/', '* /', $mDesc)."\n";
957 957
         } else {
958 958
             $mDesc = "/**\nFunction $newFuncName\n";
959 959
         }
@@ -962,7 +962,7 @@  discard block
 block discarded – undo
962 962
         $innerCode .= "\$encoder = new {$namespace}Encoder();\n";
963 963
         $plist = array();
964 964
         $pCount = count($mSig);
965
-        for ($i = 1; $i < $pCount; $i++) {
965
+        for ($i = 1; $i<$pCount; $i++) {
966 966
             $plist[] = "\$p$i";
967 967
             $pType = $mSig[$i];
968 968
             if ($pType == 'i4' || $pType == 'i8' || $pType == 'int' || $pType == 'boolean' || $pType == 'double' ||
@@ -978,19 +978,19 @@  discard block
 block discarded – undo
978 978
                 }
979 979
             }
980 980
             $innerCode .= "\$req->addparam(\$p$i);\n";
981
-            $mDesc .= '* @param ' . $this->xmlrpc2PhpType($pType) . " \$p$i\n";
981
+            $mDesc .= '* @param '.$this->xmlrpc2PhpType($pType)." \$p$i\n";
982 982
         }
983
-        if ($clientCopyMode < 2) {
983
+        if ($clientCopyMode<2) {
984 984
             $plist[] = '$debug=0';
985 985
             $mDesc .= "* @param int \$debug when 1 (or 2) will enable debugging of the underlying {$prefix} call (defaults to 0)\n";
986 986
         }
987 987
         $plist = implode(', ', $plist);
988
-        $mDesc .= "* @return {$namespace}Response|" . $this->xmlrpc2PhpType($mSig[0]) . " (an {$namespace}Response obj instance if call fails)\n*/\n";
988
+        $mDesc .= "* @return {$namespace}Response|".$this->xmlrpc2PhpType($mSig[0])." (an {$namespace}Response obj instance if call fails)\n*/\n";
989 989
 
990 990
         $innerCode .= "\$res = \${$this_}client->send(\$req, $timeout, '$protocol');\n";
991 991
         if ($decodeFault) {
992 992
             if (is_string($faultResponse) && ((strpos($faultResponse, '%faultCode%') !== false) || (strpos($faultResponse, '%faultString%') !== false))) {
993
-                $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '" . str_replace("'", "''", $faultResponse) . "')";
993
+                $respCode = "str_replace(array('%faultCode%', '%faultString%'), array(\$res->faultCode(), \$res->faultString()), '".str_replace("'", "''", $faultResponse)."')";
994 994
             } else {
995 995
                 $respCode = var_export($faultResponse, true);
996 996
             }
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
             $innerCode .= "if (\$res->faultcode()) return $respCode; else return \$encoder->decode(\$res->value());";
1004 1004
         }
1005 1005
 
1006
-        $code = $code . $plist . ") {\n" . $innerCode . "\n}\n";
1006
+        $code = $code.$plist.") {\n".$innerCode."\n}\n";
1007 1007
 
1008 1008
         return array('source' => $code, 'docstring' => $mDesc);
1009 1009
     }
@@ -1030,24 +1030,24 @@  discard block
 block discarded – undo
1030 1030
     public function wrapXmlrpcServer($client, $extraOptions = array())
1031 1031
     {
1032 1032
         $methodFilter = isset($extraOptions['method_filter']) ? $extraOptions['method_filter'] : '';
1033
-        $timeout = isset($extraOptions['timeout']) ? (int)$extraOptions['timeout'] : 0;
1033
+        $timeout = isset($extraOptions['timeout']) ? (int) $extraOptions['timeout'] : 0;
1034 1034
         $protocol = isset($extraOptions['protocol']) ? $extraOptions['protocol'] : '';
1035 1035
         $newClassName = isset($extraOptions['new_class_name']) ? $extraOptions['new_class_name'] : '';
1036
-        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool)$extraOptions['encode_php_objs'] : false;
1037
-        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool)$extraOptions['decode_php_objs'] : false;
1036
+        $encodePhpObjects = isset($extraOptions['encode_php_objs']) ? (bool) $extraOptions['encode_php_objs'] : false;
1037
+        $decodePhpObjects = isset($extraOptions['decode_php_objs']) ? (bool) $extraOptions['decode_php_objs'] : false;
1038 1038
         $verbatimClientCopy = isset($extraOptions['simple_client_copy']) ? !($extraOptions['simple_client_copy']) : true;
1039 1039
         $buildIt = isset($extraOptions['return_source']) ? !($extraOptions['return_source']) : true;
1040 1040
         $prefix = isset($extraOptions['prefix']) ? $extraOptions['prefix'] : 'xmlrpc';
1041 1041
         $namespace = '\\PhpXmlRpc\\';
1042 1042
 
1043
-        $reqClass = $namespace . 'Request';
1044
-        $decoderClass = $namespace . 'Encoder';
1043
+        $reqClass = $namespace.'Request';
1044
+        $decoderClass = $namespace.'Encoder';
1045 1045
 
1046 1046
         // retrieve the list of methods
1047 1047
         $req = new $reqClass('system.listMethods');
1048 1048
         $response = $client->send($req, $timeout, $protocol);
1049 1049
         if ($response->faultCode()) {
1050
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve method list from remote server');
1050
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve method list from remote server');
1051 1051
 
1052 1052
             return false;
1053 1053
         }
@@ -1058,7 +1058,7 @@  discard block
 block discarded – undo
1058 1058
             $mList = $decoder->decode($mList);
1059 1059
         }
1060 1060
         if (!is_array($mList) || !count($mList)) {
1061
-            $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not retrieve meaningful method list from remote server');
1061
+            $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not retrieve meaningful method list from remote server');
1062 1062
 
1063 1063
             return false;
1064 1064
         }
@@ -1067,8 +1067,8 @@  discard block
 block discarded – undo
1067 1067
         if ($newClassName != '') {
1068 1068
             $xmlrpcClassName = $newClassName;
1069 1069
         } else {
1070
-            $xmlrpcClassName = $prefix . '_' . preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'),
1071
-                    array('_', ''), $client->server) . '_client';
1070
+            $xmlrpcClassName = $prefix.'_'.preg_replace(array('/\./', '/[^a-zA-Z0-9_\x7f-\xff]/'),
1071
+                    array('_', ''), $client->server).'_client';
1072 1072
         }
1073 1073
         while ($buildIt && class_exists($xmlrpcClassName)) {
1074 1074
             $xmlrpcClassName .= 'x';
@@ -1099,20 +1099,20 @@  discard block
 block discarded – undo
1099 1099
                     if (!$buildIt) {
1100 1100
                         $source .= $methodWrap['docstring'];
1101 1101
                     }
1102
-                    $source .= $methodWrap['source'] . "\n";
1102
+                    $source .= $methodWrap['source']."\n";
1103 1103
                 } else {
1104
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': will not create class method to wrap remote method ' . $mName);
1104
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': will not create class method to wrap remote method '.$mName);
1105 1105
                 }
1106 1106
             }
1107 1107
         }
1108 1108
         $source .= "}\n";
1109 1109
         if ($buildIt) {
1110 1110
             $allOK = 0;
1111
-            eval($source . '$allOK=1;');
1111
+            eval($source.'$allOK=1;');
1112 1112
             if ($allOK) {
1113 1113
                 return $xmlrpcClassName;
1114 1114
             } else {
1115
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': could not create class ' . $xmlrpcClassName . ' to wrap remote server ' . $client->server);
1115
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': could not create class '.$xmlrpcClassName.' to wrap remote server '.$client->server);
1116 1116
                 return false;
1117 1117
             }
1118 1118
         } else {
@@ -1131,8 +1131,8 @@  discard block
 block discarded – undo
1131 1131
      */
1132 1132
     protected function buildClientWrapperCode($client, $verbatimClientCopy, $prefix = 'xmlrpc', $namespace = '\\PhpXmlRpc\\')
1133 1133
     {
1134
-        $code = "\$client = new {$namespace}Client('" . str_replace(array("\\", "'"), array("\\\\", "\'"), $client->path) .
1135
-            "', '" . str_replace(array("\\", "'"), array("\\\\", "\'"), $client->server) . "', $client->port);\n";
1134
+        $code = "\$client = new {$namespace}Client('".str_replace(array("\\", "'"), array("\\\\", "\'"), $client->path).
1135
+            "', '".str_replace(array("\\", "'"), array("\\\\", "\'"), $client->server)."', $client->port);\n";
1136 1136
 
1137 1137
         // copy all client fields to the client that will be generated runtime
1138 1138
         // (this provides for future expansion or subclassing of client obj)
Please login to merge, or discard this patch.
src/Client.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -951,9 +951,9 @@
 block discarded – undo
951 951
     }
952 952
 
953 953
     protected function prepareCurlHandle($req, $server, $port, $timeout = 0, $username = '', $password = '',
954
-         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
955
-         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https', $keepAlive = false, $key = '',
956
-         $keyPass = '', $sslVersion = 0)
954
+            $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
955
+            $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https', $keepAlive = false, $key = '',
956
+            $keyPass = '', $sslVersion = 0)
957 957
     {
958 958
         if ($port == 0) {
959 959
             if (in_array($method, array('http', 'http10', 'http11', 'h2c'))) {
Please login to merge, or discard this patch.
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -189,10 +189,10 @@  discard block
 block discarded – undo
189 189
             $server = $parts['host'];
190 190
             $path = isset($parts['path']) ? $parts['path'] : '';
191 191
             if (isset($parts['query'])) {
192
-                $path .= '?' . $parts['query'];
192
+                $path .= '?'.$parts['query'];
193 193
             }
194 194
             if (isset($parts['fragment'])) {
195
-                $path .= '#' . $parts['fragment'];
195
+                $path .= '#'.$parts['fragment'];
196 196
             }
197 197
             if (isset($parts['port'])) {
198 198
                 $port = $parts['port'];
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
             }
209 209
         }
210 210
         if ($path == '' || $path[0] != '/') {
211
-            $this->path = '/' . $path;
211
+            $this->path = '/'.$path;
212 212
         } else {
213 213
             $this->path = $path;
214 214
         }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
         }*/
247 247
 
248 248
         // initialize user_agent string
249
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
249
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
250 250
     }
251 251
 
252 252
     /**
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
      */
671 671
     protected function sendPayloadHTTP10($req, $server, $port, $timeout = 0, $username = '', $password = '',
672 672
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
673
-        $method='http')
673
+        $method = 'http')
674 674
     {
675 675
         //trigger_error('Method ' . __METHOD__ . ' is deprecated', E_USER_DEPRECATED);
676 676
 
@@ -703,7 +703,7 @@  discard block
 block discarded – undo
703 703
      * @param int $sslVersion
704 704
      * @return Response
705 705
      */
706
-    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '',  $password = '',
706
+    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '', $password = '',
707 707
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
708 708
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
709 709
         $sslVersion = 0)
@@ -742,7 +742,7 @@  discard block
 block discarded – undo
742 742
      */
743 743
     protected function sendPayloadSocket($req, $server, $port, $timeout = 0, $username = '', $password = '',
744 744
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
745
-        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method='http', $key = '', $keyPass = '',
745
+        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'http', $key = '', $keyPass = '',
746 746
         $sslVersion = 0)
747 747
     {
748 748
         /// @todo log a warning if passed an unsupported method
@@ -779,16 +779,16 @@  discard block
 block discarded – undo
779 779
         // thanks to Grant Rauscher <[email protected]> for this
780 780
         $credentials = '';
781 781
         if ($username != '') {
782
-            $credentials = 'Authorization: Basic ' . base64_encode($username . ':' . $password) . "\r\n";
782
+            $credentials = 'Authorization: Basic '.base64_encode($username.':'.$password)."\r\n";
783 783
             if ($authType != 1) {
784 784
                 /// @todo make this a proper error, i.e. return a failure
785
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
785
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
786 786
             }
787 787
         }
788 788
 
789 789
         $acceptedEncoding = '';
790 790
         if (is_array($this->accepted_compression) && count($this->accepted_compression)) {
791
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $this->accepted_compression) . "\r\n";
791
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $this->accepted_compression)."\r\n";
792 792
         }
793 793
 
794 794
         $proxyCredentials = '';
@@ -800,13 +800,13 @@  discard block
 block discarded – undo
800 800
             $connectPort = $proxyPort;
801 801
             $transport = 'tcp';
802 802
             /// @todo check: should we not use https in some cases?
803
-            $uri = 'http://' . $server . ':' . $port . $this->path;
803
+            $uri = 'http://'.$server.':'.$port.$this->path;
804 804
             if ($proxyUsername != '') {
805 805
                 if ($proxyAuthType != 1) {
806 806
                     /// @todo make this a proper error, i.e. return a failure
807
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
807
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
808 808
                 }
809
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($proxyUsername . ':' . $proxyPassword) . "\r\n";
809
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($proxyUsername.':'.$proxyPassword)."\r\n";
810 810
             }
811 811
         } else {
812 812
             $connectServer = $server;
@@ -821,45 +821,45 @@  discard block
 block discarded – undo
821 821
             $version = '';
822 822
             foreach ($this->cookies as $name => $cookie) {
823 823
                 if ($cookie['version']) {
824
-                    $version = ' $Version="' . $cookie['version'] . '";';
825
-                    $cookieHeader .= ' ' . $name . '="' . $cookie['value'] . '";';
824
+                    $version = ' $Version="'.$cookie['version'].'";';
825
+                    $cookieHeader .= ' '.$name.'="'.$cookie['value'].'";';
826 826
                     if ($cookie['path']) {
827
-                        $cookieHeader .= ' $Path="' . $cookie['path'] . '";';
827
+                        $cookieHeader .= ' $Path="'.$cookie['path'].'";';
828 828
                     }
829 829
                     if ($cookie['domain']) {
830
-                        $cookieHeader .= ' $Domain="' . $cookie['domain'] . '";';
830
+                        $cookieHeader .= ' $Domain="'.$cookie['domain'].'";';
831 831
                     }
832 832
                     if ($cookie['port']) {
833
-                        $cookieHeader .= ' $Port="' . $cookie['port'] . '";';
833
+                        $cookieHeader .= ' $Port="'.$cookie['port'].'";';
834 834
                     }
835 835
                 } else {
836
-                    $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
836
+                    $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
837 837
                 }
838 838
             }
839
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
839
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
840 840
         }
841 841
 
842 842
         // omit port if default
843 843
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
844
-            $port =  '';
844
+            $port = '';
845 845
         } else {
846
-            $port = ':' . $port;
846
+            $port = ':'.$port;
847 847
         }
848 848
 
849
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
850
-            'User-Agent: ' . $this->user_agent . "\r\n" .
851
-            'Host: ' . $server . $port . "\r\n" .
852
-            $credentials .
853
-            $proxyCredentials .
854
-            $acceptedEncoding .
855
-            $encodingHdr .
856
-            'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings) . "\r\n" .
857
-            $cookieHeader .
858
-            'Content-Type: ' . $req->content_type . "\r\nContent-Length: " .
859
-            strlen($payload) . "\r\n\r\n" .
849
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
850
+            'User-Agent: '.$this->user_agent."\r\n".
851
+            'Host: '.$server.$port."\r\n".
852
+            $credentials.
853
+            $proxyCredentials.
854
+            $acceptedEncoding.
855
+            $encodingHdr.
856
+            'Accept-Charset: '.implode(',', $this->accepted_charset_encodings)."\r\n".
857
+            $cookieHeader.
858
+            'Content-Type: '.$req->content_type."\r\nContent-Length: ".
859
+            strlen($payload)."\r\n\r\n".
860 860
             $payload;
861 861
 
862
-        if ($this->debug > 1) {
862
+        if ($this->debug>1) {
863 863
             $this->getLogger()->debugMessage("---SENDING---\n$op\n---END---");
864 864
         }
865 865
 
@@ -886,7 +886,7 @@  discard block
 block discarded – undo
886 886
 
887 887
         $context = stream_context_create($contextOptions);
888 888
 
889
-        if ($timeout <= 0) {
889
+        if ($timeout<=0) {
890 890
             $connectTimeout = ini_get('default_socket_timeout');
891 891
         } else {
892 892
             $connectTimeout = $timeout;
@@ -898,7 +898,7 @@  discard block
 block discarded – undo
898 898
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
899 899
             STREAM_CLIENT_CONNECT, $context);
900 900
         if ($fp) {
901
-            if ($timeout > 0) {
901
+            if ($timeout>0) {
902 902
                 stream_set_timeout($fp, $timeout, 0);
903 903
             }
904 904
         } else {
@@ -907,8 +907,8 @@  discard block
 block discarded – undo
907 907
                 $this->errstr = $err['message'];
908 908
             }
909 909
 
910
-            $this->errstr = 'Connect error: ' . $this->errstr;
911
-            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
910
+            $this->errstr = 'Connect error: '.$this->errstr;
911
+            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
912 912
 
913 913
             return $r;
914 914
         }
@@ -996,18 +996,18 @@  discard block
 block discarded – undo
996 996
             $keyPass, $sslVersion);
997 997
 
998 998
         if (!$curl) {
999
-            return new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': error during curl initialization. Check php error log for details');
999
+            return new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': error during curl initialization. Check php error log for details');
1000 1000
         }
1001 1001
 
1002 1002
         $result = curl_exec($curl);
1003 1003
 
1004
-        if ($this->debug > 1) {
1004
+        if ($this->debug>1) {
1005 1005
             $message = "---CURL INFO---\n";
1006 1006
             foreach (curl_getinfo($curl) as $name => $val) {
1007 1007
                 if (is_array($val)) {
1008 1008
                     $val = implode("\n", $val);
1009 1009
                 }
1010
-                $message .= $name . ': ' . $val . "\n";
1010
+                $message .= $name.': '.$val."\n";
1011 1011
             }
1012 1012
             $message .= '---END---';
1013 1013
             $this->getLogger()->debugMessage($message);
@@ -1017,7 +1017,7 @@  discard block
 block discarded – undo
1017 1017
             /// @todo we should use a better check here - what if we get back '' or '0'?
1018 1018
 
1019 1019
             $this->errstr = 'no response';
1020
-            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . curl_error($curl));
1020
+            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.curl_error($curl));
1021 1021
             curl_close($curl);
1022 1022
             if ($keepAlive) {
1023 1023
                 $this->xmlrpc_curl_handle = null;
@@ -1087,12 +1087,12 @@  discard block
 block discarded – undo
1087 1087
                     // http, https
1088 1088
                     $protocol = $method;
1089 1089
                     if (strpos($protocol, ':') !== false) {
1090
-                        $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1090
+                        $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1091 1091
                         return false;
1092 1092
                     }
1093 1093
                 }
1094 1094
             }
1095
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $this->path);
1095
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$this->path);
1096 1096
             if (!$curl) {
1097 1097
                 return false;
1098 1098
             }
@@ -1106,7 +1106,7 @@  discard block
 block discarded – undo
1106 1106
         // results into variable
1107 1107
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1108 1108
 
1109
-        if ($this->debug > 1) {
1109
+        if ($this->debug>1) {
1110 1110
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1111 1111
             /// @todo allow callers to redirect curlopt_stderr to some stream which can be buffered
1112 1112
         }
@@ -1131,7 +1131,7 @@  discard block
 block discarded – undo
1131 1131
             }
1132 1132
         }
1133 1133
         // extra headers
1134
-        $headers = array('Content-Type: ' . $req->content_type, 'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings));
1134
+        $headers = array('Content-Type: '.$req->content_type, 'Accept-Charset: '.implode(',', $this->accepted_charset_encodings));
1135 1135
         // if no keepalive is wanted, let the server know it in advance
1136 1136
         if (!$keepAlive) {
1137 1137
             $headers[] = 'Connection: close';
@@ -1148,7 +1148,7 @@  discard block
 block discarded – undo
1148 1148
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
1149 1149
         // timeout is borked
1150 1150
         if ($timeout) {
1151
-            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout - 1);
1151
+            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout-1);
1152 1152
         }
1153 1153
 
1154 1154
         switch ($method) {
@@ -1163,7 +1163,7 @@  discard block
 block discarded – undo
1163 1163
                     curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE);
1164 1164
                 } else {
1165 1165
                     /// @todo make this a proper error, i.e. return a failure
1166
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install');
1166
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install');
1167 1167
                 }
1168 1168
                 break;
1169 1169
             case 'h2':
@@ -1172,12 +1172,12 @@  discard block
 block discarded – undo
1172 1172
         }
1173 1173
 
1174 1174
         if ($username && $password) {
1175
-            curl_setopt($curl, CURLOPT_USERPWD, $username . ':' . $password);
1175
+            curl_setopt($curl, CURLOPT_USERPWD, $username.':'.$password);
1176 1176
             if (defined('CURLOPT_HTTPAUTH')) {
1177 1177
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $authType);
1178 1178
             } elseif ($authType != 1) {
1179 1179
                 /// @todo make this a proper error, i.e. return a failure
1180
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1180
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1181 1181
             }
1182 1182
         }
1183 1183
 
@@ -1220,14 +1220,14 @@  discard block
 block discarded – undo
1220 1220
             if ($proxyPort == 0) {
1221 1221
                 $proxyPort = 8080; // NB: even for HTTPS, local connection is on port 8080
1222 1222
             }
1223
-            curl_setopt($curl, CURLOPT_PROXY, $proxyHost . ':' . $proxyPort);
1223
+            curl_setopt($curl, CURLOPT_PROXY, $proxyHost.':'.$proxyPort);
1224 1224
             if ($proxyUsername) {
1225
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername . ':' . $proxyPassword);
1225
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername.':'.$proxyPassword);
1226 1226
                 if (defined('CURLOPT_PROXYAUTH')) {
1227 1227
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $proxyAuthType);
1228 1228
                 } elseif ($proxyAuthType != 1) {
1229 1229
                     /// @todo make this a proper error, i.e. return a failure
1230
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1230
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1231 1231
                 }
1232 1232
             }
1233 1233
         }
@@ -1237,7 +1237,7 @@  discard block
 block discarded – undo
1237 1237
         if (count($this->cookies)) {
1238 1238
             $cookieHeader = '';
1239 1239
             foreach ($this->cookies as $name => $cookie) {
1240
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1240
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1241 1241
             }
1242 1242
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1243 1243
         }
@@ -1246,7 +1246,7 @@  discard block
 block discarded – undo
1246 1246
             curl_setopt($curl, $opt, $val);
1247 1247
         }
1248 1248
 
1249
-        if ($this->debug > 1) {
1249
+        if ($this->debug>1) {
1250 1250
             $this->getLogger()->debugMessage("---SENDING---\n$payload\n---END---");
1251 1251
         }
1252 1252
 
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
             $call['methodName'] = new Value($req->method(), 'string');
1338 1338
             $numParams = $req->getNumParams();
1339 1339
             $params = array();
1340
-            for ($i = 0; $i < $numParams; $i++) {
1340
+            for ($i = 0; $i<$numParams; $i++) {
1341 1341
                 $params[$i] = $req->getParam($i);
1342 1342
             }
1343 1343
             $call['params'] = new Value($params, 'array');
@@ -1359,7 +1359,7 @@  discard block
 block discarded – undo
1359 1359
         $response = array();
1360 1360
 
1361 1361
         if ($this->return_type == 'xml') {
1362
-            for ($i = 0; $i < count($reqs); $i++) {
1362
+            for ($i = 0; $i<count($reqs); $i++) {
1363 1363
                 $response[] = new Response($rets, 0, '', 'xml', $result->httpResponse());
1364 1364
             }
1365 1365
 
@@ -1367,21 +1367,21 @@  discard block
 block discarded – undo
1367 1367
             if (!is_array($rets)) {
1368 1368
                 // bad return type from system.multicall
1369 1369
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1370
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse());
1370
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse());
1371 1371
             }
1372 1372
             $numRets = count($rets);
1373 1373
             if ($numRets != count($reqs)) {
1374 1374
                 // wrong number of return values.
1375 1375
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1376
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals',
1376
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals',
1377 1377
                     $result->httpResponse());
1378 1378
             }
1379 1379
 
1380
-            for ($i = 0; $i < $numRets; $i++) {
1380
+            for ($i = 0; $i<$numRets; $i++) {
1381 1381
                 $val = $rets[$i];
1382 1382
                 if (!is_array($val)) {
1383 1383
                     return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1384
-                        PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1384
+                        PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1385 1385
                         'phpvals', $result->httpResponse());
1386 1386
                 }
1387 1387
                 switch (count($val)) {
@@ -1389,7 +1389,7 @@  discard block
 block discarded – undo
1389 1389
                         if (!isset($val[0])) {
1390 1390
                             // Bad value
1391 1391
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1392
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value",
1392
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value",
1393 1393
                                 'phpvals', $result->httpResponse());
1394 1394
                         }
1395 1395
                         // Normal return value
@@ -1401,20 +1401,20 @@  discard block
 block discarded – undo
1401 1401
                         if (!is_int($code)) {
1402 1402
                             /// @todo should we check that it is != 0?
1403 1403
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1404
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1404
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1405 1405
                                 'phpvals', $result->httpResponse());
1406 1406
                         }
1407 1407
                         $str = @$val['faultString'];
1408 1408
                         if (!is_string($str)) {
1409 1409
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1410
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString",
1410
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString",
1411 1411
                                 'phpvals', $result->httpResponse());
1412 1412
                         }
1413 1413
                         $response[$i] = new Response(0, $code, $str, 'phpvals', $result->httpResponse());
1414 1414
                         break;
1415 1415
                     default:
1416 1416
                         return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1417
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1417
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1418 1418
                             'phpvals', $result->httpResponse());
1419 1419
                 }
1420 1420
             }
@@ -1423,14 +1423,14 @@  discard block
 block discarded – undo
1423 1423
             // return type == 'xmlrpcvals'
1424 1424
             if ($rets->kindOf() != 'array') {
1425 1425
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1426
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals',
1426
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals',
1427 1427
                     $result->httpResponse());
1428 1428
             }
1429 1429
             $numRets = $rets->count();
1430 1430
             if ($numRets != count($reqs)) {
1431 1431
                 // wrong number of return values.
1432 1432
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1433
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals',
1433
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals',
1434 1434
                     $result->httpResponse());
1435 1435
             }
1436 1436
 
@@ -1439,7 +1439,7 @@  discard block
 block discarded – undo
1439 1439
                     case 'array':
1440 1440
                         if ($val->count() != 1) {
1441 1441
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1442
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1442
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1443 1443
                                 'phpvals', $result->httpResponse());
1444 1444
                         }
1445 1445
                         // Normal return value
@@ -1448,28 +1448,28 @@  discard block
 block discarded – undo
1448 1448
                     case 'struct':
1449 1449
                         if ($val->count() != 2) {
1450 1450
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1451
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1451
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1452 1452
                                 'phpvals', $result->httpResponse());
1453 1453
                         }
1454 1454
                         /** @var Value $code */
1455 1455
                         $code = $val['faultCode'];
1456 1456
                         if ($code->kindOf() != 'scalar' || $code->scalartyp() != 'int') {
1457 1457
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1458
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1458
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1459 1459
                                 'xmlrpcvals', $result->httpResponse());
1460 1460
                         }
1461 1461
                         /** @var Value $str */
1462 1462
                         $str = $val['faultString'];
1463 1463
                         if ($str->kindOf() != 'scalar' || $str->scalartyp() != 'string') {
1464 1464
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1465
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1465
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1466 1466
                                 'xmlrpcvals', $result->httpResponse());
1467 1467
                         }
1468 1468
                         $response[] = new Response(0, $code->scalarval(), $str->scalarval(), 'xmlrpcvals', $result->httpResponse());
1469 1469
                         break;
1470 1470
                     default:
1471 1471
                         return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1472
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1472
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1473 1473
                             'xmlrpcvals', $result->httpResponse());
1474 1474
                 }
1475 1475
             }
Please login to merge, or discard this patch.
extras/benchmark.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -19,9 +19,9 @@  discard block
 block discarded – undo
19 19
 use PhpXmlRpc\Encoder;
20 20
 
21 21
 /// @todo allow autoloading when the library is installed as dependency
22
-include_once __DIR__ . '/../vendor/autoload.php';
22
+include_once __DIR__.'/../vendor/autoload.php';
23 23
 
24
-include __DIR__ . '/../tests/parse_args.php';
24
+include __DIR__.'/../tests/parse_args.php';
25 25
 $args = argParser::getArgs();
26 26
 
27 27
 function begin_test($test_name, $test_case)
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     if (!isset($test_results[$test_name][$test_case])) {
42 42
         trigger_error('ending test that was not started');
43 43
     }
44
-    $test_results[$test_name][$test_case]['time'] = $end - $test_results[$test_name][$test_case]['time'];
44
+    $test_results[$test_name][$test_case]['time'] = $end-$test_results[$test_name][$test_case]['time'];
45 45
     $test_results[$test_name][$test_case]['result'] = $test_result;
46 46
     echo '.';
47 47
     flush();
@@ -75,24 +75,24 @@  discard block
 block discarded – undo
75 75
 }
76 76
 
77 77
 if ($is_web) {
78
-    echo "<h3>Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "</h3>\n";
78
+    echo "<h3>Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."</h3>\n";
79 79
     if ($xd) {
80
-        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: " . htmlspecialchars(xdebug_get_profiler_filename()) . "</h4>\n";
80
+        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: ".htmlspecialchars(xdebug_get_profiler_filename())."</h4>\n";
81 81
     }
82 82
     flush();
83 83
     ob_flush();
84 84
 } else {
85
-    echo "Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "\n";
85
+    echo "Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."\n";
86 86
     if ($xd) {
87
-        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: " . xdebug_get_profiler_filename() . "\n";
87
+        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: ".xdebug_get_profiler_filename()."\n";
88 88
     }
89 89
 }
90 90
 
91 91
 // test 'manual style' data encoding vs. 'automatic style' encoding
92 92
 begin_test('Data encoding (large array)', 'manual encoding');
93
-for ($i = 0; $i < $num_tests; $i++) {
93
+for ($i = 0; $i<$num_tests; $i++) {
94 94
     $vals = array();
95
-    for ($j = 0; $j < 10; $j++) {
95
+    for ($j = 0; $j<10; $j++) {
96 96
         $valarray = array();
97 97
         foreach ($data[$j] as $key => $val) {
98 98
             $values = array();
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
 begin_test('Data encoding (large array)', 'automatic encoding');
119 119
 $encoder = new Encoder();
120
-for ($i = 0; $i < $num_tests; $i++) {
120
+for ($i = 0; $i<$num_tests; $i++) {
121 121
     $value = $encoder->encode($data, array('auto_dates'));
122 122
     $out = $value->serialize();
123 123
 }
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 
126 126
 if (function_exists('xmlrpc_set_type')) {
127 127
     begin_test('Data encoding (large array)', 'xmlrpc-epi encoding');
128
-    for ($i = 0; $i < $num_tests; $i++) {
129
-        for ($j = 0; $j < 10; $j++) {
128
+    for ($i = 0; $i<$num_tests; $i++) {
129
+        for ($j = 0; $j<10; $j++) {
130 130
             foreach ($keys as $k) {
131 131
                 xmlrpc_set_type($data[$j][$k][4], 'datetime');
132 132
                 xmlrpc_set_type($data[$j][$k][8], 'datetime');
@@ -140,18 +140,18 @@  discard block
 block discarded – undo
140 140
 // test 'old style' data decoding vs. 'automatic style' decoding
141 141
 $dummy = new Request('');
142 142
 $out = new Response($value);
143
-$in = '<?xml version="1.0" ?>' . "\n" . $out->serialize();
143
+$in = '<?xml version="1.0" ?>'."\n".$out->serialize();
144 144
 
145 145
 begin_test('Data decoding (large array)', 'manual decoding');
146
-for ($i = 0; $i < $num_tests; $i++) {
146
+for ($i = 0; $i<$num_tests; $i++) {
147 147
     $response = $dummy->ParseResponse($in, true);
148 148
     $value = $response->value();
149 149
     $result = array();
150
-    foreach($value as $val1) {
150
+    foreach ($value as $val1) {
151 151
         $out = array();
152
-        foreach($val1 as $name => $val) {
152
+        foreach ($val1 as $name => $val) {
153 153
             $out[$name] = array();
154
-            foreach($val as $data) {
154
+            foreach ($val as $data) {
155 155
                 $out[$name][] = $data->scalarval();
156 156
             }
157 157
         }
@@ -161,18 +161,18 @@  discard block
 block discarded – undo
161 161
 end_test('Data decoding (large array)', 'manual decoding', $result);
162 162
 
163 163
 begin_test('Data decoding (large array)', 'manual decoding deprecated');
164
-for ($i = 0; $i < $num_tests; $i++) {
164
+for ($i = 0; $i<$num_tests; $i++) {
165 165
     $response = $dummy->ParseResponse($in, true);
166 166
     $value = $response->value();
167 167
     $result = array();
168 168
     $l = $value->arraysize();
169
-    for ($k = 0; $k < $l; $k++) {
169
+    for ($k = 0; $k<$l; $k++) {
170 170
         $val1 = $value->arraymem($k);
171 171
         $out = array();
172
-        foreach($val1 as $name => $val) {
172
+        foreach ($val1 as $name => $val) {
173 173
             $out[$name] = array();
174 174
             $m = $val->arraysize();
175
-            for ($j = 0; $j < $m; $j++) {
175
+            for ($j = 0; $j<$m; $j++) {
176 176
                 $data = $val->arraymem($j);
177 177
                 $out[$name][] = $data->scalarval();
178 178
             }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 end_test('Data decoding (large array)', 'manual decoding deprecated', $result);
184 184
 
185 185
 begin_test('Data decoding (large array)', 'automatic decoding');
186
-for ($i = 0; $i < $num_tests; $i++) {
186
+for ($i = 0; $i<$num_tests; $i++) {
187 187
     $response = $dummy->ParseResponse($in, true, 'phpvals');
188 188
     $value = $response->value();
189 189
 }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 
192 192
 if (function_exists('xmlrpc_decode')) {
193 193
     begin_test('Data decoding (large array)', 'xmlrpc-epi decoding');
194
-    for ($i = 0; $i < $num_tests; $i++) {
194
+    for ($i = 0; $i<$num_tests; $i++) {
195 195
         $response = $dummy->ParseResponse($in, true, 'xml');
196 196
         $value = xmlrpc_decode($response->value());
197 197
     }
@@ -208,16 +208,16 @@  discard block
 block discarded – undo
208 208
     $value = $encoder->encode($data1, array('auto_dates'));
209 209
     $req = new Request('interopEchoTests.echoValue', array($value));
210 210
     $reqs = array();
211
-    for ($i = 0; $i < $num_tests; $i++) {
211
+    for ($i = 0; $i<$num_tests; $i++) {
212 212
         $reqs[] = $req;
213 213
     }
214 214
 
215 215
     $server = explode(':', $args['HTTPSERVER']);
216
-    if (count($server) > 1) {
217
-        $srv = 'http://' . $server[0] . '://' . $server[1] . $args['HTTPURI'];
216
+    if (count($server)>1) {
217
+        $srv = 'http://'.$server[0].'://'.$server[1].$args['HTTPURI'];
218 218
         $c = new Client($args['HTTPURI'], $server[0], $server[1]);
219 219
     } else {
220
-        $srv = 'http://' . $args['HTTPSERVER'] . $args['HTTPURI'];
220
+        $srv = 'http://'.$args['HTTPSERVER'].$args['HTTPURI'];
221 221
         $c = new Client($args['HTTPURI'], $args['HTTPSERVER']);
222 222
     }
223 223
 
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
 
230 230
     begin_test($testName, 'http 10');
231 231
     $response = array();
232
-    for ($i = 0; $i < $num_tests; $i++) {
232
+    for ($i = 0; $i<$num_tests; $i++) {
233 233
         $resp = $c->send($req);
234 234
         $response[] = $resp->value();
235 235
     }
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
         $c->keepalive = false;
240 240
         begin_test($testName, 'http 11 no keepalive');
241 241
         $response = array();
242
-        for ($i = 0; $i < $num_tests; $i++) {
242
+        for ($i = 0; $i<$num_tests; $i++) {
243 243
             $resp = $c->send($req, 10, 'http11');
244 244
             $response[] = $resp->value();
245 245
         }
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 
248 248
         begin_test($testName, 'http 11 w. keep-alive');
249 249
         $response = array();
250
-        for ($i = 0; $i < $num_tests; $i++) {
250
+        for ($i = 0; $i<$num_tests; $i++) {
251 251
             $resp = $c->send($req, 10, 'http11');
252 252
             $response[] = $resp->value();
253 253
         }
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 
270 270
         begin_test($testName, 'http 10 w. compression');
271 271
         $response = array();
272
-        for ($i = 0; $i < $num_tests; $i++) {
272
+        for ($i = 0; $i<$num_tests; $i++) {
273 273
             $resp = $c->send($req);
274 274
             $response[] = $resp->value();
275 275
         }
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             $c->keepalive = false;
280 280
             begin_test($testName, 'http 11 w. compression and no keepalive');
281 281
             $response = array();
282
-            for ($i = 0; $i < $num_tests; $i++) {
282
+            for ($i = 0; $i<$num_tests; $i++) {
283 283
                 $resp = $c->send($req, 10, 'http11');
284 284
                 $response[] = $resp->value();
285 285
             }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
             $c->keepalive = true;
289 289
             begin_test($testName, 'http 11 w. keep-alive and compression');
290 290
             $response = array();
291
-            for ($i = 0; $i < $num_tests; $i++) {
291
+            for ($i = 0; $i<$num_tests; $i++) {
292 292
                 $resp = $c->send($req, 10, 'http11');
293 293
                 $response[] = $resp->value();
294 294
             }
@@ -309,11 +309,11 @@  discard block
 block discarded – undo
309 309
         /// test multicall vs. many calls vs. keep-alives - HTTPS
310 310
 
311 311
         $server = explode(':', $args['HTTPSSERVER']);
312
-        if (count($server) > 1) {
313
-            $srv = 'https://' . $server[0] . ':' . $server[1] . $args['HTTPSURI'];
312
+        if (count($server)>1) {
313
+            $srv = 'https://'.$server[0].':'.$server[1].$args['HTTPSURI'];
314 314
             $c = new Client($args['HTTPSURI'], $server[0], $server[1], 'https');
315 315
         } else {
316
-            $srv = 'https://' . $args['HTTPSSERVER'] . $args['HTTPSURI'];
316
+            $srv = 'https://'.$args['HTTPSSERVER'].$args['HTTPSURI'];
317 317
             $c = new Client($args['HTTPSURI'], $args['HTTPSSERVER'], 443, 'https');
318 318
         }
319 319
         $c->setSSLVerifyPeer(!$args['HTTPSIGNOREPEER']);
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
         begin_test($testName, 'https no keep-alive');
328 328
         $c->keepalive = false;
329 329
         $response = array();
330
-        for ($i = 0; $i < $num_tests; $i++) {
330
+        for ($i = 0; $i<$num_tests; $i++) {
331 331
             $resp = $c->send($req);
332 332
             $response[] = $resp->value();
333 333
         }
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
         begin_test($testName, 'https w. keep-alive');
337 337
         $c->keepalive = true;
338 338
         $response = array();
339
-        for ($i = 0; $i < $num_tests; $i++) {
339
+        for ($i = 0; $i<$num_tests; $i++) {
340 340
             $resp = $c->send($req, 10);
341 341
             $response[] = $resp->value();
342 342
         }
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
             $c->keepalive = false;
358 358
             begin_test($testName, 'https w. compression and no keepalive');
359 359
             $response = array();
360
-            for ($i = 0; $i < $num_tests; $i++) {
360
+            for ($i = 0; $i<$num_tests; $i++) {
361 361
                 $resp = $c->send($req);
362 362
                 $response[] = $resp->value();
363 363
             }
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
             $c->keepalive = true;
367 367
             begin_test($testName, 'https w. keep-alive and compression');
368 368
             $response = array();
369
-            for ($i = 0; $i < $num_tests; $i++) {
369
+            for ($i = 0; $i<$num_tests; $i++) {
370 370
                 $resp = $c->send($req, 10);
371 371
                 $response[] = $resp->value();
372 372
             }
@@ -387,11 +387,11 @@  discard block
 block discarded – undo
387 387
         /// test multicall vs. many calls vs. keep-alives - HTTP/2
388 388
 
389 389
         $server = explode(':', $args['HTTPSSERVER']);
390
-        if (count($server) > 1) {
391
-            $srv = 'https://' . $server[0] . ':' . $server[1] . $args['HTTPSURI'];
390
+        if (count($server)>1) {
391
+            $srv = 'https://'.$server[0].':'.$server[1].$args['HTTPSURI'];
392 392
             $c = new Client($args['HTTPSURI'], $server[0], $server[1], 'https');
393 393
         } else {
394
-            $srv = 'https://' . $args['HTTPSSERVER'] . $args['HTTPSURI'];
394
+            $srv = 'https://'.$args['HTTPSSERVER'].$args['HTTPSURI'];
395 395
             $c = new Client($args['HTTPSURI'], $args['HTTPSSERVER'], 443, 'h2');
396 396
         }
397 397
         $c->setSSLVerifyPeer(!$args['HTTPSIGNOREPEER']);
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
         begin_test($testName, 'http2 no keep-alive');
406 406
         $c->keepalive = false;
407 407
         $response = array();
408
-        for ($i = 0; $i < $num_tests; $i++) {
408
+        for ($i = 0; $i<$num_tests; $i++) {
409 409
             $resp = $c->send($req);
410 410
             $response[] = $resp->value();
411 411
         }
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
         begin_test($testName, 'http2 w. keep-alive');
415 415
         $c->keepalive = true;
416 416
         $response = array();
417
-        for ($i = 0; $i < $num_tests; $i++) {
417
+        for ($i = 0; $i<$num_tests; $i++) {
418 418
             $resp = $c->send($req, 10);
419 419
             $response[] = $resp->value();
420 420
         }
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
             $c->keepalive = false;
436 436
             begin_test($testName, 'http2 w. compression and no keepalive');
437 437
             $response = array();
438
-            for ($i = 0; $i < $num_tests; $i++) {
438
+            for ($i = 0; $i<$num_tests; $i++) {
439 439
                 $resp = $c->send($req);
440 440
                 $response[] = $resp->value();
441 441
             }
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
             $c->keepalive = true;
445 445
             begin_test($testName, 'http2 w. keep-alive and compression');
446 446
             $response = array();
447
-            for ($i = 0; $i < $num_tests; $i++) {
447
+            for ($i = 0; $i<$num_tests; $i++) {
448 448
                 $resp = $c->send($req, 10);
449 449
                 $response[] = $resp->value();
450 450
             }
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
 foreach ($test_results as $test => $results) {
467 467
     echo "\nTEST: $test\n";
468 468
     foreach ($results as $case => $data) {
469
-        echo "  $case: {$data['time']} secs - Output data CRC: " . crc32(serialize($data['result'])) . "\n";
469
+        echo "  $case: {$data['time']} secs - Output data CRC: ".crc32(serialize($data['result']))."\n";
470 470
     }
471 471
 }
472 472
 
Please login to merge, or discard this patch.
tests/PolyfillTestCase.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,20 +2,20 @@
 block discarded – undo
2 2
 
3 3
 use PHPUnit\Runner\Version as PHPUnit_Version;
4 4
 
5
-if ( class_exists( 'PHPUnit_Extensions_SeleniumCommon_RemoteCoverage' ) === true
6
-    && class_exists( 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage' ) === false
5
+if (class_exists('PHPUnit_Extensions_SeleniumCommon_RemoteCoverage') === true
6
+    && class_exists('PHPUnit\Extensions\SeleniumCommon\RemoteCoverage') === false
7 7
 ) {
8
-    class_alias( 'PHPUnit_Extensions_SeleniumCommon_RemoteCoverage', 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage' );
8
+    class_alias('PHPUnit_Extensions_SeleniumCommon_RemoteCoverage', 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage');
9 9
 }
10 10
 
11
-if ( class_exists( 'PHPUnit_Runner_BaseTestRunner' ) === true
12
-    && class_exists( 'PHPUnit\Runner\BaseTestRunner' ) === false
11
+if (class_exists('PHPUnit_Runner_BaseTestRunner') === true
12
+    && class_exists('PHPUnit\Runner\BaseTestRunner') === false
13 13
 ) {
14
-    class_alias( 'PHPUnit_Runner_BaseTestRunner', 'PHPUnit\Runner\BaseTestRunner' );
14
+    class_alias('PHPUnit_Runner_BaseTestRunner', 'PHPUnit\Runner\BaseTestRunner');
15 15
 }
16 16
 
17 17
 if (class_exists('PHPUnit\Runner\Version') === false || version_compare(PHPUnit_Version::id(), '8.0.0', '<')) {
18
-    include_once __DIR__ . '/PolyfillTestCase7.php';
18
+    include_once __DIR__.'/PolyfillTestCase7.php';
19 19
 } else {
20
-    include_once __DIR__ . '/PolyfillTestCase8.php';
20
+    include_once __DIR__.'/PolyfillTestCase8.php';
21 21
 }
Please login to merge, or discard this patch.
lib/xmlrpcs.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function echoInput()
56 56
     {
57
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
57
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
58 58
         print $r->serialize();
59 59
     }
60 60
 
@@ -65,12 +65,12 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function __get($name)
67 67
     {
68
-        switch($name) {
68
+        switch ($name) {
69 69
             case 'dmap':
70 70
                 return $this->dmap;
71 71
             default:
72 72
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
73
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' .
73
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.
74 74
                     $trace[0]['line'], E_USER_NOTICE);
75 75
                 return null;
76 76
         }
@@ -97,30 +97,30 @@  discard block
 block discarded – undo
97 97
     Server::xmlrpc_debugmsg($m);
98 98
 }
99 99
 
100
-function _xmlrpcs_getCapabilities($server, $m=null)
100
+function _xmlrpcs_getCapabilities($server, $m = null)
101 101
 {
102 102
     return Server::_xmlrpcs_getCapabilities($server, $m);
103 103
 }
104 104
 
105
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
107
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
108
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
105
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
107
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
108
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
109 109
 {
110 110
     return Server::_xmlrpcs_listMethods($server, $m);
111 111
 }
112 112
 
113
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
113
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
116 116
 function _xmlrpcs_methodSignature($server, $m)
117 117
 {
118 118
     return Server::_xmlrpcs_methodSignature($server, $m);
119 119
 }
120 120
 
121
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
123
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
121
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
123
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
124 124
 function _xmlrpcs_methodHelp($server, $m)
125 125
 {
126 126
     return Server::_xmlrpcs_methodHelp($server, $m);
Please login to merge, or discard this patch.