View GitHub Repository phpxmlrpc

Schedule Inspection
Subscribe
Passed
Push — master ( 8d7896...766bff )
by Gaetano
09:39
created
Status
Category
Toggle Patches
demo/client/parallel.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 use PhpXmlRpc\Encoder;
5 5 
 use PhpXmlRpc\Client;
 
@@ -24,7 +24,7 @@  discard block
 
 block discarded – undo
24 24 
         $handles = array();
25 25 
         $curl = curl_multi_init();
26 26
27 
-        foreach($requests as $k => $req) {
27 
+        foreach ($requests as $k => $req) {
28 28 
             $req->setDebug($this->debug);
29 29
30 30 
             $handle = $this->prepareCurlHandle(
 
@@ -57,19 +57,19 @@  discard block
 
 block discarded – undo
57 57 
         $running = 0;
58 58 
         do {
59 59 
             curl_multi_exec($curl, $running);
60 
-        } while($running > 0);
60 
+        } while ($running>0);
61 61
62 62 
         $responses = array();
63 
-        foreach($handles as $k => $h) {
63 
+        foreach ($handles as $k => $h) {
64 64 
             $responses[$k] = curl_multi_getcontent($handles[$k]);
65 65
66 
-            if ($this->debug > 1) {
66 
+            if ($this->debug>1) {
67 67 
                 $message = "---CURL INFO---\n";
68 68 
                 foreach (curl_getinfo($h) as $name => $val) {
69 69 
                     if (is_array($val)) {
70 70 
                         $val = implode("\n", $val);
71 71 
                     }
72 
-                    $message .= $name . ': ' . $val . "\n";
72 
+                    $message .= $name.': '.$val."\n";
73 73 
                 }
74 74 
                 $message .= '---END---';
75 75 
                 $this->getLogger()->debugMessage($message);
 
@@ -80,9 +80,9 @@  discard block
 
 block discarded – undo
80 80 
         }
81 81 
         curl_multi_close($curl);
82 82
83 
-        foreach($responses as $k => $resp) {
83 
+        foreach ($responses as $k => $resp) {
84 84 
             if (!$resp) {
85 
-                $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . curl_error($curl));
85 
+                $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.curl_error($curl));
86 86 
             } else {
87 87 
                 $responses[$k] = $requests[$k]->parseResponse($resp, true, $this->return_type);
88 88 
             }
 
@@ -99,7 +99,7 @@  discard block
 
 block discarded – undo
99 99 
 $value = $encoder->encode($data, array('auto_dates'));
100 100 
 $req = new Request('interopEchoTests.echoValue', array($value));
101 101 
 $reqs = array();
102 
-for ($i = 0; $i < $num_tests; $i++) {
102 
+for ($i = 0; $i<$num_tests; $i++) {
103 103 
     $reqs[] = $req;
104 104 
 }
105 105 
 
@@ -108,16 +108,16 @@  discard block
 
 block discarded – undo
108 108
109 109 
 $t = microtime(true);
110 110 
 $resp = $client->send($reqs);
111 
-$t = microtime(true) - $t;
111 
+$t = microtime(true)-$t;
112 112 
 echo "Sequential send: $t secs\n";
113 113
114 114 
 $t = microtime(true);
115 115 
 $resp = $client->sendParallel($reqs);
116 
-$t = microtime(true) - $t;
116 
+$t = microtime(true)-$t;
117 117 
 echo "Parallel send: $t secs\n";
118 118
119 119 
 $client->no_multicall = false;
120 120 
 $t = microtime(true);
121 121 
 $resp = $client->send($reqs);
122 
-$t = microtime(true) - $t;
122 
+$t = microtime(true)-$t;
123 123 
 echo "Multicall send: $t secs\n";
Please login to merge, or discard this patch.
demo/client/agesort.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Agesort demo</title></head>
 
@@ -13,7 +13,7 @@  discard block
 
 block discarded – undo
13 13 
 $inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
14 14 
 output("This is the input data:<br/><pre>");
15 15 
 foreach ($inAr as $key => $val) {
16 
-    output($key . ", " . $val . "\n");
16 
+    output($key.", ".$val."\n");
17 17 
 }
18 18 
 output("</pre>");
19 19 
 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29 
     );
30 30 
 }
31 31 
 $v = new PhpXmlRpc\Value($p, "array");
32 
-output("Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n");
32 
+output("Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n");
33 33
34 34 
 // create client and message objects
35 35 
 $req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
 
@@ -49,15 +49,15 @@  discard block
 
 block discarded – undo
49 49 
     foreach ($value as $struct) {
50 50 
         $name = $struct["name"];
51 51 
         $age = $struct["age"];
52 
-        output(htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n");
52 
+        output(htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n");
53 53 
     }
54 54
55 
-    output("<hr/>For nerds: I got this value back<br/><pre>" .
56 
-        htmlentities($resp->serialize()) . "</pre><hr/>\n");
55 
+    output("<hr/>For nerds: I got this value back<br/><pre>".
56 
+        htmlentities($resp->serialize())."</pre><hr/>\n");
57 57 
 } else {
58 58 
     output("An error occurred:<pre>");
59 
-    output("Code: " . htmlspecialchars($resp->faultCode()) .
60 
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>');
59 
+    output("Code: ".htmlspecialchars($resp->faultCode()).
60 
+        "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>');
61 61 
 }
62 62
63 63 
 output("</body></html>\n");
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Webservice wrappper demo</title></head>
 
@@ -20,7 +20,7 @@  discard block
 
 block discarded – undo
20 20 
 $client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
21 21 
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
22 22 
 if ($resp->faultCode()) {
23 
-    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n");
23 
+    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n");
24 24 
 } else {
25 25 
     output("<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n");
26 26 
     flush();
 
@@ -32,9 +32,9 @@  discard block
 
 block discarded – undo
32 32 
         if ($methodName == 'examples.getStateName') {
33 33 
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
34 34 
             if ($callable) {
35 
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n");
35 
+                output("<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n");
36 36 
             } else {
37 
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n");
37 
+                output("<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n");
38 38 
             }
39 39 
             break;
40 40 
         }
Please login to merge, or discard this patch.
demo/client/_prepend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,7 @@
 
 block discarded – undo
14 14 
 }
15 15
16 16 
 // Use the custom class autoloader. These two lines not needed when the phpxmlrpc library is installed using Composer
17 
-include_once __DIR__ . '/../../src/Autoloader.php';
17 
+include_once __DIR__.'/../../src/Autoloader.php';
18 18 
 PhpXmlRpc\Autoloader::register();
19 19
20 20 
 // Let unit tests run against localhost, 'plain' demos against a known public server
Please login to merge, or discard this patch.
demo/client/which.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Which toolkit demo</title></head>
 
@@ -18,14 +18,14 @@  discard block
 
 block discarded – undo
18 18 
     $value = $encoder->decode($resp->value());
19 19 
     output("Toolkit info:<br/>\n");
20 20 
     output("<pre>");
21 
-    output("name: " . htmlspecialchars($value["toolkitName"]) . "\n");
22 
-    output("version: " . htmlspecialchars($value["toolkitVersion"]) . "\n");
23 
-    output("docs: " . htmlspecialchars($value["toolkitDocsUrl"]) . "\n");
24 
-    output("os: " . htmlspecialchars($value["toolkitOperatingSystem"]) . "\n");
21 
+    output("name: ".htmlspecialchars($value["toolkitName"])."\n");
22 
+    output("version: ".htmlspecialchars($value["toolkitVersion"])."\n");
23 
+    output("docs: ".htmlspecialchars($value["toolkitDocsUrl"])."\n");
24 
+    output("os: ".htmlspecialchars($value["toolkitOperatingSystem"])."\n");
25 25 
     output("</pre>");
26 26 
 } else {
27 27 
     output("An error occurred: ");
28 
-    output("Code: " . htmlspecialchars($resp->faultCode()) . " Reason: '" . htmlspecialchars($resp->faultString()) . "'\n");
28 
+    output("Code: ".htmlspecialchars($resp->faultCode())." Reason: '".htmlspecialchars($resp->faultString())."'\n");
29 29 
 }
30 30
31 31 
 output("</body></html>\n");
Please login to merge, or discard this patch.
demo/client/introspect.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Introspect demo</title></head>
 
@@ -13,13 +13,13 @@  discard block
 
 block discarded – undo
13 13 
 function display_error($r)
14 14 
 {
15 15 
     output("An error occurred: ");
16 
-    output("Code: " . $r->faultCode() . " Reason: '" . $r->faultString() . "'<br/>");
16 
+    output("Code: ".$r->faultCode()." Reason: '".$r->faultString()."'<br/>");
17 17 
 }
18 18
19 19 
 $client = new PhpXmlRpc\Client(XMLRPCSERVER);
20 20
21 21 
 // First off, let's retrieve the list of methods available on the remote server
22 
-output("<h3>methods available at http://" . $client->server . $client->path . "</h3>\n");
22 
+output("<h3>methods available at http://".$client->server.$client->path."</h3>\n");
23 23 
 $req = new PhpXmlRpc\Request('system.listMethods');
24 24 
 $resp = $client->send($req);
25 25 
 
@@ -30,7 +30,7 @@  discard block
 
 block discarded – undo
30 30
31 31 
     // Then, retrieve the signature and help text of each available method
32 32 
     foreach ($v as $methodName) {
33 
-        output("<h4>" . htmlspecialchars($methodName->scalarval()) . "</h4>\n");
33 
+        output("<h4>".htmlspecialchars($methodName->scalarval())."</h4>\n");
34 34 
         // build messages first, add params later
35 35 
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
36 36 
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
 
@@ -61,13 +61,13 @@  discard block
 
 block discarded – undo
61 61 
             if ($val->kindOf() == "array") {
62 62 
                 foreach ($val as $x) {
63 63 
                     $ret = $x[0];
64 
-                    output("<code>" . htmlspecialchars($ret->scalarval()) . " "
65 
-                        . htmlspecialchars($methodName->scalarval()) . "(");
66 
-                    if ($x->count() > 1) {
67 
-                        for ($k = 1; $k < $x->count(); $k++) {
64 
+                    output("<code>".htmlspecialchars($ret->scalarval())." "
65 
+                        . htmlspecialchars($methodName->scalarval())."(");
66 
+                    if ($x->count()>1) {
67 
+                        for ($k = 1; $k<$x->count(); $k++) {
68 68 
                             $y = $x[$k];
69 69 
                             output(htmlspecialchars($y->scalarval()));
70 
-                            if ($k < $x->count() - 1) {
70 
+                            if ($k<$x->count()-1) {
71 71 
                                 output(", ");
72 72 
                             }
73 73 
                         }
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Proxy demo</title></head>
Please login to merge, or discard this patch.
demo/client/mail.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,5 +1,5 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 
-require_once __DIR__ . "/_prepend.php";
2 
+require_once __DIR__."/_prepend.php";
3 3
4 4 
 output('<html lang="en">
5 5 
 <head><title>xmlrpc - Mail demo</title></head>
 
@@ -35,8 +35,8 @@  discard block
 
 block discarded – undo
35 35 
         output("<font color=\"red\">");
36 36 
         output("Mail send failed<br/>\n");
37 37 
         output("Fault: ");
38 
-        output("Code: " . htmlspecialchars($resp->faultCode()) .
39 
-            " Reason: '" . htmlspecialchars($resp->faultString()) . "'<br/>");
38 
+        output("Code: ".htmlspecialchars($resp->faultCode()).
39 
+            " Reason: '".htmlspecialchars($resp->faultString())."'<br/>");
40 40 
         output("</font><br/>");
41 41 
     }
42 42 
 }
Please login to merge, or discard this patch.
tests/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -15,7 +15,7 @@  discard block
 
 block discarded – undo
15 15 
         chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777);
16 16 
     }
17 17
18 
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
18 
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
19 19 
 }
20 20
21 21 
 $targetFile = null;
 
@@ -38,5 +38,5 @@  discard block
 
 block discarded – undo
38 38 
 }
39 39
40 40 
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
41 
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
41 
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
42 42 
 }
Please login to merge, or discard this patch.