Passed
Push — master ( 15029b...b614c9 )
by Gaetano
11:58 queued 04:30
created
tests/WebTestCase.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/parse_args.php';
3
+include_once __DIR__.'/parse_args.php';
4 4
 
5
-include_once __DIR__ . '/PolyfillTestCase.php';
5
+include_once __DIR__.'/PolyfillTestCase.php';
6 6
 
7 7
 use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage;
8 8
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function _run($result = NULL)
27 27
     {
28
-        $this->testId = get_class($this) . '__' . $this->getName();
28
+        $this->testId = get_class($this).'__'.$this->getName();
29 29
 
30 30
         if ($result === NULL) {
31 31
             $result = $this->createResult();
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     protected function request($path, $method = 'GET', $payload = '', $emptyPageOk = false)
62 62
     {
63
-        $url = $this->baseUrl . $path;
63
+        $url = $this->baseUrl.$path;
64 64
 
65 65
         $ch = curl_init($url);
66 66
         curl_setopt_array($ch, array(
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         {
79 79
             curl_setopt($ch, CURLOPT_COOKIE, 'PHPUNIT_SELENIUM_TEST_ID='.$this->testId);
80 80
         }
81
-        if ($this->args['DEBUG'] > 0) {
81
+        if ($this->args['DEBUG']>0) {
82 82
             curl_setopt($ch, CURLOPT_VERBOSE, 1);
83 83
         }
84 84
         $page = curl_exec($ch);
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $val = reset($ar);
108 108
         $typ = key($ar);
109 109
 
110
-        return '<value>' . $this->serializedata($typ, $val) . "</value>\n";
110
+        return '<value>'.$this->serializedata($typ, $val)."</value>\n";
111 111
         //}
112 112
     }
113 113
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         // preserve back compatibility
127 127
 
128 128
         if (is_array($b)) {
129
-            foreach($b as $id => $cont) {
129
+            foreach ($b as $id => $cont) {
130 130
                 $b[$id] = $cont->scalarval();
131 131
             }
132 132
         }
@@ -134,10 +134,10 @@  discard block
 block discarded – undo
134 134
         // add support for structures directly encoding php objects
135 135
         if (is_object($b)) {
136 136
             $t = get_object_vars($b);
137
-            foreach($t as $id => $cont) {
137
+            foreach ($t as $id => $cont) {
138 138
                 $t[$id] = $cont->scalarval();
139 139
             }
140
-            foreach($t as $id => $cont) {
140
+            foreach ($t as $id => $cont) {
141 141
                 @$b->$id = $cont;
142 142
             }
143 143
         }
@@ -179,17 +179,17 @@  discard block
 block discarded – undo
179 179
 /* Expose as global functions the ones which are now class methods */
180 180
 
181 181
 /// Wrong speling, but we are adamant on backwards compatibility!
182
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
182
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
183 183
 {
184 184
     return Charset::instance()->encodeEntities($data, $srcEncoding, $destEncoding);
185 185
 }
186 186
 
187
-function iso8601_encode($timeT, $utc=0)
187
+function iso8601_encode($timeT, $utc = 0)
188 188
 {
189 189
     return Date::iso8601Encode($timeT, $utc);
190 190
 }
191 191
 
192
-function iso8601_decode($iDate, $utc=0)
192
+function iso8601_decode($iDate, $utc = 0)
193 193
 {
194 194
     return Date::iso8601Decode($iDate, $utc);
195 195
 }
@@ -199,25 +199,25 @@  discard block
 block discarded – undo
199 199
     return Http::decodeChunked($buffer);
200 200
 }
201 201
 
202
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
202
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
203 203
 {
204 204
     $encoder = new Encoder();
205 205
     return $encoder->decode($xmlrpcVal, $options);
206 206
 }
207 207
 
208
-function php_xmlrpc_encode($phpVal, $options=array())
208
+function php_xmlrpc_encode($phpVal, $options = array())
209 209
 {
210 210
     $encoder = new Encoder();
211 211
     return $encoder->encode($phpVal, $options);
212 212
 }
213 213
 
214
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
214
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
215 215
 {
216 216
     $encoder = new Encoder();
217 217
     return $encoder->decodeXml($xmlVal, $options);
218 218
 }
219 219
 
220
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
220
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
221 221
 {
222 222
     return XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
223 223
 }
Please login to merge, or discard this patch.
debugger/index.php 2 patches
Braces   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,12 @@
 block discarded – undo
12 12
 <html lang="en">
13 13
 <head>
14 14
     <link rel="icon" type="image/vnd.microsoft.icon" href="favicon.ico">
15
-    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) echo 'JSONRPC'; else echo 'XMLRPC'; ?> Debugger</title>
15
+    <title><?php if (defined('DEFAULT_WSTYPE') && DEFAULT_WSTYPE == 1) {
16
+    echo 'JSONRPC';
17
+} else {
18
+    echo 'XMLRPC';
19
+}
20
+?> Debugger</title>
16 21
 </head>
17 22
 <frameset rows="360,*">
18 23
     <frame name="frmcontroller" src="controller.php<?php echo htmlspecialchars($query); ?>" marginwidth="0"
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 if (isset($_GET['run'])) {
5 5
     $path = parse_url($_GET['run']);
6 6
     if (isset($path['query'])) {
7
-        $query = '?' . $path['query'];
7
+        $query = '?'.$path['query'];
8 8
     }
9 9
 }
10 10
 
Please login to merge, or discard this patch.
src/Helper/Charset.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -176,8 +176,7 @@
 block discarded – undo
176 176
                         } else {
177 177
                             $escapedData .= $ch;
178 178
                         }
179
-                    }
180
-                    else if ($ii < 128) {
179
+                    } else if ($ii < 128) {
181 180
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
182 181
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
183 182
                         switch ($ii) {
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -91,14 +91,14 @@  discard block
 block discarded – undo
91 91
                 if (count($this->xml_iso88591_Entities['in'])) {
92 92
                     return;
93 93
                 }
94
-                for ($i = 0; $i < 32; $i++) {
94
+                for ($i = 0; $i<32; $i++) {
95 95
                     $this->xml_iso88591_Entities["in"][] = chr($i);
96 96
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
97 97
                 }
98 98
 
99 99
                 /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
100 100
 
101
-                for ($i = 160; $i < 256; $i++) {
101
+                for ($i = 160; $i<256; $i++) {
102 102
                     $this->xml_iso88591_Entities["in"][] = chr($i);
103 103
                     $this->xml_iso88591_Entities["out"][] = "&#{$i};";
104 104
                 }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
                 break;*/
127 127
 
128 128
             default:
129
-                throw new \Exception('Unsupported table: ' . $tableName);
129
+                throw new \Exception('Unsupported table: '.$tableName);
130 130
         }
131 131
     }
132 132
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
             $srcEncoding = 'UTF-8';
179 179
         }
180 180
 
181
-        $conversion = strtoupper($srcEncoding . '_' . $destEncoding);
181
+        $conversion = strtoupper($srcEncoding.'_'.$destEncoding);
182 182
 
183 183
         // list ordered with (expected) most common scenarios first
184 184
         switch ($conversion) {
@@ -196,20 +196,20 @@  discard block
 block discarded – undo
196 196
                 // NB: this will choke on invalid UTF-8, going most likely beyond EOF
197 197
                 $escapedData = '';
198 198
                 // be kind to users creating string xmlrpc values out of different php types
199
-                $data = (string)$data;
199
+                $data = (string) $data;
200 200
                 $ns = strlen($data);
201
-                for ($nn = 0; $nn < $ns; $nn++) {
201
+                for ($nn = 0; $nn<$ns; $nn++) {
202 202
                     $ch = $data[$nn];
203 203
                     $ii = ord($ch);
204 204
                     // 7 bits in 1 byte: 0bbbbbbb (127)
205
-                    if ($ii < 32) {
205
+                    if ($ii<32) {
206 206
                         if ($conversion == 'UTF-8_US-ASCII') {
207 207
                             $escapedData .= sprintf('&#%d;', $ii);
208 208
                         } else {
209 209
                             $escapedData .= $ch;
210 210
                         }
211 211
                     }
212
-                    else if ($ii < 128) {
212
+                    else if ($ii<128) {
213 213
                         /// @todo shall we replace this with a (supposedly) faster str_replace?
214 214
                         /// @todo to be 'print safe', should we encode as well character 127 (DEL) ?
215 215
                         switch ($ii) {
@@ -234,25 +234,25 @@  discard block
 block discarded – undo
234 234
                     } // 11 bits in 2 bytes: 110bbbbb 10bbbbbb (2047)
235 235
                     elseif ($ii >> 5 == 6) {
236 236
                         $b1 = ($ii & 31);
237
-                        $b2 = (ord($data[$nn + 1]) & 63);
238
-                        $ii = ($b1 * 64) + $b2;
237
+                        $b2 = (ord($data[$nn+1]) & 63);
238
+                        $ii = ($b1 * 64)+$b2;
239 239
                         $escapedData .= sprintf('&#%d;', $ii);
240 240
                         $nn += 1;
241 241
                     } // 16 bits in 3 bytes: 1110bbbb 10bbbbbb 10bbbbbb
242 242
                     elseif ($ii >> 4 == 14) {
243 243
                         $b1 = ($ii & 15);
244
-                        $b2 = (ord($data[$nn + 1]) & 63);
245
-                        $b3 = (ord($data[$nn + 2]) & 63);
246
-                        $ii = ((($b1 * 64) + $b2) * 64) + $b3;
244
+                        $b2 = (ord($data[$nn+1]) & 63);
245
+                        $b3 = (ord($data[$nn+2]) & 63);
246
+                        $ii = ((($b1 * 64)+$b2) * 64)+$b3;
247 247
                         $escapedData .= sprintf('&#%d;', $ii);
248 248
                         $nn += 2;
249 249
                     } // 21 bits in 4 bytes: 11110bbb 10bbbbbb 10bbbbbb 10bbbbbb
250 250
                     elseif ($ii >> 3 == 30) {
251 251
                         $b1 = ($ii & 7);
252
-                        $b2 = (ord($data[$nn + 1]) & 63);
253
-                        $b3 = (ord($data[$nn + 2]) & 63);
254
-                        $b4 = (ord($data[$nn + 3]) & 63);
255
-                        $ii = ((((($b1 * 64) + $b2) * 64) + $b3) * 64) + $b4;
252
+                        $b2 = (ord($data[$nn+1]) & 63);
253
+                        $b3 = (ord($data[$nn+2]) & 63);
254
+                        $b4 = (ord($data[$nn+3]) & 63);
255
+                        $ii = ((((($b1 * 64)+$b2) * 64)+$b3) * 64)+$b4;
256 256
                         $escapedData .= sprintf('&#%d;', $ii);
257 257
                         $nn += 3;
258 258
                     }
@@ -305,14 +305,14 @@  discard block
 block discarded – undo
305 305
                     // If src is UTF8, we run htmlspecialchars before converting to the target charset, as
306 306
                     // htmlspecialchars has limited charset support, but it groks utf8
307 307
                     if ($srcEncoding === 'UTF-8') {
308
-                        $data = htmlspecialchars($data,  defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
308
+                        $data = htmlspecialchars($data, defined('ENT_XML1') ? ENT_XML1 | ENT_QUOTES : ENT_QUOTES, 'UTF-8');
309 309
                     }
310 310
                     if ($srcEncoding !== $destEncoding) {
311 311
                         $data = mb_convert_encoding($data, str_replace('US-ASCII', 'ASCII', $destEncoding), str_replace('US-ASCII', 'ASCII', $srcEncoding));
312 312
                     }
313 313
                     if ($data === false) {
314 314
                         $escapedData = '';
315
-                        $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
315
+                        $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding via mbstring: failed...");
316 316
                     } else {
317 317
                         if ($srcEncoding === 'UTF-8') {
318 318
                             $escapedData = $data;
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
                     }
323 323
                 } else {
324 324
                     $escapedData = '';
325
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": Converting from $srcEncoding to $destEncoding: not supported...");
325
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": Converting from $srcEncoding to $destEncoding: not supported...");
326 326
                 }
327 327
         }
328 328
 
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
         if (function_exists('mb_list_encodings')) {
341 341
             $knownCharsets = array_unique(array_merge($knownCharsets, array_diff(mb_list_encodings(), array(
342 342
                 'pass', 'auto', 'wchar', 'BASE64', 'UUENCODE', 'ASCII', 'HTML-ENTITIES', 'Quoted-Printable',
343
-                '7bit','8bit', 'byte2be', 'byte2le', 'byte4be', 'byte4le'
343
+                '7bit', '8bit', 'byte2be', 'byte2le', 'byte4be', 'byte4le'
344 344
             ))));
345 345
         }
346 346
         return $knownCharsets;
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
             case 'iso88591':
395 395
                 return $this->xml_iso88591_Entities;
396 396
             default:
397
-                throw new \Exception('Unsupported charset: ' . $charset);
397
+                throw new \Exception('Unsupported charset: '.$charset);
398 398
         }
399 399
     }
400 400
 }
Please login to merge, or discard this patch.
src/Client.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -951,9 +951,9 @@
 block discarded – undo
951 951
     }
952 952
 
953 953
     protected function prepareCurlHandle($req, $server, $port, $timeout = 0, $username = '', $password = '',
954
-         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
955
-         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https', $keepAlive = false, $key = '',
956
-         $keyPass = '', $sslVersion = 0)
954
+            $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
955
+            $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'https', $keepAlive = false, $key = '',
956
+            $keyPass = '', $sslVersion = 0)
957 957
     {
958 958
         if ($port == 0) {
959 959
             if (in_array($method, array('http', 'http10', 'http11', 'h2c'))) {
Please login to merge, or discard this patch.
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -190,10 +190,10 @@  discard block
 block discarded – undo
190 190
             $server = $parts['host'];
191 191
             $path = isset($parts['path']) ? $parts['path'] : '';
192 192
             if (isset($parts['query'])) {
193
-                $path .= '?' . $parts['query'];
193
+                $path .= '?'.$parts['query'];
194 194
             }
195 195
             if (isset($parts['fragment'])) {
196
-                $path .= '#' . $parts['fragment'];
196
+                $path .= '#'.$parts['fragment'];
197 197
             }
198 198
             if (isset($parts['port'])) {
199 199
                 $port = $parts['port'];
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
             }
210 210
         }
211 211
         if ($path == '' || $path[0] != '/') {
212
-            $this->path = '/' . $path;
212
+            $this->path = '/'.$path;
213 213
         } else {
214 214
             $this->path = $path;
215 215
         }
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
         //$this->accepted_charset_encodings = $ch->knownCharsets();
242 242
 
243 243
         // initialize user_agent string
244
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
244
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
245 245
     }
246 246
 
247 247
     /**
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
      */
666 666
     protected function sendPayloadHTTP10($req, $server, $port, $timeout = 0, $username = '', $password = '',
667 667
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
668
-        $method='http')
668
+        $method = 'http')
669 669
     {
670 670
         //trigger_error('Method ' . __METHOD__ . ' is deprecated', E_USER_DEPRECATED);
671 671
 
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
      * @param int $sslVersion
699 699
      * @return Response
700 700
      */
701
-    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '',  $password = '',
701
+    protected function sendPayloadHTTPS($req, $server, $port, $timeout = 0, $username = '', $password = '',
702 702
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
703 703
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
704 704
         $sslVersion = 0)
@@ -737,7 +737,7 @@  discard block
 block discarded – undo
737 737
      */
738 738
     protected function sendPayloadSocket($req, $server, $port, $timeout = 0, $username = '', $password = '',
739 739
         $authType = 1, $cert = '', $certPass = '', $caCert = '', $caCertDir = '', $proxyHost = '', $proxyPort = 0,
740
-        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method='http', $key = '', $keyPass = '',
740
+        $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $method = 'http', $key = '', $keyPass = '',
741 741
         $sslVersion = 0)
742 742
     {
743 743
         /// @todo log a warning if passed an unsupported method
@@ -774,16 +774,16 @@  discard block
 block discarded – undo
774 774
         // thanks to Grant Rauscher <[email protected]> for this
775 775
         $credentials = '';
776 776
         if ($username != '') {
777
-            $credentials = 'Authorization: Basic ' . base64_encode($username . ':' . $password) . "\r\n";
777
+            $credentials = 'Authorization: Basic '.base64_encode($username.':'.$password)."\r\n";
778 778
             if ($authType != 1) {
779 779
                 /// @todo make this a proper error, i.e. return a failure
780
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
780
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
781 781
             }
782 782
         }
783 783
 
784 784
         $acceptedEncoding = '';
785 785
         if (is_array($this->accepted_compression) && count($this->accepted_compression)) {
786
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $this->accepted_compression) . "\r\n";
786
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $this->accepted_compression)."\r\n";
787 787
         }
788 788
 
789 789
         $proxyCredentials = '';
@@ -795,13 +795,13 @@  discard block
 block discarded – undo
795 795
             $connectPort = $proxyPort;
796 796
             $transport = 'tcp';
797 797
             /// @todo check: should we not use https in some cases?
798
-            $uri = 'http://' . $server . ':' . $port . $this->path;
798
+            $uri = 'http://'.$server.':'.$port.$this->path;
799 799
             if ($proxyUsername != '') {
800 800
                 if ($proxyAuthType != 1) {
801 801
                     /// @todo make this a proper error, i.e. return a failure
802
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
802
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
803 803
                 }
804
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($proxyUsername . ':' . $proxyPassword) . "\r\n";
804
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($proxyUsername.':'.$proxyPassword)."\r\n";
805 805
             }
806 806
         } else {
807 807
             $connectServer = $server;
@@ -816,45 +816,45 @@  discard block
 block discarded – undo
816 816
             $version = '';
817 817
             foreach ($this->cookies as $name => $cookie) {
818 818
                 if ($cookie['version']) {
819
-                    $version = ' $Version="' . $cookie['version'] . '";';
820
-                    $cookieHeader .= ' ' . $name . '="' . $cookie['value'] . '";';
819
+                    $version = ' $Version="'.$cookie['version'].'";';
820
+                    $cookieHeader .= ' '.$name.'="'.$cookie['value'].'";';
821 821
                     if ($cookie['path']) {
822
-                        $cookieHeader .= ' $Path="' . $cookie['path'] . '";';
822
+                        $cookieHeader .= ' $Path="'.$cookie['path'].'";';
823 823
                     }
824 824
                     if ($cookie['domain']) {
825
-                        $cookieHeader .= ' $Domain="' . $cookie['domain'] . '";';
825
+                        $cookieHeader .= ' $Domain="'.$cookie['domain'].'";';
826 826
                     }
827 827
                     if ($cookie['port']) {
828
-                        $cookieHeader .= ' $Port="' . $cookie['port'] . '";';
828
+                        $cookieHeader .= ' $Port="'.$cookie['port'].'";';
829 829
                     }
830 830
                 } else {
831
-                    $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
831
+                    $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
832 832
                 }
833 833
             }
834
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
834
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
835 835
         }
836 836
 
837 837
         // omit port if default
838 838
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
839
-            $port =  '';
839
+            $port = '';
840 840
         } else {
841
-            $port = ':' . $port;
841
+            $port = ':'.$port;
842 842
         }
843 843
 
844
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
845
-            'User-Agent: ' . $this->user_agent . "\r\n" .
846
-            'Host: ' . $server . $port . "\r\n" .
847
-            $credentials .
848
-            $proxyCredentials .
849
-            $acceptedEncoding .
850
-            $encodingHdr .
851
-            'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings) . "\r\n" .
852
-            $cookieHeader .
853
-            'Content-Type: ' . $req->content_type . "\r\nContent-Length: " .
854
-            strlen($payload) . "\r\n\r\n" .
844
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
845
+            'User-Agent: '.$this->user_agent."\r\n".
846
+            'Host: '.$server.$port."\r\n".
847
+            $credentials.
848
+            $proxyCredentials.
849
+            $acceptedEncoding.
850
+            $encodingHdr.
851
+            'Accept-Charset: '.implode(',', $this->accepted_charset_encodings)."\r\n".
852
+            $cookieHeader.
853
+            'Content-Type: '.$req->content_type."\r\nContent-Length: ".
854
+            strlen($payload)."\r\n\r\n".
855 855
             $payload;
856 856
 
857
-        if ($this->debug > 1) {
857
+        if ($this->debug>1) {
858 858
             $this->getLogger()->debugMessage("---SENDING---\n$op\n---END---");
859 859
         }
860 860
 
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
 
882 882
         $context = stream_context_create($contextOptions);
883 883
 
884
-        if ($timeout <= 0) {
884
+        if ($timeout<=0) {
885 885
             $connectTimeout = ini_get('default_socket_timeout');
886 886
         } else {
887 887
             $connectTimeout = $timeout;
@@ -893,7 +893,7 @@  discard block
 block discarded – undo
893 893
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
894 894
             STREAM_CLIENT_CONNECT, $context);
895 895
         if ($fp) {
896
-            if ($timeout > 0) {
896
+            if ($timeout>0) {
897 897
                 stream_set_timeout($fp, $timeout, 0);
898 898
             }
899 899
         } else {
@@ -902,8 +902,8 @@  discard block
 block discarded – undo
902 902
                 $this->errstr = $err['message'];
903 903
             }
904 904
 
905
-            $this->errstr = 'Connect error: ' . $this->errstr;
906
-            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
905
+            $this->errstr = 'Connect error: '.$this->errstr;
906
+            $r = new Response(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
907 907
 
908 908
             return $r;
909 909
         }
@@ -991,18 +991,18 @@  discard block
 block discarded – undo
991 991
             $keyPass, $sslVersion);
992 992
 
993 993
         if (!$curl) {
994
-            return new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': error during curl initialization. Check php error log for details');
994
+            return new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': error during curl initialization. Check php error log for details');
995 995
         }
996 996
 
997 997
         $result = curl_exec($curl);
998 998
 
999
-        if ($this->debug > 1) {
999
+        if ($this->debug>1) {
1000 1000
             $message = "---CURL INFO---\n";
1001 1001
             foreach (curl_getinfo($curl) as $name => $val) {
1002 1002
                 if (is_array($val)) {
1003 1003
                     $val = implode("\n", $val);
1004 1004
                 }
1005
-                $message .= $name . ': ' . $val . "\n";
1005
+                $message .= $name.': '.$val."\n";
1006 1006
             }
1007 1007
             $message .= '---END---';
1008 1008
             $this->getLogger()->debugMessage($message);
@@ -1012,7 +1012,7 @@  discard block
 block discarded – undo
1012 1012
             /// @todo we should use a better check here - what if we get back '' or '0'?
1013 1013
 
1014 1014
             $this->errstr = 'no response';
1015
-            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . curl_error($curl));
1015
+            $resp = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.curl_error($curl));
1016 1016
             curl_close($curl);
1017 1017
             if ($keepAlive) {
1018 1018
                 $this->xmlrpc_curl_handle = null;
@@ -1082,12 +1082,12 @@  discard block
 block discarded – undo
1082 1082
                     // http, https
1083 1083
                     $protocol = $method;
1084 1084
                     if (strpos($protocol, ':') !== false) {
1085
-                        $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1085
+                        $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1086 1086
                         return false;
1087 1087
                     }
1088 1088
                 }
1089 1089
             }
1090
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $this->path);
1090
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$this->path);
1091 1091
             if (!$curl) {
1092 1092
                 return false;
1093 1093
             }
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
         // results into variable
1102 1102
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1103 1103
 
1104
-        if ($this->debug > 1) {
1104
+        if ($this->debug>1) {
1105 1105
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1106 1106
             /// @todo allow callers to redirect curlopt_stderr to some stream which can be buffered
1107 1107
         }
@@ -1126,7 +1126,7 @@  discard block
 block discarded – undo
1126 1126
             }
1127 1127
         }
1128 1128
         // extra headers
1129
-        $headers = array('Content-Type: ' . $req->content_type, 'Accept-Charset: ' . implode(',', $this->accepted_charset_encodings));
1129
+        $headers = array('Content-Type: '.$req->content_type, 'Accept-Charset: '.implode(',', $this->accepted_charset_encodings));
1130 1130
         // if no keepalive is wanted, let the server know it in advance
1131 1131
         if (!$keepAlive) {
1132 1132
             $headers[] = 'Connection: close';
@@ -1143,7 +1143,7 @@  discard block
 block discarded – undo
1143 1143
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
1144 1144
         // timeout is borked
1145 1145
         if ($timeout) {
1146
-            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout - 1);
1146
+            curl_setopt($curl, CURLOPT_TIMEOUT, $timeout == 1 ? 1 : $timeout-1);
1147 1147
         }
1148 1148
 
1149 1149
         switch ($method) {
@@ -1158,7 +1158,7 @@  discard block
 block discarded – undo
1158 1158
                     curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE);
1159 1159
                 } else {
1160 1160
                     /// @todo make this a proper error, i.e. return a failure
1161
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install');
1161
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install');
1162 1162
                 }
1163 1163
                 break;
1164 1164
             case 'h2':
@@ -1167,12 +1167,12 @@  discard block
 block discarded – undo
1167 1167
         }
1168 1168
 
1169 1169
         if ($username && $password) {
1170
-            curl_setopt($curl, CURLOPT_USERPWD, $username . ':' . $password);
1170
+            curl_setopt($curl, CURLOPT_USERPWD, $username.':'.$password);
1171 1171
             if (defined('CURLOPT_HTTPAUTH')) {
1172 1172
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $authType);
1173 1173
             } elseif ($authType != 1) {
1174 1174
                 /// @todo make this a proper error, i.e. return a failure
1175
-                $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1175
+                $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1176 1176
             }
1177 1177
         }
1178 1178
 
@@ -1215,14 +1215,14 @@  discard block
 block discarded – undo
1215 1215
             if ($proxyPort == 0) {
1216 1216
                 $proxyPort = 8080; // NB: even for HTTPS, local connection is on port 8080
1217 1217
             }
1218
-            curl_setopt($curl, CURLOPT_PROXY, $proxyHost . ':' . $proxyPort);
1218
+            curl_setopt($curl, CURLOPT_PROXY, $proxyHost.':'.$proxyPort);
1219 1219
             if ($proxyUsername) {
1220
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername . ':' . $proxyPassword);
1220
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $proxyUsername.':'.$proxyPassword);
1221 1221
                 if (defined('CURLOPT_PROXYAUTH')) {
1222 1222
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $proxyAuthType);
1223 1223
                 } elseif ($proxyAuthType != 1) {
1224 1224
                     /// @todo make this a proper error, i.e. return a failure
1225
-                    $this->getLogger()->errorLog('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1225
+                    $this->getLogger()->errorLog('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1226 1226
                 }
1227 1227
             }
1228 1228
         }
@@ -1232,7 +1232,7 @@  discard block
 block discarded – undo
1232 1232
         if (count($this->cookies)) {
1233 1233
             $cookieHeader = '';
1234 1234
             foreach ($this->cookies as $name => $cookie) {
1235
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1235
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1236 1236
             }
1237 1237
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1238 1238
         }
@@ -1241,7 +1241,7 @@  discard block
 block discarded – undo
1241 1241
             curl_setopt($curl, $opt, $val);
1242 1242
         }
1243 1243
 
1244
-        if ($this->debug > 1) {
1244
+        if ($this->debug>1) {
1245 1245
             $this->getLogger()->debugMessage("---SENDING---\n$payload\n---END---");
1246 1246
         }
1247 1247
 
@@ -1332,7 +1332,7 @@  discard block
 block discarded – undo
1332 1332
             $call['methodName'] = new Value($req->method(), 'string');
1333 1333
             $numParams = $req->getNumParams();
1334 1334
             $params = array();
1335
-            for ($i = 0; $i < $numParams; $i++) {
1335
+            for ($i = 0; $i<$numParams; $i++) {
1336 1336
                 $params[$i] = $req->getParam($i);
1337 1337
             }
1338 1338
             $call['params'] = new Value($params, 'array');
@@ -1354,7 +1354,7 @@  discard block
 block discarded – undo
1354 1354
         $response = array();
1355 1355
 
1356 1356
         if ($this->return_type == 'xml') {
1357
-            for ($i = 0; $i < count($reqs); $i++) {
1357
+            for ($i = 0; $i<count($reqs); $i++) {
1358 1358
                 $response[] = new Response($rets, 0, '', 'xml', $result->httpResponse());
1359 1359
             }
1360 1360
 
@@ -1362,21 +1362,21 @@  discard block
 block discarded – undo
1362 1362
             if (!is_array($rets)) {
1363 1363
                 // bad return type from system.multicall
1364 1364
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1365
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse());
1365
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse());
1366 1366
             }
1367 1367
             $numRets = count($rets);
1368 1368
             if ($numRets != count($reqs)) {
1369 1369
                 // wrong number of return values.
1370 1370
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1371
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals',
1371
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals',
1372 1372
                     $result->httpResponse());
1373 1373
             }
1374 1374
 
1375
-            for ($i = 0; $i < $numRets; $i++) {
1375
+            for ($i = 0; $i<$numRets; $i++) {
1376 1376
                 $val = $rets[$i];
1377 1377
                 if (!is_array($val)) {
1378 1378
                     return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1379
-                        PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1379
+                        PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1380 1380
                         'phpvals', $result->httpResponse());
1381 1381
                 }
1382 1382
                 switch (count($val)) {
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
                         if (!isset($val[0])) {
1385 1385
                             // Bad value
1386 1386
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1387
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value",
1387
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value",
1388 1388
                                 'phpvals', $result->httpResponse());
1389 1389
                         }
1390 1390
                         // Normal return value
@@ -1396,20 +1396,20 @@  discard block
 block discarded – undo
1396 1396
                         if (!is_int($code)) {
1397 1397
                             /// @todo should we check that it is != 0?
1398 1398
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1399
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1399
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1400 1400
                                 'phpvals', $result->httpResponse());
1401 1401
                         }
1402 1402
                         $str = @$val['faultString'];
1403 1403
                         if (!is_string($str)) {
1404 1404
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1405
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString",
1405
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString",
1406 1406
                                 'phpvals', $result->httpResponse());
1407 1407
                         }
1408 1408
                         $response[$i] = new Response(0, $code, $str, 'phpvals', $result->httpResponse());
1409 1409
                         break;
1410 1410
                     default:
1411 1411
                         return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1412
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1412
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1413 1413
                             'phpvals', $result->httpResponse());
1414 1414
                 }
1415 1415
             }
@@ -1418,14 +1418,14 @@  discard block
 block discarded – undo
1418 1418
             // return type == 'xmlrpcvals'
1419 1419
             if ($rets->kindOf() != 'array') {
1420 1420
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1421
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals',
1421
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals',
1422 1422
                     $result->httpResponse());
1423 1423
             }
1424 1424
             $numRets = $rets->count();
1425 1425
             if ($numRets != count($reqs)) {
1426 1426
                 // wrong number of return values.
1427 1427
                 return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1428
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals',
1428
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals',
1429 1429
                     $result->httpResponse());
1430 1430
             }
1431 1431
 
@@ -1434,7 +1434,7 @@  discard block
 block discarded – undo
1434 1434
                     case 'array':
1435 1435
                         if ($val->count() != 1) {
1436 1436
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1437
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1437
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1438 1438
                                 'phpvals', $result->httpResponse());
1439 1439
                         }
1440 1440
                         // Normal return value
@@ -1443,28 +1443,28 @@  discard block
 block discarded – undo
1443 1443
                     case 'struct':
1444 1444
                         if ($val->count() != 2) {
1445 1445
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1446
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1446
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1447 1447
                                 'phpvals', $result->httpResponse());
1448 1448
                         }
1449 1449
                         /** @var Value $code */
1450 1450
                         $code = $val['faultCode'];
1451 1451
                         if ($code->kindOf() != 'scalar' || $code->scalartyp() != 'int') {
1452 1452
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1453
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1453
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1454 1454
                                 'xmlrpcvals', $result->httpResponse());
1455 1455
                         }
1456 1456
                         /** @var Value $str */
1457 1457
                         $str = $val['faultString'];
1458 1458
                         if ($str->kindOf() != 'scalar' || $str->scalartyp() != 'string') {
1459 1459
                             return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1460
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1460
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1461 1461
                                 'xmlrpcvals', $result->httpResponse());
1462 1462
                         }
1463 1463
                         $response[] = new Response(0, $code->scalarval(), $str->scalarval(), 'xmlrpcvals', $result->httpResponse());
1464 1464
                         break;
1465 1465
                     default:
1466 1466
                         return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1467
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1467
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1468 1468
                             'xmlrpcvals', $result->httpResponse());
1469 1469
                 }
1470 1470
             }
Please login to merge, or discard this patch.
extras/benchmark.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -19,9 +19,9 @@  discard block
 block discarded – undo
19 19
 use PhpXmlRpc\Encoder;
20 20
 
21 21
 /// @todo allow autoloading when the library is installed as dependency
22
-include_once __DIR__ . '/../vendor/autoload.php';
22
+include_once __DIR__.'/../vendor/autoload.php';
23 23
 
24
-include __DIR__ . '/../tests/parse_args.php';
24
+include __DIR__.'/../tests/parse_args.php';
25 25
 $args = argParser::getArgs();
26 26
 
27 27
 function begin_test($test_name, $test_case)
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     if (!isset($test_results[$test_name][$test_case])) {
42 42
         trigger_error('ending test that was not started');
43 43
     }
44
-    $test_results[$test_name][$test_case]['time'] = $end - $test_results[$test_name][$test_case]['time'];
44
+    $test_results[$test_name][$test_case]['time'] = $end-$test_results[$test_name][$test_case]['time'];
45 45
     $test_results[$test_name][$test_case]['result'] = $test_result;
46 46
     echo '.';
47 47
     flush();
@@ -75,24 +75,24 @@  discard block
 block discarded – undo
75 75
 }
76 76
 
77 77
 if ($is_web) {
78
-    echo "<h3>Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "</h3>\n";
78
+    echo "<h3>Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."</h3>\n";
79 79
     if ($xd) {
80
-        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: " . htmlspecialchars(xdebug_get_profiler_filename()) . "</h4>\n";
80
+        echo "<h4>XDEBUG profiling enabled: skipping remote tests. Trace file is: ".htmlspecialchars(xdebug_get_profiler_filename())."</h4>\n";
81 81
     }
82 82
     flush();
83 83
     ob_flush();
84 84
 } else {
85
-    echo "Using lib version: " . PhpXmlRpc::$xmlrpcVersion . " on PHP version: " . phpversion() . "\n";
85
+    echo "Using lib version: ".PhpXmlRpc::$xmlrpcVersion." on PHP version: ".phpversion()."\n";
86 86
     if ($xd) {
87
-        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: " . xdebug_get_profiler_filename() . "\n";
87
+        echo "XDEBUG profiling enabled: skipping remote tests\nTrace file is: ".xdebug_get_profiler_filename()."\n";
88 88
     }
89 89
 }
90 90
 
91 91
 // test 'manual style' data encoding vs. 'automatic style' encoding
92 92
 begin_test('Data encoding (large array)', 'manual encoding');
93
-for ($i = 0; $i < $num_tests; $i++) {
93
+for ($i = 0; $i<$num_tests; $i++) {
94 94
     $vals = array();
95
-    for ($j = 0; $j < 10; $j++) {
95
+    for ($j = 0; $j<10; $j++) {
96 96
         $valarray = array();
97 97
         foreach ($data[$j] as $key => $val) {
98 98
             $values = array();
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
 begin_test('Data encoding (large array)', 'automatic encoding');
119 119
 $encoder = new Encoder();
120
-for ($i = 0; $i < $num_tests; $i++) {
120
+for ($i = 0; $i<$num_tests; $i++) {
121 121
     $value = $encoder->encode($data, array('auto_dates'));
122 122
     $out = $value->serialize();
123 123
 }
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 
126 126
 if (function_exists('xmlrpc_set_type')) {
127 127
     begin_test('Data encoding (large array)', 'xmlrpc-epi encoding');
128
-    for ($i = 0; $i < $num_tests; $i++) {
129
-        for ($j = 0; $j < 10; $j++) {
128
+    for ($i = 0; $i<$num_tests; $i++) {
129
+        for ($j = 0; $j<10; $j++) {
130 130
             foreach ($keys as $k) {
131 131
                 xmlrpc_set_type($data[$j][$k][4], 'datetime');
132 132
                 xmlrpc_set_type($data[$j][$k][8], 'datetime');
@@ -140,18 +140,18 @@  discard block
 block discarded – undo
140 140
 // test 'old style' data decoding vs. 'automatic style' decoding
141 141
 $dummy = new Request('');
142 142
 $out = new Response($value);
143
-$in = '<?xml version="1.0" ?>' . "\n" . $out->serialize();
143
+$in = '<?xml version="1.0" ?>'."\n".$out->serialize();
144 144
 
145 145
 begin_test('Data decoding (large array)', 'manual decoding');
146
-for ($i = 0; $i < $num_tests; $i++) {
146
+for ($i = 0; $i<$num_tests; $i++) {
147 147
     $response = $dummy->ParseResponse($in, true);
148 148
     $value = $response->value();
149 149
     $result = array();
150
-    foreach($value as $val1) {
150
+    foreach ($value as $val1) {
151 151
         $out = array();
152
-        foreach($val1 as $name => $val) {
152
+        foreach ($val1 as $name => $val) {
153 153
             $out[$name] = array();
154
-            foreach($val as $data) {
154
+            foreach ($val as $data) {
155 155
                 $out[$name][] = $data->scalarval();
156 156
             }
157 157
         }
@@ -161,18 +161,18 @@  discard block
 block discarded – undo
161 161
 end_test('Data decoding (large array)', 'manual decoding', $result);
162 162
 
163 163
 begin_test('Data decoding (large array)', 'manual decoding deprecated');
164
-for ($i = 0; $i < $num_tests; $i++) {
164
+for ($i = 0; $i<$num_tests; $i++) {
165 165
     $response = $dummy->ParseResponse($in, true);
166 166
     $value = $response->value();
167 167
     $result = array();
168 168
     $l = $value->arraysize();
169
-    for ($k = 0; $k < $l; $k++) {
169
+    for ($k = 0; $k<$l; $k++) {
170 170
         $val1 = $value->arraymem($k);
171 171
         $out = array();
172
-        foreach($val1 as $name => $val) {
172
+        foreach ($val1 as $name => $val) {
173 173
             $out[$name] = array();
174 174
             $m = $val->arraysize();
175
-            for ($j = 0; $j < $m; $j++) {
175
+            for ($j = 0; $j<$m; $j++) {
176 176
                 $data = $val->arraymem($j);
177 177
                 $out[$name][] = $data->scalarval();
178 178
             }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 end_test('Data decoding (large array)', 'manual decoding deprecated', $result);
184 184
 
185 185
 begin_test('Data decoding (large array)', 'automatic decoding');
186
-for ($i = 0; $i < $num_tests; $i++) {
186
+for ($i = 0; $i<$num_tests; $i++) {
187 187
     $response = $dummy->ParseResponse($in, true, 'phpvals');
188 188
     $value = $response->value();
189 189
 }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 
192 192
 if (function_exists('xmlrpc_decode')) {
193 193
     begin_test('Data decoding (large array)', 'xmlrpc-epi decoding');
194
-    for ($i = 0; $i < $num_tests; $i++) {
194
+    for ($i = 0; $i<$num_tests; $i++) {
195 195
         $response = $dummy->ParseResponse($in, true, 'xml');
196 196
         $value = xmlrpc_decode($response->value());
197 197
     }
@@ -208,16 +208,16 @@  discard block
 block discarded – undo
208 208
     $value = $encoder->encode($data1, array('auto_dates'));
209 209
     $req = new Request('interopEchoTests.echoValue', array($value));
210 210
     $reqs = array();
211
-    for ($i = 0; $i < $num_tests; $i++) {
211
+    for ($i = 0; $i<$num_tests; $i++) {
212 212
         $reqs[] = $req;
213 213
     }
214 214
 
215 215
     $server = explode(':', $args['HTTPSERVER']);
216
-    if (count($server) > 1) {
217
-        $srv = 'http://' . $server[0] . '://' . $server[1] . $args['HTTPURI'];
216
+    if (count($server)>1) {
217
+        $srv = 'http://'.$server[0].'://'.$server[1].$args['HTTPURI'];
218 218
         $c = new Client($args['HTTPURI'], $server[0], $server[1]);
219 219
     } else {
220
-        $srv = 'http://' . $args['HTTPSERVER'] . $args['HTTPURI'];
220
+        $srv = 'http://'.$args['HTTPSERVER'].$args['HTTPURI'];
221 221
         $c = new Client($args['HTTPURI'], $args['HTTPSERVER']);
222 222
     }
223 223
 
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
 
230 230
     begin_test($testName, 'http 10');
231 231
     $response = array();
232
-    for ($i = 0; $i < $num_tests; $i++) {
232
+    for ($i = 0; $i<$num_tests; $i++) {
233 233
         $resp = $c->send($req);
234 234
         $response[] = $resp->value();
235 235
     }
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
         $c->keepalive = false;
240 240
         begin_test($testName, 'http 11 no keepalive');
241 241
         $response = array();
242
-        for ($i = 0; $i < $num_tests; $i++) {
242
+        for ($i = 0; $i<$num_tests; $i++) {
243 243
             $resp = $c->send($req, 10, 'http11');
244 244
             $response[] = $resp->value();
245 245
         }
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 
248 248
         begin_test($testName, 'http 11 w. keep-alive');
249 249
         $response = array();
250
-        for ($i = 0; $i < $num_tests; $i++) {
250
+        for ($i = 0; $i<$num_tests; $i++) {
251 251
             $resp = $c->send($req, 10, 'http11');
252 252
             $response[] = $resp->value();
253 253
         }
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 
270 270
         begin_test($testName, 'http 10 w. compression');
271 271
         $response = array();
272
-        for ($i = 0; $i < $num_tests; $i++) {
272
+        for ($i = 0; $i<$num_tests; $i++) {
273 273
             $resp = $c->send($req);
274 274
             $response[] = $resp->value();
275 275
         }
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
             $c->keepalive = false;
280 280
             begin_test($testName, 'http 11 w. compression and no keepalive');
281 281
             $response = array();
282
-            for ($i = 0; $i < $num_tests; $i++) {
282
+            for ($i = 0; $i<$num_tests; $i++) {
283 283
                 $resp = $c->send($req, 10, 'http11');
284 284
                 $response[] = $resp->value();
285 285
             }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
             $c->keepalive = true;
289 289
             begin_test($testName, 'http 11 w. keep-alive and compression');
290 290
             $response = array();
291
-            for ($i = 0; $i < $num_tests; $i++) {
291
+            for ($i = 0; $i<$num_tests; $i++) {
292 292
                 $resp = $c->send($req, 10, 'http11');
293 293
                 $response[] = $resp->value();
294 294
             }
@@ -309,11 +309,11 @@  discard block
 block discarded – undo
309 309
         /// test multicall vs. many calls vs. keep-alives - HTTPS
310 310
 
311 311
         $server = explode(':', $args['HTTPSSERVER']);
312
-        if (count($server) > 1) {
313
-            $srv = 'https://' . $server[0] . ':' . $server[1] . $args['HTTPSURI'];
312
+        if (count($server)>1) {
313
+            $srv = 'https://'.$server[0].':'.$server[1].$args['HTTPSURI'];
314 314
             $c = new Client($args['HTTPSURI'], $server[0], $server[1], 'https');
315 315
         } else {
316
-            $srv = 'https://' . $args['HTTPSSERVER'] . $args['HTTPSURI'];
316
+            $srv = 'https://'.$args['HTTPSSERVER'].$args['HTTPSURI'];
317 317
             $c = new Client($args['HTTPSURI'], $args['HTTPSSERVER'], 443, 'https');
318 318
         }
319 319
         $c->setSSLVerifyPeer(!$args['HTTPSIGNOREPEER']);
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
         begin_test($testName, 'https no keep-alive');
328 328
         $c->keepalive = false;
329 329
         $response = array();
330
-        for ($i = 0; $i < $num_tests; $i++) {
330
+        for ($i = 0; $i<$num_tests; $i++) {
331 331
             $resp = $c->send($req);
332 332
             $response[] = $resp->value();
333 333
         }
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
         begin_test($testName, 'https w. keep-alive');
337 337
         $c->keepalive = true;
338 338
         $response = array();
339
-        for ($i = 0; $i < $num_tests; $i++) {
339
+        for ($i = 0; $i<$num_tests; $i++) {
340 340
             $resp = $c->send($req, 10);
341 341
             $response[] = $resp->value();
342 342
         }
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
             $c->keepalive = false;
358 358
             begin_test($testName, 'https w. compression and no keepalive');
359 359
             $response = array();
360
-            for ($i = 0; $i < $num_tests; $i++) {
360
+            for ($i = 0; $i<$num_tests; $i++) {
361 361
                 $resp = $c->send($req);
362 362
                 $response[] = $resp->value();
363 363
             }
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
             $c->keepalive = true;
367 367
             begin_test($testName, 'https w. keep-alive and compression');
368 368
             $response = array();
369
-            for ($i = 0; $i < $num_tests; $i++) {
369
+            for ($i = 0; $i<$num_tests; $i++) {
370 370
                 $resp = $c->send($req, 10);
371 371
                 $response[] = $resp->value();
372 372
             }
@@ -387,11 +387,11 @@  discard block
 block discarded – undo
387 387
         /// test multicall vs. many calls vs. keep-alives - HTTP/2
388 388
 
389 389
         $server = explode(':', $args['HTTPSSERVER']);
390
-        if (count($server) > 1) {
391
-            $srv = 'https://' . $server[0] . ':' . $server[1] . $args['HTTPSURI'];
390
+        if (count($server)>1) {
391
+            $srv = 'https://'.$server[0].':'.$server[1].$args['HTTPSURI'];
392 392
             $c = new Client($args['HTTPSURI'], $server[0], $server[1], 'https');
393 393
         } else {
394
-            $srv = 'https://' . $args['HTTPSSERVER'] . $args['HTTPSURI'];
394
+            $srv = 'https://'.$args['HTTPSSERVER'].$args['HTTPSURI'];
395 395
             $c = new Client($args['HTTPSURI'], $args['HTTPSSERVER'], 443, 'h2');
396 396
         }
397 397
         $c->setSSLVerifyPeer(!$args['HTTPSIGNOREPEER']);
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
         begin_test($testName, 'http2 no keep-alive');
406 406
         $c->keepalive = false;
407 407
         $response = array();
408
-        for ($i = 0; $i < $num_tests; $i++) {
408
+        for ($i = 0; $i<$num_tests; $i++) {
409 409
             $resp = $c->send($req);
410 410
             $response[] = $resp->value();
411 411
         }
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
         begin_test($testName, 'http2 w. keep-alive');
415 415
         $c->keepalive = true;
416 416
         $response = array();
417
-        for ($i = 0; $i < $num_tests; $i++) {
417
+        for ($i = 0; $i<$num_tests; $i++) {
418 418
             $resp = $c->send($req, 10);
419 419
             $response[] = $resp->value();
420 420
         }
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
             $c->keepalive = false;
436 436
             begin_test($testName, 'http2 w. compression and no keepalive');
437 437
             $response = array();
438
-            for ($i = 0; $i < $num_tests; $i++) {
438
+            for ($i = 0; $i<$num_tests; $i++) {
439 439
                 $resp = $c->send($req);
440 440
                 $response[] = $resp->value();
441 441
             }
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
             $c->keepalive = true;
445 445
             begin_test($testName, 'http2 w. keep-alive and compression');
446 446
             $response = array();
447
-            for ($i = 0; $i < $num_tests; $i++) {
447
+            for ($i = 0; $i<$num_tests; $i++) {
448 448
                 $resp = $c->send($req, 10);
449 449
                 $response[] = $resp->value();
450 450
             }
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
 foreach ($test_results as $test => $results) {
467 467
     echo "\nTEST: $test\n";
468 468
     foreach ($results as $case => $data) {
469
-        echo "  $case: {$data['time']} secs - Output data CRC: " . crc32(serialize($data['result'])) . "\n";
469
+        echo "  $case: {$data['time']} secs - Output data CRC: ".crc32(serialize($data['result']))."\n";
470 470
     }
471 471
 }
472 472
 
Please login to merge, or discard this patch.
tests/PolyfillTestCase.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,20 +2,20 @@
 block discarded – undo
2 2
 
3 3
 use PHPUnit\Runner\Version as PHPUnit_Version;
4 4
 
5
-if ( class_exists( 'PHPUnit_Extensions_SeleniumCommon_RemoteCoverage' ) === true
6
-    && class_exists( 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage' ) === false
5
+if (class_exists('PHPUnit_Extensions_SeleniumCommon_RemoteCoverage') === true
6
+    && class_exists('PHPUnit\Extensions\SeleniumCommon\RemoteCoverage') === false
7 7
 ) {
8
-    class_alias( 'PHPUnit_Extensions_SeleniumCommon_RemoteCoverage', 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage' );
8
+    class_alias('PHPUnit_Extensions_SeleniumCommon_RemoteCoverage', 'PHPUnit\Extensions\SeleniumCommon\RemoteCoverage');
9 9
 }
10 10
 
11
-if ( class_exists( 'PHPUnit_Runner_BaseTestRunner' ) === true
12
-    && class_exists( 'PHPUnit\Runner\BaseTestRunner' ) === false
11
+if (class_exists('PHPUnit_Runner_BaseTestRunner') === true
12
+    && class_exists('PHPUnit\Runner\BaseTestRunner') === false
13 13
 ) {
14
-    class_alias( 'PHPUnit_Runner_BaseTestRunner', 'PHPUnit\Runner\BaseTestRunner' );
14
+    class_alias('PHPUnit_Runner_BaseTestRunner', 'PHPUnit\Runner\BaseTestRunner');
15 15
 }
16 16
 
17 17
 if (class_exists('PHPUnit\Runner\Version') === false || version_compare(PHPUnit_Version::id(), '8.0.0', '<')) {
18
-    include_once __DIR__ . '/PolyfillTestCase7.php';
18
+    include_once __DIR__.'/PolyfillTestCase7.php';
19 19
 } else {
20
-    include_once __DIR__ . '/PolyfillTestCase8.php';
20
+    include_once __DIR__.'/PolyfillTestCase8.php';
21 21
 }
Please login to merge, or discard this patch.
lib/xmlrpcs.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function echoInput()
56 56
     {
57
-        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '" . file_get_contents('php://input'), 'string'));
57
+        $r = new PhpXmlRpc\Response(new PhpXmlRpc\Value("'Aha said I: '".file_get_contents('php://input'), 'string'));
58 58
         print $r->serialize();
59 59
     }
60 60
 
@@ -65,12 +65,12 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function __get($name)
67 67
     {
68
-        switch($name) {
68
+        switch ($name) {
69 69
             case 'dmap':
70 70
                 return $this->dmap;
71 71
             default:
72 72
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
73
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' .
73
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.
74 74
                     $trace[0]['line'], E_USER_NOTICE);
75 75
                 return null;
76 76
         }
@@ -97,30 +97,30 @@  discard block
 block discarded – undo
97 97
     Server::xmlrpc_debugmsg($m);
98 98
 }
99 99
 
100
-function _xmlrpcs_getCapabilities($server, $m=null)
100
+function _xmlrpcs_getCapabilities($server, $m = null)
101 101
 {
102 102
     return Server::_xmlrpcs_getCapabilities($server, $m);
103 103
 }
104 104
 
105
-$_xmlrpcs_listMethods_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
-$_xmlrpcs_listMethods_doc='This method lists all the methods that the XML-RPC server knows how to dispatch';
107
-$_xmlrpcs_listMethods_sdoc=array(array('list of method names'));
108
-function _xmlrpcs_listMethods($server, $m=null) // if called in plain php values mode, second param is missing
105
+$_xmlrpcs_listMethods_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray));
106
+$_xmlrpcs_listMethods_doc = 'This method lists all the methods that the XML-RPC server knows how to dispatch';
107
+$_xmlrpcs_listMethods_sdoc = array(array('list of method names'));
108
+function _xmlrpcs_listMethods($server, $m = null) // if called in plain php values mode, second param is missing
109 109
 {
110 110
     return Server::_xmlrpcs_listMethods($server, $m);
111 111
 }
112 112
 
113
-$_xmlrpcs_methodSignature_sig=array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
-$_xmlrpcs_methodSignature_doc='Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
-$_xmlrpcs_methodSignature_sdoc=array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
113
+$_xmlrpcs_methodSignature_sig = array(array(\PhpXmlRpc\Value::$xmlrpcArray, $GLOBALS['xmlrpcString']));
114
+$_xmlrpcs_methodSignature_doc = 'Returns an array of known signatures (an array of arrays) for the method name passed. If no signatures are known, returns a none-array (test for type != array to detect missing signature)';
115
+$_xmlrpcs_methodSignature_sdoc = array(array('list of known signatures, each sig being an array of xmlrpc type names', 'name of method to be described'));
116 116
 function _xmlrpcs_methodSignature($server, $m)
117 117
 {
118 118
     return Server::_xmlrpcs_methodSignature($server, $m);
119 119
 }
120 120
 
121
-$_xmlrpcs_methodHelp_sig=array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
-$_xmlrpcs_methodHelp_doc='Returns help text if defined for the method passed, otherwise returns an empty string';
123
-$_xmlrpcs_methodHelp_sdoc=array(array('method description', 'name of the method to be described'));
121
+$_xmlrpcs_methodHelp_sig = array(array($GLOBALS['xmlrpcString'], $GLOBALS['xmlrpcString']));
122
+$_xmlrpcs_methodHelp_doc = 'Returns help text if defined for the method passed, otherwise returns an empty string';
123
+$_xmlrpcs_methodHelp_sdoc = array(array('method description', 'name of the method to be described'));
124 124
 function _xmlrpcs_methodHelp($server, $m)
125 125
 {
126 126
     return Server::_xmlrpcs_methodHelp($server, $m);
Please login to merge, or discard this patch.
tests/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777);
16 16
     }
17 17
 
18
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
18
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
19 19
 }
20 20
 
21 21
 $targetFile = null;
@@ -38,5 +38,5 @@  discard block
 block discarded – undo
38 38
 }
39 39
 
40 40
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
41
-    include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
41
+    include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
42 42
 }
Please login to merge, or discard this patch.