Passed
Push — master ( 6869ac...1a762a )
by Gaetano
07:15
created
tests/5ServerTest.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpc_wrappers.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/PolyfillTestCase.php';
8
+include_once __DIR__.'/PolyfillTestCase.php';
9 9
 
10 10
 use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage;
11 11
 use PHPUnit\Framework\TestResult;
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         // (but only if not called from subclass objects / multitests)
43 43
         if (function_exists('debug_backtrace') && strtolower(get_called_class()) == 'localhosttests') {
44 44
             $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
45
-            for ($i = 0; $i < count($trace); $i++) {
45
+            for ($i = 0; $i<count($trace); $i++) {
46 46
                 if (strpos($trace[$i]['function'], 'test') === 0) {
47 47
                     self::$failed_tests[$trace[$i]['function']] = true;
48 48
                     break;
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function _run($result = NULL)
67 67
     {
68
-        $this->testId = get_class($this) . '__' . $this->getName();
68
+        $this->testId = get_class($this).'__'.$this->getName();
69 69
 
70 70
         if ($result === NULL) {
71 71
             $result = $this->createResult();
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 
98 98
         $uri = str_replace('/demo/server/server.php', '/tests/index.php?demo=server/server.php', $this->args['HTTPURI']);
99 99
         $server = explode(':', $this->args['HTTPSERVER']);
100
-        if (count($server) > 1) {
100
+        if (count($server)>1) {
101 101
             $this->client = new xmlrpc_client($uri, $server[0], $server[1]);
102 102
         } else {
103 103
             $this->client = new xmlrpc_client($uri, $this->args['HTTPSERVER']);
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
         $this->client->request_compression = $this->request_compression;
108 108
         $this->client->accepted_compression = $this->accepted_compression;
109 109
 
110
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . '/' . str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
110
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].'/'.str_replace('/demo/server/server.php', 'tests/phpunit_coverage.php', $this->args['HTTPURI']);
111 111
 
112 112
         if ($this->args['DEBUG'] == 1)
113 113
             ob_start();
@@ -144,9 +144,9 @@  discard block
 block discarded – undo
144 144
         }
145 145
         $this->validateResponse($r);
146 146
         if (is_array($errorCode)) {
147
-            $this->assertContains($r->faultCode(), $errorCode, 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
147
+            $this->assertContains($r->faultCode(), $errorCode, 'Error '.$r->faultCode().' connecting to server: '.$r->faultString());
148 148
         } else {
149
-            $this->assertEquals($errorCode, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
149
+            $this->assertEquals($errorCode, $r->faultCode(), 'Error '.$r->faultCode().' connecting to server: '.$r->faultString());
150 150
         }
151 151
         if (!$r->faultCode()) {
152 152
             if ($returnResponse) {
@@ -173,20 +173,20 @@  discard block
 block discarded – undo
173 173
         $query = parse_url($this->client->path, PHP_URL_QUERY);
174 174
         parse_str($query, $vars);
175 175
         $query = http_build_query(array_merge($vars, $data));
176
-        $this->client->path = parse_url($this->client->path, PHP_URL_PATH) . '?' . $query;
176
+        $this->client->path = parse_url($this->client->path, PHP_URL_PATH).'?'.$query;
177 177
     }
178 178
 
179 179
     public function testString()
180 180
     {
181
-        $sendString = "here are 3 \"entities\": < > & " .
182
-            "and here's a dollar sign: \$pretendvarname and a backslash too: " . chr(92) .
183
-            " - isn't that great? \\\"hackery\\\" at it's best " .
184
-            " also don't want to miss out on \$item[0]. " .
185
-            "The real weird stuff follows: CRLF here" . chr(13) . chr(10) .
186
-            "a simple CR here" . chr(13) .
187
-            "a simple LF here" . chr(10) .
188
-            "and then LFCR" . chr(10) . chr(13) .
189
-            "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne, and an xml comment closing tag: -->";
181
+        $sendString = "here are 3 \"entities\": < > & ".
182
+            "and here's a dollar sign: \$pretendvarname and a backslash too: ".chr(92).
183
+            " - isn't that great? \\\"hackery\\\" at it's best ".
184
+            " also don't want to miss out on \$item[0]. ".
185
+            "The real weird stuff follows: CRLF here".chr(13).chr(10).
186
+            "a simple CR here".chr(13).
187
+            "a simple LF here".chr(10).
188
+            "and then LFCR".chr(10).chr(13).
189
+            "last but not least weird names: G".chr(252)."nter, El".chr(232)."ne, and an xml comment closing tag: -->";
190 190
         $m = new xmlrpcmsg('examples.stringecho', array(
191 191
             new xmlrpcval($sendString, 'string'),
192 192
         ));
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
     public function testLatin1String()
208 208
     {
209 209
         $sendString =
210
-            "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne";
210
+            "last but not least weird names: G".chr(252)."nter, El".chr(232)."ne";
211 211
         $x = '<?xml version="1.0" encoding="ISO-8859-1"?><methodCall><methodName>examples.stringecho</methodName><params><param><value>'.
212 212
             $sendString.
213 213
             '</value></param></params></methodCall>';
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     public function testUtf8Method()
316 316
     {
317 317
         PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'UTF-8';
318
-        $m = new xmlrpcmsg("tests.utf8methodname." . 'κόσμε', array(
318
+        $m = new xmlrpcmsg("tests.utf8methodname.".'κόσμε', array(
319 319
             new xmlrpcval('hello')
320 320
         ));
321 321
         $v = $this->send($m);
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
         ));
338 338
         $v = $this->send($m);
339 339
         if ($v) {
340
-            $this->assertEquals($a + $b, $v->scalarval());
340
+            $this->assertEquals($a+$b, $v->scalarval());
341 341
         }
342 342
     }
343 343
 
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
         ));
350 350
         $v = $this->send($m);
351 351
         if ($v) {
352
-            $this->assertEquals(12 - 23, $v->scalarval());
352
+            $this->assertEquals(12-23, $v->scalarval());
353 353
         }
354 354
     }
355 355
 
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
         if ($v) {
384 384
             $sz = $v->arraysize();
385 385
             $got = '';
386
-            for ($i = 0; $i < $sz; $i++) {
386
+            for ($i = 0; $i<$sz; $i++) {
387 387
                 $b = $v->arraymem($i);
388 388
                 if ($b->scalarval()) {
389 389
                     $got .= '1';
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
             $got = '';
447 447
             $expected = '37210';
448 448
             $expect_array = array('ctLeftAngleBrackets', 'ctRightAngleBrackets', 'ctAmpersands', 'ctApostrophes', 'ctQuotes');
449
-            foreach($expect_array as $val) {
449
+            foreach ($expect_array as $val) {
450 450
                 $b = $v->structmem($val);
451 451
                 $got .= $b->me['int'];
452 452
             }
@@ -899,7 +899,7 @@  discard block
 block discarded – undo
899 899
     {
900 900
         // make a 'deep client copy' as the original one might have many properties set
901 901
         // also for speed only wrap one method of the whole server
902
-        $class = wrap_xmlrpc_server($this->client, array('simple_client_copy' => 0, 'method_filter' => '/examples\.getStateName/' ));
902
+        $class = wrap_xmlrpc_server($this->client, array('simple_client_copy' => 0, 'method_filter' => '/examples\.getStateName/'));
903 903
         if ($class == '') {
904 904
             $this->fail('Registration of remote server failed');
905 905
         } else {
@@ -938,9 +938,9 @@  discard block
 block discarded – undo
938 938
         $cookies = array(
939 939
             //'c1' => array(),
940 940
             'c2' => array('value' => 'c2'),
941
-            'c3' => array('value' => 'c3', 'expires' => time() + 60 * 60 * 24 * 30),
942
-            'c4' => array('value' => 'c4', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/'),
943
-            'c5' => array('value' => 'c5', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/', 'domain' => 'localhost'),
941
+            'c3' => array('value' => 'c3', 'expires' => time()+60 * 60 * 24 * 30),
942
+            'c4' => array('value' => 'c4', 'expires' => time()+60 * 60 * 24 * 30, 'path' => '/'),
943
+            'c5' => array('value' => 'c5', 'expires' => time()+60 * 60 * 24 * 30, 'path' => '/', 'domain' => 'localhost'),
944 944
         );
945 945
         $cookiesval = php_xmlrpc_encode($cookies);
946 946
         $m = new xmlrpcmsg('examples.setcookies', array($cookiesval));
@@ -988,10 +988,10 @@  discard block
 block discarded – undo
988 988
         $m = new xmlrpcmsg('examples.getcookies', array());
989 989
         foreach ($cookies as $cookie => $val) {
990 990
             $this->client->setCookie($cookie, $val);
991
-            $cookies[$cookie] = (string)$cookies[$cookie];
991
+            $cookies[$cookie] = (string) $cookies[$cookie];
992 992
         }
993 993
         $r = $this->client->send($m, $this->timeout, $this->method);
994
-        $this->assertEquals(0, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString());
994
+        $this->assertEquals(0, $r->faultCode(), 'Error '.$r->faultCode().' connecting to server: '.$r->faultString());
995 995
         if (!$r->faultCode()) {
996 996
             $v = $r->value();
997 997
             $v = php_xmlrpc_decode($v);
Please login to merge, or discard this patch.
tests/9ExtraFilesTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests for php files in the 'extras' directory
@@ -12,9 +12,9 @@  discard block
 block discarded – undo
12 12
     {
13 13
         $this->args = argParser::getArgs();
14 14
 
15
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/tests/index.php', $this->args['HTTPURI'] );
15
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/tests/index.php', $this->args['HTTPURI']);
16 16
 
17
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/tests/phpunit_coverage.php', $this->args['HTTPURI'] );
17
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/tests/phpunit_coverage.php', $this->args['HTTPURI']);
18 18
     }
19 19
 
20 20
     public function testBenchmark()
Please login to merge, or discard this patch.
tests/8DebuggerTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/WebTestCase.php';
3
+include_once __DIR__.'/WebTestCase.php';
4 4
 
5 5
 class DebuggerTest extends PhpXmlRpc_WebTestCase
6 6
 {
@@ -8,9 +8,9 @@  discard block
 block discarded – undo
8 8
     {
9 9
         $this->args = argParser::getArgs();
10 10
 
11
-        $this->baseUrl = $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/tests/index.php', $this->args['HTTPURI'] );
11
+        $this->baseUrl = $this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/tests/index.php', $this->args['HTTPURI']);
12 12
 
13
-        $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . str_replace( '/demo/server/server.php', '/tests/phpunit_coverage.php', $this->args['HTTPURI'] );
13
+        $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].str_replace('/demo/server/server.php', '/tests/phpunit_coverage.php', $this->args['HTTPURI']);
14 14
     }
15 15
 
16 16
     public function testIndex()
Please login to merge, or discard this patch.
demo/server/_prepend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,5 +14,5 @@
 block discarded – undo
14 14
 }
15 15
 
16 16
 // Use the custom class autoloader. These two lines not needed when the phpxmlrpc library is installed using Composer
17
-include_once __DIR__ . '/../../src/Autoloader.php';
17
+include_once __DIR__.'/../../src/Autoloader.php';
18 18
 PhpXmlRpc\Autoloader::register();
Please login to merge, or discard this patch.
demo/client/getstatename.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Getstatename demo</title></head>
@@ -11,30 +11,30 @@  discard block
 block discarded – undo
11 11
 ');
12 12
 
13 13
 if (isset($_POST["stateno"]) && $_POST["stateno"] != "") {
14
-    $stateNo = (integer)$_POST["stateno"];
14
+    $stateNo = (integer) $_POST["stateno"];
15 15
     $encoder = new PhpXmlRpc\Encoder();
16 16
     $req = new PhpXmlRpc\Request('examples.getStateName',
17 17
         array($encoder->encode($stateNo))
18 18
     );
19
-    output("Sending the following request:<pre>\n\n" . htmlentities($req->serialize()) . "\n\n</pre>Debug info of server data follows...\n\n");
19
+    output("Sending the following request:<pre>\n\n".htmlentities($req->serialize())."\n\n</pre>Debug info of server data follows...\n\n");
20 20
     $client = new PhpXmlRpc\Client(XMLRPCSERVER);
21 21
     $client->setDebug(1);
22 22
     $r = $client->send($req);
23 23
     if (!$r->faultCode()) {
24 24
         $v = $r->value();
25
-        output("<br/>State number <b>" . $stateNo . "</b> is <b>"
26
-            . htmlspecialchars($encoder->decode($v)) . "</b><br/><br/>");
25
+        output("<br/>State number <b>".$stateNo."</b> is <b>"
26
+            . htmlspecialchars($encoder->decode($v))."</b><br/><br/>");
27 27
     } else {
28 28
         output("An error occurred: ");
29
-        output("Code: " . htmlspecialchars($r->faultCode())
30
-            . " Reason: '" . htmlspecialchars($r->faultString()) . "'</pre><br/>");
29
+        output("Code: ".htmlspecialchars($r->faultCode())
30
+            . " Reason: '".htmlspecialchars($r->faultString())."'</pre><br/>");
31 31
     }
32 32
 } else {
33 33
     $stateNo = "";
34 34
 }
35 35
 
36 36
 output("<form action=\"getstatename.php\" method=\"POST\">
37
-<input name=\"stateno\" value=\"" . $stateNo . "\">
37
+<input name=\"stateno\" value=\"" . $stateNo."\">
38 38
 <input type=\"submit\" value=\"go\" name=\"submit\">
39 39
 </form>
40 40
 <p>Enter a state number to query its name</p>");
Please login to merge, or discard this patch.
demo/client/_prepend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 }
15 15
 
16 16
 // Use the custom class autoloader. These two lines not needed when the phpxmlrpc library is installed using Composer
17
-include_once __DIR__ . '/../../src/Autoloader.php';
17
+include_once __DIR__.'/../../src/Autoloader.php';
18 18
 PhpXmlRpc\Autoloader::register();
19 19
 
20 20
 // Let unit tests run against localhost, 'plain' demos against a known public server
Please login to merge, or discard this patch.
demo/client/which.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Which toolkit demo</title></head>
@@ -18,14 +18,14 @@  discard block
 block discarded – undo
18 18
     $value = $encoder->decode($resp->value());
19 19
     output("Toolkit info:<br/>\n");
20 20
     output("<pre>");
21
-    output("name: " . htmlspecialchars($value["toolkitName"]) . "\n");
22
-    output("version: " . htmlspecialchars($value["toolkitVersion"]) . "\n");
23
-    output("docs: " . htmlspecialchars($value["toolkitDocsUrl"]) . "\n");
24
-    output("os: " . htmlspecialchars($value["toolkitOperatingSystem"]) . "\n");
21
+    output("name: ".htmlspecialchars($value["toolkitName"])."\n");
22
+    output("version: ".htmlspecialchars($value["toolkitVersion"])."\n");
23
+    output("docs: ".htmlspecialchars($value["toolkitDocsUrl"])."\n");
24
+    output("os: ".htmlspecialchars($value["toolkitOperatingSystem"])."\n");
25 25
     output("</pre>");
26 26
 } else {
27 27
     output("An error occurred: ");
28
-    output("Code: " . htmlspecialchars($resp->faultCode()) . " Reason: '" . htmlspecialchars($resp->faultString()) . "'\n");
28
+    output("Code: ".htmlspecialchars($resp->faultCode())." Reason: '".htmlspecialchars($resp->faultString())."'\n");
29 29
 }
30 30
 
31 31
 output("</body></html>\n");
Please login to merge, or discard this patch.
demo/client/introspect.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Introspect demo</title></head>
@@ -13,13 +13,13 @@  discard block
 block discarded – undo
13 13
 function display_error($r)
14 14
 {
15 15
     output("An error occurred: ");
16
-    output("Code: " . $r->faultCode() . " Reason: '" . $r->faultString() . "'<br/>");
16
+    output("Code: ".$r->faultCode()." Reason: '".$r->faultString()."'<br/>");
17 17
 }
18 18
 
19 19
 $client = new PhpXmlRpc\Client(XMLRPCSERVER);
20 20
 
21 21
 // First off, let's retrieve the list of methods available on the remote server
22
-output("<h3>methods available at http://" . $client->server . $client->path . "</h3>\n");
22
+output("<h3>methods available at http://".$client->server.$client->path."</h3>\n");
23 23
 $req = new PhpXmlRpc\Request('system.listMethods');
24 24
 $resp = $client->send($req);
25 25
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
     // Then, retrieve the signature and help text of each available method
32 32
     foreach ($v as $methodName) {
33
-        output("<h4>" . htmlspecialchars($methodName->scalarval()) . "</h4>\n");
33
+        output("<h4>".htmlspecialchars($methodName->scalarval())."</h4>\n");
34 34
         // build messages first, add params later
35 35
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
36 36
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
             if ($val->kindOf() == "array") {
62 62
                 foreach ($val as $x) {
63 63
                     $ret = $x[0];
64
-                    output("<code>" . htmlspecialchars($ret->scalarval()) . " "
65
-                        . htmlspecialchars($methodName->scalarval()) . "(");
66
-                    if ($x->count() > 1) {
67
-                        for ($k = 1; $k < $x->count(); $k++) {
64
+                    output("<code>".htmlspecialchars($ret->scalarval())." "
65
+                        . htmlspecialchars($methodName->scalarval())."(");
66
+                    if ($x->count()>1) {
67
+                        for ($k = 1; $k<$x->count(); $k++) {
68 68
                             $y = $x[$k];
69 69
                             output(htmlspecialchars($y->scalarval()));
70
-                            if ($k < $x->count() - 1) {
70
+                            if ($k<$x->count()-1) {
71 71
                                 output(", ");
72 72
                             }
73 73
                         }
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>xmlrpc - Proxy demo</title></head>
Please login to merge, or discard this patch.