Db3v4l\Core\SqlExecutor\Forked\PDO

Complexity

Total Complexity

12

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getExecuteStatementProcess()	0	3	1
A	setDbConfigurationManager()	0	3	1
A	getExecuteFileProcess()	0	3	1
A	setInstanceName()	0	3	1
A	resultSetToArray()	0	4	1
B	getProcess()	0	44	7

<?php

Missing file doc comment

namespace Db3v4l\Core\SqlExecutor\Forked;

use Db3v4l\API\Interfaces\SqlExecutor\Forked\CommandExecutor;
use Db3v4l\Service\DatabaseConfigurationManager;
use Db3v4l\Util\Process;

/**
 * Executes sql queries via a separate symfony console command.
 * Relies on the 'sql:execute' dbconsole command
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @author tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class PDO extends ForkedExecutor implements CommandExecutor
{
    const EXECUTION_STRATEGY = 'PDO';

    protected $instanceName;
    /** @var DatabaseConfigurationManager $dbConfigurationManager */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

    protected $dbConfigurationManager;

    public function setInstanceName($instanceName)

Missing doc comment for function setInstanceName()

    {
        $this->instanceName = $instanceName;
    }

    public function setDbConfigurationManager(DatabaseConfigurationManager $dbConfigurationManager)

Missing doc comment for function setDbConfigurationManager()

    {
        $this->dbConfigurationManager = $dbConfigurationManager;
    }

    public function getExecuteStatementProcess($sql)

Missing doc comment for function getExecuteStatementProcess()

    {
        return $this->getProcess($sql, self::EXECUTE_COMMAND);
    }

    /**

Missing short description in doc comment

     * @param string $filename

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return Process

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function getExecuteFileProcess($filename)
    {
        return $this->getProcess($filename, self::EXECUTE_FILE);
    }

    protected function getProcess($sqlOrFilename, $action = self::EXECUTE_COMMAND)

Missing doc comment for function getProcess()

    {
        // pass on _all_ env vars, including PATH. Not doing so is deprecated...
        $env = null;

        $command = 'php';
        $options = [
            'bin/dbconsole',
            'sql:execute',
            '--only-instances=' . $this->instanceName,
            '--execute-in-process',
            '--execution-strategy=' . static::EXECUTION_STRATEGY,
            '--output-type=json',
        ];

        switch ($action) {
            case self::EXECUTE_COMMAND:

Line indented incorrectly; expected 8 spaces, found 12

                $options[] = '--sql=' . $sqlOrFilename;
                break;
            case self::EXECUTE_FILE:

Line indented incorrectly; expected 8 spaces, found 12

                $options[] = '--file=' . $sqlOrFilename;
                break;
            default:

Line indented incorrectly; expected 8 spaces, found 12

                throw new \OutOfBoundsException('Unsupported action: $action');
        }

        $instanceConfiguration = $this->dbConfigurationManager->getInstanceConfiguration($this->instanceName);

        if ($instanceConfiguration != $this->databaseConfiguration) {
            if (isset($this->databaseConfiguration['dbname'])) {
                $options[] = '--database=' . $this->databaseConfiguration['dbname'];
            }
            if (isset($this->databaseConfiguration['user'])) {
                $options[] = '--user=' . $this->databaseConfiguration['user'];
            }
            if (isset($this->databaseConfiguration['password'])) {
                $options[] = '--password=' . $this->databaseConfiguration['password'];
            }
        }

        $commandLine = $this->buildCommandLine($command, $options);

        /// @todo create Process from array
        return new Process($commandLine, null, $env);
    }

    public function resultSetToArray($data)

Missing doc comment for function resultSetToArray()

    {
        $data = json_encode($data);
        return $data;

The expression return $data returns the type string which is incompatible with the return type mandated by Db3v4l\API\Interfaces\SqlExecutor\Executor::resultSetToArray() of array.

    }
}