spec\Gweb\SyliusProductDepositPlugin\Taxation\OrderDepositTaxesApplicatorSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	it_apply_taxes()	0	44	1
A	it_implements_order_processor_interface()	0	3	1
A	let()	0	6	1
A	it_is_initializable()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Gewebe\SyliusProductDepositPlugin\Taxation;

use Doctrine\Common\Collections\ArrayCollection;
use Gewebe\SyliusProductDepositPlugin\Entity\ChannelDepositInterface;
use Gewebe\SyliusProductDepositPlugin\Entity\ProductVariantInterface;
use Gewebe\SyliusProductDepositPlugin\Taxation\OrderDepositTaxesApplicator;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Addressing\Model\ZoneInterface;
use Sylius\Component\Core\Model\AdjustmentInterface;
use Sylius\Component\Core\Model\ChannelInterface;
use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Core\Model\OrderItemInterface;
use Sylius\Component\Core\Model\OrderItemUnitInterface;
use Sylius\Component\Core\Model\TaxRateInterface;
use Sylius\Component\Core\Taxation\Applicator\OrderTaxesApplicatorInterface;
use Sylius\Component\Order\Factory\AdjustmentFactoryInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Sylius\Component\Taxation\Calculator\CalculatorInterface;
use Sylius\Component\Taxation\Model\TaxCategoryInterface;

final class OrderDepositTaxesApplicatorSpec extends ObjectBehavior
{
    function let(

It is generally recommended to explicitly declare the visibility for methods.

        CalculatorInterface $calculator,
        AdjustmentFactoryInterface $adjustmentFactory,
        RepositoryInterface $taxRateRepository
    ) {
        $this->beConstructedWith($calculator, $adjustmentFactory, $taxRateRepository);
    }

    function it_is_initializable(): void

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(OrderDepositTaxesApplicator::class);
    }

    function it_implements_order_processor_interface(): void
    {
        $this->shouldImplement(OrderTaxesApplicatorInterface::class);
    }

    function it_apply_taxes(
        AdjustmentFactoryInterface $adjustmentFactory,
        AdjustmentInterface $adjustment,
        CalculatorInterface $calculator,
        ChannelInterface $channel,
        ChannelDepositInterface $channelDeposit,
        OrderInterface $order,
        OrderItemInterface $orderItem,
        OrderItemUnitInterface $orderItemUnit,
        ProductVariantInterface $productVariant,
        RepositoryInterface $taxRateRepository,
        TaxCategoryInterface $taxCategory,
        TaxRateInterface $taxRate,
        ZoneInterface $zone
    ): void {
        $adjustmentFactory->createWithData(
            AdjustmentInterface::TAX_ADJUSTMENT,
            'Returnable tax (exclude)',
            15,
            false
        )->willReturn($adjustment);

The method willReturn() does not exist on Sylius\Component\Order\Model\AdjustmentInterface.

        $taxRate->getLabel()->willReturn('Returnable tax (exclude)');
        $taxRate->isIncludedInPrice()->willReturn(false);

        $calculator->calculate(100, $taxRate)->willReturn(15);
        $taxRateRepository->findOneBy(['category' => $taxCategory, 'zone' => $zone])->willReturn($taxRate);
        $this->beConstructedWith($calculator, $adjustmentFactory, $taxRateRepository);

        $channelDeposit->getPrice()->willReturn(100);

        $productVariant->getChannelDepositForChannel($channel)->willReturn($channelDeposit);

The method willReturn() does not exist on Gewebe\SyliusProductDepositPlugin\Entity\ChannelDepositInterface.

        $productVariant->getDepositTaxCategory()->willReturn($taxCategory);

The method willReturn() does not exist on Sylius\Component\Taxation\Model\TaxCategoryInterface.

        $orderItem->getVariant()->willReturn($productVariant);

The method willReturn() does not exist on Sylius\Component\Core\Model\ProductVariantInterface.

        $orderItem->getUnits()->willReturn(new ArrayCollection([$orderItemUnit->getWrappedObject()]));

The method willReturn() does not exist on Doctrine\Common\Collections\Collection.

The method getWrappedObject() does not exist on Sylius\Component\Core\Model\OrderItemUnitInterface.

        $orderItemUnit->addAdjustment($adjustment)->shouldBeCalled();

Are you sure the usage of $orderItemUnit->addAdjustment($adjustment) targeting Sylius\Component\Order\Model\AdjustableInterface::addAdjustment() seems to always return null.

        $order->getChannel()->willReturn($channel);

The method willReturn() does not exist on Sylius\Component\Channel\Model\ChannelInterface.

        $order->getItems()->willReturn(new ArrayCollection([$orderItem->getWrappedObject()]));

The method getWrappedObject() does not exist on Sylius\Component\Core\Model\OrderItemInterface.

        $this->apply($order, $zone);

The method apply() does not exist on spec\Gewebe\SyliusProductDepositPlugin\Taxation\OrderDepositTaxesApplicatorSpec. Since you implemented __call, consider adding a @method annotation.

    }
}