Parthenon\Billing\Repository\Orm\PaymentRepository

Complexity

Total Complexity

2

Size/Duplication

Total Lines	10
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getLastPaymentForCustomer()	0	3	1
A	getLastPaymentForSubscription()	0	3	1

<?php

declare(strict_types=1);

/*
 * Copyright Iain Cambridge 2020-2023.
 *
 * Use of this software is governed by the Business Source License included in the LICENSE file and at https://getparthenon.com/docs/next/license.
 *
 * Change Date: TBD ( 3 years after 2.2.0 release )
 *
 * On the date above, in accordance with the Business Source License, use of this software will be governed by the open source license specified in the LICENSE file.
 */

namespace Parthenon\Billing\Repository\Orm;

use Parthenon\Athena\Repository\DoctrineCrudRepository;
use Parthenon\Billing\Entity\CustomerInterface;
use Parthenon\Billing\Entity\Payment;
use Parthenon\Billing\Entity\Subscription;
use Parthenon\Billing\Repository\PaymentRepositoryInterface;

class PaymentRepository extends DoctrineCrudRepository implements PaymentRepositoryInterface
{
    public function getLastPaymentForSubscription(Subscription $subscription): Payment
    {
        return $this->entityRepository->findOneBy(['subscription' => $subscription], ['createdAt' => 'DESC']);

The expression return $this->entityRepository->findOneBy(array('subscription' => $subscription), array('createdAt' => 'DESC')) could return the type null which is incompatible with the type-hinted return Parthenon\Billing\Entity\Payment. Consider adding an additional type-check to rule them out.

    }

    public function getLastPaymentForCustomer(CustomerInterface $customer): Payment
    {
        return $this->entityRepository->findOneBy(['customer' => $customer], ['createdAt' => 'DESC']);

The expression return $this->entityRepository->findOneBy(array('customer' => $customer), array('createdAt' => 'DESC')) could return the type null which is incompatible with the type-hinted return Parthenon\Billing\Entity\Payment. Consider adding an additional type-check to rule them out.

    }
}