Parthenon\Athena\Repository\DoctrineCrudRepository::getList()

Complexity

Conditions	12
Paths	146

Size

Total Lines	50
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getList(array $filters = [], string $sortKey = 'id', string $sortType = 'ASC', int $limit = self::LIMIT, $lastId = null): ResultSet
    {
        $sortKey = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', $sortKey))));

        $parts = explode('\\', $this->entityRepository->getClassName());
        $name = end($parts);
        $qb = $this->entityRepository->createQueryBuilder($name);

        $direction = 'DESC' === $sortType ? '<' : '>';
        $sortKey = preg_replace('/[^A-Za-z0-9_]+/', '', $sortKey);
        $em = $this->entityRepository->getEntityManager();
        $columns = $em->getClassMetadata($this->entityRepository->getClassName())->getColumnNames();
        $columns = array_map(function ($colName) {
            return lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', $colName))));
        }, $columns);

        if (!in_array($sortKey, $columns)) {
            throw new GeneralException("Sort key doesn't exist");
        }

        $qb
            ->orderBy($qb->getRootAliases()[0].'.'.$sortKey, $sortType)
            ->setMaxResults($limit + 1); // Fetch one more than required for pagination.

        if ($lastId) {
            $qb->where($qb->getRootAliases()[0].'.'.$sortKey.' '.$direction.' :lastId');
        }

        if (is_a($this->entityRepository->getClassName(), DeletableInterface::class, true)) {
            $qb->andWhere($qb->getRootAliases()[0].'.isDeleted = false');
        }

        foreach ($filters as $filter) {
            if ($filter instanceof DoctrineFilterInterface && $filter->hasData()) {
                $filter->modifyQueryBuilder($qb);
            }
        }
        $query = $qb->getQuery();

        foreach ($filters as $filter) {
            if ($filter instanceof DoctrineFilterInterface && $filter->hasData()) {
                $filter->modifyQuery($query);
            }
        }

        if ($lastId) {
            $query->setParameter(':lastId', $lastId);
        }

        return new ResultSet($query->getResult(), $sortKey, $sortType, $limit);

It seems like $query->getResult() can also be of type integer; however, parameter $results of Parthenon\Athena\ResultSet::__construct() does only seem to accept array, maybe add an additional type check?

    }