Parthenon\Billing\Customer\CustomerManager

Complexity

Total Complexity

3

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCustomerForReference()	0	6	2
A	__construct()	0	2	1

<?php

declare(strict_types=1);

/*
 * Copyright Iain Cambridge 2020-2023.
 *
 * Use of this software is governed by the Business Source License included in the LICENSE file and at https://getparthenon.com/docs/next/license.
 *
 * Change Date: TBD ( 3 years after 2.2.0 release )
 *
 * On the date above, in accordance with the Business Source License, use of this software will be governed by the open source license specified in the LICENSE file.
 */

namespace Parthenon\Billing\Customer;

use Parthenon\Billing\Entity\CustomerInterface;
use Parthenon\Billing\Exception\NoCustomerException;
use Parthenon\Billing\Repository\CustomerRepositoryInterface;
use Parthenon\Common\Exception\NoEntityFoundException;

final class CustomerManager implements CustomerManagerInterface
{
    public function __construct(private CustomerRepositoryInterface $customerRepository)
    {
    }

    /**
     * @throws NoCustomerException
     */
    public function getCustomerForReference(string $reference): CustomerInterface
    {
        try {
            $customer = $this->customerRepository->getByExternalReference($reference);

The assignment to $customer is dead and can be removed.

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Parthenon\Billing\Entity\CustomerInterface. Consider adding a return statement or allowing null as return value.

        } catch (NoEntityFoundException $e) {
            throw new NoCustomerException();
        }
    }
}