PaymentCardRepository::findById() - Code Metrics - Inspection of "[Billing] Make payment details come from BillaBear" - getparthenon/parthenon - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( ca991c...241451 )

by Iain

created 2024-06-07 02:42 UTC

PaymentCardRepository::findById() A

↳ Parent: PaymentCardRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	5
rs	10

<?php

declare(strict_types=1);

/*
 * Copyright (C) 2020-2024 Iain Cambridge
 *
 *     This program is free software: you can redistribute it and/or modify
 *     it under the terms of the GNU General Public License as published by
 *     the Free Software Foundation, either version 3 of the License, or
 *     (at your option) any later version.
 *
 *     This program is distributed in the hope that it will be useful,
 *     but WITHOUT ANY WARRANTY; without even the implied warranty of
 *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *     GNU General Public License for more details.
 *
 *     You should have received a copy of the GNU General Public License
 *     along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

namespace Parthenon\Billing\BillaBear;

use BillaBear\Model\PaymentDetails;
filter:
    dependency_paths: ["lib/*"]
use Parthenon\Billing\Entity\CustomerInterface;
use Parthenon\Billing\Entity\PaymentCard;
use Parthenon\Billing\Repository\PaymentCardRepositoryInterface;

class PaymentCardRepository implements PaymentCardRepositoryInterface
{
    public function __construct(private SdkFactory $sdkFactory)
    {
    }

    public function getPaymentCardForCustomer(CustomerInterface $customer): array
    {
        $cardResponse = $this->sdkFactory->createPaymentDetails()->listPaymentDetails($customer->getExternalCustomerReference());

        $output = [];

        foreach ($cardResponse->getData() as $paymentDetails) {
            $output[] = $this->buildPaymentCard($paymentDetails);
        }

        return $output;
    }

    public function markAllCustomerCardsAsNotDefault(CustomerInterface $customer): void
    {
        // TODO: Implement markAllCustomerCardsAsNotDefault() method.
    }

    public function getDefaultPaymentCardForCustomer(CustomerInterface $customer): PaymentCard
    {
        // TODO: Implement getDefaultPaymentCardForCustomer() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    public function findById($id)
    {
        $paymentCard = $this->sdkFactory->createPaymentDetails()->getPaymentDetails($id);

        return $this->buildPaymentCard($paymentCard);
    }

    public function save($entity)
    {
        throw new \Exception("SHouldn't be used. ISP failure.");
    }

    private function buildPaymentCard(PaymentDetails $paymentDetails): PaymentCard
    {
        $paymentCard = new PaymentCard();
        $paymentCard->setId($paymentDetails->getId());
        $paymentCard->setName($paymentDetails->getName());
        $paymentCard->setDefaultPaymentOption($paymentDetails->getDefault());
        $paymentCard->setBrand($paymentDetails->getBrand());
        $paymentCard->setLastFour($paymentDetails->getLastFour());
        $paymentCard->setExpiryMonth($paymentDetails->getExpiryMonth());
        $paymentCard->setExpiryYear($paymentDetails->getExpiryYear());
        $paymentCard->setCreatedAt(new \DateTime($paymentDetails->getCreatedAt()));

        return $paymentCard;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* Copyright (C) 2020-2024 Iain Cambridge
7			*
8			* This program is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU General Public License as published by
10			* the Free Software Foundation, either version 3 of the License, or
11			* (at your option) any later version.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU General Public License for more details.
17			*
18			* You should have received a copy of the GNU General Public License
19			* along with this program. If not, see <https://www.gnu.org/licenses/>.
20			*/
21
22			namespace Parthenon\Billing\BillaBear;
23
24			use BillaBear\Model\PaymentDetails;
			0 ignored issues – show Bug introduced 2024-06-07 02:46 UTC by Report Bug Copy Issue Report The type `BillaBear\Model\PaymentDetails` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
25			use Parthenon\Billing\Entity\CustomerInterface;
26			use Parthenon\Billing\Entity\PaymentCard;
27			use Parthenon\Billing\Repository\PaymentCardRepositoryInterface;
28
29			class PaymentCardRepository implements PaymentCardRepositoryInterface
30			{
31			public function __construct(private SdkFactory $sdkFactory)
32			{
33			}
34
35			public function getPaymentCardForCustomer(CustomerInterface $customer): array
36			{
37			$cardResponse = $this->sdkFactory->createPaymentDetails()->listPaymentDetails($customer->getExternalCustomerReference());
38
39			$output = [];
40
41			foreach ($cardResponse->getData() as $paymentDetails) {
42			$output[] = $this->buildPaymentCard($paymentDetails);
43			}
44
45			return $output;
46			}
47
48			public function markAllCustomerCardsAsNotDefault(CustomerInterface $customer): void
49			{
50			// TODO: Implement markAllCustomerCardsAsNotDefault() method.
51			}
52
53			public function getDefaultPaymentCardForCustomer(CustomerInterface $customer): PaymentCard
54			{
55			// TODO: Implement getDefaultPaymentCardForCustomer() method.
56			}
			0 ignored issues – show Bug Best Practice introduced 2024-06-07 02:46 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Parthenon\Billing\Entity\PaymentCard`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
57
58			public function findById($id)
59			{
60			$paymentCard = $this->sdkFactory->createPaymentDetails()->getPaymentDetails($id);
61
62			return $this->buildPaymentCard($paymentCard);
63			}
64
65			public function save($entity)
66			{
67			throw new \Exception("SHouldn't be used. ISP failure.");
68			}
69
70			private function buildPaymentCard(PaymentDetails $paymentDetails): PaymentCard
71			{
72			$paymentCard = new PaymentCard();
73			$paymentCard->setId($paymentDetails->getId());
74			$paymentCard->setName($paymentDetails->getName());
75			$paymentCard->setDefaultPaymentOption($paymentDetails->getDefault());
76			$paymentCard->setBrand($paymentDetails->getBrand());
77			$paymentCard->setLastFour($paymentDetails->getLastFour());
78			$paymentCard->setExpiryMonth($paymentDetails->getExpiryMonth());
79			$paymentCard->setExpiryYear($paymentDetails->getExpiryYear());
80			$paymentCard->setCreatedAt(new \DateTime($paymentDetails->getCreatedAt()));
81
82			return $paymentCard;
83			}
84			}
85

getparthenon / parthenon

Push — main ( ca991c...241451 )

PaymentCardRepository::findById() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like