Parthenon\AbTesting\Experiment\OptimizelyDecider

Complexity

Total Complexity

3

Size/Duplication

Total Lines	11
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	doExperiment()	0	5	2

<?php

declare(strict_types=1);

/*
 * Copyright (C) 2020-2025 Iain Cambridge
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU LESSER GENERAL PUBLIC LICENSE as published by
 * the Free Software Foundation, either version 2.1 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

namespace Parthenon\AbTesting\Experiment;

use Optimizely\Optimizely;
use Parthenon\User\Entity\UserInterface;

final class OptimizelyDecider implements DeciderInterface
{
    public function __construct(private Optimizely $optimizely)
    {
    }

    public function doExperiment(string $experimentName, ?UserInterface $user = null, array $options = []): string
    {
        $userId = ($user) ? $user->getId() : null;

        return $this->optimizely->activate($experimentName, $userId, $options);

The expression return $this->optimizely->activate($experimentName, $userId, $options) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}