Conditions | 24 |
Paths | > 20000 |
Total Lines | 81 |
Code Lines | 62 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
93 | public function createArrayFromServiceObject( |
||
94 | \Getnet\SubSellerMagento\Api\Data\SubSellerInterface $subSeller, |
||
95 | $returnNumericLogic = false |
||
96 | ) { |
||
97 | $businessAddress = []; |
||
98 | $bankAccountsUniqueAccount = []; |
||
99 | $identificationDocument = []; |
||
100 | $status = null; |
||
101 | if ($subSeller->getStatus()) { |
||
102 | $statusOptions = $this->status->toOptionArray(); |
||
103 | $status = 1; |
||
104 | if ($subSeller->getStatus() <= 3) { |
||
105 | $status = $statusOptions[$subSeller->getStatus()]; |
||
106 | $status = $status->getText(); |
||
107 | } |
||
108 | } |
||
109 | |||
110 | if ($subSeller->getAddresses()) { |
||
111 | unset($businessAddress); |
||
112 | $addresses = $subSeller->getAddresses(); |
||
113 | $businessAddress = $addresses['addresses']['business_address']; |
||
114 | } |
||
115 | |||
116 | if ($subSeller->getBankAccounts()) { |
||
117 | unset($bankAccountsUniqueAccount); |
||
118 | $bankAccounts = $subSeller->getBankAccounts(); |
||
119 | $bankAccountsUniqueAccount = $bankAccounts['bank_accounts']['unique_account']; |
||
120 | } |
||
121 | |||
122 | if ($subSeller->getIdentificationDocument()) { |
||
123 | unset($identificationDocument); |
||
124 | $identificationDocument = $subSeller->getIdentificationDocument(); |
||
125 | $identificationDocument = $identificationDocument['identification_document']; |
||
126 | } |
||
127 | |||
128 | $subSellerFormData = [ |
||
129 | 'id' => $subSeller->getId(), |
||
130 | 'merchant_id' => $subSeller->getMerchantId(), |
||
131 | 'code' => $subSeller->getCode(), |
||
132 | 'id_ext' => $subSeller->getIdExt(), |
||
133 | 'email' => $subSeller->getEmail(), |
||
134 | 'legal_document_number' => $subSeller->getLegalDocumentNumber(), |
||
135 | 'type' => $subSeller->getType(), |
||
136 | 'legal_name' => $subSeller->getLegalName(), |
||
137 | 'birth_date' => $subSeller->getBirthDate(), |
||
138 | 'address_street' => isset($businessAddress['address_street']) ? $businessAddress['address_street'] : null, |
||
139 | 'address_street_number' => isset($businessAddress['address_street_number']) ? $businessAddress['address_street_number'] : null, |
||
140 | 'address_street_district' => isset($businessAddress['address_street_district']) ? $businessAddress['address_street_district'] : null, |
||
141 | 'address_street_complement' => isset($businessAddress['address_street_complement']) ? $businessAddress['address_street_complement'] : null, |
||
142 | 'address_city' => isset($businessAddress['address_city']) ? $businessAddress['address_city'] : null, |
||
143 | 'address_region' => isset($businessAddress['address_region']) ? $businessAddress['address_region'] : null, |
||
144 | 'address_region_id' => isset($businessAddress['address_region_id']) ? $businessAddress['address_region_id'] : null, |
||
145 | 'address_country_id' => isset($businessAddress['address_country_id']) ? $businessAddress['address_country_id'] : null, |
||
146 | 'address_postcode' => isset($businessAddress['address_postcode']) ? $businessAddress['address_postcode'] : null, |
||
147 | 'telephone' => $subSeller->getTelephone(), |
||
148 | 'account_type' => isset($bankAccountsUniqueAccount['account_type']) ? $bankAccountsUniqueAccount['account_type'] : null, |
||
149 | 'bank' => isset($bankAccountsUniqueAccount['bank']) ? $bankAccountsUniqueAccount['bank'] : null, |
||
150 | 'agency' => isset($bankAccountsUniqueAccount['agency']) ? $bankAccountsUniqueAccount['agency'] : null, |
||
151 | 'agency_digit' => isset($bankAccountsUniqueAccount['agency_digit']) ? $bankAccountsUniqueAccount['agency_digit'] : null, |
||
152 | 'account' => isset($bankAccountsUniqueAccount['account']) ? $bankAccountsUniqueAccount['account'] : null, |
||
153 | 'account_digit' => isset($bankAccountsUniqueAccount['account_digit']) ? $bankAccountsUniqueAccount['account_digit'] : null, |
||
154 | 'payment_plan' => $subSeller->getPaymentPlan(), |
||
155 | 'accepted_contract' => $subSeller->getAcceptedContract(), |
||
156 | 'marketplace_store' => $subSeller->getMarketplaceStore(), |
||
157 | 'monthly_gross_income' => $subSeller->getMonthlyGrossIncome(), |
||
158 | 'gross_equity' => $subSeller->getGrossEquity(), |
||
159 | 'status' => $status, |
||
160 | 'status_comment' => $subSeller->getStatusComment(), |
||
161 | 'created_at' => $subSeller->getCreatedAt(), |
||
162 | 'updated_at' => $subSeller->getUpdatedAt(), |
||
163 | ]; |
||
164 | |||
165 | if ($subSellerFormData['address_region_id'] === '0') { |
||
166 | $subSellerFormData['address_region_id'] = ''; |
||
167 | } |
||
168 | |||
169 | if ($subSeller->getType()) { |
||
170 | $subSellerFormData['type'] = $returnNumericLogic ? 1 : true; |
||
171 | } |
||
172 | |||
173 | return $subSellerFormData; |
||
174 | } |
||
261 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths