Update::updateData() - Code Metrics - getnet-adquirencia/sub-seller-magento - Measure and Improve Code Quality continuously with Scrutinizer

Update::updateData() B
last analyzed 2022-07-12 14:37 UTC

↳ Parent: Update

Complexity

Conditions	9
Paths	126

Size

Total Lines	66
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	38
c	1
b	0
f	0
dl	0
loc	66
rs	7.5831
cc	9
nc	126
nop	3

How to fix Long Method

<?php
/**
 * Copyright © Getnet. All rights reserved.
 *
 * @author    Bruno Elisei <[email protected]>
 * See LICENSE for license details.
 */

declare(strict_types=1);

namespace Getnet\SubSellerMagento\Model\Console\Command\Synchronize;

use Exception;
use Getnet\SubSellerMagento\Api\SubSellerRepositoryInterface;
use Getnet\SubSellerMagento\Helper\Data as GetnetHelper;
use Getnet\SubSellerMagento\Logger\Logger;
use Getnet\SubSellerMagento\Model\Config as GetnetConfig;
use Getnet\SubSellerMagento\Model\Console\Command\AbstractModel;
use Magento\Framework\App\State;
use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\HTTP\ZendClient;
use Magento\Framework\HTTP\ZendClientFactory;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\Serialize\Serializer\Json;

/**
 * Class Update Sub Seller on Getnet.
 */
class Update extends AbstractModel
{
    /**
     * @var State
     */
    protected $state;

    /**
     * @var Logger
     */
    protected $logger;

    /**
     * @var GetnetConfig
     */
    protected $getnetConfig;

    /**
     * @var GetnetHelper
     */
    protected $getnetHelper;

    /**
     * @var SubSellerRepositoryInterface
     */
    protected $subSellerRepository;

    /**
     * @var Json
     */
    protected $json;

    /**
     * @var ZendClientFactory
     */
    protected $httpClientFactory;

    /**
     * @param State                        $state
     * @param Logger                       $logger
     * @param GetnetConfig                 $getnetConfig
     * @param GetnetHelper                 $getnetHelper
     * @param SubSellerRepositoryInterface $subSellerRepository
     * @param Json                         $json
     * @param ZendClientFactory            $httpClientFactory
     */
    public function __construct(
        State $state,
        Logger $logger,
        GetnetConfig $getnetConfig,
        GetnetHelper $getnetHelper,
        SubSellerRepositoryInterface $subSellerRepository,
        Json $json,
        ZendClientFactory $httpClientFactory
    ) {
        $this->state = $state;
        $this->logger = $logger;
        $this->getnetConfig = $getnetConfig;
        $this->getnetHelper = $getnetHelper;
        $this->subSellerRepository = $subSellerRepository;
        $this->json = $json;
        $this->httpClientFactory = $httpClientFactory;
    }

    /**
     * Command Preference.
     *
     * @param int $subSellerId
     *
     * @return void
     */
    public function update(int $subSellerId)
    {
        $this->writeln('Init Sync Sub Seller');
        $this->updateSubSeller($subSellerId);
        $this->writeln(__('Finished'));
    }

    /**
     * Update Sub Seller.
     *
     * @param int $subSellerId
     *
     * @return void
     * @SuppressWarnings(PHPMD.NPathComplexity)
     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
     */
    protected function updateSubSeller(int $subSellerId)
    {
        try {
            $subSeller = $this->subSellerRepository->get($subSellerId);
        } catch (LocalizedException $exc) {
            $this->writeln('<error>'.$exc->getMessage().'</error>');

            return;
        }

        if ($subSeller->getId()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $typePersona = (bool) $subSeller->getType();
            if (!$subSeller->getIdExt()) {
                $messageErrors = __('The Sub Seller does not have a relationship id on Getnet');
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));
            }

            $messageInfo = __('Send Sub Seller internal code: %1', $subSeller->getCode());
            $this->writeln(sprintf('<info>%s</info>', $messageInfo));
            $formatedData = $this->getnetHelper->formatedData($subSeller, $typePersona, 'seller_update');
            $this->writeln($this->json->serialize($formatedData));
            $response = $this->updateData($formatedData, $typePersona, (int) $subSeller->getStatus());

            if ($response->getErrors()) {
                foreach ($response->getErrors() as $error) {
                    $errors[] = $error;
                }
                $listErrors = implode(', ', $errors);

                $messageErrors = __('Could not update registration, errors found: %1', $listErrors);
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));

                return;
            }

            if ($response->getMessage()) {
                $errors[] = $response->getMessage();

                if (is_array($response->getMessage())) {
                    unset($errors);
                    foreach ($response->getMessage() as $key => $error) {
                        foreach ($error as $typeError) {
                            $errors[] = $typeError.' field '.$key;
                        }
                    }
                }
                $listErrors = implode(', ', $errors);
                $messageErrors = __('Could not update registration, errors found: %1', $listErrors);
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));

                return;
            }

            if ($response->getSuccess()) {
                $this->writeln('<info>Done!</info>');

                return;
            }

            if ($response->getSubsellerId()) {
                $messageResponse = __(
                    'Success, the sub seller id: %1, enable to sales: %2, id getnet: %3',
                    $response->getSubsellerId(),
                    $response->getEnabled()
                );
                $this->writeln(sprintf('<info>%s</info>', $messageResponse));

                return;
            }

            $messageErrorConection = __('Connection Error: %1', json_encode($response));
            $this->writeln(sprintf('<error>%s</error>', $messageErrorConection));

            return;
        }
        $this->writeln('<error>'.__('Error').'</error>');
    }

    /**
     * Update Data.
     *
     * @param array $sellerFomarted
     * @param bool  $typePersona
     * @param int   $status
     *
     * @return \Magento\Framework\DataObject
     */
    protected function updateData(
        array $sellerFomarted,
        bool $typePersona,
        int $status
    ): \Magento\Framework\DataObject {
        $uri = $this->getnetConfig->getUri();
        $bearer = $this->getnetConfig->getAuth();
        $client = $this->httpClientFactory->create();
        $send = $this->json->serialize($sellerFomarted);
        $client->setUri($uri.'v1/mgm/pf/update-subseller');

        if ($typePersona) {
            $client->setUri($uri.'v1/mgm/pj/update-subseller');
        }

        if ($status === 5) {
            $client->setUri($uri.'v1/mgm/pf/complement');

            if ($typePersona) {
                $client->setUri($uri.'v1/mgm/pj/complement');
            }
        }

        $client->setHeaders('Authorization', 'Bearer '.$bearer);
        $client->setConfig(['maxredirects' => 0, 'timeout' => 40]);
        $client->setRawData($send, 'application/json');
        $client->setMethod(ZendClient::PUT);
        $getnetData = new \Magento\Framework\DataObject();

        try {
            $result = $client->request()->getBody();
            $response = $this->json->unserialize($result);

            $this->logger->info(
                $this->json->serialize([
                    'send'     => $send,
                    'response' => $response,
                ])
            );

            if (isset($response['status_code'])) {
                return $getnetData->setDetails($response['details']);
            }

            if (isset($response['Message'])) {
                if (isset($response['ModelState'])) {
                    $getnetData->setMessage($response['ModelState']);

                    return $getnetData;
                }
                $getnetData->setMessage($response['Message']);
            }

            if (isset($response['success'])) {
                $getnetData->setSuccess(true);

                return $getnetData;
            }

            $getnetData->setData($result);

            return $getnetData;
        } catch (Exception $e) {
            $this->logger->info($this->json->serialize(['error' => $e->getMessage()]));

            return $getnetData->setDetails($e->getMessage());
        }
    }
}


1			<?php
2			/**
3			* Copyright © Getnet. All rights reserved.
4			*
5			* @author Bruno Elisei <[email protected]>
6			* See LICENSE for license details.
7			*/
8
9			declare(strict_types=1);
10
11			namespace Getnet\SubSellerMagento\Model\Console\Command\Synchronize;
12
13			use Exception;
14			use Getnet\SubSellerMagento\Api\SubSellerRepositoryInterface;
15			use Getnet\SubSellerMagento\Helper\Data as GetnetHelper;
16			use Getnet\SubSellerMagento\Logger\Logger;
17			use Getnet\SubSellerMagento\Model\Config as GetnetConfig;
18			use Getnet\SubSellerMagento\Model\Console\Command\AbstractModel;
19			use Magento\Framework\App\State;
20			use Magento\Framework\Exception\LocalizedException;
21			use Magento\Framework\HTTP\ZendClient;
22			use Magento\Framework\HTTP\ZendClientFactory;
			0 ignored issues – show Bug introduced 2022-07-12 14:26 UTC by Report Bug Copy Issue Report The type `Magento\Framework\HTTP\ZendClientFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
23			use Magento\Framework\Serialize\Serializer\Json;
24
25			/**
26			* Class Update Sub Seller on Getnet.
27			*/
28			class Update extends AbstractModel
29			{
30			/**
31			* @var State
32			*/
33			protected $state;
34
35			/**
36			* @var Logger
37			*/
38			protected $logger;
39
40			/**
41			* @var GetnetConfig
42			*/
43			protected $getnetConfig;
44
45			/**
46			* @var GetnetHelper
47			*/
48			protected $getnetHelper;
49
50			/**
51			* @var SubSellerRepositoryInterface
52			*/
53			protected $subSellerRepository;
54
55			/**
56			* @var Json
57			*/
58			protected $json;
59
60			/**
61			* @var ZendClientFactory
62			*/
63			protected $httpClientFactory;
64
65			/**
66			* @param State $state
67			* @param Logger $logger
68			* @param GetnetConfig $getnetConfig
69			* @param GetnetHelper $getnetHelper
70			* @param SubSellerRepositoryInterface $subSellerRepository
71			* @param Json $json
72			* @param ZendClientFactory $httpClientFactory
73			*/
74			public function __construct(
75			State $state,
76			Logger $logger,
77			GetnetConfig $getnetConfig,
78			GetnetHelper $getnetHelper,
79			SubSellerRepositoryInterface $subSellerRepository,
80			Json $json,
81			ZendClientFactory $httpClientFactory
82			) {
83			$this->state = $state;
84			$this->logger = $logger;
85			$this->getnetConfig = $getnetConfig;
86			$this->getnetHelper = $getnetHelper;
87			$this->subSellerRepository = $subSellerRepository;
88			$this->json = $json;
89			$this->httpClientFactory = $httpClientFactory;
90			}
91
92			/**
93			* Command Preference.
94			*
95			* @param int $subSellerId
96			*
97			* @return void
98			*/
99			public function update(int $subSellerId)
100			{
101			$this->writeln('Init Sync Sub Seller');
102			$this->updateSubSeller($subSellerId);
103			$this->writeln(__('Finished'));
104			}
105
106			/**
107			* Update Sub Seller.
108			*
109			* @param int $subSellerId
110			*
111			* @return void
112			* @SuppressWarnings(PHPMD.NPathComplexity)
113			* @SuppressWarnings(PHPMD.CyclomaticComplexity)
114			*/
115			protected function updateSubSeller(int $subSellerId)
116			{
117			try {
118			$subSeller = $this->subSellerRepository->get($subSellerId);
119			} catch (LocalizedException $exc) {
120			$this->writeln('<error>'.$exc->getMessage().'</error>');
121
122			return;
123			}
124
125			if ($subSeller->getId()) {
			0 ignored issues – show Bug Best Practice introduced 2022-07-12 14:26 UTC by Report Bug Copy Issue Report The expression `$subSeller->getId()` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
126			$typePersona = (bool) $subSeller->getType();
127			if (!$subSeller->getIdExt()) {
128			$messageErrors = __('The Sub Seller does not have a relationship id on Getnet');
129			$this->writeln(sprintf('<error>%s</error>', $messageErrors));
130			}
131
132			$messageInfo = __('Send Sub Seller internal code: %1', $subSeller->getCode());
133			$this->writeln(sprintf('<info>%s</info>', $messageInfo));
134			$formatedData = $this->getnetHelper->formatedData($subSeller, $typePersona, 'seller_update');
135			$this->writeln($this->json->serialize($formatedData));
136			$response = $this->updateData($formatedData, $typePersona, (int) $subSeller->getStatus());
137
138			if ($response->getErrors()) {
139			foreach ($response->getErrors() as $error) {
140			$errors[] = $error;
141			}
142			$listErrors = implode(', ', $errors);
			0 ignored issues – show Comprehensibility Best Practice introduced 2022-07-12 14:26 UTC by Report Bug Copy Issue Report The variable `$errors` seems to be defined by a `foreach` iteration on line `139`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
143			$messageErrors = __('Could not update registration, errors found: %1', $listErrors);
144			$this->writeln(sprintf('<error>%s</error>', $messageErrors));
145
146			return;
147			}
148
149			if ($response->getMessage()) {
150			$errors[] = $response->getMessage();
			0 ignored issues – show Comprehensibility Best Practice introduced 2022-07-12 14:26 UTC by Report Bug Copy Issue Report `$errors` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$errors = array();` before regardless. Loading history...
151			if (is_array($response->getMessage())) {
152			unset($errors);
153			foreach ($response->getMessage() as $key => $error) {
154			foreach ($error as $typeError) {
155			$errors[] = $typeError.' field '.$key;
156			}
157			}
158			}
159			$listErrors = implode(', ', $errors);
160			$messageErrors = __('Could not update registration, errors found: %1', $listErrors);
161			$this->writeln(sprintf('<error>%s</error>', $messageErrors));
162
163			return;
164			}
165
166			if ($response->getSuccess()) {
167			$this->writeln('<info>Done!</info>');
168
169			return;
170			}
171
172			if ($response->getSubsellerId()) {
173			$messageResponse = __(
174			'Success, the sub seller id: %1, enable to sales: %2, id getnet: %3',
175			$response->getSubsellerId(),
176			$response->getEnabled()
177			);
178			$this->writeln(sprintf('<info>%s</info>', $messageResponse));
179
180			return;
181			}
182
183			$messageErrorConection = __('Connection Error: %1', json_encode($response));
184			$this->writeln(sprintf('<error>%s</error>', $messageErrorConection));
185
186			return;
187			}
188			$this->writeln('<error>'.__('Error').'</error>');
189			}
190
191			/**
192			* Update Data.
193			*
194			* @param array $sellerFomarted
195			* @param bool $typePersona
196			* @param int $status
197			*
198			* @return \Magento\Framework\DataObject
199			*/
200			protected function updateData(
201			array $sellerFomarted,
202			bool $typePersona,
203			int $status
204			): \Magento\Framework\DataObject {
205			$uri = $this->getnetConfig->getUri();
206			$bearer = $this->getnetConfig->getAuth();
207			$client = $this->httpClientFactory->create();
208			$send = $this->json->serialize($sellerFomarted);
209			$client->setUri($uri.'v1/mgm/pf/update-subseller');
210
211			if ($typePersona) {
212			$client->setUri($uri.'v1/mgm/pj/update-subseller');
213			}
214
215			if ($status === 5) {
216			$client->setUri($uri.'v1/mgm/pf/complement');
217
218			if ($typePersona) {
219			$client->setUri($uri.'v1/mgm/pj/complement');
220			}
221			}
222
223			$client->setHeaders('Authorization', 'Bearer '.$bearer);
224			$client->setConfig(['maxredirects' => 0, 'timeout' => 40]);
225			$client->setRawData($send, 'application/json');
226			$client->setMethod(ZendClient::PUT);
227			$getnetData = new \Magento\Framework\DataObject();
228
229			try {
230			$result = $client->request()->getBody();
231			$response = $this->json->unserialize($result);
232
233			$this->logger->info(
234			$this->json->serialize([
235			'send' => $send,
236			'response' => $response,
237			])
238			);
239
240			if (isset($response['status_code'])) {
241			return $getnetData->setDetails($response['details']);
242			}
243
244			if (isset($response['Message'])) {
245			if (isset($response['ModelState'])) {
246			$getnetData->setMessage($response['ModelState']);
247
248			return $getnetData;
249			}
250			$getnetData->setMessage($response['Message']);
251			}
252
253			if (isset($response['success'])) {
254			$getnetData->setSuccess(true);
255
256			return $getnetData;
257			}
258
259			$getnetData->setData($result);
260
261			return $getnetData;
262			} catch (Exception $e) {
263			$this->logger->info($this->json->serialize(['error' => $e->getMessage()]));
264
265			return $getnetData->setDetails($e->getMessage());
266			}
267			}
268			}
269

getnet-adquirencia / sub-seller-magento

Update::updateData() B last analyzed 2022-07-12 14:37 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Update::updateData() B
last analyzed 2022-07-12 14:37 UTC