Getnet\SubSellerMagento\Model\Console\Command\Synchronize\Create::createSubSeller()

Complexity

Conditions	13
Paths	10

Size

Total Lines	90
Code Lines	61

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function createSubSeller(int $subSellerId)
    {
        try {
            $subSeller = $this->subSellerRepository->get($subSellerId);
        } catch (LocalizedException $exc) {
            $this->writeln('<error>'.$exc->getMessage().'</error>');

            return;
        }

        if ($subSeller->getId()) {

The expression $subSeller->getId() of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $typePersona = (bool) $subSeller->getType();
            if ($subSeller->getIdExt()) {
                $messageErrors = __('O Sub Seller já possuí id de relacionamento na Getnet');
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));

                return;
            }

            $formatedData = $this->getnetHelper->formatedData($subSeller, $typePersona);
            $messageInfo = __('Send Sub Seller internal code: %1', $subSeller->getCode());
            $this->writeln(sprintf('<info>%s</info>', $messageInfo));
            $this->writeln($this->json->serialize($formatedData));
            $response = $this->sendData($formatedData, $typePersona);

            if ($response->getErrors()) {
                foreach ($response->getErrors() as $error) {
                    $errors[] = $error;
                }
                $listErrors = implode(', ', $errors);

The variable $errors seems to be defined by a foreach iteration on line 142. Are you sure the iterator is never empty, otherwise this variable is not defined?

                $subSeller->setStatus('4');
                $subSeller->setStatusComment($listErrors);
                $subSeller->save();

The method save() does not exist on Getnet\SubSellerMagento\Api\Data\SubSellerInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Getnet\SubSellerMagento\Api\Data\SubSellerInterface.

                $messageErrors = __('Unable to register, errors found: %1', $listErrors);
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));

                return;
            }

            if ($response->getMessage()) {
                $errors[] = $response->getMessage();

$errors was never initialized. Although not strictly required by PHP, it is generally a good practice to add $errors = array(); before regardless.

                if (is_array($response->getMessage())) {
                    unset($errors);
                    foreach ($response->getMessage() as $key => $error) {
                        $errors[] = $error;
                        if (is_array($error)) {
                            unset($errors);
                            foreach ($error as $typeError) {
                                $errors[] = $typeError.' field '.$key;
                            }
                        }
                    }
                }
                $listErrors = implode(', ', $errors);
                $subSeller->setStatus('5');
                $subSeller->setStatusComment($listErrors);
                $subSeller->save();
                $messageErrors = __('Unable to register, errors found: %1', $listErrors);
                $this->writeln(sprintf('<error>%s</error>', $messageErrors));

                return;
            }

            if ($response->getSubsellerId()) {
                $subSeller->setIdExt($response->getSubsellerId());
                $subSeller->setStatus('2');
                $subSeller->setStatusComment('Waiting for registration approval.');

                if ($response->getEnabled() === 'S') {
                    $subSeller->setStatus('3');
                    $subSeller->setStatusComment('Authorized for sales.');
                }

                $subSeller->save();
                $messageResponse = __(
                    'Success, the sub seller id: %1, enable to sales: %2, id getnet: %3',
                    $response->getCode(),
                    $response->getEnabled(),
                    $response->getSubsellerId()
                );
                $this->writeln(sprintf('<info>%s</info>', $messageResponse));

                return;
            }

            $messageErrorConection = __('Connection Error: %1', $response->getDetails());
            $this->writeln(sprintf('<error>%s</error>', $messageErrorConection));

            return;
        }