getnet-adquirencia / payment-magento

Model/CardIdManagement.php

<?php
/**
 * Copyright © Getnet. All rights reserved.
 *
 * @author    Bruno Elisei <brunoelisei@o2ti.com>
 * See LICENSE for license details.
 */

declare(strict_types=1);

namespace Getnet\PaymentMagento\Model;

use Getnet\PaymentMagento\Api\CardIdManagementInterface;
use Getnet\PaymentMagento\Api\Data\CardIdInterface;
use Getnet\PaymentMagento\Gateway\Config\Config as ConfigBase;
use InvalidArgumentException;
use Magento\Framework\Exception\CouldNotSaveException;
use Magento\Framework\Exception\NoSuchEntityException;
use Magento\Framework\HTTP\ZendClient;
use Magento\Framework\HTTP\ZendClientFactory;

The type Magento\Framework\HTTP\ZendClientFactory was not found. Maybe you did not declare it correctly or list all dependencies?

use Magento\Framework\Serialize\Serializer\Json;
use Magento\Payment\Gateway\ConfigInterface;
use Magento\Payment\Model\Method\Logger;
use Magento\Quote\Api\CartRepositoryInterface;
use Magento\Quote\Api\Data\CartInterface as QuoteCartInterface;
use Magento\Vault\Model\PaymentTokenManagement;

/**
 * Class Card Id Management - Get Details Card Id.
 *
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class CardIdManagement implements CardIdManagementInterface
{
    /**
     * @var Logger
     */
    private $logger;

    /**
     * @var CartRepositoryInterface
     */
    protected $quoteRepository;

    /**
     * @var ConfigInterface
     */
    private $config;

    /**
     * @var ConfigBase
     */
    private $configBase;

    /**
     * @var ZendClientFactory
     */
    private $httpClientFactory;

    /**
     * @var Json
     */
    private $json;

    /**
     * @var PaymentTokenManagement
     */
    private $tokenManagement;

    /**
     * CardIdManagement constructor.
     *
     * @param Logger                  $logger
     * @param CartRepositoryInterface $quoteRepository
     * @param ConfigInterface         $config
     * @param ConfigBase              $configBase
     * @param ZendClientFactory       $httpClientFactory
     * @param Json                    $json
     * @param PaymentTokenManagement  $tokenManagement
     */
    public function __construct(
        Logger $logger,
        CartRepositoryInterface $quoteRepository,
        ConfigInterface $config,
        ConfigBase $configBase,
        ZendClientFactory $httpClientFactory,
        Json $json,
        PaymentTokenManagement $tokenManagement
    ) {
        $this->logger = $logger;
        $this->quoteRepository = $quoteRepository;
        $this->config = $config;
        $this->configBase = $configBase;
        $this->httpClientFactory = $httpClientFactory;
        $this->json = $json;
        $this->tokenManagement = $tokenManagement;
    }

    /**
     * Generate Number Token by Card Number.
     *
     * @param int                                             $cartId
     * @param \Getnet\PaymentMagento\Api\Data\CardIdInterface $cardId
     *
     * @throws CouldNotSaveException
     * @throws NoSuchEntityException
     *
     * @return array
     */
    public function getDetailsCardId(
        $cartId,
        CardIdInterface $cardId
    ) {
        $quote = $this->quoteRepository->getActive($cartId);
        if (!$quote->getItemsCount()) {

The expression $quote->getItemsCount() of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            throw new NoSuchEntityException(__('Cart %1 doesn\'t contain products', $cartId));
        }
        $data = [];

        $hash = $cardId->getCardId();

        $storeId = $quote->getData(QuoteCartInterface::KEY_STORE_ID);

        $customerId = $quote->getCustomer()->getId();

        /** @var PaymentTokenManagement $paymentToken */
        $paymentToken = $this->tokenManagement->getByPublicHash($hash, $customerId);

        $gatawayToken = $paymentToken->getGatewayToken();

The method getGatewayToken() does not exist on Magento\Vault\Model\PaymentTokenManagement. Did you maybe mean getByGatewayToken()?

        $data['details'] = $this->getCardId($storeId, $gatawayToken);

        return $data;

The expression return $data returns the type array which is incompatible with the return type mandated by Getnet\PaymentMagento\Api\CardIdManagementInterface::getDetailsCardId() of string.

    }

    /**
     * Get Number Token.
     *
     * @param int    $storeId
     * @param string $cardId
     *
     * @return array
     */
    public function getCardId($storeId, $cardId)
    {
        $client = $this->httpClientFactory->create();
        $url = $this->configBase->getApiUrl($storeId);
        $apiBearer = $this->configBase->getMerchantGatewayOauth($storeId);

        try {
            $client->setUri($url.'v1/cards/'.$cardId);
            $client->setConfig(['maxredirects' => 0, 'timeout' => 45000]);
            $client->setHeaders('Authorization', 'Bearer '.$apiBearer);
            $client->setMethod(ZendClient::GET);

            $responseBody = $client->request()->getBody();
            $data = $this->json->unserialize($responseBody);
            $response = [
                'success' => 0,
            ];
            if (isset($data['number_token'])) {
                $response = [
                    'success' => 1,
                    'card'    => $data,
                ];
            }
            $this->logger->debug(
                [
                    'url'      => $url.'v1/cards/'.$cardId,
                    'request'  => $cardId,
                    'response' => $responseBody,
                ]
            );
        } catch (InvalidArgumentException $e) {
            $this->logger->debug(
                [
                    'url'      => $url.'v1/cards/'.$cardId,
                    'request'  => $cardId,
                    'response' => $responseBody,
                ]
            );
            // phpcs:ignore Magento2.Exceptions.DirectThrow
            throw new NoSuchEntityException('Invalid JSON was returned by the gateway');

'Invalid JSON was returned by the gateway' of type string is incompatible with the type Magento\Framework\Phrase|null expected by parameter $phrase of Magento\Framework\Exception\NoSuchEntityException::__construct().

        }

        return $response;
    }
}