CreateVaultManagement::getVaultDetails() - Code Metrics - Inspection of "Merge pull request #12 from elisei/Magento@2.4" - getnet-adquirencia/payment-magento - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — [email protected] (8a736f)

by Bruno

created 2022-03-11 14:18 UTC

CreateVaultManagement::getVaultDetails() A

↳ Parent: CreateVaultManagement

Complexity

Conditions	4
Paths	26

Size

Total Lines	59
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	38
c	1
b	0
f	0
nc	26
nop	3
dl	0
loc	59
rs	9.312

How to fix Long Method

<?php
/**
 * Copyright © Getnet. All rights reserved.
 *
 * @author    Bruno Elisei <[email protected]>
 * See LICENSE for license details.
 */

declare(strict_types=1);

namespace Getnet\PaymentMagento\Model;

use Exception;
use Getnet\PaymentMagento\Api\CreateVaultManagementInterface;
use Getnet\PaymentMagento\Gateway\Config\Config as ConfigBase;
use Magento\Framework\Exception\CouldNotSaveException;
use Magento\Framework\Exception\NoSuchEntityException;
use Magento\Framework\HTTP\ZendClient;
use Magento\Framework\HTTP\ZendClientFactory;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\Serialize\Serializer\Json;
use Magento\Payment\Gateway\ConfigInterface;
use Magento\Payment\Model\Method\Logger;
use Magento\Quote\Api\CartRepositoryInterface;
use Magento\Quote\Api\Data\CartInterface as QuoteCartInterface;

/**
 * Class Create Vault Management - Generate number token by card number in API Cofre.
 *
 * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
 */
class CreateVaultManagement implements CreateVaultManagementInterface
{
    /**
     * @var Logger
     */
    private $logger;

    /**
     * @var CartRepositoryInterface
     */
    protected $quoteRepository;

    /**
     * @var ConfigInterface
     */
    private $config;

    /**
     * @var ConfigBase
     */
    private $configBase;

    /**
     * @var ZendClientFactory
     */
    private $httpClientFactory;

    /**
     * @var Json
     */
    private $json;

    /**
     * CreateVaultManagement constructor.
     *
     * @param Logger                  $logger
     * @param CartRepositoryInterface $quoteRepository
     * @param ConfigInterface         $config
     * @param ConfigBase              $configBase
     * @param ZendClientFactory       $httpClientFactory
     * @param Json                    $json
     */
    public function __construct(
        Logger $logger,
        CartRepositoryInterface $quoteRepository,
        ConfigInterface $config,
        ConfigBase $configBase,
        ZendClientFactory $httpClientFactory,
        Json $json
    ) {
        $this->logger = $logger;
        $this->quoteRepository = $quoteRepository;
        $this->config = $config;
        $this->configBase = $configBase;
        $this->httpClientFactory = $httpClientFactory;
        $this->json = $json;
    }

    /**
     * Create Vault Card Id.
     *
     * @param int   $cartId
     * @param array $vaultData
     *
     * @throws CouldNotSaveException
     * @throws NoSuchEntityException
     *
     * @return array
     */
    public function createVault(
        $cartId,
        $vaultData
    ) {
        $token = [];
        $quote = $this->quoteRepository->getActive($cartId);
        if (!$quote->getItemsCount()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            throw new NoSuchEntityException(__('Cart %1 doesn\'t contain products', $cartId));
        }

        $storeId = $quote->getData(QuoteCartInterface::KEY_STORE_ID);

        $numberToken = $this->getTokenCcNumber($storeId, $vaultData);

        if ($numberToken) {
            $vaultDetails = $this->getVaultDetails($storeId, $numberToken, $vaultData);
            $token['tokenize'] = $vaultDetails;
        }

        return $token;
    }

    /**
     * Get Token Cc Number.
     *
     * @param int   $storeId
     * @param array $vaultData
     *
     * @return null|string
     */
    public function getTokenCcNumber($storeId, $vaultData)
    {
        /** @var ZendClient $client */
        $client = $this->httpClientFactory->create();
        $request = ['card_number' => $vaultData['card_number']];
        $url = $this->configBase->getApiUrl($storeId);
        $apiBearer = $this->configBase->getMerchantGatewayOauth($storeId);
        $response = null;

        try {
            $client->setUri($url.'/v1/tokens/card');
            $client->setConfig(['maxredirects' => 0, 'timeout' => 45000]);
            $client->setHeaders('Authorization', 'Bearer '.$apiBearer);
            $client->setRawData($this->json->serialize($request), 'application/json');
            $client->setMethod(ZendClient::POST);

            $responseBody = $client->request()->getBody();
            $data = $this->json->unserialize($responseBody);

            if (isset($data['number_token'])) {
                $response = $data['number_token'];
            }
            $this->logger->debug(
                [
                    'url'      => $url.'v1/tokens/card',
                    'response' => $responseBody,
                ]
            );
        } catch (InvalidArgumentException $e) {

            $this->logger->debug(
                [
                    'url'      => $url.'v1/tokens/card',
                    'response' => $responseBody,
                ]
            );
            // phpcs:ignore Magento2.Exceptions.DirectThrow
            throw new Exception('Invalid JSON was returned by the gateway');
        }

        return $response;
    }

    /**
     * Get Vault Details.
     *
     * @param int    $storeId
     * @param string $numberToken
     * @param array  $vaultData
     *
     * @return array
     */
    public function getVaultDetails($storeId, $numberToken, $vaultData)
    {
        /** @var ZendClient $client */
        $client = $this->httpClientFactory->create();
        $url = $this->configBase->getApiUrl($storeId);
        $apiBearer = $this->configBase->getMerchantGatewayOauth($storeId);

        $month = $vaultData['expiration_month'];
        if (strlen($month) === 1) {
            $month = '0'.$month;
        }

        $request = [
            'number_token'      => $numberToken,
            'expiration_month'  => $month,
            'expiration_year'   => $vaultData['expiration_year'],
            'customer_id'       => $vaultData['customer_email'],
            'cardholder_name'   => $vaultData['cardholder_name'],
        ];

        try {
            $client->setUri($url.'/v1/cards');
            $client->setConfig(['maxredirects' => 0, 'timeout' => 45000]);
            $client->setHeaders('Authorization', 'Bearer '.$apiBearer);
            $client->setRawData($this->json->serialize($request), 'application/json');
            $client->setMethod(ZendClient::POST);

            $responseBody = $client->request()->getBody();
            $data = $this->json->unserialize($responseBody);
            $response = [
                'success' => 0,
            ];
            if (isset($data['card_id'])) {
                $response = [
                    'success'      => 1,
                    'card_id'      => $data['card_id'],
                    'number_token' => $data['number_token'],
                ];
            }
            $this->logger->debug(
                [
                    'url'      => $url.'v1/cards',
                    'request'  => $this->json->serialize($request),
                    'response' => $responseBody,
                ]
            );
        } catch (InvalidArgumentException $e) {
            $this->logger->debug(
                [
                    'url'      => $url.'v1/cards',
                    'request'  => $request,
                    'response' => $responseBody,
                ]
            );
            // phpcs:ignore Magento2.Exceptions.DirectThrow
            throw new Exception('Invalid JSON was returned by the gateway');
        }

        return $response;
    }
}


1			<?php
2			/**
3			* Copyright © Getnet. All rights reserved.
4			*
5			* @author Bruno Elisei <[email protected]>
6			* See LICENSE for license details.
7			*/
8
9			declare(strict_types=1);
10
11			namespace Getnet\PaymentMagento\Model;
12
13			use Exception;
14			use Getnet\PaymentMagento\Api\CreateVaultManagementInterface;
15			use Getnet\PaymentMagento\Gateway\Config\Config as ConfigBase;
16			use Magento\Framework\Exception\CouldNotSaveException;
17			use Magento\Framework\Exception\NoSuchEntityException;
18			use Magento\Framework\HTTP\ZendClient;
19			use Magento\Framework\HTTP\ZendClientFactory;
			0 ignored issues – show Bug introduced 2022-03-11 14:31 UTC by Report Bug Copy Issue Report The type `Magento\Framework\HTTP\ZendClientFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
20			use Magento\Framework\Serialize\Serializer\Json;
21			use Magento\Payment\Gateway\ConfigInterface;
22			use Magento\Payment\Model\Method\Logger;
23			use Magento\Quote\Api\CartRepositoryInterface;
24			use Magento\Quote\Api\Data\CartInterface as QuoteCartInterface;
25
26			/**
27			* Class Create Vault Management - Generate number token by card number in API Cofre.
28			*
29			* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
30			*/
31			class CreateVaultManagement implements CreateVaultManagementInterface
32			{
33			/**
34			* @var Logger
35			*/
36			private $logger;
37
38			/**
39			* @var CartRepositoryInterface
40			*/
41			protected $quoteRepository;
42
43			/**
44			* @var ConfigInterface
45			*/
46			private $config;
47
48			/**
49			* @var ConfigBase
50			*/
51			private $configBase;
52
53			/**
54			* @var ZendClientFactory
55			*/
56			private $httpClientFactory;
57
58			/**
59			* @var Json
60			*/
61			private $json;
62
63			/**
64			* CreateVaultManagement constructor.
65			*
66			* @param Logger $logger
67			* @param CartRepositoryInterface $quoteRepository
68			* @param ConfigInterface $config
69			* @param ConfigBase $configBase
70			* @param ZendClientFactory $httpClientFactory
71			* @param Json $json
72			*/
73			public function __construct(
74			Logger $logger,
75			CartRepositoryInterface $quoteRepository,
76			ConfigInterface $config,
77			ConfigBase $configBase,
78			ZendClientFactory $httpClientFactory,
79			Json $json
80			) {
81			$this->logger = $logger;
82			$this->quoteRepository = $quoteRepository;
83			$this->config = $config;
84			$this->configBase = $configBase;
85			$this->httpClientFactory = $httpClientFactory;
86			$this->json = $json;
87			}
88
89			/**
90			* Create Vault Card Id.
91			*
92			* @param int $cartId
93			* @param array $vaultData
94			*
95			* @throws CouldNotSaveException
96			* @throws NoSuchEntityException
97			*
98			* @return array
99			*/
100			public function createVault(
101			$cartId,
102			$vaultData
103			) {
104			$token = [];
105			$quote = $this->quoteRepository->getActive($cartId);
106			if (!$quote->getItemsCount()) {
			0 ignored issues – show Bug Best Practice introduced 2022-03-11 14:31 UTC by Report Bug Copy Issue Report The expression `$quote->getItemsCount()` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
107			throw new NoSuchEntityException(__('Cart %1 doesn\'t contain products', $cartId));
108			}
109
110			$storeId = $quote->getData(QuoteCartInterface::KEY_STORE_ID);
111
112			$numberToken = $this->getTokenCcNumber($storeId, $vaultData);
113
114			if ($numberToken) {
115			$vaultDetails = $this->getVaultDetails($storeId, $numberToken, $vaultData);
116			$token['tokenize'] = $vaultDetails;
117			}
118
119			return $token;
120			}
121
122			/**
123			* Get Token Cc Number.
124			*
125			* @param int $storeId
126			* @param array $vaultData
127			*
128			* @return null\|string
129			*/
130			public function getTokenCcNumber($storeId, $vaultData)
131			{
132			/** @var ZendClient $client */
133			$client = $this->httpClientFactory->create();
134			$request = ['card_number' => $vaultData['card_number']];
135			$url = $this->configBase->getApiUrl($storeId);
136			$apiBearer = $this->configBase->getMerchantGatewayOauth($storeId);
137			$response = null;
138
139			try {
140			$client->setUri($url.'/v1/tokens/card');
141			$client->setConfig(['maxredirects' => 0, 'timeout' => 45000]);
142			$client->setHeaders('Authorization', 'Bearer '.$apiBearer);
143			$client->setRawData($this->json->serialize($request), 'application/json');
144			$client->setMethod(ZendClient::POST);
145
146			$responseBody = $client->request()->getBody();
147			$data = $this->json->unserialize($responseBody);
148
149			if (isset($data['number_token'])) {
150			$response = $data['number_token'];
151			}
152			$this->logger->debug(
153			[
154			'url' => $url.'v1/tokens/card',
155			'response' => $responseBody,
156			]
157			);
158			} catch (InvalidArgumentException $e) {
			0 ignored issues – show Bug introduced 2022-02-03 18:41 UTC by Report Bug Copy Issue Report The type `Getnet\PaymentMagento\Mo...nvalidArgumentException` was not found. Did you mean `InvalidArgumentException`? If so, make sure to prefix the type with `\`. Loading history...
159			$this->logger->debug(
160			[
161			'url' => $url.'v1/tokens/card',
162			'response' => $responseBody,
163			]
164			);
165			// phpcs:ignore Magento2.Exceptions.DirectThrow
166			throw new Exception('Invalid JSON was returned by the gateway');
167			}
168
169			return $response;
170			}
171
172			/**
173			* Get Vault Details.
174			*
175			* @param int $storeId
176			* @param string $numberToken
177			* @param array $vaultData
178			*
179			* @return array
180			*/
181			public function getVaultDetails($storeId, $numberToken, $vaultData)
182			{
183			/** @var ZendClient $client */
184			$client = $this->httpClientFactory->create();
185			$url = $this->configBase->getApiUrl($storeId);
186			$apiBearer = $this->configBase->getMerchantGatewayOauth($storeId);
187
188			$month = $vaultData['expiration_month'];
189			if (strlen($month) === 1) {
190			$month = '0'.$month;
191			}
192
193			$request = [
194			'number_token' => $numberToken,
195			'expiration_month' => $month,
196			'expiration_year' => $vaultData['expiration_year'],
197			'customer_id' => $vaultData['customer_email'],
198			'cardholder_name' => $vaultData['cardholder_name'],
199			];
200
201			try {
202			$client->setUri($url.'/v1/cards');
203			$client->setConfig(['maxredirects' => 0, 'timeout' => 45000]);
204			$client->setHeaders('Authorization', 'Bearer '.$apiBearer);
205			$client->setRawData($this->json->serialize($request), 'application/json');
206			$client->setMethod(ZendClient::POST);
207
208			$responseBody = $client->request()->getBody();
209			$data = $this->json->unserialize($responseBody);
210			$response = [
211			'success' => 0,
212			];
213			if (isset($data['card_id'])) {
214			$response = [
215			'success' => 1,
216			'card_id' => $data['card_id'],
217			'number_token' => $data['number_token'],
218			];
219			}
220			$this->logger->debug(
221			[
222			'url' => $url.'v1/cards',
223			'request' => $this->json->serialize($request),
224			'response' => $responseBody,
225			]
226			);
227			} catch (InvalidArgumentException $e) {
228			$this->logger->debug(
229			[
230			'url' => $url.'v1/cards',
231			'request' => $request,
232			'response' => $responseBody,
233			]
234			);
235			// phpcs:ignore Magento2.Exceptions.DirectThrow
236			throw new Exception('Invalid JSON was returned by the gateway');
237			}
238
239			return $response;
240			}
241			}
242

getnet-adquirencia / payment-magento

Branch — [email protected] (8a736f)

CreateVaultManagement::getVaultDetails() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like