RefreshTokenAuthenticator::createToken() - Code Metrics - Inspection of "Add support for parameter naming strategies" - gesdinet/JWTRefreshTokenBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#81)

unknown

created 2017-12-12 16:48 UTC

RefreshTokenAuthenticator::createToken() A

↳ Parent: RefreshTokenAuthenticator

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
cc	1
eloc	6
nc	1
nop	2
crap	1

<?php

/*
 * This file is part of the GesdinetJWTRefreshTokenBundle package.
 *
 * (c) Gesdinet <http://www.gesdinet.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gesdinet\JWTRefreshTokenBundle\Security\Authenticator;

use Gesdinet\JWTRefreshTokenBundle\Request\RequestRefreshToken;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
use Symfony\Component\HttpFoundation\Response;
use Gesdinet\JWTRefreshTokenBundle\Security\Provider\RefreshTokenProvider;

if (interface_exists('Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface')) {
    abstract class RefreshTokenAuthenticatorBase implements \Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface
    {
    }
} else {
    abstract class RefreshTokenAuthenticatorBase implements \Symfony\Component\Security\Core\Authentication\SimplePreAuthenticatorInterface

    {
    }
}

/**
 * Class RefreshTokenAuthenticator.
 */
class RefreshTokenAuthenticator extends RefreshTokenAuthenticatorBase implements AuthenticationFailureHandlerInterface

{
    /**
     * @var RequestRefreshToken
     */
    private $requestRefreshToken;

    /**
     * Injects dependencies.
     *
     * @param RequestRefreshToken $requestRefreshToken
     */
    public function __construct(RequestRefreshToken $requestRefreshToken)
    {
        $this->requestRefreshToken = $requestRefreshToken;
    }

    public function createToken(Request $request, $providerKey)
    {
        $refreshTokenString = $this->requestRefreshToken->getRefreshToken($request);

        return new PreAuthenticatedToken(
            '',
            $refreshTokenString,
            $providerKey
        );
    }

    public function authenticateToken(TokenInterface $token, UserProviderInterface $userProvider, $providerKey)
    {
        if (!$userProvider instanceof RefreshTokenProvider) {
            throw new \InvalidArgumentException(
                sprintf(
                    'The user provider must be an instance of RefreshTokenProvider (%s was given).',
                    get_class($userProvider)
                )
            );
        }

        $refreshToken = $token->getCredentials();
        $username = $userProvider->getUsernameForRefreshToken($refreshToken);

        if (!$username) {
            throw new AuthenticationException(
                sprintf('Refresh token "%s" does not exist.', $refreshToken)
            );
        }

        $user = $userProvider->loadUserByUsername($username);

        return new PreAuthenticatedToken(
            $user,
            $refreshToken,
            $providerKey,
            $user->getRoles()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    public function supportsToken(TokenInterface $token, $providerKey)
    {
        return $token instanceof PreAuthenticatedToken && $token->getProviderKey() === $providerKey;
    }

    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
    {
        return new Response('Refresh token authentication failed.', 403);
    }
}


1		<?php
2
3		/*
4		* This file is part of the GesdinetJWTRefreshTokenBundle package.
5		*
6		* (c) Gesdinet <http://www.gesdinet.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gesdinet\JWTRefreshTokenBundle\Security\Authenticator;
13
14		use Gesdinet\JWTRefreshTokenBundle\Request\RequestRefreshToken;
15		use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
16		use Symfony\Component\Security\Core\Exception\AuthenticationException;
17		use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken;
18		use Symfony\Component\HttpFoundation\Request;
19		use Symfony\Component\Security\Core\User\UserProviderInterface;
20		use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
21		use Symfony\Component\HttpFoundation\Response;
22		use Gesdinet\JWTRefreshTokenBundle\Security\Provider\RefreshTokenProvider;
23
24	1	if (interface_exists('Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface')) {
25		abstract class RefreshTokenAuthenticatorBase implements \Symfony\Component\Security\Http\Authentication\SimplePreAuthenticatorInterface
26		{
27		}
28		} else {
29		abstract class RefreshTokenAuthenticatorBase implements \Symfony\Component\Security\Core\Authentication\SimplePreAuthenticatorInterface
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-04 10:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Comprehensibility Best Practice introduced 2016-03-15 10:52 UTC by Report Bug Copy Issue Report The type `Gesdinet\JWTRefreshToken...hTokenAuthenticatorBase` has been defined more than once; this definition is ignored, only the first definition in this file (L25-27) is considered. This check looks for classes that have been defined more than once in the same file. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history...
30		{
31		}
32		}
33
34		/**
35		* Class RefreshTokenAuthenticator.
36		*/
37		class RefreshTokenAuthenticator extends RefreshTokenAuthenticatorBase implements AuthenticationFailureHandlerInterface
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-04 10:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
38		{
39		/**
40		* @var RequestRefreshToken
41		*/
42		private $requestRefreshToken;
43
44		/**
45		* Injects dependencies.
46		*
47		* @param RequestRefreshToken $requestRefreshToken
48		*/
49	4	public function __construct(RequestRefreshToken $requestRefreshToken)
50		{
51	4	$this->requestRefreshToken = $requestRefreshToken;
52	4	}
53
54	1	public function createToken(Request $request, $providerKey)
55		{
56	1	$refreshTokenString = $this->requestRefreshToken->getRefreshToken($request);
57
58	1	return new PreAuthenticatedToken(
59	1	'',
60	1	$refreshTokenString,
61	1	$providerKey
62		);
63		}
64
65		public function authenticateToken(TokenInterface $token, UserProviderInterface $userProvider, $providerKey)
66		{
67		if (!$userProvider instanceof RefreshTokenProvider) {
68		throw new \InvalidArgumentException(
69		sprintf(
70		'The user provider must be an instance of RefreshTokenProvider (%s was given).',
71		get_class($userProvider)
72		)
73		);
74		}
75
76		$refreshToken = $token->getCredentials();
77		$username = $userProvider->getUsernameForRefreshToken($refreshToken);
78
79		if (!$username) {
80		throw new AuthenticationException(
81		sprintf('Refresh token "%s" does not exist.', $refreshToken)
82		);
83		}
84
85		$user = $userProvider->loadUserByUsername($username);
86
87		return new PreAuthenticatedToken(
88		$user,
89		$refreshToken,
90		$providerKey,
91		$user->getRoles()
		0 ignored issues – show Documentation introduced 2017-12-04 13:31 UTC by Report Bug Copy Issue Report `$user->getRoles()` is of type `array<integer,object<Sym...Core\Role\Role>\|string>`, but the function expects a `array<integer,object<Sym...ion\Token\Role>\|string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
92		);
93		}
94
95	1	public function supportsToken(TokenInterface $token, $providerKey)
96		{
97	1	return $token instanceof PreAuthenticatedToken && $token->getProviderKey() === $providerKey;
98		}
99
100	1	public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
101		{
102	1	return new Response('Refresh token authentication failed.', 403);
103		}
104		}
105

gesdinet / JWTRefreshTokenBundle

Pull Request — master (#81)

RefreshTokenAuthenticator::createToken() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like