geronimo-iia /
async-btree
| Conditions | 10 |
| Total Lines | 52 |
| Code Lines | 30 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like async_btree.analyze.analyze() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | """Analyze definition.""" |
||
| 30 | @no_type_check # it's a shortcut for hasattr ... |
||
| 31 | def analyze(target: CallableFunction) -> Node: |
||
| 32 | """Analyze specified target and return a Node representation. |
||
| 33 | |||
| 34 | # Parameters |
||
| 35 | - target (CallableFunction): async function to analyze |
||
| 36 | |||
| 37 | # Returns |
||
| 38 | (Node) a defintion |
||
| 39 | """ |
||
| 40 | |||
| 41 | nonlocals = getclosurevars(target).nonlocals |
||
| 42 | |||
| 43 | def _analyze_property(p): |
||
| 44 | """Return a tuple (name, value) or (name, function name) as property.""" |
||
| 45 | value = nonlocals[p] if p in nonlocals else None |
||
| 46 | return p, value.__name__ if value and callable(value) else value |
||
| 47 | |||
| 48 | def _analyze_edges(egde_name): |
||
| 49 | """Lookup children node from egde_name local var.""" |
||
| 50 | value = None |
||
| 51 | if egde_name in nonlocals and nonlocals[egde_name]: |
||
| 52 | edge = nonlocals[egde_name] |
||
| 53 | # it could be a collection of node |
||
| 54 | if hasattr(edge, "__iter__"): |
||
| 55 | value = list(map(analyze, edge)) |
||
| 56 | else: # or a single node |
||
| 57 | value = [analyze(edge)] |
||
| 58 | return (egde_name, value) |
||
| 59 | |||
| 60 | if hasattr(target, "__node_metadata"): |
||
| 61 | # its a node construct. |
||
| 62 | node = target.__node_metadata |
||
| 63 | if not isinstance(node, NodeMetadata): |
||
| 64 | raise RuntimeError( |
||
| 65 | f'attr __node_metadata of {target} is not a NodeMetadata!' |
||
| 66 | ) |
||
| 67 | return Node( |
||
| 68 | name=node.name, |
||
| 69 | properties=list(map(_analyze_property, node.properties)), |
||
| 70 | edges=list( |
||
| 71 | filter(lambda p: p is not None, map(_analyze_edges, node.edges)) |
||
| 72 | ), |
||
| 73 | ) |
||
| 74 | |||
| 75 | # simple function |
||
| 76 | return Node( |
||
| 77 | name=target.__name__.lstrip("_") |
||
| 78 | if hasattr(target, "__name__") |
||
| 79 | else "anonymous", |
||
| 80 | properties=list(map(_analyze_property, nonlocals.keys())), |
||
| 81 | edges=[], |
||
| 82 | ) |
||
| 102 |
