test_manager_one_route() - Code Metrics - Inspection of "Run by paremeters" - georgeyk/loafer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#15)

unknown

created 2016-06-27 18:01 UTC

test_manager_one_route() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285

# -*- coding: utf-8 -*-
# vi:si:et:sw=4:sts=4:ts=4

import asyncio
from unittest import mock

import pytest

from loafer.exceptions import ConfigurationError, ConsumerError
from loafer.dispatcher import LoaferDispatcher
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from loafer.manager import LoaferManager
from loafer.route import Route
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from loafer.aws.consumer import Consumer as AWSConsumer
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3


def test_manager_with_no_routes(event_loop):
    manager = LoaferManager('test-queue', event_loop=event_loop)
    assert len(manager.routes) == 0


def test_manager_one_route(event_loop):
    route = Route('test-queue', lambda x: None)
    manager = LoaferManager('test-queue', event_loop=event_loop)
    manager.routes.append(route)

    assert len(manager.routes) == 1


def test_routes_stop_manager_if_loop_is_running(event_loop):

    manager = LoaferManager('test-queue', event_loop=event_loop)
    manager.stop = mock.Mock()

    with mock.patch.object(event_loop, 'is_running', return_value=True):
        with pytest.raises(ConfigurationError):
            manager.routes
class SomeClass:
    def __init__(self):
        self._x = 5

    def squared(self):
        return self._x * self._x

some_class = SomeClass()
some_class.squared()        # Flagged, as the return value is not used
print(some_class.squared()) # Ok

        assert manager.stop.called
        assert manager.stop.called_once_with()


def test_consumers(event_loop):
    manager = LoaferManager('test-queue', event_loop=event_loop)
    assert manager.consumers
    assert len(manager.consumers) == 1


def test_consumers_returns_default_if_not_manually_set(event_loop):

    manager = LoaferManager('test-queue', event_loop=event_loop)
    assert manager.consumers[0].__class__ == AWSConsumer


def test_dispatcher(event_loop):
    manager = LoaferManager('test-queue', event_loop=event_loop)
    manager.get_dispatcher()
    assert manager._dispatcher
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
    assert isinstance(manager._dispatcher, LoaferDispatcher)
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent


def test_on_future_errors(event_loop):
    manager = LoaferManager('test-queue', event_loop=event_loop)
    manager.stop = mock.Mock()
    future = asyncio.Future()
    future.set_exception(ConsumerError)
    manager.on_future__errors(future)

    assert manager.stop.called
    assert manager.stop.called_once_with()


1			# -- coding: utf-8 --
2			# vi:si:et:sw=4:sts=4:ts=4
3
4			import asyncio
5			from unittest import mock
6
7			import pytest
8
9			from loafer.exceptions import ConfigurationError, ConsumerError
10			from loafer.dispatcher import LoaferDispatcher
			0 ignored issues – show Bug introduced 2016-04-20 00:12 UTC by Report Bug Copy Issue Report The name `dispatcher` does not seem to exist in module `loafer`. Loading history... Configuration introduced 2016-06-09 11:43 UTC by Report Bug Copy Issue Report Unable to import 'loafer.dispatcher' (invalid syntax (<string>, line 36)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
11			from loafer.manager import LoaferManager
12			from loafer.route import Route
			0 ignored issues – show Bug introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report The name `route` does not seem to exist in module `loafer`. Loading history... Configuration introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report Unable to import 'loafer.route' (invalid syntax (<string>, line 26)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
13
14			from loafer.aws.consumer import Consumer as AWSConsumer
			0 ignored issues – show Bug introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report The name `consumer` does not seem to exist in module `loafer.aws`. Loading history... Configuration introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report Unable to import 'loafer.aws.consumer' (invalid syntax (<string>, line 28)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
15
16
17			def test_manager_with_no_routes(event_loop):
18			manager = LoaferManager('test-queue', event_loop=event_loop)
19			assert len(manager.routes) == 0
20
21
22			def test_manager_one_route(event_loop):
23			route = Route('test-queue', lambda x: None)
24			manager = LoaferManager('test-queue', event_loop=event_loop)
25			manager.routes.append(route)
26
27			assert len(manager.routes) == 1
28
29
30			def test_routes_stop_manager_if_loop_is_running(event_loop):
			0 ignored issues – show Coding Style Naming introduced 2016-04-20 00:12 UTC by Report Bug Copy Issue Report The name `test_routes_stop_manager_if_loop_is_running` does not conform to the function naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
31			manager = LoaferManager('test-queue', event_loop=event_loop)
32			manager.stop = mock.Mock()
33
34			with mock.patch.object(event_loop, 'is_running', return_value=True):
35			with pytest.raises(ConfigurationError):
36			manager.routes
			0 ignored issues – show Unused Code introduced 2016-04-20 00:12 UTC by Report Bug Copy Issue Report This statement seems to have no effect and could be removed. This issue is typically triggered when a function that does not have side-effects is called and the return value is discarded: class SomeClass: def __init__(self): self._x = 5 def squared(self): return self._x * self._x some_class = SomeClass() some_class.squared() # Flagged, as the return value is not used print(some_class.squared()) # Ok Loading history...
37
38			assert manager.stop.called
39			assert manager.stop.called_once_with()
40
41
42			def test_consumers(event_loop):
43			manager = LoaferManager('test-queue', event_loop=event_loop)
44			assert manager.consumers
45			assert len(manager.consumers) == 1
46
47
48			def test_consumers_returns_default_if_not_manually_set(event_loop):
			0 ignored issues – show Coding Style Naming introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report The name `test_consumers_returns_default_if_not_manually_set` does not conform to the function naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
49			manager = LoaferManager('test-queue', event_loop=event_loop)
50			assert manager.consumers[0].__class__ == AWSConsumer
51
52
53			def test_dispatcher(event_loop):
54			manager = LoaferManager('test-queue', event_loop=event_loop)
55			manager.get_dispatcher()
56			assert manager._dispatcher
			0 ignored issues – show Coding Style Best Practice introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report It seems like `_dispatcher` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
57			assert isinstance(manager._dispatcher, LoaferDispatcher)
			0 ignored issues – show Coding Style Best Practice introduced 2016-06-27 18:03 UTC by Report Bug Copy Issue Report It seems like `_dispatcher` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
58
59
60			def test_on_future_errors(event_loop):
61			manager = LoaferManager('test-queue', event_loop=event_loop)
62			manager.stop = mock.Mock()
63			future = asyncio.Future()
64			future.set_exception(ConsumerError)
65			manager.on_future__errors(future)
66
67			assert manager.stop.called
68			assert manager.stop.called_once_with()
69

Pull Request — master (#15)

test_manager_one_route() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

georgeyk / loafer

Pull Request — master (#15)

test_manager_one_route() A

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files