SNSMessageTranslator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

1 Method

Rating	Name	Duplication	Size	Complexity
A	translate()	0	13	3

# -*- coding: utf-8 -*-
# vi:si:et:sw=4:sts=4:ts=4

import json
import logging

logger = logging.getLogger(__name__)

The name logger does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

class SQSMessageTranslator(object):

    def translate(self, message):

This method could be written as a function/class method.

        try:
            body = message['Body']
        except (KeyError, TypeError):
            logger.error('Missing Body key in SQS message. It really came from SQS ?')
            return {'content': None}

        try:
            return {'content': json.loads(body)}
        except json.decoder.JSONDecodeError as exc:

The Module json.decoder does not seem to have a member named JSONDecodeError.

            logger.exception(exc)
            return {'content': None}


class SNSMessageTranslator(object):
    def translate(self, message):

This method could be written as a function/class method.

        try:
            body = json.loads(message['Body'])
            message = body['Message']
        except (KeyError, TypeError):
            logger.error('Missing Body or Message key in SQS message. It really came from SNS ?')
            return {'content': None}

        try:
            return {'content': json.loads(message)}
        except (json.decoder.JSONDecodeError, TypeError) as exc:

The Module json.decoder does not seem to have a member named JSONDecodeError.

            logger.exception(exc)
            return {'content': None}