$locations was never initialized. Although not strictly required by PHP, it is generally a good practice to add $locations = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
106
3
'providedBy' => $this->getName(),
107
3
'latitude' => $data['latitude'] ?: null,
108
3
'longitude' => $data['longitude'] ?: null,
109
3
'locality' => $data['city'] ?: null,
110
3
'postalCode' => $data['zip'] ?: null,
111
3
'country' => $data['country_name'] ?: null,
112
3
'countryCode' => $data['country_code'] ?: null,
113
]);
114
115
3
return new AddressCollection($locations);
116
}
117
118
/**
119
* {@inheritdoc}
120
*/
121
1
public function reverseQuery(ReverseQuery $query): Collection
122
{
123
1
throw new UnsupportedOperation('The Ipstack provider is not able to do reverse geocoding.');
geocoder-php /
ipstack-provider
Jonas Gielen
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.