Issues in StatefulGeocoder.php (master) - Issues in master - geocoder-php/Geocoder - Measure and Improve Code Quality continuously with Scrutinizer

Issues (153)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Common/StatefulGeocoder.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of the Geocoder package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license    MIT License
 */

namespace Geocoder;

use Geocoder\Model\Bounds;
use Geocoder\Query\GeocodeQuery;
use Geocoder\Query\ReverseQuery;
use Geocoder\Provider\Provider;

/**
 * @author Tobias Nyholm <[email protected]>
 */
final class StatefulGeocoder implements Geocoder
{
    /**
     * @var string
     */
    private $locale;

    /**
     * @var Bounds
     */
    private $bounds;

    /**
     * @var int
     */
    private $limit;

    /**
     * @var Provider
     */
    private $provider;

    /**
     * @param Provider $provider
     * @param string   $locale

     */
    public function __construct(Provider $provider, string $locale = null)
    {
        $this->provider = $provider;
        $this->locale = $locale;
        $this->limit = Geocoder::DEFAULT_RESULT_LIMIT;
    }

    /**
     * {@inheritdoc}
     */
    public function geocode(string $value): Collection
    {
        $query = GeocodeQuery::create($value)
            ->withLimit($this->limit);

        if (!empty($this->locale)) {
            $query = $query->withLocale($this->locale);
        }

        if (!empty($this->bounds)) {
            $query = $query->withBounds($this->bounds);
        }

        return $this->provider->geocodeQuery($query);
    }

    /**
     * {@inheritdoc}
     */
    public function reverse(float $latitude, float $longitude): Collection
    {
        $query = ReverseQuery::fromCoordinates($latitude, $longitude)
            ->withLimit($this->limit);

        if (!empty($this->locale)) {
            $query = $query->withLocale($this->locale);
        }

        return $this->provider->reverseQuery($query);
    }

    /**
     * {@inheritdoc}
     */
    public function geocodeQuery(GeocodeQuery $query): Collection
    {
        $locale = $query->getLocale();
        if (empty($locale) && null !== $this->locale) {
            $query = $query->withLocale($this->locale);
        }

        $bounds = $query->getBounds();
        if (empty($bounds) && null !== $this->bounds) {
            $query = $query->withBounds($this->bounds);
        }

        return $this->provider->geocodeQuery($query);
    }

    /**
     * {@inheritdoc}
     */
    public function reverseQuery(ReverseQuery $query): Collection
    {
        $locale = $query->getLocale();
        if (empty($locale) && null !== $this->locale) {
            $query = $query->withLocale($this->locale);
        }

        return $this->provider->reverseQuery($query);
    }

    /**
     * @param string $locale
     *
     * @return StatefulGeocoder
     */
    public function setLocale(string $locale): self
    {
        $this->locale = $locale;

        return $this;
    }

    /**
     * @param Bounds $bounds
     *
     * @return StatefulGeocoder
     */
    public function setBounds(Bounds $bounds): self
    {
        $this->bounds = $bounds;

        return $this;
    }

    /**
     * @param int $limit
     *
     * @return StatefulGeocoder
     */
    public function setLimit(int $limit): self
    {
        $this->limit = $limit;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getName(): string
    {
        return 'stateful_geocoder';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Geocoder package.
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @license MIT License
11			*/
12
13			namespace Geocoder;
14
15			use Geocoder\Model\Bounds;
16			use Geocoder\Query\GeocodeQuery;
17			use Geocoder\Query\ReverseQuery;
18			use Geocoder\Provider\Provider;
19
20			/**
21			* @author Tobias Nyholm <[email protected]>
22			*/
23			final class StatefulGeocoder implements Geocoder
24			{
25			/**
26			* @var string
27			*/
28			private $locale;
29
30			/**
31			* @var Bounds
32			*/
33			private $bounds;
34
35			/**
36			* @var int
37			*/
38			private $limit;
39
40			/**
41			* @var Provider
42			*/
43			private $provider;
44
45			/**
46			* @param Provider $provider
47			* @param string $locale
			0 ignored issues – show Documentation introduced 2017-06-17 19:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$locale` not be `null\|string`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
48			*/
49			public function __construct(Provider $provider, string $locale = null)
50			{
51			$this->provider = $provider;
52			$this->locale = $locale;
53			$this->limit = Geocoder::DEFAULT_RESULT_LIMIT;
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function geocode(string $value): Collection
60			{
61			$query = GeocodeQuery::create($value)
62			->withLimit($this->limit);
63
64			if (!empty($this->locale)) {
65			$query = $query->withLocale($this->locale);
66			}
67
68			if (!empty($this->bounds)) {
69			$query = $query->withBounds($this->bounds);
70			}
71
72			return $this->provider->geocodeQuery($query);
73			}
74
75			/**
76			* {@inheritdoc}
77			*/
78			public function reverse(float $latitude, float $longitude): Collection
79			{
80			$query = ReverseQuery::fromCoordinates($latitude, $longitude)
81			->withLimit($this->limit);
82
83			if (!empty($this->locale)) {
84			$query = $query->withLocale($this->locale);
85			}
86
87			return $this->provider->reverseQuery($query);
88			}
89
90			/**
91			* {@inheritdoc}
92			*/
93			public function geocodeQuery(GeocodeQuery $query): Collection
94			{
95			$locale = $query->getLocale();
96			if (empty($locale) && null !== $this->locale) {
97			$query = $query->withLocale($this->locale);
98			}
99
100			$bounds = $query->getBounds();
101			if (empty($bounds) && null !== $this->bounds) {
102			$query = $query->withBounds($this->bounds);
103			}
104
105			return $this->provider->geocodeQuery($query);
106			}
107
108			/**
109			* {@inheritdoc}
110			*/
111			public function reverseQuery(ReverseQuery $query): Collection
112			{
113			$locale = $query->getLocale();
114			if (empty($locale) && null !== $this->locale) {
115			$query = $query->withLocale($this->locale);
116			}
117
118			return $this->provider->reverseQuery($query);
119			}
120
121			/**
122			* @param string $locale
123			*
124			* @return StatefulGeocoder
125			*/
126			public function setLocale(string $locale): self
127			{
128			$this->locale = $locale;
129
130			return $this;
131			}
132
133			/**
134			* @param Bounds $bounds
135			*
136			* @return StatefulGeocoder
137			*/
138			public function setBounds(Bounds $bounds): self
139			{
140			$this->bounds = $bounds;
141
142			return $this;
143			}
144
145			/**
146			* @param int $limit
147			*
148			* @return StatefulGeocoder
149			*/
150			public function setLimit(int $limit): self
151			{
152			$this->limit = $limit;
153
154			return $this;
155			}
156
157			/**
158			* {@inheritdoc}
159			*/
160			public function getName(): string
161			{
162			return 'stateful_geocoder';
163			}
164			}
165

GitHub Access Token became invalid

Issues (153)

Security Analysis no request data

src/Common/StatefulGeocoder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

geocoder-php / Geocoder

GitHub Access Token became invalid

Issues (153)

Security Analysis no request data

src/Common/StatefulGeocoder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like