LoggerPluginTest::testPluginException() - Code Metrics - Inspection of "Adding Plugin support (#742)" - geocoder-php/Geocoder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0e03a...4af0c2 )

by Tobias

created 2017-08-01 08:30 UTC

LoggerPluginTest::testPluginException() B

↳ Parent: LoggerPluginTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	27
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	22
nc	1
nop	0

<?php

declare(strict_types=1);

/*
 * This file is part of the Geocoder package.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license    MIT License
 */

namespace Geocoder\Plugin\Tests\Plugin;

use Geocoder\Exception\QuotaExceeded;
use Geocoder\Model\AddressCollection;
use Geocoder\Plugin\Plugin\LoggerPlugin;
use Geocoder\Plugin\PluginProvider;
use Geocoder\Provider\Provider;
use Geocoder\Query\GeocodeQuery;
use PHPUnit\Framework\TestCase;
use Psr\Log\AbstractLogger;

class LoggerPluginTest extends TestCase
{
    public function testPlugin()
    {
        $logger = $this->getMockBuilder(AbstractLogger::class)
            ->disableOriginalConstructor()
            ->setMethods(['log'])
            ->getMock();
        $logger->expects($this->once())
            ->method('log')
            ->with('info', $this->callback(function ($message) {
                return false !== strstr($message, 'Got 0 results');
            }));

        $geocodeQuery = GeocodeQuery::create('foo');
        $collection = new AddressCollection([]);

        $provider = $this->getMockBuilder(Provider::class)
            ->disableOriginalConstructor()
            ->setMethods(['geocodeQuery', 'reverseQuery', 'getName'])
            ->getMock();
        $provider->expects($this->once())
            ->method('geocodeQuery')
            ->with($geocodeQuery)
            ->willReturn($collection);
        $provider->expects($this->never())->method('reverseQuery');
        $provider->expects($this->never())->method('getName');

        $pluginProvider = new PluginProvider($provider, [new LoggerPlugin($logger)]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($collection, $pluginProvider->geocodeQuery($geocodeQuery));
    }

    public function testPluginException()
    {
        $this->expectException(QuotaExceeded::class);
        $logger = $this->getMockBuilder(AbstractLogger::class)
            ->disableOriginalConstructor()
            ->setMethods(['log'])
            ->getMock();
        $logger->expects($this->once())
            ->method('log')
            ->with('error', $this->callback(function ($message) {
                return false !== strstr($message, 'QuotaExceeded');
            }));

        $geocodeQuery = GeocodeQuery::create('foo');
        $provider = $this->getMockBuilder(Provider::class)
            ->disableOriginalConstructor()
            ->setMethods(['geocodeQuery', 'reverseQuery', 'getName'])
            ->getMock();
        $provider->expects($this->once())
            ->method('geocodeQuery')
            ->willThrowException(new QuotaExceeded());
        $provider->expects($this->never())->method('reverseQuery');
        $provider->expects($this->never())->method('getName');

        $pluginProvider = new PluginProvider($provider, [new LoggerPlugin($logger)]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $pluginProvider->geocodeQuery($geocodeQuery);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Geocoder package.
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @license MIT License
11			*/
12
13			namespace Geocoder\Plugin\Tests\Plugin;
14
15			use Geocoder\Exception\QuotaExceeded;
16			use Geocoder\Model\AddressCollection;
17			use Geocoder\Plugin\Plugin\LoggerPlugin;
18			use Geocoder\Plugin\PluginProvider;
19			use Geocoder\Provider\Provider;
20			use Geocoder\Query\GeocodeQuery;
21			use PHPUnit\Framework\TestCase;
22			use Psr\Log\AbstractLogger;
23
24			class LoggerPluginTest extends TestCase
25			{
26			public function testPlugin()
27			{
28			$logger = $this->getMockBuilder(AbstractLogger::class)
29			->disableOriginalConstructor()
30			->setMethods(['log'])
31			->getMock();
32			$logger->expects($this->once())
33			->method('log')
34			->with('info', $this->callback(function ($message) {
35			return false !== strstr($message, 'Got 0 results');
36			}));
37
38			$geocodeQuery = GeocodeQuery::create('foo');
39			$collection = new AddressCollection([]);
40
41			$provider = $this->getMockBuilder(Provider::class)
42			->disableOriginalConstructor()
43			->setMethods(['geocodeQuery', 'reverseQuery', 'getName'])
44			->getMock();
45			$provider->expects($this->once())
46			->method('geocodeQuery')
47			->with($geocodeQuery)
48			->willReturn($collection);
49			$provider->expects($this->never())->method('reverseQuery');
50			$provider->expects($this->never())->method('getName');
51
52			$pluginProvider = new PluginProvider($provider, [new LoggerPlugin($logger)]);
			0 ignored issues – show Documentation introduced 2017-07-15 12:34 UTC by Report Bug Copy Issue Report `array(new \Geocoder\Plug...\LoggerPlugin($logger))` is of type `array<integer,object<Geo...lugin\\LoggerPlugin>"}>`, but the function expects a `array<integer,object<Geocoder\Plugin\Plugin>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			$this->assertSame($collection, $pluginProvider->geocodeQuery($geocodeQuery));
54			}
55
56			public function testPluginException()
57			{
58			$this->expectException(QuotaExceeded::class);
59			$logger = $this->getMockBuilder(AbstractLogger::class)
60			->disableOriginalConstructor()
61			->setMethods(['log'])
62			->getMock();
63			$logger->expects($this->once())
64			->method('log')
65			->with('error', $this->callback(function ($message) {
66			return false !== strstr($message, 'QuotaExceeded');
67			}));
68
69			$geocodeQuery = GeocodeQuery::create('foo');
70			$provider = $this->getMockBuilder(Provider::class)
71			->disableOriginalConstructor()
72			->setMethods(['geocodeQuery', 'reverseQuery', 'getName'])
73			->getMock();
74			$provider->expects($this->once())
75			->method('geocodeQuery')
76			->willThrowException(new QuotaExceeded());
77			$provider->expects($this->never())->method('reverseQuery');
78			$provider->expects($this->never())->method('getName');
79
80			$pluginProvider = new PluginProvider($provider, [new LoggerPlugin($logger)]);
			0 ignored issues – show Documentation introduced 2017-07-15 12:34 UTC by Report Bug Copy Issue Report `array(new \Geocoder\Plug...\LoggerPlugin($logger))` is of type `array<integer,object<Geo...lugin\\LoggerPlugin>"}>`, but the function expects a `array<integer,object<Geocoder\Plugin\Plugin>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			$pluginProvider->geocodeQuery($geocodeQuery);
82			}
83			}
84

geocoder-php / Geocoder

GitHub Access Token became invalid

Push — master ( b0e03a...4af0c2 )

LoggerPluginTest::testPluginException() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like