geobase /
php-countries
| Conditions | 11 |
| Paths | 9 |
| Total Lines | 25 |
| Code Lines | 16 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 6 |
| CRAP Score | 37.1359 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | 1 | public function get($key) |
|
| 21 | { |
||
| 22 | 1 | if (isset($this->elements[$key])) { |
|
| 23 | return $this->elements[$key]; |
||
| 24 | } else { |
||
| 25 | 1 | if (is_string($key)) { |
|
| 26 | 1 | foreach ($this->elements as $element) { |
|
| 27 | 1 | if (is_string($element->getLanguage()) && $key === $element->getLanguage()) { |
|
| 28 | 1 | return $element; |
|
| 29 | } elseif ( |
||
| 30 | $element->getLanguage() instanceof LanguageEntity && |
||
| 31 | $key === $element->getLanguage()->getCode() |
||
| 32 | ) { |
||
| 33 | return $element; |
||
| 34 | } |
||
| 35 | } |
||
| 36 | } elseif ($key instanceof LanguageEntity) { |
||
| 37 | foreach ($this->elements as $element) { |
||
| 38 | if ($key === $element->getLanguage()) { |
||
| 39 | return $element; |
||
| 40 | } |
||
| 41 | } |
||
| 42 | } |
||
| 43 | } |
||
| 44 | } |
||
| 45 | } |
||
| 46 |
