GeoBase\Countries\CountryRepository

Complexity

Total Complexity

9

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

89.47%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	findAll()	0	8	2
A	findByShortCode()	0	13	3
A	getLoader()	0	8	2
A	getMapper()	0	8	2

<?php

namespace GeoBase\Countries;

use GeoBase\Countries\Country\CountryLoader;
use GeoBase\Countries\Country\CountryMapper;

class CountryRepository
{
    /**
     * @var CountryCollection
     */
    private static $collection;

    /**
     * @var CountryEntity[]
     */
    private static $items = [];

    /**
     * @var CountryMapper
     */
    private static $mapper;

    /**
     * @var CountryLoader
     */
    private static $loader;

    /**
     * @return CountryCollection
     */
    public static function findAll()
    {
        if (null === self::$collection) {
            self::$collection = self::getMapper()->mapArrayToCollection(self::getLoader()->loadAllCountries());

It seems like self::getMapper()->mapArrayToCollection(self::getLoader()->loadAllCountries()) of type object<GeoBase\Countries\Country\CountryCollection> is incompatible with the declared type object<GeoBase\Countries\CountryCollection> of property $collection.

        }

        return self::$collection;

The expression self::$collection; of type GeoBase\Countries\Country\CountryCollection|GeoBase\Countries\CountryCollection adds the type GeoBase\Countries\Country\CountryCollection to the return on line 39 which is incompatible with the return type documented by GeoBase\Countries\CountryRepository::findAll of type GeoBase\Countries\CountryCollection.

    }

    /**
     * @param string $shortCode
     *
     * @return null|CountryEntity
     */
    public static function findByShortCode($shortCode)
    {
        if (!isset(self::$items[$shortCode])) {
            $country = self::getLoader()->loadCountry($shortCode);
            if (!$country) {

The expression $country of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

                return;
            }

            return self::$items[$shortCode] = self::getMapper()->mapArrayToEntity($country);
        }

        return self::$items[$shortCode];
    }

    /**
     * @return CountryLoader
     */
    private static function getLoader()
    {
        if (null === self::$loader) {
            self::$loader = new CountryLoader();
        }

        return self::$loader;
    }

    /**
     * @return CountryMapper
     */
    private static function getMapper()
    {
        if (null === self::$mapper) {
            self::$mapper = new CountryMapper();
        }

        return self::$mapper;
    }
}