CountryEntity - Code Metrics - geobase/php-countries - Measure and Improve Code Quality continuously with Scrutinizer

CountryEntity B
last analyzed 2017-03-06 21:53 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	551
Duplicated Lines	2 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

50.74%

Importance

Changes

Metric	Value
wmc	44
lcom	1
cbo	6
dl	11
loc	551
ccs	68
cts	134
cp	0.5074
rs	8.3396
c	0
b	0
f	0

44 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	toArray()	0	20	1
A	jsonSerialize()	0	4	1
A	getCoordinate()	0	4	1
A	setCoordinate()	0	6	1
A	getBoundingBox()	0	4	1
A	setBoundingBox()	0	6	1
A	getRegions()	0	4	1
A	setRegions()	0	6	1
A	getPolygon()	0	4	1
A	setPolygon()	0	6	1
A	getNames()	0	4	1
A	setNames()	0	6	1
A	getShortCode()	0	4	1
A	setShortCode()	0	6	1
A	getCode()	0	4	1
A	setCode()	0	6	1
A	getLatitude()	0	4	1
A	setLatitude()	0	7	1
A	getLongitude()	0	4	1
A	setLongitude()	0	7	1
A	getCurrency()	0	4	1
A	setCurrency()	0	6	1
A	getContinent()	0	4	1
A	setContinent()	0	6	1
A	getPopulation()	0	4	1
A	setPopulation()	0	6	1
A	getArea()	0	4	1
A	setArea()	0	6	1
A	getCapital()	0	4	1
A	setCapital()	0	6	1
A	getTimezone()	0	4	1
A	setTimezone()	0	6	1
A	getNorth()	0	4	1
A	setNorth()	0	7	1
A	getEast()	0	4	1
A	setEast()	0	7	1
A	getSouth()	0	4	1
A	setSouth()	0	7	1
A	getWest()	0	4	1
A	setWest()	0	7	1
A	normalizeLatitude()	0	4	1
A	normalizeLongitude()	0	4	1
A	getEllipsoid()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like CountryEntity often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use CountryEntity, and based on these observations, apply Extract Interface, too.

<?php

namespace GeoBase\Countries\Country;

use GeoBase\Countries\Coordinate\CoordinateCollectionInterface;
use GeoBase\Countries\Coordinate\CoordinateLogic;
use GeoBase\Countries\Country\CountryName\CountryNameCollection;
use GeoBase\Regions\Region\RegionCollection;
use JsonSerializable;
use League\Geotools\BoundingBox\BoundingBox;
use League\Geotools\Coordinate\Coordinate;
use League\Geotools\Polygon\Polygon;

class CountryEntity extends CoordinateLogic implements JsonSerializable, CoordinateCollectionInterface
{
    /**
     * @var Coordinate
     */
    protected $coordinate;

    /**
     * @var BoundingBox
     */
    protected $boundingBox;

    /**
     * @var RegionCollection
     */
    protected $regions;

    /**
     * @var Polygon
     */
    protected $polygon;

    /**
     * @var CountryNameCollection
     */
    protected $names;

    /**
     * @var string
     */
    protected $shortCode;

    /**
     * @var string
     */
    protected $code;

    /**
     * @var string
     */
    protected $latitude;

    /**
     * @var string
     */
    protected $longitude;

    /**
     * @var string
     */
    protected $currency;

    /**
     * @var string
     */
    protected $continent;

    /**
     * @var string
     */
    protected $population;

    /**
     * @var string
     */
    protected $area;

    /**
     * @var string
     */
    protected $capital;

    /**
     * @var string
     */
    protected $timezone;

    /**
     * @var string
     */
    protected $north;

    /**
     * @var string
     */
    protected $east;

    /**
     * @var string
     */
    protected $south;

    /**
     * @var string
     */
    protected $west;

    public function __construct()

    {
        $this->boundingBox = new BoundingBox();
        $this->regions = new RegionCollection();
        $this->polygon = new Polygon();
        $this->coordinate = new Coordinate([
            $this->latitude,
            $this->longitude,
        ]);
        $this->setNames(new CountryNameCollection());
    }

    /**
     * @return array
     */
    public function toArray()
    {
        return [
            'names'      => $this->getNames(),
            'short_code' => $this->getShortCode(),
            'code'       => $this->getCode(),
            'latitude'   => $this->getLatitude(),
            'longitude'  => $this->getLongitude(),
            'currency'   => $this->getCurrency(),
            'continent'  => $this->getContinent(),
            'population' => $this->getPopulation(),
            'area'       => $this->getArea(),
            'capital'    => $this->getCapital(),
            'timezone'   => $this->getTimezone(),
            'north'      => $this->getNorth(),
            'east'       => $this->getEast(),
            'south'      => $this->getSouth(),
            'west'       => $this->getWest(),
        ];
    }

    /**
     * @return array
     */
    public function jsonSerialize()
    {
        return $this->toArray();
    }

    /**
     * @return Coordinate
     */
    public function getCoordinate()
    {
        return $this->coordinate;
    }

    /**
     * @param Coordinate $coordinate
     *
     * @return $this
     */
    public function setCoordinate(Coordinate $coordinate)
    {
        $this->coordinate = $coordinate;

        return $this;
    }

    /**
     * @return BoundingBox
     */
    public function getBoundingBox()
    {
        return $this->boundingBox;
    }

    /**
     * @param BoundingBox $boundingBox
     *
     * @return $this
     */
    public function setBoundingBox(BoundingBox $boundingBox)
    {
        $this->boundingBox = $boundingBox;

        return $this;
    }

    /**
     * @return RegionCollection
     */
    public function getRegions()
    {
        return $this->regions;
    }

    /**
     * @param RegionCollection $regions
     *
     * @return $this
     */
    public function setRegions(RegionCollection $regions)
    {
        $this->regions = $regions;

        return $this;
    }

    /**
     * @return Polygon
     */
    public function getPolygon()
    {
        return $this->polygon;
    }

    /**
     * @param Polygon $polygon
     *
     * @return $this
     */
    public function setPolygon(Polygon $polygon)
    {
        $this->polygon = $polygon;

        return $this;
    }

    /**
     * @return CountryNameCollection
     */
    public function getNames()
    {
        return $this->names;
    }

    /**
     * @param CountryNameCollection $names
     *
     * @return $this
     */
    public function setNames(CountryNameCollection $names)
    {
        $this->names = $names;

        return $this;
    }

    /**
     * @return string
     */
    public function getShortCode()
    {
        return $this->shortCode;
    }

    /**
     * @param string $shortCode
     *
     * @return $this
     */
    public function setShortCode($shortCode)
    {
        $this->shortCode = $shortCode;

        return $this;
    }

    /**
     * @return string
     */
    public function getCode()
    {
        return $this->code;
    }

    /**
     * @param string $code
     *
     * @return $this
     */
    public function setCode($code)
    {
        $this->code = $code;

        return $this;
    }

    /**
     * @return string
     */
    public function getLatitude()
    {
        return $this->latitude;
    }

    /**
     * @param string $latitude
     *
     * @return $this
     */
    public function setLatitude($latitude)
    {
        $this->getCoordinate()->setLatitude($latitude);
        $this->latitude = $latitude;

        return $this;
    }

    /**
     * @return string
     */
    public function getLongitude()
    {
        return $this->longitude;
    }

    /**
     * @param string $longitude
     *
     * @return $this
     */
    public function setLongitude($longitude)
    {
        $this->getCoordinate()->setLongitude($longitude);
        $this->longitude = $longitude;

        return $this;
    }

    /**
     * @return string
     */
    public function getCurrency()
    {
        return $this->currency;
    }

    /**
     * @param string $currency
     *
     * @return $this
     */
    public function setCurrency($currency)
    {
        $this->currency = $currency;

        return $this;
    }

    /**
     * @return string
     */
    public function getContinent()
    {
        return $this->continent;
    }

    /**
     * @param string $continent
     *
     * @return $this
     */
    public function setContinent($continent)
    {
        $this->continent = $continent;

        return $this;
    }

    /**
     * @return string
     */
    public function getPopulation()
    {
        return $this->population;
    }

    /**
     * @param string $population
     *
     * @return $this
     */
    public function setPopulation($population)
    {
        $this->population = $population;

        return $this;
    }

    /**
     * @return string
     */
    public function getArea()
    {
        return $this->area;
    }

    /**
     * @param string $area
     *
     * @return $this
     */
    public function setArea($area)
    {
        $this->area = $area;

        return $this;
    }

    /**
     * @return string
     */
    public function getCapital()
    {
        return $this->capital;
    }

    /**
     * @param string $capital
     *
     * @return $this
     */
    public function setCapital($capital)
    {
        $this->capital = $capital;

        return $this;
    }

    /**
     * @return string
     */
    public function getTimezone()
    {
        return $this->timezone;
    }

    /**
     * @param string $timezone
     *
     * @return $this
     */
    public function setTimezone($timezone)
    {
        $this->timezone = $timezone;

        return $this;
    }

    /**
     * @return string
     */
    public function getNorth()
    {
        return $this->north;
    }

    /**
     * @param string $north
     *
     * @return $this
     */
    public function setNorth($north)
    {
        $this->getBoundingBox()->setNorth($north);
        $this->north = $north;

        return $this;
    }

    /**
     * @return string
     */
    public function getEast()
    {
        return $this->east;
    }

    /**
     * @param string $east
     *
     * @return $this
     */
    public function setEast($east)
    {
        $this->getBoundingBox()->setEast($east);
        $this->east = $east;

        return $this;
    }

    /**
     * @return string
     */
    public function getSouth()
    {
        return $this->south;
    }

    /**
     * @param string $south
     *
     * @return $this
     */
    public function setSouth($south)
    {
        $this->getBoundingBox()->setSouth($south);
        $this->south = $south;

        return $this;
    }

    /**
     * @return string
     */
    public function getWest()
    {
        return $this->west;
    }

    /**
     * @param string $west
     *
     * @return $this
     */
    public function setWest($west)
    {
        $this->getBoundingBox()->setWest($west);
        $this->west = $west;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function normalizeLatitude($latitude)
    {
        return $this->coordinate->normalizeLatitude($latitude);
    }

    /**
     * {@inheritdoc}
     */
    public function normalizeLongitude($longitude)
    {
        return $this->coordinate->normalizeLongitude($longitude);
    }

    /**
     * {@inheritdoc}
     */
    public function getEllipsoid()
    {
        return $this->coordinate->getEllipsoid();
    }
}


1			<?php
2
3			namespace GeoBase\Countries\Country;
4
5			use GeoBase\Countries\Coordinate\CoordinateCollectionInterface;
6			use GeoBase\Countries\Coordinate\CoordinateLogic;
7			use GeoBase\Countries\Country\CountryName\CountryNameCollection;
8			use GeoBase\Regions\Region\RegionCollection;
9			use JsonSerializable;
10			use League\Geotools\BoundingBox\BoundingBox;
11			use League\Geotools\Coordinate\Coordinate;
12			use League\Geotools\Polygon\Polygon;
13
14			class CountryEntity extends CoordinateLogic implements JsonSerializable, CoordinateCollectionInterface
15			{
16			/**
17			* @var Coordinate
18			*/
19			protected $coordinate;
20
21			/**
22			* @var BoundingBox
23			*/
24			protected $boundingBox;
25
26			/**
27			* @var RegionCollection
28			*/
29			protected $regions;
30
31			/**
32			* @var Polygon
33			*/
34			protected $polygon;
35
36			/**
37			* @var CountryNameCollection
38			*/
39			protected $names;
40
41			/**
42			* @var string
43			*/
44			protected $shortCode;
45
46			/**
47			* @var string
48			*/
49			protected $code;
50
51			/**
52			* @var string
53			*/
54			protected $latitude;
55
56			/**
57			* @var string
58			*/
59			protected $longitude;
60
61			/**
62			* @var string
63			*/
64			protected $currency;
65
66			/**
67			* @var string
68			*/
69			protected $continent;
70
71			/**
72			* @var string
73			*/
74			protected $population;
75
76			/**
77			* @var string
78			*/
79			protected $area;
80
81			/**
82			* @var string
83			*/
84			protected $capital;
85
86			/**
87			* @var string
88			*/
89			protected $timezone;
90
91			/**
92			* @var string
93			*/
94			protected $north;
95
96			/**
97			* @var string
98			*/
99			protected $east;
100
101			/**
102			* @var string
103			*/
104			protected $south;
105
106			/**
107			* @var string
108			*/
109			protected $west;
110
111	4	View Code Duplication	public function __construct()
			0 ignored issues – show Duplication introduced 2017-03-06 21:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112			{
113	4		$this->boundingBox = new BoundingBox();
114	4		$this->regions = new RegionCollection();
115	4		$this->polygon = new Polygon();
116	4		$this->coordinate = new Coordinate([
117	4		$this->latitude,
118	4		$this->longitude,
119			]);
120	4		$this->setNames(new CountryNameCollection());
121	4		}
122
123			/**
124			* @return array
125			*/
126			public function toArray()
127			{
128			return [
129			'names' => $this->getNames(),
130			'short_code' => $this->getShortCode(),
131			'code' => $this->getCode(),
132			'latitude' => $this->getLatitude(),
133			'longitude' => $this->getLongitude(),
134			'currency' => $this->getCurrency(),
135			'continent' => $this->getContinent(),
136			'population' => $this->getPopulation(),
137			'area' => $this->getArea(),
138			'capital' => $this->getCapital(),
139			'timezone' => $this->getTimezone(),
140			'north' => $this->getNorth(),
141			'east' => $this->getEast(),
142			'south' => $this->getSouth(),
143			'west' => $this->getWest(),
144			];
145			}
146
147			/**
148			* @return array
149			*/
150			public function jsonSerialize()
151			{
152			return $this->toArray();
153			}
154
155			/**
156			* @return Coordinate
157			*/
158	4		public function getCoordinate()
159			{
160	4		return $this->coordinate;
161			}
162
163			/**
164			* @param Coordinate $coordinate
165			*
166			* @return $this
167			*/
168			public function setCoordinate(Coordinate $coordinate)
169			{
170			$this->coordinate = $coordinate;
171
172			return $this;
173			}
174
175			/**
176			* @return BoundingBox
177			*/
178	4		public function getBoundingBox()
179			{
180	4		return $this->boundingBox;
181			}
182
183			/**
184			* @param BoundingBox $boundingBox
185			*
186			* @return $this
187			*/
188			public function setBoundingBox(BoundingBox $boundingBox)
189			{
190			$this->boundingBox = $boundingBox;
191
192			return $this;
193			}
194
195			/**
196			* @return RegionCollection
197			*/
198			public function getRegions()
199			{
200			return $this->regions;
201			}
202
203			/**
204			* @param RegionCollection $regions
205			*
206			* @return $this
207			*/
208			public function setRegions(RegionCollection $regions)
209			{
210			$this->regions = $regions;
211
212			return $this;
213			}
214
215			/**
216			* @return Polygon
217			*/
218			public function getPolygon()
219			{
220			return $this->polygon;
221			}
222
223			/**
224			* @param Polygon $polygon
225			*
226			* @return $this
227			*/
228			public function setPolygon(Polygon $polygon)
229			{
230			$this->polygon = $polygon;
231
232			return $this;
233			}
234
235			/**
236			* @return CountryNameCollection
237			*/
238	4		public function getNames()
239			{
240	4		return $this->names;
241			}
242
243			/**
244			* @param CountryNameCollection $names
245			*
246			* @return $this
247			*/
248	4		public function setNames(CountryNameCollection $names)
249			{
250	4		$this->names = $names;
251
252	4		return $this;
253			}
254
255			/**
256			* @return string
257			*/
258			public function getShortCode()
259			{
260			return $this->shortCode;
261			}
262
263			/**
264			* @param string $shortCode
265			*
266			* @return $this
267			*/
268	4		public function setShortCode($shortCode)
269			{
270	4		$this->shortCode = $shortCode;
271
272	4		return $this;
273			}
274
275			/**
276			* @return string
277			*/
278	3		public function getCode()
279			{
280	3		return $this->code;
281			}
282
283			/**
284			* @param string $code
285			*
286			* @return $this
287			*/
288	4		public function setCode($code)
289			{
290	4		$this->code = $code;
291
292	4		return $this;
293			}
294
295			/**
296			* @return string
297			*/
298			public function getLatitude()
299			{
300			return $this->latitude;
301			}
302
303			/**
304			* @param string $latitude
305			*
306			* @return $this
307			*/
308	4		public function setLatitude($latitude)
309			{
310	4		$this->getCoordinate()->setLatitude($latitude);
311	4		$this->latitude = $latitude;
312
313	4		return $this;
314			}
315
316			/**
317			* @return string
318			*/
319			public function getLongitude()
320			{
321			return $this->longitude;
322			}
323
324			/**
325			* @param string $longitude
326			*
327			* @return $this
328			*/
329	4		public function setLongitude($longitude)
330			{
331	4		$this->getCoordinate()->setLongitude($longitude);
332	4		$this->longitude = $longitude;
333
334	4		return $this;
335			}
336
337			/**
338			* @return string
339			*/
340			public function getCurrency()
341			{
342			return $this->currency;
343			}
344
345			/**
346			* @param string $currency
347			*
348			* @return $this
349			*/
350	4		public function setCurrency($currency)
351			{
352	4		$this->currency = $currency;
353
354	4		return $this;
355			}
356
357			/**
358			* @return string
359			*/
360			public function getContinent()
361			{
362			return $this->continent;
363			}
364
365			/**
366			* @param string $continent
367			*
368			* @return $this
369			*/
370	4		public function setContinent($continent)
371			{
372	4		$this->continent = $continent;
373
374	4		return $this;
375			}
376
377			/**
378			* @return string
379			*/
380			public function getPopulation()
381			{
382			return $this->population;
383			}
384
385			/**
386			* @param string $population
387			*
388			* @return $this
389			*/
390	4		public function setPopulation($population)
391			{
392	4		$this->population = $population;
393
394	4		return $this;
395			}
396
397			/**
398			* @return string
399			*/
400			public function getArea()
401			{
402			return $this->area;
403			}
404
405			/**
406			* @param string $area
407			*
408			* @return $this
409			*/
410	4		public function setArea($area)
411			{
412	4		$this->area = $area;
413
414	4		return $this;
415			}
416
417			/**
418			* @return string
419			*/
420			public function getCapital()
421			{
422			return $this->capital;
423			}
424
425			/**
426			* @param string $capital
427			*
428			* @return $this
429			*/
430	4		public function setCapital($capital)
431			{
432	4		$this->capital = $capital;
433
434	4		return $this;
435			}
436
437			/**
438			* @return string
439			*/
440			public function getTimezone()
441			{
442			return $this->timezone;
443			}
444
445			/**
446			* @param string $timezone
447			*
448			* @return $this
449			*/
450	4		public function setTimezone($timezone)
451			{
452	4		$this->timezone = $timezone;
453
454	4		return $this;
455			}
456
457			/**
458			* @return string
459			*/
460			public function getNorth()
461			{
462			return $this->north;
463			}
464
465			/**
466			* @param string $north
467			*
468			* @return $this
469			*/
470	4		public function setNorth($north)
471			{
472	4		$this->getBoundingBox()->setNorth($north);
473	4		$this->north = $north;
474
475	4		return $this;
476			}
477
478			/**
479			* @return string
480			*/
481			public function getEast()
482			{
483			return $this->east;
484			}
485
486			/**
487			* @param string $east
488			*
489			* @return $this
490			*/
491	4		public function setEast($east)
492			{
493	4		$this->getBoundingBox()->setEast($east);
494	4		$this->east = $east;
495
496	4		return $this;
497			}
498
499			/**
500			* @return string
501			*/
502			public function getSouth()
503			{
504			return $this->south;
505			}
506
507			/**
508			* @param string $south
509			*
510			* @return $this
511			*/
512	4		public function setSouth($south)
513			{
514	4		$this->getBoundingBox()->setSouth($south);
515	4		$this->south = $south;
516
517	4		return $this;
518			}
519
520			/**
521			* @return string
522			*/
523			public function getWest()
524			{
525			return $this->west;
526			}
527
528			/**
529			* @param string $west
530			*
531			* @return $this
532			*/
533	4		public function setWest($west)
534			{
535	4		$this->getBoundingBox()->setWest($west);
536	4		$this->west = $west;
537
538	4		return $this;
539			}
540
541			/**
542			* {@inheritdoc}
543			*/
544			public function normalizeLatitude($latitude)
545			{
546			return $this->coordinate->normalizeLatitude($latitude);
547			}
548
549			/**
550			* {@inheritdoc}
551			*/
552			public function normalizeLongitude($longitude)
553			{
554			return $this->coordinate->normalizeLongitude($longitude);
555			}
556
557			/**
558			* {@inheritdoc}
559			*/
560			public function getEllipsoid()
561			{
562			return $this->coordinate->getEllipsoid();
563			}
564			}
565

geobase / php-countries

CountryEntity B last analyzed 2017-03-06 21:53 UTC