Issues in Server.php (master) - Issues in master - genkgo/mail - Measure and Improve Code Quality continuously with Scrutinizer

Issues (74)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Protocol/Smtp/Server.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace Genkgo\Mail\Protocol\Smtp;

use Genkgo\Mail\Exception\ConnectionBrokenException;
use Genkgo\Mail\Exception\ConnectionTimeoutException;
use Genkgo\Mail\Exception\ConnectionClosedException;
use Genkgo\Mail\Exception\UnknownSmtpCommandException;
use Genkgo\Mail\Protocol\AppendCrlfConnection;
use Genkgo\Mail\Protocol\ConnectionInterface;
use Genkgo\Mail\Protocol\ConnectionListenerInterface;
use Genkgo\Mail\Protocol\Smtp\Capability\EhloCapability;
use Genkgo\Mail\Protocol\Smtp\Capability\QuitCapability;
use Genkgo\Mail\Protocol\Smtp\Capability\ResetCapability;
use Genkgo\Mail\Protocol\TrimCrlfConnection;

final class Server
{
    /**
     * @var ConnectionListenerInterface
     */
    private $listener;

    /**
     * @var CapabilityInterface[]
     */
    private $capabilities = [];

    /**
     * @var string
     */
    private $serverName;

    /**
     * @param ConnectionListenerInterface $connection
     * @param array|CapabilityInterface[] $capabilities
     * @param string $serverName
     */
    public function __construct(ConnectionListenerInterface $connection, array $capabilities, string $serverName)
    {
        $this->listener = $connection;
        $this->serverName = $serverName;

        $this->capabilities = \array_merge(

            $capabilities,
            [
                new EhloCapability($this->serverName, $capabilities),
                new QuitCapability(),
                new ResetCapability()
            ]
        );
    }
    
    public function start(): void
    {
        while ($connection = $this->listener->listen()) {
            $connection = new TrimCrlfConnection(new AppendCrlfConnection($connection));
            $connection->send('220 Welcome to Genkgo Mail Server');

            $this->transport(
                $connection,
                function (ConnectionInterface $connection) {
                    $session = new Session();

                    while ($session = $session->withCommand($connection->receive())) {
                        try {
                            $session = $this->handleCommand($connection, $session);
                        } catch (UnknownSmtpCommandException $e) {
                            $connection->send('500 unrecognized command');
                        }

                        if ($session->getState() === Session::STATE_DISCONNECT) {
                            break;
                        }
                    }
                }
            );
        }
    }

    /**
     * @param ConnectionInterface $connection
     * @param \Closure $callback
     */
    private function transport(ConnectionInterface $connection, \Closure $callback): void
    {
        try {
            $callback($connection);
        } catch (ConnectionTimeoutException $e) {
            $connection->send('421 command timeout - closing connection');
            $connection->disconnect();
        } catch (ConnectionBrokenException $e) {
            try {
                $connection->send('554 transaction failed, unexpected value - closing connection');
            } catch (\Exception $e) {

            }

            $connection->disconnect();
        } catch (ConnectionClosedException $e) {
            $connection->disconnect();
        }
    }

    /**
     * @param ConnectionInterface $connection
     * @param Session $session
     * @return Session
     * @throws UnknownSmtpCommandException
     */
    private function handleCommand(ConnectionInterface $connection, Session $session): Session
    {
        $command = $session->getCommand();

        foreach ($this->capabilities as $capability) {
            $advertised = $capability->advertise();
            if (\substr($command, 0, \strlen($advertised)) === $advertised) {
                return $capability->manifest($connection, $session);
            }
        }

        throw new UnknownSmtpCommandException('Cannot handle command');
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Genkgo\Mail\Protocol\Smtp;
5
6		use Genkgo\Mail\Exception\ConnectionBrokenException;
7		use Genkgo\Mail\Exception\ConnectionTimeoutException;
8		use Genkgo\Mail\Exception\ConnectionClosedException;
9		use Genkgo\Mail\Exception\UnknownSmtpCommandException;
10		use Genkgo\Mail\Protocol\AppendCrlfConnection;
11		use Genkgo\Mail\Protocol\ConnectionInterface;
12		use Genkgo\Mail\Protocol\ConnectionListenerInterface;
13		use Genkgo\Mail\Protocol\Smtp\Capability\EhloCapability;
14		use Genkgo\Mail\Protocol\Smtp\Capability\QuitCapability;
15		use Genkgo\Mail\Protocol\Smtp\Capability\ResetCapability;
16		use Genkgo\Mail\Protocol\TrimCrlfConnection;
17
18		final class Server
19		{
20		/**
21		* @var ConnectionListenerInterface
22		*/
23		private $listener;
24
25		/**
26		* @var CapabilityInterface[]
27		*/
28		private $capabilities = [];
29
30		/**
31		* @var string
32		*/
33		private $serverName;
34
35		/**
36		* @param ConnectionListenerInterface $connection
37		* @param array\|CapabilityInterface[] $capabilities
38		* @param string $serverName
39		*/
40	6	public function __construct(ConnectionListenerInterface $connection, array $capabilities, string $serverName)
41		{
42	6	$this->listener = $connection;
43	6	$this->serverName = $serverName;
44
45	6	$this->capabilities = \array_merge(
		0 ignored issues – show Documentation Bug introduced 2018-03-04 16:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\array_merge($capabiliti...ity\ResetCapability()))` of type `array` is incompatible with the declared type `array<integer,object<Gen...p\CapabilityInterface>>` of property `$capabilities`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
46	6	$capabilities,
47		[
48	6	new EhloCapability($this->serverName, $capabilities),
49	6	new QuitCapability(),
50	6	new ResetCapability()
51		]
52		);
53	6	}
54
55	6	public function start(): void
56		{
57	6	while ($connection = $this->listener->listen()) {
58	6	$connection = new TrimCrlfConnection(new AppendCrlfConnection($connection));
59	6	$connection->send('220 Welcome to Genkgo Mail Server');
60
61	6	$this->transport(
62	6	$connection,
63		function (ConnectionInterface $connection) {
64	6	$session = new Session();
65
66	6	while ($session = $session->withCommand($connection->receive())) {
67		try {
68	2	$session = $this->handleCommand($connection, $session);
69	1	} catch (UnknownSmtpCommandException $e) {
70	1	$connection->send('500 unrecognized command');
71		}
72
73	2	if ($session->getState() === Session::STATE_DISCONNECT) {
74	2	break;
75		}
76		}
77	6	}
78		);
79		}
80		}
81
82		/**
83		* @param ConnectionInterface $connection
84		* @param \Closure $callback
85		*/
86	6	private function transport(ConnectionInterface $connection, \Closure $callback): void
87		{
88		try {
89	6	$callback($connection);
90	4	} catch (ConnectionTimeoutException $e) {
91	1	$connection->send('421 command timeout - closing connection');
92	1	$connection->disconnect();
93	3	} catch (ConnectionBrokenException $e) {
94		try {
95	2	$connection->send('554 transaction failed, unexpected value - closing connection');
96	1	} catch (\Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-11 12:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
97		}
98
99	2	$connection->disconnect();
100	1	} catch (ConnectionClosedException $e) {
101	1	$connection->disconnect();
102		}
103	6	}
104
105		/**
106		* @param ConnectionInterface $connection
107		* @param Session $session
108		* @return Session
109		* @throws UnknownSmtpCommandException
110		*/
111	2	private function handleCommand(ConnectionInterface $connection, Session $session): Session
112		{
113	2	$command = $session->getCommand();
114
115	2	foreach ($this->capabilities as $capability) {
116	2	$advertised = $capability->advertise();
117	2	if (\substr($command, 0, \strlen($advertised)) === $advertised) {
118	2	return $capability->manifest($connection, $session);
119		}
120		}
121
122	1	throw new UnknownSmtpCommandException('Cannot handle command');
123		}
124		}
125

genkgo / mail

Issues (74)

Security Analysis no request data

src/Protocol/Smtp/Server.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like