Issues in AutomaticConnection.php (master) - Issues in master - genkgo/mail - Measure and Improve Code Quality continuously with Scrutinizer

Issues (74)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Protocol/AutomaticConnection.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace Genkgo\Mail\Protocol;

final class AutomaticConnection implements ConnectionInterface
{
    /**
     * @var ConnectionInterface
     */
    private $decoratedConnection;

    /**
     * @var \DateTimeImmutable|null
     */
    private $connectedAt;

    /**
     * @var \DateInterval
     */
    private $interval;

    /**
     * @var bool
     */
    private $connecting = false;

    /**
     * @param ConnectionInterface $decoratedConnection
     * @param \DateInterval $interval
     */
    public function __construct(ConnectionInterface $decoratedConnection, \DateInterval $interval)
    {
        $this->decoratedConnection = $decoratedConnection;
        $this->interval = $interval;
    }

    /**
     * @param string $name
     * @param \Closure $callback
     */
    public function addListener(string $name, \Closure $callback): void
    {
        $this->decoratedConnection->addListener($name, $callback);
    }

    /**
     * @return void
     */
    public function connect(): void
    {
        if ($this->connecting === false) {
            try {
                $this->connecting = true;
                $this->decoratedConnection->connect();
                $this->connectedAt = new \DateTimeImmutable('now');
            } finally {
                $this->connecting = false;
            }
        }
    }

    /**
     * @return void
     */
    public function disconnect(): void
    {
        $this->decoratedConnection->disconnect();
        $this->connectedAt = null;
    }

    /**
     * @param string $request
     * @return int
     */
    public function send(string $request): int
    {
        $this->connectIfNotConnected();
        return $this->decoratedConnection->send($request);
    }

    /**
     * @return string
     */
    public function receive(): string
    {
        $this->connectIfNotConnected();
        return $this->decoratedConnection->receive();
    }

    /**
     * @param int $type
     */
    public function upgrade(int $type): void
    {
        $this->decoratedConnection->upgrade($type);
    }

    /**
     * @param float $timeout
     */
    public function timeout(float $timeout): void
    {
        $this->decoratedConnection->timeout($timeout);
    }

    /**
     * @param array<int, string> $keys
     * @return array<string, mixed>

     */
    public function getMetaData(array $keys = []): array
    {
        return $this->decoratedConnection->getMetaData($keys);
    }
    
    private function connectIfNotConnected(): void
    {
        if ($this->connectedAt === null) {
            $this->connect();
        }

        $now = new \DateTimeImmutable();
        if ($this->connecting === false && $this->connectedAt && $this->connectedAt->add($this->interval) < $now) {
            $this->disconnect();
            $this->connect();
        }
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Genkgo\Mail\Protocol;
5
6		final class AutomaticConnection implements ConnectionInterface
7		{
8		/**
9		* @var ConnectionInterface
10		*/
11		private $decoratedConnection;
12
13		/**
14		* @var \DateTimeImmutable\|null
15		*/
16		private $connectedAt;
17
18		/**
19		* @var \DateInterval
20		*/
21		private $interval;
22
23		/**
24		* @var bool
25		*/
26		private $connecting = false;
27
28		/**
29		* @param ConnectionInterface $decoratedConnection
30		* @param \DateInterval $interval
31		*/
32	17	public function __construct(ConnectionInterface $decoratedConnection, \DateInterval $interval)
33		{
34	17	$this->decoratedConnection = $decoratedConnection;
35	17	$this->interval = $interval;
36	17	}
37
38		/**
39		* @param string $name
40		* @param \Closure $callback
41		*/
42	15	public function addListener(string $name, \Closure $callback): void
43		{
44	15	$this->decoratedConnection->addListener($name, $callback);
45	15	}
46
47		/**
48		* @return void
49		*/
50	17	public function connect(): void
51		{
52	17	if ($this->connecting === false) {
53		try {
54	17	$this->connecting = true;
55	17	$this->decoratedConnection->connect();
56	8	$this->connectedAt = new \DateTimeImmutable('now');
57	8	} finally {
58	17	$this->connecting = false;
59		}
60		}
61	8	}
62
63		/**
64		* @return void
65		*/
66	2	public function disconnect(): void
67		{
68	2	$this->decoratedConnection->disconnect();
69	2	$this->connectedAt = null;
70	2	}
71
72		/**
73		* @param string $request
74		* @return int
75		*/
76	15	public function send(string $request): int
77		{
78	15	$this->connectIfNotConnected();
79	7	return $this->decoratedConnection->send($request);
80		}
81
82		/**
83		* @return string
84		*/
85	7	public function receive(): string
86		{
87	7	$this->connectIfNotConnected();
88	7	return $this->decoratedConnection->receive();
89		}
90
91		/**
92		* @param int $type
93		*/
94	1	public function upgrade(int $type): void
95		{
96	1	$this->decoratedConnection->upgrade($type);
97	1	}
98
99		/**
100		* @param float $timeout
101		*/
102	1	public function timeout(float $timeout): void
103		{
104	1	$this->decoratedConnection->timeout($timeout);
105	1	}
106
107		/**
108		* @param array<int, string> $keys
109		* @return array<string, mixed>
		0 ignored issues – show Documentation introduced 2020-02-28 13:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `array<string,` could not be parsed: Expected ">" at position 5, but found "end of type". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
110		*/
111	1	public function getMetaData(array $keys = []): array
112		{
113	1	return $this->decoratedConnection->getMetaData($keys);
114		}
115
116	16	private function connectIfNotConnected(): void
117		{
118	16	if ($this->connectedAt === null) {
119	14	$this->connect();
120		}
121
122	8	$now = new \DateTimeImmutable();
123	8	if ($this->connecting === false && $this->connectedAt && $this->connectedAt->add($this->interval) < $now) {
124	1	$this->disconnect();
125	1	$this->connect();
126		}
127	8	}
128		}
129

genkgo / mail

Issues (74)

Security Analysis no request data

src/Protocol/AutomaticConnection.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like