ImapTransport::send() - Code Metrics - Inspection of "Implement imap client" - genkgo/mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Frederik

created 2018-03-02 22:09 UTC

ImapTransport::send() A

↳ Parent: ImapTransport

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	13
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	1
crap	2

<?php
declare(strict_types=1);

namespace Genkgo\Mail\Transport;

use Genkgo\Mail\MessageInterface;
use Genkgo\Mail\Protocol\Imap\Client;
use Genkgo\Mail\Protocol\Imap\ParenthesizedList;
use Genkgo\Mail\Protocol\Imap\Request\AppendCommand;
use Genkgo\Mail\Protocol\Imap\Request\AppendDataRequest;
use Genkgo\Mail\Protocol\Imap\Response\CompletionResult;
use Genkgo\Mail\TransportInterface;

final class ImapTransport implements TransportInterface
{
    /**
     * @var Client
     */
    private $client;
    /**
     * @var string
     */
    private $mailbox;

    /**
     * SmtpTransport constructor.
     * @param Client $client
     * @param string $inbox
     */
    public function __construct(
        Client $client,
        string $inbox
    ) {
        $this->client = $client;
        $this->mailbox = $inbox;
    }

    /**
     * @param MessageInterface $message
     * @return void
     */
    public function send(MessageInterface $message): void
    {
        $tag = $this->client->newTag();

        $this->client
            ->emit(new AppendCommand($tag, $this->mailbox, strlen((string)$message), new ParenthesizedList()))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->last()
            ->assertContinuation();

        $this->client
            ->emit(new AppendDataRequest($tag, $message))
            ->last()
            ->assertCompletion(CompletionResult::ok())
            ->assertTagged();
    }
}

1			<?php
2			declare(strict_types=1);
3
4			namespace Genkgo\Mail\Transport;
5
6			use Genkgo\Mail\MessageInterface;
7			use Genkgo\Mail\Protocol\Imap\Client;
8			use Genkgo\Mail\Protocol\Imap\ParenthesizedList;
9			use Genkgo\Mail\Protocol\Imap\Request\AppendCommand;
10			use Genkgo\Mail\Protocol\Imap\Request\AppendDataRequest;
11			use Genkgo\Mail\Protocol\Imap\Response\CompletionResult;
12			use Genkgo\Mail\TransportInterface;
13
14			final class ImapTransport implements TransportInterface
15			{
16			/**
17			* @var Client
18			*/
19			private $client;
20			/**
21			* @var string
22			*/
23			private $mailbox;
24
25			/**
26			* SmtpTransport constructor.
27			* @param Client $client
28			* @param string $inbox
29			*/
30			public function __construct(
31			Client $client,
32			string $inbox
33			) {
34			$this->client = $client;
35			$this->mailbox = $inbox;
36			}
37
38			/**
39			* @param MessageInterface $message
40			* @return void
41			*/
42			public function send(MessageInterface $message): void
43			{
44			$tag = $this->client->newTag();
45
46			$this->client
47			->emit(new AppendCommand($tag, $this->mailbox, strlen((string)$message), new ParenthesizedList()))
			0 ignored issues – show Documentation introduced 2018-02-18 21:12 UTC by Report Bug Copy Issue Report `new \Genkgo\Mail\Protocol\Imap\ParenthesizedList()` is of type `object<Genkgo\Mail\Proto...Imap\ParenthesizedList>`, but the function expects a `null\|object<Genkgo\Mail\...\FlagParenthesizedList>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-02-19 09:51 UTC by Report Bug Copy Issue Report `$this->mailbox` is of type `string`, but the function expects a `object<Genkgo\Mail\Protocol\Imap\MailboxName>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			->last()
49			->assertContinuation();
50
51			$this->client
52			->emit(new AppendDataRequest($tag, $message))
53			->last()
54			->assertCompletion(CompletionResult::ok())
55			->assertTagged();
56			}
57			}

genkgo / mail

Pull Request — master (#42)

ImapTransport::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like