SectionList::fromString() - Code Metrics - Inspection of "Implement imap client" - genkgo/mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

by Frederik

created 2018-03-03 13:21 UTC

SectionList::fromString() D

↳ Parent: SectionList

Complexity

Conditions	9
Paths	6

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	9

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	19
cts	19
cp	1
rs	4.909
c	0
b	0
f	0
cc	9
eloc	20
nc	6
nop	1
crap	9

<?php
declare(strict_types=1);

namespace Genkgo\Mail\Protocol\Imap\MessageData;

/**
 * Class SectionList
 * @package Genkgo\Mail\Protocol\Imap\MessageData
 */
final class SectionList
{
    /**
     *
     */
    private CONST RFC_3501_SECTION_FIXED = [
        'HEADER' => true,
        'TEXT' => true,
    ];

    /**
     * @var array
     */
    private $sections = [];

    /**
     * SectionList constructor.
     * @param array $sections
     */
    public function __construct(array $sections = [])
    {
        foreach ($sections as $section) {
            $this->validateSection($section);
        }

        $this->sections = $sections;
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        return sprintf(
            '[%s]',
            implode(' ', $this->sections)
        );
    }

    /**
     * @param string $sections
     * @return SectionList
     */
    public static function fromString(string $sections): self
    {
        $result = preg_match('/^\[(.*?)\]$/', $sections, $matches);
        if ($result !== 1) {
            throw new \InvalidArgumentException('No section list');
        }

        $sections = array_filter(explode(' ', $matches[1]));
        for ($i = 0; $i < count($sections); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            if ($sections[$i] === 'HEADER.FIELDS' || $sections[$i] === 'HEADER.FIELDS.NOT') {
                if (!isset($sections[$i + 1][0]) || $sections[$i + 1][0] !== '(') {
                    throw new \InvalidArgumentException(
                        'HEADER.FIELDS or HEADER.FIELDS.NOT requires header-list'
                    );
                }

                $appendIndex = $i;
                $i++;
                do {
                    $sections[$appendIndex] .= ' ' . $sections[$i];
                    unset($sections[$i]);
                    $i++;

                    if (substr($sections[$appendIndex], -1) === ')') {
                        break;
                    }
                } while (isset($sections[$i]));
            }
        }

        return new self($sections);
    }

    /**
     * @param string $section
     */
    private function validateSection(string $section): void
    {
        if ($section === '') {
            throw new \InvalidArgumentException('Empty section');
        }

        if (isset(self::RFC_3501_SECTION_FIXED[$section])) {
            return;
        }

        if (preg_match('/^HEADER.FIELDS(\.NOT)? \((.*?)\)$/', $section) === 1) {
            return;
        }

        throw new \InvalidArgumentException('Invalid section item ' . $section);
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Genkgo\Mail\Protocol\Imap\MessageData;
5
6		/**
7		* Class SectionList
8		* @package Genkgo\Mail\Protocol\Imap\MessageData
9		*/
10		final class SectionList
11		{
12		/**
13		*
14		*/
15		private CONST RFC_3501_SECTION_FIXED = [
16		'HEADER' => true,
17		'TEXT' => true,
18		];
19
20		/**
21		* @var array
22		*/
23		private $sections = [];
24
25		/**
26		* SectionList constructor.
27		* @param array $sections
28		*/
29	17	public function __construct(array $sections = [])
30		{
31	17	foreach ($sections as $section) {
32	12	$this->validateSection($section);
33		}
34
35	13	$this->sections = $sections;
36	13	}
37
38		/**
39		* @return string
40		*/
41	11	public function __toString(): string
42		{
43	11	return sprintf(
44	11	'[%s]',
45	11	implode(' ', $this->sections)
46		);
47		}
48
49		/**
50		* @param string $sections
51		* @return SectionList
52		*/
53	8	public static function fromString(string $sections): self
54		{
55	8	$result = preg_match('/^\[(.*?)\]$/', $sections, $matches);
56	8	if ($result !== 1) {
57	1	throw new \InvalidArgumentException('No section list');
58		}
59
60	7	$sections = array_filter(explode(' ', $matches[1]));
61	7	for ($i = 0; $i < count($sections); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2018-02-18 21:12 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
62	6	if ($sections[$i] === 'HEADER.FIELDS' \|\| $sections[$i] === 'HEADER.FIELDS.NOT') {
63	3	if (!isset($sections[$i + 1][0]) \|\| $sections[$i + 1][0] !== '(') {
64	2	throw new \InvalidArgumentException(
65	2	'HEADER.FIELDS or HEADER.FIELDS.NOT requires header-list'
66		);
67		}
68
69	1	$appendIndex = $i;
70	1	$i++;
71		do {
72	1	$sections[$appendIndex] .= ' ' . $sections[$i];
73	1	unset($sections[$i]);
74	1	$i++;
75
76	1	if (substr($sections[$appendIndex], -1) === ')') {
77	1	break;
78		}
79	1	} while (isset($sections[$i]));
80		}
81		}
82
83	5	return new self($sections);
84		}
85
86		/**
87		* @param string $section
88		*/
89	12	private function validateSection(string $section): void
90		{
91	12	if ($section === '') {
92	1	throw new \InvalidArgumentException('Empty section');
93		}
94
95	11	if (isset(self::RFC_3501_SECTION_FIXED[$section])) {
96	5	return;
97		}
98
99	6	if (preg_match('/^HEADER.FIELDS(\.NOT)? \((.*?)\)$/', $section) === 1) {
100	3	return;
101		}
102
103	3	throw new \InvalidArgumentException('Invalid section item ' . $section);
104		}
105		}

genkgo / mail

Pull Request — master (#42)

SectionList::fromString() D

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like